Re: plasma-framework, kactivities and kactivities-stats: please consider proper de-KF-ication now

On dimanche 5 novembre 2023 18:01:38 CET Nate Graham wrote: > On 11/5/23 07:42, Kevin Ottens wrote: > > I was clumsily advocating for this Akademy 2021 or 2022 (can't remember > > which). > > > > This way it's clearer to application authors when they tie themselves to a > > given workspace or

D28980: Revert "add Baloo DBus signals for moved or removed files"

mgallien added a comment. In D28980#652256 , @bruns wrote: > In D28980#652102 , @mgallien wrote: > > > To be clear, I am fine with this change going in. > > > > I would still like to work on a

D28980: Revert "add Baloo DBus signals for moved or removed files"

mgallien accepted this revision. mgallien added a comment. This revision is now accepted and ready to land. To be clear, I am fine with this change going in. I would still like to work on a proper solution to allow an application to monitor moved files or similar stuff without having to

D28980: Revert "add Baloo DBus signals for moved or removed files"

mgallien added a comment. The unusual method to get notified is about avoiding signaling moved files if nobody is watching. Baloo will only callback if applications have registered themselves. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D28980 To: bruns, #baloo,

D28980: Revert "add Baloo DBus signals for moved or removed files"

mgallien added a comment. Sorry for the lack of time to do a proper review. I will need to have a thorough look at what Elisa is currently doing and what is working (or not). Is there another working way to get information about files that have moved without having an application

D28682: export done signal in filecontentindexer

mgallien added a comment. This is the reason why it is so slow in Elisa? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D28682 To: astippich, #baloo, bruns Cc: mgallien, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, GB_2, domson,

D21381: use org.freedesktop.appstream-glib package to validate appstream data

mgallien abandoned this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D21381 To: mgallien, aacid, yurchor, apol Cc: bcooksley, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

D26054: partial fix for accentuated characters in file name on Windows

This revision was automatically updated to reflect the committed changes. Closed by commit R286:8c066c834c64: partial fix for accentuated characters in file name on Windows (authored by mgallien). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

D26054: partial fix for accentuated characters in file name on Windows

mgallien updated this revision to Diff 71684. mgallien added a comment. sorry for the mess in the previous patch REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26054?vs=71683=71684 BRANCH fixWriterAccentuatedFileName REVISION DETAIL

D26054: partial fix for accentuated characters in file name on Windows

mgallien created this revision. mgallien added reviewers: bruns, astippich. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. mgallien requested review of this revision. REVISION SUMMARY partial fix to try to get accentuated file names to work with

D25622: partial solution to accept accentuated characters on windows

This revision was automatically updated to reflect the committed changes. Closed by commit R286:9220e5045687: partial solution to accept accentuated characters on windows (authored by mgallien). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

D25622: partial solution to accept accentuated characters on windows

mgallien added a comment. I forgot to maybe give some explanations. The documentation of the constructor of TagLib::FileStream takes a char* and "file should be a be a C-string in the local file system encoding". This means that the proper fix would possibly involve doing changes in

D25622: partial solution to accept accentuated characters on windows

mgallien added a reviewer: bruns. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D25622 To: mgallien, bruns Cc: kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham,

D25622: partial solution to accept accentuated characters on windows

mgallien created this revision. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. mgallien requested review of this revision. REVISION SUMMARY If filename contains accentuated characters, taglib fails to open it on windows if the QString is

D24598: Update elisa icon

mgallien accepted this revision. mgallien added a comment. Thanks REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24598 To: astippich, #vdg, ngraham, mgallien, trickyricky26 Cc: trickyricky26, GB_2, kde-frameworks-devel, stuartm, daerny, mfraser, mnesbitt,

D24598: Update elisa icon

mgallien added a comment. In D24598#546135 , @astippich wrote: > I have no intention on taking over D12992 as I would like rather like to code for Elisa. I am no designer. > I was unsatisfied with the

D24406: Small performance improvements suggested by clang tidy

mgallien accepted this revision. mgallien added a comment. This revision is now accepted and ready to land. Thanks REPOSITORY R286 KFileMetaData BRANCH master REVISION DETAIL https://phabricator.kde.org/D24406 To: aacid, mgallien Cc: mgallien, kde-frameworks-devel, #baloo, lots0logs,

D12992: New elisa icon

mgallien added a comment. In D12992#533180 , @lshoravi wrote: > Bumping @abetts Thanks for keeping this on your todo list. This is very much appreciated. I am trying to move forward the process of having Elisa published on Windows

D12992: New elisa icon

mgallien added a comment. In D12992#486880 , @lshoravi wrote: > Using @abetts prototype: No blockers, incorporating the given teal and green colours given by mgallien is TODO. > > Otherwise, the blocker would be to find what visual profile

D20526: fix extracting of some properties to match what was writen

mgallien added a comment. In D20526#483910 , @astippich wrote: > @mgallien Are you going to update? There are bug reports which will also be fixed by this, so it would be nice to get this in. > Or do you mind if I take over? I would

D21581: Detect valgrind, avoid database removal when using valgrind

mgallien accepted this revision. mgallien added a comment. This revision is now accepted and ready to land. Very nice. Thank you REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D21581 To: bruns, #baloo, ngraham, astippich, poboiko, broulik, mgallien

D21381: use org.freedesktop.appstream-glib package to validate appstream data

mgallien added a comment. In D21381#469617 , @apol wrote: > How about we test against both? I have just pushed a new diff to do that. I am not sure if it desirable to keep appstreamcli test given it fails to validate files that are

D21381: use org.freedesktop.appstream-glib package to validate appstream data

mgallien updated this revision to Diff 58628. mgallien added a comment. - use appstream-util and appstreamcli to validate appdata file REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21381?vs=58595=58628 BRANCH master REVISION DETAIL

D21381: use org.freedesktop.appstream-glib package to validate appstream data

mgallien created this revision. mgallien added reviewers: aacid, yurchor. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. mgallien requested review of this revision. REVISION SUMMARY should help having the same validation than

D21219: Don't try to index SQL database dumps

mgallien accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH dont-try-to-index-database-dumps (branched from master) REVISION DETAIL https://phabricator.kde.org/D21219 To: ngraham, #frameworks, bruns, mgallien Cc: kde-frameworks-devel,

D20526: fix extracting of some properties to match what was writen

mgallien created this revision. mgallien added reviewers: astippich, bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. mgallien requested review of this revision. REVISION SUMMARY Currently, one can write and read through taglib extractor

D20310: Use nullptr instead of NULL

mgallien accepted this revision. mgallien added a comment. This revision is now accepted and ready to land. Thanks REPOSITORY R286 KFileMetaData BRANCH nullptr REVISION DETAIL https://phabricator.kde.org/D20310 To: nicolasfella, #frameworks, bruns, mgallien, astippich Cc:

D20219: Propose Stefan Bruns as KFileMetaData maintainer

mgallien added subscribers: bruns, mgallien. mgallien accepted this revision. mgallien added a comment. This revision is now accepted and ready to land. Thanks for all the work going on. I am really happy to see all the work done by @bruns REPOSITORY R286 KFileMetaData BRANCH master

D16579: Remove support for non-standard APE tag field names from the test files

mgallien added a comment. In D16579#428835 , @smithjd wrote: > The change was ack'ed in this review, and this review closed by the commit. > > There was no code that required further review, only binary changes. The posted concerns were

Re: Power Management and Inhibition by Applications

ng to suspend has to check itself for any blocking inhibition for sleep. I can volunteer to add this to Powerdevil if this is deemed useful. I had checked the dbus interface for logind and there is still no any signals to know when an inhibition is added or removed. Best regards -- Matthieu Gallien

Re: Power Management and Inhibition by Applications

Hello, On samedi 19 janvier 2019 12:19:10 CET Elvis Angelaccio wrote: > On 16/01/19 22:07, Matthieu Gallien wrote: > > Hello, > > > > I am trying to work on a feature request to add the ability to suppress > > laptop sleep when playing music. > > > > Cu

Power Management and Inhibition by Applications

n also see some other features that could make sense to provide in libraries that music players could use (lyrics fetching, album art fetching, ...). This could be in a dedicated framework to help build media players. Best regards -- Matthieu Gallien

Power Management and Inhibition by Applications

n also see some other features that could make sense to provide in libraries that music players could use (lyrics fetching, album art fetching, ...). This could be in a dedicated framework to help build media players. Best regards -- Matthieu Gallien

D17500: Restore mobipocket extractor

mgallien added a comment. In D17500#376221 , @aacid wrote: > In D17500#375753 , @astippich wrote: > > > Oh, thanks for the hint, didn't know that. That makes it a lot more complicated than a

D17046: Use the new FindExiv2 module from ECM.

mgallien accepted this revision. mgallien added a comment. This revision is now accepted and ready to land. Please feel free to land this after solving my comment. INLINE COMMENTS > CMakeLists.txt:57 > -set_package_properties(Exiv2 PROPERTIES DESCRIPTION "Image Tag reader" > -

D16618: add explicit to constructors

mgallien accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH explicit REVISION DETAIL https://phabricator.kde.org/D16618 To: astippich, #frameworks, bruns, mgallien Cc: mgallien, kde-frameworks-devel, #baloo, ashaposhnikov,

D16618: add explicit to constructors

mgallien added inline comments. INLINE COMMENTS > simpleextractionresult.h:42 > public: > -SimpleExtractionResult(const QString& url, const QString& mimetype = > QString(), const Flags& flags = ExtractEverything); > +explicit SimpleExtractionResult(const QString& url, const QString& >

D16197: provide a list of supported mimetypes for embeddedimagedata

mgallien added inline comments. INLINE COMMENTS > embeddedimagedata.h:62 > + */ > +QStringList readMimetypes() const; > + You can make it static because you are returning a static member. It means that you should probably return by const reference (even if I do not remember if it is

D16163: refactor taglibextractor to functions specific for metadata type

mgallien added a comment. In D16163#342046 , @astippich wrote: > To be on the safe side here: I am allowed to modify private member functions regarding binary compatibility, right? This page is a very good reference:

D8532: [WIP] Restrict file extractor with Seccomp

mgallien added a comment. In D8532#289500 , @davidk wrote: > I was asked in private about the current state of libseccomp integration and why there was no progress in a long time. > The current state is, that I have implemented seccomp support

D15614: remove usage of own TString to QString conversion function

mgallien added a comment. In D15614#328722 , @astippich wrote: > The removal of the convertWCharsToQString function is safe, right? It was never exported It is a static function. So it is absolutely safe to remove it. REPOSITORY R286

D13700: implement reading of the replaygain tags

mgallien accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH replaygain REVISION DETAIL https://phabricator.kde.org/D13700 To: astippich, mgallien, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich,

D13700: implement reading of the replaygain tags

mgallien added a comment. Thanks for your hard work. This is a really nice addition to audio tags. I no longer have objections. Please finish to take into account feedback from @bruns. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D13700 To: astippich,

D13700: implement reading of the replaygain tags

mgallien requested changes to this revision. mgallien added a comment. This revision now requires changes to proceed. Some inline comments INLINE COMMENTS > taglibextractor.cpp:254-263 > +if(!strcmp( userTextFrame->description().toCString( true ), > "replaygain_track_gain" ) ) {

D13906: add missing include

mgallien accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH add_include REVISION DETAIL https://phabricator.kde.org/D13906 To: astippich, mgallien Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun,

D15013: balootctl: fix 396535

mgallien added a comment. In D15013#313880 , @jausmus wrote: > In D15013#313867 , @anthonyfieroni wrote: > > > Do not use QDir::separator > > > > if (!folder.endsWith(QLatin1Char('/')) { > >

D14131: Add enum alias Property::Language for typo Property::Langauge

mgallien accepted this revision. mgallien added a comment. This revision is now accepted and ready to land. Thanks for your work and good idea. REPOSITORY R286 KFileMetaData BRANCH fixLangaugeEnumTypoNow REVISION DETAIL https://phabricator.kde.org/D14131 To: kossebau, mgallien Cc:

D14131: Add enum alias Property::Language for typo Property::Langauge

mgallien added a comment. In D14131#294528 , @aacid wrote: > Looks good to me. If @mgallien doesn't give you an "accept" in a reasonable timeframe i guess you can count this as me accepting it ;) I am in holidays for 3 weeks and unable

D12950: add test which checks the property types

mgallien added a comment. Sorry for the delay on my side. Why are you adding this test ? REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12950 To: astippich, mgallien, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun,

D13914: Avoid compiler warnings for taglib headers

mgallien accepted this revision. mgallien added a comment. This revision is now accepted and ready to land. Thanks REPOSITORY R286 KFileMetaData BRANCH avoidtaglibheaderwarnings REVISION DETAIL https://phabricator.kde.org/D13914 To: kossebau, mgallien Cc: kde-frameworks-devel,

D13885: taglibextractor: Restore extracting audio props without tags existing

mgallien accepted this revision. mgallien added a comment. This revision is now accepted and ready to land. @kossebau thanks for your work on this patch @astippich thanks for your quick reaction and the work on this patch REPOSITORY R286 KFileMetaData BRANCH fix_empty_tags REVISION

D13630: automatic tests: do not embed EmbeddedImageData already in the library

This revision was automatically updated to reflect the committed changes. Closed by commit R286:aa90123a8c18: automatic tests: do not embed EmbeddedImageData already in the library (authored by mgallien). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

D12320: add ability to read embedded cover files

mgallien added a comment. D13630 should fix the Windows build. Sorry for not noticing this before. I was mostly away from keyboard for the last two weeks after having been sick. REPOSITORY R286 KFileMetaData REVISION DETAIL

D13630: automatic tests: do not embed EmbeddedImageData already in the library

mgallien created this revision. mgallien added reviewers: dfaure, bcooksley, bruns, astippich. Restricted Application added projects: Frameworks, Baloo. Restricted Application added subscribers: Baloo, kde-frameworks-devel. mgallien requested review of this revision. REVISION SUMMARY should fix

D13302: check for needed version of libavcode, libavformat and libavutil

This revision was automatically updated to reflect the committed changes. Closed by commit R286:461f8ec81b81: check for needed version of libavcode, libavformat and libavutil (authored by mgallien). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

Re: KDE Frameworks 5.47.0

ng understood that was the only feasible solution. > Cheers, > Albert > > > Jonathan Best regards -- Matthieu Gallien

D12992: New elisa icon

mgallien added a comment. In D12992#269849 , @abetts wrote: > In D12992#269803 , @lshoravi wrote: > > > @abetts Yes, I've been concepting a little on different ideas but not really coming anywhere

D13216: Overhaul the file index scheduler.

mgallien added a comment. Sounds good to me. I will try to do a proper review as soon as I can. Sorry for the delay. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13216 To: smithjd, bruns, mgallien Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh,

D13302: check for needed version of libavcode, libavformat and libavutil

mgallien updated this revision to Diff 35712. mgallien added a comment. - checks if FFmpeg provides the new API and use it only in this case extend the existing configure header to allow to compile both versions of the code in the FFmpeg extractor in case the new API exists, we

D13302: check for needed version of libavcode, libavformat and libavutil

mgallien updated this revision to Diff 35457. mgallien added a comment. - prefer usage of CHECK_STRUCT_HAS_MEMBER instead of having test code the test is shorter with CHECK_STRUCT_HAS_MEMBER (thanks @adridg for the help) REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

D13302: check for needed version of libavcode, libavformat and libavutil

mgallien retitled this revision from "[WIP] check for needed version of libavcode, libavformat and libavutil" to "check for needed version of libavcode, libavformat and libavutil". mgallien edited the test plan for this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL

D13302: [WIP] check for needed version of libavcode, libavformat and libavutil

mgallien updated this revision to Diff 35456. mgallien added a comment. - check AVStrean structure have codecpar member working check for codecpar member in AVStream structure should I try to make the result variable be not in the cmake cache ? REPOSITORY R286 KFileMetaData

D13302: [WIP] check for needed version of libavcode, libavformat and libavutil

mgallien created this revision. mgallien added reviewers: romangg, adridg. Restricted Application added projects: Frameworks, Baloo. Restricted Application added subscribers: Baloo, kde-frameworks-devel. mgallien requested review of this revision. REVISION SUMMARY check for needed version of

D12320: [RFC] add ability to read embedded cover files

mgallien added a comment. In D12320#272370 , @bruns wrote: > as the remaining issues are formatting only, this is an `accept` by me save the requested changes. > @mgallien - if i am late to accept, can you do it? Yes sure. I have just

D12320: [RFC] add ability to read embedded cover files

mgallien added a comment. In D12320#271300 , @astippich wrote: > any more comments? would be nice to ship it with Kf 5.48 @bruns you requested changes. Can you have a look when you have time ? REPOSITORY R286 KFileMetaData REVISION

D12156: implement reading of rating tag

mgallien accepted this revision. mgallien added a comment. This revision is now accepted and ready to land. I hope application developers will not complain about the need to support a second api to get ratings. I am still unsure this the best way to add this support. REPOSITORY R286

D12992: New elisa icon

mgallien added a subscriber: paullesur. mgallien added a comment. @januz and @astippich I really understand your point of view about the current icon. I share your point of view the need to have an icon easy to differentiate from many other players. For example, I would like Elisa be easy

D12156: implement reading of rating tag

mgallien added a subscriber: cgilles. mgallien added a comment. @cgilles Are you somehow using KFileMetaData (seems correct if one looks at the Debian package dependencies) ? This diff is about adding a way to read ratings from "tags" native to a specific file format. This would be in

D12992: New elisa icon

mgallien added subscribers: astippich, januz. mgallien added a comment. In D12992#266288 , @alex-l wrote: > F5863162: image.png > > ^ I'm for this one without the quaver I also prefer this one

D12578: fix some issues reported by clazy

This revision was automatically updated to reflect the committed changes. Closed by commit R293:f887468b172a: fix some issues reported by clazy (authored by mgallien). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12578?vs=34389=34390 REVISION DETAIL

D12578: fix some issues reported by clazy

mgallien marked an inline comment as done. mgallien added a comment. @bruns Thanks for the review and sorry for my slowness. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12578 To: mgallien, #baloo, #frameworks, bruns Cc: kde-frameworks-devel, bruns, ashaposhnikov,

D12578: fix some issues reported by clazy

mgallien updated this revision to Diff 34389. mgallien added a comment. - fix one more issue REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12578?vs=34223=34389 BRANCH arcpatch-D12578 REVISION DETAIL https://phabricator.kde.org/D12578 AFFECTED FILES

D12578: fix some issues reported by clazy

mgallien updated this revision to Diff 34223. mgallien added a comment. fix some issues REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12578?vs=33247=34223 BRANCH arcpatch-D12578 REVISION DETAIL https://phabricator.kde.org/D12578 AFFECTED FILES

D12886: check that ffmpeg is at least version 3.1 that introduce the API we require

This revision was automatically updated to reflect the committed changes. Closed by commit R286:3415015e3d45: check that ffmpeg is at least version 3.1 that introduce the API we require (authored by mgallien). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

D12578: fix some issues reported by clazy

mgallien added a comment. In D12578#262831 , @bruns wrote: > @mgallien - I think this is trivial to fix up - can you do, so we have one less request open? I will do but as I had started working on that as a low priority task, I have not

D12886: check that ffmpeg is at least version 3.1 that introduce the API we require

mgallien created this revision. mgallien added reviewers: dfaure, michaelh, jriddell. Restricted Application added projects: Frameworks, Baloo. Restricted Application added subscribers: Baloo, kde-frameworks-devel. mgallien requested review of this revision. REVISION SUMMARY check that ffmpeg

Re: kfilemetadata compile failure

On lundi 14 mai 2018 19:57:58 CEST Albert Astals Cid wrote: > El diumenge, 13 de maig de 2018, a les 23:15:56 CEST, Matthieu Gallien va > > escriure: > > On dimanche 13 mai 2018 23:03:02 CEST Albert Astals Cid wrote: > > > El divendres, 11 de maig de 2018, a les 23:22:1

Re: kfilemetadata compile failure

On dimanche 13 mai 2018 23:03:02 CEST Albert Astals Cid wrote: > El divendres, 11 de maig de 2018, a les 23:22:15 CEST, Jonathan Riddell va > > escriure: > > On Thu, Apr 26, 2018 at 08:31:46AM +0200, Kevin Funk wrote: > > > On Wednesday, 25 April 2018 14:34:58 CEST Jonathan Riddell wrote: > > > >

D12320: [RFC] add ability to read embedded cover files

mgallien added a comment. I am away from keyboard. Can we move forward ? Does it make sense to aim for having only one copy of this code and makes the kio code depends on KFileMetaData ? REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12320 To: astippich,

D12156: implement reading of rating tag

mgallien added a comment. In D12156#254055 , @astippich wrote: > In D12156#252575 , @mgallien wrote: > > > If I have correctly understood the ideas behind the conception of Baloo, we should

D12197: autotests: Test for multiple values

mgallien accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH multi-value-test (branched from master) REVISION DETAIL https://phabricator.kde.org/D12197 To: michaelh, #baloo, #frameworks, mgallien, bruns Cc: bruns, ashaposhnikov,

D12320: {RFC] add ability to read embedded cover files

mgallien added a comment. Thanks for your work. Please find a few remarks inline. INLINE COMMENTS > embeddedimagedata.h:25 > +#include "kfilemetadata_export.h" > +#include > + You can do a forward declaration of QMimeDatabase because it is only referred through a reference. >

D12578: fix some issues reported by clazy

mgallien created this revision. mgallien added reviewers: Baloo, Frameworks. Restricted Application added projects: Frameworks, Baloo. mgallien requested review of this revision. REVISION SUMMARY fix some issues reported by clazy TEST PLAN tests are OK REPOSITORY R293 Baloo BRANCH

D4911: add Baloo DBus signals for moved or removed files

This revision was automatically updated to reflect the committed changes. Closed by commit R293:ef0e268c6577: add Baloo DBus signals for moved or removed files (authored by mgallien). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D4911?vs=14953=33246#toc REPOSITORY R293 Baloo CHANGES

D9408: extractors: Hide warnings from system headers

mgallien accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH master REVISION DETAIL https://phabricator.kde.org/D9408 To: kfunk, mgallien Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, bruns

D9408: extractors: Hide warnings from system headers

mgallien requested changes to this revision. mgallien added a comment. This revision now requires changes to proceed. Please have a look at the issue. Thanks INLINE COMMENTS > CMakeLists.txt:35 > +target_include_directories(kfilemetadata_exiv2extractor SYSTEM PRIVATE >

D12341: fix detection of taglib when compiling for Android

This revision was automatically updated to reflect the committed changes. Closed by commit R286:d497ffebe202: fix detection of taglib when compiling for Android (authored by mgallien). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12341?vs=32543=33035

D12156: implement reading of rating tag

mgallien requested changes to this revision. mgallien added a comment. This revision now requires changes to proceed. In D12156#249994 , @astippich wrote: > In D12156#249977 , @michaelh wrote: > >

D12320: add ability to read embedded cover files

mgallien added a comment. In D12320#249998 , @astippich wrote: > In D12320#249982 , @michaelh wrote: > > > -2 > > https://cgit.kde.org/ffmpegthumbs.git/ should be useable, not sure though. >

D12341: fix detection of taglib when compiling for Android

mgallien created this revision. mgallien added reviewers: Frameworks, Baloo. Restricted Application added projects: Frameworks, Baloo. mgallien requested review of this revision. REVISION SUMMARY fix detection of taglib when cross compiling for Android TEST PLAN tagib is properly found

D12320: add ability to read embedded cover files

mgallien added a comment. Thanks a lot to continue to push this work. In D12320#249433 , @bruns wrote: > Baloos DBs should only contain searchable data. So until someone teaches baloo how to compare images, it should be kept separate.

D12108: ffmpegextractor: Silence deprecation warnings

mgallien accepted this revision. mgallien added a comment. This revision is now accepted and ready to land. Thanks. I did try to fix it some months ago but did not finished however I noticed that there is no automatic tests for it. Do you have time to work on some ? REPOSITORY R286

D12156: implement reading of rating tag

mgallien requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12156 To: astippich, mgallien, michaelh Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, bruns

D12156: implement reading of rating tag

mgallien added a comment. Thanks. Fix one issue and we should be good to go. Another nice thing is that we should have a portable way to have ratings in Elisa that could be read or write somewhere else. INLINE COMMENTS > taglibextractor.cpp:222-234 > +if (temp == 0) { > +

D11489: Make concatenated strings wrappable

mgallien accepted this revision. mgallien added a comment. This revision is now accepted and ready to land. You could even push directly for this kind of changes. REPOSITORY R286 KFileMetaData BRANCH wrappable REVISION DETAIL https://phabricator.kde.org/D11489 To: michaelh, mgallien,

D12197: autotests: Test for multiple values

mgallien accepted this revision. mgallien added a comment. This revision is now accepted and ready to land. Sorry, that was a local problem. REPOSITORY R286 KFileMetaData BRANCH multi-value-test REVISION DETAIL https://phabricator.kde.org/D12197 To: michaelh, #baloo, #frameworks,

D12197: autotests: Test for multiple values

mgallien requested changes to this revision. mgallien added a comment. This revision now requires changes to proceed. The test for mp3 is failing to complete. I am investigating. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12197 To: michaelh, #baloo,

D10694: epubextractor: Handle multiple subjects better

mgallien accepted this revision. mgallien added a comment. This revision is now accepted and ready to land. Thanks REPOSITORY R286 KFileMetaData BRANCH multi-subject REVISION DETAIL https://phabricator.kde.org/D10694 To: michaelh, mgallien, dfaure Cc: bruns, astippich, #frameworks,

D12197: autotests: Test for multiple values

mgallien accepted this revision. mgallien added a comment. This revision is now accepted and ready to land. Thanks REPOSITORY R286 KFileMetaData BRANCH multi-value-test REVISION DETAIL https://phabricator.kde.org/D12197 To: michaelh, #baloo, #frameworks, mgallien Cc: bruns,

D12145: autotests: Do not use QScopedPointer for plugins

mgallien added a comment. In D12145#245023 , @alexeymin wrote: > Just curious, why is this needed? To avoid dynamic memory allocations? I asked on new code to avoid using an extractor allocated on heap instead of on stack. @michaelh

  1   2   3   >