D16524: [Extractor] Use QDataStream serialization in place of cooked one

[Luca Beltrame]

lbeltrame accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  extractor

REVISION DETAIL
  https://phabricator.kde.org/D16524

To: bruns, #baloo, #frameworks, ngraham, poboiko, lbeltrame
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D16523: [Extractor] Replace homegrown IO handler with QDataStream, catch HUP

[Luca Beltrame]

lbeltrame added a comment.


  In general (for my limited Baloo knowledge) this makes sense. You might want 
to add a few CCBUGs if you are aware of specific bugs this alleviates (@ngraham 
or someone from the bugsquad may help).

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D16523

To: bruns, #baloo, #frameworks, ngraham, poboiko
Cc: lbeltrame, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D16522: [Extractor] Do not check QFile::exists for an empty url

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:856fd6811881: [Extractor] Do not check QFile::exists for 
an empty url (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16522?vs=44475&id=44480

REVISION DETAIL
  https://phabricator.kde.org/D16522

AFFECTED FILES
  src/file/extractor/app.cpp

To: bruns, #baloo, #frameworks, dfaure, apol, broulik
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.9 - Build # 64 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.9/64/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Tue, 30 Oct 2018 03:08:35 +
 Build duration:
4 min 39 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.scalable
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)78%
(234/300)58%
(106/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionals100%
(1/1)100%
(1/1)74%
(42/57)56%
(10/18)autotests100%
(5/5)100%
(5/5)79%
(192/243)59%
(96/164)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.10 - Build # 120 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.10/120/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 30 Oct 2018 03:08:35 +
 Build duration:
1 min 20 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.scalable
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)78%
(234/300)58%
(106/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionals100%
(1/1)100%
(1/1)74%
(42/57)56%
(10/18)autotests100%
(5/5)100%
(5/5)79%
(192/243)59%
(96/164)

D16514: Re-add monochrome link icon as action

[Nathaniel Graham]

ngraham added a comment.


  Due to a bug in how Phabricator handles diffs that involve symlinks that 
become real files, I had to land this by hand: 
https://cgit.kde.org/breeze-icons.git/commit/?id=0d8d99bd9d16f9bc5e4f14c77109e43dd65094cb

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16514

To: ndavis, #vdg, #breeze, ngraham
Cc: ngraham, #vdg, kde-frameworks-devel, michaelh, bruns

D16514: Re-add monochrome link icon as action

[Nathaniel Graham]

ngraham closed this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16514

To: ndavis, #vdg, #breeze, ngraham
Cc: ngraham, #vdg, kde-frameworks-devel, michaelh, bruns

D16522: [Extractor] Do not check QFile::exists for an empty url

[Kai Uwe Broulik]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  extractor

REVISION DETAIL
  https://phabricator.kde.org/D16522

To: bruns, #baloo, #frameworks, dfaure, apol, broulik
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D16514: Re-add monochrome link icon as action

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Yep, that'll do!

REPOSITORY
  R266 Breeze Icons

BRANCH
  fix-link-action (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16514

To: ndavis, #vdg, #breeze, ngraham
Cc: ngraham, #vdg, kde-frameworks-devel, michaelh, bruns

D16523: [Extractor] Replace homegrown IO handler with QDataStream, catch HUP

[Stefan Brüns]

bruns added a dependent revision: D16524: [Extractor] Use QDataStream 
serialization in place of cooked one.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D16523

To: bruns, #baloo, #frameworks, ngraham, poboiko
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D16524: [Extractor] Use QDataStream serialization in place of cooked one

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, Frameworks, ngraham, poboiko.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  There is no need to reinvent serialization of Qt data types, just use
  the one provided.
  
  Depends on D16523 

REPOSITORY
  R293 Baloo

BRANCH
  extractor

REVISION DETAIL
  https://phabricator.kde.org/D16524

AFFECTED FILES
  src/file/extractor/app.cpp
  src/file/extractorprocess.cpp

To: bruns, #baloo, #frameworks, ngraham, poboiko
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D16523: [Extractor] Replace homegrown IO handler with QDataStream, catch HUP

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, Frameworks, ngraham, poboiko.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  The handler does not handle partial reads, and most importantly, does
  not handle when the pipe from the parent process is closed.
  
  Although this should not happen during normal operation, in case of a
  crash the indexer process will receive QSocketNotifier::activated events
  due to 'POLLHUP' events from the underlying poll. This causes a busy
  loop, as the underlying pipe status is never checked.
  
  May fix a few instances of "100% CPU load" bug reports.

REPOSITORY
  R293 Baloo

BRANCH
  extractor

REVISION DETAIL
  https://phabricator.kde.org/D16523

AFFECTED FILES
  src/file/extractor/CMakeLists.txt
  src/file/extractor/app.cpp
  src/file/extractor/app.h
  src/file/extractor/autotests/CMakeLists.txt
  src/file/extractor/autotests/iohandlertest.cpp
  src/file/extractor/iohandler.cpp
  src/file/extractor/iohandler.h

To: bruns, #baloo, #frameworks, ngraham, poboiko
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D16522: [Extractor] Do not check QFile::exists for an empty url

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, Frameworks, dfaure, apol.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  In case the file has been removed from the IdTree DB, but is still in the
  IndexingLevelDB, documentUrl(id) may return an empty name. Skip the
  check if the name isEmpty().
  
  Qt 5.10 issues a runtime warning otherwise - 'Empty filename passed to
  function'.
  
  See also D8697 .

REPOSITORY
  R293 Baloo

BRANCH
  extractor

REVISION DETAIL
  https://phabricator.kde.org/D16522

AFFECTED FILES
  src/file/extractor/app.cpp

To: bruns, #baloo, #frameworks, dfaure, apol
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D16520: proper kwalletd dbus service file for the legacy name

[Stefan Brüns]

bruns added a comment.


  The old kwalletd(4) from kde-runtime newer installed a service file, as far 
as I can see.
  
  The `org.kde.kwalletd.service` from kwalletd5 only serves one purpose - start 
the old kwalletd4 as a source for the migration agent. IMHO the much better 
approach would be to check for `QStandardPaths::findExecutable("kwalletd")`and 
execute it.
  
  The change to the service file is IMHO fine - kwalletd5 implements both 
versions (which are actually the same interface save the service name), but 
before doing this change the migration agent has to be changed.
  
  I also wouldn't mind when the migration agent where gone completely - KDE4 is 
EOL for 3 years, and if there are some persons late to the game they can still 
export the the old wallets manually and reimport.

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D16520

To: damjang, #frameworks, cfeck
Cc: bruns, apol, kde-frameworks-devel, michaelh, ngraham

D16520: proper kwalletd dbus service file for the legacy name

[Damjan Georgievski]

damjang added a comment.


  > So now both kdelibs4 and kf5-kwallet will be installing 
org.kde.kwalletd.service and the package manager will complain.
  
  that was the case even before my patch

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D16520

To: damjang, #frameworks, cfeck
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D16520: proper kwalletd dbus service file for the legacy name

[Aleix Pol Gonzalez]

apol added a comment.


  In D16520#350809 , @damjang wrote:
  
  > in what way exactly?
  >
  > note that the kwallet package already did install org.kde.kwalletd.service, 
but also, kdelibs4 apps should be able to use kwalletd5 via the old interface 
name
  
  
  So now both kdelibs4 and kf5-kwallet will be installing 
org.kde.kwalletd.service and the package manager will complain.

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D16520

To: damjang, #frameworks, cfeck
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D16520: proper kwalletd dbus service file for the legacy name

[Damjan Georgievski]

damjang added a comment.


  In D16520#350807 , @apol wrote:
  
  > Won't this break co-installability with kdelibs4?
  
  
  in what way exactly?
  
  note that the kwallet package already did install org.kde.kwalletd.service, 
but also, kdelibs4 apps should be able to use kwalletd5 via the old interface 
name

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D16520

To: damjang, #frameworks, cfeck
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D16520: proper kwalletd dbus service file for the legacy name

[Aleix Pol Gonzalez]

apol added a comment.


  Won't this break co-installability with kdelibs4?

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D16520

To: damjang, #frameworks, cfeck
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D16520: proper kwalletd dbus service file for the legacy name

[Nathaniel Graham]

ngraham added reviewers: Frameworks, cfeck.

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D16520

To: damjang, #frameworks, cfeck
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16520: proper kwalletd dbus service file for the legacy name

[Damjan Georgievski]

damjang edited the summary of this revision.

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D16520

To: damjang
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16520: proper kwalletd dbus service file for the legacy name

[Damjan Georgievski]

damjang edited the summary of this revision.

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D16520

To: damjang
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16520: proper kwalletd dbus service file for the legacy name

[Damjan Georgievski]

damjang created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
damjang requested review of this revision.

REVISION SUMMARY
the org.kde.kwalletd legacy (kde4) name/interface is implemented by
kwalletd5. this patch makes a proper dbus service file (to
start kwalletd5 for the org.kde.kwalletd bus name, instead of the old
one that tried to start the kde4 wallet daemon

BUG: 400462

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D16520

AFFECTED FILES
  src/runtime/kwalletd/CMakeLists.txt
  src/runtime/kwalletd/org.kde.kwalletd.service
  src/runtime/kwalletd/org.kde.kwalletd.service.in

To: damjang
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14472: Set Dialog flag for JobDialog

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R495:b82b62e87a4e: Set Dialog flag for JobDialog (authored by 
nicolasfella).

REPOSITORY
  R495 Purpose Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14472?vs=38729&id=44468

REVISION DETAIL
  https://phabricator.kde.org/D14472

AFFECTED FILES
  src/widgets/JobDialog.qml

To: nicolasfella, apol, #frameworks, cfeck
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16116: [KPropertiesDialog] Show a filename for the / directory

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Whoops, missed this.
  
  However, I'm afraid it doesn't work for me, unless I'm holding it wrong:
  
  F6373382: Doesn't seem to work.png 
  
  Looks like `%1` isn't defined here.

REPOSITORY
  R241 KIO

BRANCH
  arc_root (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16116

To: thsurrel, #frameworks, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D16116: [KPropertiesDialog] Show a filename for the / directory

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Er, whoops.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16116

To: thsurrel, #frameworks, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D16494: Take 1..n KMainWindows in kRestoreMainWindows

[Tobias Deiminger]

This revision was automatically updated to reflect the committed changes.
Closed by commit R263:726684c0eb19: Take 1..n KMainWindows in 
kRestoreMainWindows (authored by tobiasdeiminger).

REPOSITORY
  R263 KXmlGui

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16494?vs=44383&id=44464

REVISION DETAIL
  https://phabricator.kde.org/D16494

AFFECTED FILES
  src/kmainwindow.h

To: tobiasdeiminger, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16415: Creating new syntax highlighting file for Job Control Language (JCL)

[Phil Young]

phily updated this revision to Diff 44457.
phily added a comment.


  - Added JCL test program as well as fixing recommendations (no hard coded 
colors)
  - Added new highlighting of steps (vs program options)

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16415?vs=44454&id=44457

REVISION DETAIL
  https://phabricator.kde.org/D16415

AFFECTED FILES
  autotests/input/test.jcl
  data/syntax/jcl.xml

To: phily, #framework_syntax_highlighting, dhaumann, cullmann
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, 
bruns, demsking, sars

D16415: Creating new syntax highlighting file for Job Control Language (JCL)

[Phil Young]

phily updated this revision to Diff 44454.
phily added a comment.


  Adding test file for JCL and making removing hard coded colors.

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16415?vs=44277&id=44454

REVISION DETAIL
  https://phabricator.kde.org/D16415

AFFECTED FILES
  autotests/input/test.jcl
  data/syntax/jcl.xml

To: phily, #framework_syntax_highlighting, dhaumann, cullmann
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, 
bruns, demsking, sars

KDE CI: Frameworks » kdoctools » kf5-qt5 SUSEQt5.10 - Build # 59 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdoctools/job/kf5-qt5%20SUSEQt5.10/59/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 29 Oct 2018 17:49:53 +
 Build duration:
3 min 34 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.kdoctools_install
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(1/1)67%
(4/6)67%
(4/6)68%
(335/490)48%
(138/287)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalssrc67%
(4/6)67%
(4/6)68%
(335/490)48%
(138/287)

D16500: Wait for docbookl10nhelper to be built before building our own manpages

[Albert Astals Cid]

This revision was automatically updated to reflect the committed changes.
Closed by commit R238:002940d2e0c3: Wait for docbookl10nhelper to be built 
before building our own manpages (authored by aacid).

REPOSITORY
  R238 KDocTools

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16500?vs=44392&id=44453

REVISION DETAIL
  https://phabricator.kde.org/D16500

AFFECTED FILES
  KF5DocToolsMacros.cmake

To: aacid, apol
Cc: bmwiedemann, kde-frameworks-devel, kde-doc-english, ltoscano, michaelh, 
ngraham, bruns, skadinna

D16416: z/OS CLIST file syntax highlighting

[Phil Young]

phily added a comment.


  In D16416#349335 , @cullmann wrote:
  
  > To properly push it with you as author, what is your full name + mail 
address?
  
  
  Phil Young
  mainframed...@gmail.com
  
  (I'm assuming you meant email address)

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D16416

To: phily, #framework_syntax_highlighting, dhaumann, cullmann
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, 
bruns, demsking, sars

KDE CI: Frameworks » kiconthemes » kf5-qt5 WindowsMSVCQt5.11 - Build # 18 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kiconthemes/job/kf5-qt5%20WindowsMSVCQt5.11/18/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Mon, 29 Oct 2018 15:52:06 +
 Build duration:
2 min 5 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 7 test(s)

KDE CI: Frameworks » kiconthemes » kf5-qt5 SUSEQt5.9 - Build # 47 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kiconthemes/job/kf5-qt5%20SUSEQt5.9/47/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 29 Oct 2018 15:47:03 +
 Build duration:
1 min 29 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 8 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(2/4)71%
(15/21)71%
(15/21)52%
(1429/2732)40%
(750/1879)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(7/7)100%
(7/7)99%
(456/458)50%
(199/400)src89%
(8/9)89%
(8/9)46%
(973/2111)38%
(551/1461)src.tools.kiconfinder0%
(0/1)0%
(0/1)0%
(0/17)0%
(0/12)tests0%
(0/4)0%
(0/4)0%
(0/146)0%
(0/6)

KDE CI: Frameworks » kiconthemes » kf5-qt5 SUSEQt5.10 - Build # 59 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kiconthemes/job/kf5-qt5%20SUSEQt5.10/59/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 29 Oct 2018 15:47:03 +
 Build duration:
1 min 29 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 8 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(2/4)71%
(15/21)71%
(15/21)52%
(1429/2732)40%
(750/1879)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(7/7)100%
(7/7)99%
(456/458)50%
(199/400)src89%
(8/9)89%
(8/9)46%
(973/2111)38%
(551/1461)src.tools.kiconfinder0%
(0/1)0%
(0/1)0%
(0/17)0%
(0/12)tests0%
(0/4)0%
(0/4)0%
(0/146)0%
(0/6)

KDE CI: Frameworks » kiconthemes » kf5-qt5 SUSEQt5.9 - Build # 46 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kiconthemes/job/kf5-qt5%20SUSEQt5.9/46/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 29 Oct 2018 15:42:43 +
 Build duration:
1 min 35 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 8 test(s)Failed: TestSuite.kiconloader_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(2/4)67%
(14/21)67%
(14/21)36%
(990/2726)27%
(513/1879)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(6/7)86%
(6/7)33%
(149/454)15%
(58/400)src89%
(8/9)89%
(8/9)40%
(841/2109)31%
(455/1461)src.tools.kiconfinder0%
(0/1)0%
(0/1)0%
(0/17)0%
(0/12)tests0%
(0/4)0%
(0/4)0%
(0/146)0%
(0/6)

KDE CI: Frameworks » kiconthemes » kf5-qt5 SUSEQt5.10 - Build # 58 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kiconthemes/job/kf5-qt5%20SUSEQt5.10/58/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 29 Oct 2018 15:42:43 +
 Build duration:
1 min 29 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 8 test(s)Failed: TestSuite.kiconloader_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(2/4)67%
(14/21)67%
(14/21)36%
(990/2726)27%
(513/1879)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(6/7)86%
(6/7)33%
(149/454)15%
(58/400)src89%
(8/9)89%
(8/9)40%
(841/2109)31%
(455/1461)src.tools.kiconfinder0%
(0/1)0%
(0/1)0%
(0/17)0%
(0/12)tests0%
(0/4)0%
(0/4)0%
(0/146)0%
(0/6)

D14472: Set Dialog flag for JobDialog

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R495 Purpose Library

BRANCH
  dialog

REVISION DETAIL
  https://phabricator.kde.org/D14472

To: nicolasfella, apol, #frameworks, cfeck
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16514: Re-add monochrome link icon as action

[Noah Davis]

ndavis added reviewers: VDG, Breeze.
ndavis added a subscriber: VDG.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16514

To: ndavis, #vdg, #breeze
Cc: #vdg, kde-frameworks-devel, michaelh, ngraham, bruns

D16514: Re-add monochrome link icon as action

[Noah Davis]

ndavis created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  Some action icons were symlinks to `emblem-symbolic-link`.
  When the new emblem style was applied to `emblem-symbolic-link`,
  those actions then had the wrong style.
  The old style has been re-added as an action icon and the symlinks have been 
changed to point to `link.svg`.

REPOSITORY
  R266 Breeze Icons

BRANCH
  fix-link-action (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16514

AFFECTED FILES
  icons-dark/actions/16/edit-link.svg
  icons-dark/actions/16/link.svg
  icons-dark/actions/16/tag-assigned.svg
  icons-dark/actions/22/edit-link.svg
  icons-dark/actions/22/link.svg
  icons-dark/actions/22/tag-assigned.svg
  icons/actions/16/edit-link.svg
  icons/actions/16/link.svg
  icons/actions/16/tag-assigned.svg
  icons/actions/22/edit-link.svg
  icons/actions/22/link.svg
  icons/actions/22/tag-assigned.svg

To: ndavis
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16498: [KFileMetaData] Add extractor for DSC conforming (Encapsulated) Postscript

[Stefan Brüns]

bruns added a comment.


  In D16498#350460 , @pino wrote:
  
  > In D16498#350426 , @bruns wrote:
  >
  > > In D16498#350422 , @pino wrote:
  > >
  > > > In D16498#350289 , @bruns 
wrote:
  > > >
  > > > > In D16498#350286 , @pino 
wrote:
  > > > >
  > > > > > Ugh no manual parsing of PS files -- please use libspectre.
  > > > >
  > > > >
  > > > > This is not Postscript parsing, but DSC parsing - read the 
specification to understand the difference!
  > > > >
  > > > > http://www.lprng.com/RESOURCES/ADOBE/5001.DSC_Spec.pdf
  > > >
  > > >
  > > > An EPS file //is// also a PostScript file, and indeed ghostscript opens 
it perfectly
  > >
  > >
  > >
  > >
  > > - also **
  >
  >
  > Sure: that is a reason more to handle it like that.
  >
  > >> Because of the above, libspectre perfectly handles EPS files, and the 
API already provides all the information that the current DscExtractor provides 
as well.
  > > 
  > > Its an additional dependency (libpectre and libgs),
  >
  >
  >
  > - libspectre is a C library, and uses only libgs
  > - the rest of the ghostscript dependencies are already used in one way or 
another in an average KDE installation
  > - okular & cantor already use libspectre for a very long time (okular a 
decade)
  
  
  It //may// be an option to use libspectre as basis for an additional 
extractor, but this should not be the default, see below.
  
  This is meant to be as simple as possible - the extractor itself is hardly 
more than 30 lines of code. There is definitely a use case for this extractor.
  
  >> and also imposes a security risk - see e.g. 
https://nvd.nist.gov/vuln/detail/CVE-2018-11645
  > 
  > There are way worse CVEs in lower components of a modern Linux stack (say 
in the Linux kernel).
  >  Also, according to that, should we drop the support in okular for 
PostScript files, and the support in cantor for EPS images?
  
  There is a difference between opening a file consciously and letting it 
happen by chance. The extractor is run when a file is hovered by the mouse 
cursor or by baloo. It will be executed without the user being aware of it.
  
  IMHO the ghostscript support should be disabled (runtime) by default in 
Okular, until it is run completely sandboxed.
  
  >>> In D16498#350325 , @bruns 
wrote:
  >>> 
   @pino - please remove your change request, if you have not read the code 
at all ...
  >>> 
  >>> 
  >>> Please tone down your attitude to something more respectful, thanks.
  >> 
  >> You started with "Ugh ..." - you comment lacks any respect ...
  > 
  > Certainly this was not the case, sorry if it was not intended. But even 
then, that was geared towards //the code//, and that does not remotely justify 
attacking //the person// with "you did not read the code" (which is wrong).
  
  The code clearly states it targets (E)PS **DSC**. A full blown PS interpreter 
//may// be able to extract more info from the file, but not without the 
mentioned drawbacks. Blankly stating using libspectre is better and should be 
used, without weighting pros and cons, does not give the impression (//to me//) 
you have evaluated it carefully.
  
  Apology accepted.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16498

To: bruns, #frameworks, #baloo, astippich, ngraham, poboiko, pino
Cc: pino, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.9 - Build # 63 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.9/63/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 29 Oct 2018 13:19:08 +
 Build duration:
4 min 53 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.scalable
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)78%
(234/300)58%
(106/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionals100%
(1/1)100%
(1/1)74%
(42/57)56%
(10/18)autotests100%
(5/5)100%
(5/5)79%
(192/243)59%
(96/164)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.10 - Build # 119 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.10/119/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 29 Oct 2018 13:19:07 +
 Build duration:
1 min 16 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.scalable
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)78%
(234/300)58%
(106/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionals100%
(1/1)100%
(1/1)74%
(42/57)56%
(10/18)autotests100%
(5/5)100%
(5/5)79%
(192/243)59%
(96/164)

D16421: Improve emblem contrast, legibility and consistency

[Nathaniel Graham]

ngraham closed this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16421

To: ndavis, #vdg, ngraham
Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh

D16421: Improve emblem contrast, legibility and consistency

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Looks fantastic. Fabulous work.

REPOSITORY
  R266 Breeze Icons

BRANCH
  emblem-outlines (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16421

To: ndavis, #vdg, ngraham
Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh

D16498: [KFileMetaData] Add extractor for DSC conforming (Encapsulated) Postscript

[Pino Toscano]

pino added a comment.


  In D16498#350426 , @bruns wrote:
  
  > In D16498#350422 , @pino wrote:
  >
  > > In D16498#350289 , @bruns 
wrote:
  > >
  > > > In D16498#350286 , @pino 
wrote:
  > > >
  > > > > Ugh no manual parsing of PS files -- please use libspectre.
  > > >
  > > >
  > > > This is not Postscript parsing, but DSC parsing - read the 
specification to understand the difference!
  > > >
  > > > http://www.lprng.com/RESOURCES/ADOBE/5001.DSC_Spec.pdf
  > >
  > >
  > > An EPS file //is// also a PostScript file, and indeed ghostscript opens 
it perfectly
  >
  >
  >
  >
  > - also **
  
  
  Sure: that is a reason more to handle it like that.
  
  >> Because of the above, libspectre perfectly handles EPS files, and the API 
already provides all the information that the current DscExtractor provides as 
well.
  > 
  > Its an additional dependency (libpectre and libgs),
  
  
  
  - libspectre is a C library, and uses only libgs
  - the rest of the ghostscript dependencies are already used in one way or 
another in an average KDE installation
  - okular & cantor already use libspectre for a very long time (okular a 
decade)
  
  > and also imposes a security risk - see e.g. 
https://nvd.nist.gov/vuln/detail/CVE-2018-11645
  
  There are way worse CVEs in lower components of a modern Linux stack (say in 
the Linux kernel).
  Also, according to that, should we drop the support in okular for PostScript 
files, and the support in cantor for EPS images?
  
  >> In D16498#350325 , @bruns wrote:
  >> 
  >>> @pino - please remove your change request, if you have not read the code 
at all ...
  >> 
  >> 
  >> Please tone down your attitude to something more respectful, thanks.
  > 
  > You started with "Ugh ..." - you comment lacks any respect ...
  
  Certainly this was not the case, sorry if it was not intended. But even then, 
that was geared towards //the code//, and that does not remotely justify 
attacking //the person// with "you did not read the code" (which is wrong).

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16498

To: bruns, #frameworks, #baloo, astippich, ngraham, poboiko, pino
Cc: pino, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16498: [KFileMetaData] Add extractor for DSC conforming (Encapsulated) Postscript

[Stefan Brüns]

bruns added a comment.


  In D16498#350422 , @pino wrote:
  
  > In D16498#350289 , @bruns wrote:
  >
  > > In D16498#350286 , @pino wrote:
  > >
  > > > Ugh no manual parsing of PS files -- please use libspectre.
  > >
  > >
  > > This is not Postscript parsing, but DSC parsing - read the specification 
to understand the difference!
  > >
  > > http://www.lprng.com/RESOURCES/ADOBE/5001.DSC_Spec.pdf
  >
  >
  > An EPS file //is// also a PostScript file, and indeed ghostscript opens it 
perfectly
  
  
  
  
  - also **
  
  > Because of the above, libspectre perfectly handles EPS files, and the API 
already provides all the information that the current DscExtractor provides as 
well.
  
  Its an additional dependency (libpectre and libgs), and also imposes a 
security risk - see e.g. https://nvd.nist.gov/vuln/detail/CVE-2018-11645
  
  > In D16498#350325 , @bruns wrote:
  > 
  >> @pino - please remove your change request, if you have not read the code 
at all ...
  > 
  > 
  > Please tone down your attitude to something more respectful, thanks.
  
  You started with "Ugh ..." - you comment lacks any respect ...

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16498

To: bruns, #frameworks, #baloo, astippich, ngraham, poboiko, pino
Cc: pino, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16498: [KFileMetaData] Add extractor for DSC conforming (Encapsulated) Postscript

[Pino Toscano]

pino added a comment.


  In D16498#350289 , @bruns wrote:
  
  > In D16498#350286 , @pino wrote:
  >
  > > Ugh no manual parsing of PS files -- please use libspectre.
  >
  >
  > This is not Postscript parsing, but DSC parsing - read the specification to 
understand the difference!
  >
  > http://www.lprng.com/RESOURCES/ADOBE/5001.DSC_Spec.pdf
  
  
  An EPS file //is// also a PostScript file, and indeed ghostscript opens it 
perfectly fine.
  Because of the above, libspectre perfectly handles EPS files, and the API 
already provides all the information that the current DscExtractor provides as 
well.
  
  In D16498#350325 , @bruns wrote:
  
  > @pino - please remove your change request, if you have not read the code at 
all ...
  
  
  Please tone down your attitude to something more respectful, thanks.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16498

To: bruns, #frameworks, #baloo, astippich, ngraham, poboiko, pino
Cc: pino, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16505: [KFileMetaData] Replace QDir::separator() with '/' in unit tests

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:891b3f70c8b6: [KFileMetaData] Replace QDir::separator() 
with '/' in unit tests (authored by bruns).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16505?vs=44411&id=44424

REVISION DETAIL
  https://phabricator.kde.org/D16505

AFFECTED FILES
  autotests/embeddedimagedatatest.cpp
  autotests/epubextractortest.cpp
  autotests/exiv2extractortest.cpp
  autotests/externalextractortest.cpp
  autotests/externalwritertest.cpp
  autotests/indexerextractortests.cpp
  autotests/mobiextractortest.cpp
  autotests/odfextractortest.cpp
  autotests/office2007extractortest.cpp
  autotests/popplerextractortest.cpp
  autotests/taglibextractortest.cpp
  autotests/taglibwritertest.cpp
  autotests/usermetadatawritertest.cpp

To: bruns, #frameworks, #baloo, lbeltrame
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D16505: [KFileMetaData] Replace QDir::separator() with '/' in unit tests

[Luca Beltrame]

lbeltrame accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R286 KFileMetaData

BRANCH
  qdir_separator

REVISION DETAIL
  https://phabricator.kde.org/D16505

To: bruns, #frameworks, #baloo, lbeltrame
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D16431: Guard data source being deleted before processing dataoffer receive event

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R127:8fe4a2756cdb: Guard data source being deleted before 
processing dataoffer receive event (authored by davidedmundson).

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16431?vs=44227&id=44422

REVISION DETAIL
  https://phabricator.kde.org/D16431

AFFECTED FILES
  src/server/dataoffer_interface.cpp

To: davidedmundson, #kwin, romangg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15900: Add unit test for subsurface input mask detection

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R127:55ebeda6d5b3: Add unit test for subsurface input mask 
detection (authored by davidedmundson).

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15900?vs=42731&id=44423

REVISION DETAIL
  https://phabricator.kde.org/D15900

AFFECTED FILES
  autotests/client/test_wayland_subsurface.cpp

To: davidedmundson, #kwin, romangg
Cc: romangg, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.9 - Build # 67 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.9/67/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 29 Oct 2018 10:10:07 +
 Build duration:
13 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 43 test(s), Skipped: 0 test(s), Total: 45 test(s)Failed: TestSuite.kwayland-testDataDeviceFailed: TestSuite.kwayland-testRemoteAccess
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)92%
(234/254)92%
(234/254)87%
(24774/28476)53%
(9822/18391)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(41/41)100%
(41/41)99%
(11653/11773)50%
(6179/12343)autotests.server100%
(5/5)100%
(5/5)99%
(353/356)49%
(169/344)src.client99%
(71/72)99%
(71/72)85%
(5742/6773)65%
(1508/2322)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server100%
(115/115)100%
(115/115)87%
(6945/7984)66%
(1966/2967)src.tools0%
(0/2)0%
(0/2)0%
(0/693)0%
(0/272)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/69)0%
(0/10)tests0%
(0/14)0%
(0/14)0%
(0/747)0%
(0/133)

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.10 - Build # 94 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.10/94/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 29 Oct 2018 10:10:07 +
 Build duration:
4 min 28 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 45 test(s), Skipped: 0 test(s), Total: 45 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)92%
(234/254)92%
(234/254)87%
(24808/28473)54%
(9849/18391)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(41/41)100%
(41/41)99%
(11697/11772)50%
(6211/12343)autotests.server100%
(5/5)100%
(5/5)99%
(353/356)49%
(169/344)src.client99%
(71/72)99%
(71/72)85%
(5731/6771)65%
(1503/2322)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server100%
(115/115)100%
(115/115)87%
(6946/7984)66%
(1966/2967)src.tools0%
(0/2)0%
(0/2)0%
(0/693)0%
(0/272)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/69)0%
(0/10)tests0%
(0/14)0%
(0/14)0%
(0/747)0%
(0/133)

D15900: Add unit test for subsurface input mask detection

[Roman Gilg]

romangg accepted this revision.
romangg added a comment.
This revision is now accepted and ready to land.


  The test passes on current master.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D15900

To: davidedmundson, #kwin, romangg
Cc: romangg, kde-frameworks-devel, michaelh, ngraham, bruns

D16431: Guard data source being deleted before processing dataoffer receive event

[Roman Gilg]

romangg accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16431

To: davidedmundson, #kwin, romangg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16498: [KFileMetaData] Add extractor for DSC conforming (Encapsulated) Postscript

[Stefan Brüns]

bruns added a comment.


  @pino - please remove your change request, if you have not read the code at 
all ...

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16498

To: bruns, #frameworks, #baloo, astippich, ngraham, poboiko, pino
Cc: pino, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16421: Improve emblem contrast, legibility and consistency

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16421

To: ndavis, #vdg
Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh

D16490: [KFileMetaData] Add unittest for XML extractor

[Stefan Brüns]

bruns marked an inline comment as done.
bruns added inline comments.

INLINE COMMENTS

> lbeltrame wrote in xmlextractortest.cpp:38
> IIRC you shouldn't use `QDir::separator()`.  See 
> http://agateau.com/2015/qdir-separator-considered-harmful/

Thx, fixed here and elsewhere (D16505 )

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16490

To: bruns, #frameworks, astippich
Cc: lbeltrame, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D16505: [KFileMetaData] Replace QDir::separator() with '/' in unit tests

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Frameworks, Baloo, lbeltrame.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

TEST PLAN
  make
  no functional changes

REPOSITORY
  R286 KFileMetaData

BRANCH
  qdir_separator

REVISION DETAIL
  https://phabricator.kde.org/D16505

AFFECTED FILES
  autotests/embeddedimagedatatest.cpp
  autotests/epubextractortest.cpp
  autotests/exiv2extractortest.cpp
  autotests/externalextractortest.cpp
  autotests/externalwritertest.cpp
  autotests/indexerextractortests.cpp
  autotests/mobiextractortest.cpp
  autotests/odfextractortest.cpp
  autotests/office2007extractortest.cpp
  autotests/popplerextractortest.cpp
  autotests/taglibextractortest.cpp
  autotests/taglibwritertest.cpp
  autotests/usermetadatawritertest.cpp

To: bruns, #frameworks, #baloo, lbeltrame
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D16421: Improve emblem contrast, legibility and consistency

[Noah Davis]

ndavis updated this revision to Diff 44410.
ndavis added a comment.


  Add emblem-readonly

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16421?vs=44313&id=44410

BRANCH
  emblem-outlines (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16421

AFFECTED FILES
  icons-dark/emblems/16/checkmark.svg
  icons-dark/emblems/16/emblem-added.svg
  icons-dark/emblems/16/emblem-checked.svg
  icons-dark/emblems/16/emblem-encrypted-locked.svg
  icons-dark/emblems/16/emblem-encrypted-unlocked.svg
  icons-dark/emblems/16/emblem-error.svg
  icons-dark/emblems/16/emblem-favorite.svg
  icons-dark/emblems/16/emblem-important.svg
  icons-dark/emblems/16/emblem-information.svg
  icons-dark/emblems/16/emblem-locked.svg
  icons-dark/emblems/16/emblem-mounted.svg
  icons-dark/emblems/16/emblem-pause.svg
  icons-dark/emblems/16/emblem-question.svg
  icons-dark/emblems/16/emblem-readonly.svg
  icons-dark/emblems/16/emblem-remove.svg
  icons-dark/emblems/16/emblem-shared.svg
  icons-dark/emblems/16/emblem-success.svg
  icons-dark/emblems/16/emblem-symbolic-link.svg
  icons-dark/emblems/16/emblem-unavailable.svg
  icons-dark/emblems/16/emblem-unlocked.svg
  icons-dark/emblems/16/emblem-unmounted.svg
  icons-dark/emblems/16/emblem-warning.svg
  icons-dark/emblems/16/rating-unrated.svg
  icons-dark/emblems/16/rating.svg
  icons-dark/emblems/16/vcs-added.svg
  icons-dark/emblems/16/vcs-conflicting.svg
  icons-dark/emblems/16/vcs-locally-modified-unstaged.svg
  icons-dark/emblems/16/vcs-locally-modified.svg
  icons-dark/emblems/16/vcs-normal.svg
  icons-dark/emblems/16/vcs-removed.svg
  icons-dark/emblems/16/vcs-update-required.svg
  icons-dark/emblems/22/checkmark.svg
  icons-dark/emblems/22/emblem-added.svg
  icons-dark/emblems/22/emblem-checked.svg
  icons-dark/emblems/22/emblem-encrypted-locked.svg
  icons-dark/emblems/22/emblem-encrypted-unlocked.svg
  icons-dark/emblems/22/emblem-error.svg
  icons-dark/emblems/22/emblem-favorite.svg
  icons-dark/emblems/22/emblem-important.svg
  icons-dark/emblems/22/emblem-information.svg
  icons-dark/emblems/22/emblem-locked.svg
  icons-dark/emblems/22/emblem-mounted.svg
  icons-dark/emblems/22/emblem-pause.svg
  icons-dark/emblems/22/emblem-question.svg
  icons-dark/emblems/22/emblem-readonly.svg
  icons-dark/emblems/22/emblem-remove.svg
  icons-dark/emblems/22/emblem-shared.svg
  icons-dark/emblems/22/emblem-success.svg
  icons-dark/emblems/22/emblem-symbolic-link.svg
  icons-dark/emblems/22/emblem-unavailable.svg
  icons-dark/emblems/22/emblem-unlocked.svg
  icons-dark/emblems/22/emblem-unmounted.svg
  icons-dark/emblems/22/emblem-warning.svg
  icons-dark/emblems/22/rating-unrated.svg
  icons-dark/emblems/22/rating.svg
  icons-dark/emblems/22/vcs-added.svg
  icons-dark/emblems/22/vcs-conflicting.svg
  icons-dark/emblems/22/vcs-locally-modified-unstaged.svg
  icons-dark/emblems/22/vcs-locally-modified.svg
  icons-dark/emblems/22/vcs-normal.svg
  icons-dark/emblems/22/vcs-removed.svg
  icons-dark/emblems/22/vcs-update-required.svg
  icons-dark/emblems/8/emblem-added.svg
  icons-dark/emblems/8/emblem-checked.svg
  icons-dark/emblems/8/emblem-encrypted-locked.svg
  icons-dark/emblems/8/emblem-encrypted-unlocked.svg
  icons-dark/emblems/8/emblem-error.svg
  icons-dark/emblems/8/emblem-favorite.svg
  icons-dark/emblems/8/emblem-important.svg
  icons-dark/emblems/8/emblem-information.svg
  icons-dark/emblems/8/emblem-locked.svg
  icons-dark/emblems/8/emblem-mounted.svg
  icons-dark/emblems/8/emblem-pause.svg
  icons-dark/emblems/8/emblem-question.svg
  icons-dark/emblems/8/emblem-readonly.svg
  icons-dark/emblems/8/emblem-remove.svg
  icons-dark/emblems/8/emblem-shared.svg
  icons-dark/emblems/8/emblem-symbolic-link.svg
  icons-dark/emblems/8/emblem-unavailable.svg
  icons-dark/emblems/8/emblem-unlocked.svg
  icons-dark/emblems/8/emblem-unmounted.svg
  icons-dark/emblems/8/emblem-warning.svg
  icons-dark/emblems/8/rating-unrated.svg
  icons-dark/emblems/8/rating.svg
  icons-dark/emblems/8/vcs-added.svg
  icons-dark/emblems/8/vcs-conflicting.svg
  icons-dark/emblems/8/vcs-locally-modified-unstaged.svg
  icons-dark/emblems/8/vcs-locally-modified.svg
  icons-dark/emblems/8/vcs-normal.svg
  icons-dark/emblems/8/vcs-removed.svg
  icons-dark/emblems/8/vcs-update-required.svg
  icons/emblems/16/checkmark.svg
  icons/emblems/16/emblem-added.svg
  icons/emblems/16/emblem-checked.svg
  icons/emblems/16/emblem-encrypted-locked.svg
  icons/emblems/16/emblem-encrypted-unlocked.svg
  icons/emblems/16/emblem-error.svg
  icons/emblems/16/emblem-favorite.svg
  icons/emblems/16/emblem-important.svg
  icons/emblems/16/emblem-information.svg
  icons/emblems/16/emblem-locked.svg
  icons/emblems/16/emblem-mounted.svg
  icons/emblems/16/emblem-pause.svg
  icons/emblems/16/emblem-question.svg
  icons/emblems/16/emblem-readonly.svg
  icons/emblems/16/emblem-remove.svg
  icons/emblems/16/emblem-shared.svg
  icons/emblems/16/emblem-success.svg
  icons/emblems/16/

D16116: [KPropertiesDialog] Show a filename for the / directory

[Thomas Surrel]

thsurrel added a comment.


  Ping ! Anyone from #frameworks  
could review this ?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16116

To: thsurrel, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16490: [KFileMetaData] Add unittest for XML extractor

[Stefan Brüns]

bruns updated this revision to Diff 44409.
bruns added a comment.


  Replace QDir::Separator with "/"

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16490?vs=44375&id=44409

BRANCH
  xml_extractor

REVISION DETAIL
  https://phabricator.kde.org/D16490

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/samplefiles/test_with_metadata.svg
  autotests/xmlextractortest.cpp
  autotests/xmlextractortest.h

To: bruns, #frameworks, astippich
Cc: lbeltrame, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D16498: [KFileMetaData] Add extractor for DSC conforming (Encapsulated) Postscript

[Stefan Brüns]

bruns added a comment.


  In D16498#350286 , @pino wrote:
  
  > Ugh no manual parsing of PS files -- please use libspectre.
  
  
  This is not Postscript parsing, but DSC parsing - read the specification to 
understand the difference!

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16498

To: bruns, #frameworks, #baloo, astippich, ngraham, poboiko, pino
Cc: pino, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16498: [KFileMetaData] Add extractor for DSC conforming (Encapsulated) Postscript

[Pino Toscano]

pino requested changes to this revision.
pino added a comment.
This revision now requires changes to proceed.


  Ugh no manual parsing of PS files -- please use libspectre.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16498

To: bruns, #frameworks, #baloo, astippich, ngraham, poboiko, pino
Cc: pino, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16498: [KFileMetaData] Add extractor for DSC conforming (Encapsulated) Postscript

[Stefan Brüns]

bruns updated this revision to Diff 44408.
bruns added a comment.


  Replace QDir::Separator with "/"

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16498?vs=44388&id=44408

BRANCH
  postscript_dsc

REVISION DETAIL
  https://phabricator.kde.org/D16498

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/postscriptdscextractortest.cpp
  autotests/postscriptdscextractortest.h
  autotests/samplefiles/test.eps
  autotests/samplefiles/test.ps
  src/extractors/CMakeLists.txt
  src/extractors/postscriptdscextractor.cpp
  src/extractors/postscriptdscextractor.h

To: bruns, #frameworks, #baloo, astippich, ngraham, poboiko
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D16490: [KFileMetaData] Add unittest for XML extractor

[Luca Beltrame]

lbeltrame added a comment.


  Generally looks OK to me, one note on `QDir::separator()` usage.

INLINE COMMENTS

> xmlextractortest.cpp:38
> +{
> +return QLatin1String(INDEXER_TESTS_SAMPLE_FILES_PATH) + 
> QDir::separator() + fileName;
> +}

IIRC you shouldn't use `QDir::separator()`.  See 
http://agateau.com/2015/qdir-separator-considered-harmful/

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16490

To: bruns, #frameworks, astippich
Cc: lbeltrame, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams