D21295: SyntaxHighlighter: Fix foreground color for text without special highlighting

dhaumann added a comment. @cullmann I don't see how we can optimize unneed `hasXXX` calls away: `Format::isDefaultTextStyle(const Theme )` internally uses the same 'hasXXX' calls, i.e. if we use both, we do it twice. Right now I don't see a trivial way to improve the patch. REPOSITORY

D21298: Add example app for printing highlighted text to pdf

pino added inline comments. INLINE COMMENTS > main.cpp:36 > +parser.addPositionalArgument(QStringLiteral("source"), > QStringLiteral("The source file to print.")); > +parser.addPositionalArgument(QStringLiteral("pdf"), QStringLiteral("The > PDF file to prin to.")); > +

D21298: Add example app for printing highlighted text to pdf

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. I ngeneral looks good to me. Maybe use ecm_optional_add_subdirectory - this also allows 3rd party users to omit the code and it still works. INLINE COMMENTS > CMakeLists.txt:6 > + >

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 108 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/108/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 20 May 2019 03:31:02 + Build duration: 1 hr 3 min and counting JUnit Tests Name:

D21295: SyntaxHighlighter: Fix foreground color for text without special highlighting

kossebau added a comment. I can confirm that this fixes the thumbnail bug for me: when I change the color theme, get rid of current thumbnail process (`killall thumbnail.so`) and trigger a reload of text thumbnails in Dolphin, I now always get consistently same colors with enough contrast

D21298: Add example app for printing highlighted text to pdf

kossebau created this revision. kossebau added a reviewer: vkrause. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. kossebau requested review of this revision. REVISION SUMMARY Gives an example how to use KSyntaxHighlighting when simply

D21295: SyntaxHighlighter: Fix foreground color for text without special highlighting

dhaumann added a comment. Well, this change only affects the SyntaxHighlighter, which KTextEditor does not use ;) For completeness: https://code.woboq.org/qt5/qtbase/src/gui/text/qtextdocument.cpp.html#673 Here, we can see that QTextDocument::drawContents() internally uses a

D21249: Test current filter before setting a new one

jglogowski added a comment. In D21249#467037 , @dfaure wrote: > A unittest addition would be good, too. Done In D21249#467073 , @dfaure wrote: > Yes, naming is hard because the method

D21249: Test current filter before setting a new one

jglogowski updated this revision to Diff 58317. jglogowski added a comment. Readd dropped lines from tests/CMakeLists.txt REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21249?vs=58316=58317 REVISION DETAIL https://phabricator.kde.org/D21249 AFFECTED FILES

D21249: Test current filter before setting a new one

jglogowski updated this revision to Diff 58316. jglogowski added a comment. - Return a QString from findMatchingFilter and handle setCurrentFilter in main function - Add filter unit test For a manual test I added a "Raw (*)" filter to the bug test program. After playing with it, I

D21295: SyntaxHighlighter: Fix foreground color for text without special highlighting

cullmann added a comment. I think one reason for the early out was that actually even the "isXXX" checks are very expensive, at least if I remember correctly they did show up a lot in my profiling in the past. Perhaps one should profile this once more (and if still visible) at least skip

D21295: SyntaxHighlighter: Fix foreground color for text without special highlighting

dhaumann added a comment. The text thumbnailer was added in: D19432 . REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D21295 To: dhaumann, vkrause, cullmann, kossebau Cc: kwrite-devel, kde-frameworks-devel, domson,

D21293: Markdown: Use color with higher contrast for lists

gregormi added a comment. In D21293#467150 , @dhaumann wrote: > New color is red: F6835074: Screenshot_20190519_175848.png > > @gregormi If you want other colors, please propose them yourself :-)

D21295: SyntaxHighlighter: Fix foreground color for text without special highlighting

dhaumann created this revision. dhaumann added reviewers: vkrause, cullmann, kossebau. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. dhaumann requested review of this revision. REVISION SUMMARY QTextDocument seems to use the widget

D20626: Refactor and cleanup

shubham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20626 To: shubham, dfaure Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kwidgetsaddons » kf5-qt5 SUSEQt5.12 - Build # 32 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwidgetsaddons/job/kf5-qt5%20SUSEQt5.12/32/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 19 May 2019 16:13:32 + Build duration: 9 min 8 sec and counting BUILD ARTIFACTS

D21293: Markdown: Use color with higher contrast for lists

This revision was automatically updated to reflect the committed changes. Closed by commit R216:7be1380c52a8: Markdown: Use color with higher contrast for lists (authored by dhaumann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D21293: Markdown: Use color with higher contrast for lists

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Looks ok for me. REPOSITORY R216 Syntax Highlighting BRANCH improve-markdown-colors REVISION DETAIL https://phabricator.kde.org/D21293 To: dhaumann, cullmann, gregormi Cc:

D21293: Markdown: Use color with higher contrast for lists

dhaumann added a comment. New color is red: F6835074: Screenshot_20190519_175848.png @gregormi If you want other colors, please propose them yourself :-) REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D21293

D21293: Markdown: Use color with higher contrast for lists

dhaumann created this revision. dhaumann added reviewers: cullmann, gregormi. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. dhaumann requested review of this revision. REVISION SUMMARY BUG: 405824 FIXED-IN: 5.59 TEST PLAN make &&

D21287: Try to find always an unique visible document name without a number suffix

loh.tar edited the test plan for this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D21287 To: loh.tar, #ktexteditor Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, ngraham, bruns, demsking, sars

D21287: Try to find always an unique visible document name without a number suffix

loh.tar added a comment. > PS: The tab switcher also has something similar to make a distiction between files with the same name D16054 I noticed this patch. It's more a workaround for the core issue. > besides that the quick open already

D14464: Cancel privilege operation for read-only target with the current user as owner

dfaure added inline comments. INLINE COMMENTS > ngraham wrote in global.h:248 > 5.59 now no, not that one, it was already there ;) The line was only modified to add a comma. > ngraham wrote in global.h:250 > 5.59 now and a trailing comma (as allowed by C++11) so that it doesn't need to be

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 107 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/107/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 19 May 2019 15:02:16 + Build duration: 9 min 3 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kwidgetsaddons » kf5-qt5 SUSEQt5.12 - Build # 31 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwidgetsaddons/job/kf5-qt5%20SUSEQt5.12/31/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 19 May 2019 14:33:01 + Build duration: 4 min 44 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.10 - Build # 117 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.10/117/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 19 May 2019 13:41:41 + Build duration: 18 min and counting BUILD ARTIFACTS

D21283: Replace Simple View and Tree view by an icon view and compact view

meven updated this revision to Diff 58303. meven added a comment. Clean up reference to action decoration menu REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21283?vs=58280=58303 BRANCH icon-compact-views REVISION DETAIL

D21287: Try to find always an unique visible document name without a number suffix

dhaumann added a comment. Looking at the screenshots, I find it rather intransparent which document gets what name, besides that the quick open already shows the path to distinguish the files -> is this really an improvement? And: I have the feeling this patch should pay attention to

D21289: Fix: Use default indentation mode for new files

This revision was automatically updated to reflect the committed changes. Closed by commit R39:11fb4c4d5e10: Fix: Use default indentation mode for new files (authored by dhaumann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21289?vs=58296=58300

D21287: Try to find always an unique visible document name without a number suffix

cullmann added a comment. I like the idea of having better short document names without numbers. The algo looks a bit like what the document list tries to do with the shortest paths differentiating two files. I think the documents stuff ignores the changed doc names as it looks for file

D19608: DocumentPrivate: Make bracket handling smart

This revision was automatically updated to reflect the committed changes. Closed by commit R39:df555c9b2e57: honor auto-bracket setting for balance check (authored by cullmann). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D19608?vs=56105=58298#toc REPOSITORY R39 KTextEditor CHANGES

D21289: Fix: Use default indentation mode for new files

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. > ok REPOSITORY R39 KTextEditor BRANCH fix-default-indent-mode REVISION DETAIL https://phabricator.kde.org/D21289 To: dhaumann, cullmann Cc: kwrite-devel,

D21249: Test current filter before setting a new one

dfaure added a comment. Yes, naming is hard because the method is dual-purposed ;-) If the method only tried to match (but not to set), then the naming would be much simpler. QString findMatchingFilter() const; if (!findMatchingFilter(...).isEmpty()) return;

D21249: Test current filter before setting a new one

jglogowski marked an inline comment as done. jglogowski added inline comments. INLINE COMMENTS > elvisangelaccio wrote in kfilewidget.cpp:132 > Nitpick: I'd make `filter` the first parameter. And we usually don't use > `const boll` in signatures, but just `bool`. > > `bUpdate` doesn't tell the

D21289: Fix: Use default indentation mode for new files

dhaumann updated this revision to Diff 58296. dhaumann added a comment. - Use updateConfig() to set indentation mode REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21289?vs=58294=58296 BRANCH fix-default-indent-mode REVISION DETAIL

D21289: Fix: Use default indentation mode for new files

cullmann added a comment. Hmm, perhaps updateConfig would be better to not miss other stuff. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D21289 To: dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, demsking,

D21288: Remove .conf extension from "INI Files" hl, to determine the highlighter using MIME type

This revision was automatically updated to reflect the committed changes. Closed by commit R216:71446d3e9e5e: Remove .conf extension from INI Files hl, to determine the highlighter using… (authored by nibags). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D21289: Fix: Use default indentation mode for new files

dhaumann added a comment. Alternatively, we could call updateConfig() at the end of the KateDocument constructor which does - among other things - the same. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D21289 To: dhaumann, cullmann Cc: kwrite-devel,

D21289: Fix: Use default indentation mode for new files

dhaumann created this revision. dhaumann added a reviewer: cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. dhaumann requested review of this revision. REVISION SUMMARY BUG: 375502 TEST PLAN make && make test REPOSITORY R39

D21286: Perl: fix the // operator

nibags closed this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D21286 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D21288: Remove .conf extension from "INI Files" hl, to determine the highlighter using MIME type

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. OK with that. REPOSITORY R216 Syntax Highlighting BRANCH remove-ext-conf-ini REVISION DETAIL https://phabricator.kde.org/D21288 To: nibags, #framework_syntax_highlighting,

D19608: DocumentPrivate: Make bracket handling smart

cullmann reopened this revision. cullmann added a comment. This revision is now accepted and ready to land. I think moving the config check some lines up will do the trick. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19608 To: loh.tar, #ktexteditor, cullmann,

D21249: Test current filter before setting a new one

jglogowski updated this revision to Diff 58291. jglogowski added a comment. Changes: - Dropped the duplicate comment in matchFilter (not sure if it makes sense at all) - Replace bool param with enum class to improve readability - should have done this from the start - Drop const

D21286: Perl: fix the // operator

cullmann accepted this revision. cullmann added a comment. Yes, please push, thanks. REPOSITORY R216 Syntax Highlighting BRANCH fix-perl REVISION DETAIL https://phabricator.kde.org/D21286 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel,

D21288: Remove .conf extension from "INI Files" hl, to determine the highlighter using MIME type

nibags created this revision. nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY BUG: 400290 The

D21249: Test current filter before setting a new one

dfaure added a comment. A unittest addition would be good, too. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21249 To: jglogowski, #frameworks, ngraham, dfaure Cc: elvisangelaccio, ngraham, michaelweghorn, kde-frameworks-devel, michaelh, bruns

D21249: Test current filter before setting a new one

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kfilewidget.cpp:2463 > +if (rx.exactMatch(filename)) { > +if (bUpdate && p != QLatin1String("*")) { // never match the > catch-all

D21280: kioslave: preserve argv[0], to fix applicationDirPath() on non-Linux

dfaure updated this revision to Diff 58289. dfaure added a comment. Use QVarLengthArray to fix the memory leak REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21280?vs=58268=58289 BRANCH 2019_freebsd_fixed REVISION DETAIL

D21287: Try to find always an unique visible document name without a number suffix

loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY When you e.g. work on multiple projects at the same time you

D21286: Perl: fix the // operator

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Thanks for the fix, please commit. REPOSITORY R216 Syntax Highlighting BRANCH fix-perl REVISION DETAIL https://phabricator.kde.org/D21286 To: nibags,

D21286: Perl: fix the // operator

nibags created this revision. nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY BUG: 407327 The "/"

D21283: Replace Simple View and Tree view by an icon view and compact view

meven updated this revision to Diff 58280. meven added a comment. Rename IconView kind Simple to Icon REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21283?vs=58279=58280 BRANCH icon-compact-views REVISION DETAIL https://phabricator.kde.org/D21283

D21249: Test current filter before setting a new one

elvisangelaccio added inline comments. INLINE COMMENTS > kfilewidget.cpp:132 > void updateLocationEditExtension(const QString &); > +bool matchFilter(const QString , const QString , const > bool bUpdate); > void updateFilter(); Nitpick: I'd make `filter` the first parameter. And

D21249: Test current filter before setting a new one

elvisangelaccio added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21249 To: jglogowski, #frameworks, ngraham, dfaure Cc: elvisangelaccio, ngraham, michaelweghorn, kde-frameworks-devel, michaelh, bruns

D21283: Replace Simple View and Tree view by an icon view and compact view

meven updated this revision to Diff 58279. meven added a comment. Capitalization REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21283?vs=58277=58279 BRANCH icon-compact-views REVISION DETAIL https://phabricator.kde.org/D21283 AFFECTED FILES

D21283: Replace Simple View and Tree view by an icon view and compact view

meven edited the summary of this revision. meven edited the test plan for this revision. meven added a reviewer: ngraham. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21283 To: meven, #frameworks, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21283: Replace Simple View and Tree view by an icon view and compact view

meven created this revision. meven added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Remove the simple view with the decoration position option, splitting the feature