Re: Change the ML default reply-to address
On Tue, Jan 28, 2014 at 7:04 PM, Nicolás Alvarez nicolas.alva...@gmail.comwrote: 2014-01-28 Martin Klapetek martin.klape...@gmail.com: Hey, would it be possible to change the default reply-to address for this list? It's quite annoying in less-advanced-than-kmail clients always pressing Reply and getting only the sender instead of the whole list. There's a switch for that in mailman, lots of lists have the reply-to set to the list address. Is there any reason why not for this list? And if not, can we please change it? :) Whether or not to make reply-to point to the mailing list is a holy war as old as mailing lists themselves. See, for example: http://www.unicom.com/pw/reply-to-harmful.html To be honest I stopped reading after the Freedom of Choice paragraph...arguments as Setting reply-to-list is arrogant, you should allow me to decide exactly how I wish to respond to a message are just...just...strange, let's go with strange. Everytime you're replying to a message it's still /you/ who decides exactly how will you respond to the message :) Personally I see it just like the holy war over GNU/Linux or Linux and similar (Gnome, hint hint). Let's be pragmatic, how many times it happened to you that you actually responded to the author alone while you actually intended to respond to the list? It's just super annoying if you're communicating with lists like plasma-devel which has reply-to-list and dozen more KDE MLs which also have reply-to-list and then you're responding to k-f-devel and everytime it's that oh wait, I need to change the reply-to address. Cheers -- Martin Klapetek | KDE Developer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115360: Remove the allocator and visibility check
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115360/#review48514 --- Ship it! Ship It! - David Faure On Jan. 28, 2014, 10:43 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115360/ --- (Updated Jan. 28, 2014, 10:43 p.m.) Review request for Build System, Extra Cmake Modules and KDE Frameworks. Repository: extra-cmake-modules Description --- Remove the allocator and visibility check I am reasonably sure the allocator check is out of date, given our minimum GCC version, and it was not used for anything interesting anyway. The visibility check will not be performed in practice, as this file will almost always be included before any check for Qt. Diffs - kde-modules/KDECompilerSettings.cmake ba9b03f1c86061dd740960220b6411bbce541617 Diff: https://git.reviewboard.kde.org/r/115360/diff/ Testing --- Everything kdesrc-build knows about builds (GCC 4.8.2 20131219; Linux with glibc 2.18). Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Where to put QML Bindings for KDE frameworks?
On Tue, Jan 28, 2014 at 7:10 PM, Kevin Ottens er...@kde.org wrote: I don't think we'll get a one size fit all type of solution, that will heavily depend on the nature of the framework. For instance something like KConfig should probably provide it's own imports, it is in the natural order of things as it already provides a core/gui split. KIO is in pretty much the same situation. But for some others it is less clear... For those ones we'll have to decide if we want to change them toward providing several payloads as well (sounds doable for most except the *addons ones), or if we want the import to be in one of the imports provided by KDeclarative. One of the downsides that wasn't mentioned yet (I think) is keeping the imports away from their modules can (and possibly will) cause the imports to bitrot and get behind the modules. Say that someone makes some changes to the framework but forgets/doesn't know about imports in KDeclarative, so those stay unupdated and may even break. Can also lead to not my problem situation when the KDeclarative maintainer will say that's code from kio, talk to kio maintainer etc. So I think it makes sense to keep the code together. Cheers -- Martin Klapetek | KDE Developer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: kf5options and qt5options manpages
On Saturday 25 January 2014 16:36:22 Albert Astals Cid wrote: El Dissabte, 25 de gener de 2014, a les 10:20:20, David Faure va escriure: On Tuesday 21 January 2014 18:38:28 Jonathan Riddell wrote: kdeoptions and qtoptions manpages listed the common options to applications using kdelibs4 and qt4. These have just become kf5options and qt5options. But which options are still true? --caption caption Use caption as name in the titlebar. Ah, this is a kde4support thing (kcmdlineargs). If we think this is useful, we should add it to Qt. Is it useful? --icon icon Use icon as the application icon. Isn't this kind of mandated by the desktop entry spec that says that %i will be translated to --icon? Besides ./kio/src/core/desktopexecparser.cpp seems to use it. You're somewhat right. Note that the .desktop file for an app doesn't have to use %i, if the app doesn't support --icon. I can see the idea of the feature, using the Icon field in the .desktop file for both menus and the app window icon, but my question is whether it's really used/useful in practice. In my kde4 applications dir, I see 16 .desktop files using %i, plus the 14 .desktop files for okular but that's just one app, so 17 apps in total. However, I suspect that most of these would work just the same without %i, since they use the default icon name anyway (e.g. ktorrent.desktop, Icon=ktorrent). Plus, the apps need a good default icon anyway, for the case where they started another way (e.g. from the command line). Not sure about -caption but i'd say it may make sense too in some cases. I actually see more possible use cases for -caption, in custom setups (e.g. someone preparing custom desktop files for users to do specific tasks, the window title can make it very clear what a particular window instance is for) I'll see about adding it to Qt. It's also easier, because we can make it single dash... I guess I should also make Qt support double-dash for its builtin options... -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Change the ML default reply-to address
Hi, Let's be pragmatic, how many times it happened to you that you actually responded to the author alone while you actually intended to respond to the list? It's just super annoying if you're communicating with lists like plasma-devel which has reply-to-list and dozen more KDE MLs which also have reply-to-list and then you're responding to k-f-devel and everytime it's that oh wait, I need to change the reply-to address. +1 Cheers, David Gil ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115364: Update tier number
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115364/#review48518 --- This review has been submitted with commit d0faca866bb645b4a4f8f52dd1e6cb98ef3424db by Michael Palimaka to branch master. - Commit Hook On Jan. 28, 2014, 5:14 p.m., Michael Palimaka wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115364/ --- (Updated Jan. 28, 2014, 5:14 p.m.) Review request for KDE Frameworks and Valentin Rusu. Repository: kwallet-framework Description --- It was discussed on the mailing list that kwallet is moving to tier 3, so this needs updating in the yaml file too. Diffs - kwallet-framework.yaml 9b601d5a6408c76d0f56d875af1f4c179b271741 Diff: https://git.reviewboard.kde.org/r/115364/diff/ Testing --- Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115364: Update tier number
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115364/ --- (Updated Jan. 29, 2014, 9:45 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Valentin Rusu. Repository: kwallet-framework Description --- It was discussed on the mailing list that kwallet is moving to tier 3, so this needs updating in the yaml file too. Diffs - kwallet-framework.yaml 9b601d5a6408c76d0f56d875af1f4c179b271741 Diff: https://git.reviewboard.kde.org/r/115364/diff/ Testing --- Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Where to put QML Bindings for KDE frameworks?
On Wednesday 29 January 2014 09:20:09 Martin Klapetek wrote: On Tue, Jan 28, 2014 at 7:10 PM, Kevin Ottens er...@kde.org wrote: I don't think we'll get a one size fit all type of solution, that will heavily depend on the nature of the framework. For instance something like KConfig should probably provide it's own imports, it is in the natural order of things as it already provides a core/gui split. KIO is in pretty much the same situation. But for some others it is less clear... For those ones we'll have to decide if we want to change them toward providing several payloads as well (sounds doable for most except the *addons ones), or if we want the import to be in one of the imports provided by KDeclarative. One of the downsides that wasn't mentioned yet (I think) is keeping the imports away from their modules can (and possibly will) cause the imports to bitrot and get behind the modules. Say that someone makes some changes to the framework but forgets/doesn't know about imports in KDeclarative, so those stay unupdated and may even break. Can also lead to not my problem situation when the KDeclarative maintainer will say that's code from kio, talk to kio maintainer etc. So I think it makes sense to keep the code together. Definitely. My point was that I'm not convinced we'll be able to do that in 100% of the cases. Regards. -- Kévin Ottens, http://ervin.ipsquad.net KDAB - proud supporter of KDE, http://www.kdab.com signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 115376: KDE_SOURCE_FILES_ENABLE_EXCEPTIONS: Handle case where COMPILE_FLAGS is not set
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115376/
---
Review request for Build System, Extra Cmake Modules, KDE Frameworks, and Alex
Merry.
Repository: extra-cmake-modules
Description
---
When COMPILE_FLAGS is not set, get_source_file_property(flags ${source_file}
COMPILEFLAGS) set flags to NOTFOUND. Leading to interesting build failures in
kde-runtime when we then set flags to NOTFOUND -fexceptions, see
http://build.kde.org/job/kde-runtime_frameworks_qt5/58/
Diffs
-
kde-modules/KDECompilerSettings.cmake 6b7ab4e
Diff: https://git.reviewboard.kde.org/r/115376/diff/
Testing
---
Built kde-runtime successfully.
Thanks,
Aurélien Gâteau
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Change the ML default reply-to address
On Wednesday, 2014-01-29, 09:01:00, Martin Klapetek wrote: Let's be pragmatic, how many times it happened to you that you actually responded to the author alone while you actually intended to respond to the list? How would that happen? Replying to the list always replies to the list. It's just super annoying if you're communicating with lists like plasma-devel which has reply-to-list and dozen more KDE MLs which also have reply-to-list and then you're responding to k-f-devel and everytime it's that oh wait, I need to change the reply-to address. I am subscribed to more than two dozend KDE mailinglist (and numerous others). I post to some of the regularily while some others only sporadically. New mail to list and reply to list have *always* sent the mail to the list. The only thing that is not reliably working across lists is reply in private mail. For that to work repliably I've fallen back to using the mouse and right-clicking the right address. Pretty annoying but some mailinglists seem to have broken setups. Cheers, Kevin -- Kevin Krammer, KDE developer, xdg-utils developer KDE user support, developer mentoring signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Change the ML default reply-to address
On Wed, Jan 29, 2014 at 11:23 AM, Kevin Krammer kram...@kde.org wrote: On Wednesday, 2014-01-29, 09:01:00, Martin Klapetek wrote: Let's be pragmatic, how many times it happened to you that you actually responded to the author alone while you actually intended to respond to the list? How would that happen? Replying to the list always replies to the list. It's just super annoying if you're communicating with lists like plasma-devel which has reply-to-list and dozen more KDE MLs which also have reply-to-list and then you're responding to k-f-devel and everytime it's that oh wait, I need to change the reply-to address. I am subscribed to more than two dozend KDE mailinglist (and numerous others). I post to some of the regularily while some others only sporadically. New mail to list and reply to list have *always* sent the mail to the list. The only thing that is not reliably working across lists is reply in private mail. For that to work repliably I've fallen back to using the mouse and right-clicking the right address. Pretty annoying but some mailinglists seem to have broken setups. As said in the original mail, in less-advanced-than-kmail clients there is no reply to list and simply hitting reply /always/ puts the author in To: instead of the ML address for this list, therefore the suggestion :) Personally I also think that all of our MLs should behave the same...sort of like KDE-ML-policy but that's a longer run I guess... Cheers -- Martin Klapetek | KDE Developer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Change the ML default reply-to address
On Tue, Jan 28, 2014, at 9:30, Martin Klapetek wrote: Hey, would it be possible to change the default reply-to address for this list? It's quite annoying in less-advanced-than-kmail clients always pressing Reply and getting only the sender instead of the whole list. There's a switch for that in mailman, lots of lists have the reply-to set to the list address. Is there any reason why not for this list? And if not, can we please change it? :) +1 from me. Aurélien ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Change the ML default reply-to address
On Wednesday, 2014-01-29, 11:43:37, Martin Klapetek wrote: On Wed, Jan 29, 2014 at 11:23 AM, Kevin Krammer kram...@kde.org wrote: I am subscribed to more than two dozend KDE mailinglist (and numerous others). I post to some of the regularily while some others only sporadically. New mail to list and reply to list have *always* sent the mail to the list. The only thing that is not reliably working across lists is reply in private mail. For that to work repliably I've fallen back to using the mouse and right-clicking the right address. Pretty annoying but some mailinglists seem to have broken setups. As said in the original mail, in less-advanced-than-kmail clients there is no reply to list and simply hitting reply /always/ puts the author in To: instead of the ML address for this list, therefore the suggestion :) Ah, a case of wrong-tool-for-the-job then :) Personally I also think that all of our MLs should behave the same...sort of like KDE-ML-policy but that's a longer run I guess... I don't think it really matters [1]. Reply to list works reliably, reply to author requires mouse interaction to be reliable, reply as a shortcut is out of the picture due to broken lists. It is a pity but using shortcuts is dying out, more and more things start to require clicking and touching :( Luckily the only affected action currently is reply to author which is not often required :) Cheers, Kevin [1] if those with limited mail clients prefer reply to mimick reply to list, then we should do that. Reply's consistency is broken for everyone anyway and thus mostly unused anyway. -- Kevin Krammer, KDE developer, xdg-utils developer KDE user support, developer mentoring signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Where to put QML Bindings for KDE frameworks?
So I think there is some agreement that where we have a relevant 1-1 match we put it with the framework. i.e KIO. knotifications(?), kunitconversion, kconfig, kbookmarks, solid... That still leaves a few items where we need imports which don't have a match: - Helper actions for QML - like qtextracomponents/clipboard, qtextracomponents/mouseeventlistener, qtextracomponents/columnproxymodel I think this might be worth making a tier1 module. If there are enough items to warrant it and if there's going to be enough outside interest. Also we should try to upstream these; Digia are currently remaking something like mouseeventlistener; which is just a waste of effort. - Custom QtQuickControl styled widgets that aren't upstream. I don't generally think it makes sense to merge these with the widgets. If you want to build the widgets you wouldn't want the QML imports, if you want the QML imports you don't want to build the widgets. David ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Re: Change the ML default reply-to address
On Wednesday 29 January 2014 11:23:31 Kevin Krammer wrote: On Wednesday, 2014-01-29, 09:01:00, Martin Klapetek wrote: Let's be pragmatic, how many times it happened to you that you actually responded to the author alone while you actually intended to respond to the list? How would that happen? Replying to the list always replies to the list. It's just super annoying if you're communicating with lists like plasma-devel which has reply-to-list and dozen more KDE MLs which also have reply-to-list and then you're responding to k-f-devel and everytime it's that oh wait, I need to change the reply-to address. I am subscribed to more than two dozend KDE mailinglist (and numerous others). I post to some of the regularily while some others only sporadically. New mail to list and reply to list have *always* sent the mail to the list. And I as a more than a decade KMail user just learned something new: I haven't known that there is a reply to list option. And while trying to write that mail I noticed the problem. I pressed R and got krammer in the to field, and had to go back and tried L for the very first time. Cheers Martin signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Where to put QML Bindings for KDE frameworks?
On Wednesday, 2014-01-29, 12:22:39, David Edmundson wrote: I don't generally think it makes sense to merge these with the widgets. If you want to build the widgets you wouldn't want the QML imports, if you want the QML imports you don't want to build the widgets. If you meant QtQuick, I agree :) Cheers, Kevin -- Kevin Krammer, KDE developer, xdg-utils developer KDE user support, developer mentoring signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Change the ML default reply-to address
On Wednesday, 2014-01-29, 12:30:55, Martin Gräßlin wrote: On Wednesday 29 January 2014 11:23:31 Kevin Krammer wrote: I am subscribed to more than two dozend KDE mailinglist (and numerous others). I post to some of the regularily while some others only sporadically. New mail to list and reply to list have *always* sent the mail to the list. And I as a more than a decade KMail user just learned something new: I haven't known that there is a reply to list option. And while trying to write that mail I noticed the problem. I pressed R and got krammer in the to field, and had to go back and tried L for the very first time. :-) Just in case: CTRL+SHIFT+N - new mail to list Cheers, Kevin -- Kevin Krammer, KDE developer, xdg-utils developer KDE user support, developer mentoring signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115360: Remove the allocator and visibility check
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115360/#review48531 --- This review has been submitted with commit 4e867a836bafd113c6d4b34c17eeb564089308a2 by Alex Merry to branch master. - Commit Hook On Jan. 28, 2014, 10:43 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115360/ --- (Updated Jan. 28, 2014, 10:43 p.m.) Review request for Build System, Extra Cmake Modules and KDE Frameworks. Repository: extra-cmake-modules Description --- Remove the allocator and visibility check I am reasonably sure the allocator check is out of date, given our minimum GCC version, and it was not used for anything interesting anyway. The visibility check will not be performed in practice, as this file will almost always be included before any check for Qt. Diffs - kde-modules/KDECompilerSettings.cmake ba9b03f1c86061dd740960220b6411bbce541617 Diff: https://git.reviewboard.kde.org/r/115360/diff/ Testing --- Everything kdesrc-build knows about builds (GCC 4.8.2 20131219; Linux with glibc 2.18). Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115372: Improve the compiler version checks
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115372/ --- (Updated Jan. 29, 2014, 1:20 p.m.) Review request for Build System, Extra Cmake Modules and KDE Frameworks. Changes --- Rebase against latest master. Repository: extra-cmake-modules Description --- Improve the compiler version checks - Only warn if the compiler is not recent enough (it may still work...) - Bump up the GCC version to 4.5 (on Linux, at least) to match Qt - Add checks for Windows (both MSVC and MinGW) - Add check for Clang Diffs (updated) - kde-modules/KDECompilerSettings.cmake bcc11284d36830963af66f203bc5ea0397afa611 Diff: https://git.reviewboard.kde.org/r/115372/diff/ Testing --- Built KCoreAddons with gcc 4.8.2 on Linux. Got no warning. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115359: rename dbus interface files and .desktop files in kio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115359/ --- (Updated Jan. 29, 2014, 1:24 p.m.) Review request for KDE Frameworks and David Faure. Repository: kio Description --- rename dbus interface files and .desktop files in kio to prevent clashes with kdelibs4 equivalents. dbus interface itself remains the same. Diffs (updated) - KF5KIOConfig.cmake.in 5846238 src/core/CMakeLists.txt 75ba28d src/ioslaves/http/kcookiejar/CMakeLists.txt b22ded4 src/ioslaves/mailto/CMakeLists.txt acabf88 src/ioslaves/mailto/kmailservice.desktop 03838a5 src/ioslaves/mailto/kmailservice5.desktop PRE-CREATION src/ioslaves/telnet/CMakeLists.txt 70fea89 src/ioslaves/telnet/ktelnetservice.desktop 052a9d3 src/ioslaves/telnet/ktelnetservice5.desktop PRE-CREATION src/widgets/CMakeLists.txt 01b9483 Diff: https://git.reviewboard.kde.org/r/115359/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115376: KDE_SOURCE_FILES_ENABLE_EXCEPTIONS: Handle case where COMPILE_FLAGS is not set
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115376/#review48533
---
Ship it!
kde-modules/KDECompilerSettings.cmake
https://git.reviewboard.kde.org/r/115376/#comment34300
I would have gone for
if (NOT flags)
# CMake can give NOTFOUND as a result
set(flags)
endif()
which may be more resilient to possible changes in the implementation of
get_source_file_property, but I'm not that fussed either way.
- Alex Merry
On Jan. 29, 2014, 10:17 a.m., Aurélien Gâteau wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115376/
---
(Updated Jan. 29, 2014, 10:17 a.m.)
Review request for Build System, Extra Cmake Modules, KDE Frameworks, and
Alex Merry.
Repository: extra-cmake-modules
Description
---
When COMPILE_FLAGS is not set, get_source_file_property(flags ${source_file}
COMPILEFLAGS) set flags to NOTFOUND. Leading to interesting build failures
in kde-runtime when we then set flags to NOTFOUND -fexceptions, see
http://build.kde.org/job/kde-runtime_frameworks_qt5/58/
Diffs
-
kde-modules/KDECompilerSettings.cmake 6b7ab4e
Diff: https://git.reviewboard.kde.org/r/115376/diff/
Testing
---
Built kde-runtime successfully.
Thanks,
Aurélien Gâteau
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Change the ML default reply-to address
On Wed, Jan 29, 2014 at 9:01 AM, Martin Klapetek martin.klape...@gmail.com wrote: On Tue, Jan 28, 2014 at 7:04 PM, Nicolás Alvarez nicolas.alva...@gmail.com wrote: 2014-01-28 Martin Klapetek martin.klape...@gmail.com: Hey, would it be possible to change the default reply-to address for this list? It's quite annoying in less-advanced-than-kmail clients always pressing Reply and getting only the sender instead of the whole list. There's a switch for that in mailman, lots of lists have the reply-to set to the list address. Is there any reason why not for this list? And if not, can we please change it? :) Whether or not to make reply-to point to the mailing list is a holy war as old as mailing lists themselves. See, for example: http://www.unicom.com/pw/reply-to-harmful.html To be honest I stopped reading after the Freedom of Choice paragraph...arguments as Setting reply-to-list is arrogant, you should allow me to decide exactly how I wish to respond to a message are just...just...strange, let's go with strange. Everytime you're replying to a message it's still /you/ who decides exactly how will you respond to the message :) Personally I see it just like the holy war over GNU/Linux or Linux and similar (Gnome, hint hint). Let's be pragmatic, how many times it happened to you that you actually responded to the author alone while you actually intended to respond to the list? It's just super annoying if you're communicating with lists like plasma-devel which has reply-to-list and dozen more KDE MLs which also have reply-to-list and then you're responding to k-f-devel and everytime it's that oh wait, I need to change the reply-to address. +1 Yeah, i've had that issue quite a few times. Now since i use gmail i either have an easy reply-to-all option or (and that's even better) a labs plugin that automatically does reply-to-all instead of reply. I didn't even know this was something the mailing list software could influence. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 115379: Check the C_COMPILER_ID when settings C_FLAGS, not CXX_COMPILER_ID
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115379/ --- Review request for Build System, Extra Cmake Modules and KDE Frameworks. Repository: extra-cmake-modules Description --- Check the C_COMPILER_ID when settings C_FLAGS, not CXX_COMPILER_ID Not that anyone is likely to use different compilers for C and C++... Diffs - kde-modules/KDECompilerSettings.cmake bcc11284d36830963af66f203bc5ea0397afa611 Diff: https://git.reviewboard.kde.org/r/115379/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 115380: Find QtGui when being consumed
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115380/ --- Review request for KDE Frameworks and Martin Gräßlin. Repository: kwindowsystem Description --- QtGui is exported in the public link interface, so linking of a consumer will fail if that consumer does not happen to use QtGui. Diffs - KF5WindowSystemConfig.cmake.in 318df19071b57138126607d0ed908feec75102b8 Diff: https://git.reviewboard.kde.org/r/115380/diff/ Testing --- Consumer kcrash builds when its QtGui checks are removed (it doesn't actually use them). Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 115381: rename dbus interface file for kmediaplayer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115381/ --- Review request for KDE Frameworks and Alex Merry. Repository: kmediaplayer Description --- rename the dbus interface file for kmediaplayer. this prevents it clashing with the equivalent from kdelibs4 which some distros can not handle. The dbus interface itself remains unchanged. Diffs - src/CMakeLists.txt 299c044 Diff: https://git.reviewboard.kde.org/r/115381/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115380: Find QtGui when being consumed
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115380/#review48537 --- Ship it! Ship It! - Martin Gräßlin On Jan. 29, 2014, 3:53 p.m., Michael Palimaka wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115380/ --- (Updated Jan. 29, 2014, 3:53 p.m.) Review request for KDE Frameworks and Martin Gräßlin. Repository: kwindowsystem Description --- QtGui is exported in the public link interface, so linking of a consumer will fail if that consumer does not happen to use QtGui. Diffs - KF5WindowSystemConfig.cmake.in 318df19071b57138126607d0ed908feec75102b8 Diff: https://git.reviewboard.kde.org/r/115380/diff/ Testing --- Consumer kcrash builds when its QtGui checks are removed (it doesn't actually use them). Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115380: Find QtGui when being consumed
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115380/ --- (Updated Jan. 29, 2014, 3:08 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Martin Gräßlin. Repository: kwindowsystem Description --- QtGui is exported in the public link interface, so linking of a consumer will fail if that consumer does not happen to use QtGui. Diffs - KF5WindowSystemConfig.cmake.in 318df19071b57138126607d0ed908feec75102b8 Diff: https://git.reviewboard.kde.org/r/115380/diff/ Testing --- Consumer kcrash builds when its QtGui checks are removed (it doesn't actually use them). Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115376: KDE_SOURCE_FILES_ENABLE_EXCEPTIONS: Handle case where COMPILE_FLAGS is not set
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115376/
---
(Updated Jan. 29, 2014, 3:15 p.m.)
Status
--
This change has been marked as submitted.
Review request for Build System, Extra Cmake Modules, KDE Frameworks, and Alex
Merry.
Repository: extra-cmake-modules
Description
---
When COMPILE_FLAGS is not set, get_source_file_property(flags ${source_file}
COMPILEFLAGS) set flags to NOTFOUND. Leading to interesting build failures in
kde-runtime when we then set flags to NOTFOUND -fexceptions, see
http://build.kde.org/job/kde-runtime_frameworks_qt5/58/
Diffs
-
kde-modules/KDECompilerSettings.cmake 6b7ab4e
Diff: https://git.reviewboard.kde.org/r/115376/diff/
Testing
---
Built kde-runtime successfully.
Thanks,
Aurélien Gâteau
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115381: rename dbus interface file for kmediaplayer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115381/#review48545 --- Ship it! I'm not even aware that anyone actually uses this interface... - Alex Merry On Jan. 29, 2014, 2:50 p.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115381/ --- (Updated Jan. 29, 2014, 2:50 p.m.) Review request for KDE Frameworks and Alex Merry. Repository: kmediaplayer Description --- rename the dbus interface file for kmediaplayer. this prevents it clashing with the equivalent from kdelibs4 which some distros can not handle. The dbus interface itself remains unchanged. Diffs - src/CMakeLists.txt 299c044 Diff: https://git.reviewboard.kde.org/r/115381/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115376: KDE_SOURCE_FILES_ENABLE_EXCEPTIONS: Handle case where COMPILE_FLAGS is not set
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115376/#review48543
---
This review has been submitted with commit
cf6070c980f7b9465ce7ad850291663210b9ea53 by Aurélien Gâteau to branch master.
- Commit Hook
On Jan. 29, 2014, 10:17 a.m., Aurélien Gâteau wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115376/
---
(Updated Jan. 29, 2014, 10:17 a.m.)
Review request for Build System, Extra Cmake Modules, KDE Frameworks, and
Alex Merry.
Repository: extra-cmake-modules
Description
---
When COMPILE_FLAGS is not set, get_source_file_property(flags ${source_file}
COMPILEFLAGS) set flags to NOTFOUND. Leading to interesting build failures
in kde-runtime when we then set flags to NOTFOUND -fexceptions, see
http://build.kde.org/job/kde-runtime_frameworks_qt5/58/
Diffs
-
kde-modules/KDECompilerSettings.cmake 6b7ab4e
Diff: https://git.reviewboard.kde.org/r/115376/diff/
Testing
---
Built kde-runtime successfully.
Thanks,
Aurélien Gâteau
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115380: Find QtGui when being consumed
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115380/#review48540 --- This review has been submitted with commit 3e73a48f101a8521e2b48a58e8eb9c243a383f32 by Michael Palimaka to branch master. - Commit Hook On Jan. 29, 2014, 2:53 p.m., Michael Palimaka wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115380/ --- (Updated Jan. 29, 2014, 2:53 p.m.) Review request for KDE Frameworks and Martin Gräßlin. Repository: kwindowsystem Description --- QtGui is exported in the public link interface, so linking of a consumer will fail if that consumer does not happen to use QtGui. Diffs - KF5WindowSystemConfig.cmake.in 318df19071b57138126607d0ed908feec75102b8 Diff: https://git.reviewboard.kde.org/r/115380/diff/ Testing --- Consumer kcrash builds when its QtGui checks are removed (it doesn't actually use them). Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115376: KDE_SOURCE_FILES_ENABLE_EXCEPTIONS: Handle case where COMPILE_FLAGS is not set
On Jan. 29, 2014, 2:29 p.m., Alex Merry wrote:
kde-modules/KDECompilerSettings.cmake, lines 204-206
https://git.reviewboard.kde.org/r/115376/diff/1/?file=240951#file240951line204
I would have gone for
if (NOT flags)
# CMake can give NOTFOUND as a result
set(flags)
endif()
which may be more resilient to possible changes in the implementation
of get_source_file_property, but I'm not that fussed either way.
Oh right NOTFOUND is considered FALSE. CMake is a weird language :/. Going to
do it this way, it's more future proof indeed.
- Aurélien
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115376/#review48533
---
On Jan. 29, 2014, 11:17 a.m., Aurélien Gâteau wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115376/
---
(Updated Jan. 29, 2014, 11:17 a.m.)
Review request for Build System, Extra Cmake Modules, KDE Frameworks, and
Alex Merry.
Repository: extra-cmake-modules
Description
---
When COMPILE_FLAGS is not set, get_source_file_property(flags ${source_file}
COMPILEFLAGS) set flags to NOTFOUND. Leading to interesting build failures
in kde-runtime when we then set flags to NOTFOUND -fexceptions, see
http://build.kde.org/job/kde-runtime_frameworks_qt5/58/
Diffs
-
kde-modules/KDECompilerSettings.cmake 6b7ab4e
Diff: https://git.reviewboard.kde.org/r/115376/diff/
Testing
---
Built kde-runtime successfully.
Thanks,
Aurélien Gâteau
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 115382: Remove unused dependencies
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115382/ --- Review request for KDE Frameworks and David Faure. Repository: kcrash Description --- QtGui is not used anywhere, and QtWidgets are only required for tests. Diffs - src/kcrash.cpp b8e13a92c822d0bec47280941e7d5dadca5bfb38 src/CMakeLists.txt 69dd376a0f08909d77b70c492fc60a5ab5220317 CMakeLists.txt 0ce523b9a5355813285c508fcff8f4c6b80405ba KF5CrashConfig.cmake.in f1e6ecfee32f4c54d467f9a08976472c16fe6823 autotests/CMakeLists.txt b01a5753adb0a3097b315570231edfbff30f89d7 Diff: https://git.reviewboard.kde.org/r/115382/diff/ Testing --- Builds. I didn't find any source references to the two dependencies. qwindowdefs.h from QtWidgets was identified as unused through static analysis tool. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115378: Resolve some FIXMEs related to MSVC and Intel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115378/#review48547 --- Looks good, but I can't test it right now. kde-modules/KDECompilerSettings.cmake https://git.reviewboard.kde.org/r/115378/#comment34310 if(MSVC) is used everywhere else - Andrius da Costa Ribas On Jan. 29, 2014, 1:39 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115378/ --- (Updated Jan. 29, 2014, 1:39 p.m.) Review request for Build System, Extra Cmake Modules, KDE Frameworks, and Andrius da Costa Ribas. Repository: extra-cmake-modules Description --- Resolve some FIXMEs related to MSVC and Intel In particular, MSVC (and Intel on Windows) have no equivalent of the -std flag to set the language standard, and Intel does not appear to produce the warnings that were disabled for MSVC. Diffs - kde-modules/KDECompilerSettings.cmake bcc11284d36830963af66f203bc5ea0397afa611 Diff: https://git.reviewboard.kde.org/r/115378/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115382: Remove unused dependencies
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115382/#review48548 --- Ship it! Cool :) - Aleix Pol Gonzalez On Jan. 29, 2014, 3:33 p.m., Michael Palimaka wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115382/ --- (Updated Jan. 29, 2014, 3:33 p.m.) Review request for KDE Frameworks and David Faure. Repository: kcrash Description --- QtGui is not used anywhere, and QtWidgets are only required for tests. Diffs - src/kcrash.cpp b8e13a92c822d0bec47280941e7d5dadca5bfb38 src/CMakeLists.txt 69dd376a0f08909d77b70c492fc60a5ab5220317 CMakeLists.txt 0ce523b9a5355813285c508fcff8f4c6b80405ba KF5CrashConfig.cmake.in f1e6ecfee32f4c54d467f9a08976472c16fe6823 autotests/CMakeLists.txt b01a5753adb0a3097b315570231edfbff30f89d7 Diff: https://git.reviewboard.kde.org/r/115382/diff/ Testing --- Builds. I didn't find any source references to the two dependencies. qwindowdefs.h from QtWidgets was identified as unused through static analysis tool. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115382: Remove unused dependencies
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115382/ --- (Updated Jan. 29, 2014, 3:53 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and David Faure. Repository: kcrash Description --- QtGui is not used anywhere, and QtWidgets are only required for tests. Diffs - src/kcrash.cpp b8e13a92c822d0bec47280941e7d5dadca5bfb38 src/CMakeLists.txt 69dd376a0f08909d77b70c492fc60a5ab5220317 CMakeLists.txt 0ce523b9a5355813285c508fcff8f4c6b80405ba KF5CrashConfig.cmake.in f1e6ecfee32f4c54d467f9a08976472c16fe6823 autotests/CMakeLists.txt b01a5753adb0a3097b315570231edfbff30f89d7 Diff: https://git.reviewboard.kde.org/r/115382/diff/ Testing --- Builds. I didn't find any source references to the two dependencies. qwindowdefs.h from QtWidgets was identified as unused through static analysis tool. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115382: Remove unused dependencies
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115382/#review48552 --- This review has been submitted with commit 603638aa9524660672c47f6af77e767c1dac4ff8 by Michael Palimaka to branch master. - Commit Hook On Jan. 29, 2014, 3:33 p.m., Michael Palimaka wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115382/ --- (Updated Jan. 29, 2014, 3:33 p.m.) Review request for KDE Frameworks and David Faure. Repository: kcrash Description --- QtGui is not used anywhere, and QtWidgets are only required for tests. Diffs - src/kcrash.cpp b8e13a92c822d0bec47280941e7d5dadca5bfb38 src/CMakeLists.txt 69dd376a0f08909d77b70c492fc60a5ab5220317 CMakeLists.txt 0ce523b9a5355813285c508fcff8f4c6b80405ba KF5CrashConfig.cmake.in f1e6ecfee32f4c54d467f9a08976472c16fe6823 autotests/CMakeLists.txt b01a5753adb0a3097b315570231edfbff30f89d7 Diff: https://git.reviewboard.kde.org/r/115382/diff/ Testing --- Builds. I didn't find any source references to the two dependencies. qwindowdefs.h from QtWidgets was identified as unused through static analysis tool. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115361: use renamed kmailservice5
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115361/ --- (Updated Jan. 29, 2014, 3:58 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Hrvoje Senjan. Repository: kservice Description --- fix test for renamed kmailservice5 proposed in https://git.reviewboard.kde.org/r/115359/ Diffs - autotests/kservicetest.cpp 89eb0ae Diff: https://git.reviewboard.kde.org/r/115361/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115359: rename dbus interface files and .desktop files in kio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115359/ --- (Updated Jan. 29, 2014, 3:57 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and David Faure. Repository: kio Description --- rename dbus interface files and .desktop files in kio to prevent clashes with kdelibs4 equivalents. dbus interface itself remains the same. Diffs - KF5KIOConfig.cmake.in 5846238 src/core/CMakeLists.txt 75ba28d src/ioslaves/http/kcookiejar/CMakeLists.txt b22ded4 src/ioslaves/mailto/CMakeLists.txt acabf88 src/ioslaves/mailto/kmailservice.desktop 03838a5 src/ioslaves/mailto/kmailservice5.desktop PRE-CREATION src/ioslaves/telnet/CMakeLists.txt 70fea89 src/ioslaves/telnet/ktelnetservice.desktop 052a9d3 src/ioslaves/telnet/ktelnetservice5.desktop PRE-CREATION src/widgets/CMakeLists.txt 01b9483 Diff: https://git.reviewboard.kde.org/r/115359/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115359: rename dbus interface files and .desktop files in kio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115359/#review48554 --- - Jonathan Riddell On Jan. 29, 2014, 3:57 p.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115359/ --- (Updated Jan. 29, 2014, 3:57 p.m.) Review request for KDE Frameworks and David Faure. Repository: kio Description --- rename dbus interface files and .desktop files in kio to prevent clashes with kdelibs4 equivalents. dbus interface itself remains the same. Diffs - KF5KIOConfig.cmake.in 5846238 src/core/CMakeLists.txt 75ba28d src/ioslaves/http/kcookiejar/CMakeLists.txt b22ded4 src/ioslaves/mailto/CMakeLists.txt acabf88 src/ioslaves/mailto/kmailservice.desktop 03838a5 src/ioslaves/mailto/kmailservice5.desktop PRE-CREATION src/ioslaves/telnet/CMakeLists.txt 70fea89 src/ioslaves/telnet/ktelnetservice.desktop 052a9d3 src/ioslaves/telnet/ktelnetservice5.desktop PRE-CREATION src/widgets/CMakeLists.txt 01b9483 Diff: https://git.reviewboard.kde.org/r/115359/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115381: rename dbus interface file for kmediaplayer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115381/#review48556 --- This review has been submitted with commit f4fe77bd9830c80081c22285cd57b9e7e3626382 by Jonathan Riddell to branch master. - Commit Hook On Jan. 29, 2014, 2:50 p.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115381/ --- (Updated Jan. 29, 2014, 2:50 p.m.) Review request for KDE Frameworks and Alex Merry. Repository: kmediaplayer Description --- rename the dbus interface file for kmediaplayer. this prevents it clashing with the equivalent from kdelibs4 which some distros can not handle. The dbus interface itself remains unchanged. Diffs - src/CMakeLists.txt 299c044 Diff: https://git.reviewboard.kde.org/r/115381/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115381: rename dbus interface file for kmediaplayer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115381/ --- (Updated Jan. 29, 2014, 4 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Alex Merry. Repository: kmediaplayer Description --- rename the dbus interface file for kmediaplayer. this prevents it clashing with the equivalent from kdelibs4 which some distros can not handle. The dbus interface itself remains unchanged. Diffs - src/CMakeLists.txt 299c044 Diff: https://git.reviewboard.kde.org/r/115381/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115379: Check the C_COMPILER_ID when settings C_FLAGS, not CXX_COMPILER_ID
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115379/#review48557 --- Ship it! Ship It! - Christophe Giboudeaux On Jan. 29, 2014, 1:52 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115379/ --- (Updated Jan. 29, 2014, 1:52 p.m.) Review request for Build System, Extra Cmake Modules and KDE Frameworks. Repository: extra-cmake-modules Description --- Check the C_COMPILER_ID when settings C_FLAGS, not CXX_COMPILER_ID Not that anyone is likely to use different compilers for C and C++... Diffs - kde-modules/KDECompilerSettings.cmake bcc11284d36830963af66f203bc5ea0397afa611 Diff: https://git.reviewboard.kde.org/r/115379/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115361: use renamed kmailservice5
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115361/#review48555 --- This review has been submitted with commit 1e91aa164f22b43f4025759b39bba6279ef60047 by Jonathan Riddell to branch master. - Commit Hook On Jan. 28, 2014, 4:25 p.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115361/ --- (Updated Jan. 28, 2014, 4:25 p.m.) Review request for KDE Frameworks and Hrvoje Senjan. Repository: kservice Description --- fix test for renamed kmailservice5 proposed in https://git.reviewboard.kde.org/r/115359/ Diffs - autotests/kservicetest.cpp 89eb0ae Diff: https://git.reviewboard.kde.org/r/115361/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115378: Resolve some FIXMEs related to MSVC and Intel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115378/ --- (Updated Jan. 29, 2014, 4:30 p.m.) Review request for Build System, Extra Cmake Modules, KDE Frameworks, and Andrius da Costa Ribas. Changes --- Added an extra commit that replaces compiler id checks against MSVC with checking the MSVC variable. Repository: extra-cmake-modules Description (updated) --- Use the MSVC variable directly, instead of the compiler ID This is cleaner and easier to read. Resolve some FIXMEs related to MSVC and Intel In particular, MSVC (and Intel on Windows) have no equivalent of the -std flag to set the language standard, and Intel does not appear to produce the warnings that were disabled for MSVC. Diffs (updated) - kde-modules/KDECompilerSettings.cmake 62ba4a0ab2cd2615fb54b3f938784b753bcff132 Diff: https://git.reviewboard.kde.org/r/115378/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115379: Check the C_COMPILER_ID when settings C_FLAGS, not CXX_COMPILER_ID
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115379/#review48559 --- This review has been submitted with commit eed522877d4b575e2bbfdcca7dc964df6b88030e by Alex Merry to branch master. - Commit Hook On Jan. 29, 2014, 1:52 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115379/ --- (Updated Jan. 29, 2014, 1:52 p.m.) Review request for Build System, Extra Cmake Modules and KDE Frameworks. Repository: extra-cmake-modules Description --- Check the C_COMPILER_ID when settings C_FLAGS, not CXX_COMPILER_ID Not that anyone is likely to use different compilers for C and C++... Diffs - kde-modules/KDECompilerSettings.cmake bcc11284d36830963af66f203bc5ea0397afa611 Diff: https://git.reviewboard.kde.org/r/115379/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115379: Check the C_COMPILER_ID when settings C_FLAGS, not CXX_COMPILER_ID
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115379/ --- (Updated Jan. 29, 2014, 4:31 p.m.) Status -- This change has been marked as submitted. Review request for Build System, Extra Cmake Modules and KDE Frameworks. Repository: extra-cmake-modules Description --- Check the C_COMPILER_ID when settings C_FLAGS, not CXX_COMPILER_ID Not that anyone is likely to use different compilers for C and C++... Diffs - kde-modules/KDECompilerSettings.cmake bcc11284d36830963af66f203bc5ea0397afa611 Diff: https://git.reviewboard.kde.org/r/115379/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 115387: rename dbus interface file for kinit
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115387/ --- Review request for KDE Frameworks and Stefano Avallone. Repository: kinit Description --- rename the dbus interface file for kinit on install to prevent clashes with kdelibs4 equivalent. Diffs - src/klauncher/CMakeLists.txt c6cff7c Diff: https://git.reviewboard.kde.org/r/115387/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Change the ML default reply-to address
On Wednesday, 2014-01-29, 14:29:42, Mark Gaiser wrote: Yeah, i've had that issue quite a few times. Now since i use gmail i either have an easy reply-to-all option or (and that's even better) a labs plugin that automatically does reply-to-all instead of reply. Which has a different problem since this sends mails to the other person twice. Once directly and once through the list. IMHO it really sucks when that happens, polluting *my* inbox when replying to my mails on a list. Make sure you always remove the sender after you've hit reply-all for a list! Cheers, Kevin -- Kevin Krammer, KDE developer, xdg-utils developer KDE user support, developer mentoring signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Frameworks sprint in Barcelona
Hi there ! It is time we decide when to organize the Frameworks sprint, the main objective of this sprint is Making it releseable. The Doodle contains only Thursdays from May and April which is the day the sprint will start (and end on Sunday) http://doodle.com/n4r7xv3waigbcnv4 Cheers ! ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Change the ML default reply-to address
On Wed, Jan 29, 2014 at 5:38 PM, Kevin Krammer kram...@kde.org wrote: On Wednesday, 2014-01-29, 14:29:42, Mark Gaiser wrote: Yeah, i've had that issue quite a few times. Now since i use gmail i either have an easy reply-to-all option or (and that's even better) a labs plugin that automatically does reply-to-all instead of reply. Which has a different problem since this sends mails to the other person twice. Once directly and once through the list. IMHO it really sucks when that happens, polluting *my* inbox when replying to my mails on a list. Make sure you always remove the sender after you've hit reply-all for a list! Also didn't know that. This is a quite informative thread, it thought me two new things already. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 115388: Remove unused dependencies.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115388/ --- Review request for KDE Frameworks and Marco Martin. Repository: kdeclarative Description --- QtScript is not used. QtGui is actually used rather than QtWidgets. Diffs - CMakeLists.txt 536f7f33ca6ac25fc87966bf2bb4e2fc248c37fd src/kdeclarative.h 84f313302c70f9161ab2244c735166e08947f252 Diff: https://git.reviewboard.kde.org/r/115388/diff/ Testing --- Builds. Didn't find any reference to QtScript or QtWidgets when inspecting source. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115372: Improve the compiler version checks
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115372/#review48563 --- Ship it! Ship It! - Alexander Richardson On Jan. 29, 2014, 2:20 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115372/ --- (Updated Jan. 29, 2014, 2:20 p.m.) Review request for Build System, Extra Cmake Modules and KDE Frameworks. Repository: extra-cmake-modules Description --- Improve the compiler version checks - Only warn if the compiler is not recent enough (it may still work...) - Bump up the GCC version to 4.5 (on Linux, at least) to match Qt - Add checks for Windows (both MSVC and MinGW) - Add check for Clang Diffs - kde-modules/KDECompilerSettings.cmake bcc11284d36830963af66f203bc5ea0397afa611 Diff: https://git.reviewboard.kde.org/r/115372/diff/ Testing --- Built KCoreAddons with gcc 4.8.2 on Linux. Got no warning. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115372: Improve the compiler version checks
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115372/#review48564 --- This review has been submitted with commit dc3e32e27dcd42f551e5fb2c923689275c6b3f52 by Alex Merry to branch master. - Commit Hook On Jan. 29, 2014, 1:20 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115372/ --- (Updated Jan. 29, 2014, 1:20 p.m.) Review request for Build System, Extra Cmake Modules and KDE Frameworks. Repository: extra-cmake-modules Description --- Improve the compiler version checks - Only warn if the compiler is not recent enough (it may still work...) - Bump up the GCC version to 4.5 (on Linux, at least) to match Qt - Add checks for Windows (both MSVC and MinGW) - Add check for Clang Diffs - kde-modules/KDECompilerSettings.cmake bcc11284d36830963af66f203bc5ea0397afa611 Diff: https://git.reviewboard.kde.org/r/115372/diff/ Testing --- Built KCoreAddons with gcc 4.8.2 on Linux. Got no warning. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Transitive dependency checks
On 29/01/14 17:29, Michael Palimaka wrote: Hi, In a some (not all) tier 3 frameworks, we check for transitive dependencies: #NOTE: here the dependencies of dependencies are displayed as well, this shouldn't be needed #after cmake 3.0.0 is released find_package(...) I think this is no longer needed since we ship CMake config files for each framework which pull in the required dependencies, and a number of frameworks already omit the transitive checks and work fine. I'd like to start sending review requests to clean this all up unless anyone thinks this is not correct. The issue, as I recall, was the *private* dependencies - ie: those not listed in the Config.cmake file. I'm not sure exactly what issue it caused, though, as I never encountered any problems. I wouldn't have thought that dynamic linking would produce any problems anyway; maybe static linking? Or Windows? Alex ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Unable to start kcmshell5 * after installing kf5 successfully
Hello I've just build the KF5 using instructions given on community.kde.org/framework/building using build-kdesrc script. the build was successful but I'm unable to run kcmshell5 *. when I execute command an empty dialog box appears as attached with mail. and it gives error : Couldn't start kded5 from org.kde.kded5.service: QDBusError(org.freedesktop.DBus.Error.ServiceUnknown, The name org.kde.kded5 was not provided by any .service files) Trying to open ksycoca from /home/amourphious/.cache5/ksycoca5 Theme tree: (Oxygen) also command kbuildsycoca5 gives output : kbuildsycoca5 running... Trying to open ksycoca from /home/amourphious/.cache5/ksycoca5 Reusing existing ksycoca Recreating ksycoca file (/home/amourphious/.cache5/ksycoca5, version 230) The desktop entry file plasma-wallpaper.desktop has Type= ServiceType instead of Application or Service Invalid Service : plasma-wallpaper.desktop Still in the time dict (i.e. deleted files) (apps) Menu applications-kmenuedit.menu not found. Saving Emitting notifyDatabaseChanged (apps) any ideas about how to get it to work ? Thanks Regards Shivam attachment: snapshot35.jpg___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: kf5options and qt5options manpages
El Dimecres, 29 de gener de 2014, a les 09:25:47, David Faure va escriure: On Saturday 25 January 2014 16:36:22 Albert Astals Cid wrote: El Dissabte, 25 de gener de 2014, a les 10:20:20, David Faure va escriure: On Tuesday 21 January 2014 18:38:28 Jonathan Riddell wrote: kdeoptions and qtoptions manpages listed the common options to applications using kdelibs4 and qt4. These have just become kf5options and qt5options. But which options are still true? --caption caption Use caption as name in the titlebar. Ah, this is a kde4support thing (kcmdlineargs). If we think this is useful, we should add it to Qt. Is it useful? --icon icon Use icon as the application icon. Isn't this kind of mandated by the desktop entry spec that says that %i will be translated to --icon? Besides ./kio/src/core/desktopexecparser.cpp seems to use it. You're somewhat right. Note that the .desktop file for an app doesn't have to use %i, if the app doesn't support --icon. I can see the idea of the feature, using the Icon field in the .desktop file for both menus and the app window icon, but my question is whether it's really used/useful in practice. In my kde4 applications dir, I see 16 .desktop files using %i, plus the 14 .desktop files for okular but that's just one app, so 17 apps in total. However, I suspect that most of these would work just the same without %i, since they use the default icon name anyway (e.g. ktorrent.desktop, Icon=ktorrent). Plus, the apps need a good default icon anyway, for the case where they started another way (e.g. from the command line). Sure, ok, forget the .desktop scenario, the real useful scenario is the same than -caption and is actually starting something from a command line and giving it a custom icon, like let's say, konsole or kdialog but you pretend they are something you created for your own command line program. Does that make more sense? Cheers, Albert Not sure about -caption but i'd say it may make sense too in some cases. I actually see more possible use cases for -caption, in custom setups (e.g. someone preparing custom desktop files for users to do specific tasks, the window title can make it very clear what a particular window instance is for) I'll see about adding it to Qt. It's also easier, because we can make it single dash... I guess I should also make Qt support double-dash for its builtin options... ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: kactivities master becomes Qt5/KF5-based
On Wed, January 29, 2014 00:02:09 Ivan Čukić wrote: Ping, 4.13 is looming over. If you want to make it so there's no new releases of 4.12.x anymore and master is KF5 based, please discuss now. Personally I'd suggest against it since seems that even if we dicussed for that happening to kde-workspace people did not get the memo and got angry, so unless you have a huge itch to make it happen i'd just do with kactivities the same we do with kdelibs. I've been procrastinating. We can't do the same thing as with kdelibs. Simply because those were split into separate repositories where masters are qt5/kf5-based. KActivities is already in a separate repository. I think Albert would be referring to when kdelibs was tracking both KDE 4 and KF5 Frameworks development (before the KF5 repo splits occurred). If we decide to wait after 4.13, the next release of Plasma will have to use a non-master-based kactivities which I'm not sure is a good idea. Naturally, I am open to suggestions. We already track branch groups for the build.kde.org CI infrastructure and for kdesrc-build users, which simply maps which 'role' is being build for to the needed repo branch to use. It's visible in the kde-build-metadata repo, and should make it easy enough to manage (this is used in the same kf5-qt5-build-include that dfaure and others are maintaining for the kdesrc-build KF5 config). Regards, - Michael Pyne signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 115392: Fix compilation with clang
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115392/ --- Review request for KDE Frameworks and Christoph Cullmann. Repository: ktexteditor Description --- Fix compilation with clang Clang ignores the implicit conversion operators with const return type. Diffs - src/buffer/katetextrange.h fda415f71d3942c35169d33882d43df4a2baf27e src/include/ktexteditor/movingcursor.h 8783c390bfe4144b663eb234562ffa300fdc8e11 src/include/ktexteditor/movingrange.h 49200799dec08f07e5c1e7d01de6ef1d468a9a6b Diff: https://git.reviewboard.kde.org/r/115392/diff/ Testing --- compiles now with clang 3.3, didn't before Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115392: Fix compilation with clang
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115392/#review48574 --- Ship it! Ship It! - Christoph Cullmann On Jan. 29, 2014, 10:46 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115392/ --- (Updated Jan. 29, 2014, 10:46 p.m.) Review request for KDE Frameworks and Christoph Cullmann. Repository: ktexteditor Description --- Fix compilation with clang Clang ignores the implicit conversion operators with const return type. Diffs - src/buffer/katetextrange.h fda415f71d3942c35169d33882d43df4a2baf27e src/include/ktexteditor/movingcursor.h 8783c390bfe4144b663eb234562ffa300fdc8e11 src/include/ktexteditor/movingrange.h 49200799dec08f07e5c1e7d01de6ef1d468a9a6b Diff: https://git.reviewboard.kde.org/r/115392/diff/ Testing --- compiles now with clang 3.3, didn't before Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115392: Fix compilation with clang
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115392/#review48575 --- This review has been submitted with commit 9bd234cfb74f18e8040db559dd3be9f4675a34fe by Alex Richardson to branch master. - Commit Hook On Jan. 29, 2014, 10:46 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115392/ --- (Updated Jan. 29, 2014, 10:46 p.m.) Review request for KDE Frameworks and Christoph Cullmann. Repository: ktexteditor Description --- Fix compilation with clang Clang ignores the implicit conversion operators with const return type. Diffs - src/buffer/katetextrange.h fda415f71d3942c35169d33882d43df4a2baf27e src/include/ktexteditor/movingcursor.h 8783c390bfe4144b663eb234562ffa300fdc8e11 src/include/ktexteditor/movingrange.h 49200799dec08f07e5c1e7d01de6ef1d468a9a6b Diff: https://git.reviewboard.kde.org/r/115392/diff/ Testing --- compiles now with clang 3.3, didn't before Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115392: Fix compilation with clang
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115392/ --- (Updated Jan. 29, 2014, 10:55 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Christoph Cullmann. Repository: ktexteditor Description --- Fix compilation with clang Clang ignores the implicit conversion operators with const return type. Diffs - src/buffer/katetextrange.h fda415f71d3942c35169d33882d43df4a2baf27e src/include/ktexteditor/movingcursor.h 8783c390bfe4144b663eb234562ffa300fdc8e11 src/include/ktexteditor/movingrange.h 49200799dec08f07e5c1e7d01de6ef1d468a9a6b Diff: https://git.reviewboard.kde.org/r/115392/diff/ Testing --- compiles now with clang 3.3, didn't before Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Unable to start kcmshell5 * after installing kf5 successfully
On 29/01/14 12:21, Shivam Makkar wrote: Hello I've just build the KF5 using instructions given on community.kde.org/framework/building http://community.kde.org/framework/building using build-kdesrc script. the build was successful but I'm unable to run kcmshell5 *. when I execute command an empty dialog box appears as attached with mail. and it gives error : Couldn't start kded5 from org.kde.kded5.service: QDBusError(org.freedesktop.DBus.Error.ServiceUnknown, The name org.kde.kded5 was not provided by any .service files) Trying to open ksycoca from /home/amourphious/.cache5/ksycoca5 Theme tree: (Oxygen) You probably need to start a new instance of dbus, as described in http://community.kde.org/Frameworks/Building#Running_unit_tests Alex ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 115394: Split KCompletionBase from kcompletion.h
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115394/ --- Review request for KDE Frameworks. Repository: kcompletion Description --- To make kcompletion.h smaller, split KCompletionBase class from it into its own header file. Diffs - src/klineedit.h f1107e2 src/kcompletionbase.cpp 252b613 src/kcompletion.h fa0731e src/kcompletionbase.h PRE-CREATION src/CMakeLists.txt 05452ab src/kcombobox.h f34d259 Diff: https://git.reviewboard.kde.org/r/115394/diff/ Testing --- It builds. Tests pass. Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 115395: Also pass -fno-exceptions when building with clang
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115395/ --- Review request for Build System, Extra Cmake Modules and KDE Frameworks. Repository: extra-cmake-modules Description --- Also pass -fno-exceptions when building with clang All of KF5 + kate + kde-workspace compile with clang and -fno-exceptions The only problem related to clang and -fno-exceptions I could find was http://llvm.org/bugs/show_bug.cgi?id=10910 and that is fixed since clang version 3.0 which was released in December 2011 Diffs - kde-modules/KDECompilerSettings.cmake 335e1270d19f8342e41b22e7081dea3f7ac0fbfc Diff: https://git.reviewboard.kde.org/r/115395/diff/ Testing --- compiled all of kf5 + kate + kde-workspace without any issues using clang 3.3 Would be good if someone with an older clang version could test it and see whether it works. May also be related to the libstdc++ headers (4.8 installed here). Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115395: Also pass -fno-exceptions when building with clang
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115395/#review48579 --- kde-modules/KDECompilerSettings.cmake https://git.reviewboard.kde.org/r/115395/#comment34328 I forgot to remove this comment, will do if it can be confirmed that compilation works also with older versions - Alexander Richardson On Jan. 30, 2014, 12:18 a.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115395/ --- (Updated Jan. 30, 2014, 12:18 a.m.) Review request for Build System, Extra Cmake Modules and KDE Frameworks. Repository: extra-cmake-modules Description --- Also pass -fno-exceptions when building with clang All of KF5 + kate + kde-workspace compile with clang and -fno-exceptions The only problem related to clang and -fno-exceptions I could find was http://llvm.org/bugs/show_bug.cgi?id=10910 and that is fixed since clang version 3.0 which was released in December 2011 Diffs - kde-modules/KDECompilerSettings.cmake 335e1270d19f8342e41b22e7081dea3f7ac0fbfc Diff: https://git.reviewboard.kde.org/r/115395/diff/ Testing --- compiled all of kf5 + kate + kde-workspace without any issues using clang 3.3 Would be good if someone with an older clang version could test it and see whether it works. May also be related to the libstdc++ headers (4.8 installed here). Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115395: Also pass -fno-exceptions when building with clang
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115395/#review48580 --- Don't forget to also remove the comments about # We never disabled exceptions for Clang anyway, but this makes it # blindingly obvious to anyone building with make VERBOSE=1 in the enable exceptions functions (it appears twice). - Alex Merry On Jan. 29, 2014, 11:18 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115395/ --- (Updated Jan. 29, 2014, 11:18 p.m.) Review request for Build System, Extra Cmake Modules and KDE Frameworks. Repository: extra-cmake-modules Description --- Also pass -fno-exceptions when building with clang All of KF5 + kate + kde-workspace compile with clang and -fno-exceptions The only problem related to clang and -fno-exceptions I could find was http://llvm.org/bugs/show_bug.cgi?id=10910 and that is fixed since clang version 3.0 which was released in December 2011 Diffs - kde-modules/KDECompilerSettings.cmake 335e1270d19f8342e41b22e7081dea3f7ac0fbfc Diff: https://git.reviewboard.kde.org/r/115395/diff/ Testing --- compiled all of kf5 + kate + kde-workspace without any issues using clang 3.3 Would be good if someone with an older clang version could test it and see whether it works. May also be related to the libstdc++ headers (4.8 installed here). Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115395: Also pass -fno-exceptions when building with clang
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115395/#review48581 --- kde-modules/KDECompilerSettings.cmake https://git.reviewboard.kde.org/r/115395/#comment34329 Remove this comment kde-modules/KDECompilerSettings.cmake https://git.reviewboard.kde.org/r/115395/#comment34330 Remove this comment - Alex Merry On Jan. 29, 2014, 11:18 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115395/ --- (Updated Jan. 29, 2014, 11:18 p.m.) Review request for Build System, Extra Cmake Modules and KDE Frameworks. Repository: extra-cmake-modules Description --- Also pass -fno-exceptions when building with clang All of KF5 + kate + kde-workspace compile with clang and -fno-exceptions The only problem related to clang and -fno-exceptions I could find was http://llvm.org/bugs/show_bug.cgi?id=10910 and that is fixed since clang version 3.0 which was released in December 2011 Diffs - kde-modules/KDECompilerSettings.cmake 335e1270d19f8342e41b22e7081dea3f7ac0fbfc Diff: https://git.reviewboard.kde.org/r/115395/diff/ Testing --- compiled all of kf5 + kate + kde-workspace without any issues using clang 3.3 Would be good if someone with an older clang version could test it and see whether it works. May also be related to the libstdc++ headers (4.8 installed here). Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
