ngraham added a comment.
In https://phabricator.kde.org/D9840#203563, @jtamate wrote:
> Just to let you know that I know how to reproduce the high I/O of
plasmashell and continuous calls to Kservice.
> You can reproduce it just having opened the vivaldi web browser. (I never
though it
januz added a comment.
Agree with the text not being useful for small sizes, but it could look good
for a large logo-style image (like say, a 256px logo on the wiki/homepage).
A cassette is definitely an interesting idea for an icon. At least it's not
another musical note or play icon
apol abandoned this revision.
apol added a comment.
https://phabricator.kde.org/D10420 this one works better.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D10416
To: apol, #plasma, davidedmundson
Cc: davidedmundson, ngraham, plasma-devel, #framew
apol created this revision.
apol added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
apol requested review of this revision.
REVISION SUMMARY
On wayland (at least) it's initialized when the windo
davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.
> Fixes rendering of svg in many places, for example now icons don't look
By editing FrameSVG? That seems unlikely.
I think you've got some results mixed u
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.7/41/
Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.7
Date of build:
Fri, 09 Feb 2018 23:23:51 +
Build duration:
17 min and counting
JUnit Tests
Nam
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.9/30/
Project:
Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9
Date of build:
Fri, 09 Feb 2018 23:23:51 +
Build duration:
9 min 55 sec and counting
JUnit Tes
ngraham added a comment.
It doesn't merge cleanly on master. Can you re-base it?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D10114
To: ijanssen, #plasma, dfaure
Cc: ngraham, aacid, broulik, plasma-devel, #frameworks, michaelh, ZrenBot,
progwolff, lesliezhai, ali-moh
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/46/
Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.10
Date of build:
Fri, 09 Feb 2018 23:23:51 +
Build duration:
5 min 9 sec and counting
JUnit Tests
This revision was not accepted when it landed; it landed in state "Needs
Revision".
This revision was automatically updated to reflect the committed changes.
Closed by commit R244:97ca9ee095cd: Introduce K_PLUGIN_CLASS_WITH_JSON
(authored by aacid).
CHANGED PRIOR TO COMMIT
https://phabricator.
This revision was automatically updated to reflect the committed changes.
Closed by commit R249:9ae1a9b2e923: API dox: add note about calling
setApplicationDomain after QApp creation (authored by kossebau).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D8351?vs=20928&id=26851#toc
REPOSIT
fvogt added a comment.
In https://phabricator.kde.org/D10141#203726, @aacid wrote:
> In https://phabricator.kde.org/D10141#203664, @fvogt wrote:
>
> > In https://phabricator.kde.org/D10141#203545, @chinmoyr wrote:
> >
> > > In https://phabricator.kde.org/D10141#197039, @fvogt wrote
aacid added a comment.
In https://phabricator.kde.org/D10141#203664, @fvogt wrote:
> In https://phabricator.kde.org/D10141#203545, @chinmoyr wrote:
>
> > In https://phabricator.kde.org/D10141#197039, @fvogt wrote:
> >
> > > There is one issue I have with this. While this is close t
René J. V. Bertin wrote:
> Rex Dieter wrote:
>
>> I'm not aware of fedora providing any such thing.
>
> I still had the link in my terminal scrollback:
> http://ftp.gwdg.de/pub/opensuse/tumbleweed/repo/oss/suse/noarch/oxygen5-icon-theme-scalable-5.42.0-1.1.noarch.rpm
That's an opensuse rpm, not
ijanssen added a comment.
In https://phabricator.kde.org/D10114#202694, @ngraham wrote:
> Is this committable?
I think yes
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D10114
To: ijanssen, #plasma, dfaure
Cc: ngraham, aacid, broulik, plasma-devel, #framewo
apol added a comment.
This breaks the rendering of buttons (exclusively, as long as I've seen), any
idea why?
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D10416
To: apol, #plasma
Cc: plasma-devel, #frameworks, michaelh, ZrenBot, ngraham, progwo
apol created this revision.
apol added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
apol requested review of this revision.
REVISION SUMMARY
Plasma::Svg uses this information to know the pixel d
fvogt added a comment.
In https://phabricator.kde.org/D10141#203545, @chinmoyr wrote:
> In https://phabricator.kde.org/D10141#197039, @fvogt wrote:
>
> > There is one issue I have with this. While this is close to the
`sudo`-mode of temporary authorization grants, it doesn't work that
Hi all together,
first, yes I'm the maintainer of oxygen-icons5 and there are png file the
the origin svgz files.
I don't know how the svg rendering work in plasma, BUT the svg folder is
350 mb in size
the png ones are 34 mb. I don't think it's a good idea to use the svgz
icons.
And here is the
Friedrich W. H. Kossebau wrote:
> Too focussed on the second question, I missed this one. Hm, doing a quick
> incomplete ls -1 | wc -l on some categories I would rather see more PNG files
> per size than SVG files.
You're right actually, I see now that I missed directory level in one of my own
l
Rex Dieter wrote:
> I'm not aware of fedora providing any such thing.
I still had the link in my terminal scrollback:
http://ftp.gwdg.de/pub/opensuse/tumbleweed/repo/oss/suse/noarch/oxygen5-icon-theme-scalable-5.42.0-1.1.noarch.rpm
R
Adding Andreas as cc:, given he semi-maintains the oxygen icons.
Am Freitag, 9. Februar 2018, 17:49:54 CET schrieb René J. V. Bertin:
> Friedrich W. H. Kossebau wrote:
> > Am Freitag, 9. Februar 2018, 10:07:35 CET schrieb René J.V. Bertin:
> > > Two questions arise:
> > > - why are they there so m
markg marked an inline comment as done.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D10414
To: markg, dfaure
Cc: apol, #frameworks, michaelh, ngraham
markg updated this revision to Diff 26839.
markg added a comment.
Remove comment about compiler generated functions.
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10414?vs=26838&id=26839
BRANCH
udsentry_move
REVISION DETAIL
https://phabricator.kde.org/D1
apol added inline comments.
INLINE COMMENTS
> udsentry.cpp:95
> +// Default implementations for:
> +// - Copy constructor
> +// - Move constructor
This comment is very confusing, especially considering that the order you used
there isn't the same as the ones below.
I'd just remove it all.
RE
markg added a comment.
Just a note.
The fact that currently no code is structured in a way that move semantics
are used is... slightly annoying ;)
No as in not when running dolphin with it and profiling it to see UDSEntry
uses. There "might" be code that uses move semantics when this patc
René J. V. Bertin wrote:
>> So all the PNG versions are there as handcrafted optimized versions of
>> their SVG counterpart, so the icons are still usable when needed in sizes
>> of 16,22,24,32,48,...
>
> Isn't that an answer to the question "why are there also png icons" (or to
> "why are so ma
markg updated this revision to Diff 26838.
markg added a comment.
Fix indentation.
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10414?vs=26836&id=26838
BRANCH
udsentry_move
REVISION DETAIL
https://phabricator.kde.org/D10414
AFFECTED FILES
autotests/u
markg created this revision.
markg added a reviewer: dfaure.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
markg requested review of this revision.
REVISION SUMMARY
Adds move semantics support and a testcase (only useful in callgrind).
chinmoyr created this revision.
chinmoyr added reviewers: Frameworks, ossi.
Restricted Application added a project: Frameworks.
chinmoyr requested review of this revision.
REVISION SUMMARY
"/tmp" is world writable so creating socket there is a bad idea. Instead
create socket in user's
runtime
chinmoyr added a dependent revision: D10411: Create socket file in user's
runtime directory.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D10410
To: chinmoyr, #frameworks, ossi
Cc: michaelh, ngraham
chinmoyr added a dependent revision: D10410: Move the task of cleaning up of
socket file to file ioslave and FdReceiver.
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9966
To: chinmoyr, #frameworks, thiago, dfaure, ossi
Cc: ngraham, fvogt, lbeltrame, dfau
chinmoyr added a dependent revision: D10410: Move the task of cleaning up of
socket file to file ioslave and FdReceiver.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D10409
To: chinmoyr, #frameworks, ossi
Cc: michaelh, ngraham
chinmoyr created this revision.
chinmoyr added reviewers: Frameworks, ossi.
Restricted Application added a project: Frameworks.
chinmoyr requested review of this revision.
REVISION SUMMARY
The class SocketAddress is meant only for creating a proper socket address
structure. It should not be han
chinmoyr updated this revision to Diff 26830.
chinmoyr added a comment.
Added back "/tmp/" prefix
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10409?vs=26828&id=26830
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D10409
AFFECTED FILES
src
chinmoyr added a dependent revision: D10409: In linux don't use abstract socket
to share file descriptor.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D10273
To: chinmoyr, #frameworks
Cc: ossi, thiago, dfaure, michaelh, ngraham
chinmoyr created this revision.
chinmoyr added reviewers: Frameworks, ossi.
Restricted Application added a project: Frameworks.
chinmoyr requested review of this revision.
REVISION SUMMARY
Use pathname socket for better security. The socket path will be provided by
file ioslave.
Depends on
jtamate added a comment.
Just to let you know that I know how to reproduce the high I/O of plasmashell
and continuous calls to Kservice.
You can reproduce it just having opened the vivaldi web browser. (I never
though it could be a problem).
If it goes to a webpage that still uses flash,
Friedrich W. H. Kossebau wrote:
Hi,
> So all the PNG versions are there as handcrafted optimized versions of their
> SVG counterpart, so the icons are still usable when needed in sizes of
> 16,22,24,32,48,...
Isn't that an answer to the question "why are there also png icons" (or to "why
are s
paullesur added a comment.
In https://phabricator.kde.org/D10365#203432, @astippich wrote:
> I was a little bit hesitant at first, but I'm starting to like the idea of
a cassette as an icon for Elisa. But I think the text in the icon is not
required. It will usually be so small that no-o
chinmoyr added a comment.
Is the patch good enough to be pushed?
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9966
To: chinmoyr, #frameworks, thiago, dfaure, ossi
Cc: ngraham, fvogt, lbeltrame, dfaure, michaelh
chinmoyr abandoned this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D6198
To: chinmoyr, elvisangelaccio, #frameworks
Cc: fvogt, dfaure, davidedmundson, michaelh, ngraham
chinmoyr added a comment.
In https://phabricator.kde.org/D10141#197039, @fvogt wrote:
> There is one issue I have with this. While this is close to the `sudo`-mode
of temporary authorization grants, it doesn't work that way as the whole
session has full access via file.so.
How ex
mart added a comment.
+1 from me
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D10405
To: hein, dfaure, davidedmundson, mart
Cc: #frameworks, michaelh, ngraham
hein updated this revision to Diff 26821.
hein added a comment.
Remove unrelated changes.
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10405?vs=26820&id=26821
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D10405
AFFECTED FILES
src/widgets
hein added a comment.
Argh, sorry for the noisy diff, I didn't do commit -a but arc did I guess ...
I'll clean this up, one sec.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D10405
To: hein, dfaure, davidedmundson, mart
Cc: #frameworks, michaelh, ngraham
hein created this revision.
hein added reviewers: dfaure, davidedmundson, mart.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
hein requested review of this revision.
REVISION SUMMARY
Without this patch, runCommandInternal tries running
Am Freitag, 9. Februar 2018, 14:11:34 CET schrieb Friedrich W. H. Kossebau:
> Am Freitag, 9. Februar 2018, 10:07:35 CET schrieb René J.V. Bertin:
> > - where are the instructions on how to install (only) the
> > scalable version?
Oh, my reply was done for a "how to install only" question, forgot t
Am Freitag, 9. Februar 2018, 10:07:35 CET schrieb René J.V. Bertin:
> I just discover that the huge source tarball size of the oxygen-icons5 theme
> is not a result of it using png icons, but of an enormous collection of SVG
> icons.
>
> Two questions arise:
> - why are they there so many more tha
Hi,
I just discover that the huge source tarball size of the oxygen-icons5 theme is
not a result of it using png icons, but of an enormous collection of SVG icons.
Two questions arise:
- why are they there so many more than there are png icons (= what are they
used for)?
- where are the instruc
astippich added a comment.
I was a little bit hesitant at first, but I'm starting to like the idea of a
cassette as an icon for Elisa. But I think the text in the icon is not
required. It will usually be so small that no-one can read it.
Anyways, Matthieu should have a comment about this.
51 matches
Mail list logo