D26145: Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 71995. ahmadsamir added a comment. Link to KF6 task REPOSITORY R174 KContacts CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26145?vs=71959&id=71995 BRANCH l-qregularexpression (branched from master) REVISION DETAIL https://phabricato

D26106: Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 71994. ahmadsamir added a comment. Link to KF6 task REPOSITORY R269 BluezQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26106?vs=71843&id=71994 BRANCH l-qregularexpression (branched from master) REVISION DETAIL https://phabricator.

D26099: Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 71992. ahmadsamir added a comment. Link to KF6 task REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26099?vs=71954&id=71992 BRANCH l-qregexp (branched from master) REVISION DETAIL https://phabricator.kde.org/D2609

D26145: Port QRegExp to QRegularExpression

ahmadsamir created this revision. ahmadsamir added reviewers: mlaurent, vkrause. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY With QRegularExpression \x escape sequences that use more than two hex digists have be in the form \x{}. TEST

D26099: Port QRegExp to QRegularExpression

ahmadsamir marked an inline comment as done. ahmadsamir added a comment. I guess I was confused because I saw KItemModels has the min. Qt version 5.12.0 REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D26099 To: ahmadsamir, #baloo, meven, bruns, astippich, mlaurent Cc:

D26099: Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 71954. ahmadsamir added a comment. Don't assign inside if condition REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26099?vs=71943&id=71954 BRANCH l-qregexp (branched from master) REVISION DETAIL https://phabricat

D26118: Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 71948. ahmadsamir added a comment. KF5 now requires Qt 5.12 REPOSITORY R283 KAuth CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26118?vs=71884&id=71948 BRANCH l-qregularexpression (branched from master) REVISION DETAIL https://phabri

D26106: Port QRegExp to QRegularExpression

ahmadsamir edited reviewers, added: Frameworks; removed: Framework: Syntax Highlighting. REPOSITORY R269 BluezQt REVISION DETAIL https://phabricator.kde.org/D26106 To: ahmadsamir, drosca, #frameworks, #framework_syntax_highlighting Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraha

D26099: Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 71943. ahmadsamir added a comment. Frameworks now require Qt 5.12 REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26099?vs=71936&id=71943 BRANCH l-qregexp (branched from master) REVISION DETAIL https://phabricator

D26123: Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 71941. ahmadsamir added a comment. Frameworks min. required Qt has just been raised to 5.12 REPOSITORY R270 KCodecs CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26123?vs=71934&id=71941 BRANCH l-qregexp (branched from master) REVISION

D26123: Port QRegExp to QRegularExpression

ahmadsamir added a comment. Sorry, I did reply to your inline comments but didn't "submit" the replies only "save draft"ed. REPOSITORY R270 KCodecs REVISION DETAIL https://phabricator.kde.org/D26123 To: ahmadsamir, #frameworks, dfaure, mlaurent, vkrause Cc: kde-frameworks-devel, LeGast0

D26123: Port QRegExp to QRegularExpression

ahmadsamir added inline comments. INLINE COMMENTS > dfaure wrote in kemailaddress.cpp:631 > Message from Giuseppe D'Angelo (author of QRegularExpression) : if you can > depend from Qt 5.12, there's QRegularExpression::anchoredPattern instead of > manual wrapping in \A and \z > > We can't requ

D26099: Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 71936. ahmadsamir added a comment. Add TODO for when we can depend on Qt 5.12 REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26099?vs=71888&id=71936 BRANCH l-qregexp (branched from master) REVISION DETAIL https:/

D26106: Port QRegExp to QRegularExpression

ahmadsamir added a reviewer: Framework: Syntax Highlighting. REPOSITORY R269 BluezQt REVISION DETAIL https://phabricator.kde.org/D26106 To: ahmadsamir, drosca, #framework_syntax_highlighting Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26102: QAtomicInteger::loadRelaxed() and storeRelaxed() are available since Qt 5.14

ahmadsamir added a reviewer: mlaurent. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D26102 To: ahmadsamir, #baloo, meven, bruns, astippich, mlaurent Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippic

D26123: Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 71934. ahmadsamir marked 4 inline comments as done. ahmadsamir edited the summary of this revision. ahmadsamir added a comment. Address review comments REPOSITORY R270 KCodecs CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26123?vs=71907&id

D26136: Port QRegExp to QRegularExpression

ahmadsamir created this revision. ahmadsamir added a reviewer: Frameworks. Herald added a project: Frameworks. ahmadsamir requested review of this revision. TEST PLAN make && ctest REPOSITORY R265 KConfigWidgets BRANCH l-qregularexpression (branched from master) REVISION DETAIL https://

D26123: Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 71907. ahmadsamir edited the summary of this revision. ahmadsamir added a comment. One more QRegExp REPOSITORY R270 KCodecs CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26123?vs=71900&id=71907 BRANCH l-qregexp (branched from master) R

D26123: Port QRegExp to QRegularExpression

ahmadsamir planned changes to this revision. ahmadsamir added a comment. I missed one QRegExp. REPOSITORY R270 KCodecs REVISION DETAIL https://phabricator.kde.org/D26123 To: ahmadsamir, #frameworks, dfaure, mlaurent, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, b

D26123: Port QRegExp to QRegularExpression

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, mlaurent, vkrause. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY I had to modify the regex pattern slightly to make kemailaddresstest pass TEST PLAN make && c

D26099: Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 71888. ahmadsamir removed a subscriber: mlaurent. ahmadsamir added a comment. Revert min required Qt version REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26099?vs=71869&id=71888 BRANCH l-qregexp (branched from mas

D26101: Port away from Qt 5.14 deprecated QList methods

This revision was automatically updated to reflect the committed changes. Closed by commit R293:e1ad18533db3: Port away from Qt 5.14 deprecated QList methods (authored by ahmadsamir). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26101?vs=71837&id=71885 REVISI

D26118: Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 71884. ahmadsamir marked an inline comment as done. ahmadsamir added a comment. Don't touch Qt required version directly for frameworks. Use \A and \z anchors instead of the convenience function QRegularExpression::anchoredPattern() REPOSITORY R

D26118: Port QRegExp to QRegularExpression

ahmadsamir marked an inline comment as done. ahmadsamir added inline comments. INLINE COMMENTS > mlaurent wrote in CMakeLists.txt:14 > kauth is a framework package. You can't increase qt version directly. I didn't know that, sorry. Luckily fixing it is easy in this particular case, I'll anchor

D26118: Port QRegExp to QRegularExpression

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, mlaurent. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY Require Qt 5.12 for QRegularExpression::anchoredPattern() TEST PLAN make && ctest REPOSITORY R283 KAuth BR

D26099: Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 71869. ahmadsamir edited the summary of this revision. ahmadsamir added a comment. Use QRegularExpression::anchoredPattern() to port QRegExp::exactMatch() REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26099?vs=71832&i

D26099: Port QRegExp to QRegularExpression

ahmadsamir planned changes to this revision. ahmadsamir added a comment. I messed up exactMatch stuff, will have to rethink it. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D26099 To: ahmadsamir, #baloo, meven, bruns, astippich Cc: kde-frameworks-devel, hurikhan77, l

D26106: Port QRegExp to QRegularExpression

ahmadsamir created this revision. ahmadsamir added a reviewer: drosca. Herald added a project: Frameworks. ahmadsamir requested review of this revision. TEST PLAN The code compiles and the unit tests pass. REPOSITORY R269 BluezQt BRANCH l-qregularexpression (branched from master) REVISION

D26101: Port away from Qt 5.14 deprecated QList methods

ahmadsamir updated this revision to Diff 71837. ahmadsamir added a task: T11553: Port KDE Frameworks away from deprecated methods in Qt. ahmadsamir added a comment. Link to T11553 REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde

D26102: QAtomicInteger::loadRelaxed() and storeRelaxed() are available since Qt 5.14

ahmadsamir created this revision. ahmadsamir added reviewers: Baloo, meven, bruns, astippich. Herald added projects: Frameworks, Baloo. ahmadsamir requested review of this revision. TEST PLAN make && ctest REPOSITORY R293 Baloo BRANCH l-qt14-deprecated-2 (branched from master) REVISION DE

D26101: Port away from Qt 5.14 deprecated QList methods

ahmadsamir updated this revision to Diff 71835. ahmadsamir retitled this revision from "Port away from Qt 14.0 deprecated QList methods" to "Port away from Qt 5.14 deprecated QList methods". ahmadsamir added a comment. Qt 14 hasn't been released yet (I kept thinking something looks wrong...)

D26101: Port away from Qt 14.0 deprecated QList methods

ahmadsamir created this revision. ahmadsamir added reviewers: Baloo, meven, bruns, astippich. Herald added projects: Frameworks, Baloo. ahmadsamir requested review of this revision. REVISION SUMMARY Refactor FileIndexerConfig::excludeFilters() as it doesn't make sense to me to convert to a QSt

D26099: Port QRegExp to QRegularExpression

ahmadsamir created this revision. ahmadsamir added reviewers: Baloo, meven, bruns, astippich. Herald added projects: Frameworks, Baloo. ahmadsamir requested review of this revision. TEST PLAN The code builds and unit tests pass. REPOSITORY R293 Baloo BRANCH l-qregexp (branched from master)

D25980: [KAutoSaveFile] Use QUrl::path() instead of toLocalFile()

ahmadsamir added a comment. In D25980#579978 , @dfaure wrote: > Yes. This matches the path() on line 77. Thanks for the pointer. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D25980 To: ahmadsamir, #framewo

D25980: [KAutoSaveFile] Use QUrl::path() instead of toLocalFile()

This revision was automatically updated to reflect the committed changes. Closed by commit R244:8e2768a69075: [KAutoSaveFile] Use QUrl::path() instead of toLocalFile() (authored by ahmadsamir). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25980?vs=71493&

D23457: Port the search interface from QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 71618. ahmadsamir retitled this revision from "Port regex search to QRegularExpression" to "Port the search interface from QRegExp to QRegularExpression". ahmadsamir edited the summary of this revision. ahmadsamir edited the test plan for this revision. ah

D23457: Port regex search to QRegularExpression

ahmadsamir added a comment. Disagreement doesn't always mean distrust. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D23457 To: ahmadsamir, #ktexteditor, dhaumann, cullmann Cc: kde-frameworks-devel, kwrite-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns

D23457: Port regex search to QRegularExpression

ahmadsamir updated this revision to Diff 71617. ahmadsamir added a comment. Address comments REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23457?vs=71178&id=71617 BRANCH l-qregularexpression (branched from master) REVISION DETAIL https://phabricat

D25979: [KAutoSaveFile] Improve the comment in tempFileName()

This revision was automatically updated to reflect the committed changes. Closed by commit R244:0699c27a022a: [KAutoSaveFile] Improve the comment in tempFileName() (authored by ahmadsamir). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25979?vs=71492&id=7

D25980: [KAutoSaveFile] Use QUrl::path() instead of toLocalFile()

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, mpyne, dfaure, mardelle. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY In staleMatchesManaged() using toLocalFile() means that it'll fail for remote files, e.g. fish:/

D25979: [KAutoSaveFile] Improve the comment in tempFileName()

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, mpyne, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY Hopefully now it's clear that the filename length in this context is the filename component only, e.g. tes

D24489: KAutosaveFile not respecting maximum filename length

ahmadsamir added a comment. According to [1], for windows, it's _MAX_FNAME defined in stdlib.h [1] https://docs.microsoft.com/en-us/cpp/c-runtime-library/path-field-limits?view=vs-2019 see also https://docs.microsoft.com/en-us/cpp/c-runtime-library/filename-max?view=vs-2019 Howeve

D24489: KAutosaveFile not respecting maximum filename length

ahmadsamir added a comment. FWIW, this broke kautosavefiletest: 3: * Start testing of KAutoSaveFileTest * 3: Config: Using QtTest library 5.13.1, Qt 5.13.1 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 9.2.1 20190903 [gcc-9-branch revision 275330

D25767: KAutoSaveFile: add a unit test to check max. filename length

This revision was automatically updated to reflect the committed changes. Closed by commit R244:f9e62dc0239d: KAutoSaveFile: add a unit test to check max. filename length (authored by ahmadsamir). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25767?vs=710

D23457: Port regex search to QRegularExpression

ahmadsamir added a comment. Personally, I am not convinced replacing \s with [ \t], and deviating from PCRE default behaviour is a good idea in this case. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D23457 To: ahmadsamir, #ktexteditor, dhaumann, cullmann Cc: k

D23457: Port regex search to QRegularExpression

ahmadsamir updated this revision to Diff 71178. ahmadsamir added a comment. clang-fromat the code in this diff REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23457?vs=71059&id=71178 BRANCH l-qregularexpression (branched from master) REVISION DETAIL

D25720: Fix shortcut conflict between Cut and Delete File

ahmadsamir added a comment. In D25720#573926 , @elvisangelaccio wrote: > In D25720#572291 , @ngraham wrote: > > > Though Dolphin seems to have some kind of local hack to make Shift+delete work for

D23457: Port regex search to QRegularExpression

ahmadsamir updated this revision to Diff 71059. ahmadsamir added a comment. Rebase REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23457?vs=64618&id=71059 BRANCH l-qregularexpression (branched from master) REVISION DETAIL https://phabricator.kde.org

D25767: KAutoSaveFile: add a unit test to check max. filename length

ahmadsamir added inline comments. INLINE COMMENTS > dhaumann wrote in kautosavefiletest.cpp:98 > What I wonder is: PATH_MAX etc are #defines, right? Since on Windows there is > a registry flag to enable much longer paths/file names. My intention is not > to block this series of patches, but we

D25767: KAutoSaveFile: add a unit test to check max. filename length

ahmadsamir updated this revision to Diff 71047. ahmadsamir added a comment. Address comments REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25767?vs=70968&id=71047 BRANCH l-kautosave-unittest (branched from master) REVISION DETAIL https://phabrica

D24489: KAutosaveFile not respecting maximum filename length

ahmadsamir added a comment. In D24489#573152 , @mardelle wrote: > The unittest is in another diff because it's a different author I guess. [...] I didn't mean to step on your toes; feel free to disregard the unit test I wrote, or reuse

D24489: KAutosaveFile not respecting maximum filename length

ahmadsamir added a comment. Unit test added in D25767 . AFAICS, both points addressed in this diff are needed to fix the referenced bug. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D24489 To: mardelle, #frameworks, dfaure,

D24489: KAutosaveFile not respecting maximum filename length

ahmadsamir added a reviewer: mpyne. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D24489 To: mardelle, #frameworks, dfaure, mpyne Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25767: KAutoSaveFile: add a unit test to check max. filename length

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, mpyne. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY In KAutoSaveFilePrivate::tempFile() the name of the kautosavefile that's going to be created is generated using th

D24489: KAutosaveFile not respecting maximum filename length

ahmadsamir added a dependent revision: D25767: KAutoSaveFile: add a unit test to check max. filename length. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D24489 To: mardelle, #frameworks, dfaure Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngra

D25755: Replace iterators with range-based for

ahmadsamir added a subscriber: dfaure. REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D25755 To: nicolasfella, #frameworks Cc: dfaure, ahmadsamir, broulik, aacid, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25755: Replace iterators with range-based for

ahmadsamir added a comment. If we're going to iterate over a whole container, from cbegin() to cend(), and the container isn't going to change in the loop, then IMHO (H for humble :)) range-for would convey the intention better and make the code slightly easier to read/look cleaner. Kin

D25420: [KFileWidget] Avoid calling slotOk right after the url changed

ahmadsamir added a comment. FWIW, this still doesn't work: - Open a pdf in okular - Invoke save as, navigate via the keyboard, highlight/select a dir, Enter, the file is saved inside that dir and the dialog closes REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25

D24489: KAutosaveFile not respecting maximum filename length

ahmadsamir added a comment. tempFilename() actually changes the filename to include the whole path plus some other bits and pieces; but as @mardelle proposes, the maximum filename length is NAME_MAX and it should take into account the percent encoding. Again, sorry about the noise... RE

D25420: [KFileWidget] Avoid calling slotOk right after the url changed

ahmadsamir added a comment. >> And, of course, more unit tests like the one in D19824 ... :D > > This was not an automated test. OK, thanks for clarifying that. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25420 To: meven

D24489: KAutosaveFile not respecting maximum filename length

ahmadsamir added a comment. I was wrong, indeed NAME_MAX is what should be used; looking at the code in KAutoSaveFile::open(), and how tempFileName() is actually used: tempFile = staleFilesDir + QChar::fromLatin1('/') + d->tempFileName(); NAME_MAX is what should be used, as tempFil

D25420: [KFileWidget] Avoid calling slotOk right after the url changed

ahmadsamir added a comment. In D25420#571483 , @dfaure wrote: > So after a double-click, activated() is emitted, the boolean is set, and much later some Key_Enter event that should have been emitted, gets eaten? > > Wouldn't an event filter o

D25420: [KFileWidget] Avoid calling slotOk right after the url changed

ahmadsamir added a reviewer: dfaure. ahmadsamir added a comment. IMHO, it's such a user-visible bug with several reports and it affects all apps that use KIO; it should be included if it can catch the 5.65 train. I can confirm it fixes the issue in my local build (and the code LGTM). REP

D24828: KRun: don't override user preferred app when opening local *.*html and co. files

ahmadsamir added a subscriber: ngraham. ahmadsamir added a comment. @ngraham: I do know how to land a diff :) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24828 To: ahmadsamir, #frameworks, dfaure Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24489: KAutosaveFile not respecting maximum filename length

ahmadsamir added a comment. IIUC, FILENAME_MAX corresponds to PATH_MAX, 4096 (bytes; or chars in an array). NAME_MAX is the max. filename (the filename part only, without the canonical path) length, this is 255 on Linux. So using FILENAME_MAX is correct in the code. See: http

D23457: Port regex search to QRegularExpression

ahmadsamir added a comment. In D23457#568067 , @dhaumann wrote: > Any news here? For starters, this needs to be rebased; I'll try and get to it soon. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D23457 To:

D25631: Replace KRecursiveFilterProxyModel with QSortFilterProxyModel

ahmadsamir added a comment. Thank you. REPOSITORY R36 Ark REVISION DETAIL https://phabricator.kde.org/D25631 To: ahmadsamir, #ark, elvisangelaccio, apol Cc: apol, kde-frameworks-devel, kde-utils-devel, fbampaloukas, tctara

D25631: Replace KRecursiveFilterProxyModel with QSortFilterProxyModel

This revision was automatically updated to reflect the committed changes. Closed by commit R36:aee422b0b2c4: Replace KRecursiveFilterProxyModel with QSortFilterProxyModel (authored by ahmadsamir). REPOSITORY R36 Ark CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25631?vs=70624&id=706

D25631: Replace KRecursiveFilterProxyModel with QSortFilterProxyModel

ahmadsamir created this revision. ahmadsamir added reviewers: Ark, elvisangelaccio. Herald added a project: Ark. ahmadsamir requested review of this revision. REVISION SUMMARY KRecursiveFilterProxyModel was only needed to have recursive filtering, which became available upstream since Qt 5.10.

D24349: More fixes to compile without implicit conversion from ASCII/ByteArray

This revision was automatically updated to reflect the committed changes. ahmadsamir marked an inline comment as done. Closed by commit R241:54ccb1ac4883: More fixes to compile without implicit conversion from ASCII/ByteArray (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPD

D24349: More fixes to compile without implicit conversion from ASCII/ByteArray

ahmadsamir updated this revision to Diff 70407. ahmadsamir added a comment. Per dfaure's recommendation, change createSystemBookmark 2nd and 3rd params to take a const char * (since this is the translation context which will be dropped) and a QByteArray, respectively. REPOSITORY R241 KIO

D24349: More fixes to compile without implicit conversion from ASCII/ByteArray

ahmadsamir added inline comments. INLINE COMMENTS > yurchor wrote in kfileplacesmodel.cpp:275 > This does not work. Our translation system cannot extract from something like > > I18NC_NOOP(fsBookmarks, QStringLiteral("Desktop")) > > all the strings below with I18NC_NOOP should be left as is. Th

D24349: More fixes to compile without implicit conversion from ASCII/ByteArray

ahmadsamir updated this revision to Diff 70379. ahmadsamir marked 5 inline comments as done. ahmadsamir added a comment. - Keep I18NC_NOOP working - QLatin1String where appropriate - Rename mProtocolToStr() to protocolName(), and make it private (only used in slavebase) REPOSITORY R241

D24349: More fixes to compile without implicit conversion from ASCII/ByteArray

ahmadsamir added a comment. Ping. (I want to get this committed to close the gates before any more implicit conversions sneak in :)). REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24349 To: ahmadsamir, dfaure, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, mic

D24349: More fixes to compile without implicit conversion from ASCII/ByteArray

ahmadsamir updated this revision to Diff 70271. ahmadsamir marked 8 inline comments as done. ahmadsamir retitled this revision from "More (and last) fixes to compile without implicit conversion from ASCII/ByteArray" to "More fixes to compile without implicit conversion from ASCII/ByteArray". ahma

D24349: More fixes to compile without implicit conversion from ASCII/ByteArray

ahmadsamir added inline comments. INLINE COMMENTS > dfaure wrote in slavebase.h:979 > This method should be const A B C, nothing changed inside make it const, D E F. > dfaure wrote in ftp.cpp:1232 > Should this be remoteEncoding()->decode(...) given that the method will then > use q->remoteEnc

D25465: [DropJob] Minor grammar fix in API docs

This revision was automatically updated to reflect the committed changes. Closed by commit R241:81167ec94f8d: [DropJob] Minor grammar fix in API docs (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25465?vs=70167&id=70169 REVISION DETAIL

D25465: [DropJob] Minor grammar fix in API docs

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, apol. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REPOSITORY R241 KIO BRANCH l-grammar (branched from master) REVISION DETAIL https://phabricator.kde.org/D25465 AFFECTED

D25421: [kio_tags] improve log message when the database can't be opened

ahmadsamir updated this revision to Diff 70062. ahmadsamir retitled this revision from "[file_extractor] improve log message when the database can't be opened" to "[kio_tags] improve log message when the database can't be opened". ahmadsamir edited the summary of this revision. ahmadsamir removed

D25421: [file_extractor] improve log message when the database can't be opened

ahmadsamir added a comment. In D25421#565217 , @bruns wrote: > This is obviously the wrong line of code for the referenced bug report. Well, it's obvious now. :) (I should have tested, but now that I try to test, I can't reproduce the

D25421: [file_extractor] improve log message when the database can't be opened

ahmadsamir created this revision. ahmadsamir added reviewers: Baloo, astippich. Herald added projects: Frameworks, Baloo. ahmadsamir requested review of this revision. REVISION SUMMARY Bug: 407786 REPOSITORY R293 Baloo BRANCH l-log-messages (branched from master) REVISION DETAIL https:/

D24951: [KOpenWithDialog] Automatically select the result if the model filter has only one match

ahmadsamir added a comment. Ping. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24951 To: ahmadsamir, dfaure, ngraham, #frameworks, #vdg Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24951: [KOpenWithDialog] Automatically select the result if the model filter has only one match

ahmadsamir added reviewers: Frameworks, VDG. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24951 To: ahmadsamir, dfaure, ngraham, #frameworks, #vdg Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24873: [http kio slave] use QSslSocket instead of KTcpSocket (deprecated)

This revision was automatically updated to reflect the committed changes. Closed by commit R241:f39eb884fecc: [http kio slave] use QSslSocket instead of KTcpSocket (deprecated) (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24873?vs=68702

D24828: KRun: don't override user preferred app when opening local *.*html and co. files

ahmadsamir added a comment. Ping. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24828 To: ahmadsamir, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24928: [TcpSlaveBase] port from KTcpSocket (deprecated) to QSslSocket

This revision was automatically updated to reflect the committed changes. Closed by commit R241:14c6c0007c42: [TcpSlaveBase] port from KTcpSocket (deprecated) to QSslSocket (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24928?vs=68836&id=

D24980: Port ssl_cert_errors meta data from KSslError to QSslError

ahmadsamir added inline comments. INLINE COMMENTS > vkrause wrote in jobuidelegate.cpp:365 > sslMetaData is a QMap, ie. value() has no QLatin1String > overload, calling it with a QLatin1String will work but convert to a QString > at runtime (involving a memory allocation), using QStringLiteral

D24980: Port ssl_cert_errors meta data from KSslError to QSslError

ahmadsamir added inline comments. INLINE COMMENTS > jobuidelegate.cpp:365 > > sslMetaData.value(QStringLiteral("ssl_cipher_bits")).toInt(), > - > KSslInfoDialog::errorsFromString(sslMetaData.value(QStringLiteral("ssl_cert_errors"; > +

D25152: Reenable the tests and only disable krcrashtest on windows

ahmadsamir added a comment. In D25152#558886 , @sitter wrote: > Heh, sorry 😉 Don't be sorry, yours is actually a fix, mine isn't/wasn't :D > D25153 for reference. REPOSITORY R285 KCrash REVISIO

D25152: Reenable the tests and only disable krcrashtest on windows

ahmadsamir abandoned this revision. ahmadsamir added a comment. @sitter: I see you have a fix already :) REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D25152 To: ahmadsamir, #frameworks, sitter Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25152: Reenable the tests and only disable krcrashtest on windows

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, sitter. Herald added a project: Frameworks. ahmadsamir requested review of this revision. TEST PLAN Code builds and tests pass on Linux REPOSITORY R285 KCrash BRANCH l-win-test (branched from master) REVISION DETAIL

kde-frameworks-devel@kde.org

ahmadsamir added inline comments. INLINE COMMENTS > kossebau wrote in ftp.cpp:1376 > `QUrl::fileName()` returns a value QString, so just > > const QString filename = empurl.fileName(); > > While > > const QString &filename = empurl.fileName(); > > also is fine code IIRC, as I once learned

D25079: [CopyJob] Increase the amount of data sendfile can copy at once

ahmadsamir added a comment. Hopefully may fix https://bugs.kde.org/show_bug.cgi?id=402276 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25079 To: meven, dfaure, #frameworks, davidedmundson Cc: ahmadsamir, sitter, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D12283: Allow to load dictionaries form a rcc

ahmadsamir added a comment. IINM, in the commit message s/form a rcc/from an rcc/. REPOSITORY R246 Sonnet BRANCH master REVISION DETAIL https://phabricator.kde.org/D12283 To: vonreth, mlaurent Cc: ahmadsamir, kde-frameworks-devel, habacker, LeGast00n, GB_2, michaelh, ngraham, bruns

D24951: [KOpenWithDialog] Automatically select the result if the model filter has only one match

ahmadsamir added a comment. In D24951#554516 , @dfaure wrote: > A sort model allows to define any sorting criteria you want (see QSortFilterProxyModel::lessThan), so this is technically possible: the criteria would say "if A is a match and B isn

D24928: [TcpSlaveBase] port from KTcpSocket (deprecated) to QSslSocket

ahmadsamir added a comment. In D24928#554731 , @vkrause wrote: > In D24928#554720 , @ahmadsamir wrote: > > > So, we ditch digestMethod but keep the rest? ecryptionMethod/authenticationMethod/keyExch

D24928: [TcpSlaveBase] port from KTcpSocket (deprecated) to QSslSocket

ahmadsamir updated this revision to Diff 68836. ahmadsamir edited the summary of this revision. ahmadsamir added a comment. Verbatim REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24928?vs=68834&id=68836 BRANCH ahmad/tcpslavebase (branched from master) REVI

D24928: [TcpSlaveBase] port from KTcpSocket (deprecated) to QSslSocket

ahmadsamir updated this revision to Diff 68834. ahmadsamir added a comment. cipher.name() is deemed sufficient when setting the ssl MetaData REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24928?vs=68701&id=68834 BRANCH ahmad/tcpslavebase (branched from maste

D24928: [TcpSlaveBase] port from KTcpSocket (deprecated) to QSslSocket

ahmadsamir added a comment. So, we ditch digestMethod but keep the rest? ecryptionMethod/authenticationMethod/keyExchangeMethod can be deduced from the name() sometimes, but some others, not so obvious: Name: "TLS_AES_256_GCM_SHA384" Encryption method: "AESGCM(256)" Auth meth

D24951: [KOpenWithDialog] Automatically select the result if the model filter has only one match

ahmadsamir added a comment. In D24951#554516 , @dfaure wrote: > A sort model allows to define any sorting criteria you want (see QSortFilterProxyModel::lessThan), so this is technically possible: the criteria would say "if A is a match and B isn

<    3   4   5   6   7   8   9   10   >