?
- Aleix Pol Gonzalez
On Oct. 23, 2015, 8:25 a.m., Christoph Cullmann wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
3380cbe
autotests/jobtest.cpp c24bcea
autotests/jobtest.h ef8c3e1
Diff: https://git.reviewboard.kde.org/r/125164/diff/
Testing
---
Added a test and made it pass.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks
-
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125164/#review87245
---
On Sept. 11, 2015, 3:24 p.m., Aleix Pol Gonzalez wrote:
>
>
/transferjob.cpp 0c38070
Diff: https://git.reviewboard.kde.org/r/125164/diff/
Testing
---
Added a test and made it pass.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo
posed to take care of emitting finished already, and you
> > don't want to emit it twice.
>
> Aleix Pol Gonzalez wrote:
> slotFinished is never called, if I remove the slotFinished call the test
> never ends.
I got deep to the issue. Here's the catch:
SchedulerPrivate::jo
on the reviews
there:
https://git.reviewboard.kde.org/r/125613/
Will have to look into how to fix properly, whatever that means.
- Aleix Pol Gonzalez
On Oct. 29, 2015, 1:35 p.m., Aleix Pol Gonzalez wrote
> On Oct. 29, 2015, 9:26 p.m., Aleix Pol Gonzalez wrote:
> > autotests/kdeplatformtheme_unittest.cpp, line 237
> > <https://git.reviewboard.kde.org/r/125877/diff/1/?file=413361#file413361line237>
> >
> > What does `qApp->wheelScrollLines()
tps://git.reviewboard.kde.org/r/125877/#comment60168>
What does `qApp->wheelScrollLines()` return now?
- Aleix Pol Gonzalez
On Oct. 29, 2015, 9:22 p.m., David Rosca wrote:
>
> ---
> This is an automatically generated e-mai
---
Booted again, tests still pass, no warnings.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
marked as submitted.
Review request for KDE Frameworks and Plasma.
Changes
---
Submitted with commit 36288df5ac48901134ca98ff8131d87ad434e2a1 by Aleix Pol to
branch master.
Repository: plasma-framework
Description
---
It was checking that a variable existed, then it used it. Now
documentation just works.
Needs figuring out for more complex cases, I'm unsure if applications are
opening the documentation in specific pages. In fact, I couldn't find the
documentation for docs.kde.org url scheme, and I just made up the `path` part,
although it seems to work.
Thanks,
Aleix Pol
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125766/#review87311
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Oct. 23, 2015
g/r/125766/#comment59966>
Use qputenv, also then the strdup isn't necessary.
src/kded.cpp (line 686)
<https://git.reviewboard.kde.org/r/125766/#comment59967>
Maybe it should set up KAboutData as well?
- Aleix Pol Gonzalez
On Oct. 23, 2015, 4:36 p.m., Antonio Larrosa J
> On Oct. 23, 2015, 5:09 p.m., Aleix Pol Gonzalez wrote:
> > Ship It!
Eh sorry I pressed that by fault, I don't know how it got confirmed. My actual
review follows.
- Aleix
---
This is an automatically generated e-mail.
marked as submitted.
Review request for KDE Frameworks and Sebastian Kügler.
Changes
---
Submitted with commit 32e48f1911103537645c77d50ea3ddc192b0befe by Aleix Pol to
branch master.
Repository: kcoreaddons
Description
---
I know this could be done so much better and there's
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125760/#review87320
---
+1 looks good to me.
- Aleix Pol Gonzalez
On Oct. 23, 2015
-
Tests pass, plasma still boots.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
f: https://git.reviewboard.kde.org/r/125750/diff/
Testing
---
Tests pass, plasma still boots.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126054/#review88330
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On nov. 13, 2015
to work.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
d88b566
src/kdeclarative/private/rootcontext_p.h 94df09f
Diff: https://git.reviewboard.kde.org/r/126088/diff/
Testing
---
Tests still pass, apps still work, plasma still works as well.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel
org/r/126086/#comment60602>
Move it in the upper CMakeLists.txt file together with
`include(ECMGenerateHeaders)`.
Otherwise looks good to me. +1
- Aleix Pol Gonzalez
On Nov. 16, 2015, 1:47 p.m., René J.V. Bertin
://git.reviewboard.kde.org/r/126084/diff/
Testing
---
Builds, tests pass.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
> On Nov. 15, 2015, 12:33 a.m., Aleix Pol Gonzalez wrote:
> > src/runtime/kwallet-query/src/CMakeLists.txt, line 20
> > <https://git.reviewboard.kde.org/r/126069/diff/1/?file=416871#file416871line20>
> >
> > Why only for APPLE?
>
> René J.V. Bertin wr
tps://git.reviewboard.kde.org/r/126078/#comment60588>
You removed Carbon from cmake, no?
I'm not sure why you're keeping both really. If IOKit is the way to go,
then do it.
In fact, I'm quite sure that as is it already is broken without the #define
- Aleix Pol Gonzalez
On Nov. 15, 2015, 11:
>
> Martin Gräßlin wrote:
> I agree with Marco: we should try to split this up again. Somehow the
> framework starts to remind me of kdelibs4 and in applications I maintain it
> takes a lot of strength to buy into using it. (Why would I want KIO in KWin?)
>
> Aleix Pol Gonzalez
s about?
To me it's clear that KIconProvider could go to KIconThemes and
KIOAccessManagerFactory could go to KIO.
- Aleix
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126087/#review88463
-
--------
On Nov. 16, 2015, 3:55 p.m., Aleix Pol Gonzalez wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126087/
> -
viewboard.kde.org/r/126087/#review88459
---
On Nov. 16, 2015, 3:55 p.m., Aleix Pol Gonzalez wrote:
>
> ---
> This is an automatically generated e-mail. To reply, v
e to call the QPrivateSignal from
there.
- Aleix
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125924/#review87922
---
On Nov. 2, 20
c/widgets/kernel/qapplication.cpp:3498
```
Repository: kio
Description
---
Scheduler::jobFinished cleans up the job but doesn't report it as such.
Diffs (updated)
-
src/core/simplejob.cpp 3380cbe
autotests/jobtest.h 7641131
autotests/jobtest.cpp 7da92d5
Diff: https:/
marked as submitted.
Review request for KDE Frameworks.
Changes
---
Submitted with commit 17a1ff06f234de4e763494101254542ff49a8659 by Aleix Pol to
branch master.
Repository: kcoreaddons
Description
---
To that end, this patch unifies both duplicated codes so it keeps consistent
://git.reviewboard.kde.org/r/125164/diff/
Testing
---
Added a test and made it pass.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
board.kde.org/r/125941/#comment60357>
You should compare to the file size, otherwise this all will have to be
changed every time these files are modified.
Good first step!
- Aleix Pol Gonzalez
On Nov. 4, 2015, 3:08 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125815/#review87979
---
Bump? Anyone with docs.kde.org knowledge around?
- Aleix Pol
. In fact, I couldn't find the
documentation for docs.kde.org url scheme, and I just made up the `path` part,
although it seems to work.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org
the exact case, but
usually it's good to develop such API outside then when it stabilizes merge to
the framework, I'd say. Otherwise changes in the API will be very hard.
- Aleix Pol Gonzalez
On Nov. 5, 2015, 8:57 p.m., Martin Klapetek wrote
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125975/#review88092
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Nov. 6, 2015
> On Nov. 4, 2015, 1:43 a.m., Aleix Pol Gonzalez wrote:
> > Bump? Anyone with docs.kde.org knowledge around?
>
> Ben Cooksley wrote:
> As long as the application name is being submitted in lower case, it
> should work fine.
>
> Examples:
>
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125164/#review87040
---
bump?
- Aleix Pol Gonzalez
On Sept. 11, 2015, 3:24 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125658/#review87034
---
Ship it!
Makes sense to me.
- Aleix Pol Gonzalez
On Oct
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125332/#review86501
---
+1
- Aleix Pol Gonzalez
On Oct. 8, 2015, 2:30 p.m., Hannah
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125559/#review86515
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Oct. 8, 2015, 7
tps://git.reviewboard.kde.org/r/125725/#comment59874>
Maybe it would make sense to handle it using signal() directly here, rather
than just ifdef'ing KCrash?
- Aleix Pol Gonzalez
On Oct. 20, 2015, 3:41 p.m., Christoph Cullmann
> On Oct. 20, 2015, 3:52 p.m., Aleix Pol Gonzalez wrote:
> > src/kbuildsycoca/kbuildsycoca_main.cpp, line 122
> > <https://git.reviewboard.kde.org/r/125725/diff/1/?file=411919#file411919line122>
> >
> > Maybe it would make sense to handle it using signal(
://git.reviewboard.kde.org/r/125628/diff/
Testing
---
Tests still pass, my system starts reliably.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125480/#review86647
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Oct. 2, 2015, 9
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125535/#review86431
---
+1 LGTM.
- Aleix Pol Gonzalez
On Oct. 6, 2015, 2:44 p.m
can go here?
- Aleix Pol Gonzalez
On Oct. 13, 2015, 3:30 p.m., Elvis Angelaccio wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.revi
tps://git.reviewboard.kde.org/r/125538/#comment59537>
Maybe use qCDebug? So it can be disabled and so.
- Aleix Pol Gonzalez
On Oct. 6, 2015, 9:40 a.m., Emmanuel Pescosta wrote:
>
> ---
> This is an automatically generated e-mail.
> On Oct. 6, 2015, 10:27 a.m., Aleix Pol Gonzalez wrote:
> > src/ioslaves/trash/kio_trash.cpp, line 617
> > <https://git.reviewboard.kde.org/r/125538/diff/1/?file=410023#file410023line617>
> >
> > Maybe use qCDebug? So it can be disabled and so.
>
&g
.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
.
- Aleix Pol Gonzalez
On July 8, 2015, 8:23 a.m., Martin Gräßlin wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124289
.
- Aleix Pol Gonzalez
On July 8, 2015, 8:21 a.m., Martin Gräßlin wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124288
I'd just drop it.
Diffs
-
src/kiconloader.cpp c725115
Diff: https://git.reviewboard.kde.org/r/124307/diff/
Testing
---
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124321/#review82346
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On July 11, 2015
://git.reviewboard.kde.org/r/124321/#comment56702
You should if() the whole if/else statement.
- Aleix Pol Gonzalez
On July 10, 2015, 11:09 p.m., Heiko Becker wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
it figured out, it makes sense to me to support
another format, even if probably nobody is going to ever use man for KF
documentation.
- Aleix Pol Gonzalez
On July 11, 2015, 11:34 p.m., Scott Kitterman wrote
On July 7, 2015, 9:07 p.m., Martin Tobias Holmedahl Sandsmark wrote:
src/plugins/voikko/voikkoclient.cpp, line 32
https://git.reviewboard.kde.org/r/124282/diff/3/?file=383588#file383588line32
I prefer to error out early («if (!dictionaries) return;»), less
indentation and state
.
I don't really know much about Voikko or even Sonnet, so just reviewing the
code.
- Aleix Pol Gonzalez
On July 7, 2015, 4 p.m., Jesse Jaara wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
On July 7, 2015, 2:16 p.m., Hrvoje Senjan wrote:
Seems kwindowsystem master doesn't build now (against Qt 5.5 at least):
```
[ 55s] In file included from
/home/abuild/rpmbuild/BUILD/kwindowsystem-5.12.0git.20150707T133122~569a723/src/kwindowinfo.cpp:21:0:
[ 55s]
Will that pass the DPI test? Have you tested with a different
QT_DEVICE_PIXEL_RATIO?
- Aleix Pol Gonzalez
On July 7, 2015, 2:52 p.m., Martin Klapetek wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
On July 9, 2015, 12:02 p.m., Aleix Pol Gonzalez wrote:
What's the use case?
Elvis Angelaccio wrote:
Basically more user-friendly messages for the users.
See RR 120204 and in particular this screenshot:
https://git.reviewboard.kde.org/r/120204/file/2145/
Aleix Pol Gonzalez
On July 9, 2015, 12:02 p.m., Aleix Pol Gonzalez wrote:
What's the use case?
Elvis Angelaccio wrote:
Basically more user-friendly messages for the users.
See RR 120204 and in particular this screenshot:
https://git.reviewboard.kde.org/r/120204/file/2145/
Why don't you use
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124304/#review82262
---
+1 makes sense to me.
- Aleix Pol Gonzalez
On July 9, 2015
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124303/#review82253
---
What's the use case?
- Aleix Pol Gonzalez
On July 9, 2015
://git.reviewboard.kde.org/r/124331/#comment56838
It should have a licence.
I think this is really cool. :)
+1
- Aleix Pol Gonzalez
On July 12, 2015, 1:13 p.m., David Faure wrote:
---
This is an automatically generated e-mail
---
This error won't happen anymore:
https://build.kde.org/job/analitza%20master%20kf5-qt5/12/PLATFORM=Linux,compiler=gcc/console
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman
)
<https://git.reviewboard.kde.org/r/126069/#comment60584>
Why only for APPLE?
I wouldn't add if(APPLE) unless there's something very specific about the
platform.
- Aleix Pol Gonzalez
On Nov. 14, 2015, 10:29 p.m., René J.V. Bertin
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125083/#review84932
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Sept. 7, 2015
) (qapplication.cpp:3717)
==25580==by 0xA182B45: QApplication::notify(QObject*, QEvent*)
(qapplication.cpp:3498)
==25580==
Diffs
-
src/quickaddons/quickviewsharedengine.cpp 0c8edc6
Diff: https://git.reviewboard.kde.org/r/125021/diff/
Testing
tps://git.reviewboard.kde.org/r/125051/#comment58740>
User iterators for less look-ups?
Other than that, looks good to me.
- Aleix Pol Gonzalez
On Sept. 4, 2015, 11:32 p.m., Jean-Baptiste Mardelle wrote:
>
> ---
> This is a
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125272/#review85530
---
+1
- Aleix Pol Gonzalez
On Sept. 17, 2015, 12:04 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125274/#review85531
---
+1
- Aleix Pol Gonzalez
On Sept. 17, 2015, 1:32 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125278/#review85533
---
+1
- Aleix Pol Gonzalez
On Sept. 17, 2015, 1:28 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125279/#review85532
---
+1
- Aleix Pol Gonzalez
On Sept. 17, 2015, 1:30 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125270/#review85529
---
Shouldn't it be qCWarning?
- Aleix Pol Gonzalez
On Sept
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125270/#review85554
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Sept. 17, 2015
> On Sept. 17, 2015, 4:13 p.m., Andrea Scarpino wrote:
> > Inviala!
>
> Andrea Scarpino wrote:
> And in Choqok too, thanks!
>
> (please do not consider my "Ship It" :-)
Oops... xD
- Aleix
---
This is an automatically
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125289/#review85574
---
+1 this was a problem in KDE Connect as well.
- Aleix Pol
---
Added a test and made it pass.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
? o.o
- Aleix Pol Gonzalez
On Sept. 10, 2015, 10:16 p.m., Andreas Cord-Landwehr wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125511/#review86317
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Oct. 3, 2015, 8
marked as submitted.
Review request for KDE Frameworks.
Changes
---
Submitted with commit c0b8ee043e8fbf1edd7b4e3223dedb00960f2e0a by Aleix Pol to
branch master.
Repository: kdeclarative
Description
---
* Add a check for a property set so that it doesn't re-compute if the new value
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125338/#review86231
---
+1 Makes sense to me.
- Aleix Pol Gonzalez
On Sept. 21
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125480/#review86218
---
+1 lgtm
- Aleix Pol Gonzalez
On Oct. 2, 2015, 9:58 a.m
already.
- Aleix Pol Gonzalez
On Sept. 9, 2015, 3:58 p.m., Giuseppe Calà wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
g/r/125535/#comment59521>
.fill() and remove the loop
src/k7zip.cpp (line 2574)
<https://git.reviewboard.kde.org/r/125535/#comment59522>
.fill
src/k7zip.cpp (line 2580)
<https://git.reviewboard.kde.org/r/125535/#comment59523>
.fill
- Aleix Pol Gonzalez
On O
tps://git.reviewboard.kde.org/r/125338/#comment59289>
Isn't this already checked in line 230? Or is `sizeof(Challenge)!=32`?
- Aleix Pol Gonzalez
On Sept. 21, 2015, 9:56 p.m., Albert Astals Cid wrote:
>
> ---
> This is an automatically g
/kquickcontrolsaddons/columnproxymodel.h 83d65d1
src/qmlcontrols/kquickcontrolsaddons/columnproxymodel.cpp b4f7973
Diff: https://git.reviewboard.kde.org/r/125334/diff/
Testing
---
added test, does what I need it to do on muon.
Thanks,
Aleix Pol Gonzalez
it. (although I had to remove 2 asserts and I feel uneasy
about it).
Diffs
-
src/core/kprotocolmanager.cpp 294ebdf
Diff: https://git.reviewboard.kde.org/r/125300/diff/
Testing
---
Tests pass, cannot reproduce the attached bug anymore.
Thanks,
Aleix Pol Gonzalez
marked as submitted.
Review request for KDE Frameworks and Alexander Dymo.
Changes
---
Submitted with commit cffb5232246e3059d048c55a1a1eab0d0b2a9b17 by Aleix Pol to
branch master.
Repository: kxmlgui
Description
---
I wanted to make sure that it's possible to provide shortcut
marked as submitted.
Review request for KDE Frameworks and Plasma.
Changes
---
Submitted with commit 8bd2d9010da0269c7a633d1c19bad70aae10a34f by Aleix Pol to
branch master.
Repository: kdeclarative
Description
---
==25580== Conditional jump or move depends on uninitialised value(s
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125337/#review85727
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Sept. 21, 2015
(updated)
-
src/widgets/kdynamicjobtracker.cpp 14924d5
Diff: https://git.reviewboard.kde.org/r/123229/diff/
Testing
---
Ran the tests, my unit test doesn't crash anymore.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde
it really hard to debug
why the function isn't there because some dependencies are missing... Maybe a
warning is enough?
- Aleix Pol Gonzalez
On Dec. 3, 2015, 1:26 p.m., Boudewijn Rempt wrote:
>
> ---
> This is an automatically ge
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126239/#review89119
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Dec. 4, 2015, 1
---
On Dec. 4, 2015, 1:17 a.m., Boudewijn Rempt wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126230/
> ---
>
>
for actually
interfacing with KCoreAddons the framework.
Have you considered getting an iteration of this upstream in Qt? At first
glance the feature doesn't look super-useful though... ^^'
- Aleix Pol Gonzalez
On Dec. 4, 2015, 3:21 p.m., David Rosca wrote
tps://git.reviewboard.kde.org/r/126185/#comment61055>
Naming them .zip on windows, won't make it a zip file, if you use tar j. I
suggest just using .tar.bz2 everywhere.
- Aleix Pol Gonzalez
On Dec. 9, 2015, 12:27 p.m., Marco Martin
1401 - 1500 of 4253 matches
Mail list logo
