Re: Review Request 126088: Port KDeclarative to use KI18n directly, rather than adding its own bindings

://git.reviewboard.kde.org/r/126088/diff/ Testing --- Tests still pass, apps still work, plasma still works as well. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Re: Review Request 126167: Expose QMimeType comment

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126167/#review88826 --- Ship it! Ship It! - Aleix Pol Gonzalez On Nov. 25, 2015

Re: Review Request 126170: [OS X] make kded5 an agent, and build it as a regular application instead of an app bundle

forms/cocoa/qcocoaintegration.mm and qcocoahelpers.mm - Aleix Pol Gonzalez On Nov. 25, 2015, 6:08 p.m., René J.V. Bertin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.revie

Re: Review Request 126185: Make the KAppTemplate CMake module global

https://techbase.kde.org/Policies/CMake_Coding_Style - Aleix Pol Gonzalez On Nov. 27, 2015, 3:26 p.m., Marco Martin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Re: Review Request 126212: Do not crash if KDE platform integration is loaded but SNI is unavailable

tps://git.reviewboard.kde.org/r/126212/#comment60913> qEnvironmentVariableIsSet - Aleix Pol Gonzalez On Dec. 1, 2015, 1:53 a.m., Sven Brauch wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.r

Re: Review Request 126230: Make python, gettext and Qt5::QML optional for ki18n

really hard to debug why the function isn't there because some dependencies are missing... Maybe a warning is enough? - Aleix Pol Gonzalez On Dec. 3, 2015, 1:26 p.m., Boudewijn Rempt wrote: > > --- > This is an automatical

Re: Review Request 126185: Make the KAppTemplate CMake module global

tps://git.reviewboard.kde.org/r/126185/#comment60983> You might want to add documentation. You can get inspired with `kde-modules/KDEFrameworkCompilerSettings.cmake` or `modules/ECMInstallIcons.cmake`. Note it's also lacking the copyright header. - Aleix Pol Gonzalez On Dec. 3, 201

Re: Review Request 126230: Make python, gettext and Qt5::QML optional for ki18n

On Dec. 4, 2015, 1:17 a.m., Boudewijn Rempt wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126230/ > --

Re: Review Request 126239: make autotests nongui executables

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126239/#review89119 --- Ship it! Ship It! - Aleix Pol Gonzalez On Dec. 4, 2015, 1

Re: Review Request 126242: KCoreAddons: Add WheelArea

for actually interfacing with KCoreAddons the framework. Have you considered getting an iteration of this upstream in Qt? At first glance the feature doesn't look super-useful though... ^^' - Aleix Pol Gonzalez On Dec. 4, 2015, 3:21 p.m., David R

Re: Review Request 126230: Make python, gettext and Qt5::QML optional for ki18n

nslations in the repository. > > Regarding this patch, I don't see it as appropriate, since it would > basically allow for broken treatment of translations when building release > tarballs. Better just add it to be applied in your build setup. I know, not > nice when some

Re: Review Request 123229: Ensure we don't crash when using KIO from non-QApplication process

Diffs (updated) - src/widgets/kdynamicjobtracker.cpp 14924d5 Diff: https://git.reviewboard.kde.org/r/123229/diff/ Testing --- Ran the tests, my unit test doesn't crash anymore. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailin

Re: Review Request 126185: Make the KAppTemplate CMake module global

tps://git.reviewboard.kde.org/r/126185/#comment61055> Naming them .zip on windows, won't make it a zip file, if you use tar j. I suggest just using .tar.bz2 everywhere. - Aleix Pol Gonzalez On Dec. 9, 2015, 12:27 p.m., Marco M

Re: Review Request 126185: Make the KAppTemplate CMake module global

> On Dec. 9, 2015, 1:03 p.m., Aleix Pol Gonzalez wrote: > > kde-modules/KDETemplateGenerator.cmake, line 59 > > <https://git.reviewboard.kde.org/r/126185/diff/3/?file=421456#file421456line59> > > > > Naming them .zip on windows, won't make it a zip file,

Re: Review Request 123229: Ensure we don't crash when using KIO from non-QApplication process

> On April 7, 2015, 5:38 p.m., Aleix Pol Gonzalez wrote: > > src/widgets/jobuidelegate.cpp, line 391 > > <https://git.reviewboard.kde.org/r/123229/diff/2/?file=360351#file360351line391> > > > > This is not correct, it's too early to figure out if it'

Re: Review Request 123229: Ensure we don't crash when using KIO from non-QApplication process

automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123229/#review89239 --- On Dec. 7, 2015, 2:29 p.m., Aleix Pol Gonzalez wrote: > > ---

Review Request 126348: Make it possible to provide the metadata in json

/ Testing --- Tests still pass (except for https://build.kde.org/job/kpackage%20master%20stable-kf5-qt5/37/PLATFORM=Linux,compiler=gcc/testReport/, that is not passing in master). Adds a test plugin with a json file in it. Thanks, Aleix Pol Gonzalez

Re: Review Request 126350: Fixed all Clazy level 1 and level 2 warnings

> On Dec. 14, 2015, 7:38 p.m., Aleix Pol Gonzalez wrote: > > I ran the tests locally and I can confirm that clazy warnings are gone and > > all tests still pass. +1, waiting for maintainer approval. - Aleix ---

Re: Review Request 126350: Fixed all Clazy level 1 and level 2 warnings

are gone and all tests still pass. - Aleix Pol Gonzalez On Dec. 14, 2015, 7:37 p.m., Artur Puzio wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 126350: Fixed all Clazy level 1 and level 2 warnings

-- On Dec. 14, 2015, 7:46 p.m., Artur Puzio wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126350/ > ---

Review Request 126366: Make KPluginMetaData constructible from a json path.

pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126348: Make it possible to provide the metadata in json

,compiler=gcc/testReport/, that is not passing in master). Adds a test plugin with a json file in it. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks

Re: Review Request 126348: Make it possible to provide the metadata in json

> Tests still pass (except for > https://build.kde.org/job/kpackage%20master%20stable-kf5-qt5/37/PLATFORM=Linux,compiler=gcc/testReport/, > that is not passing in master). > Adds a test plugin with a json file in it. > > > Thanks, > > Aleix Pol Gonzalez > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126366: Make KPluginMetaData constructible from a json path.

3674360 Diff: https://git.reviewboard.kde.org/r/126366/diff/ Testing --- Tests still pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126366: Make KPluginMetaData constructible from a json path.

files for KPackage. Diffs - src/lib/plugin/kpluginmetadata.h a91b94a src/lib/plugin/kpluginmetadata.cpp 3674360 Diff: https://git.reviewboard.kde.org/r/126366/diff/ Testing --- Tests still pass. Thanks, Aleix Pol Gonzalez ___ Kde

Re: Review Request 126384: better description of qmlmodule cmake module

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126384/#review89600 --- Ship it! Ship It! - Aleix Pol Gonzalez On Dec. 16, 2015

Re: Review Request 126400: [GCI] Fix some Clazy warnings

tps://git.reviewboard.kde.org/r/126400/#comment61400> Don't comment it, just remove it. - Aleix Pol Gonzalez On Dec. 17, 2015, 3:34 p.m., Imran Tatriev wrote: > > --- > This is an automatically generated e-mail. To r

Re: Review Request 126400: [GCI] Fix some Clazy warnings

. Tested locally and tests still pass. - Aleix Pol Gonzalez On Dec. 17, 2015, 4 p.m., Imran Tatriev wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 126392: Fix some Clazy warnings in kcoreaddons

. - Aleix Pol Gonzalez On Dec. 18, 2015, 4:33 a.m., Andrey Cygankov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

> On Dec. 18, 2015, 8:11 a.m., Martin Gräßlin wrote: > > src/platformtheme/kdeplatformtheme.cpp, lines 45-46 > > > > > > Q_NULLPTR > > René J.V. Bertin wrote: > I recall a relatively recent discussion on a Q

Re: Review Request 126416: MetaFunction doesn't need to be exported

file? - Aleix Pol Gonzalez On Dec. 18, 2015, 3:05 p.m., Patrick Spendrin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 126417: don't rely on char* to QString implicit conversion

> On Dec. 18, 2015, 3:35 p.m., Kai Uwe Broulik wrote: > > i'm wondering whether those are still needed Well, it's still being called. +1 on the patch, it can be further fixed later. - Aleix --- This is an automatically generated e-mail

Re: Review Request 126392: Fix some Clazy warnings in kcoreaddons

tps://git.reviewboard.kde.org/r/126392/#comment61462> That's still wrong. it should be: `return !m_clients.isEmpty() || !m_entries.isEmpty();` - Aleix Pol Gonzalez On Dec. 18, 2015, 5:57 p.m., Andrey Cygankov wrote: > > --- > This

Re: Review Request 126348: Make it possible to provide the metadata in json

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126348/#review89823 --- bump? - Aleix Pol Gonzalez On Dec. 15, 2015, 4:24 p.m

Re: Review Request 126455: Add mutex round static QRegExp usage in KShorturifilter

) <https://git.reviewboard.kde.org/r/126455/#comment61574> Get both variables in this scope? - Aleix Pol Gonzalez On Dec. 21, 2015, 5:22 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 126471: Don't emit statusChanged if it hasn't changed

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126471/#review89920 --- Ship it! Ship It! - Aleix Pol Gonzalez On Dec. 22, 2015

Re: Review Request 126472: Don't always load the timetracker

> On Dec. 22, 2015, 3:21 p.m., Aleix Pol Gonzalez wrote: > > I'm ok with this, although it wasn't guarded initially because it was asked > > not to. IIRC. > > > > Anyway, +1. Some small documentation about the environm

Re: Review Request 126472: Don't always load the timetracker

initially because it was asked not to. IIRC. Anyway, +1. - Aleix Pol Gonzalez On Dec. 22, 2015, 3:14 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.review

Review Request 126476: Make it possible to use doubles as index for i18np*() calls

de. Diffs - autotests/ki18ndeclarativetest.cpp cf8e778 autotests/test.qml 314b516 src/klocalizedstring.cpp 69950d2 Diff: https://git.reviewboard.kde.org/r/126476/diff/ Testing --- Added new tests, which now pass. Thanks, Aleix Pol Gonzalez __

Re: Review Request 126476: Make it possible to use doubles as index for i18np*() calls

est.cpp cf8e778 autotests/test.qml 314b516 src/klocalizedcontext.cpp 3bc42dd src/klocalizedstring.cpp 69950d2 Diff: https://git.reviewboard.kde.org/r/126476/diff/ Testing --- Added new tests, which now pass. Thanks, Aleix Pol Gonzalez

Re: Review Request 126476: Make it possible to use doubles as index for i18np*() calls

ring.cpp 69950d2 Diff: https://git.reviewboard.kde.org/r/126476/diff/ Testing --- Added new tests, which now pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126350: Fixed all Clazy level 1 and level 2 warnings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126350/#review89992 --- Ship it! Ship It! - Aleix Pol Gonzalez On Dec. 15, 2015

Re: Review Request 126400: [GCI] Fix some Clazy warnings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126400/#review89993 --- Ship it! Can you commit? - Aleix Pol Gonzalez On Dec. 17

Re: Review Request 126392: Fix some Clazy warnings in kcoreaddons

org/r/126392/ > --- > > (Updated Dec. 18, 2015, 8:32 p.m.) > > > Review request for KDE Frameworks and Aleix Pol Gonzalez. > > > Repository: kcoreaddons > > > Description > --- > > Fix some Clazy warnings: > - unneeded heap allocation with QString

Re: Review Request 126429: Fixed all Clazy warnings level 1 and level 2

g/r/126429/#comment61676> Why do we keep all this code? src/k7zip.cpp (line 2029) <https://git.reviewboard.kde.org/r/126429/#comment61677> I wouldn't get this all in. Is that suggested by `-Wclazy-reserve-candidates`? - Aleix Pol Gonzalez On Dec. 19, 2015, 4:56 p.m.,

Re: Review Request 126400: [GCI] Fix some Clazy warnings

> On Dec. 23, 2015, 3:46 p.m., Aleix Pol Gonzalez wrote: > > Can you commit? > > Imran Tatriev wrote: > Done! ;) Next time, add a `REVIEW: 126400` statement after the commit message to link it directly. - Aleix

Re: Review Request 126476: Make it possible to use doubles as index for i18np*() calls

sting --- Added new tests, which now pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126476: Make it possible to use doubles as index for i18np*() calls

rc/klocalizedcontext.h c322e33 src/klocalizedcontext.cpp 3bc42dd src/klocalizedstring.cpp 69950d2 Diff: https://git.reviewboard.kde.org/r/126476/diff/ Testing --- Added new tests, which now pass. Thanks, Aleix Pol Gonzalez ___ Kde-fra

Review Request 126489: Reduce unwanted type changes

Tests still pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126489: Reduce unwanted type changes

Diffs - CMakeLists.txt a4bd8d9 src/klocalizedstring.cpp ac14bd5 src/kuitmarkup.h bb2f65d src/kuitmarkup.cpp 64db024 Diff: https://git.reviewboard.kde.org/r/126489/diff/ Testing --- Tests still pass. Thanks, Aleix Pol Gonzalez __

Re: Review Request 126429: Fixed all Clazy warnings level 1 and level 2

> On Dec. 23, 2015, 3:49 p.m., Aleix Pol Gonzalez wrote: > > src/k7zip.cpp, line 2029 > > <https://git.reviewboard.kde.org/r/126429/diff/1/?file=424823#file424823line2029> > > > > I wouldn't get this all in. Is that suggested by > > `-Wclazy

Re: Review Request 126392: Fix some Clazy warnings in kcoreaddons

--- > > (Updated Dec. 24, 2015, 12:58 p.m.) > > > Review request for KDE Frameworks and Aleix Pol Gonzalez. > > > Repository: kcoreaddons > > > Description > --- > > Fix some Clazy warnings: > - unneeded heap allocat

Re: Review Request 126508: kdesu: Fix fd leaks.

kdesu`... - Aleix Pol Gonzalez On Dec. 25, 2015, 1:19 a.m., Michael Pyne wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Re: Review Request 126509: Silence Coverity warning about risk of buffer overflow by shrinking source buffer and using qstrncpy

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126509/#review90079 --- Ship it! Ship It! - Aleix Pol Gonzalez On Dec. 25, 2015

Re: Review Request 126506: Fix improper destruction of non-virtual KDirModel subclasses

x27;d vote for that... - Aleix Pol Gonzalez On Dec. 25, 2015, 1:12 a.m., Michael Pyne wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.review

Re: Review Request 126506: Fix improper destruction of non-virtual KDirModel subclasses

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126506/#review90161 --- Ship it! Ship It! - Aleix Pol Gonzalez On Dec. 26, 2015

Re: Review Request 126531: Fix some Clazy warnings in kemoticons.

moticons.cpp (line 180) <https://git.reviewboard.kde.org/r/126531/#comment61742> Use QLatin1String when comparing, same for the next one. Are you sure you used clazy properly? It usually detects those warnings correctly. - Aleix Pol Gonzalez On Dec. 27, 2015, 6:50 p.m., And

Re: Review Request 126531: Fix some Clazy warnings in kemoticons.

ey Cygankov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126531/ > --- > > (Updated Dec. 27, 2015, 9:08 p.m.) > > > Review re

Re: Review Request 126531: Fix some Clazy warnings in kemoticons.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126531/#review90191 --- Ship it! Ship It! - Aleix Pol Gonzalez On Dec. 27, 2015

Re: Review Request 126556: Ensure group is unescaped properly in kconf_update.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126556/#review90275 --- Ship it! Ship It! - Aleix Pol Gonzalez On Dec. 29, 2015

Re: Review Request 125536: Remove unused variable warnings

Pol Gonzalez On Oct. 6, 2015, 12:41 a.m., Albert Astals Cid wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 126587: Add option to build with gcov support

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126587/#review90423 --- That's provided by ecm, isn't it? - Aleix Pol Gon

Re: Review Request 126587: Add option to build with gcov support

e` in ECM, and included by `KDECompilerSettings.cmake`. If anything, the proper fix would be to remove this kind of code from elsewhere. - Aleix Pol Gonzalez On Dec. 31, 2015, 10:13 p.m., Dāvis Mosāns wrote: > > --- > This is an

Re: Review Request 126614: (Ki18n) Fix compilation: QStringLiteral and multistring parameter do not mix on Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126614/#review90504 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 3, 2016, 1

Re: Review Request 126620: Fixed most of level 1 and level 2 warnings

y. Is it accepted to have c++11-style connects in KF5? For the rest, +1. - Aleix Pol Gonzalez On Jan. 3, 2016, 10:09 p.m., Artur Puzio wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 126494: Add cross compile support for desktoptojson.

tps://git.reviewboard.kde.org/r/126494/#comment61894> What's that property supposed to do? `IMPORTED_LOCATION_NONE` - Aleix Pol Gonzalez On Dec. 23, 2015, 11:46 p.m., Ralf Habacker wrote: > > --- > This is an automatically genera

Re: Review Request 126494: Add cross compile support for desktoptojson.

> On Jan. 4, 2016, 3:09 p.m., Aleix Pol Gonzalez wrote: > > KF5CoreAddonsConfig.cmake.in, line 12 > > <https://git.reviewboard.kde.org/r/126494/diff/1/?file=425586#file425586line12> > > > > What's that property supposed to do? `IMPORTED_LOCATION_NONE

Re: Review Request 126494: Add cross compile support for desktoptojson.

> On Jan. 4, 2016, 3:09 p.m., Aleix Pol Gonzalez wrote: > > KF5CoreAddonsConfig.cmake.in, line 12 > > <https://git.reviewboard.kde.org/r/126494/diff/1/?file=425586#file425586line12> > > > > What's that property supposed to do? `IMPORTED_LOCATION_NONE

Re: Review Request 126348: Make it possible to provide the metadata in json

=Linux,compiler=gcc/testReport/, that is not passing in master). Adds a test plugin with a json file in it. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Re: Review Request 126632: add a "Complementary" color scheme to kcolorscheme

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126632/#review90655 --- +1 makes sense to me. - Aleix Pol Gonzalez On Jan. 5, 2016

Re: Review Request 126661: [GCI] Apply qstring-related clazy fixes to the core lib.

tps://git.reviewboard.kde.org/r/126661/#comment62050> this should be `endsWith(QLatin1Char('/'))` - Aleix Pol Gonzalez On Jan. 7, 2016, 4:41 p.m., Mihail Ivchenko wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 126662: [GCI] Fix clazy's issues in core lib.

351) <https://git.reviewboard.kde.org/r/126662/#comment62054> Why's this change? src/kpackagetool/kpackagetool.cpp (line 516) <https://git.reviewboard.kde.org/r/126662/#comment62053> I would just change for Q_FOREACH. - Aleix Pol Gonzalez On Jan. 7, 2016, 4:4

Re: Review Request 126662: [GCI] Fix clazy's issues in core lib.

> On Jan. 7, 2016, 4:51 p.m., Aleix Pol Gonzalez wrote: > > src/kpackagetool/kpackagetool.cpp, line 351 > > <https://git.reviewboard.kde.org/r/126662/diff/1/?file=428750#file428750line351> > > > > Why's this change? > > Mihail Ivchenko wrote:

Re: Review Request 126665: [GCI] Fix clazy's issues in tests.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126665/#review90783 --- Ship it! Do you have push rights? - Aleix Pol Gonzalez On

Re: Review Request 126664: [GCI] Apply qstring-related clazy fixes to tests.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126664/#review90782 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 7, 2016, 7

Re: Review Request 126670: Fix some Clazy warnings in KPeople framework

, but besides compilation, you should have checked if tests still pass and specified so in the testing field. The change looks, good. Thanks! - Aleix Pol Gonzalez On Jan. 8, 2016, 2:15 a.m., Andrey Cygankov wrote: > > --- &

Re: Review Request 126672: Fix most of Clazy warnings in plasma-framework

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126672/#review90785 --- Looks good. +1 - Aleix Pol Gonzalez On Jan. 8, 2016, 2:34

Re: Review Request 126661: [GCI] Apply qstring-related clazy fixes to the core lib.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126661/#review90796 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 7, 2016, 5

Re: Review Request 126692: Provide a DBus service file for org.kde.kpasswdserver

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126692/#review90882 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 10, 2016

Re: Review Request 126696: kssld: install DBus service file for org.kde.kssld5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126696/#review90885 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 10, 2016

Re: Review Request 126712: Make kcookiejar accessible under the dbus service name org.kde.kcookiejar5.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126712/#review90883 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 10, 2016

Re: Review Request 126672: Fix most of Clazy warnings in plasma-framework

> This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126672/ > --- > > (Updated Jan. 8, 2016, 2:34 a.m.) > > > Review request for KDE Frameworks, Plasma and A

Re: Review Request 126672: Fix most of Clazy warnings in plasma-framework

refer > > Q_FOREACH as replacement, the Q_ macros seem safer in the long run. > > Aleix Pol Gonzalez wrote: > It also detaches. > > http://www.dvratil.cz/2015/06/qt-containers-and-c11-range-based-loops/ > > Sebastian Kügler wrote: > but would

Re: Review Request 126624: respect "ShowIconsOnButtons" in the Qt5/KF5 style

> On Jan. 11, 2016, 4:17 p.m., Yichao Yu wrote: > > qt5/style/qtcurve_api.cpp, line 3211 > > > > > > Should this be turned on only when KF5 is enabled? KGlobalSettings is deprecated in KF5. I recommend quering

Re: Review Request 126734: Fix Clazy warnings in KNotifications.

sn't helping and can be removed. - Aleix Pol Gonzalez On Jan. 14, 2016, 12:30 a.m., Andrey Cygankov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewb

Re: Review Request 126734: Fix Clazy warnings in KNotifications.

> On Jan. 14, 2016, 12:30 a.m., Aleix Pol Gonzalez wrote: > > Only the foreach I don't understand, as for the rest, note that `NewStatus` > > first argument is `QString`. > > > > Use QString::fromLatin1(). > > Andrey Cygankov wrote: > What to put i

Re: Review Request 126734: Fix Clazy warnings in KNotifications.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126734/#review91038 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 14, 2016

Re: Review Request 126736: Fix all Clazy warnings in KFileMetadata.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126736/#review91039 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 14, 2016

Re: Review Request 126735: Fix most Clazy warnings in KItemModels.

s couldn't you fix? - Aleix Pol Gonzalez On Jan. 14, 2016, 1:05 a.m., Andrey Cygankov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.r

Re: Review Request 126735: Fix most Clazy warnings in KItemModels.

> On Jan. 14, 2016, 1:07 a.m., Aleix Pol Gonzalez wrote: > > These look good. You wrote "most". Which warnings couldn't you fix? > > Andrey Cygankov wrote: > log file sent `/home/andrey/dev/projects/kitemmodels/autotests/proxymodeltestsuite/proxymodelte

Re: Review Request 126738: Remove external dependencies from svgs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126738/#review91043 --- +1 Good catch. - Aleix Pol Gonzalez On Jan. 14, 2016, 2:18

Review Request 126740: Add a script for optimizing svgs

40/diff/ Testing --- ``` kde-devel@oliver:~/frameworks/breeze-icons (master)$ du -sh icons icons-dark/ 32M icons 32M icons-dark/ #run the script kde-devel@oliver:~/frameworks/breeze-icons (master)$ du -sh icons icons-dark/ 17M icons 17M icons-dark

Re: Review Request 126740: Add a script for optimizing svgs

an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126740/#review91055 ----------- On Jan. 14, 2016, 4 a.m., Aleix Pol Gonzalez wrote: > > --- > T

Re: Review Request 126740: Add a script for optimizing svgs

we should provide users whatever is easier to execute when we release. - Aleix --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126740/#review91064 ---------

Re: Review Request 126740: Add a script for optimizing svgs

diff/ > > > Testing > --- > > ``` > kde-devel@oliver:~/frameworks/breeze-icons (master)$ du -sh icons icons-dark/ > 32M icons > 32M icons-dark/ > > #run the script > > kde-devel@oliver:~/frameworks/breeze-icons (master)$ du -sh icons icons-da

Re: Review Request 126737: Fix most Clazy warnings in KItemViews.

bject]` - Aleix Pol Gonzalez On Jan. 14, 2016, 10:49 a.m., Andrey Cygankov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Re: Review Request 126735: Fix most Clazy warnings in KItemModels.

- On Jan. 14, 2016, 9:52 a.m., Andrey Cygankov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126735/ > ------

Re: Review Request 126740: Add a script for optimizing svgs

obably the compression to svgz to be done at > > build time and have all simple svgs in the repository > > Aleix Pol Gonzalez wrote: > What do you mean with "because git"? Because we might have the exact same > problem with svgo then. > > Sebastian Kügler w

Re: Review Request 126740: Add a script for optimizing svgs

ts BUT it would be awesome for us to have this scripts before > > an distribution build there packages. In git keep it as simple as possible > > and when an distro will use the icons use therefore an script (check if the > > stylesheets fit, compress, make png files, ) &

Re: Review Request 126735: Fix most Clazy warnings in KItemModels.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126735/#review91073 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 14, 2016

  1   2   3   4   5   6   7   8   9   10   >