D15220: implement more basic tags for taglibwriter

astippich added a dependent revision: D15715: remove own implementation of QString to TString conversion for taglibwriter. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D15220 To: astippich, mgallien, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michael

D15704: increase test coverage of taglibwriter

astippich added inline comments. INLINE COMMENTS > svuorela wrote in taglibwriter.cpp:22 > Unrelated. but consider making this static ? Never really though about that, but should be static, yes. None of the writers and extractors I looked at currently do this, so if I find time I will do that

D15714: add a string suffix to test data and use for unicode testing of taglibwriter

astippich updated this revision to Diff 42264. astippich added a comment. - implement feedback REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15714?vs=42197&id=42264 BRANCH taglib_write_unicode REVISION DETAIL https://phabricator.kde.org/D15714

D15714: add a string suffix to test data and use for unicode testing of taglibwriter

astippich updated this revision to Diff 42270. astippich added a comment. - actually use temporary string variable for unicode REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15714?vs=42264&id=42270 BRANCH taglib_write_unicode REVISION DETAIL htt

D15714: add a string suffix to test data and use for unicode testing of taglibwriter

astippich added inline comments. INLINE COMMENTS > smithjd wrote in taglibwritertest.cpp:60 > Is wrapping in a QString necessary? It does not compile otherwise. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D15714 To: astippich, mgallien, bruns Cc: smithjd, svu

D15220: implement more basic tags for taglibwriter

This revision was automatically updated to reflect the committed changes. Closed by commit R286:0f16dd4d4cbf: implement more basic tags for taglibwriter (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15220?vs=41856&id=42518 REVI

D15715: remove own implementation of QString to TString conversion for taglibwriter

astippich edited the summary of this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D15715 To: astippich, mgallien, bruns, svuorela Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D15704: increase test coverage of taglibwriter

astippich updated this revision to Diff 42519. astippich added a comment. - remove untested mime types and sort REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15704?vs=42196&id=42519 BRANCH taglib_write_mimetypes REVISION DETAIL https://phabrica

D15715: remove own implementation of QString to TString conversion for taglibwriter

astippich added a comment. In D15715#333567 , @bruns wrote: > Thx! Can you also add some line breaks at ~80 chars? ;-) sure :) REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D15715 To: astippich, mgallien,

D15715: remove own implementation of QString to TString conversion for taglibwriter

astippich edited the summary of this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D15715 To: astippich, mgallien, bruns, svuorela Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D15714: add a string suffix to test data and use for unicode testing of taglibwriter

astippich added inline comments. INLINE COMMENTS > bruns wrote in taglibwritertest.cpp:73 > If safeguarding against bad editors is really necessary, better do it here. > Alternatively, you can use C++11 unicode string literals, e.g. > `QString(u"€")` > If you save that one as e.g. latin1 and try

D15704: increase test coverage of taglibwriter

This revision was automatically updated to reflect the committed changes. Closed by commit R286:ae3c38293421: increase test coverage of taglibwriter (authored by astippich). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D15704?vs=42519&id=42521#toc REPOSITORY R286 KFileMetaData CHANGE

D15715: remove own implementation of QString to TString conversion for taglibwriter

This revision was automatically updated to reflect the committed changes. Closed by commit R286:c413d83851c5: remove own implementation of QString to TString conversion for taglibwriter (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.o

D15714: add a string suffix to test data and use for unicode testing of taglibwriter

astippich updated this revision to Diff 42525. astippich added a comment. - use suggested test pattern REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15714?vs=42270&id=42525 BRANCH taglib_write_unicode REVISION DETAIL https://phabricator.kde.org

D15825: move testing of common tags of test files to a new data-driven test for taglibextractor

astippich created this revision. astippich added reviewers: bruns, svuorela. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY as a preparation for more test data, move all tags that ar

D15714: add a string suffix to test data and use for unicode testing of taglibwriter

astippich updated this revision to Diff 42541. astippich added a comment. - fix after rebase REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15714?vs=42525&id=42541 BRANCH taglib_write_unicode REVISION DETAIL https://phabricator.kde.org/D15714 A

D15714: add a string suffix to test data and use for unicode testing of taglibwriter

astippich marked 5 inline comments as done. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D15714 To: astippich, mgallien, bruns Cc: smithjd, svuorela, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D15829: make units and prefixes of formatValue translatable

astippich created this revision. astippich added reviewers: bruns, safaalfulaij. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY give the possibility to translate the prefix und unit strings REPOS

D15829: make units and prefixes of formatValue translatable

astippich added a comment. @bruns please have a look at the changes. In particular, regarding "µ" and windows support. I don't know if this will be able to compile on windows, or how to fix it for tr() function. @safaalfulaij please verify if this fixes the RTL issue for you REPOSITORY R

D15829: make units and prefixes of formatValue translatable

astippich added a comment. In D15829#333799 , @safaalfulaij wrote: > Since the joining between number and format is translatable, that's great. I meant that if it is kept untranslatable, problems regarding RTL will happen. Sorry, I don't

D15833: extend test coverage to all supported mimetypes for taglibextractor

astippich created this revision. astippich added reviewers: mgallien, bruns, svuorela. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY add new test files such that all mime types declar

D15825: move testing of common tags of test files to a new data-driven test for taglibextractor

astippich added a dependent revision: D15833: extend test coverage to all supported mimetypes for taglibextractor. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D15825 To: astippich, bruns, svuorela Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astip

D15833: extend test coverage to all supported mimetypes for taglibextractor

astippich added a dependency: D15825: move testing of common tags of test files to a new data-driven test for taglibextractor. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D15833 To: astippich, mgallien, bruns, svuorela Cc: kde-frameworks-devel, #baloo, ashaposh

D15833: extend test coverage to all supported mimetypes for taglibextractor

astippich updated this revision to Diff 42551. astippich added a comment. - modify permissions of binary files REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15833?vs=42549&id=42551 BRANCH taglib_extractor_additional_tests REVISION DETAIL https:

D15829: make units and prefixes of formatValue translatable

astippich updated this revision to Diff 42563. astippich added a comment. - change description for prefixes and make the IEC prefix translatable REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15829?vs=42542&id=42563 BRANCH translate_units REVISION D

D15829: make units and prefixes of formatValue translatable

astippich added inline comments. INLINE COMMENTS > safaalfulaij wrote in kformatprivate.cpp:168 > Well, I searched other languages and no one seems to do as Arabic does. We do > not abbreviate in this case and just write the whole "Mebi.Byte" ("Byte" is > always written, "M.Byte" > "MB"). > And

D15825: move testing of common tags of test files to a new data-driven test for taglibextractor

astippich updated this revision to Diff 43028. astippich added a comment. - explicitly test for supported mimetype REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15825?vs=42529&id=43028 BRANCH refactor_taglib_extractor_tests REVISION DETAIL http

D15825: move testing of common tags of test files to a new data-driven test for taglibextractor

astippich added a comment. In D15825#334087 , @bruns wrote: > There are some more common tags with identical values, i.e. AlbumArtist, Composer and Lyrics - any reason you kept these? These are the tags directly supported by taglib (e.g.

D15833: extend test coverage to all supported mimetypes for taglibextractor

astippich edited the summary of this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D15833 To: astippich, mgallien, bruns, svuorela Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D15833: extend test coverage to all supported mimetypes for taglibextractor

astippich added a comment. In D15833#333933 , @svuorela wrote: > What's the origin/license of these files ? How are they created ? Forgot to mention it, I added this information to the summary. In D15833#333944

D15833: extend test coverage to all supported mimetypes for taglibextractor

astippich updated this revision to Diff 43031. astippich added a comment. - update aiff and wav test files so that they are smaller REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15833?vs=42551&id=43031 BRANCH taglib_extractor_additional_tests REV

D15829: make units and prefixes of formatValue translatable

astippich updated this revision to Diff 43034. astippich added a comment. - add seperate, translatable string for IEC binary prefixes REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15829?vs=42563&id=43034 BRANCH translate_units REVISION DETAIL htt

D15829: make units and prefixes of formatValue translatable

astippich added a comment. In D15829#338296 , @safaalfulaij wrote: > Thanks! > I think this solved all my issues. I can for meter unit change the formatting so that `tr("%1 %2", "no Prefix")` is translated to `"%1%2"` and choose to keep the

D15829: make units and prefixes of formatValue translatable

astippich updated this revision to Diff 43038. astippich added a comment. - fixup spaces REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15829?vs=43034&id=43038 BRANCH translate_units REVISION DETAIL https://phabricator.kde.org/D15829 AFFECTED FIL

D15825: move testing of common tags of test files to a new data-driven test for taglibextractor

astippich added a comment. Sorry, I should have written this more clearly, but you got it right. It's for the new formats. For the most common tags, taglib directly provides the implementation for all its supported tag formats and one can call e.g. tag->artist(). For the others, one has to i

D15825: move testing of common tags of test files to a new data-driven test for taglibextractor

astippich edited the summary of this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D15825 To: astippich, bruns, svuorela Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D16059: remove compile time check for taglib version

astippich created this revision. astippich added reviewers: svuorela, bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY cleanup the check for the taglib version, which is unneede

D15825: move testing of common tags of test files to a new data-driven test for taglibextractor

astippich edited the summary of this revision. REPOSITORY R286 KFileMetaData BRANCH refactor_taglib_extractor_tests REVISION DETAIL https://phabricator.kde.org/D15825 To: astippich, bruns, svuorela Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, br

D15825: move testing of common tags of test files to a new data-driven test for taglibextractor

This revision was automatically updated to reflect the committed changes. Closed by commit R286:52920c0003d6: move testing of common tags of test files to a new data-driven test for… (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/

D15833: extend test coverage to all supported mimetypes for taglibextractor

This revision was automatically updated to reflect the committed changes. Closed by commit R286:601059a3c0b6: extend test coverage to all supported mimetypes for taglibextractor (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1583

D16059: remove compile time check for taglib version

This revision was automatically updated to reflect the committed changes. Closed by commit R286:d6d86adbd773: remove compile time check for taglib version (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16059?vs=43191&id=43326 RE

D15714: add a string suffix to test data and use for unicode testing of taglibwriter

astippich edited the summary of this revision. REPOSITORY R286 KFileMetaData BRANCH taglib_write_unicode REVISION DETAIL https://phabricator.kde.org/D15714 To: astippich, mgallien, bruns Cc: smithjd, svuorela, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngr

D15714: add a string suffix to test data and use for unicode testing of taglibwriter

astippich marked an inline comment as done. astippich added inline comments. INLINE COMMENTS > bruns wrote in taglibwritertest.cpp:75 > can you change this to `data[2]` ... > Facepalm myself ... I should have spotted this myself :) REPOSITORY R286 KFileMetaData BRANCH taglib_write_unicode

D15714: add a string suffix to test data and use for unicode testing of taglibwriter

This revision was automatically updated to reflect the committed changes. astippich marked an inline comment as done. Closed by commit R286:196b1289152c: add a string suffix to test data and use for unicode testing of taglibwriter (authored by astippich). CHANGED PRIOR TO COMMIT https://phabric

D16111: use own extractor for testing the taglibwriter

astippich created this revision. astippich added reviewers: mgallien, bruns, svuorela. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Instead of querying the tags directly through tagl

D16112: add wma files/asf tags as supported mimetype and add test data

astippich created this revision. astippich added reviewers: mgallien, bruns, svuorela. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Add preliminary support for wma files/asf tags for

D16111: use own extractor for testing the taglibwriter

astippich updated this revision to Diff 43339. astippich added a comment. - fix stupid mistakes REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16111?vs=43330&id=43339 BRANCH use_extractor_for_writertest REVISION DETAIL https://phabricator.kde.or

D16111: use own extractor for testing the taglibwriter

astippich marked 2 inline comments as done. astippich added a comment. Sorry, that was really stupid REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16111 To: astippich, mgallien, bruns, svuorela Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astipp

D16111: use own extractor for testing the taglibwriter

This revision was automatically updated to reflect the committed changes. Closed by commit R286:d472f470bacb: use own extractor for testing the taglibwriter (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16111?vs=43339&id=43370

D16112: add wma files/asf tags as supported mimetype and add test data

This revision was automatically updated to reflect the committed changes. Closed by commit R286:d7c6fa57d243: add wma files/asf tags as supported mimetype and add test data (authored by astippich). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D16112?vs=43332&id=43371#toc REPOSITORY R2

D16135: refactor tests for taglibextractor

astippich created this revision. astippich added reviewers: mgallien, bruns, svuorela. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY refactors all tests so that they can be reused for

D16162: harmonize test data for vorbis comment tags

astippich created this revision. astippich added a reviewer: bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY harmonize the test data for all files with vorbis comments so that

D16135: refactor tests for taglibextractor

astippich added a comment. In D16135#341549 , @bruns wrote: > Can you split this up in two patches, the first one updating the test files and fixing the values in the tests, and the second one doing the refactoring? see D16162

D16163: refactor taglibextractor to functions specific for metadata type

astippich created this revision. astippich added a reviewer: bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Refactor the specific extraction funtions in taglibextractor so tha

D16163: refactor taglibextractor to functions specific for metadata type

astippich added a comment. To be on the safe side here: I am allowed to modify private member functions regarding binary compatibility, right? REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16163 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, ashaposh

D16162: harmonize test data for vorbis comment tags

This revision was automatically updated to reflect the committed changes. Closed by commit R286:1aab09a628ae: harmonize test data for vorbis comment tags (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16162?vs=43485&id=43489 REV

D16135: refactor tests for taglibextractor

astippich updated this revision to Diff 43490. astippich added a comment. - rebase REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16135?vs=43409&id=43490 BRANCH refactor_tests REVISION DETAIL https://phabricator.kde.org/D16135 AFFECTED FILES

D16163: refactor taglibextractor to functions specific for metadata type

astippich added a comment. In D16163#342057 , @mgallien wrote: > In D16163#342046 , @astippich wrote: > > > To be on the safe side here: I am allowed to modify private member functions regarding bin

D16163: refactor taglibextractor to functions specific for metadata type

astippich updated this revision to Diff 43500. astippich added a comment. - use forward declaration REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16163?vs=43486&id=43500 BRANCH refactor_taglib REVISION DETAIL https://phabricator.kde.org/D16163

D16165: Don't crash on invalid exiv2 data

astippich added a comment. I guess bugs 352856 353848 361259 will also be fixed by this? REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16165 To: poboiko, #baloo, #frameworks Cc: astippich, kde-frameworks-devel, ashaposhnikov, michaelh, spoorun, ngrah

D16135: refactor tests for taglibextractor

This revision was automatically updated to reflect the committed changes. Closed by commit R286:2d6b448b69b0: refactor tests for taglibextractor (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16135?vs=43490&id=43525 REVISION DET

D16163: refactor taglibextractor to functions specific for metadata type

This revision was automatically updated to reflect the committed changes. Closed by commit R286:5836ca4adefd: refactor taglibextractor to functions specific for metadata type (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16163?v

D16179: compare with QLatin1String and harmonize handling of all types

astippich created this revision. astippich added reviewers: mgallien, bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY small optimization and harmonization for all metadata format

D11869: epubextractor: Add property ReleaseYear

astippich accepted this revision. astippich added a comment. This revision is now accepted and ready to land. Herald edited subscribers, added: Baloo, kde-frameworks-devel; removed: Frameworks. Any objections? Otherwise I will merge this on michaelh's behalf REPOSITORY R286 KFileMetaData B

D16196: add a description property to KFileMetaData

astippich created this revision. astippich added reviewers: mgallien, bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY add the description property to KFileMetaData, as the Comm

D16197: provide a list of supported mimetypes for embeddedimagedata

astippich created this revision. astippich added reviewers: bruns, mgallien. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY provide a list of supported mimetypes similar to the extra

D16197: provide a list of supported mimetypes for embeddedimagedata

astippich updated this revision to Diff 43601. astippich added a comment. - move mimetype list to private REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16197?vs=43587&id=43601 BRANCH mimetypes_embedded_image REVISION DETAIL https://phabricator.

D11869: epubextractor: Add property ReleaseYear

This revision was automatically updated to reflect the committed changes. Closed by commit R286:15adb113399e: epubextractor: Add property ReleaseYear (authored by michaelh, committed by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11869?vs=

D16165: Don't crash on invalid exiv2 data

astippich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH dont-crash-invalid-exiv (branched from master) REVISION DETAIL https://phabricator.kde.org/D16165 To: poboiko, #baloo, #frameworks, astippich Cc: bruns, astippich, kde-f

D16197: provide a list of supported mimetypes for embeddedimagedata

astippich added inline comments. INLINE COMMENTS > mgallien wrote in embeddedimagedata.h:62 > You can make it static because you are returning a static member. It means > that you should probably return by const reference (even if I do not remember > if it is always the best answer). I had it

D16179: compare with QLatin1String and harmonize handling of all types

astippich added a comment. Ok. Thanks! REPOSITORY R286 KFileMetaData BRANCH harmonize_optimize REVISION DETAIL https://phabricator.kde.org/D16179 To: astippich, mgallien, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D16179: compare with QLatin1String and harmonize handling of all types

This revision was automatically updated to reflect the committed changes. Closed by commit R286:fd9ce3a4e1d2: compare with QLatin1String and harmonize handling of all types (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16179?vs=

D16196: add a description property to KFileMetaData

astippich added a comment. ping. would be great to get this in before the string freeze REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16196 To: astippich, mgallien, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham,

D16197: provide a list of supported mimetypes for embeddedimagedata

astippich updated this revision to Diff 43819. astippich added a comment. - use QVERIFY - use capital T - add since 5.52 tag and rephrase documentation REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16197?vs=43601&id=43819 BRANCH mimetypes_embe

D16197: provide a list of supported mimetypes for embeddedimagedata

astippich marked an inline comment as done. astippich added inline comments. INLINE COMMENTS > bruns wrote in embeddedimagedata.cpp:73 > `supportedMimeTypes()` ? > capital `T`, see `ImageType` and `QMimeType` The "read" is supposed to mark that only read operations for these mimetypes are suppo

D16281: update epub test data and test for comment property

astippich created this revision. astippich added a reviewer: bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY update the test data for epub and test for the comment property in

D16281: update epub test data and test for comment property

astippich added a comment. In preparation of D12114 , which I plan to commandeer REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16281 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich

D16282: extract ape tags from ape and wavpack files

astippich created this revision. astippich added reviewers: mgallien, bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY extend the existing support of ape tags to all types that

D16283: implement more tags for asf metadata

astippich created this revision. astippich added reviewers: mgallien, bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY add some more tags for asf audio files REPOSITORY R286 KF

D16283: implement more tags for asf metadata

astippich added a comment. for some reason the TagLib::ASF::File tag() function returns only an invalid pointer, so I decided to use the dynamic_cast here. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16283 To: astippich, mgallien, bruns Cc: kde-frameworks-

D16283: implement more tags for asf metadata

astippich updated this revision to Diff 43885. astippich marked 3 inline comments as done. astippich added a comment. - fix comment and simplify iterating - cleanup REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16283?vs=43822&id=43885 BRANCH ext

D16283: implement more tags for asf metadata

astippich added inline comments. INLINE COMMENTS > bruns wrote in taglibextractor.cpp:739 > this makes me always wonder why we don't do: > > // decltype(data.albumArtists) == QStringList > for (attribute : lstAsf) { > QString t = TStringToQString(attribute.toString()); > data.albumAr

D16281: update epub test data and test for comment property

astippich updated this revision to Diff 43887. astippich added a comment. - fix test file REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16281?vs=43820&id=43887 BRANCH description_test_preparation REVISION DETAIL https://phabricator.kde.org/D162

D16197: provide a list of supported mimetypes for embeddedimagedata

astippich updated this revision to Diff 43888. astippich marked an inline comment as done. astippich added a comment. - remove read prefix REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16197?vs=43819&id=43888 BRANCH mimetypes_embedded_image REVIS

D16197: provide a list of supported mimetypes for embeddedimagedata

astippich added a comment. I've decided to name it similar to the extractor plugins REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16197 To: astippich, bruns, mgallien Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bru

D16197: provide a list of supported mimetypes for embeddedimagedata

This revision was automatically updated to reflect the committed changes. Closed by commit R286:1e9705162343: provide a list of supported mimetypes for embeddedimagedata (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16197?vs=438

D16281: update epub test data and test for comment property

This revision was automatically updated to reflect the committed changes. Closed by commit R286:d97b15679179: update epub test data and test for comment property (authored by astippich). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D16281?vs=43887&id=44364#toc REPOSITORY R286 KFileMet

D16282: extract ape tags from ape and wavpack files

This revision was automatically updated to reflect the committed changes. Closed by commit R286:4582ba5f3d7a: extract ape tags from ape and wavpack files (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16282?vs=43821&id=44365 REV

D16283: implement more tags for asf metadata

This revision was automatically updated to reflect the committed changes. Closed by commit R286:02e8cab069ff: implement more tags for asf metadata (authored by astippich). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D16283?vs=43885&id=44366#toc REPOSITORY R286 KFileMetaData CHANGES

D16486: implement support for reading ID3 tags from aiff and wav files

astippich created this revision. astippich added reviewers: mgallien, bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY implement ID3 tags for aiff and wav files as supported by ta

D16488: [KFileMetaData] Add helper for XML encoded Dublin Core metadata

astippich added a comment. I guess you plan to convert the existing extractors to use this? The only concern I might have that now two iterations over the node are required when this is used in e.g. odfextractor, isn't it? Btw, I don't think it's necessary to prepend KFileMetaData in the d

D16554: move supported mimetypes to static string list

astippich created this revision. astippich added a reviewer: bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Do not create the list of supported mime types on demand and use a

D16489: [KFileMetaData] Add extractor for generic XML and SVG

astippich added inline comments. INLINE COMMENTS > xmlextractor.cpp:24 > + > +#include > +#include seems unused > xmlextractor.cpp:27 > +#include > +#include > + same > xmlextractor.cpp:71 > + > +return list; > +} Can we agree on using a static qstringlist if the mimetypes are fixed?

D16490: [KFileMetaData] Add unittest for XML extractor

astippich added a comment. Only one minor thing: please also check that the mimetype is in the list of supported mimetypes REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16490 To: bruns, #frameworks, astippich Cc: lbeltrame, kde-frameworks-devel, #baloo, asha

D16560: create a separate test file for embedded images test

astippich created this revision. astippich added a reviewer: bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY if the test.jpg file is altered, e.g. additional metadata is added,

D16486: implement support for reading ID3 tags from aiff and wav files

This revision was automatically updated to reflect the committed changes. Closed by commit R286:19f0237fdc98: implement support for reading ID3 tags from aiff and wav files (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16486?vs=

D15829: make units and prefixes of formatValue translatable

astippich added a comment. ping REPOSITORY R244 KCoreAddons BRANCH translate_units REVISION DETAIL https://phabricator.kde.org/D15829 To: astippich, bruns, safaalfulaij Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16564: cleanup the test for embedded image extraction

astippich created this revision. astippich added reviewers: Frameworks, bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY cleanup the test by converting to a data-driven one REPOS

D16560: create a separate test file for embedded images test

astippich added a dependent revision: D16564: cleanup the test for embedded image extraction. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16560 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns,

D16564: cleanup the test for embedded image extraction

astippich added a dependency: D16560: create a separate test file for embedded images test. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16564 To: astippich, #frameworks, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngra

<    1   2   3   4   5   6   7   8   9   10   >