D29678: Fix incorrect colours in the KNS Quick messagebox

leinir added a comment. In D29678#670125 , @ngraham wrote: > Does this even need to be a TextEdit? Or is that to get mouse-selectability for the error text? If so, +1 but please add comments indicating this reason. That is precisely what

D29678: Fix incorrect colours in the KNS Quick messagebox

leinir updated this revision to Diff 82744. leinir added a comment. Address comment by @ngraham - Add a comment for the purpose of the control being a TextEdit REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29678?vs=82659&id=82744 BRANCH fix-colou

D29678: Fix incorrect colours in the KNS Quick messagebox

This revision was automatically updated to reflect the committed changes. Closed by commit R304:5ce4d1a29b96: Fix incorrect colours in the KNS Quick messagebox (authored by leinir). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29678?vs=82744&id=82791 REVI

Re: KNewStuff - CMake targets hardcoding paths

On Sunday, 8 April 2018 03:30:15 BST Ben Cooksley wrote: > Hi all, > > On Windows the Binary Factory has recently struck an issue with > KNewStuff where the paths supplied in the newstuffqmlplugin target it > installs are hardcoded. > > This can be seen at the bottom of > https://binary-factory.k

D12082: Don't offer qml plugin as a link target

leinir created this revision. leinir added reviewers: Frameworks, KNewStuff. leinir added a project: KNewStuff. Restricted Application added a project: Frameworks. leinir requested review of this revision. REVISION SUMMARY This removes the KNSQuick plugin as a link target for cmake. It was never

D12082: Don't offer qml plugin as a link target

This revision was automatically updated to reflect the committed changes. Closed by commit R304:469db5c6934b: Don't offer qml plugin as a link target (authored by leinir). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12082?vs=31790&id=31859 REVISION DETAI

D13515: Remove KNS::Engine d-pointer hack

leinir added a comment. H... this is tricky, but... yes, it seems reasonable to me that replacing one pointer with another would cause no BIC issues... and i certainly am happy to get rid of the d-pointer hack, so... if we're absolutely super-sure that this is BC, i'm all for it... would

D13714: Fix broken url to API specification

leinir accepted this revision. This revision is now accepted and ready to land. REPOSITORY R235 Attica BRANCH master REVISION DETAIL https://phabricator.kde.org/D13714 To: habacker, mlaurent, leinir Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13733: Add provider auto test

leinir requested changes to this revision. leinir added a comment. This revision now requires changes to proceed. Autotests are good, but so is documentation - in principle this is good, but new public functions without documentation isn't really acceptable :) Apart from that, though, looks

D13733: Add provider auto test

leinir accepted this revision. This revision is now accepted and ready to land. REPOSITORY R235 Attica BRANCH master REVISION DETAIL https://phabricator.kde.org/D13733 To: habacker, leinir Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13732: Add debug output for all network requests

leinir requested changes to this revision. leinir added a comment. This revision now requires changes to proceed. Straight-up qDebug would cause quite a lot of spam... I'd be much happier if this was done using qCDebug (which is already used in other parts of the code, so just need to include

D13743: Migrate build system to use find_package in autotests/ki18n_install

leinir added a comment. This seems quite sensible to me, a cleanup and simplification of the test build system is not bad... That said, i'm unsure why you think i'm qualified to speak about ki18n and the general cmake build system to a level high enough that you highlight me specificall

D13732: Add debug output for all network requests

leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. Sorted! Good digging, nice work :) REPOSITORY R235 Attica BRANCH master REVISION DETAIL https://phabricator.kde.org/D13732 To: habacker, leinir Cc: ltoscano, bruns, kde-frameworks-d

D6513: Add support for Attica tags support

leinir updated this revision to Diff 37047. leinir edited the summary of this revision. leinir edited the test plan for this revision. leinir added a comment. Restricted Application edited subscribers, added: kde-frameworks-devel; removed: Frameworks. - add test tool - add support for filter

D6513: Add support for Attica tags support

leinir added a comment. Test tool using the default settings, and with QT__LOGGING_RULES="org.kde.knewstuff.*=true" F5998853: image.png REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D6513 To: leinir, #knewstuff, apol, #kde

D6512: Add support for proposed tags addition in OCS 1.7

leinir added a comment. Restricted Application edited subscribers, added: kde-frameworks-devel; removed: Frameworks. Ping, if we could get this merged soon, it would be terribly handy :) (it's the basis for moderating the ghns content, and needed for the knewstuff patch in D6513

D6513: Add support for Attica tags support

leinir added a comment. Pingaling, it would be super handy if we could get this merged soon :) It's needed to support the moderation happening on the KDE Store, and also needed for better handling of specific types of content like e.g. comic books in Peruse. Thanks! :D REPOSITORY R304 KNe

D14095: Fix DownloadDialog window margins to meet general theme margins

leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. In principle, this would really want to go via the designers, but at the same time it does seem that this was what was originally intended anyway. Shippit :) REPOSITORY R304 KNewStuff BR

D14097: Change default sort order in the download dialog to Rating

leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. As an aside, I'd probably like this to end up being remembered between sessions, but this no different to the current state, and so outside the scope of this patch. As a default setting, yu

D6512: Add support for proposed tags addition in OCS 1.7

leinir added a comment. In D6512#296329 , @ahiemstra wrote: > T6133 suggests that tags are formatted as "group##key=value" or something similar. Wouldn't it make sense to handle parsing that format here as well

D6513: Add support for Attica tags support

leinir marked 7 inline comments as done. leinir added inline comments. INLINE COMMENTS > ahiemstra wrote in atticaprovider.cpp:283 > Wouldn't it be simpler to first check if the content should be considered at > all, and then check if one of the downloads is valid? So something like: > > if(!

D6513: Add support for Attica tags support

leinir updated this revision to Diff 38489. leinir marked 4 inline comments as done. leinir added a comment. Address ahiemstra's comments REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6513?vs=37047&id=38489 REVISION DETAIL https://phabricator.kde.org/

D6513: Add support for Attica tags support

leinir marked 3 inline comments as done. leinir added inline comments. INLINE COMMENTS > mlaurent wrote in entryinternal.cpp:495 > qCWarning(KNEWSTUFF_CORE) ? I was just adding in a bit of verbosity to the output... but yes, makes sense to fix that while i'm there anyway :) REPOSITORY R304 K

D6513: Add support for Attica tags support

leinir updated this revision to Diff 38506. leinir marked an inline comment as done. leinir added a comment. Address mlaurent's comments REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6513?vs=38489&id=38506 REVISION DETAIL https://phabricator.kde.org/D

D6513: Add support for Attica tags support

leinir added a comment. @mlaurent quick ping? :) Also in general, sorry, would really like to get this merged in asap - i realise it's the summer holidays for a lot of people ;) REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D6513 To: leinir, #knewstuff, apol

D6513: Add support for Attica tags support

leinir marked 17 inline comments as done. leinir added inline comments. INLINE COMMENTS > dfaure wrote in engine.cpp:133 > That's out of bounds, if tagFilter is empty!! It will assert. > > You meant append or push_back, I think. i did indeed! > dfaure wrote in engine.cpp:138 > !? What's the po

D6513: Add support for Attica tags support

leinir updated this revision to Diff 39174. leinir marked 3 inline comments as done. leinir added a comment. Address the various comments by dfaure, cfeck and ngraham - with thanks! REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6513?vs=38506&id=39174 RE

D6512: Add support for proposed tags addition in OCS 1.7

leinir marked 2 inline comments as done. REPOSITORY R235 Attica REVISION DETAIL https://phabricator.kde.org/D6512 To: leinir, #knewstuff, apol, whiting, #kde_store, ahiemstra Cc: cfeck, ahiemstra, ngraham, kde-frameworks-devel, #kde_store, michaelh, ZrenBot, bruns, akiraohgaki, alexandersch

D6512: Add support for proposed tags addition in OCS 1.7

leinir updated this revision to Diff 39175. leinir added a comment. Address comments by cfeck Also mark new public API as @since 5.50 REPOSITORY R235 Attica CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6512?vs=16200&id=39175 REVISION DETAIL https://phabricator.kde.org/D6512

D6512: Add support for proposed tags addition in OCS 1.7

leinir requested review of this revision. REPOSITORY R235 Attica REVISION DETAIL https://phabricator.kde.org/D6512 To: leinir, #knewstuff, apol, whiting, #kde_store, ahiemstra Cc: cfeck, ahiemstra, ngraham, kde-frameworks-devel, #kde_store, michaelh, ZrenBot, bruns, akiraohgaki, alexandersc

D18813: Filter out invalid content in lists

leinir created this revision. leinir added a reviewer: KNewStuff. leinir added a project: KNewStuff. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY Prior to this change, if the ocs server being queri

D18813: Filter out invalid content in lists

leinir marked an inline comment as done. leinir added inline comments. INLINE COMMENTS > apol wrote in atticaprovider.cpp:277 > Maybe it would be easier to read if we had a `if (!content.isValid()) > continue; ...`. Hmm... the patch certainly would, i'll swap that around a bit. Generally don't

D18813: Filter out invalid content in lists

leinir updated this revision to Diff 51169. leinir marked an inline comment as done. leinir added a comment. Swap the logic around a bit, makes for an easier to read patch and whatnot. REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18813?vs=51099&id=51169

D18813: Filter out invalid content in lists

This revision was automatically updated to reflect the committed changes. Closed by commit R304:1f4e1a6db756: Filter out invalid content in lists (authored by leinir). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18813?vs=51169&id=51501 REVISION DETAIL

D19338: New location for KNSRC files

leinir created this revision. leinir added reviewers: KNewStuff, apol, ngraham, fvogt. leinir added a project: KNewStuff. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY This introduces a cmake variab

D19338: New location for KNSRC files

leinir added a dependent revision: D19340: Search new knsrc locations. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D19338 To: leinir, #knewstuff, apol, ngraham, fvogt Cc: kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, ngraham, bruns

D19338: New location for KNSRC files

leinir added a comment. In D19338#420303 , @apol wrote: > +1 cool stuff! > > this opens the possibility for files being both in /usr and /etc, can you make sure hell doesn't break loose when that happens? > > Was these files look up was d

D19387: Remove deprecated QSignalMapper

leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. Much simpler code run, there, lgtm :) REPOSITORY R235 Attica BRANCH remove_deprecated_qsignalmapper (branched from master) REVISION DETAIL https://phabricator.kde.org/D19387 To: mla

D19338: New location for KNSRC files

leinir updated this revision to Diff 53117. leinir added a comment. Since 5.57, not 5.56 REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19338?vs=52607&id=53117 REVISION DETAIL https://phabricator.kde.org/D19338 AFFECTED FILES KF5NewStuffCoreConfig.c

D19672: [knewstuff] make it compile without foreach

leinir accepted this revision. leinir added a comment. Looks good to me... None of the scary ones that'll trigger various nasty side effects as far as i can tell. REPOSITORY R304 KNewStuff BRANCH compile_without_foreach (branched from master) REVISION DETAIL https://phabricator.kde.or

D19683: autotests: use new signal failedToLoad in ProviderTest

leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. This does seem very much sensible, yes, well thought :) REPOSITORY R235 Attica BRANCH master REVISION DETAIL https://phabricator.kde.org/D19683 To: dfaure, leinir Cc: kde-frameworks

D19338: New location for KNSRC files

leinir added a comment. Quick ping, be good to get this in sometime before it becomes late again... :) REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D19338 To: leinir, #knewstuff, apol, ngraham, fvogt Cc: kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, ngraha

D19338: New location for KNSRC files

This revision was automatically updated to reflect the committed changes. Closed by commit R304:be0412024a46: New location for KNSRC files (authored by leinir). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19338?vs=53117&id=53869 REVISION DETAIL https:/

D19858: Handle unsupported OCS commands, and don't over-vote

leinir created this revision. leinir added reviewers: KNewStuff, ronaldv, ngraham. leinir added a project: KNewStuff. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY When the server does not support c

D19858: Handle unsupported OCS commands, and don't over-vote

leinir marked an inline comment as done. leinir added inline comments. INLINE COMMENTS > ngraham wrote in itemsviewdelegate.cpp:287 > Why do we need to do this twice? ehrm... we don't, we need to undo it, and i forgot to swap that true for a false ;) Thanks! REPOSITORY R304 KNewStuff REVISI

D19858: Handle unsupported OCS commands, and don't over-vote

leinir updated this revision to Diff 54235. leinir marked an inline comment as done. leinir added a comment. Copypasta error... thanks Nate :) REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19858?vs=54233&id=54235 REVISION DETAIL https://phabricator.kd

D19858: Handle unsupported OCS commands, and don't over-vote

leinir added a comment. In D19858#433788 , @ngraham wrote: > Thanks! Makes sense, and fixes the bug. :) > > Of course the underlying issue is still present. If you can't vote from the GHNS dialogs, there shouldn't be a UI for let you try; it

D19858: Handle unsupported OCS commands, and don't over-vote

This revision was automatically updated to reflect the committed changes. Closed by commit R304:2a40085fc3d2: Handle unsupported OCS commands, and don't over-vote (authored by leinir). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19858?vs=54235&id=54238 R

D19900: Set category on Attica entries

leinir created this revision. leinir added reviewers: KNewStuff, apol. leinir added a project: KNewStuff. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY Prior to this patch, we had forgotten to set t

D19900: Set category on Attica entries

This revision was automatically updated to reflect the committed changes. Closed by commit R304:88ffd3cce725: Set category on Attica entries (authored by leinir). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19900?vs=54368&id=54375 REVISION DETAIL https

D19917: Additions for ProviderManager documentation

leinir created this revision. leinir added reviewers: Frameworks, KNewStuff. leinir added a project: KNewStuff. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY Someone attempting to work on an Attica

D19917: Additions for ProviderManager documentation

leinir added inline comments. INLINE COMMENTS > apol wrote in providermanager.h:50 > You can use @see so doxygen creates a link? It's supposed to pick those up automatically, i thought? REPOSITORY R235 Attica REVISION DETAIL https://phabricator.kde.org/D19917 To: leinir, #frameworks, #kne

D19917: Additions for ProviderManager documentation

This revision was automatically updated to reflect the committed changes. Closed by commit R235:533b31b5d6f9: Additions for ProviderManager documentation (authored by leinir). REPOSITORY R235 Attica CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19917?vs=54422&id=54426 REVISION DETA

D20077: Accept HTTP status 103 as benign

leinir created this revision. leinir added reviewers: KNewStuff, Frameworks. leinir added a project: KNewStuff. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY In December 2017, a new status code was

D20077: Accept HTTP status 103 as benign

leinir added a comment. In D20077#439290 , @apol wrote: > And why are 101 and 102 bad? > Should we just accept between 100 and 200? Hmm... You're probably right, yes, 100 is supposed to be all benign status type stuff, so... yeah, i'll

D20077: Accept any HTTP status between 100 and 199 as benign

leinir updated this revision to Diff 54928. leinir retitled this revision from "Accept HTTP status 103 as benign" to "Accept any HTTP status between 100 and 199 as benign". leinir edited the summary of this revision. leinir added a comment. Just accept any informational status as benign, rathe

D19990: Switch URLs to https

leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. LGTM, as long as all the various sites being pointed at there actually resolve on https, which i'm guessing (going by your summary) you've checked? :) REPOSITORY R304 KNewStuff BRANCH

D20077: Accept any HTTP status between 100 and 199 as benign

This revision was automatically updated to reflect the committed changes. Closed by commit R235:7e988d655db2: Accept any HTTP status between 100 and 199 as benign (authored by leinir). REPOSITORY R235 Attica CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20077?vs=54928&id=54972 REVI

D20693: Remove pixelated border

leinir created this revision. leinir added reviewers: KNewStuff, ngraham, sitter. leinir added a project: KNewStuff. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY In the before-times, drop shadows w

D20761: Remove pixelated border

leinir created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY In the before-times, drop shadows were considered vitally important on everything, and so it was introduced to KNewStu

D20693: Remove pixelated border

leinir updated this revision to Diff 56794. leinir added a comment. Attempt to use arcanist, hopefully with less data loss this time REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20693?vs=56613&id=56794 BRANCH no-pixelated-border (branched from master

D20761: Remove pixelated border

leinir abandoned this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D20761 To: leinir Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20693: Remove pixelated border

leinir added a comment. In D20693#454173 , @ngraham wrote: > This patch doesn't apply: > >INFO Base commit is not in local repository; trying to fetch. > Created and checked out branch arcpatch-D20693. > Checking patch src/ui/imag

D20693: Remove pixelated border

leinir added a comment. Before patch: F6788195: image.png After patch: F6788193: image.png REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D20693 To: leinir, #knewstuff, ngraham, sitt

D20761: Remove pixelated border

leinir added a reviewer: VDG. leinir added a comment. Adding VDG because this is a visual change. To the visual commenters: This is intended as a first step, removing the old drop-shadow method (see also the related bug for a more severe version

D20693: Remove pixelated border

leinir added a reviewer: VDG. leinir added a comment. Adding VDG because this is a visual change. To the visual commenters: This is intended as a first step, removing the old drop-shadow method (see also the related bug for a more severe version of that drop-shadow being shown very incorrect

D20693: Remove pixelated border

leinir added a comment. In D20693#454733 , @ndavis wrote: > +1 for the change to the large thumbnail, but I think the smaller thumbnails need something to show that they can be clicked. The problem as described in my comment where i added

D20693: Remove pixelated border

leinir added a comment. In D20693#454783 , @sitter wrote: > LGTM on a technical level. On a visual level also +1 because I hate that drop shadow with a fierce passion. > > @leinir lxr says a similar thumb is also used for some of the KAboutPe

D20693: Remove pixelated border

leinir added a comment. In D20693#454799 , @sitter wrote: > In D20693#454750 , @leinir wrote: > > > So yes, in principle i'd certainly like there to be some kind of background or outline to suggest c

D20693: Remove pixelated border

leinir added a comment. In D20693#454874 , @ngraham wrote: > To show that a thumbnail clickable, switching to the pointing hand cursor when hovering over a thumbnail could work. > > However I notice that the actual list delegates in the brows

D20693: Remove pixelated border

leinir added a comment. That does indeed look good, and not a huge departure from what we have already, which i'm sure will make people feel quite at home in the new version :) I do wonder if we'd want to, at some point, make it look closer to Discover, but certainly for now this seems a muc

D20693: Remove pixelated border

This revision was automatically updated to reflect the committed changes. Closed by commit R304:e1f5782a8518: Remove pixelated border (authored by leinir). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20693?vs=56794&id=56952 REVISION DETAIL https://phab

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

leinir added inline comments. INLINE COMMENTS > GridDelegate.qml:147 > +onClicked: { > +delegate.clicked() > +modelData.trigger() Just came across having both a function called on clicking the thumbnail (

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

leinir added inline comments. INLINE COMMENTS > ngraham wrote in GridDelegate.qml:147 > This was a deliberate choice, to make sure that the delegate got selected > when one of its buttons got clicked. But yeah selected may not necessarily > require clicked, so maybe it wasn't the best way of do

D20986: Don't call click on the delegate, when we just want it to become current item

leinir created this revision. leinir added a reviewer: ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY If you have any actions in your GridDelegate, activating them would previously cause t

D20986: Don't call click on the delegate, when we just want it to become current item

leinir added a comment. In D20986#460112 , @broulik wrote: > -1 > > Most KCMs actually use `onClicked` to update the selected plugin and other bits. They don't actually set `currentIndex` on the `ListView` directly but have it updated based

D21183: search in the new location for knsrc files

leinir requested changes to this revision. leinir added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > main.cpp:49 > > -const auto knsname = > QStandardPaths::locate(QStandardPaths::GenericConfigLocation, url.host()); > +auto knsname = > QStandardPat

D21183: search in the new location for knsrc files

leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. In the words of the interwebs whenever someone days a certain number: nice :) REPOSITORY R252 Framework Integration BRANCH phab/newlocation REVISION DETAIL https://phabricator.kde.or

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY Basic KNewStuffQuick dialog for testing purposes Actually return the number of comments, not the rating Change t

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir edited the summary of this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D21721 To: leinir Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

[Differential] [Accepted] D4063: Only continue if it's what was said

leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. Ah, yes, quite, push away :) REPOSITORY R304 KNewStuff BRANCH master REVISION DETAIL https://phabricator.kde.org/D4063 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel

[Differential] [Accepted] D4048: Support some of the KNSCore questions using notifications

leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. That works, yup :) REPOSITORY R252 Framework Integration BRANCH master REVISION DETAIL https://phabricator.kde.org/D4048 EMAIL PREFERENCES https://phabricator.kde.org/settings/pan

[Differential] [Accepted] D4120: add support for display_name in categories

leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. We will need to consider the implications of adding functionality into ocs, but technically this would be fine. REPOSITORY R304 KNewStuff BRANCH phab/displayname REVISION DETAIL htt

[Differential] [Accepted] D4121: add support for display_name in categories

leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. This being an extension of ocs, we will need to prepare a proposal of this at some point in the not too far distant future. However, as other things (tags etc) are also going to be required

[Differential] [Accepted] D4156: sort alphabetically category list

leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. LGTM :) REPOSITORY R304 KNewStuff BRANCH phab/sort REVISION DETAIL https://phabricator.kde.org/D4156 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Accepted] D4118: if is not an archive, always copy

leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. Right. I think we can sensibly pick this. I would like a comment added, though, that future "don't simply install things" logic should go into the section above this one, rather than into t

[Differential] [Accepted] D4065: Don't ask if we're getting the file in /tmp

leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. Go for it REPOSITORY R304 KNewStuff BRANCH master REVISION DETAIL https://phabricator.kde.org/D4065 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Accepted] D4226: [KNS] Take into account the distribution type

leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. Yup, this is fairly clearly what this is really supposed to be doing... REPOSITORY R304 KNewStuff BRANCH master REVISION DETAIL https://phabricator.kde.org/D4226 EMAIL PREFERENCES

D5001: Add support for killing a KAuth::ExecuteJob

leinir created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY This implements the standard method for stopping a KJob in KAuth::ExecuteJob. It is done using a minimal-intrusion approach, and is supposed to feel familiar to people already used to working wit

D5003: Update docs to Frameworks API

leinir requested changes to this revision. leinir added a comment. This revision now requires changes to proceed. Thinking this is... well under way, with a couple of details :) INLINE COMMENTS > kauthactionreply.h:338 > -* > -* In case of errors coming from the library, the type() is > -* Ac

D5003: Update docs to Frameworks API

leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. That looks about right to me! :) REPOSITORY R283 KAuth BRANCH docs REVISION DETAIL https://phabricator.kde.org/D5003 To: jriddell, leinir Cc: #frameworks

D5001: Add support for killing a KAuth::ExecuteJob

leinir closed this revision. leinir added a comment. Closed by commit https://commits.kde.org/kauth/39621f485f434fb4453a1fd6af2796cde23eec53 REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D5001 To: leinir, #frameworks, jriddell Cc: jriddell

D5402: always close the downloaded file after downloading

leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. Yes, good catch. I am unsure of why that happened, but i quite agree, that certainly needs to happen whether or not a redirection has been involved. REPOSITORY R304 KNewStuff BRANCH ph

D5587: Improvements

leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. Looks good to me :) REPOSITORY R304 KNewStuff BRANCH master REVISION DETAIL https://phabricator.kde.org/D5587 To: apol, #frameworks, leinir

D5638: Use a single QNAM (and a disk cache) for HTTP jobs

leinir created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Use a single QNetworkAccessManager instance for all our HTTP jobs, and also add a simple diskcache to that qnam. Further ensure there is only

D5639: Internal cache for provider data on initialisation

leinir created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This is a two layer approach to creating less network traffic when initialising a KNSCore::Engine: - Firstly, cache the xml documents th

D5639: Internal cache for provider data on initialisation

leinir added a comment. In https://phabricator.kde.org/D5639#105620, @apol wrote: > Won't caching already fix the problem of traffic there? This change adds quite some complexity (all these QMutex make me cringe, these methods should always be called from the same thread anyway...)

D5638: Use a single QNAM (and a disk cache) for HTTP jobs

leinir marked an inline comment as done. leinir added inline comments. INLINE COMMENTS > apol wrote in httpworker.cpp:33 > How about getting a class with these 3 attributes? Looks like we're juggling > here... You know, that sounds like a good plan. Updated diff incoming :) REPOSITORY R304 K

D5638: Use a single QNAM (and a disk cache) for HTTP jobs

leinir updated this revision to Diff 14079. leinir marked an inline comment as done. leinir added a comment. Simpler logic, with the global qnam (etc) stored in a locally defined class, so we only have the one global static, and also allowing the qnam access to be more pleasantly locked. REP

D5639: Internal cache for provider data on initialisation

leinir updated this revision to Diff 14080. leinir edited the summary of this revision. leinir added a comment. Simplify the logic, and only do the xmlloader caching, not the documents themselves which (as apol points out) should be cached already anyway. Not only that, but that codepath was

<    1   2   3   4   5   6   >