D23800: Use ECMGenerateExportHeader to manage deprecated API better

This revision was automatically updated to reflect the committed changes. Closed by commit R244:76d89c91e05f: Use ECMGenerateExportHeader to manage deprecated API better (authored by kossebau). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23800?vs=67221&

D23802: Use ECMGenerateExportHeader to manage deprecated API better

kossebau added a comment. If no-one objects, would be pushing on Monday evening, Oct. 14th. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D23802 To: kossebau, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24465: Use ECMGenerateExportHeader to manage deprecated API better

kossebau added a comment. If no-one objects, would be pushing on Monday evening, Oct. 14th. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D24465 To: kossebau, #frameworks, #kwin, dfaure, zzag Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24466: Use ECMGenerateExportHeader to manage deprecated API better

kossebau added a comment. If no-one objects, would be pushing on Monday evening, Oct. 14th. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D24466 To: kossebau, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24467: Use ECMGenerateExportHeader to manage deprecated API better

kossebau added a comment. If no-one objects, would be pushing on Monday evening, Oct. 14th. REPOSITORY R306 KParts REVISION DETAIL https://phabricator.kde.org/D24467 To: kossebau, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24468: Use ECMGenerateExportHeader to manage deprecated API better

kossebau added a comment. If no-one objets, would be pushing on Monday evening, Oct. 14th. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D24468 To: kossebau, #frameworks, cfeck Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23802: Use ECMGenerateExportHeader to manage deprecated API better

kossebau updated this revision to Diff 67655. kossebau added a comment. tests no longer need to unset KSERVICE_DEPRECATED REPOSITORY R309 KService CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23802?vs=67222&id=67655 BRANCH useECMGenerateExportHeader REVISION DETAIL https:/

D23789: Add ECMGenerateExportHeader, for improved handling of deprecated API

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R240:7b15c20dafc9: Add ECMGenerateExportHeader, for improved handling of deprecated API (authored by kossebau). CHANGED PRI

D23789: Add ECMGenerateExportHeader, for improved handling of deprecated API

kossebau added a comment. To keep the momentum, now going to merge, given there was no objection when I pointed out the plan to move forward both here and in the email to frameworks-devel. I assume no-one has time enough to wrap their brain around this as well and/or too many other competi

D24537: Icons for windy weather

kossebau added a comment. Thanks for the icon work. I fear some info here though has been lost: what is needed is an icon which describes "windy weather" in general, where we have no other info about whether it is cloudy, sunny or not. At least by what I understood from D24483

D23789: Add ECMGenerateExportHeader, for improved handling of deprecated API

kossebau updated this revision to Diff 67620. kossebau marked an inline comment as done. kossebau added a comment. switch to do generation-time decision about deprecated(text) attribute usage GCC/Clang are mostly ABI-compatible, so mixing and linking of artifacts from both compilers can

D23789: Add ECMGenerateExportHeader, for improved handling of deprecated API

kossebau retitled this revision from "Add ECMGenerateExportHeaders, for improved handling of deprecated API" to "Add ECMGenerateExportHeader, for improved handling of deprecated API". REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D23789 To: kossebau, #fram

D23789: Add ECMGenerateExportHeaders, for improved handling of deprecated API

kossebau updated this revision to Diff 67584. kossebau added a comment. improve documentation, especially about the generated C++ macros REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23789?vs=67554&id=67584 BRANCH addgenerateexportheader RE

D23789: Add ECMGenerateExportHeaders, for improved handling of deprecated API

kossebau marked 2 inline comments as done. kossebau added inline comments. INLINE COMMENTS > dfaure wrote in ECMGenerateExportHeader.cmake:269 > Really? Isn't doWhat excluded only if EXCLUDE_DEPRECATED_BEFORE_AND_AT is set > to 5.12.0? > With 5.0.0 it's still available, no? > > I'm also surpris

D23789: Add ECMGenerateExportHeaders, for improved handling of deprecated API

kossebau updated this revision to Diff 67554. kossebau marked an inline comment as done. kossebau added a comment. - update to David's findings in the docs REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23789?vs=67523&id=67554 BRANCH addgener

D21356: Port to ECMAddQmlModule, add plugins.qmltypes files

kossebau abandoned this revision. kossebau added a comment. Not sure of usefulness (see D20984#543937 ), so discarding myself. Happy to see someone else take over though if they feel this improves things. REPOSITORY R296 KDeclarative REVISION DET

D21356: Port to ECMAddQmlModule, add plugins.qmltypes files

kossebau added a dependency: D20984: Add ECMAddQmlModule. REPOSITORY R296 KDeclarative BRANCH porttoECMInstallQmlModules REVISION DETAIL https://phabricator.kde.org/D21356 To: kossebau, #plasma, apol Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D20984: Add ECMAddQmlModule

kossebau added a dependent revision: D21356: Port to ECMAddQmlModule, add plugins.qmltypes files. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D20984 To: kossebau, #plasma, apol Cc: apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy,

D21344: Port to ECMAddQmlModule

kossebau abandoned this revision. kossebau added a comment. Not sure of usefulness (see D20984#543937 ), so discarding myself. Happy to see someone else take over though if they feel this improves things. REPOSITORY R242 Plasma Framework (Library)

D21344: Port to ECMAddQmlModule

kossebau added a dependency: D20984: Add ECMAddQmlModule. REPOSITORY R242 Plasma Framework (Library) BRANCH porttoECMInstallQmlModules REVISION DETAIL https://phabricator.kde.org/D21344 To: kossebau, #plasma, apol Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D20984: Add ECMAddQmlModule

kossebau added a dependent revision: D21344: Port to ECMAddQmlModule. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D20984 To: kossebau, #plasma, apol Cc: apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

D20984: Add ECMAddQmlModule

kossebau abandoned this revision. kossebau added a comment. @apol Thanks again for your review work. I am still a bit unsure about the usefulness and completeness of this macro, even more as I would not call myself a QML expert who has seen all corners. And given the lack of feedback fro

D23789: Add ECMGenerateExportHeaders, for improved handling of deprecated API

kossebau added a comment. So, given the lack of further change proposals or objections, I would proceed to push this in the next days (Thurday evening or Friday morning), to have 3 weeks of pre-5.64 real world testing by CI and people running from git master. See also https://mail.kde.org/

D23789: Add ECMGenerateExportHeaders, for improved handling of deprecated API

kossebau updated this revision to Diff 67523. kossebau added a comment. - add missing group defaulting for warning settings, got lost in rebase before REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23789?vs=67324&id=67523 BRANCH addgenerateex

D24494: Add convenience for defaults/dirty states to KCoreConfigSkeleton

kossebau added inline comments. INLINE COMMENTS > kcoreconfigskeleton.h:216 > + * > + * @since 5.63 > + */ -> 5.64 REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D24494 To: ervin, #plasma, #frameworks, dfaure, mart Cc: kossebau, davidedmundson, kde-framewo

D24490: Make kconfig_compiler generate ctors with the optional parent arg

kossebau added a comment. In D24490#543807 , @ervin wrote: > In D24490#543724 , @kossebau wrote: > > > How does this effect the BIC of the generated classes? Consumers might have exposed the generat

D24490: Make kconfig_compiler generate ctors with the optional parent arg

kossebau added a comment. How does this effect the BIC of the generated classes? Consumers might have exposed the generated classes in public API. Any chance this could become a opt-in change for KF5 times? REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D24490 To:

D24496: Use ECMGenerateExportHeader to manage deprecated API better

kossebau created this revision. kossebau added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Allows - projects linking to KConfigCore/Gui to hide deprecated API up to

D24497: Use ECMGenerateExportHeader to manage deprecated API better

kossebau created this revision. kossebau added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Allows - projects linking to KConfigWidgets to hide deprecated API up to a

D24495: Use ECMGenerateExportHeader to manage deprecated API better

kossebau created this revision. kossebau added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Allows - projects linking to KCompletion to hide deprecated API up to a gi

D24468: Use ECMGenerateExportHeader to manage deprecated API better

kossebau created this revision. kossebau added reviewers: Frameworks, cfeck. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Allows - projects linking to KWidgetsAddons to hide deprecated API u

D24467: Use ECMGenerateExportHeader to manage deprecated API better

kossebau created this revision. kossebau added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Allows - projects linking to KParts to hide deprecated API up to a

D24466: Use ECMGenerateExportHeader to manage deprecated API better

kossebau created this revision. kossebau added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Allows - projects linking to KXmlGui to hide deprecated API up to a

D24465: Use ECMGenerateExportHeader to manage deprecated API better

kossebau created this revision. kossebau added reviewers: Frameworks, KWin, dfaure, zzag. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Allows - projects linking to KWindowSystem to hide depr

D23800: Use ECMGenerateExportHeader to manage deprecated API better

kossebau added a comment. @mpyne Thanks for the immediate review and testing In D23800#542391 , @mpyne wrote: > I encountered that excluding deprecated components from the build requires a version of x.y.z. (not just x.y) but other than that

Call for action: applying version-based deprecation macros for KDE Frameworks API

Hi, for those who missed things so far, quick recap first (everyone else please jump to next section below): To better assist users of KDE Frameworks in dealing with its deprecated API, we might want to give them more control over visibility of such API to the compiler when building their soft

D23802: Use ECMGenerateExportHeader to manage deprecated API better

kossebau retitled this revision from "RFC: Use ECMGenerateExportHeader to manage deprecated API better" to "Use ECMGenerateExportHeader to manage deprecated API better". kossebau added reviewers: Frameworks, dfaure. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D23802

D23789: Add ECMGenerateExportHeaders, for improved handling of deprecated API

kossebau added reviewers: Frameworks, Build System. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D23789 To: kossebau, #frameworks, #build_system Cc: chehrlic, dfaure, cgiboudeaux, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh,

D23800: Use ECMGenerateExportHeader to manage deprecated API better

kossebau retitled this revision from "RFC: Use ECMGenerateExportHeader to manage deprecated API better" to "Use ECMGenerateExportHeader to manage deprecated API better". kossebau added reviewers: Frameworks, mpyne. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D238

D23789: Add ECMGenerateExportHeaders, for improved handling of deprecated API

kossebau retitled this revision from "RFC: Add ECMGenerateExportHeaders, for improved handling of deprecated API" to "Add ECMGenerateExportHeaders, for improved handling of deprecated API". REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D23789 To: kossebau

[EMAIL WAS STILL DRAFT] Re: Version-based deprecation macros for KDE Frameworks API: execution plan

Am Freitag, 4. Oktober 2019, 17:37:12 CEST schrieb Friedrich W. H. Kossebau: > Hi, > > for those who missed things so far, quick recap first: Premature send due to Shift+Backspace becoming press of Shift+Return key and instant email sending while still drafting :) Well, please do the

Version-based deprecation macros for KDE Frameworks API: execution plan

Hi, for those who missed things so far, quick recap first: To better assist users of KDE Frameworks in dealing with its deprecated API, we might want to give them more control over visibility of such API to the compiler when building their software or if deprecation warnings are emitted. For s

D23789: RFC: Add ECMGenerateExportHeaders, for improved handling of deprecated API

kossebau updated this revision to Diff 67324. kossebau added a comment. - extend unit tests to cover library group macro variants Sadly blows up by all combinations unit test time to >1 min on old machine REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricat

D23789: RFC: Add ECMGenerateExportHeaders, for improved handling of deprecated API

kossebau added a comment. In D23789#540033 , @dfaure wrote: > I found confirmation in cmake's Tests/RunCMake/GenerateExportHeader/reference/ Not sure what you exactly mean, can you please specify confirmation for what? And what this reco

D23802: RFC: Use ECMGenerateExportHeader to manage deprecated API better

kossebau updated this revision to Diff 67222. kossebau edited the test plan for this revision. kossebau added a comment. - update to latest version of ecm_generate_export_header with deprecation text support REPOSITORY R309 KService CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D

D23800: RFC: Use ECMGenerateExportHeader to manage deprecated API better

kossebau updated this revision to Diff 67221. kossebau added a comment. - update to latest version of ecm_generate_export_header with deprecation text support REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23800?vs=65686&id=67221 BRANCH useECMGenera

D23789: RFC: Add ECMGenerateExportHeaders, for improved handling of deprecated API

kossebau updated this revision to Diff 67220. kossebau added a comment. - extend *_VERSION_DEPRECATED to expect third argument "text" first experimental consumption time support for "text" output with GCC compiler - make *_NO_DEPRECATED a proper shortcut for DISABLE_BEFORE_AND_AT=CURRENT -

D23789: RFC: Add ECMGenerateExportHeaders, for improved handling of deprecated API

kossebau added a comment. In D23789#539940 , @dfaure wrote: > I see the theoretical problem, but how could this ever be a problem in practice? > On Unix all compilers support the same syntax (`__attribute__ ((__deprecated__))`), so you'd have

D23789: RFC: Add ECMGenerateExportHeaders, for improved handling of deprecated API

kossebau added a comment. Quick Update (week 40): Locally have added experimental code to even set the proper attribute for GCC compiler, so we get e.g.: /home/koder/Kode/kdegit/kf5/frameworks/kparts/tests/notepad.cpp: In constructor ‘NotepadPart::NotepadPart(QWidget*, QObject*, cons

D24262: Modernize code: use range-based loops & algorithms in more places

This revision was automatically updated to reflect the committed changes. Closed by commit R306:65c55de00bae: Modernize code: use range-based loops & algorithms in more places (authored by kossebau). REPOSITORY R306 KParts CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24262?vs=67046

D24262: Modernize code: use range-based loops & algorithms in more places

kossebau added inline comments. INLINE COMMENTS > dfaure wrote in browseropenorsavequestion.cpp:270 > I give C++11/14/17 trainings, if it helps :-) :) Though, I doubt you give them in single person understanding-pace-driven tiredness-cut bed settings (besides own family how to tell a nerd k

D24261: Modernize code: use range-based for loop in more places

kossebau updated this revision to Diff 67047. kossebau added a comment. - move &/* to variable name ' use explicit const REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24261?vs=66989&id=67047 BRANCH morerangebasedforloops REVISION DETAIL https://

D24262: Modernize code: use range-based loops & algorithms in more places

kossebau added inline comments. INLINE COMMENTS > dfaure wrote in browseropenorsavequestion.cpp:270 > auto or not auto isn't the question when it comes to const :-) > > Would you have written `foreach(QString &app, apps)` if `apps` was a > qstringlist (to simplify)? > Or `for (QString &app : ap

D24262: Modernize code: use range-based loops & algorithms in more places

kossebau updated this revision to Diff 67046. kossebau marked 3 inline comments as done. kossebau added a comment. - move &/* to varname - explicit const with auto types REPOSITORY R306 KParts CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24262?vs=66996&id=67046 BRANCH morer

D24262: Modernize code: use range-based loops & algorithms in more places

kossebau added a comment. In D24262#539348 , @ahmadsamir wrote: > @kossebau: did you try the C++ Standard (working draft): https://isocpp.org/blog/2013/10/n3797-working-draft-standard-for-programming-language-c-stefanus-du-toit > > This ^ on

D24262: Modernize code: use range-based loops & algorithms in more places

kossebau added inline comments. INLINE COMMENTS > dfaure wrote in browseropenorsavequestion.cpp:270 > Why not *const* auto &app? In most projects I have seen people omitting the const, and only adding explicitly any &/* to help the human reader a bit more. If you prefer explicit const, fine wit

D24262: Modernize code: use range-based loops & algorithms in more places

kossebau added a comment. Thanks for your teaching, appreciated :) Will have another look again when not tired. Just tried again to read on cppreference.com the stuff about lambda capturing, but still not digested what I read this afternoon, reread now did not help. So next try scheduled.

D24160: [KIO] Modernize the code to use range-for in more places

kossebau accepted this revision. kossebau added a comment. This revision is now accepted and ready to land. Code changes look all fine to me. Only looked at code here with eyes (tired and fermentation products influenced ;) ), not built, run or tested though. REPOSITORY R241 KIO BRANCH 2

D24262: Modernize code: use range-based loops & algorithms in more places

kossebau added inline comments. INLINE COMMENTS > kossebau wrote in plugin.cpp:196 > Meh, I need to check quite some code of mine then, I got that wrong and > thought that the values of the actual variables listed are captured (i.e. for > a reference type the reference "pointer"), and not that

D24262: Modernize code: use range-based loops & algorithms in more places

kossebau updated this revision to Diff 66996. kossebau added a comment. properly mark captured variable to be captured by reference as intended REPOSITORY R306 KParts CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24262?vs=66950&id=66996 BRANCH morerangebased REVISION DETAIL

D24262: Modernize code: use range-based loops & algorithms in more places

kossebau added inline comments. INLINE COMMENTS > dfaure wrote in plugin.cpp:196 > STL is fine by definition, it's the C++ standard. > > But yes, no need for cbegin/cend on a const container. > > Catching `library` by reference makes sense, just like you wouldn't pass it > by value to a functi

D24262: Modernize code: use range-based loops & algorithms in more places

kossebau added inline comments. INLINE COMMENTS > dhaumann wrote in plugin.cpp:196 > cbegin() + cend() > Catch library by reference? [& library] Do we have rules in KF whether stl-like names liks cbegin() & cend() are fine? Then plugins is const, so begin()/end() are giving use the const iterato

D24261: Modernize code: use range-based for loop in more places

kossebau updated this revision to Diff 66989. kossebau added a comment. update to @dhaumann's first review: - drop wrong change for loop starting at 1 - use plain array for shortcutTitleToColumnMap REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24261

D24261: Modernize code: use range-based for loop in more places

kossebau added a comment. Thanks for review work, @dhaumann :) Seems we have some differences though, so let's try to align knowledge: When it comes to by-value or by reference of the loop range element value, I learned that similar rules as for arguments are valid: small size in bytes

D23789: RFC: Add ECMGenerateExportHeaders, for improved handling of deprecated API

kossebau added a comment. Thanks for your reply, Christian :) In D23789#538876 , @chehrlic wrote: > In D23789#536338 , @kossebau wrote: > > > Actual questions I have: > > > > - why is QT_DEP

D24262: Modernize code: use range-based loops & algorithms in more places

kossebau created this revision. kossebau added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY GIT_SILENT TEST PLAN Tests pass, KParts-based apps work as before. REPOSITORY

D24261: Modernize code: use range-based for loop in more places

kossebau created this revision. kossebau added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY GIT_SILENT TEST PLAN Test pass, KXMLGUI-based apps showed no regressions incl. e

Re: Proposing Quick Charts as a new framework

Am Mittwoch, 18. September 2019, 11:50:58 CEST schrieb Arjen Hiemstra: > On 09-09-2019 10:24, Dominik Haumann wrote: > > Hi, > > > > On Sat, Sep 7, 2019 at 3:59 PM Arjen Hiemstra > > > > wrote: > >> On 06-09-2019 02:49, Aleix Pol wrote: > >>> On Thu, Sep 5, 2019 at 10:53 PM Arjen Hiemstra > >>

D23927: Improve naming of KTitleWidget icon methods

kossebau added a comment. In D23927#537585 , @vkrause wrote: > Moving even more towards a QIcon rather than a QPixmap API is a good thing for sure, I agree on that. I don't think going back is justified here though, especially since the QIcon-ba

D23927: Improve naming of KTitleWidget icon methods

kossebau added a comment. When going to adapt some code to follow the deprecation, I now look though at some inconsistency in the API: - KTitleWidget has a property "pixmap" - the `setPixmap` methods all set this pixmap, with overloads for convenience - `setIcon` is without a getter a

D24160: [KIO] Modernize the code to use range-for in more places

kossebau added a comment. Not tested the changes myself, only looked at the code here. Looks good to me in general, modulo the comments I made. When it comes to `it`, my code reading expectations are that it is a real iterator, same like `i` is an integer index. The current patch propos

D23789: RFC: Add ECMGenerateExportHeaders, for improved handling of deprecated API

kossebau updated this revision to Diff 66670. kossebau added a comment. add first set of unit tests covering the main functionality. Feedback on principal approach wanted! Also add some fixes to actual macro code found by the tests already :) REPOSITORY R240 Extra CMake Modules CHANG

D24159: new module ECMSourceVersionControl

kossebau added a comment. In D24159#536388 , @kossebau wrote: > Should the new module be part of public ECM macros? Then it misses a documentation linking file `docs/module/ECMSourceVersionControl.rst` I am blind, ignore me. REPOSITORY

D24159: new module ECMSourceVersionControl

kossebau added a comment. Should the new module be part of public ECM macros? Then it misses a documentation linking file `docs/module/ECMSourceVersionControl.rst` Would be also good to have this variable being set mentioned in KDECompilerSettings, unless this is also not under public AP

D24160: [KIO] Modernize the code to use range-for in more places

kossebau added a comment. Will see to give this some review later this week (if still needed). Would agree the "modern" code is more easy to grasp by humans and thus better to maintain, so +1 for principle. All override changes please as separate commit though, unrelated to commit messa

D23789: RFC: Add ECMGenerateExportHeaders, for improved handling of deprecated API

kossebau added a subscriber: chehrlic. kossebau added a comment. @chehrlic Hi. As I just discovered, you are the author of the macros for Qt (commit ) which I took as inspiration/blue print when designi

D23789: RFC: Add ECMGenerateExportHeaders, for improved handling of deprecated API

kossebau added a comment. Quick Update (week 39): took me a bit longer to design and write tests, not trained to write such things in cmake code, all its magic & caches & scopes + own undiscovered typos make this not (yet?) fun, and I am not certain I have done things properly, so will be

D23791: ECMAddQch: add INCLUDE_DIRS argument

This revision was automatically updated to reflect the committed changes. Closed by commit R240:ee4c3fd91eea: ECMAddQch: add INCLUDE_DIRS argument (authored by kossebau). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23791?vs=65657&id=66099 REVIS

D23946: Remove dependency on kdesignerplugin

kossebau added a comment. The current macro does not check for the existence, so the dep is hard IMHO. One could change that, but myself no energy left to work on/review such patch, all my energy would be spent to get of kdelibs4support completely in general :) REPOSITORY R239 KDELibs

D23946: Remove dependency on kdesignerplugin

kossebau added a comment. PS: That''s also the reason why I gave up on porting kdelibs4support away from it, given the tool is leaked in the public interface by this macro (cmp. comment D22776#503175 ) REPOSITORY R239 KDELibs4Support REVISION DET

D23946: Remove dependency on kdesignerplugin

kossebau added a comment. It's there because one of the cmake macros kdelibs4support installs depends on its existance, see https://phabricator.kde.org/source/kdelibs4support/browse/master/src/KDEUIMacros.cmake$166 REPOSITORY R239 KDELibs4Support REVISION DETAIL https://phabricator.kd

D23789: RFC: Add ECMGenerateExportHeaders, for improved handling of deprecated API

kossebau added a comment. Quick update: Currently still busy trying to get unit tests done, half-way through that. ETA begin of upcoming week. Next plan: see how only having the 3-arg-`FOO_DEPRECATED_VERSION(major. minor, message)` would work by using that in the experimental patches done

D23813: Port away from foreach loops over arguments without calls to owner class

kossebau added inline comments. INLINE COMMENTS > ahmadsamir wrote in kkeysequencewidget.cpp:127 > I admit "making them const as needed" is badly phrased; I meant whether the > container iterated-over is const to begin with, or can be made const in the > range-for to avoid a detach/deep-copy ..

D23813: Port away from foreach loops over arguments without calls to owner class

kossebau added inline comments. INLINE COMMENTS > ahmadsamir wrote in kkeysequencewidget.cpp:127 > I understand. but I was talking about this case specifically, it's about > foreach two arguments, and making them const as needed, so that seqAsString > change is in inline with replacing foreach

D23551: CMake config files: use as dep version the Qt one built against (private API)

kossebau retitled this revision from "CMake config files: use as min dep version the Qt version we built against" to "CMake config files: use as dep version the Qt one built against (private API)". REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D23551 To: kossebau, #fr

D23813: Port away from foreach loops over arguments without calls to owner class

kossebau added inline comments. INLINE COMMENTS > ahmadsamir wrote in kkeysequencewidget.cpp:127 > My two (inexperienced) pennyworth: if it makes sense, and should have been > done to begin with (so most likely it's an oversight), I'd always go for it > (who knows how long it'll be before that

D23789: RFC: Add ECMGenerateExportHeaders, for improved handling of deprecated API

kossebau added inline comments. INLINE COMMENTS > dfaure wrote in ECMGenerateExportHeader.cmake:87 > I'm having trouble parsing the "only" in this sentence. > > `deprecated API only`... that seems redundant, it's only API that gets > deprecated :-) > > Maybe you mean "to disable only at build

D23789: RFC: Add ECMGenerateExportHeaders, for improved handling of deprecated API

kossebau updated this revision to Diff 65854. kossebau marked 3 inline comments as done. kossebau added a comment. - reword documentation based on dfaure's comments - bump since-version to 5.64.0, as currently targetted introduction version Hope is review can be finished at 5.63 tagging

D23789: RFC: Add ECMGenerateExportHeaders, for improved handling of deprecated API

kossebau added a comment. @dfaure Thanks for first in-detail feedback, good to get a feeling this is not totally insane over-engineered stuff to other people'e eyes :) In D23789#528994 , @dfaure wrote: > Great work. Not really easy to grasp

D23861: Port away from Qt's foreach: loop directly over pimpl member

This revision was automatically updated to reflect the committed changes. Closed by commit R263:efc2e0c3dbe9: Port away from Qt's foreach: loop directly over pimpl member (authored by kossebau). REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23861?vs=65814&id=

D23861: Port away from Qt's foreach: loop directly over pimpl member

kossebau created this revision. kossebau added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY The old implementation of all the KActionCollection methods was a bit inconsisten

D23813: Port away from foreach loops over arguments without calls to owner class

kossebau added a comment. Thanks for review :) INLINE COMMENTS > dfaure wrote in kkeysequencewidget.cpp:127 > This could even be `const QString seq = it.key().toString();` so that > toString() is only called once. I try (hard, there are many temptations when looking at all exisiting loop c

D23813: Port away from foreach loops over arguments without calls to owner class

This revision was automatically updated to reflect the committed changes. Closed by commit R263:02ee352df1af: Port away from foreach loops over arguments without calls to owner class (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D23813?vs=65716&id=65808#toc REPOSI

D23812: Port away from foreach loops over members without calls to owner class

This revision was automatically updated to reflect the committed changes. Closed by commit R263:c0844ac2a6d6: Port away from foreach loops over members without calls to owner class (authored by kossebau). REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23812?vs

D23816: [KItemViews] Port to non-deprecated QWheelEvent API

kossebau added a comment. Seems not okay with KDE CI though ;) -> https://build.kde.org/view/Failing/job/Frameworks/job/kitemviews/ Some 5.14 API-only method now used? REPOSITORY R276 KItemViews REVISION DETAIL https://phabricator.kde.org/D23816 To: dfaure, mlaurent Cc: kossebau, k

D23839: Port away from Qt's foreach

This revision was automatically updated to reflect the committed changes. Closed by commit R278:1081a6b284ba: Port away from Qt's foreach (authored by kossebau). REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23839?vs=65768&id=65782 REVISION DETAIL ht

D23839: Port away from Qt's foreach

kossebau added a comment. @zzag Actually, while you commented on that one loop only, the same would be valid also for other loops touched in the patch. So, do you want const ref with all of them? As you can see by the existing code, it also already used values, not const ref, surely also for

D23839: Port away from Qt's foreach

kossebau added inline comments. INLINE COMMENTS > zzag wrote in kwindowsystem_threadtest.cpp:61 > I asked that because `for (const Type &item : collection) {` is more common. > I know that const ref doesn't have any advantages here. (Gah, phab ate this comment before, rewriting) Getting the ite

D23839: Port away from Qt's foreach

kossebau added a comment. Thanks for review, Albert & Vlad. BTW; still one foreach left in macOS branch of code, which I could not test-drive, so did not change (also touching internals that I could not quickly understand if there is a chance to conflicting container changes in the call

D23839: Port away from Qt's foreach

kossebau added a comment. In D23839#528788 , @zzag wrote: > Did you use a script to create this patch? Nope, manually done. INLINE COMMENTS > zzag wrote in kwindowsystem_threadtest.cpp:61 > Capture the value by const ref please. Would a

<    3   4   5   6   7   8   9   10   11   12   >