KF6 meeting notes 2021-11-23

2021-11-23 Thread Volker Krause
https://invent.kde.org/frameworks/kcoreaddons/-/merge_requests/149 * needs input by Nico https://phabricator.kde.org/T13924 * unused private class inheritance infrastructure can be removed at any time without breaking ABI

Reminder: Weekly KF6 Meeting

2021-11-22 Thread Volker Krause
Hello everyone, please remember the weekly KF6 meeting tomorrow, Tuesday 17:00 CET, on https://meet.kde.org/b/ada-mi8-aem! Thank you, Volker signature.asc Description: This is a digitally signed message part.

Re: Fwd: KDE CI: Administration » Dependency Build Applications kf5-qt5 FreeBSDQt5.15 - Build # 127 - Still Failing!

2021-11-18 Thread Volker Krause
On Donnerstag, 18. November 2021 18:47:37 CET Ben Cooksley wrote: > On Fri, Nov 19, 2021 at 6:39 AM Volker Krause wrote: > > I looked into this and it seems the problem had already been addressed > > prior > > to your email, so all I ended up doing is pressi

Re: Fwd: KDE CI: Administration » Dependency Build Applications kf5-qt5 FreeBSDQt5.15 - Build # 127 - Still Failing!

2021-11-18 Thread Volker Krause
On Donnerstag, 18. November 2021 19:39:09 CET Friedrich W. H. Kossebau wrote: > Am Donnerstag, 18. November 2021, 18:37:37 CET schrieb Volker Krause: > > I looked into this and it seems the problem had already been addressed > > prior to your email, so all I ended up doing is press

Re: Fwd: KDE CI: Administration » Dependency Build Applications kf5-qt5 FreeBSDQt5.15 - Build # 127 - Still Failing!

2021-11-18 Thread Volker Krause
I looked into this and it seems the problem had already been addressed prior to your email, so all I ended up doing is pressing the rebuild button. The change starting this was https://invent.kde.org/frameworks/ki18n/-/ merge_requests/21, by me. What actually caused the breakage however was the

KF6 meeting notes 2021-11-09

2021-11-16 Thread Volker Krause
[Davids: please look for the items needing your input :)] https://invent.kde.org/frameworks/extra-cmake-modules/-/merge_requests/142 * what's the status of this? * important for enabling Qt6 builds, so would be good to get in * David F?

Reminder: Weekly KF6 Meeting

2021-11-15 Thread Volker Krause
Hello everyone, please remember the weekly KF6 meeting tomorrow, Tuesday 17:00 CET, on https://meet.kde.org/b/ada-mi8-aem! Thank you, Volker signature.asc Description: This is a digitally signed message part.

KF6 meeting notes 2021-11-09

2021-11-09 Thread Volker Krause
https://phabricator.kde.org/T12101 * we want QKeyChain as the consumer API (port in progress) * there's a pending merge request to add secret service API to KWallet -> move to in progress https://invent.kde.org/frameworks/purpose/-/issues/1 * Purpose has a very generic API, but currently only

Reminder: Weekly KF6 Meeting

2021-11-08 Thread Volker Krause
Hello everyone, please remember the weekly KF6 meeting tomorrow, Tuesday 17:00 CET, on https://meet.kde.org/b/ada-mi8-aem! Thank you, Volker signature.asc Description: This is a digitally signed message part.

Re: What is our plan for Qt6 and QXmlPatterns?

2021-10-28 Thread Volker Krause
On Donnerstag, 28. Oktober 2021 10:01:41 CEST Christoph Cullmann (cullmann.io) wrote: > On 2021-10-28 08:32, Helio Chissini de Castro wrote: > > Hi Albert > > > > Can i raise the questions on all valid possible solutions ? > > > > - Maintain qxmlpattern on our side > > - Move to libxslt > > -

Re: KF6 meeting notes 2021-10-26

2021-10-27 Thread Volker Krause
On Dienstag, 26. Oktober 2021 22:09:02 CEST Albert Astals Cid wrote: > El dimarts, 26 d’octubre de 2021, a les 18:05:42 (CEST), Volker Krause va escriure: > > !! Meeting will move to 17:00 CET next week (due to DST change in > > continental Europe) > > > > Threaded

KF6 meeting notes 2021-10-26

2021-10-26 Thread Volker Krause
!! Meeting will move to 17:00 CET next week (due to DST change in continental Europe) https://invent.kde.org/frameworks/kcoreaddons/-/merge_requests/149 * static plugin support draft, needs review * MRs to demonstrate the usage exists for KWin and KMyMoney

Reminder: Weekly KF6 Meeting moved to Tuesday!

2021-10-25 Thread Volker Krause
Hi everyone, please remember the weekly KF6 meeting tomorrow, Tuesday 15:00 UTC / 17:00 CEST, on https://meet.kde.org/b/ada-mi8-aem! Thank you, VolkerBEGIN:VCALENDAR PRODID:-//K Desktop Environment//NONSGML libkcal 4.3//EN VERSION:2.0 X-KDE-ICAL-IMPLEMENTATION-VERSION:1.0 METHOD:REQUEST

KF6 meeting notes 2021-10-19

2021-10-19 Thread Volker Krause
* https://invent.kde.org/frameworks/kservice/-/merge_requests/60#note_323530 Does it make sense to be specific about the deprecating the different constructors? * https://invent.kde.org/frameworks/kcoreaddons/-/commits/work/ kcoreaddons_static_plugin Review/testing needed. *

Reminder: Weekly KF6 Meeting moved to Tuesday!

2021-10-15 Thread Volker Krause
Hi everyone, please note the weekly KF6 meeting has been moved to Tuesday 15:00 UTC / 17:00 CEST, on https://meet.kde.org/b/ada-mi8-aem! A new iCal event is attached. Thank you, VolkerBEGIN:VCALENDAR PRODID:-//K Desktop Environment//NONSGML libkcal 4.3//EN VERSION:2.0

KF6 meeting notes 2021-10-11

2021-10-11 Thread Volker Krause
!! Changing the meeting time: - Monday conflicts with Alex's new university schedule and is difficult for David F, would Tuesday at the same time work for everyone instead? -> moved to Tuesday starting next week KF6 Timeline - Plasma needs to know for release planning for 2022 - possible

Reminder: Weekly KF6 Meeting

2021-10-08 Thread Volker Krause
Hi everyone, please remember the weekly KF6 meeting, every Monday 15:00 UTC / 17:00 CEST on https://meet.kde.org/b/ada-mi8-aem! And in case you don't know what to do until then, there's a huge review backlog for Frameworks that would benefit from your help :)

KF6 meeting notes 2021-10-04

2021-10-04 Thread Volker Krause
!! More reviews needed: - https://invent.kde.org/dashboard/merge_requests? scope=all=opened_username=alex - https://invent.kde.org/dashboard/merge_requests? scope=all=opened_username=ahmadsamir KIO slave on hold feature: - not needed anymore for passing to another application, but still needed

Reminder: Weekly KF6 Meeting

2021-10-01 Thread Volker Krause
Hi everyone, please remember the weekly KF6 meeting, every Monday 15:00 UTC / 17:00 CEST on https://meet.kde.org/b/ada-mi8-aem! As per popular request there's also an iCal event for these meetings attached. Thank you, VolkerBEGIN:VCALENDAR PRODID:-//K Desktop Environment//NONSGML libkcal

KF6 meeting notes 2021-09-27

2021-09-27 Thread Volker Krause
https://phabricator.kde.org/T12212 * search providers are used by apps, not just Plasma, so the move to Plasma seems wrong * David E doesn't remember creating the task, now considered a bad idea https://phabricator.kde.org/T12098 * not a kf6 blocker, could happen later

Reminder: Weekly KF6 Meeting

2021-09-24 Thread Volker Krause
Hi everyone, please remember the weekly KF6 meeting, every Monday 15:00 UTC / 17:00 CEST on https://meet.kde.org/b/ada-mi8-aem! Thank you, Volker signature.asc Description: This is a digitally signed message part.

Re: Extending the license policy to include ODbL-1.0

2021-09-23 Thread Volker Krause
done On Mittwoch, 22. September 2021 23:20:56 CEST Alexander Potashev wrote: > Thanks! > > Could you please update the changelog section > https://community.kde.org/Policies/Licensing_Policy#Changelog ? > > On Wed, Sep 22, 2021 at 5:38 PM Volker Krause wrote: > > Tha

Re: Extending the license policy to include ODbL-1.0

2021-09-22 Thread Volker Krause
Thanks everyone, I've added the suggested change to the wiki now. Regards, Volker On Mittwoch, 15. September 2021 17:26:57 CEST Volker Krause wrote: > Hi, > > there's a MR [1] for ki18n containing data tables generated from OSM data, > which implies the ODbL-1.0 license [2]. We

Re: QML API docs for C++ wrapper types?

2021-09-20 Thread Volker Krause
On Sonntag, 19. September 2021 19:43:46 CEST Carl Schwan wrote: > Le vendredi 17 septembre 2021 à 3:23 PM, Volker Krause a écrit : > > Hi, > > do we have an example somewhere how to do API docs markup properly for C++ > > wrappers for QML APIs? > > I don't think

KF6 meeting notes 2021-09-21

2021-09-20 Thread Volker Krause
Short meeting due to an acute David insufficiency, mainly discussion licensing issues. What to do about files without any license header at all? - ask everyone - for trivial files we can just add a CC0-1.0 license - can we assume the LICENSE file from a top-level folder applies as well? might

QML API docs for C++ wrapper types?

2021-09-17 Thread Volker Krause
Hi, do we have an example somewhere how to do API docs markup properly for C++ wrappers for QML APIs? Thinking about cases like these: https://invent.kde.org/frameworks/knotifications/-/merge_requests/49/ diffs#aa15f1228c0fb7ecaaa96bb9d8d843ef37033c2b_0_12

Extending the license policy to include ODbL-1.0

2021-09-15 Thread Volker Krause
Hi, there's a MR [1] for ki18n containing data tables generated from OSM data, which implies the ODbL-1.0 license [2]. We also already have other places ([3], [4]) actually doing this. However that's a license not yet covered by our license policy, so I suggest we add it. ODbL is essentially

KF6 meeting notes 2021-09-13

2021-09-13 Thread Volker Krause
Workboard clarification: - Needs Input is for tasks needing discussion in the weekly meeting - In Discussion was created during a sprint and should not be used outside of a sprint https://phabricator.kde.org/T12549 - do we need a KConfigXT extension for a setting/state separation? -> yes --

Reminder: Weekly KF6 Meeting

2021-09-10 Thread Volker Krause
Hi everyone, please remember the weekly KF6 meeting, every Monday 15:00 UTC / 17:00 CEST on https://meet.kde.org/b/ada-mi8-aem! I'm sure you don't want to let poor Alex end up all alone in the meeting room with all his burning questions blocking his Frameworks work going unanswered again, do

KF6 meeting notes 2021-08-30

2021-08-30 Thread Volker Krause
* https://phabricator.kde.org/T14312 - plugin loading is using a struct for this, so we consider this lower priority for now. * should we have a "nice to have" column on the work board? * https://phabricator.kde.org/T14784 - seems never set/used, so can be removed. *

Reminder: Weekly KF6 Meeting

2021-08-27 Thread Volker Krause
Hi everyone, please remember the weekly KF6 meeting, every Monday 15:00 UTC / 17:00 CEST on https://meet.kde.org/b/ada-mi8-aem. Attendance during the last two weeks was minimal unfortunately, hopefully just due to vacation time for many of you. Thank you, Volker signature.asc Description:

KF6 meeting notes 2021-08-02

2021-08-02 Thread Volker Krause
* https://phabricator.kde.org/T13056: Technically not a KF task, and solved itself by moving away from KAboutData. * https://phabricator.kde.org/T14564: There are a number of good reasons to consistently use JSON files, desktop files for editing might be nicer, but those files are rarely

KF6 meeting notes 2021-07-19

2021-07-19 Thread Volker Krause
Topics remaining from last week: * Raising the Qt minimum version to 5.15.2: https://mail.kde.org/pipermail/ kde-frameworks-devel/2021-July/118039.html * STL use in KF implementation: https://invent.kde.org/frameworks/kio/-/ merge_requests/484 * Friedrich's alternative ECM branching proposal:

KF6 meeting notes 2021-07-12

2021-07-12 Thread Volker Krause
Hi, apparently many people who voted for Monday 15:00 UTC as the new meeting time didn't get the memo yet that this is the new meeting time now ;-) So here's mainly topics that we weren't able to discuss and that we then need to cover next week (unless they resolve themselves on the mailing

KService as a platform abstraction framework?

2021-07-03 Thread Volker Krause
Hi, while looking at implementing a pretty straightforward KApplicationTrader/ KIO::ApplicationLauncherJob use ([1]) for Android, I found myself wondering whether we should have an Android backend for KService. KService conceptually matches android.content.pm.PackageManager/PackageInfo [2, 3],

KF6 Akademy BoF Notes 2021-06-21

2021-06-21 Thread Volker Krause
KF6 BoF Akademy Notes 2021-06-21 Topics: - how to continue and when to branch for a Qt 6 port - implications of Kevin's talk - better time for the weekly call - better priorities on the task board Branching: - Plasma and things depending on shadertools/RHI would like this to be done earlier

Re: KF6 meeting notes 2021-06-12

2021-06-18 Thread Volker Krause
On Freitag, 18. Juni 2021 22:27:40 CEST Kevin Ottens wrote: > On Friday, 18 June 2021 15:21:07 CEST Volker Krause wrote: > > Added now, Monday 09:00 UTC. > > OK, I will show up only at 10 though. I can't do 9. oh, sorry, I did this from the top of my head ("Monday morning

Re: KF6 meeting notes 2021-06-12

2021-06-18 Thread Volker Krause
On Freitag, 18. Juni 2021 15:01:00 CEST Kevin Ottens wrote: > Hello, > > On Tuesday, 15 June 2021 18:17:27 CEST Volker Krause wrote: > > On Dienstag, 15. Juni 2021 12:45:21 CEST Luigi Toscano wrote: > > > David Faure ha scritto: > > > > On dimanche 13 juin 20

Re: KF6 meeting notes 2021-06-12

2021-06-15 Thread Volker Krause
On Dienstag, 15. Juni 2021 12:45:21 CEST Luigi Toscano wrote: > David Faure ha scritto: > > On dimanche 13 juin 2021 20:32:42 CEST Luigi Toscano wrote: > >> -> we need need input about dfaure presence and try to avoid conflicts > >> with > >> Plasma BoFs > > > > I'm available Mon-Thu, but since

KF6 meeting notes 2021-06-05

2021-06-05 Thread Volker Krause
Hi all, here are the notes from today's KF6 weekly call: C++ 17 - can we use std::optional in public API? KPluginLoader has that need - we need to keep source compatibility with older KF5, so unconditional C++17 includes can be a problem during the remaining KF5 lifetime (but not for KF6) -

Re: KDE Frameworks 6 - Virtual Sprint setup

2021-02-03 Thread Volker Krause
On Freitag, 29. Januar 2021 15:57:59 CET Adam Szopa wrote: > Hello, > I've been talking with David Faure about setting up a Sprint focused on KF6 > work. Some of the topics would include: > - Reviewing the KF6 board > (https://phabricator.kde.org/project/board/310/[1]): -- Clean up > -- Tagging

Re: KDE Frameworks 6 - Virtual Sprint setup

2021-01-30 Thread Volker Krause
On Freitag, 29. Januar 2021 15:57:59 CET Adam Szopa wrote: > Hello, > I've been talking with David Faure about setting up a Sprint focused on KF6 > work. Some of the topics would include: > - Reviewing the KF6 board > (https://phabricator.kde.org/project/board/310/[1]): -- Clean up > -- Tagging

Re: KDE review for KWeatherCore

2021-01-02 Thread Volker Krause
On Samstag, 2. Januar 2021 12:44:31 CET Dominik Haumann wrote: > This is just by looking at the first two header files. > > Looking at WeatherForecast.cpp: > > double maxTemp = std::numeric_limits::min(); > double minTemp = std::numeric_limits::max(); > > Initializing the temperature to

Re: KDE review for KWeatherCore

2020-12-21 Thread Volker Krause
Having implemented the weather support for Itinerary, rebasing that onto a more comprehensive framework would indeed be welcome :) I haven't looked too deeply at the implementation or the API yet, most of the feedback below is based on things learned when implementing this for Itinerary. ##

Re: RFC: Switching to min Qt version 5.14 for KF on December 14th

2020-12-07 Thread Volker Krause
On Sonntag, 6. Dezember 2020 14:20:47 CET Friedrich W. H. Kossebau wrote: > you might have seen I asked* whether anyone knows a real world requirement > to stick with Qt 5.13 as new current minimum required Qt version for > current KF releases. So far no-one had to report a reason to support Qt >=

Re: KUserFeedback => Frameworks?

2020-10-09 Thread Volker Krause
On Freitag, 9. Oktober 2020 21:17:42 CEST Christoph Cullmann wrote: > On 2020-09-26 21:52, Christoph Cullmann wrote: > > Hi, > > > > is there any real reason why KUserFeedback is yet no official > > framework? > > > > I just stumbled over this during my try to add it as dependency for > > the

Re: Dropping the moderation by default flag

2020-07-22 Thread Volker Krause
On Tuesday, 21 July 2020 21:16:00 CEST Albert Astals Cid wrote: > Hi, this list has an unusual setting [for kde mailing lists] inherited from > kde-core-devel that is that even subscribed people get moderated, and then > the list moderator can decide to clear the moderate flag for each person >

D29747: Deprecate AbstractBarcode::minimumSize() also for the compiler

2020-06-22 Thread Volker Krause
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R280 Prison BRANCH fullydeprecateminimumsize REVISION DETAIL https://phabricator.kde.org/D29747 To: kossebau, #frameworks, svuorela, vkrause Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh,

Re: Shift for parts of the CI system to Qt 5.15

2020-06-20 Thread Volker Krause
On Saturday, 20 June 2020 08:20:18 CEST Ben Cooksley wrote: > Hi all, > > This weekend parts of our CI system shifted to using Qt 5.15, with all > FreeBSD builds now being based on Qt 5.15. We also shifted all Linux > builds of Plasma, and the latest Qt version build of Frameworks to Qt > 5.15 as

Re: New Framework Review: KDAV

2020-06-20 Thread Volker Krause
with this! Volker On Sunday, 14 June 2020 11:53:42 CEST Albert Astals Cid wrote: > El diumenge, 14 de juny de 2020, a les 10:17:01 CEST, Ben Cooksley va escriure: > > On Sun, Jun 14, 2020 at 8:03 PM Volker Krause wrote: > > > With both 20.04.2 and 5.71.0 out I think it's now ti

Re: New Framework Review: KDAV

2020-06-19 Thread Volker Krause
On Friday, 19 June 2020 01:16:20 CEST Friedrich W. H. Kossebau wrote: > Am Samstag, 4. April 2020, 16:20:21 CEST schrieb Kevin Ottens: > > Overall apidox would likely need a big pass of cleanups as well. > > I locally prepared the addition of ECMAddQch usage for KDAV tonight, and > while testing

Re: New Framework Review: KDAV

2020-06-14 Thread Volker Krause
move this in Gitlab? Thanks, Volker On Sunday, 24 May 2020 08:52:17 CEST Volker Krause wrote: > The remaining issues that didn't change ABI anymore (movable value types, > hide private methods/slots inside the private classes, etc) have long since > been addressed. > > I th

D29747: Deprecate AbstractBarcode::minimumSize() also for the compiler

2020-05-26 Thread Volker Krause
vkrause added a comment. PIM has been fully adapted meanwhile, only https://phabricator.kde.org/D29478 missing I think. REPOSITORY R280 Prison REVISION DETAIL https://phabricator.kde.org/D29747 To: kossebau, #frameworks, svuorela, vkrause Cc: kde-frameworks-devel, LeGast00n, cblack,

Re: New Framework Review: KDAV

2020-05-24 Thread Volker Krause
. * For the July release, just in time for the 20.08 dependency freeze. Opinions? Thanks, Volker On Saturday, 4 April 2020 17:32:19 CEST Volker Krause wrote: > Thanks for the review! We are cutting it close again with the 20.04 > deadline, but fortunately most of these findings aren't ABI-br

Re: KEmoticons, emoticons kcm

2020-05-23 Thread Volker Krause
On Saturday, 23 May 2020 02:49:57 CEST Aleix Pol wrote: > I was looking through some Plasma code and I saw that we have some > fairly old emoticons KCM using KF5Emoticons. > > Now while I know why this exists, it feels like it's more of a thing > of the past from when people wrote :) instead of

D29358: Implement lock-screen visibility control on Android

2020-05-23 Thread Volker Krause
vkrause closed this revision. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D29358 To: vkrause, nicolasfella Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29358: Implement lock-screen visibility control on Android

2020-05-22 Thread Volker Krause
vkrause updated this revision to Diff 83104. vkrause added a comment. Rename visibility hint. REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29358?vs=81734=83104 BRANCH pending REVISION DETAIL https://phabricator.kde.org/D29358 AFFECTED FILES

D29358: Implement lock-screen visibility control on Android

2020-05-19 Thread Volker Krause
vkrause added a comment. ping? REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D29358 To: vkrause Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29335: Implement notification grouping on Android

2020-05-19 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R289:942bddded289: Implement notification grouping on Android (authored by vkrause). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D29335?vs=81731=83063#toc REPOSITORY R289 KNotifications

D29357: Display rich text notification messages on Android

2020-05-18 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R289:c14be41192d2: Display rich text notification messages on Android (authored by vkrause). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D29357?vs=82566=83046#toc REPOSITORY R289

D27989: Add a new set of barcode size functions

2020-05-14 Thread Volker Krause
vkrause added a comment. In D27989#670416 , @kossebau wrote: > > minimumSize() becomes deprecated by this, the deprecation macros will > > follow once the current users have been adjusted. > > IMHO you should add the macros from the start,

D29357: Display rich text notification messages on Android

2020-05-11 Thread Volker Krause
vkrause retitled this revision from "Display rich text notification messages on Android (API level 24+)" to "Display rich text notification messages on Android". REPOSITORY R289 KNotifications BRANCH rich-text REVISION DETAIL https://phabricator.kde.org/D29357 To: vkrause, tfella Cc:

D29357: Display rich text notification messages on Android (API level 24+)

2020-05-11 Thread Volker Krause
vkrause updated this revision to Diff 82566. vkrause added a comment. Support API level < 24 as well. REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29357?vs=81729=82566 BRANCH rich-text REVISION DETAIL https://phabricator.kde.org/D29357

D29575: holidayregion.cpp - provide translatable strings for the German regions.

2020-05-11 Thread Volker Krause
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R175 KHolidays BRANCH master REVISION DETAIL https://phabricator.kde.org/D29575 To: winterz, vkrause Cc: ltoscano, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29274: ECMGeneratePriFile: make the pri files relocatable

2020-05-08 Thread Volker Krause
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D29274 To: dfaure, vatra, kfunk, apol, vkrause Cc: ablu, kossebau, kde-frameworks-devel, kde-buildsystem,

D29342: Implement support for notification urgency on Android

2020-05-07 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R289:9a13dd26d1de: Implement support for notification urgency on Android (authored by vkrause). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D29342?vs=81695=82227#toc REPOSITORY R289

D29415: Add holiday file for DE-BE (Germany/Berlin)

2020-05-05 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R175:c39d1eb12217: Add holiday file for DE-BE (Germany/Berlin) (authored by vkrause). REPOSITORY R175 KHolidays CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29415?vs=81905=81999 REVISION

D29415: Add holiday file for DE-BE (Germany/Berlin)

2020-05-04 Thread Volker Krause
vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY The generic DE file doesn't really work anymore since Berlin got creative in adding non-standard public holidays.

D29358: Implement lock-screen visibility control on Android

2020-05-02 Thread Volker Krause
vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY This is only the backend part, lacking a proper frontend API this is using a custom hint for now. Android knows three

D29335: Implement notification grouping on Android

2020-05-02 Thread Volker Krause
vkrause updated this revision to Diff 81731. vkrause added a comment. Replace the simple ref count with a full child id tracking. The ref count got out of sync when an existing notification is updated, using a set fixes that. REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE

D29335: Implement notification grouping on Android

2020-05-02 Thread Volker Krause
vkrause added a comment. Still not good enough, updating existing notfication messes up the refcounter, resulting still in leftover group elements. REPOSITORY R289 KNotifications BRANCH grouping REVISION DETAIL https://phabricator.kde.org/D29335 To: vkrause, nicolasfella Cc:

D29357: Display rich text notification messages on Android (API level 24+)

2020-05-02 Thread Volker Krause
vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REPOSITORY R289 KNotifications BRANCH pending REVISION DETAIL https://phabricator.kde.org/D29357 AFFECTED FILES

D29357: Display rich text notification messages on Android (API level 24+)

2020-05-02 Thread Volker Krause
vkrause added a comment. Example: F8278136: Screenshot_20200502_112835.PNG REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D29357 To: vkrause Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29335: Implement notification grouping on Android

2020-05-02 Thread Volker Krause
vkrause updated this revision to Diff 81725. vkrause added a comment. Explicitly track if notification groups are still in use. This fixes group summaries staying active when we explicitly close a notification, rather then having the user or system dismiss it. REPOSITORY R289

D29335: Implement notification grouping on Android

2020-05-02 Thread Volker Krause
vkrause added a comment. This isn't good to go yet, there are corner cases where the group summary item stays around after closing the last notification, working on fixing this. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D29335 To:

D29339: Implement updating of notifications on Android

2020-05-02 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R289:c5688295e45f: Implement updating of notifications on Android (authored by vkrause). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D29339?vs=81686=81722#toc REPOSITORY R289 KNotifications

D29323: Handle multi-line and rich-text notifications on Android

2020-05-02 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R289:9bfd98a3d3da: Handle multi-line and rich-text notifications on Android (authored by vkrause). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE

D29342: Implement support for notification urgency on Android

2020-05-01 Thread Volker Krause
vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY While the notification levels map nicely, the behavior on Android with API level 26 or higher is slightly different

D29339: Implement updating of notifications on Android

2020-05-01 Thread Volker Krause
vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D29339 AFFECTED FILES

D29335: Implement notification grouping on Android

2020-05-01 Thread Volker Krause
vkrause added inline comments. INLINE COMMENTS > nicolasfella wrote in NotifyByAndroid.java:171 > Please use > https://developer.android.com/reference/android/os/Build.VERSION_CODES > instead of hardcoding numbers That seems counter-productive to me, as the Android API documentation always

D29335: Implement notification grouping on Android

2020-05-01 Thread Volker Krause
vkrause added a comment. Collapsed: F8276057: Screenshot_20200501_161952.PNG Expanded: F8276059: Screenshot_20200501_162043.PNG REPOSITORY R289 KNotifications REVISION DETAIL

D29335: Implement notification grouping on Android

2020-05-01 Thread Volker Krause
vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY This is available starting at API level 20, which is below our minimal requirement. Grouping can be disabled by the

D29323: Handle multi-line and rich-text notifications on Android

2020-05-01 Thread Volker Krause
vkrause added a comment. F8275264: Screenshot_20200501_124105.PNG REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D29323 To: vkrause Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29323: Handle multi-line and rich-text notifications on Android

2020-05-01 Thread Volker Krause
vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY By default only a single line of the notification message is shown, for making longer messages readable we need to

D29079: android: include the architecture on the apk name

2020-04-22 Thread Volker Krause
vkrause added a comment. +1, I can't judge the impact on the subsequent pipeline though, such as the fdroid repo handling. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D29079 To: apol, #android, #frameworks Cc: vkrause, kde-frameworks-devel,

D28834: Add metadata properties to calendar

2020-04-14 Thread Volker Krause
vkrause added a comment. In D28834#648405 , @winterz wrote: > I don't know how things are done in frameworks but it seems to me that the KF5_VERSION (see top of kcalendarcore/CMakeLists.txt) needs to become 5.70.0 now This is handled

D28400: [AdvancedQueryParser] Move semantic handling of tokens to SearchStore

2020-04-07 Thread Volker Krause
vkrause added inline comments. INLINE COMMENTS > bruns wrote in searchstore.cpp:82 > Thanks for the heads-up. > > As you have noticed, the message is vague, so someone with access to one of > the affected systems should test it and submit a review. I don't have either of those here to test it

D28577: Add StatusBarExtension(KParts::Part *) overloaded constructor.

2020-04-05 Thread Volker Krause
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R306 KParts BRANCH master REVISION DETAIL https://phabricator.kde.org/D28577 To: dfaure, vkrause, aacid, cgiboudeaux, kossebau Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham,

Re: New Framework Review: KDAV

2020-04-04 Thread Volker Krause
wrote: > Hello, > > On Saturday, 9 November 2019 12:33:54 CEST Volker Krause wrote: > > during Akademy there was a request to promote KDAV from KDE PIM to > > Frameworks for use by Plasma Mobile. KDAV is a framework that implements > > the CalDav/ CardDav/GroupDav prot

D25984: Load translations

2020-03-19 Thread Volker Krause
vkrause added a comment. In D25984#589426 , @mart wrote: > ping, what's the current status of this? There's also https://phabricator.kde.org/D27595, which might address the same/a similar issue. REPOSITORY R169 Kirigami REVISION

D28030: Also expose the true minimum size to QML

2020-03-15 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R280:e0dec83dd692: Also expose the true minimum size to QML (authored by vkrause). REPOSITORY R280 Prison CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28030?vs=77578=77650 REVISION DETAIL

D27989: Add a new set of barcode size functions

2020-03-15 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R280:838f886c380f: Add a new set of barcode size functions (authored by vkrause). REPOSITORY R280 Prison CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27989?vs=77441=77647 REVISION DETAIL

D27952: Simplify minimum size handling

2020-03-14 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R280:0d64bdd22e7c: Simplify minimum size handling (authored by vkrause). REPOSITORY R280 Prison CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27952?vs=77611=77612 REVISION DETAIL

D27952: Simplify minimum size handling

2020-03-14 Thread Volker Krause
vkrause updated this revision to Diff 77611. vkrause added a comment. Rebase and bump version numbers. REPOSITORY R280 Prison CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27952?vs=77302=77611 BRANCH arcpatch-D27952 REVISION DETAIL https://phabricator.kde.org/D27952

D27909: Move barcode image scaling logic to AbstractBarcode

2020-03-14 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R280:ea1f6c1abeb0: Move barcode image scaling logic to AbstractBarcode (authored by vkrause). REPOSITORY R280 Prison CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27909?vs=77158=77610

D27730: Add API to check whether a barcode is one- or two-dimensional

2020-03-14 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R280:3d4b8780a8d5: Add API to check whether a barcode is one- or two-dimensional (authored by vkrause). REPOSITORY R280 Prison CHANGES SINCE LAST UPDATE

D27730: Add API to check whether a barcode is one- or two-dimensional

2020-03-14 Thread Volker Krause
vkrause updated this revision to Diff 77607. vkrause added a comment. Rebase and bump version number to 5.69. REPOSITORY R280 Prison CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27730?vs=77128=77607 BRANCH arcpatch-D27730 REVISION DETAIL https://phabricator.kde.org/D27730

D28030: Also expose the true minimum size to QML

2020-03-13 Thread Volker Krause
vkrause created this revision. vkrause added a reviewer: svuorela. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY Useful in case you want to implement manual scaling there, for example. REPOSITORY

D27989: Add a new set of barcode size functions

2020-03-11 Thread Volker Krause
vkrause created this revision. vkrause added a reviewer: svuorela. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY preferredSize() is an improvement over what minimumSize() used to do, with taking

D27916: Add Overpass QL highlighting

2020-03-10 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R216:fdc762d23fdc: Add Overpass QL highlighting (authored by vkrause). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27916?vs=77179=77372#toc REPOSITORY R216 Syntax Highlighting CHANGES SINCE

  1   2   3   4   5   6   7   8   9   10   >