Re: KUserFeedback => Frameworks?

2020-10-09 Thread Volker Krause
On Freitag, 9. Oktober 2020 21:17:42 CEST Christoph Cullmann wrote: > On 2020-09-26 21:52, Christoph Cullmann wrote: > > Hi, > > > > is there any real reason why KUserFeedback is yet no official > > framework? > > > > I just stumbled over this during my try to add it as dependency for > > the

Re: Dropping the moderation by default flag

2020-07-22 Thread Volker Krause
On Tuesday, 21 July 2020 21:16:00 CEST Albert Astals Cid wrote: > Hi, this list has an unusual setting [for kde mailing lists] inherited from > kde-core-devel that is that even subscribed people get moderated, and then > the list moderator can decide to clear the moderate flag for each person >

D29747: Deprecate AbstractBarcode::minimumSize() also for the compiler

2020-06-22 Thread Volker Krause
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R280 Prison BRANCH fullydeprecateminimumsize REVISION DETAIL https://phabricator.kde.org/D29747 To: kossebau, #frameworks, svuorela, vkrause Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh,

Re: Shift for parts of the CI system to Qt 5.15

2020-06-20 Thread Volker Krause
On Saturday, 20 June 2020 08:20:18 CEST Ben Cooksley wrote: > Hi all, > > This weekend parts of our CI system shifted to using Qt 5.15, with all > FreeBSD builds now being based on Qt 5.15. We also shifted all Linux > builds of Plasma, and the latest Qt version build of Frameworks to Qt > 5.15 as

Re: New Framework Review: KDAV

2020-06-20 Thread Volker Krause
with this! Volker On Sunday, 14 June 2020 11:53:42 CEST Albert Astals Cid wrote: > El diumenge, 14 de juny de 2020, a les 10:17:01 CEST, Ben Cooksley va escriure: > > On Sun, Jun 14, 2020 at 8:03 PM Volker Krause wrote: > > > With both 20.04.2 and 5.71.0 out I think it's now ti

Re: New Framework Review: KDAV

2020-06-19 Thread Volker Krause
On Friday, 19 June 2020 01:16:20 CEST Friedrich W. H. Kossebau wrote: > Am Samstag, 4. April 2020, 16:20:21 CEST schrieb Kevin Ottens: > > Overall apidox would likely need a big pass of cleanups as well. > > I locally prepared the addition of ECMAddQch usage for KDAV tonight, and > while testing

Re: New Framework Review: KDAV

2020-06-14 Thread Volker Krause
move this in Gitlab? Thanks, Volker On Sunday, 24 May 2020 08:52:17 CEST Volker Krause wrote: > The remaining issues that didn't change ABI anymore (movable value types, > hide private methods/slots inside the private classes, etc) have long since > been addressed. > > I th

D29747: Deprecate AbstractBarcode::minimumSize() also for the compiler

2020-05-26 Thread Volker Krause
vkrause added a comment. PIM has been fully adapted meanwhile, only https://phabricator.kde.org/D29478 missing I think. REPOSITORY R280 Prison REVISION DETAIL https://phabricator.kde.org/D29747 To: kossebau, #frameworks, svuorela, vkrause Cc: kde-frameworks-devel, LeGast00n, cblack,

Re: New Framework Review: KDAV

2020-05-24 Thread Volker Krause
. * For the July release, just in time for the 20.08 dependency freeze. Opinions? Thanks, Volker On Saturday, 4 April 2020 17:32:19 CEST Volker Krause wrote: > Thanks for the review! We are cutting it close again with the 20.04 > deadline, but fortunately most of these findings aren't ABI-br

Re: KEmoticons, emoticons kcm

2020-05-23 Thread Volker Krause
On Saturday, 23 May 2020 02:49:57 CEST Aleix Pol wrote: > I was looking through some Plasma code and I saw that we have some > fairly old emoticons KCM using KF5Emoticons. > > Now while I know why this exists, it feels like it's more of a thing > of the past from when people wrote :) instead of

D29358: Implement lock-screen visibility control on Android

2020-05-23 Thread Volker Krause
vkrause closed this revision. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D29358 To: vkrause, nicolasfella Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29358: Implement lock-screen visibility control on Android

2020-05-22 Thread Volker Krause
vkrause updated this revision to Diff 83104. vkrause added a comment. Rename visibility hint. REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29358?vs=81734=83104 BRANCH pending REVISION DETAIL https://phabricator.kde.org/D29358 AFFECTED FILES

D29358: Implement lock-screen visibility control on Android

2020-05-19 Thread Volker Krause
vkrause added a comment. ping? REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D29358 To: vkrause Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29335: Implement notification grouping on Android

2020-05-19 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R289:942bddded289: Implement notification grouping on Android (authored by vkrause). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D29335?vs=81731=83063#toc REPOSITORY R289 KNotifications

D29357: Display rich text notification messages on Android

2020-05-18 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R289:c14be41192d2: Display rich text notification messages on Android (authored by vkrause). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D29357?vs=82566=83046#toc REPOSITORY R289

D27989: Add a new set of barcode size functions

2020-05-14 Thread Volker Krause
vkrause added a comment. In D27989#670416 , @kossebau wrote: > > minimumSize() becomes deprecated by this, the deprecation macros will > > follow once the current users have been adjusted. > > IMHO you should add the macros from the start,

D29357: Display rich text notification messages on Android

2020-05-11 Thread Volker Krause
vkrause retitled this revision from "Display rich text notification messages on Android (API level 24+)" to "Display rich text notification messages on Android". REPOSITORY R289 KNotifications BRANCH rich-text REVISION DETAIL https://phabricator.kde.org/D29357 To: vkrause, tfella Cc:

D29357: Display rich text notification messages on Android (API level 24+)

2020-05-11 Thread Volker Krause
vkrause updated this revision to Diff 82566. vkrause added a comment. Support API level < 24 as well. REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29357?vs=81729=82566 BRANCH rich-text REVISION DETAIL https://phabricator.kde.org/D29357

D29575: holidayregion.cpp - provide translatable strings for the German regions.

2020-05-11 Thread Volker Krause
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R175 KHolidays BRANCH master REVISION DETAIL https://phabricator.kde.org/D29575 To: winterz, vkrause Cc: ltoscano, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29274: ECMGeneratePriFile: make the pri files relocatable

2020-05-08 Thread Volker Krause
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D29274 To: dfaure, vatra, kfunk, apol, vkrause Cc: ablu, kossebau, kde-frameworks-devel, kde-buildsystem,

D29342: Implement support for notification urgency on Android

2020-05-07 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R289:9a13dd26d1de: Implement support for notification urgency on Android (authored by vkrause). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D29342?vs=81695=82227#toc REPOSITORY R289

D29415: Add holiday file for DE-BE (Germany/Berlin)

2020-05-05 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R175:c39d1eb12217: Add holiday file for DE-BE (Germany/Berlin) (authored by vkrause). REPOSITORY R175 KHolidays CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29415?vs=81905=81999 REVISION

D29415: Add holiday file for DE-BE (Germany/Berlin)

2020-05-04 Thread Volker Krause
vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY The generic DE file doesn't really work anymore since Berlin got creative in adding non-standard public holidays.

D29358: Implement lock-screen visibility control on Android

2020-05-02 Thread Volker Krause
vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY This is only the backend part, lacking a proper frontend API this is using a custom hint for now. Android knows three

D29335: Implement notification grouping on Android

2020-05-02 Thread Volker Krause
vkrause updated this revision to Diff 81731. vkrause added a comment. Replace the simple ref count with a full child id tracking. The ref count got out of sync when an existing notification is updated, using a set fixes that. REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE

D29335: Implement notification grouping on Android

2020-05-02 Thread Volker Krause
vkrause added a comment. Still not good enough, updating existing notfication messes up the refcounter, resulting still in leftover group elements. REPOSITORY R289 KNotifications BRANCH grouping REVISION DETAIL https://phabricator.kde.org/D29335 To: vkrause, nicolasfella Cc:

D29357: Display rich text notification messages on Android (API level 24+)

2020-05-02 Thread Volker Krause
vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REPOSITORY R289 KNotifications BRANCH pending REVISION DETAIL https://phabricator.kde.org/D29357 AFFECTED FILES

D29357: Display rich text notification messages on Android (API level 24+)

2020-05-02 Thread Volker Krause
vkrause added a comment. Example: F8278136: Screenshot_20200502_112835.PNG REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D29357 To: vkrause Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29335: Implement notification grouping on Android

2020-05-02 Thread Volker Krause
vkrause updated this revision to Diff 81725. vkrause added a comment. Explicitly track if notification groups are still in use. This fixes group summaries staying active when we explicitly close a notification, rather then having the user or system dismiss it. REPOSITORY R289

D29335: Implement notification grouping on Android

2020-05-02 Thread Volker Krause
vkrause added a comment. This isn't good to go yet, there are corner cases where the group summary item stays around after closing the last notification, working on fixing this. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D29335 To:

D29339: Implement updating of notifications on Android

2020-05-02 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R289:c5688295e45f: Implement updating of notifications on Android (authored by vkrause). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D29339?vs=81686=81722#toc REPOSITORY R289 KNotifications

D29323: Handle multi-line and rich-text notifications on Android

2020-05-02 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R289:9bfd98a3d3da: Handle multi-line and rich-text notifications on Android (authored by vkrause). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE

D29342: Implement support for notification urgency on Android

2020-05-01 Thread Volker Krause
vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY While the notification levels map nicely, the behavior on Android with API level 26 or higher is slightly different

D29339: Implement updating of notifications on Android

2020-05-01 Thread Volker Krause
vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D29339 AFFECTED FILES

D29335: Implement notification grouping on Android

2020-05-01 Thread Volker Krause
vkrause added inline comments. INLINE COMMENTS > nicolasfella wrote in NotifyByAndroid.java:171 > Please use > https://developer.android.com/reference/android/os/Build.VERSION_CODES > instead of hardcoding numbers That seems counter-productive to me, as the Android API documentation always

D29335: Implement notification grouping on Android

2020-05-01 Thread Volker Krause
vkrause added a comment. Collapsed: F8276057: Screenshot_20200501_161952.PNG Expanded: F8276059: Screenshot_20200501_162043.PNG REPOSITORY R289 KNotifications REVISION DETAIL

D29335: Implement notification grouping on Android

2020-05-01 Thread Volker Krause
vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY This is available starting at API level 20, which is below our minimal requirement. Grouping can be disabled by the

D29323: Handle multi-line and rich-text notifications on Android

2020-05-01 Thread Volker Krause
vkrause added a comment. F8275264: Screenshot_20200501_124105.PNG REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D29323 To: vkrause Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29323: Handle multi-line and rich-text notifications on Android

2020-05-01 Thread Volker Krause
vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY By default only a single line of the notification message is shown, for making longer messages readable we need to

D29079: android: include the architecture on the apk name

2020-04-22 Thread Volker Krause
vkrause added a comment. +1, I can't judge the impact on the subsequent pipeline though, such as the fdroid repo handling. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D29079 To: apol, #android, #frameworks Cc: vkrause, kde-frameworks-devel,

D28834: Add metadata properties to calendar

2020-04-14 Thread Volker Krause
vkrause added a comment. In D28834#648405 , @winterz wrote: > I don't know how things are done in frameworks but it seems to me that the KF5_VERSION (see top of kcalendarcore/CMakeLists.txt) needs to become 5.70.0 now This is handled

D28400: [AdvancedQueryParser] Move semantic handling of tokens to SearchStore

2020-04-07 Thread Volker Krause
vkrause added inline comments. INLINE COMMENTS > bruns wrote in searchstore.cpp:82 > Thanks for the heads-up. > > As you have noticed, the message is vague, so someone with access to one of > the affected systems should test it and submit a review. I don't have either of those here to test it

D28577: Add StatusBarExtension(KParts::Part *) overloaded constructor.

2020-04-05 Thread Volker Krause
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R306 KParts BRANCH master REVISION DETAIL https://phabricator.kde.org/D28577 To: dfaure, vkrause, aacid, cgiboudeaux, kossebau Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham,

Re: New Framework Review: KDAV

2020-04-04 Thread Volker Krause
wrote: > Hello, > > On Saturday, 9 November 2019 12:33:54 CEST Volker Krause wrote: > > during Akademy there was a request to promote KDAV from KDE PIM to > > Frameworks for use by Plasma Mobile. KDAV is a framework that implements > > the CalDav/ CardDav/GroupDav prot

D25984: Load translations

2020-03-19 Thread Volker Krause
vkrause added a comment. In D25984#589426 , @mart wrote: > ping, what's the current status of this? There's also https://phabricator.kde.org/D27595, which might address the same/a similar issue. REPOSITORY R169 Kirigami REVISION

D28030: Also expose the true minimum size to QML

2020-03-15 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R280:e0dec83dd692: Also expose the true minimum size to QML (authored by vkrause). REPOSITORY R280 Prison CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28030?vs=77578=77650 REVISION DETAIL

D27989: Add a new set of barcode size functions

2020-03-15 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R280:838f886c380f: Add a new set of barcode size functions (authored by vkrause). REPOSITORY R280 Prison CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27989?vs=77441=77647 REVISION DETAIL

D27952: Simplify minimum size handling

2020-03-14 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R280:0d64bdd22e7c: Simplify minimum size handling (authored by vkrause). REPOSITORY R280 Prison CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27952?vs=77611=77612 REVISION DETAIL

D27952: Simplify minimum size handling

2020-03-14 Thread Volker Krause
vkrause updated this revision to Diff 77611. vkrause added a comment. Rebase and bump version numbers. REPOSITORY R280 Prison CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27952?vs=77302=77611 BRANCH arcpatch-D27952 REVISION DETAIL https://phabricator.kde.org/D27952

D27909: Move barcode image scaling logic to AbstractBarcode

2020-03-14 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R280:ea1f6c1abeb0: Move barcode image scaling logic to AbstractBarcode (authored by vkrause). REPOSITORY R280 Prison CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27909?vs=77158=77610

D27730: Add API to check whether a barcode is one- or two-dimensional

2020-03-14 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R280:3d4b8780a8d5: Add API to check whether a barcode is one- or two-dimensional (authored by vkrause). REPOSITORY R280 Prison CHANGES SINCE LAST UPDATE

D27730: Add API to check whether a barcode is one- or two-dimensional

2020-03-14 Thread Volker Krause
vkrause updated this revision to Diff 77607. vkrause added a comment. Rebase and bump version number to 5.69. REPOSITORY R280 Prison CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27730?vs=77128=77607 BRANCH arcpatch-D27730 REVISION DETAIL https://phabricator.kde.org/D27730

D28030: Also expose the true minimum size to QML

2020-03-13 Thread Volker Krause
vkrause created this revision. vkrause added a reviewer: svuorela. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY Useful in case you want to implement manual scaling there, for example. REPOSITORY

D27989: Add a new set of barcode size functions

2020-03-11 Thread Volker Krause
vkrause created this revision. vkrause added a reviewer: svuorela. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY preferredSize() is an improvement over what minimumSize() used to do, with taking

D27916: Add Overpass QL highlighting

2020-03-10 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R216:fdc762d23fdc: Add Overpass QL highlighting (authored by vkrause). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27916?vs=77179=77372#toc REPOSITORY R216 Syntax Highlighting CHANGES SINCE

D27952: Simplify minimum size handling

2020-03-09 Thread Volker Krause
vkrause added a comment. The deprecation version is off by one, but that will be fixed when rebasing the entire patch set on 5.69 once 5.68 is released. REPOSITORY R280 Prison REVISION DETAIL https://phabricator.kde.org/D27952 To: vkrause, svuorela Cc: kde-frameworks-devel, LeGast00n,

D27952: Simplify minimum size handling

2020-03-09 Thread Volker Krause
vkrause created this revision. vkrause added a reviewer: svuorela. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY We don't need to track the minimum size separately anymore, so avoid this getting

D27916: Add Overpass QL highlighting

2020-03-07 Thread Volker Krause
vkrause updated this revision to Diff 77179. vkrause added a comment. Highlight the {{bbox}} Overpass Turbo placeholder. REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27916?vs=77177=77179 BRANCH master REVISION DETAIL

D27916: Add Overpass QL highlighting

2020-03-07 Thread Volker Krause
vkrause created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. vkrause requested review of this revision. REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde.org/D27916 AFFECTED

D27909: Move barcode image scaling logic to AbstractBarcode

2020-03-07 Thread Volker Krause
vkrause created this revision. vkrause added a reviewer: svuorela. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY This removes any kind of scaling from the specific implementations, they now

D27730: Add API to check whether a barcode is one- or two-dimensional

2020-03-06 Thread Volker Krause
vkrause updated this revision to Diff 77128. vkrause added a comment. Alternative implementation for the barcode dimension API. REPOSITORY R280 Prison CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27730?vs=76661=77128 BRANCH pending REVISION DETAIL

D27727: Remove empty/unused private classes on internal types

2020-03-04 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R280:10054afd8243: Remove empty/unused private classes on internal types (authored by vkrause). REPOSITORY R280 Prison CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27727?vs=76657=76965

D27730: Add API to check whether a barcode is one- or two-dimensional

2020-03-04 Thread Volker Krause
vkrause added a reviewer: svuorela. REPOSITORY R280 Prison REVISION DETAIL https://phabricator.kde.org/D27730 To: vkrause, svuorela Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27727: Remove empty/unused private classes on internal types

2020-03-04 Thread Volker Krause
vkrause added a reviewer: svuorela. REPOSITORY R280 Prison REVISION DETAIL https://phabricator.kde.org/D27727 To: vkrause, svuorela Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D26749: Support NDK r20 and Qt 5.14

2020-03-03 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R240:c9ebd3917e59: Support NDK r20 and Qt 5.14 (authored by vkrause). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26749?vs=73822=76876 REVISION DETAIL

D26749: Support NDK r20 and Qt 5.14

2020-03-02 Thread Volker Krause
vkrause retitled this revision from "WIP: Support NDK r20 and Qt 5.14" to "Support NDK r20 and Qt 5.14". REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D26749 To: vkrause, apol Cc: flherne, apol, kde-frameworks-devel, kde-buildsystem,

D26749: WIP: Support NDK r20 and Qt 5.14

2020-03-01 Thread Volker Krause
vkrause added a comment. In D26749#620142 , @apol wrote: > Seems ready to land to me. It does seem to break poppler in the old setup here, not sure yet why though. If we land the docker change as well that is probably acceptable though.

D27730: Add API to check whether a barcode is one- or two-dimensional

2020-02-28 Thread Volker Krause
vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY This matters for user code doing some more advanced layouting or size computations, especially once we remove the

D27727: Remove empty/unused private classes on internal types

2020-02-28 Thread Volker Krause
vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY This avoids unnecessary allocations. This also un-exports QRCodeBarcode, which is declared in a non-installed header

D27607: Deprecate KDBusConnectionPool

2020-02-28 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R271:417607275368: Deprecate KDBusConnectionPool (authored by vkrause). REPOSITORY R271 KDBusAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27607?vs=76316=76652 REVISION DETAIL

D27607: Deprecate KDBusConnectionPool

2020-02-28 Thread Volker Krause
vkrause added a comment. ping? REPOSITORY R271 KDBusAddons REVISION DETAIL https://phabricator.kde.org/D27607 To: vkrause Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D26749: WIP: Support NDK r20 and Qt 5.14

2020-02-26 Thread Volker Krause
vkrause added inline comments. INLINE COMMENTS > apol wrote in Android.cmake:173 > I did some testing and for me it works for arm64 but not for arm32. I actually didn't test 64bit ARM here, only armv7 and x86, both work. What does break for you there? REPOSITORY R240 Extra CMake Modules

D27596: Load QM files from assets: URLs on Android

2020-02-26 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R240:040504da64aa: Load QM files from assets: URLs on Android (authored by vkrause). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27596?vs=76212=76476

D27596: Load QM files from assets: URLs on Android

2020-02-24 Thread Volker Krause
vkrause added a comment. In D27596#616554 , @apol wrote: > Don't we need an if Qt 5.13 elseif Qt 5.14? > > In other Qt versions it won't be in the assets... Are you sure about this? I had tested this on my Qt 5.13 setup and the files

D27607: Deprecate KDBusConnectionPool

2020-02-24 Thread Volker Krause
vkrause updated this revision to Diff 76316. vkrause added a comment. Set EXCLUDE_DEPRECATED_BEFORE_AND_AT. REPOSITORY R271 KDBusAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27607?vs=76241=76316 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27607

D27594: Remove unused KDBusConnectionPool include

2020-02-24 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R241:faace55f0bea: Remove unused KDBusConnectionPool include (authored by vkrause). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27594?vs=76207=76315 REVISION DETAIL

D27607: Deprecate KDBusConnectionPool

2020-02-23 Thread Volker Krause
vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY As per T12722 this is no longer needed, QDBusConnection now behaves correctly

D27596: Load QM files from assets: URLs on Android

2020-02-23 Thread Volker Krause
vkrause added a task: T12520: Qt 5.14. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D27596 To: vkrause Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, GB_2, bencreasy, michaelh, ngraham, bruns

D27596: Load QM files from assets: URLs on Android

2020-02-23 Thread Volker Krause
vkrause created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY This works with both the old and the new way of Qt's asset deployment, ie. with Qt 5.13

D27594: Remove unused KDBusConnectionPool include

2020-02-23 Thread Volker Krause
vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY KDBusConnectionPool is about to be deprecated. REPOSITORY R241 KIO BRANCH master REVISION DETAIL

D27550: Support Qt 5.14 on Android

2020-02-22 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R249:91c5e2ff604e: Support Qt 5.14 on Android (authored by vkrause). REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27550?vs=76160=76161 REVISION DETAIL

D27550: Support Qt 5.14 on Android

2020-02-22 Thread Volker Krause
vkrause updated this revision to Diff 76160. vkrause added a comment. Improve compile-time conditional to only build the new code with Qt >= 5.14. REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27550?vs=76117=76160 BRANCH master REVISION DETAIL

D27550: Support Qt 5.14 on Android

2020-02-21 Thread Volker Krause
vkrause added a task: T12520: Qt 5.14. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D27550 To: vkrause Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27550: Support Qt 5.14 on Android

2020-02-21 Thread Volker Krause
vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY With Qt 5.14 asset files are no longer extracted into the filesystem, they are only available via assert: or qrc:

Re: Banning QNetworkAccessManager

2020-02-20 Thread Volker Krause
On Wednesday, 19 February 2020 10:04:11 CET Ben Cooksley wrote: > On Wed, Feb 19, 2020 at 9:30 PM Volker Krause wrote: > > On Wednesday, 19 February 2020 08:05:01 CET Ben Cooksley wrote: > > > On Mon, Feb 3, 2020 at 7:42 AM Volker Krause wrote: > > > > I agree on

Re: Banning QNetworkAccessManager

2020-02-19 Thread Volker Krause
On Wednesday, 19 February 2020 08:05:01 CET Ben Cooksley wrote: > On Mon, Feb 3, 2020 at 7:42 AM Volker Krause wrote: > > I agree on the problem of QNAM's default, see also > > https://conf.kde.org/en/ > > akademy2019/public/events/135 on that subject. > > > > O

Re: New Framework Review: KDAV

2020-02-16 Thread Volker Krause
On Saturday, 15 February 2020 11:42:57 CET Andreas Cord-Landwehr wrote: > Hi, sorry for this very late mail, missed the call for reviews... > > Would it be possible to do some license clarifications before moving kdav > into the frameworks section? > > In mostly all files it is not clear if the

Re: New Framework Review: KDAV

2020-02-15 Thread Volker Krause
On Saturday, 9 November 2019 12:33:54 CET Volker Krause wrote: > Hi, > > during Akademy there was a request to promote KDAV from KDE PIM to > Frameworks for use by Plasma Mobile. KDAV is a framework that implements > the CalDav/ CardDav/GroupDav protocol on top of KIO's WebDav supp

D27239: [android] Emit defaultActivated when tapping the notification

2020-02-08 Thread Volker Krause
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH defa REVISION DETAIL https://phabricator.kde.org/D27239 To: nicolasfella, #frameworks, vkrause Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham,

D27187: update travel-family icons

2020-02-07 Thread Volker Krause
vkrause added a comment. Awesome work indeed, thanks! I've integrated that in the app, now trying to find all remaining uses of the old one elsewhere. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27187 To: mbruchert, #vdg, ndavis Cc: vkrause, ngraham,

D26749: WIP: Support NDK r20 and Qt 5.14

2020-02-05 Thread Volker Krause
vkrause added a comment. Excellent news! Could you post your Kirigami patch somewhere maybe? Makes this easier to test here :) For icons we probably need a similar adjustment, I bet they got affected by the same Qt change. Same for translations I think, in ki18n. REPOSITORY R240

Re: Banning QNetworkAccessManager

2020-02-03 Thread Volker Krause
On Monday, 3 February 2020 10:49:10 CET David Edmundson wrote: > I updated: > > https://community.kde.org/Policies/API_to_Avoid > > Which had no mention of this. Thanks for taking care of this! I'd propose a slightly different approach than the per-request all-or-nothing attribute mentioned

Re: Banning QNetworkAccessManager

2020-02-02 Thread Volker Krause
I agree on the problem of QNAM's default, see also https://conf.kde.org/en/ akademy2019/public/events/135 on that subject. On Saturday, 1 February 2020 23:24:14 CET Ben Cooksley wrote: [...] > Prior to now, i've taken the approach of advertising that > QNetworkAccessManager is broken and needs a

D26749: WIP: Support NDK r20 and Qt 5.14

2020-01-20 Thread Volker Krause
vkrause added inline comments. INLINE COMMENTS > apol wrote in Android.cmake:173 > Why's this better? Or how is it different? It's "better" in the way that it actually works with NDK r20, while CMake 3.16 failed to even pass the basic compiler checks. For a toolchain file shipped with a

D26723: KCONFIG_ADD_KCFG_FILES: regenerate also on new version of kconfig_compiler

2020-01-19 Thread Volker Krause
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig BRANCH dependonkconfigcompiler REVISION DETAIL https://phabricator.kde.org/D26723 To: kossebau, #frameworks, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D26749: WIP: Support NDK r20 and Qt 5.14

2020-01-18 Thread Volker Krause
vkrause retitled this revision from "Support NDK r20 and Qt 5.14" to "WIP: Support NDK r20 and Qt 5.14". vkrause edited the test plan for this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D26749 To: vkrause Cc: kde-frameworks-devel,

D26749: WIP: Support NDK r20 and Qt 5.14

2020-01-18 Thread Volker Krause
vkrause added a task: T12520: Qt 5.14. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D26749 To: vkrause Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

D26749: Support NDK r20 and Qt 5.14

2020-01-18 Thread Volker Krause
vkrause created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY This changes from using the toolchain file provided by CMake to using the one provided

D26713: Adapt to Qt 5.14 Android changes

2020-01-18 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R289:41b270f06f6e: Adapt to Qt 5.14 Android changes (authored by vkrause). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26713?vs=73726=73821 REVISION DETAIL

D26713: Adapt to Qt 5.14 Android changes

2020-01-16 Thread Volker Krause
vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY - Library names now have the ABI as a suffix, dependency files need to follow that. - The Gradle version shipped

  1   2   3   4   5   6   7   8   9   10   >