D25236: Remove the last traces of KSslError from TCPSlaveBase

2019-11-10 Thread Volker Krause
vkrause added a task: T11620: Port from KSslError to QSslError. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25236 To: vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24980: Port ssl_cert_errors meta data from KSslError to QSslError

2019-11-10 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R241:d074873f4703: Port ssl_cert_errors meta data from KSslError to QSslError (authored by vkrause). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24980?vs=69534=69536

D25237: Deprecated KTcpSocket and KSsl* classes

2019-11-10 Thread Volker Krause
vkrause added a task: T11544: Remove KTcpSocket. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25237 To: vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25237: Deprecated KTcpSocket and KSsl* classes

2019-11-10 Thread Volker Krause
vkrause added a task: T11620: Port from KSslError to QSslError. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25237 To: vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24980: Port ssl_cert_errors meta data from KSslError to QSslError

2019-11-10 Thread Volker Krause
vkrause updated this revision to Diff 69534. vkrause added a comment. bump the right version numbers, sorry REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24980?vs=69531=69534 BRANCH pending REVISION DETAIL https://phabricator.kde.org/D24980 AFFECTED

D24980: Port ssl_cert_errors meta data from KSslError to QSslError

2019-11-10 Thread Volker Krause
vkrause updated this revision to Diff 69531. vkrause added a comment. bump deprecation version REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24980?vs=69526=69531 BRANCH pending REVISION DETAIL https://phabricator.kde.org/D24980 AFFECTED FILES

D25237: Deprecated KTcpSocket and KSsl* classes

2019-11-10 Thread Volker Krause
vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY We have ported usage of those to their Qt equivalents now, so what remains here is just the removal of all this with

D25234: Deprecate KTcpSocket overload of KSslErrorUiData ctor

2019-11-10 Thread Volker Krause
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH dpe REVISION DETAIL https://phabricator.kde.org/D25234 To: nicolasfella, #frameworks, vkrause Cc: vkrause, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25236: Remove the last traces of KSslError from TCPSlaveBase

2019-11-10 Thread Volker Krause
vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REPOSITORY R241 KIO BRANCH next REVISION DETAIL https://phabricator.kde.org/D25236 AFFECTED FILES src/core/tcpslavebase.cpp

D24980: Port ssl_cert_errors meta data from KSslError to QSslError

2019-11-10 Thread Volker Krause
vkrause updated this revision to Diff 69526. vkrause added a comment. rebase to latest master REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24980?vs=69514=69526 BRANCH next REVISION DETAIL https://phabricator.kde.org/D24980 AFFECTED FILES

D25234: [WIP] Deprecate KTcpSocket overload of KSslErrorUiData ctor

2019-11-10 Thread Volker Krause
vkrause added a comment. I suspect src/core/CMakeLists.txt:139 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25234 To: nicolasfella, #frameworks Cc: vkrause, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24980: Port ssl_cert_errors meta data from KSslError to QSslError

2019-11-10 Thread Volker Krause
vkrause updated this revision to Diff 69514. vkrause added a comment. add comment requested during review REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24980?vs=68817=69514 BRANCH next REVISION DETAIL https://phabricator.kde.org/D24980 AFFECTED FILES

D24928: [TcpSlaveBase] port from KTcpSocket (deprecated) to QSslSocket

2019-11-10 Thread Volker Krause
vkrause accepted this revision. vkrause added a comment. This revision is now accepted and ready to land. Let's get this in now that 5.64 is out. REPOSITORY R241 KIO BRANCH ahmad/tcpslavebase (branched from master) REVISION DETAIL https://phabricator.kde.org/D24928 To: ahmadsamir,

D24873: [http kio slave] use QSslSocket instead of KTcpSocket (deprecated)

2019-11-10 Thread Volker Krause
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH ahmad/kio_http-ktcpsocket (branched from master) REVISION DETAIL https://phabricator.kde.org/D24873 To: ahmadsamir, dfaure, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2,

Re: New Framework Review: KDAV

2019-11-09 Thread Volker Krause
On Saturday, 9 November 2019 18:45:17 CET Christoph Feck wrote: > Hi Volker, > > On 11/09/19 12:33, Volker Krause wrote: > > during Akademy there was a request to promote KDAV from KDE PIM to > > Frameworks for use by Plasma Mobile. KDAV is a framework that implements &g

New Framework Review: KDAV

2019-11-09 Thread Volker Krause
Hi, during Akademy there was a request to promote KDAV from KDE PIM to Frameworks for use by Plasma Mobile. KDAV is a framework that implements the CalDav/ CardDav/GroupDav protocol on top of KIO's WebDav support. It would be classified as a functional tier 3 framework. So far we have fixed a

D24980: Port ssl_cert_errors meta data from KSslError to QSslError

2019-11-09 Thread Volker Krause
vkrause added inline comments. INLINE COMMENTS > ahmadsamir wrote in jobuidelegate.cpp:365 > Nitpick, wouldn't QLatin1String be better here? > > c.f. Marc Mutz's talk about QStringLiteral and QLatin1String: > https://youtu.be/Ov7s0GgBbOQ?t=2806 sslMetaData is a QMap, ie. value() has no

D25210: Prepare KConfigSkeletonItem to allow inheriting its private class

2019-11-08 Thread Volker Krause
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D25210 To: ervin, #frameworks, dfaure, davidedmundson, bport, crossi, vkrause Cc: vkrause, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D25209: Register KKeySequenceWidget to KConfigDialogManager

2019-11-08 Thread Volker Krause
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25209 To: ervin, #frameworks, dfaure, davidedmundson, bport, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D25210: Prepare KConfigSkeletonItem to allow inheriting its private class

2019-11-08 Thread Volker Krause
vkrause added a comment. Ok as such, but I think KConfigSkeletonItemPrivate would need a virtual dtor for this to actually work safely when used by a sub-class? REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D25210 To: ervin, #frameworks, dfaure, davidedmundson,

D25194: Use modern for

2019-11-07 Thread Volker Krause
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D25194 To: aacid, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24980: Port ssl_cert_errors meta data from KSslError to QSslError

2019-11-07 Thread Volker Krause
vkrause added a comment. anyone? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24980 To: vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25122: embedd trigrams.map into shared library

2019-11-04 Thread Volker Krause
vkrause added a comment. In D25122#558385 , @cullmann wrote: > I re-scheduled the build, seems to work for me now. > > @vkrause : have you some solution to run the trigrams stuff for cross compiles, too? D25143

D25143: Basic cross-compiling support for parsetrigrams

2019-11-04 Thread Volker Krause
vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY Works with or without KF5_HOST_TOOLING set. Not particularly elegant, but before spending more time on this I think

D25122: embedd trigrams.map into shared library

2019-11-03 Thread Volker Krause
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R246 Sonnet BRANCH master REVISION DETAIL https://phabricator.kde.org/D25122 To: cullmann, dfaure, vonreth, #frameworks, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24980: Port ssl_cert_errors meta data from KSslError to QSslError

2019-11-01 Thread Volker Krause
vkrause added a comment. ping? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24980 To: vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24961: Port to the QSslError variant of KSslInfoDialog

2019-10-30 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R241:4c2cd442a001: Port to the QSslError variant of KSslInfoDialog (authored by vkrause). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24961?vs=68781=69074 REVISION

D24931: Port KSSLD internals from KSslError to QSslError

2019-10-30 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R241:62af525910d4: Port KSSLD internals from KSslError to QSslError (authored by vkrause). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24931?vs=68709=69073 REVISION

D24742: Make non-ignorable SSL errors explicit

2019-10-30 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R241:8dc567852b26: Make non-ignorable SSL errors explicit (authored by vkrause). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24742?vs=68289=69071 REVISION DETAIL

D24960: Remove call to no longer needed KIconTheme::assignIconsToContextMenu

2019-10-30 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R310:47f24c83759d: Remove call to no longer needed KIconTheme::assignIconsToContextMenu (authored by vkrause). REPOSITORY R310 KTextWidgets CHANGES SINCE LAST UPDATE

Re: KF6 Sprint

2019-10-30 Thread Volker Krause
CET Volker Krause wrote: > Hi, > > as you might have seen in David's summary of the KF6 BoF at Akademy > (https:// > mail.kde.org/pipermail/kde-frameworks-devel/2019-September/093298.html), > there's the idea to have a KF6 sprint, along the lines of the KF5 sprint we > had in R

D24742: Make non-ignorable SSL errors explicit

2019-10-29 Thread Volker Krause
vkrause added a comment. Anyone? This blocks the subsequent SSL error patches. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24742 To: vkrause, #frameworks Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24742: Make non-ignorable SSL errors explicit

2019-10-29 Thread Volker Krause
vkrause added a reviewer: Frameworks. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24742 To: vkrause, #frameworks Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24892: Fix usage of the new deprecation macros for assignIconsToContextMenu

2019-10-28 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R302:3ff850df6b48: Fix usage of the new deprecation macros for assignIconsToContextMenu (authored by vkrause). REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE

D24928: [TcpSlaveBase] port from KTcpSocket (deprecated) to QSslSocket

2019-10-27 Thread Volker Krause
vkrause added a comment. In D24928#554720 , @ahmadsamir wrote: > So, we ditch digestMethod but keep the rest? ecryptionMethod/authenticationMethod/keyExchangeMethod can be deduced from the name() sometimes, but some others, not so obvious:

D24980: Port ssl_cert_errors meta data from KSslError to QSslError

2019-10-27 Thread Volker Krause
vkrause added a task: T11620: Port from KSslError to QSslError. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24980 To: vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24980: Port ssl_cert_errors meta data from KSslError to QSslError

2019-10-27 Thread Volker Krause
vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY The TCPSlaveBase side of this can be fully ported to QSslError once D24928 is

D24928: [TcpSlaveBase] port from KTcpSocket (deprecated) to QSslSocket

2019-10-27 Thread Volker Krause
vkrause added a comment. In D24928#554514 , @ahmadsamir wrote: > In D24928#553952 , @vkrause wrote: > > > The cipher naming stuff looks very fishy though, that's not due to your changes though but

D24968: Port away from KF5 deprecated API: use setWindowIcon

2019-10-26 Thread Volker Krause
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R311 KWallet BRANCH master REVISION DETAIL https://phabricator.kde.org/D24968 To: dfaure, vkrause, ngraham Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24931: Port KSSLD internals from KSslError to QSslError

2019-10-26 Thread Volker Krause
vkrause added a task: T11620: Port from KSslError to QSslError. REPOSITORY R241 KIO BRANCH next REVISION DETAIL https://phabricator.kde.org/D24931 To: vkrause, aacid Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24961: Port to the QSslError variant of KSslInfoDialog

2019-10-26 Thread Volker Krause
vkrause added a task: T11620: Port from KSslError to QSslError. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24961 To: vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24961: Port to the QSslError variant of KSslInfoDialog

2019-10-26 Thread Volker Krause
vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REPOSITORY R241 KIO BRANCH next REVISION DETAIL https://phabricator.kde.org/D24961 AFFECTED FILES src/widgets/sslui.cpp To:

D24892: Fix usage of the new deprecation macros for assignIconsToContextMenu

2019-10-26 Thread Volker Krause
vkrause added a comment. In D24892#554048 , @kossebau wrote: > In D24892#553597 , @vkrause wrote: > > > In D24892#552838 , @kossebau wrote: > > > > >

D24892: Fix usage of the new deprecation macros for assignIconsToContextMenu

2019-10-26 Thread Volker Krause
vkrause added a task: T11865: Deprecate KIconTheme::assignIconsToContextMenu. REPOSITORY R302 KIconThemes BRANCH master REVISION DETAIL https://phabricator.kde.org/D24892 To: vkrause, kossebau Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24960: Remove call to no longer needed KIconTheme::assignIconsToContextMenu

2019-10-26 Thread Volker Krause
vkrause added a task: T11865: Deprecate KIconTheme::assignIconsToContextMenu. REPOSITORY R310 KTextWidgets REVISION DETAIL https://phabricator.kde.org/D24960 To: vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24960: Remove call to no longer needed KIconTheme::assignIconsToContextMenu

2019-10-26 Thread Volker Krause
vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY Qt does set icons itself nowadays, so assignIconToContextMenu got deprecated. REPOSITORY R310 KTextWidgets BRANCH

D24928: [TcpSlaveBase] port from KTcpSocket (deprecated) to QSslSocket

2019-10-25 Thread Volker Krause
vkrause added a comment. In general I think this looks very good already! The cipher naming stuff looks very fishy though, that's not due to your changes though but coming from old KSslCipher code. I'm wondering where the ssl_cipher meta data is being consumed? If this is purely used for

D24742: Make non-ignorable SSL errors explicit

2019-10-25 Thread Volker Krause
vkrause added a comment. ping? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24742 To: vkrause Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24931: Port KSSLD internals from KSslError to QSslError

2019-10-25 Thread Volker Krause
vkrause retitled this revision from "Port KSSD internals from KSslError to QSslError" to "Port KSSLD internals from KSslError to QSslError". REPOSITORY R241 KIO BRANCH next REVISION DETAIL https://phabricator.kde.org/D24931 To: vkrause, aacid Cc: kde-frameworks-devel, LeGast00n, GB_2,

D24884: I18N_NOOP2 was deprecated but we can't replace by I18NC_NOOP as it expends it as 2 elements (context + text)

2019-10-25 Thread Volker Krause
vkrause added a comment. In D24884#552701 , @vkrause wrote: > Seeing things like https://lxr.kde.org/source/frameworks/ki18n/src/kuitmarkup.cpp#0336 I'm wondering if this isn't rather a bug in I18NC_NOOP? That's of course a stupid

D24892: Fix usage of the new deprecation macros for assignIconsToContextMenu

2019-10-24 Thread Volker Krause
vkrause added a comment. In D24892#552838 , @kossebau wrote: > Looks good. Perfect would be if you tested KIconThemes with EXCLUDE_DEPRECATED_BEFORE_AND_AT set to hexnumber(5.64.0), to see if there is no internal usage still happening, like

D24931: Port KSSD internals from KSslError to QSslError

2019-10-24 Thread Volker Krause
vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY The strings don't match all enum values exactly, as this tries to keep the same strings for the corresponding enums

D24703: Port (most of) KSslInfoDialog from KSslError to QSslError

2019-10-24 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R241:ba182f153729: Port (most of) KSslInfoDialog from KSslError to QSslError (authored by vkrause). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24703?vs=68619=68708

D24902: K7Zip: Fix memory use in readAndDecodePackedStreams

2019-10-24 Thread Volker Krause
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R243 KArchive BRANCH master REVISION DETAIL https://phabricator.kde.org/D24902 To: aacid, vkrause Cc: kde-frameworks-devel, apol, dfaure, LeGast00n, GB_2, michaelh, ngraham, bruns

D24703: Port (most of) KSslInfoDialog from KSslError to QSslError

2019-10-23 Thread Volker Krause
vkrause updated this revision to Diff 68619. vkrause added a comment. Adapt to the new deprecation macros. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24703?vs=68063=68619 BRANCH D24703 REVISION DETAIL https://phabricator.kde.org/D24703 AFFECTED

D24764: Deprecate KIconTheme::assignIconsToContextMenu

2019-10-23 Thread Volker Krause
vkrause added a comment. Follow up in D24892 to address the latest comments. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D24764 To: vkrause, mlaurent Cc: kossebau, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D24892: Fix usage of the new deprecation macros for assignIconsToContextMenu

2019-10-23 Thread Volker Krause
vkrause created this revision. vkrause added a reviewer: kossebau. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REPOSITORY R302 KIconThemes BRANCH master REVISION DETAIL https://phabricator.kde.org/D24892

D24873: [http kio slave] use QSslSocket instead of KTcpSocket (deprecated)

2019-10-23 Thread Volker Krause
vkrause added a comment. In D24873#552697 , @ahmadsamir wrote: > In D24873#552410 , @vkrause wrote: > > > This will compile, but it will only work correctly once TCPSlaveBase has been ported to

D24884: I18N_NOOP2 was deprecated but we can't replace by I18NC_NOOP as it expends it as 2 elements (context + text)

2019-10-23 Thread Volker Krause
vkrause added a comment. Seeing things like https://lxr.kde.org/source/frameworks/ki18n/src/kuitmarkup.cpp#0336 I'm wondering if this isn't rather a bug in I18NC_NOOP? REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D24884 To: mlaurent, dfaure, ilic Cc: vkrause,

D24880: kio_http: avoid double Content-Type and Depth when used by KDAV

2019-10-23 Thread Volker Krause
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D24880 To: dfaure, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24316: Consider the usage of WebDAV methods sufficient for assuming WebDAV

2019-10-23 Thread Volker Krause
vkrause added a comment. In D24316#552541 , @dfaure wrote: > Can I just ignore the Depth from the custom http headers instead? > > --- i/src/ioslaves/http/http.cpp > +++ w/src/ioslaves/http/http.cpp > @@ -172,7 +172,8 @@ static

D24316: Consider the usage of WebDAV methods sufficient for assuming WebDAV

2019-10-23 Thread Volker Krause
vkrause added a comment. In D24316#552528 , @dfaure wrote: > I'm on the Applications/19.08 git branch, which shouldn't get broken by a newer KF5 release. > > Your patch works for Content-Type, but the duplicated Depth still leads to "Bad

D24316: Consider the usage of WebDAV methods sufficient for assuming WebDAV

2019-10-23 Thread Volker Krause
vkrause added a comment. Overall we probably have two options, revert this change (and the corresponding change in KDAV) and defer it to KF6, or harden this code further against duplicates in custom headers. The below might work for Content-Type (no way to test here atm), a similar fix for

D24316: Consider the usage of WebDAV methods sufficient for assuming WebDAV

2019-10-23 Thread Volker Krause
vkrause added a comment. Which version of KDAV do you have? master or some older release? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24316 To: vkrause, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24873: [http kio slave] use QSslSocket instead of KTcpSocket (deprecated)

2019-10-22 Thread Volker Krause
vkrause added a comment. This will compile, but it will only work correctly once TCPSlaveBase has been ported to QSslSocket too. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24873 To: ahmadsamir, dfaure, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D24764: Deprecate KIconTheme::assignIconsToContextMenu

2019-10-22 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R302:ccf27d634cbf: Deprecate KIconTheme::assignIconsToContextMenu (authored by vkrause). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24764?vs=68252=68555#toc REPOSITORY R302 KIconThemes

D24676: Port the KSSLD D-Bus interface from KSslError to QSslError

2019-10-22 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R241:12b68224e084: Port the KSSLD D-Bus interface from KSslError to QSslError (authored by vkrause). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24676?vs=67999=68552#toc REPOSITORY R241 KIO

D24703: Port (most of) KSslInfoDialog from KSslError to QSslError

2019-10-22 Thread Volker Krause
vkrause added a comment. ping? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24703 To: vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24799: Port away from deprecated SmallIcon method

2019-10-21 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R295:3b082be3acdd: Port away from deprecated SmallIcon method (authored by vkrause). REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24799?vs=68347=68454 REVISION

D24676: Port the KSSLD D-Bus interface from KSslError to QSslError

2019-10-21 Thread Volker Krause
vkrause added a comment. ping? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24676 To: vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24799: Port away from deprecated SmallIcon method

2019-10-20 Thread Volker Krause
vkrause added a task: T11654: Deprecate SmallIcon/DesktopIcon/BarIcon/UserIcon/MainBarIcon and KDE::icon in favor of KIconLoader or QIcon API. REPOSITORY R295 KCMUtils BRANCH master REVISION DETAIL https://phabricator.kde.org/D24799 To: vkrause, mlaurent Cc: kde-frameworks-devel,

D24799: Port away from deprecated SmallIcon method

2019-10-20 Thread Volker Krause
vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REPOSITORY R295 KCMUtils BRANCH master REVISION DETAIL https://phabricator.kde.org/D24799 AFFECTED FILES

D24742: Make non-ignorable SSL errors explicit

2019-10-19 Thread Volker Krause
vkrause updated this revision to Diff 68289. vkrause added a comment. Rebase on recent changes. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24742?vs=68248=68289 BRANCH next REVISION DETAIL https://phabricator.kde.org/D24742 AFFECTED FILES

D24762: Remove two unused member variables using KSslError

2019-10-19 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R241:0bf73b6eebd7: Remove two unused member variables using KSslError (authored by vkrause). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24762?vs=68249=68287 REVISION

D24770: KLocale api docs: make it easier to find how to port code away from it

2019-10-19 Thread Volker Krause
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R239 KDELibs4Support BRANCH ahmad/klocale-notes (branched from master) REVISION DETAIL https://phabricator.kde.org/D24770 To: ahmadsamir, #frameworks, vkrause Cc: kde-frameworks-devel, LeGast00n,

D24762: Remove two unused member variables using KSslError

2019-10-18 Thread Volker Krause
vkrause added a task: T11620: Port from KSslError to QSslError. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24762 To: vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24742: Make non-ignorable SSL errors explicit

2019-10-18 Thread Volker Krause
vkrause added a task: T11620: Port from KSslError to QSslError. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24742 To: vkrause Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24764: Deprecate KIconTheme::assignIconsToContextMenu

2019-10-18 Thread Volker Krause
vkrause added a task: T11865: Deprecate KIconTheme::assignIconsToContextMenu. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D24764 To: vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24764: Deprecate KIconTheme::assignIconsToContextMenu

2019-10-18 Thread Volker Krause
vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY It's no longer necessary as Qt sets icons on context menu actions itself by now. REPOSITORY R302 KIconThemes

D24762: Remove two unused member variables using KSslError

2019-10-18 Thread Volker Krause
vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REPOSITORY R241 KIO BRANCH next REVISION DETAIL https://phabricator.kde.org/D24762 AFFECTED FILES

D24742: Make non-ignorable SSL errors explicit

2019-10-18 Thread Volker Krause
vkrause updated this revision to Diff 68248. vkrause added a comment. Fix return value. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24742?vs=68168=68248 BRANCH next REVISION DETAIL https://phabricator.kde.org/D24742 AFFECTED FILES

D24675: Deprecate the KTcpSocket-based variant of SslUi::askIgnoreSslErrors

2019-10-17 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R241:b5f5fb475da7: Deprecate the KTcpSocket-based variant of SslUi::askIgnoreSslErrors (authored by vkrause). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D24742: Make non-ignorable SSL errors explicit

2019-10-17 Thread Volker Krause
vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY So far this is done implicitly in KSSLD by not being able to persist these error codes in its config file. This

D24703: Port (most of) KSslInfoDialog from KSslError to QSslError

2019-10-16 Thread Volker Krause
vkrause added a task: T11620: Port from KSslError to QSslError. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24703 To: vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24703: Port (most of) KSslInfoDialog from KSslError to QSslError

2019-10-16 Thread Volker Krause
vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D24703 AFFECTED FILES src/core/ksslerror_p.h

D24682: Use ECMGenerateExportHeader to manage deprecated API better

2019-10-16 Thread Volker Krause
vkrause accepted this revision. This revision is now accepted and ready to land. BRANCH useECMGenerateExportHeader REVISION DETAIL https://phabricator.kde.org/D24682 To: kossebau, #frameworks, vkrause

D24675: Deprecate the KTcpSocket-based variant of SslUi::askIgnoreSslErrors

2019-10-15 Thread Volker Krause
vkrause added a task: T11544: Remove KTcpSocket. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24675 To: vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24676: Port the KSSLD D-Bus interface from KSslError to QSslError

2019-10-15 Thread Volker Krause
vkrause added a task: T11620: Port from KSslError to QSslError. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24676 To: vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24676: Port the KSSLD D-Bus interface from KSslError to QSslError

2019-10-15 Thread Volker Krause
vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D24676 AFFECTED FILES

D24675: Deprecate the KTcpSocket-based variant of SslUi::askIgnoreSslErrors

2019-10-15 Thread Volker Krause
vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY The KSslErrorUiData variant below covers KTcpSocket too as a source for errors, next to QSslSocket/QNAM. Also,

D24655: give all pointers in slavebase a default init to nullptr

2019-10-15 Thread Volker Krause
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D24655 To: sitter, dfaure, meven, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24590: Port KSslErrorUiData to QSslError

2019-10-14 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R241:77fce361d9ba: Port KSslErrorUiData to QSslError (authored by vkrause). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24590?vs=67828=67918#toc REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D24631: exclude ioslaves directory from api docs

2019-10-14 Thread Volker Krause
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH no-slave-dox REVISION DETAIL https://phabricator.kde.org/D24631 To: sitter, dfaure, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24590: Port KSslErrorUiData to QSslError

2019-10-14 Thread Volker Krause
vkrause added a comment. In D24590#546528 , @aacid wrote: > Do we have tests for the thing you discovered breaks? Do we need them? There's almost no test coverage for this unfortunately, and yes, I'd feel much better if we had that. I

D24603: Port away from deprecated KDELibs4Support

2019-10-13 Thread Volker Krause
vkrause accepted this revision. vkrause added a comment. Thanks! REPOSITORY R103 KMenu Editor BRANCH master REVISION DETAIL https://phabricator.kde.org/D24603 To: ahmadsamir, mlaurent, vkrause Cc: vkrause, plasma-devel, kde-frameworks-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D24588: [SslUi] Overload askIgnoreSslErrors() to take a QSslSocket

2019-10-13 Thread Volker Krause
vkrause added a comment. In D24588#546229 , @dfaure wrote: > Hmm, why not just do `KSslErrorUiData uiData(socket);` in the caller, or even just `askIgnoreSslErrors(KSslErrorUiData(socket), storedRules)`. > Don't know, just wondering (not

D24590: Port KSslErrorUiData to QSslError

2019-10-13 Thread Volker Krause
vkrause updated this revision to Diff 67828. vkrause added a comment. This revision is now accepted and ready to land. Deal with errors with full QSslError level of detail until kssld is ported, make variables const. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D24590: Port KSslErrorUiData to QSslError

2019-10-13 Thread Volker Krause
vkrause planned changes to this revision. vkrause added a comment. This actually breaks things when the error comes from a Qt source rather than a KIO one, as we now carry the QSslError level of detail forward far enough and compare it to the stored KSslError. This is a temporary problem

D24590: Port KSslErrorUiData to QSslError

2019-10-12 Thread Volker Krause
vkrause added a task: T11620: Port from KSslError to QSslError. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24590 To: vkrause, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24590: Port KSslErrorUiData to QSslError

2019-10-12 Thread Volker Krause
vkrause created this revision. vkrause added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D24590 AFFECTED

  1   2   3   4   5   6   7   8   9   >