---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115424/
---
(Updated Feb. 8, 2014, 5:32 p.m.)
Review request for KDE Frameworks and
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115424/#review49264
---
Ship it!
Looks good, but then you have 56 other frameworks
On Feb. 8, 2014, 5:34 p.m., David Faure wrote:
Looks good, but then you have 56 other frameworks where to add a
if(BUILD_TESTING) around add_subdirectory(tests) and
add_subdirectory(autotests) :-)
That's fine, do I need to do a review request for all of those that have just
that
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115424/#review49266
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115424/
---
(Updated Feb. 8, 2014, 5:39 p.m.)
Status
--
This change has been
On Feb. 8, 2014, 5:34 p.m., David Faure wrote:
Looks good, but then you have 56 other frameworks where to add a
if(BUILD_TESTING) around add_subdirectory(tests) and
add_subdirectory(autotests) :-)
Michael Palimaka wrote:
That's fine, do I need to do a review request for all of
On Feb. 8, 2014, 5:34 p.m., David Faure wrote:
Looks good, but then you have 56 other frameworks where to add a
if(BUILD_TESTING) around add_subdirectory(tests) and
add_subdirectory(autotests) :-)
Michael Palimaka wrote:
That's fine, do I need to do a review request for all of
On Feb. 8, 2014, 5:34 p.m., David Faure wrote:
Looks good, but then you have 56 other frameworks where to add a
if(BUILD_TESTING) around add_subdirectory(tests) and
add_subdirectory(autotests) :-)
Michael Palimaka wrote:
That's fine, do I need to do a review request for all of
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115424/#review48758
---
tests/CMakeLists.txt
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115424/
---
(Updated Feb. 2, 2014, 3:09 p.m.)
Review request for KDE Frameworks and
On Feb. 2, 2014, 9:36 a.m., David Faure wrote:
tests/CMakeLists.txt, lines 1-2
https://git.reviewboard.kde.org/r/115424/diff/1/?file=241204#file241204line1
There's never any reason for the tests/ subdir to use Qt5Test.
Qt5Test = library for autotests.
It uses
On Feb. 1, 2014, 7:45 p.m., Alex Merry wrote:
autotests/CMakeLists.txt, line 1
https://git.reviewboard.kde.org/r/115424/diff/1/?file=241203#file241203line1
What happens if Qt5Test is not found? Presumably, this should either
be REQUIRED or the tests should be wrapped in an if()
On Feb. 2, 2014, 9:36 a.m., David Faure wrote:
tests/CMakeLists.txt, lines 1-2
https://git.reviewboard.kde.org/r/115424/diff/1/?file=241204#file241204line1
There's never any reason for the tests/ subdir to use Qt5Test.
Qt5Test = library for autotests.
Michael
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115424/#review48754
---
Build checked with 2.8.12.0, but see below.
14 matches
Mail list logo
