D9423: Fix 'Exec line in kiod service file must not have any path prefix on Windows'

habacker added a comment. This review was superseded by D9669 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9423 To: habacker, dfaure, bcooksley, kfunk Cc: apol, kfunk, broulik, #frameworks, michaelh, ngraham, bruns

D9427: Fix 'Exec line in kpasswdserver service file must not have any path prefix on Windows'

habacker added a comment. This review was superseded by D9669 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9427 To: habacker, dfaure, bcooksley Cc: #frameworks, michaelh, ngraham, bruns

D9428: Fix 'Exec line in kcookiejar service file must not have any path prefix on Windows'

habacker added a comment. This review was superseded by D9669 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9428 To: habacker, dfaure, bcooksley Cc: #frameworks, michaelh, ngraham, bruns

D9426: Fix 'Exec line in kssld service file must not have any path prefix on Windows'

habacker added a comment. This review was superseded by D9669 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9426 To: habacker, dfaure, bcooksley Cc: #frameworks, michaelh, ngraham, bruns

D9425: Fix 'Exec line in kioexecd service file must not have any path prefix on Windows'

habacker added a comment. This review was superseded by D9669 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9425 To: habacker, dfaure, bcooksley Cc: #frameworks, michaelh, ngraham, bruns

D7706: Use runtime install prefix instead of compile time install prefix.

habacker marked an inline comment as done. habacker added a comment. In D7706#181225 , @dfaure wrote: > There is a completely different solution: adding to Qt a method that takes a function address and returns the full path to the binary (shared l

D12064: Don't alter memory management to hide an item

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. davidedmundson requested review of this revision. REVISION SUMMARY The original owner of a graphics item is th

D11851: Add syntax highlighting for Logcat

nibags updated this revision to Diff 31729. nibags added a comment. - New test file. I also merged some RegExpr rules. REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11851?vs=31075&id=31729 BRANCH add-logcat (branched from master) REVIS

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.10 - Build # 67 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.10/67/ Project: Frameworks baloo kf5-qt5 SUSEQt5.10 Date of build: Mon, 09 Apr 2018 10:16:46 + Build duration: 11 min and counting JUnit Tests Name: (root) F

D12016: [ktexteditor] much faster positionFromCursor

jtamate updated this revision to Diff 31733. jtamate edited the summary of this revision. jtamate edited the test plan for this revision. jtamate added a reviewer: Frameworks. jtamate added a comment. Cached the position in static variables of KateViewAccessible. The cache is invalidated when

D12064: Don't alter memory management to hide an item

rikmills added a comment. Applied this to 5.44 in test package for Ubuntu 18.04 Switched containment folderview -> desktop and back several times. No longer any crash. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D12064 To: davidedmundson,

Asking for recommendations on how to add a feature to KTextEditor

Hi, I would like to ask for hints/recommendations on how to implement a feature for KTextEditor. My ultimate goal is to make a plugin for KDevelop that will show some additional information in the code itself. For example names of function arguments at call site. Something like this in intellij:

D12016: [ktexteditor] much faster positionFromCursor

cullmann added a comment. Hi, must the variable be static or would an object member be good enough? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12016 To: jtamate, #kate, cullmann, #frameworks Cc: cullmann, #frameworks, michaelh, kevinapavew, ngraham, bruns, de

D12016: [ktexteditor] much faster positionFromCursor

jtamate added a comment. In D12016#243079 , @cullmann wrote: > Hi, must the variable be static or would an object member be good enough? It can't be a member object, because some methods that call positionFromCursor are const. I tried :-(

D12016: [ktexteditor] much faster positionFromCursor

cullmann added a comment. You can use a mutable member for that. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12016 To: jtamate, #kate, cullmann, #frameworks Cc: cullmann, #frameworks, michaelh, kevinapavew, ngraham, bruns, demsking, sars, dhaumann

Re: Asking for recommendations on how to add a feature to KTextEditor

On Mon, Apr 9, 2018 at 12:49 PM, Michal Srb wrote: > Hi, > > I would like to ask for hints/recommendations on how to implement a > feature for KTextEditor. > > My ultimate goal is to make a plugin for KDevelop that will show some > additional information in the code itself. For example names of >

Re: Asking for recommendations on how to add a feature to KTextEditor

On Monday, 9 April 2018 13:13:46 CEST Aleix Pol wrote: > On Mon, Apr 9, 2018 at 12:49 PM, Michal Srb wrote: > > Hi, > > > > I would like to ask for hints/recommendations on how to implement a > > feature for KTextEditor. > > > > My ultimate goal is to make a plugin for KDevelop that will show so

D12016: [ktexteditor] much faster positionFromCursor

jtamate updated this revision to Diff 31737. jtamate edited the summary of this revision. jtamate added a comment. Implemented now as object method instead of static. Changed the calls from KateViewInternal from static to use the reference the method QAccessible::queryAccessibleInterface(thi

D12045: Clean up existing documentation

michaelh updated this revision to Diff 31739. michaelh added a comment. - Apply suggested changes - Add KFileMetaData link - Correct new bug links - Change recommendation text REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12045?vs=31688&id=31739 BRANC

D12045: Clean up existing documentation

michaelh marked 2 inline comments as done. michaelh added a subscriber: ngraham. michaelh added inline comments. INLINE COMMENTS > README.md:36 > +the native system than Baloo ever will. > + > +Baloo may run on 32-bit systems, but it has not been tested and may not work @ngraham Original text w

D11452: sanitizer: Improve device listing

bruns added inline comments. INLINE COMMENTS > databasesanitizer.cpp:159 > +// Create a hash to sum-up indexed items > QMultiHash usedDevices; > +for (const auto& info : infos) { I can not come up with a reason to use a MultiHash here in the first place - all that is ne

D11745: databasesanitizer: Use flags for filtering

bruns added inline comments. INLINE COMMENTS > databasesanitizer.cpp:100 > QTextStream err(stderr); > for (quint64 id: keys) { > printProgress(err, i, max, 100); As you are not iterating over sorted keys, just directly iterate on the map. > databasesanitizer.cpp:1

D11828: Simplify orPostingIterator and make it faster

bruns added a comment. In D11828#242372 , @michaelh wrote: > While reading in IDE realized `(*it)` resolves to `PostingIterator**` I got a little dizzy at first, then started to play with this code and came up with this. > In Constructor: >

D11828: Simplify orPostingIterator and make it faster

bruns added inline comments. INLINE COMMENTS > michaelh wrote in orpostingiterator.cpp:71 > Newbie question: Does std::unique_ptr make sense here? When writing from scratch today, yes. But this would not disallow nullptr (`std::make_unique(nullptr)` is fully valid) REPOSITORY R293 Baloo REV

D12071: add a new ConstrainedSquare formfactor

mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. mart requested review of this revision. REVISION SUMMARY It will make possible for applets to know they are in a systray-like si

D12071: add a new ConstrainedSquare formfactor

kossebau added a comment. Commit message could see some "bug:388995" :) "ConstrainedSquare" sounds like there could be other "Contrained*" in the future? Why this term combination instead of just "Square"? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricato

D12071: add a new ConstrainedSquare formfactor

mart edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D12071 To: mart, #plasma Cc: kossebau, #frameworks, michaelh, ngraham, bruns

D12071: add a new ConstrainedSquare formfactor

mart added a comment. suggests that is more about it being constrained both horizontally and vertically than being a square, which may not be a given (the actual name comes from an old enum value in Plasma 4 that was AspectRatio) is i think the most correct name, even if less intuitive woul

D12016: [ktexteditor] much faster positionFromCursor

brauch added a comment. Re. binary compatibility: should be fine because this class is not exported (no KTEXTEDITOR_EXPORT macro). REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12016 To: jtamate, #kate, cullmann, #frameworks Cc: brauch, cullmann, #frameworks, m

D12016: [ktexteditor] much faster positionFromCursor

brauch added a comment. Oh and, you do not need to inherit QObject to use connect; you can connect to a lambda calling the member function AFAIK or so. Just omit the third argument in connect(). What you lose by doing this is the automatic disconnect of the connection when the receiver objec

D11452: sanitizer: Improve device listing

michaelh marked 4 inline comments as done. michaelh added inline comments. INLINE COMMENTS > bruns wrote in databasesanitizer.cpp:159 > I can not come up with a reason to use a MultiHash here in the first place - > all that is needed is the deviceId and the file count per device. > > You can us

D11828: Simplify orPostingIterator and make it faster

michaelh added a comment. :-) Thank you for the lesson. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11828 To: bruns, #baloo, michaelh Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin

D11828: Simplify orPostingIterator and make it faster

bruns added a comment. In D11828#242402 , @michaelh wrote: > I'm not very familiar with the concept of iterators (yet). To me it looks like `auto i = new OrPostingIterator(iters); i->docId();` will return 0 and `i->next()` returns a valid docId.

D11828: Simplify orPostingIterator and make it faster

michaelh added a comment. Thank you once more. This is complicated stuff (for me), it will take some time to sink in. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11828 To: bruns, #baloo, michaelh Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngrah

D11452: sanitizer: Improve device listing

michaelh added inline comments. INLINE COMMENTS > michaelh wrote in fsutils.cpp:111 > I agree completely and followed your suggestion. Currently I'm stuck, though. > Using Solid to obtain the accessibilty info of volumes and network shares, > it seems only `Solid::Block` provides the `major` a

D12016: [ktexteditor] much faster positionFromCursor

jtamate updated this revision to Diff 31760. jtamate added a comment. No QObject inheritance, only a QMetaObject::Connection member to disconnect the connection. As this is a non exported class, use the same method name and make it non-static. KateViewInternal::cursorMoved checks if QAcce

D11768: Add Desktop and Downloads to the default list of Places

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11768 To: ngraham, #dolphin, #gwenview, #frameworks, #vdg, markg, progwolff Cc: huoni, markg, fabiank, progwolff, broulik, michaelh, ngraham, bruns

D11452: sanitizer: Improve device listing

bruns added inline comments. INLINE COMMENTS > michaelh wrote in fsutils.cpp:111 > I agree completely and followed your suggestion. Currently I'm stuck, though. > Using Solid to obtain the accessibilty info of volumes and network shares, > it seems only `Solid::Block` provides the `major` and

D5784: Add support for FreeBSD in FSUtils::getDirectoryFileSystem().

bruns added a comment. Restricted Application added a project: Baloo. The whole function as currently used is pointless. Currently, it sets the NO_COW flag on BTRFS, but this is insufficient: - XFS - https://lwn.net/Articles/747633/ - F2FS - Hammer2 ? At least on Linux, the c

D5784: Add support for FreeBSD in FSUtils::getDirectoryFileSystem().

bruns added a reviewer: bruns. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D5784 To: tcberner, #freebsd, kfunk, poboiko, bruns Cc: bruns, adridg, kfunk, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin

D11851: Add syntax highlighting for Logcat

nibags updated this revision to Diff 31767. nibags added a comment. - I added two lines to the test file REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11851?vs=31729&id=31767 BRANCH add-logcat (branched from master) REVISION DETAIL https:

D12045: Clean up existing documentation

bruns added inline comments. INLINE COMMENTS > README.md:31 > +Baloo is developed and tested exclusively for Linux. While it may run on > other > +unix based systems. It is not recommended, and certainly not tested. > + While it may run on other unix based systems ", it is hardly tested. It is

D12045: Clean up existing documentation

michaelh added inline comments. INLINE COMMENTS > bruns wrote in README.md:36 > AFAIK, on windows only the library is built, but as a stub. > > See: > R293:49fecea8e218ce03b01073c1604cfc0b683b1cc5 > If I understood R29

D5784: Add support for FreeBSD in FSUtils::getDirectoryFileSystem().

kfunk resigned from this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D5784 To: tcberner, #freebsd, poboiko, bruns Cc: bruns, adridg, kfunk, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin

D11452: sanitizer: Improve device listing

michaelh updated this revision to Diff 31773. michaelh added a comment. - Optimize device list creation REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11452?vs=31438&id=31773 BRANCH sanitize-devices (branched from master) REVISION DETAIL https://phabric

D12045: Clean up existing documentation

michaelh added inline comments. INLINE COMMENTS > michaelh wrote in README.md:36 > If I understood R293:49fecea8e218ce03b01073c1604cfc0b683b1cc5 > > correctly baloo is a stub for every system except linux. > In that ca

D11993: Tweak column widths in tree view of file open/save dialogs

ngraham edited the summary of this revision. REPOSITORY R241 KIO BRANCH arcpatch-D11993 REVISION DETAIL https://phabricator.kde.org/D11993 To: sharvey, ngraham, dfaure Cc: cfeck, fabiank, broulik, #frameworks, michaelh, ngraham, bruns

D5784: Add support for FreeBSD in FSUtils::getDirectoryFileSystem().

adridg added a comment. The question is mostly: does the existing (complicated) code do anything that QStorageInfo doesn't? Because switching to QStorageInfo gives us the functionality on FreeBSD for free (even if it's not useful because we'll never have btrfs). REPOSITORY R293 Baloo REV

D11452: sanitizer: Improve device listing

michaelh added inline comments. INLINE COMMENTS > databasesanitizer.cpp:165 > +deviceInfo.id = info.deviceId; > +fillInDeviceInfo(deviceInfo); > +} Will try to use QStorageInfo REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11

D11993: Tweak column widths in tree view of file open/save dialogs

ngraham edited the summary of this revision. REPOSITORY R241 KIO BRANCH arcpatch-D11993 REVISION DETAIL https://phabricator.kde.org/D11993 To: sharvey, ngraham, dfaure Cc: cfeck, fabiank, broulik, #frameworks, michaelh, ngraham, bruns

Re: On KIO and non-unicode compatible paths

On 08.04.2018 13:59, Inkane wrote: I recently had a look at Bug 173097 (Cannot delete a file with "invalid" characters in its name), and unfortunately, this seems to be a surprisingly difficult issue to fix with how KIO is currently designed. [...] The root of the issue here is basically the way

D12077: Show toggle buttons in the toolbar for the two most commonly-used view modes in the file open/save dialogs

ngraham created this revision. ngraham added a reviewer: Frameworks. Restricted Application added a project: Frameworks. ngraham requested review of this revision. REVISION SUMMARY Without this patch, changing the view mode is unnecesarily difficult: you need to click on the settings button in

D12034: Use the more appropriate "two sliders" icon for "configure"

ngraham added a reviewer: Breeze. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D12034 To: ngraham, #vdg, #plasma, #breeze Cc: sharvey, #frameworks, michaelh, ngraham, bruns

D12077: Show toggle buttons in the toolbar for the two most commonly-used view modes in the file open/save dialogs

ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12077 To: ngraham, #frameworks Cc: michaelh, ngraham, bruns

D5784: Add support for FreeBSD in FSUtils::getDirectoryFileSystem().

bruns added a comment. In D5784#243432 , @adridg wrote: > The question is mostly: does the existing (complicated) code do anything that QStorageInfo doesn't? Because switching to QStorageInfo gives us the functionality on FreeBSD for free (even i

D11452: sanitizer: Improve device listing

bruns added inline comments. INLINE COMMENTS > databasesanitizer.cpp:163 > +DeviceInfo& deviceInfo = usedDevices[info.deviceId]; > +if (deviceInfo.id == 0) { > +deviceInfo.id = info.deviceId; instead of checking and filling it in here, just iterate over us

D12034: Use the more appropriate "two sliders" icon for "configure"

abetts added a comment. I am in fact, a little bit taken back by the fact that we have a two slider icon. The reason is because I have been told many times that we don't want to use sliders or toggles in the desktop. We are referencing something that doesn't exist in the Plasma desktop. I mi

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 100 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/100/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 10 Apr 2018 03:34:27 + Build duration: 3 min 13 sec and counting

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 125 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/125/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Tue, 10 Apr 2018 03:34:27 + Build duration: 11 min and counting JUnit Te

D12034: Use the more appropriate "two sliders" icon for "configure"

ngraham added a comment. 1. System Settings uses sliders right there in its icon. :) They're already used to mean "Configure me!" in other contexts (KRunner, Plasma widgets, GTK apps) 2. Sliders aren't the same as on/off toggle buttons. We use sliders in, for example, volume controls. I do

D12034: Use the more appropriate "two sliders" icon for "configure"

abetts added a comment. In D12034#243522 , @ngraham wrote: > 1. System Settings uses sliders right there in its icon. :) They're already used to mean "Configure me!" in other contexts (KRunner, Plasma widgets, GTK apps) > 2. Sliders aren't the

D12034: Use the more appropriate "two sliders" icon for "configure"

ngraham added a comment. If we also want to change the icon, it can't be done as a part of this patch because I've got no icon design or vector art skills whatsoever. It can't go into this patch as long as I'm the author. Like I said, I'm open to changing the icon itself, but that's a separa

D12034: Use the more appropriate "two sliders" icon for "configure"

sharvey added a comment. Since I may or may not have been the one to bring this to @ngraham's attention, I'll offer my two cents and be done. - The mini/mono slider icons for widget & panel configs, are, I believe, hardcoded and drawn from Breeze. - The full-size two-slider icon for Sy