D15714: add a string suffix to test data and use for unicode testing of taglibwriter

astippich marked 5 inline comments as done. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D15714 To: astippich, mgallien, bruns Cc: smithjd, svuorela, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D15714: add a string suffix to test data and use for unicode testing of taglibwriter

astippich updated this revision to Diff 42541. astippich added a comment. - fix after rebase REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15714?vs=42525=42541 BRANCH taglib_write_unicode REVISION DETAIL https://phabricator.kde.org/D15714

D15826: [Balooshow] Avoid out-of-bounds access when accessing corrupt db data

anthonyfieroni added inline comments. INLINE COMMENTS > main.cpp:217 > +int posOfNonNumeric = word.indexOf('-', 2); > +if ((posOfNonNumeric < -1) || ((posOfNonNumeric + 1) > == word.length())) { > +stream << "Malformed

D15829: make units and prefixes of formatValue translatable

astippich created this revision. astippich added reviewers: bruns, safaalfulaij. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY give the possibility to translate the prefix und unit strings

D15830: Properly scope CMAKE_REQUIRED_LIBRARIES change

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY It's the clean thing to do anyway, and it looks like this has side-effects on the coverage build of the CI.

D15829: make units and prefixes of formatValue translatable

astippich added a comment. @bruns please have a look at the changes. In particular, regarding "µ" and windows support. I don't know if this will be able to compile on windows, or how to fix it for tr() function. @safaalfulaij please verify if this fixes the RTL issue for you REPOSITORY

D15829: make units and prefixes of formatValue translatable

safaalfulaij added a comment. I came into anther problem, this time with the unit selection. In Arabic, we don't put a dot between the prefix and the unit if we're talking about meters (mm, cm, km), but we do with other units (k.Byte, M.Byte, G.Byte). If ki18n was used here, all of

D15826: [Balooshow] Avoid out-of-bounds access when accessing corrupt db data

bruns updated this revision to Diff 42547. bruns marked an inline comment as done. bruns added a comment. fix "not found" condition for `word.indexOf(...)` REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15826?vs=42530=42547 BRANCH db_robustness2 REVISION

D15826: [Balooshow] Avoid out-of-bounds access when accessing corrupt db data

bruns added inline comments. INLINE COMMENTS > anthonyfieroni wrote in main.cpp:217 > posOfNonNumeric < 0 or == -1 ? Thou shall not code after bedtime ... Thx. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15826 To: bruns, #baloo, #frameworks Cc: anthonyfieroni,

D15525: Fix rendering Aztec codes with an aspect ratio != 1

dhaumann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R280 Prison BRANCH master REVISION DETAIL https://phabricator.kde.org/D15525 To: vkrause, dhaumann Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kpackage » kf5-qt5 AndroidQt5.11 - Build # 24 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20AndroidQt5.11/24/ Project: kf5-qt5 AndroidQt5.11 Date of build: Sat, 29 Sep 2018 15:14:09 + Build duration: 3 min 12 sec and counting

D15830: Properly scope CMAKE_REQUIRED_LIBRARIES change

This revision was automatically updated to reflect the committed changes. Closed by commit R249:bfe6134916f3: Properly scope CMAKE_REQUIRED_LIBRARIES change (authored by vkrause). REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15830?vs=42543=42553 REVISION

D12336: Replace several Q_ASSERTs with proper checks

apol added subscribers: sitter, apol. apol added a comment. If it was silently corrupting the DB maybe the right solution would have been to integrate baloo properly with KCrash. Like @sitter did in https://phabricator.kde.org/D15573. INLINE COMMENTS > documenturldb.cpp:44 > { > -

D15525: Fix rendering Aztec codes with an aspect ratio != 1

vkrause added a comment. ping REPOSITORY R280 Prison REVISION DETAIL https://phabricator.kde.org/D15525 To: vkrause Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15829: make units and prefixes of formatValue translatable

safaalfulaij added a comment. Since the joining between number and format is translatable, that's great. I meant that if it is kept untranslatable, problems regarding RTL will happen. INLINE COMMENTS > kformatprivate.cpp:115 > const PrefixMapEntry map[] = { > -{

D15830: Properly scope CMAKE_REQUIRED_LIBRARIES change

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Let's see what happens... REPOSITORY R249 KI18n BRANCH master REVISION DETAIL https://phabricator.kde.org/D15830 To: vkrause, apol Cc: apol, kde-frameworks-devel, michaelh, ngraham,

D12336: Replace several Q_ASSERTs with proper checks

bruns added inline comments. INLINE COMMENTS > apol wrote in documenturldb.cpp:44 > Would it make sense to include a warning then? If it's a wrong input, we'll > need ways to debug it now that it won't be giving a backtrace. This may be accessed quite frequently, so we would get a lot of

KDE CI: Frameworks » kunitconversion » kf5-qt5 AndroidQt5.11 - Build # 18 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kunitconversion/job/kf5-qt5%20AndroidQt5.11/18/ Project: kf5-qt5 AndroidQt5.11 Date of build: Sat, 29 Sep 2018 15:10:45 + Build duration: 3 min 3 sec and counting

D15773: AppArmor: fix crashes in open rules (in KF5.50) and improvements for the new Solarized schemes

cullmann added a comment. Thanks for the examples, with that I could reproduce and introduce some hard guard for such cases. Better broken highlighting then an endless hanging application. https://phabricator.kde.org/D15836 REPOSITORY R216 Syntax Highlighting REVISION DETAIL

D15829: make units and prefixes of formatValue translatable

astippich updated this revision to Diff 42563. astippich added a comment. - change description for prefixes and make the IEC prefix translatable REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15829?vs=42542=42563 BRANCH translate_units REVISION

D12336: Replace several Q_ASSERTs with proper checks

bruns added a comment. Herald added a subscriber: kde-frameworks-devel. Ping! REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12336 To: bruns, #baloo, michaelh, #frameworks Cc: kde-frameworks-devel, broulik, #frameworks, ashaposhnikov, michaelh, astippich, spoorun,

D15829: make units and prefixes of formatValue translatable

astippich added a comment. In D15829#333799 , @safaalfulaij wrote: > Since the joining between number and format is translatable, that's great. I meant that if it is kept untranslatable, problems regarding RTL will happen. Sorry, I

D15833: extend test coverage to all supported mimetypes for taglibextractor

astippich created this revision. astippich added reviewers: mgallien, bruns, svuorela. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY add new test files such that all mime types

D15835: avoid that the main context can be #poped

cullmann created this revision. cullmann added a reviewer: dhaumann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. cullmann requested review of this revision. REVISION SUMMARY avoids that the main context can be #poped + ensure we abort

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.11 - Build # 29 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.11/29/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sat, 29 Sep 2018 19:58:08 + Build duration: 3 min 42 sec and counting

D15842: Lower log level for X-KDE-DBus-ServiceName missing message

bruns created this revision. bruns added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY None of the KDED modules provide a X-KDE-DBus-ServiceName, so there are a lot of

D15835: avoid that the main context can be #poped

This revision was automatically updated to reflect the committed changes. Closed by commit R216:9e039a669f8f: avoid that the main context can be #poped (authored by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15835?vs=42555=42560

D15525: Fix rendering Aztec codes with an aspect ratio != 1

This revision was automatically updated to reflect the committed changes. Closed by commit R280:1f7e403b02dd: Fix rendering Aztec codes with an aspect ratio != 1 (authored by vkrause). REPOSITORY R280 Prison CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15525?vs=41687=42561

D15829: make units and prefixes of formatValue translatable

astippich added inline comments. INLINE COMMENTS > safaalfulaij wrote in kformatprivate.cpp:168 > Well, I searched other languages and no one seems to do as Arabic does. We do > not abbreviate in this case and just write the whole "Mebi.Byte" ("Byte" is > always written, "M.Byte" > "MB"). >

D15839: extend PlasmaCore.ColorScope for custom colors

mvourlakos created this revision. mvourlakos added reviewers: Plasma, davidedmundson, mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mvourlakos requested review of this revision. REVISION SUMMARY --In the future dynamic coloring might be needed for

D15839: extend PlasmaCore.ColorScope for custom colors

mvourlakos edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15839 To: mvourlakos, #plasma, davidedmundson, mart Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15839: extend PlasmaCore.ColorScope for custom colors

mvourlakos added a comment. F6294480: εικόνα.png [plasma taskmanager that is using red as textColor even though Breeze-Dark theme is chosen] REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15839 To:

D15836: Endless state transition guard

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D15836 To: cullmann, dhaumann, vkrause, nibags Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking,

D15835: avoid that the main context can be #poped

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde.org/D15835 To: cullmann, dhaumann, vkrause, nibags Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns,

D12336: Replace several Q_ASSERTs with proper checks

apol added inline comments. INLINE COMMENTS > bruns wrote in documenturldb.cpp:44 > This may be accessed quite frequently, so we would get a lot of warnings, > spamming the journal, and slowing down the system. > > A backtrace is useless here, as the code processes whatever it finds in the >

D15833: extend test coverage to all supported mimetypes for taglibextractor

svuorela added a comment. What's the origin/license of these files ? How are they created ? REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D15833 To: astippich, mgallien, bruns, svuorela Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich,

D15843: Allow FileIndexerConfig to check device mounted status by path.

smithjd created this revision. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. smithjd requested review of this revision. REVISION SUMMARY Parts of Baloo need some way to check if a path's volume is mounted or not. REPOSITORY R293 Baloo

D15844: Allow removing non-existent folders from include and exclude lists

ngraham updated this revision to Diff 42574. ngraham added a comment. Don't unnecessarily rename the variable REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15844?vs=42573=42574 BRANCH fix-removing-locations-from-include-and-exclude-lists (branched from

D15843: Allow FileIndexerConfig to check device mounted status by path.

bruns added a comment. Whats the use case exactly? "Some parts" is not sufficient ... REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15843 To: smithjd, #baloo, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns,

D15844: Allow removing non-existent folders from include and exclude lists

ngraham closed this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15844 To: ngraham, #baloo, bruns Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D15843: Allow FileIndexerConfig to check device mounted status by path.

ngraham added reviewers: Baloo, bruns. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15843 To: smithjd, #baloo, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D15844: Allow removing non-existent folders from include and exclude lists

bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH fix-removing-locations-from-include-and-exclude-lists (branched from master) REVISION DETAIL https://phabricator.kde.org/D15844 To: ngraham, #baloo, bruns Cc: kde-frameworks-devel,

D15843: Allow FileIndexerConfig to check device mounted status by path.

smithjd added a comment. In D15843#334024 , @bruns wrote: > Whats the use case exactly? "Some parts" is not sufficient ... The index cleaner for example needs to skip unmounted paths. REPOSITORY R293 Baloo REVISION DETAIL

D15583: [Balooctl] remove directory parent check

bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH arcpatch-D15583 REVISION DETAIL https://phabricator.kde.org/D15583 To: ngraham, #baloo, #dolphin, bruns, #frameworks Cc: smithjd, anthonyfieroni, kde-frameworks-devel,

D15583: [Balooctl] remove directory parent check

This revision was automatically updated to reflect the committed changes. Closed by commit R293:2452ce28193a: [Balooctl] remove directory parent check (authored by ngraham). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15583?vs=42152=42576 REVISION DETAIL

D15846: Remove misleading use of KDE_INSTALL_PYTHONBINDINGSDIR

bruns created this revision. bruns added reviewers: Frameworks, apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Removing the (typically empty) optional argument from the function invocation

D15845: Remove misleading use of KDE_INSTALL_PYTHONBINDINGSDIR

bruns created this revision. bruns added reviewers: Frameworks, apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Removing the (typically empty) optional argument from the function invocation

D15843: Allow FileIndexerConfig to check device mounted status by path.

ngraham added a comment. I think what @bruns is gently trying to indicate is that your Summary needs improvement. :) Remember that it becomes a part of the commit message once the patch lands. A Test Plan wouldn't hurt, either. REPOSITORY R293 Baloo REVISION DETAIL

D15825: move testing of common tags of test files to a new data-driven test for taglibextractor

bruns added a comment. There are some more common tags with identical values, i.e. AlbumArtist, Composer and Lyrics - any reason you kept these? REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D15825 To: astippich, bruns, svuorela Cc: kde-frameworks-devel,

D15844: Allow removing non-existent folders from include and exclude lists

ngraham created this revision. ngraham added reviewers: Baloo, bruns. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY Currently, if you add a folder to Baloo's `includeFolders` or

D15844: Allow removing non-existent folders from include and exclude lists

ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15844 To: ngraham, #baloo, bruns Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D15848: Remove misleading use of KDE_INSTALL_PYTHONBINDINGSDIR

bruns created this revision. bruns added reviewers: Frameworks, apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Removing the (typically empty) optional argument from the function invocation

D15847: Remove misleading use of KDE_INSTALL_PYTHONBINDINGSDIR

bruns created this revision. bruns added reviewers: Frameworks, apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Removing the (typically empty) optional argument from the function invocation

D15833: extend test coverage to all supported mimetypes for taglibextractor

bruns requested changes to this revision. bruns added a comment. This revision now requires changes to proceed. Please lower bitdepth. Also, can you provide the commandline or the like to generate the files? - probably this is also stuff for an accompanying `README` file. REPOSITORY R286

D15825: move testing of common tags of test files to a new data-driven test for taglibextractor

astippich added a dependent revision: D15833: extend test coverage to all supported mimetypes for taglibextractor. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D15825 To: astippich, bruns, svuorela Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh,

D15833: extend test coverage to all supported mimetypes for taglibextractor

astippich added a dependency: D15825: move testing of common tags of test files to a new data-driven test for taglibextractor. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D15833 To: astippich, mgallien, bruns, svuorela Cc: kde-frameworks-devel, #baloo,

D15833: extend test coverage to all supported mimetypes for taglibextractor

astippich updated this revision to Diff 42551. astippich added a comment. - modify permissions of binary files REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15833?vs=42549=42551 BRANCH taglib_extractor_additional_tests REVISION DETAIL

D15836: Endless state transition guard

This revision was automatically updated to reflect the committed changes. Closed by commit R216:899ce3e7bb6e: Endless state transition guard (authored by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15836?vs=42558=42559 REVISION

D15835: avoid that the main context can be #poped

cullmann added reviewers: vkrause, nibags. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D15835 To: cullmann, dhaumann, vkrause, nibags Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D12336: Replace several Q_ASSERTs with proper checks

bruns added inline comments. INLINE COMMENTS > apol wrote in documenturldb.cpp:44 > Shouldn't asserts help to find where the library is being misused? You gain no information if you crash here. Not the code is wrong, but the processed data. Most importantly, when somebody runs this code,

D15833: extend test coverage to all supported mimetypes for taglibextractor

bruns added a comment. In D15833#333933 , @svuorela wrote: > What's the origin/license of these files ? How are they created ? The files contain just silence. @astippich - can you convert the wav file to 8bit (32bit float currently),

D15836: Endless state transition guard

cullmann created this revision. cullmann added reviewers: dhaumann, vkrause, nibags. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. cullmann requested review of this revision. REVISION SUMMARY This e.g. catches the "hang" people did see

[sysadmin/ci-tooling] build-specs/Frameworks: Re-disable the KIO tests on Windows like we have done essentially since the inception of Windows CI.

Git commit fc6d15636d8da49f351e4bccf02e877efe5d9b10 by Ben Cooksley. Committed on 29/09/2018 at 19:57. Pushed by bcooksley into branch 'master'. Re-disable the KIO tests on Windows like we have done essentially since the inception of Windows CI. Qt on Windows is horrendously broken when it comes

D15778: Log wallet open failure errors

This revision was automatically updated to reflect the committed changes. Closed by commit R311:c7b064e5a3d5: Log wallet open failure errors (authored by arjun). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D15778?vs=42430=42538#toc REPOSITORY R311 KWallet CHANGES SINCE LAST UPDATE

D15778: Log wallet open failure errors

arjun marked an inline comment as done. arjun added a comment. In D15778#333555 , @bruns wrote: > The preferred way is to use arc, i.e. `arc diff`, ..., `arc land`, which ensures phabricator tags (Reviewed:, Revision, ...) are added to the