D29101: KNewStuff: Fix file path and process call

alex added a dependent revision: D29123: Do not mark entry as uninstalled if uninstallation script failed. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D29101 To: alex, #knewstuff, ngraham, nicolasfella, elvisangelaccio, meven, mlaurent Cc: kde-frameworks-devel,

D29123: Do not mark entry as uninstalled if uninstallation script failed

leinir requested changes to this revision. leinir added a comment. This revision now requires changes to proceed. On a related note, i'm waiting on reviews on D28701 at the moment... which i'm afraid might wreck some havoc with your patch, as they touch

D29149: Fix kio-extras compilation with -DQT_NO_CAST_TO_ASCII

dfaure created this revision. dfaure added reviewers: thiago, sitter. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY D27804 broke compilation

D28590: Add a QString Solid::Device::displayName, used in Fstab Device for network mounts

bruns added a comment. In D28590#656133 , @meven wrote: > In D28590#654139 , @bruns wrote: > > > Do not create m_storageAccess in the constructor > > > Hmm, you told me `the f

D29123: Do not mark entry as uninstalled if uninstallation script failed

alex edited the summary of this revision. alex added a dependency: D29101: KNewStuff: Fix file path and process call. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D29123 To: alex, #knewstuff, meven, ngraham, leinir Cc: leinir, kde-frameworks-devel, LeGast00n,

D29123: Do not mark entry as uninstalled if uninstallation script failed

alex updated this revision to Diff 81076. alex retitled this revision from "WIP BUG: 420312. Do not mark entry as uninstalled if uninstallation script failed" to "Do not mark entry as uninstalled if uninstallation script failed". alex edited the summary of this revision. alex added a comment.

D29123: Do not mark entry as uninstalled if uninstallation script failed

alex added inline comments. INLINE COMMENTS > leinir wrote in installation.cpp:632 > This will want to be more... question like... "The thing failed" isn't really > a question, not sure how the user's supposed to make an informed choice based > on that... Perhaps something like "The

D29101: WIP Fix file path and process call

meven retitled this revision from "WIP BUG: 420312 Fix file path and process call" to "WIP Fix file path and process call". meven edited the summary of this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D29101 To: alex, #knewstuff, ngraham, nicolasfella,

D29123: WIP BUG: 420312. Do not mark entry as uninstalled if uninstallation script failed

alex updated this revision to Diff 81075. alex added a comment. Merge branch 'bugfix_uninstall' REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29123?vs=80976=81075 BRANCH bugfix_install_uninstall_messages (branched from master) REVISION DETAIL

D29149: Fix kio-extras compilation with -DQT_NO_CAST_TO_ASCII

sitter added a comment. Shouldn't we just make the entire thing QT_NO_CAST_TO_ASCII by default? REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D29149 To: dfaure, thiago, sitter Cc: kde-frameworks-devel, kfm-devel, azyx, nikolaik, pberestov, iasensio, aprcela,

D29101: KNewStuff: Fix file path and process call

alex retitled this revision from "WIP Fix file path and process call" to "KNewStuff: Fix file path and process call". REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D29101 To: alex, #knewstuff, ngraham, nicolasfella, elvisangelaccio, meven, mlaurent Cc:

D29101: WIP BUG: 420312 Fix file path and process call

alex updated this revision to Diff 81062. alex added a comment. Use KShell to split args REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29101?vs=80907=81062 BRANCH bugfix_uninstall (branched from master) REVISION DETAIL

D29101: WIP BUG: 420312 Fix file path and process call

alex edited the summary of this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D29101 To: alex, #knewstuff, ngraham, nicolasfella, elvisangelaccio, meven, mlaurent Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29149: Fix kio-extras compilation with -DQT_NO_CAST_TO_ASCII

sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. Sure, I was referring to the smb module, not even kio-extras as a whole. ^^ Anyway, diff looks reasonable. REPOSITORY R320 KIO Extras BRANCH master REVISION DETAIL

D29149: Fix kio-extras compilation with -DQT_NO_CAST_TO_ASCII

sitter added inline comments. INLINE COMMENTS > dfaure wrote in CMakeLists.txt:60 > Isn't that what I did here? Now all of kio-extras gets that flag. > > And BTW everything built by kdesrc-build actually builds with this flag > (since I have it in my kdesrc-buildrc). But that doesn't allow

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 72 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/72/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Fri, 24 Apr 2020 12:07:58 + Build duration: 24 min and counting JUnit Tests Name: projectroot

D29138: [Solid] Replace foreach (deprecated) with range/index for

ahmadsamir marked 4 inline comments as done. ahmadsamir added a comment. In D29138#656140 , @meven wrote: > In D29138#656094 , @dfaure wrote: > > > Wow those iterations over map.keys() were awful.

D28701: Add KPackage support to KNewStuffCore

leinir added inline comments. INLINE COMMENTS > mart wrote in kpackagejob.cpp:55 > is it worth encapsulating it in a runnable? the installation of a package is > already in a separathe thread. Annoyingly, the caller waits for that thread to complete, so the KPackage internals work

D29054: [Wayland] Add to PlasmaWindowManagement protocol windows stacking order

meven added inline comments. INLINE COMMENTS > plasmawindowmanagement_interface.h:76 > > + > +/** A space too many REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D29054 To: bport, zzag, davidedmundson Cc: meven, kde-frameworks-devel, LeGast00n, cblack,

D29054: [Wayland] Add to PlasmaWindowManagement protocol windows stacking order

zzag added inline comments. INLINE COMMENTS > plasma-window-management.xml:74 > > + > + To be in-line with upstream standards, please add ``. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D29054 To: bport, zzag, davidedmundson Cc: meven,

D29072: Optimize SVG

ndavis added a comment. In D29072#654363 , @guoyunhe wrote: > I do try scour but the result is disappointing. I get 16 times the following error: > > hge difference of 123 in ./icons-dark/apps/48/hwinfo.svg > > > which means 16

D24956: Consider desktop files with NoDisplay attribute

meven abandoned this revision. meven added a comment. D28856 should be preferred REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D24956 To: meven, mart, #plasma, fvogt, apol, davidedmundson Cc: davidedmundson, davidre,

D25088: Use X-KDE-NoGlobalShortcut instead of NoDisplay to store that a component is disabled

meven abandoned this revision. meven added a comment. D28856 should be preferred REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D25088 To: meven, #plasma, broulik, apol Cc: davidre, davidedmundson, kde-frameworks-devel,

D27252: add maui index icon in pm style

ndavis added a comment. @cblack is right, breeze icons tend to be sharper, but there's no rule requiring sharpness and I've accepted similar icons recently (maybe I should edit those a bit, but they're still good). However, I'm not sure how we'll differentiate this from Dolphin if we make

D29149: Fix kio-extras compilation with -DQT_NO_CAST_TO_ASCII

dfaure closed this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D29149 To: dfaure, thiago, sitter Cc: meven, kde-frameworks-devel, kfm-devel, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, cblack, fbampaloukas, alexde, Codezela,

D28470: [PlasmaCore.IconItem] Refactor source handling for different types

This revision was automatically updated to reflect the committed changes. Closed by commit R242:5a3fb570feda: [PlasmaCore.IconItem] Refactor source handling for different types (authored by kmaterka). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D7563: Add privilegeExecution field to file protocol description

ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7563 To: ngraham, #frameworks, dfaure, chinmoyr Cc: kde-frameworks-devel, feverfew, mreeves, mati865, ngraham, elvisangelaccio, LeGast00n, cblack, michaelh, bruns

D7563: Add privilegeExecution field to file protocol description

ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7563 To: ngraham, #frameworks, dfaure, chinmoyr Cc: kde-frameworks-devel, feverfew, mreeves, mati865, ngraham, elvisangelaccio, LeGast00n, cblack, michaelh, bruns

D29138: [Solid] Replace foreach (deprecated) with range/index for

ahmadsamir updated this revision to Diff 81098. ahmadsamir marked an inline comment as done. ahmadsamir added a comment. More const Optimise by iterating over QStringList, and constFind in QMap REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE

D29149: Fix kio-extras compilation with -DQT_NO_CAST_TO_ASCII

meven added a comment. In D29149#656310 , @sitter wrote: > Shouldn't we just make the entire thing QT_NO_CAST_TO_ASCII by default? It might need some work like here, so one repo at a time I would say. Even if that would a goal. We

D29149: Fix kio-extras compilation with -DQT_NO_CAST_TO_ASCII

dfaure added inline comments. INLINE COMMENTS > CMakeLists.txt:60 > > -add_definitions(-DQT_NO_URL_CAST_FROM_STRING) > +add_definitions(-DQT_NO_URL_CAST_FROM_STRING -DQT_NO_CAST_TO_ASCII) > Isn't that what I did here? Now all of kio-extras gets that flag. And BTW everything built by

D27252: add maui index icon in pm style

ndavis added inline comments. INLINE COMMENTS > ndavis wrote in index.svg:35 > This one can't be seen, so get rid of it. Just realized this comment could be easily mistaken for me saying to get rid of the shadow because of how the phabricator UI looks. I'm talking about a blue rectangle.

D29153: Move handling of untrusted programs to ApplicationLauncherJob.

dfaure created this revision. dfaure added reviewers: ahmadsamir, broulik, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY This was still in KRun so the porting to ApplicationLauncherJob

D28701: Add KPackage support to KNewStuffCore

mart added inline comments. INLINE COMMENTS > kpackagejob.cpp:55 > + > +class KPackageTask : public QObject, public QRunnable > +{ is it worth encapsulating it in a runnable? the installation of a package is already in a separathe thread. > kpackagejob.cpp:97 > +}); > +

D7563: Add privilegeExecution field to file protocol description

ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7563 To: ngraham, #frameworks, dfaure, chinmoyr Cc: kde-frameworks-devel, feverfew, mreeves, mati865, ngraham, elvisangelaccio, LeGast00n, cblack, michaelh, bruns

D28590: Add a QString Solid::Device::displayName, used in Fstab Device for network mounts

meven marked 3 inline comments as done. meven added a comment. In D28590#656297 , @bruns wrote: > In D28590#656133 , @meven wrote: > > > In D28590#654139 ,

D29153: Move handling of untrusted programs to ApplicationLauncherJob.

dfaure updated this revision to Diff 81108. dfaure added a comment. improve docu, add test in kruntest REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29153?vs=81101=81108 BRANCH 2020_04_UntrustedProgramHandler REVISION DETAIL

D28882: Create protocol to manage video feeds

apol updated this revision to Diff 81113. apol added a comment. Refactor the protocol as suggested by David and Vlad REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28882?vs=80984=81113 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28882

D29138: [Solid] Replace foreach (deprecated) with range/index for

ahmadsamir added inline comments. INLINE COMMENTS > bruns wrote in fakeopticaldisc.cpp:43 > These four lines can be written as > `content |= map.value(type, Solid::OpticalDisc::ContentType(0));` Nice. :) I think Solid::OpticalDisc::NoContent is more readable. REPOSITORY R245 Solid BRANCH

D28883: Add wrapper for wl_global_remove

This revision was automatically updated to reflect the committed changes. Closed by commit R127:c557cdba3a73: Add wrapper for wl_global_remove (authored by davidedmundson). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28883?vs=80279=81103 REVISION DETAIL

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.14 - Build # 12 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.14/12/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Fri, 24 Apr 2020 14:46:21 + Build duration: 11 min and counting JUnit Tests Name:

D29159: Optimize SVG with sour

guoyunhe added a reviewer: Breeze. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29159 To: guoyunhe, #breeze Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29153: Move handling of untrusted programs to ApplicationLauncherJob.

dfaure updated this revision to Diff 8. dfaure added a comment. Fix error message box after the user clicks Cancel. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29153?vs=81108=8 BRANCH 2020_04_UntrustedProgramHandler REVISION DETAIL

D29153: Move handling of untrusted programs to ApplicationLauncherJob.

dfaure added a reviewer: mdlubakowski. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D29153 To: dfaure, ahmadsamir, broulik, ngraham, mdlubakowski Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29138: [Solid] Replace foreach (deprecated) with range/index for

bruns added inline comments. INLINE COMMENTS > fakeopticaldisc.cpp:43 > } > } > These four lines can be written as `content |= map.value(type, Solid::OpticalDisc::ContentType(0));` REPOSITORY R245 Solid BRANCH l-foreach (branched from master) REVISION DETAIL

D28882: Create protocol to manage video feeds

apol marked an inline comment as done. apol added inline comments. INLINE COMMENTS > davidedmundson wrote in screencast.xml:31 > this is racey with create. Any suggestion on how to do it better? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D28882 To: apol, #kwin,

D29072: Optimize SVG

guoyunhe added a comment. The diff compare is based on Inkscape PNG output. And you can also check git cola's pixel diff, the diff of `icons-dark/actions/22/color-management.svg` looks like this (black means no difference): F8258009: image.png

D29159: Optimize SVG with sour

guoyunhe created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. guoyunhe requested review of this revision. REVISION SUMMARY Some icons are failed to optimize due to huge pixel difference though you cannot tell by eyes. These files are not

D29138: [Solid] Replace foreach (deprecated) with range/index for

ahmadsamir updated this revision to Diff 81121. ahmadsamir marked an inline comment as done. ahmadsamir added a comment. Make the code much shorter with map.value(key, defaultvalue), since the ContentType enum has a NoContent member REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE

D29163: WIP: Add document-replace icon (Like for Overwrite action)

davidhurka created this revision. davidhurka added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidhurka requested review of this revision. REVISION SUMMARY This adds an icon document-replace in 16px, 22px, and 32px size, which can be

D29163: WIP: Add document-replace icon (Like for Overwrite action)

davidhurka planned changes to this revision. davidhurka added a comment. The current state is as follows: F8258336: image.png F8258342: image.png All paper sheets are shrunken by 2px, and 16px and 32px got a

D28765: KSettings::Dialog: add support for KPluginInfos without a KService

dfaure added a comment. Thanks for the review! I was getting desperate to get one ;-) INLINE COMMENTS > svuorela wrote in kcmoduleinfo.cpp:73 > At a later point, I*m not sure what the purpose is for these members are - > but that's probably for another changeset. Right, I was wondering the

D29138: [Solid] Replace foreach (deprecated) with range/index for

ahmadsamir updated this revision to Diff 81131. ahmadsamir added a comment. Remove redundant lines... REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29138?vs=81121=81131 BRANCH l-foreach (branched from master) REVISION DETAIL

D29138: [Solid] Replace foreach (deprecated) with range/index for

ahmadsamir added inline comments. INLINE COMMENTS > bruns wrote in fakeopticaldisc.cpp:43 > You forgot to remove the old lines. > > Can also be applied to supportedMedia /* brown paper bag */, removed the lines. I don't see a default a-la-NoContent MediumType member. REPOSITORY R245 Solid

D29138: [Solid] Replace foreach (deprecated) with range/index for

bruns added inline comments. INLINE COMMENTS > ahmadsamir wrote in fakeopticaldisc.cpp:43 > /* brown paper bag */, removed the lines. > > I don't see a default a-la-NoContent MediumType member. Just use `0`. REPOSITORY R245 Solid BRANCH l-foreach (branched from master) REVISION DETAIL

D28765: KSettings::Dialog: add support for KPluginInfos without a KService

svuorela accepted this revision. svuorela added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kcmoduleinfo.cpp:73 > +lib = pluginInfo.libraryPath(); > +keywords = > pluginInfo.property(QStringLiteral("Keywords")).toStringList(); > } At a later

D29095: New much simpler mouse icon that works in both light and dark breeze

saligari updated this revision to Diff 81126. saligari added a comment. - a bit darker, with a more pronounced gradient effect REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29095?vs=81041=81126 BRANCH input-mouse-patch (branched from master)

D7563: Add privilegeExecution field to file protocol description

ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7563 To: ngraham, #frameworks, dfaure, chinmoyr Cc: kde-frameworks-devel, feverfew, mreeves, mati865, ngraham, elvisangelaccio, LeGast00n, cblack, michaelh, bruns

D7563: Add privilegeExecution field to file protocol description

ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7563 To: ngraham, #frameworks, dfaure, chinmoyr Cc: kde-frameworks-devel, feverfew, mreeves, mati865, ngraham, elvisangelaccio, LeGast00n, cblack, michaelh, bruns

D29163: RFC: Add document-replace icon (Like for Overwrite action)

davidhurka retitled this revision from "WIP: Add document-replace icon (Like for Overwrite action)" to "RFC: Add document-replace icon (Like for Overwrite action)". davidhurka edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL

D29138: [Solid] Replace foreach (deprecated) with range/index for

bruns added inline comments. INLINE COMMENTS > ahmadsamir wrote in fakeopticaldisc.cpp:43 > Nice. :) > > I think Solid::OpticalDisc::NoContent is more readable. You forgot to remove the old lines. Can also be applied to supportedMedia REPOSITORY R245 Solid BRANCH l-foreach (branched

D29095: New much simpler mouse icon that works in both light and dark breeze

ngraham added a comment. LGTM now! While you're at it, could you create a 32px version and replace `icons/preferences/32/preferences-desktop-mouse.svg`? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29095 To: saligari, #vdg Cc: bruns, ouwerkerk, ndavis,

D29095: New much simpler mouse icon that works in both light and dark breeze

saligari updated this revision to Diff 81138. saligari added a comment. My search on the internet told me LGTM stands for looks good to me. I added a 32px with 3px margin REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29095?vs=81126=81138 BRANCH

D29095: New much simpler mouse icon that works in both light and dark breeze

ndavis added a comment. It's a bit off center and I'd prefer if lines were more aligned with pixels. That way the icon doesn't change in how it looks when you scale it up. You may need to lighten the colors of your lines to maintain the original appearance. You see what I'm seeing? Do