ngraham added a comment.
I can confirm that this fixes https://bugs.kde.org/show_bug.cgi?id=384682.
Updating that accordingly.
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D7130
To: gregormi, ltoscano, elvisangelaccio, #kde_applications, davidedmundson,
cfeck added a comment.
This probably also fixes bug 384682. Can someone confirm?
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D7130
To: gregormi, ltoscano, elvisangelaccio, #kde_applications, davidedmundson,
ngraham
Cc: cfeck, mak, ngraham, ltoscano,
ngraham added a comment.
My pleasure. It's always nice to get bugs fixed. :)
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D7130
To: gregormi, ltoscano, elvisangelaccio, #kde_applications, davidedmundson,
ngraham
Cc: mak, ngraham, ltoscano, #frameworks
gregormi added a comment.
Thanks for committing, Nate.
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D7130
To: gregormi, ltoscano, elvisangelaccio, #kde_applications, davidedmundson,
ngraham
Cc: mak, ngraham, ltoscano, #frameworks
ltoscano added a subscriber: mak.
ltoscano added a comment.
In https://phabricator.kde.org/D7130#155151, @gregormi wrote:
> > @ltoscano, can we commit this?
>
>
>
> > I still disagree in the way this is done, as it means manually
periodically updating the information and it's
This revision was automatically updated to reflect the committed changes.
Closed by commit R304:7d3992479ea1: KMoreTools: Update and fix desktopfiles
(authored by gregormi, committed by ngraham).
REPOSITORY
R304 KNewStuff
CHANGES SINCE LAST UPDATE
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.
Derp derp derp. Works fine now.
REPOSITORY
R304 KNewStuff
BRANCH
mydev
REVISION DETAIL
https://phabricator.kde.org/D7130
To: gregormi, ltoscano, elvisangelaccio,
elvisangelaccio added a comment.
@ngraham This patch is for knewstuff :)
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D7130
To: gregormi, ltoscano, elvisangelaccio, #kde_applications, davidedmundson,
ngraham
Cc: ngraham, ltoscano, #frameworks
ngraham added a comment.
I'm afraid this still doesn't merge cleanly onto Dolphin's master branch for
me. `arc patch D7130` reports the following:
This diff is against commit e2d0a8108ec04a208d384176d53f413686ed35f2, but
the commit is nowhere in the working copy. Try to apply it
gregormi updated this revision to Diff 20781.
gregormi added a comment.
Rebase, run _update_all_files.sh and fix outdated desktop files
REPOSITORY
R304 KNewStuff
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7130?vs=17723=20781
BRANCH
mydev
REVISION DETAIL
gregormi added a comment.
> @ltoscano, can we commit this?
Hi Nate, thanks for pushing this forward.
> I still disagree in the way this is done, as it means manually periodically
updating the information and it's definitely not the right thing to do.
Hi Luigi,
I agree with
ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.
I'm afraid this doesn't merge cleanly onto master. @gregormi, can you rebase
it against current master so that I can merge it?
REPOSITORY
R304 KNewStuff
REVISION DETAIL
ngraham added a comment.
My brain knows that, but apparently my fingers didn't. :p
REPOSITORY
R304 KNewStuff
BRANCH
mydev
REVISION DETAIL
https://phabricator.kde.org/D7130
To: gregormi, ltoscano, elvisangelaccio, #kde_applications, davidedmundson,
ngraham
Cc: ngraham, ltoscano,
ngraham edited the summary of this revision.
REPOSITORY
R304 KNewStuff
BRANCH
mydev
REVISION DETAIL
https://phabricator.kde.org/D7130
To: gregormi, ltoscano, elvisangelaccio, #kde_applications, davidedmundson,
ngraham
Cc: ngraham, ltoscano, #frameworks
ltoscano added a comment.
BUG: n
REPOSITORY
R304 KNewStuff
BRANCH
mydev
REVISION DETAIL
https://phabricator.kde.org/D7130
To: gregormi, ltoscano, elvisangelaccio, #kde_applications, davidedmundson,
ngraham
Cc: ngraham, ltoscano, #frameworks
ngraham edited the summary of this revision.
REPOSITORY
R304 KNewStuff
BRANCH
mydev
REVISION DETAIL
https://phabricator.kde.org/D7130
To: gregormi, ltoscano, elvisangelaccio, #kde_applications, davidedmundson,
ngraham
Cc: ngraham, ltoscano, #frameworks
elvisangelaccio accepted this revision as: elvisangelaccio.
elvisangelaccio added a comment.
I had tested the patch and it was fixing the bug.
I'm fine with this as long as @gregormi volunteers to maintain this code
updated (and eventually to switch to a better design, if possible).
ltoscano added a comment.
The line `update desktop files including fix for PartitionManager and
KDiskFree (https://bugs.kde.org/show_bug.cgi?id=369646)` should be fixed to
have BUG:...
REPOSITORY
R304 KNewStuff
BRANCH
mydev
REVISION DETAIL
https://phabricator.kde.org/D7130
To:
ltoscano resigned from this revision.
ltoscano added a comment.
This revision is now accepted and ready to land.
I still disagree in the way this is done, as it means manually periodically
updating the information and it's definitely not the right thing to do.
That said, if
ngraham added a comment.
@ltoscano, can we commit this?
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D7130
To: gregormi, ltoscano, elvisangelaccio, #kde_applications, davidedmundson,
ngraham
Cc: ngraham, ltoscano, #frameworks
ngraham accepted this revision.
ngraham added a comment.
FWIW, this looks good to me.
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D7130
To: gregormi, ltoscano, elvisangelaccio, #kde_applications, davidedmundson,
ngraham
Cc: ngraham, ltoscano, #frameworks
ngraham added reviewers: KDE Applications, davidedmundson.
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D7130
To: gregormi, ltoscano, elvisangelaccio, #kde_applications, davidedmundson
Cc: ltoscano, #frameworks
gregormi added a comment.
In https://phabricator.kde.org/D7130#133389, @elvisangelaccio wrote:
> In https://phabricator.kde.org/D7130#132809, @gregormi wrote:
>
> > Hmm, this looks fine. Actually, KMoreTools uses KService to find out if
an application is installed by passing the
gregormi added a comment.
In https://phabricator.kde.org/D7130#132857, @ltoscano wrote:
> In https://phabricator.kde.org/D7130#132425, @gregormi wrote:
>
> > In https://phabricator.kde.org/D7130#132409, @ltoscano wrote:
> >
> > > Just update the English messages.
> > > More
elvisangelaccio added a comment.
In https://phabricator.kde.org/D7130#132809, @gregormi wrote:
> Hmm, this looks fine. Actually, KMoreTools uses KService to find out if an
application is installed by passing the desktop filename (without extension),
i.e. "org.kde.filelight" or
ltoscano added a comment.
In https://phabricator.kde.org/D7130#132425, @gregormi wrote:
> In https://phabricator.kde.org/D7130#132409, @ltoscano wrote:
>
> > Just update the English messages.
> > More generally, why do we need copies of the system desktop files (even
the
gregormi added a comment.
In https://phabricator.kde.org/D7130#132762, @elvisangelaccio wrote:
> In https://phabricator.kde.org/D7130#132742, @gregormi wrote:
>
> > In https://phabricator.kde.org/D7130#132640, @elvisangelaccio wrote:
> >
> > > It doesn't seem to fix the bug here,
elvisangelaccio added a comment.
In https://phabricator.kde.org/D7130#132742, @gregormi wrote:
> In https://phabricator.kde.org/D7130#132640, @elvisangelaccio wrote:
>
> > It doesn't seem to fix the bug here, it's still saying that filelight and
partitionmanager are not installed
gregormi added a comment.
In https://phabricator.kde.org/D7130#132640, @elvisangelaccio wrote:
> It doesn't seem to fix the bug here, it's still saying that filelight and
partitionmanager are not installed (but they are).
Can you tell me what distro you are using and maybe the
elvisangelaccio added a comment.
It doesn't seem to fix the bug here, it's still saying that filelight and
partitionmanager are not installed (but they are).
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D7130
To: gregormi, ltoscano, elvisangelaccio
Cc:
gregormi edited the summary of this revision.
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D7130
To: gregormi, ltoscano, elvisangelaccio
Cc: ltoscano, #frameworks
gregormi added a comment.
BUG: 369646
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D7130
To: gregormi, ltoscano, elvisangelaccio
Cc: ltoscano, #frameworks
gregormi added a reviewer: elvisangelaccio.
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D7130
To: gregormi, ltoscano, elvisangelaccio
Cc: ltoscano, #frameworks
gregormi edited the summary of this revision.
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D7130
To: gregormi, ltoscano
Cc: ltoscano, #frameworks
gregormi updated this revision to Diff 17723.
gregormi edited the summary of this revision.
gregormi added a comment.
- add FSearch and AngrySearch to search tools
- Add new grouping "screenrecorder" with Peek and Simples Screen Recorder
- Add new grouping "mouse-tools"
- Add new
gregormi added a comment.
In https://phabricator.kde.org/D7130#132409, @ltoscano wrote:
> Just update the English messages.
> More generally, why do we need copies of the system desktop files (even
the ones developed by KDE, org.kde.filelight.desktop?) Isn't there a way to use
the
ltoscano added a comment.
Just update the English messages.
More generally, why do we need copies of the system desktop files (even the
ones developed by KDE, org.kde.filelight.desktop?) Isn't there a way to use the
existing desktop files if installed? We don't want to duplicate what
gregormi added a comment.
In https://phabricator.kde.org/D7130#132397, @ltoscano wrote:
> I think there is more than what you want: the translations of desktop are
handled automatically by scripty.
Thanks for the hint. I copied the desktop files from the system installation.
I
gregormi retitled this revision from "Update and fix desktopfiles" to
"KMoreTools: Update and fix desktopfiles".
gregormi edited the summary of this revision.
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D7130
To: gregormi, ltoscano
Cc: ltoscano, #frameworks
39 matches
Mail list logo
