Re: [Kicad-developers] Non copper zones

2018-02-23 Thread Maciej Suminski
Sorry for late answer, I will not have a reliable Internet connection until Sunday evening. I removed the option to draw ZONE_CONTAINERs as they are dedicated to copper layers. For graphical items there is DRAWSEGMENT of POLYGON type. If you find it unacceptable, please revert the commit. I am

Re: [Kicad-developers] Non copper zones

2018-02-23 Thread Andrzej Wolski
 There are a number of missing features in the polygon tool that exist in the zone editor.  Adding corners is a large one. Cutouts would be a big regression. I think gr_poly is a single polygon and cannot have cutouts? Andrzej ___ Mailing

Re: [Kicad-developers] Non copper zones

2018-02-23 Thread Andrzej Wolski
I have just found nice bug in 4.0. If you first edit copper zone and set corner smoothing to chamfer, then you can make non copper zone with chamfered corners: https://imgur.com/a/GsLn2 Andrzej W dniu 2018-02-24 o 02:15, Seth Hillbrand pisze: Playing with the tool some more, I can see that

Re: [Kicad-developers] Nightly builds.

2018-02-23 Thread Wayne Stambaugh
Even if you could launch kicad from gdb and to a backtrace after the segfault would be helpful. I have never had any luck interrupting an running process using gdb on windows. On 02/23/2018 08:01 PM, Nick Østergaard wrote: In the installer I also tried to include gdb, such that it could

Re: [Kicad-developers] Non copper zones

2018-02-23 Thread Wayne Stambaugh
On 02/23/2018 08:24 PM, Andrzej Wolski wrote:  Does the polygon tool allow you to edit zones on non-copper layers or were zones on non-copper layers saved as polygons?  If the latter is the case then I'm guessing this change is not significant but if that is not the case then there could be

Re: [Kicad-developers] Non copper zones

2018-02-23 Thread Andrzej Wolski
 Does the polygon tool allow you to edit zones on non-copper layers or were zones on non-copper layers saved as polygons?  If the latter is the case then I'm guessing this change is not significant but if that is not the case then there could be some editing issues. Zones on non copper

Re: [Kicad-developers] Non copper zones

2018-02-23 Thread Seth Hillbrand
Playing with the tool some more, I can see that Andrzej is right. There are a number of missing features in the polygon tool that exist in the zone editor. Adding corners is a large one. If you have an existing non-copper zone, it seems you can keep it, change its layer, add cut-outs, etc.

Re: [Kicad-developers] Non copper zones

2018-02-23 Thread Andrzej Wolski
Was it ever possible to run the fill algorithm (meaning, only fill in parts of a polygon outline, based on some clearance to other items on the same layer) on a non-copper zone? No, I didn't mean it was already possible. Seth, yes I see that dialog too in old builds, but the outline

Re: [Kicad-developers] Non copper zones

2018-02-23 Thread Wayne Stambaugh
There definitely was a change in the commit that removed InvokeNonCopperZonesEditor() from the ZONE_CREATE_HELPER tool so I can see how this would be jarring for users that have been using that feature. I'm going to wait until Orson responds to my original question. If we are going to make a

Re: [Kicad-developers] Nightly builds.

2018-02-23 Thread Nick Østergaard
In the installer I also tried to include gdb, such that it could potentiallyt be possible to run kicad on windows in here, but this is not well tested. All I did was successfully make it run and break on a kicad function. I am not sure how much debugging you can actually do with that. 2018-02-23

Re: [Kicad-developers] Non copper zones

2018-02-23 Thread Andrzej Wolski
I can edit existing zones on non copper layers, but I can't place new one. What I mean is zones and polygons behave differently and I think they both should be there. But maybe I do not fully understand the intentions. Andrzej W dniu 2018-02-24 o 01:37, Wayne Stambaugh pisze: I'm seeing this

Re: [Kicad-developers] Non copper zones

2018-02-23 Thread Andrzej Wolski
But setting the width of a graphical polygon to 0 removes the size issue Andrzej mentioned. But the you don't have them with rounded corners :) For filling vs. non-filling, I don't personally see the usefulness in having the fill algorithm run over a polygon that will always be filled. 

Re: [Kicad-developers] Non copper zones

2018-02-23 Thread Wayne Stambaugh
This is what I'm trying to determine. It sounds like this was a premature assessment on my part. If this is the case, I will branch and tag rc1 now. On 02/23/2018 07:49 PM, Jon Evans wrote: Was it ever possible to run the fill algorithm (meaning, only fill in parts of a polygon outline,

Re: [Kicad-developers] Non copper zones

2018-02-23 Thread Wayne Stambaugh
Seth, So you can still edit files with zones without using the zone tool or does the polygon tool pop up for editing zones on non-copper layers? I don't have any boards with zones on non-copper layers. As long as they are still editable, then I don't see the problem. As far filled versus

Re: [Kicad-developers] Non copper zones

2018-02-23 Thread Andrzej Wolski
What behavior do you mean? In 4.0 and nightly from few days ago zones on non copper layers: - have outline drawn like zones, not like graphic polygons (I mean difference in size) - can be displayed in outline mode (hatched, fully hatched etc), polygons can't Moreover, zones have tools like

Re: [Kicad-developers] Non copper zones

2018-02-23 Thread Jon Evans
Was it ever possible to run the fill algorithm (meaning, only fill in parts of a polygon outline, based on some clearance to other items on the same layer) on a non-copper zone? I might be missing something, but from looking over the code (even back at 4.0 branch) I don't think this has ever been

Re: [Kicad-developers] Non copper zones

2018-02-23 Thread Seth Hillbrand
I have a number of zones on non-copper layers in older designs. They used to have the attached dialog. But setting the width of a graphical polygon to 0 removes the size issue Andrzej mentioned. For filling vs. non-filling, I don't personally see the usefulness in having the fill algorithm run

Re: [Kicad-developers] Non copper zones

2018-02-23 Thread Wayne Stambaugh
I'm seeing this as well. Andrzej, are you sure this is correct? Can you not edit zones on non-copper layers any longer? On 02/23/2018 07:26 PM, Jon Evans wrote: I went back to an older version of master (back around September of last year) and I can't make a zone on a non-copper layer that

Re: [Kicad-developers] Non copper zones

2018-02-23 Thread Jon Evans
I went back to an older version of master (back around September of last year) and I can't make a zone on a non-copper layer that behaves like a copper zone. Even when using the zone tool, they behave like graphic polygons. Were you able to do this up until Orson's recent change? If so, how do

Re: [Kicad-developers] Non copper zones

2018-02-23 Thread Andrzej Wolski
Polygons do work, but they are different kind of object than zones and I think they both should be there. I think zones suppose to flood, while polygons should be always solid. Polygons do not currently have "do not show filled". There are many designs which already have zones on non coppers

Re: [Kicad-developers] Non copper zones

2018-02-23 Thread Jon Evans
Yes, this is not really a bug. The behavior of the "draw polygon" tool is the same as the zone tool on non-copper layers used to be. On Fri, Feb 23, 2018 at 6:49 PM, Seth Hillbrand wrote: > The graphical polygon tool works for non-copper layers. > > Andrzej, does this

Re: [Kicad-developers] Non copper zones

2018-02-23 Thread Seth Hillbrand
The graphical polygon tool works for non-copper layers. Andrzej, does this tool not work? -S 2018-02-23 15:28 GMT-08:00 Wayne Stambaugh : > Orson, > > Is there any reason not to allow zones to be drawn on non-copper layers? > The changes you made in this commit would

Re: [Kicad-developers] Inc/DecAlpha code review patch

2018-02-23 Thread Wayne Stambaugh
On 02/23/2018 05:41 PM, Steven A. Falco wrote: > On 02/23/2018 04:05 PM, Wayne Stambaugh wrote: >> On 02/23/2018 03:43 PM, Andy Peters wrote: >>> >>> On Feb 23, 2018, at 6:05 AM, Jeff Young wrote: This patch addresses code review comments to the Inc/DecAlpha bug

Re: [Kicad-developers] Non copper zones

2018-02-23 Thread Wayne Stambaugh
Orson, Is there any reason not to allow zones to be drawn on non-copper layers? The changes you made in this commit would seem to indicate there was a reason not to allow this. I'm going to hold off on rc1 until we get this resolved. Thanks, Wayne On 02/23/2018 06:10 PM, Andrzej Wolski

[Kicad-developers] Non copper zones

2018-02-23 Thread Andrzej Wolski
Hello, after this change: https://git.launchpad.net/kicad/commit/?id=fea71c9f8f02c59a05de19293a8ce5a55432527b I can no logner draw zones on non copper layers. Was that intentional? Andrzej ___ Mailing list: https://launchpad.net/~kicad-developers

Re: [Kicad-developers] Inc/DecAlpha code review patch

2018-02-23 Thread Steven A. Falco
On 02/23/2018 04:05 PM, Wayne Stambaugh wrote: > On 02/23/2018 03:43 PM, Andy Peters wrote: >> >> >>> On Feb 23, 2018, at 6:05 AM, Jeff Young wrote: >>> >>> This patch addresses code review comments to the Inc/DecAlpha bug fix. >>> >>>

Re: [Kicad-developers] IPC-2581

2018-02-23 Thread Cirilo Bernardo
In this case the standards document IPC2581 is freely available. Some large corporations in the EU use it but otherwise adoption is a bit slow (but hey, it took IPv6 almost 20 years to get anywhere). Years ago I was hoping to find time to implement it so that anyone required to use it for work

Re: [Kicad-developers] [PATCH] Rearrange Render panel of PcbNew layer widget; add spacers

2018-02-23 Thread Eeli Kaikkonen
Oh well, I can't share with google drive... This should work better: https://drive.google.com/open?id=1G1DDjlusNYpZ63m9ymXgBXRD0isOziCz 2018-02-23 23:09 GMT+02:00 Eeli Kaikkonen : > I also think it's an improvement, something which I had in mind. As we > have seen there

Re: [Kicad-developers] [PATCH] Rearrange Render panel of PcbNew layer widget; add spacers

2018-02-23 Thread Jeff Young
My straw man would be that we need to get out of the heuristics game. When we get them wrong, customers file bugs and lose confidence in their understanding of the program. If we have a checkbox that says “Through Hole Pads”, then it should toggle the visibility of through hole pads. That

Re: [Kicad-developers] [PATCH] Rearrange Render panel of PcbNew layer widget; add spacers

2018-02-23 Thread Wayne Stambaugh
Before we do any more tweaking, we should definitely agree on the visibility behavior and stick too it. Otherwise this will be a never ending cycle of changes. I think what we have in place is a big improvement any further tweaking be put off to v6. This way we have the time to perhaps do

Re: [Kicad-developers] [PATCH] Rearrange Render panel of PcbNew layer widget; add spacers

2018-02-23 Thread Eeli Kaikkonen
I also think it's an improvement, something which I had in mind. As we have seen there are countless of details which could be changed, but it's difficult to say which are useful. For what it's worth, a bit earlier I used QtDesigner to create a mock-up widget. It has some ideas which could or

Re: [Kicad-developers] Inc/DecAlpha code review patch

2018-02-23 Thread Wayne Stambaugh
On 02/23/2018 03:43 PM, Andy Peters wrote: > > >> On Feb 23, 2018, at 6:05 AM, Jeff Young wrote: >> >> This patch addresses code review comments to the Inc/DecAlpha bug fix. >> >> <0004-Address-inc-decAlpha-bug-fix-code-review-comments.patch> > > Completely off the topic, but

Re: [Kicad-developers] [PATCH] Rearrange Render panel of PcbNew layer widget; add spacers

2018-02-23 Thread Andrzej Wolski
Actually that logic was already there, I just fixed hiding non footprint items together with pads. Andrzej W dniu 2018-02-23 o 21:46, Jon Evans pisze: I'm fine with renaming to SMD pads. Right now the logic (implemented by Andrzej, not me by the way) assumes that all pads are associated with

Re: [Kicad-developers] Hard coded hotkeys

2018-02-23 Thread hauptmech
Thanks for pointing that out. https://bugs.launchpad.net/kicad/+bug/1751183 On 24/02/18 00:38, Nick Østergaard wrote: Where is the bug report? Please link it here. I guess you just forgot it. 2018-02-23 4:35 GMT+01:00 hauptmech >: Jon

Re: [Kicad-developers] [PATCH] Rearrange Render panel of PcbNew layer widget; add spacers

2018-02-23 Thread Jon Evans
I'm fine with renaming to SMD pads. Right now the logic (implemented by Andrzej, not me by the way) assumes that all pads are associated with footprints, and if footprint display is turned off, hides pads (SMD and through hole) Seems like lots of people have different opinions on what those

Re: [Kicad-developers] Inc/DecAlpha code review patch

2018-02-23 Thread Andy Peters
> On Feb 23, 2018, at 6:05 AM, Jeff Young wrote: > > This patch addresses code review comments to the Inc/DecAlpha bug fix. > > <0004-Address-inc-decAlpha-bug-fix-code-review-comments.patch> Completely off the topic, but when I saw the subject line, I thought, “Kicad runs on

Re: [Kicad-developers] [PATCH] Rearrange Render panel of PcbNew layer widget; add spacers

2018-02-23 Thread Jeff Young
Hi Jon, Just playing with the new render palette. It’s a big improvement. However, I noted that turning off Footprints turns off through-hole pads. Since we have a separate option for that, it’s counter-intuitive to have Footprints also control it. (And, when one wants to see the copper and

Re: [Kicad-developers] Nightly builds.

2018-02-23 Thread Wayne Stambaugh
Hi Simon, Thanks. I've never used a RelWithDebInfo build. What kind of debugging info would this give me if I ran it gdb? Would it be good enough for someone to do produce useful debugging information performing a backtrace on a segfault? Wayne On 02/23/2018 12:26 PM, Simon Richter wrote: >

Re: [Kicad-developers] Nightly builds.

2018-02-23 Thread Simon Richter
Hi Wayne, On 23.02.2018 18:00, Wayne Stambaugh wrote: > Are our nightly windows builds built with debugging information? I was > just curious. The file sizes would indicate that they may be but given > the current size of the libraries it's hard to tell. Yes, the CMAKE_BUILD_TYPE is set to

[Kicad-developers] Decimal separator characters

2018-02-23 Thread Jeff Young
We had a discussion a while back about local-specific decimal characters in which JP made the point that we don’t have any use for thousands separators, and so we might as well accept either separator (. or ,). I *thought* at the time that it was mentioned that Kicad already did this, but I

[Kicad-developers] Version 5 branch update

2018-02-23 Thread Wayne Stambaugh
It's looking like I will be able to create the version 5 branch and tag rc1 this evening unless an expected critical bug pops up before then. If any of the lead developers have something they are planning on pushing, please do it in the next few hours or it will have to wait for rc2. For regular

[Kicad-developers] Nightly builds.

2018-02-23 Thread Wayne Stambaugh
Are our nightly windows builds built with debugging information? I was just curious. The file sizes would indicate that they may be but given the current size of the libraries it's hard to tell. Thanks, Wayne ___ Mailing list:

Re: [Kicad-developers] [PATCH] Rearrange Render panel of PcbNew layer widget; add spacers

2018-02-23 Thread jp charras
Le 23/02/2018 à 16:12, Jon Evans a écrit : > You can commit that, but I can't quite tell why there are two different > functions ReFillRender() and > SyncRenderStates(); they do mostly the same thing so it seems best to just > collapse them into one to > avoid bugs in the future. > The attached

Re: [Kicad-developers] [PATCH] Rearrange Render panel of PcbNew layer widget; add spacers

2018-02-23 Thread Jon Evans
You can commit that, but I can't quite tell why there are two different functions ReFillRender() and SyncRenderStates(); they do mostly the same thing so it seems best to just collapse them into one to avoid bugs in the future. The attached patch removes SyncRenderStates -- please let me know if

Re: [Kicad-developers] [PATCH] Rearrange Render panel of PcbNew layer widget; add spacers

2018-02-23 Thread jp charras
Le 23/02/2018 à 15:57, Jon Evans a écrit : > If you add a call to ReFillRender() at the top of  > PCB_LAYER_WIDGET::SyncRenderStates() instead of my > change, does it fix it? > Yes, just adding the call fixes this issue. Can I commit this fix? > On Fri, Feb 23, 2018 at 9:54 AM, jp charras

Re: [Kicad-developers] [PATCH] Rearrange Render panel of PcbNew layer widget; add spacers

2018-02-23 Thread Jon Evans
If you add a call to ReFillRender() at the top of PCB_LAYER_WIDGET::SyncRenderStates() instead of my change, does it fix it? On Fri, Feb 23, 2018 at 9:54 AM, jp charras wrote: > Le 23/02/2018 à 14:24, Jon Evans a écrit : > > Hi JP, good catch, the attached fixes it for me

Re: [Kicad-developers] [PATCH] Rearrange Render panel of PcbNew layer widget; add spacers

2018-02-23 Thread jp charras
Le 23/02/2018 à 14:24, Jon Evans a écrit : > Hi JP, good catch, the attached fixes it for me > > -Jon > > On Fri, Feb 23, 2018 at 7:18 AM, jp charras > > wrote: > > Le 23/02/2018 à 01:04, Jon Evans a écrit : > > Here are two more

Re: [Kicad-developers] [PATCH] Rearrange Render panel of PcbNew layer widget; add spacers

2018-02-23 Thread Wayne Stambaugh
Before anyone decides to take on this task, I have some very concrete ideas about creating a plot manager for creating plot tasks which will allow users (me) to set up a plot (and possibly other exports) task that includes all of the plots I use in production and perform this task with a single

Re: [Kicad-developers] [PATCH] Rearrange Render panel of PcbNew layer widget; add spacers

2018-02-23 Thread Jon Evans
Hi JP, good catch, the attached fixes it for me -Jon On Fri, Feb 23, 2018 at 7:18 AM, jp charras wrote: > Le 23/02/2018 à 01:04, Jon Evans a écrit : > > Here are two more quick patches addressing some of the easier changes. > > I have some other bugs to look at that seem

Re: [Kicad-developers] Inc/DecAlpha code review patch

2018-02-23 Thread jp charras
Le 23/02/2018 à 14:05, Jeff Young a écrit : > This patch addresses code review comments to the Inc/DecAlpha bug fix. > > Cheers, > Jeff. > I committed your patch. Thanks. -- Jean-Pierre CHARRAS ___ Mailing list:

Re: [Kicad-developers] [PATCH/RFC] Eeschema menubar

2018-02-23 Thread jp charras
Le 23/02/2018 à 13:46, Jeff Young a écrit : > This patch fixes a copy/paste compile error (Mac-only) in the menu changes. > > Cheers, > Jeff. I committed this patch. Thanks. -- Jean-Pierre CHARRAS ___ Mailing list:

[Kicad-developers] Inc/DecAlpha code review patch

2018-02-23 Thread Jeff Young
This patch addresses code review comments to the Inc/DecAlpha bug fix. 0004-Address-inc-decAlpha-bug-fix-code-review-comments.patch Description: Binary data Cheers, Jeff.___ Mailing list: https://launchpad.net/~kicad-developers Post to :

Re: [Kicad-developers] Getting kicad to work with wxPython Phoenix

2018-02-23 Thread Nick Østergaard
Hi Miles, I use archlinux and used this AUR package to install phoenix, https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=python-wxpython-phoenix Then I applied your patch and added that header file to kicad as shown on

Re: [Kicad-developers] [PATCH/RFC] Eeschema menubar

2018-02-23 Thread Jeff Young
This patch fixes a copy/paste compile error (Mac-only) in the menu changes. 0003-Fix-copy-paste-compile-error-on-Mac.patch Description: Binary data Cheers, Jeff. > On 23 Feb 2018, at 01:52, Wayne Stambaugh wrote: > > Michael, > > I merged your patches. Thank you

Re: [Kicad-developers] [PATCH] Rearrange Render panel of PcbNew layer widget; add spacers

2018-02-23 Thread jp charras
Le 23/02/2018 à 01:04, Jon Evans a écrit : > Here are two more quick patches addressing some of the easier changes. > I have some other bugs to look at that seem more urgent, so I'm not going to > work on the right-click > menu or settings persistence. > > Thanks, > Jon > Hi Jon, There is a

Re: [Kicad-developers] [PATCH] Rearrange Render panel of PcbNew layer widget; add spacers

2018-02-23 Thread Wayne Stambaugh
John, I merged your patch. Thanks. Wayne On 02/22/2018 07:04 PM, Jon Evans wrote: Here are two more quick patches addressing some of the easier changes. I have some other bugs to look at that seem more urgent, so I'm not going to work on the right-click menu or settings persistence.

Re: [Kicad-developers] kicad compile error on FreeBSD

2018-02-23 Thread jp charras
Le 23/02/2018 à 00:53, Maciej Suminski a écrit : > I am sorry about that. I swear it would not have happened if I got a > single warning message from the compiler, but both clang 4.0.0 and gcc > 7.1.1 had merrily compiled the code, so I have not expected such > problems. Thank you for quick

Re: [Kicad-developers] [PATCH] Fix assert on GerbView launch

2018-02-23 Thread jp charras
Le 23/02/2018 à 01:14, Jon Evans a écrit : > Fixing a small bug in my recently-merged patch > That'll teach me to try to do 3 things at once ;-) > I forgot this fix, and commit my own fix, that is the same! Unfortunately, not only it created an assert in Gerbview, but Gerbview crashed at start

Re: [Kicad-developers] [PATCH] Clear out old layer data when loading on top of an existing image

2018-02-23 Thread jp charras
Le 23/02/2018 à 01:34, Jon Evans a écrit : > Fixes: https://bugs.launchpad.net/kicad/+bug/1747443 > > -Jon > Thanks. I committed your fix. -- Jean-Pierre CHARRAS ___ Mailing list: https://launchpad.net/~kicad-developers Post to :

Re: [Kicad-developers] Hard coded hotkeys

2018-02-23 Thread Nick Østergaard
Where is the bug report? Please link it here. I guess you just forgot it. 2018-02-23 4:35 GMT+01:00 hauptmech : > Jon Evans, Kristoffer Ödmark, John Beard, and maybe Tomasz Włostowski > > I filed a bug report for the temporary hard-coded hotkeys that have not > been cleaned