[Kicad-developers] [proposal] pcbnew/eeschema save/copy/duplicate consistency and customary definitions

2015-03-21 Thread Chris Pavlina
Relatively simple proposals: 1. Rename 'copy' to 'duplicate' in eeschema to match pcbnew. 2. Rename 'save' to 'copy' in eeschema to match traditional usage. 3. Add default Ctrl-V keybinding to eeschema for 'paste' to match traditional usage. 4. Add 'cut' to eeschema, on Ctrl-X: - This

Re: [Kicad-developers] [PATCH] Option in eeschema to annotate keeping multi-unit parts grouped

2015-03-21 Thread Chris Pavlina
Ah, thank you for having a look. Yes, I clearly missed this use case. D'oh... I'll submit a new patch in a couple days that handles this. Any interest in including it if I get it working properly? Chris On Sat, Mar 21, 2015 at 04:44:43PM +0100, jp charras wrote: Thank for your

Re: [Kicad-developers] [PATCH] Option in eeschema to annotate keeping multi-unit parts grouped

2015-03-21 Thread Chris Pavlina
Here is a fixed version of the patch. It handled perfectly any complex hierarchies I could throw at it. Got anything worse to torture it with? Chris On Sat, Mar 21, 2015 at 04:44:43PM +0100, jp charras wrote: Le 14/03/2015 00:11, Chris Pavlina a écrit : Hello, Here is a patch for eeschema

[Kicad-developers] [PATCH] Incorrect save-on-quit in pcbnew with unsaved board

2015-03-16 Thread Chris Pavlina
In pcbnew, if you exit with a new (totally unsaved, but not empty) board open, and click 'yes' in the save-on-exit box, an error is raised due to passing an empty filename string to the save routine. Correct behavior is to execute a 'save as' if the filename is still blank. Attached is a

[Kicad-developers] [PATCH] Option in eeschema to annotate keeping multi-unit parts grouped

2015-03-13 Thread Chris Pavlina
Hello, Here is a patch for eeschema that adds Reset existing annotation, but do not swap any units to eeschema. This first compiles a list of multi-unit parts and all of the components that comprise them, and then on annotation, annotates all of them as a group. For example, if components

Re: [Kicad-developers] [proposal] Handling conflict between projname-cache.lib and an updated library

2015-03-25 Thread Chris Pavlina
Any more thoughts on this from any other devs? If nobody objects, I think I'll get started coding this up in the next day or so. -- Chris On Mon, Mar 23, 2015 at 01:27:35PM -0400, Wayne Stambaugh wrote: On 3/23/2015 1:16 PM, Chris Pavlina wrote: On Mon, Mar 23, 2015 at 01:07:33PM -0400

Re: [Kicad-developers] [patch?] Handling conflict between projname-cache.lib and an updated library

2015-03-30 Thread Chris Pavlina
Well, that was kind of the point - a stopgap for now, to keep the current way the symbols were handled from confusing people too much. I planned for it to become obsolete :D On Mon, Mar 30, 2015 at 05:55:34PM +0200, Tomasz Wlostowski wrote: On 30.03.2015 17:43, Chris Pavlina wrote: [snip

[Kicad-developers] Question on kicad-install.sh

2015-03-31 Thread Chris Pavlina
Does anyone know why kicad-install.sh does this? for p in ${prerequisite_list} do sudo apt-get install $p || exit 1 done Rather than something along the lines of this: echo ${prerequisite_list} | xargs -d\n sudo apt-get install The long prompts for permission to install each package have,

[Kicad-developers] [PATCH] Friendlier warning for modifying power values

2015-03-22 Thread Chris Pavlina
Currently, if you try to edit the value of a power component in eeschema, you get a ... is a power component and it's [sic] value cannot be modified! message. That message isn't completely accurate, though. The edit box also allows you to change the *formatting*, which is perfectly valid to

Re: [Kicad-developers] [PATCH] Option in eeschema to annotate keeping multi-unit parts grouped

2015-03-22 Thread Chris Pavlina
else to test. I tried it on every combination of hierarchical nastiness I could and it worked fine. Here's the latest version, and final if you also can't think of anything else. Thanks, Chris On Sun, Mar 22, 2015 at 04:06:57PM +0100, jp charras wrote: Le 22/03/2015 03:18, Chris Pavlina a écrit

[Kicad-developers] [proposal] Handling conflict between projname-cache.lib and an updated library

2015-03-23 Thread Chris Pavlina
When loading an old schematic, it's fairly common for it to be broken, if symbols have changed significantly in the libraries. An example: https://i.imgur.com/7cVBneA.png A workaround suggested by Wayne is to make a local copy of the projname-cache.lib file, and add it to the project as a

Re: [Kicad-developers] [proposal] Handling conflict between projname-cache.lib and an updated library

2015-03-23 Thread Chris Pavlina
, Mar 23, 2015 at 11:52:48AM -0400, Chris Pavlina wrote: When loading an old schematic, it's fairly common for it to be broken, if symbols have changed significantly in the libraries. An example: https://i.imgur.com/7cVBneA.png A workaround suggested by Wayne is to make a local copy

Re: [Kicad-developers] [proposal] Handling conflict between projname-cache.lib and an updated library

2015-03-23 Thread Chris Pavlina
On Mon, Mar 23, 2015 at 01:07:33PM -0400, Wayne Stambaugh wrote: On 3/23/2015 12:12 PM, Chris Pavlina wrote: I like your idea - I proposed it myself, but it was not well received ;) [[snip]] Please see the discussion here on why this will not work. https://bugs.launchpad.net/kicad/+bug

Re: [Kicad-developers] Feature Request: ViaStiching

2015-03-23 Thread Chris Pavlina
KiCad does not currently support standalone vias, and I think that would be a necessity before a *clean* implementation of this could be done. The only other options are to either place a /footprint/ as a via (nasty), or place a web of traces along with the vias (terribly, horribly filthy).

Re: [Kicad-developers] [patch?] Handling conflict between projname-cache.lib and an updated library

2015-04-25 Thread Chris Pavlina
the dialog is shown. There are examples of this in other kicad dialogs. * Everyone please test this thoroughly if you have any old schematics so we can be sure it's robust enough for the stable release. Thanks, Wayne On 4/12/2015 1:57 PM, Chris Pavlina wrote: And, because I'm excessively stupid

[Kicad-developers] [PATCH] lib-cache-rescue default button in dialog

2015-05-03 Thread Chris Pavlina
Here's a patch that sets the 'OK' button as default in the rescue dialog. -- Chris commit 028e30fb7d422ae2d1aa2a6bcd60c4962e7385e9 Author: Chris Pavlina cpavl...@binghamton.edu Date: Sun May 3 12:37:50 2015 -0400 Set default button in rescue dialog diff --git a/eeschema/dialogs

[Kicad-developers] [PATCH] lib-cache-rescue coding style fixes

2015-05-03 Thread Chris Pavlina
Here's a patch that fixes a few minor coding style issues with lib-cache-rescue. -- Chris commit 18380f35788821b508c4a01a420f67d17eea4d37 Author: Chris Pavlina cpavl...@binghamton.edu Date: Sun May 3 12:26:55 2015 -0400 Fix coding style Add space inside parentheses diff --git

[Kicad-developers] [PATCH] lib-cache-rescue: remove summary dialog, correct minor bug

2015-05-04 Thread Chris Pavlina
Chris Pavlina pavlina.ch...@gmail.com - * Copyright (C) 2015 Kicad Developers, see change_log.txt for contributors. - * - * This program is free software; you can redistribute it and/or - * modify it under the terms of the GNU General Public License - * as published by the Free Software Foundation

Re: [Kicad-developers] kicad main icons - minor improvements

2015-05-04 Thread Chris Pavlina
People recognize icons quickly by their silhouettes. This is already pretty hard with the existing KiCad icon set, and you're making it harder, by making so many icons into a symbol on top of paper. I agree that the icons need work, but we've got to keep good UI design practices in mind while

Re: [Kicad-developers] [PATCH] lib-cache-rescue: remove summary dialog, correct minor bug

2015-05-13 Thread Chris Pavlina
orientation against the rescued library is correct. I'll commit this patch. If you find a bug, please apply the patch against this patch. Thanks, Wayne On 5/4/2015 1:30 PM, Chris Pavlina wrote: I've got two changes here - they're a bit inadvertently intertwined, so I left them as one patch

Re: [Kicad-developers] [PATCH] lib-cache-rescue: remove summary dialog, correct minor bug

2015-05-13 Thread Chris Pavlina
: Is it possible the problem is related to the recent diode pin swapping in KiCad library? Regards, Orson On 05/13/2015 05:35 PM, Chris Pavlina wrote: Hi Wayne, That's interesting. I can't really imagine what would cause that, and I haven't seen anything like that - I've tested it on many projects

[Kicad-developers] [PATCH] Hide Power component value text cannot be modified in libedit

2015-04-17 Thread Chris Pavlina
When I submitted the patch to allow editing power component value text properties, I didn't realize that the edit dialog base class was subclassed /twice/ - I missed a required edit to the libedit subclass of it, so the Power component value text cannot be modified! warning is not properly

Re: [Kicad-developers] [patch?] Handling conflict between projname-cache.lib and an updated library

2015-04-10 Thread Chris Pavlina
it. I've got git-bisect compiles running in the background as I type. On Fri, Apr 10, 2015 at 07:15:00PM -0400, Wayne Stambaugh wrote: On 4/8/2015 8:48 PM, Chris Pavlina wrote: Any more devs have an opinion on this? I've already said it would be a good idea albeit a temporary one

[Kicad-developers] [PATCH] Correct tab order in pcbnew text properties dialog

2015-04-08 Thread Chris Pavlina
The logical flow of the Text Properties dialog in pcbnew is vertical, not horizontal, but the wx grid control naturally arranges the widgets horizontally and the tab order follows that. This means that after Size X, [tab] moves to Position X, which is unlikely to be the next desired control.

Re: [Kicad-developers] [patch?] Handling conflict between projname-cache.lib and an updated library

2015-04-08 Thread Chris Pavlina
Any more devs have an opinion on this? On Mon, Mar 30, 2015 at 02:01:07PM -0400, Wayne Stambaugh wrote: On 3/30/2015 1:58 PM, Chris Pavlina wrote: On Mar 30, 2015 1:49 PM, Wayne Stambaugh stambau...@gmail.com mailto:stambau...@gmail.com wrote: Please fix your coding style issues. I saw

[Kicad-developers] [PATCH] User Grid dimensions don't update in GAL footprint editor

2015-04-08 Thread Chris Pavlina
The User Grid dimension dialog in the footprint editor is missing the calls to update the grid in GAL, so the user grid doesn't update until you switch to a different grid and back. Here's a patch. Chris Pavlina (Ref. bug #1426098: https://bugs.launchpad.net/kicad/+bug/1426098) diff --git

[Kicad-developers] [PATCH] eeschema sheet pin width and height are swapped

2015-04-14 Thread Chris Pavlina
Tiny little bug in eeschema: when you set the height of a sheet pin text, it actually sets the width, and vice versa. diff --git a/eeschema/sheetlab.cpp b/eeschema/sheetlab.cpp index 9f90792..8a10319 100644 --- a/eeschema/sheetlab.cpp +++ b/eeschema/sheetlab.cpp @@ -94,8 +94,8 @@ int

Re: [Kicad-developers] Question on kicad-install.sh

2015-04-01 Thread Chris Pavlina
Østergaard oe.n...@gmail.com: Search the mailing list archive. Try to also use the keyword fedora when searching. I am currently not on a proper machine. Den 01/04/2015 01.48 skrev Chris Pavlina pavlina.ch...@gmail.com: Does anyone know why kicad-install.sh does this? for p in ${prerequisite_list

Re: [Kicad-developers] Schematic Symbol Philosophy?

2015-06-04 Thread Chris Pavlina
The assignment of footprints to schematic symbols is largely a KiCad quirk. Many other tools consider a component to be a single package containing symbol and footprint. In my own library I have a part per actual electronic part (one called MMBT3904, for instance), which already has the

[Kicad-developers] [PATCH] Hide pin targets when properly connected

2015-06-04 Thread Chris Pavlina
target after the connection is made) was best. Here's a patch to do this. IMO it makes the schematic look a lot cleaner in addition to helping make sure the schematic is connected correctly :) -- Chris commit ecbf90b995f609c5eab550e9941d4d8ed27ce2ed Author: Chris Pavlina cpavl...@binghamton.edu

[Kicad-developers] [PATCH] Show targets on bus entry as well, hide when connected

2015-06-08 Thread Chris Pavlina
Author: Chris Pavlina cpavl...@binghamton.edu Date: Sun Jun 7 22:02:45 2015 -0400 Show targets on bus entries diff --git a/eeschema/sch_bus_entry.cpp b/eeschema/sch_bus_entry.cpp index 227f88a..6b3e3b6 100644 --- a/eeschema/sch_bus_entry.cpp +++ b/eeschema/sch_bus_entry.cpp @@ -35,6 +35,7

Re: [Kicad-developers] Schematic Symbol Philosophy?

2015-06-08 Thread Chris Pavlina
On Mon, Jun 08, 2015 at 11:28:08PM +0200, Heiko Rosemann wrote: A given component should have exactly ONE available footprint. If your opamp comes in PDIP-8 and SOIC-8, those are two different components. Why? There's a good point for the opposite: Making different PCBs (SMD for series

[Kicad-developers] [PATCH] Refresh eeschema canvas after placing part to avoid graphic debris

2015-06-07 Thread Chris Pavlina
immediately obvious now that a part has been connected. -- Chris commit 175650781ec7dd5ec51f72bbeb8d6cf8c60677fc Author: Chris Pavlina cpavl...@binghamton.edu Date: Sun Jun 7 15:18:27 2015 -0400 Refresh canvas after placing part to avoid graphic debris diff --git a/eeschema/schframe.cpp b

Re: [Kicad-developers] Schematic Symbol Philosophy?

2015-06-05 Thread Chris Pavlina
On Fri, Jun 05, 2015 at 02:31:06PM -0400, Wayne Stambaugh wrote: On 6/5/2015 2:00 PM, Andy Peters wrote: *snip * *snip* Trying to provide a fully defined symbol for every transistor would be a huge under taking. Our solution may not be ideal but I'm not sure I want to sift through

Re: [Kicad-developers] Schematic Symbol Philosophy?

2015-06-05 Thread Chris Pavlina
Thank you for saying this - op amps are the perfect example of why relying on standard pinouts is a *terrible* idea! Let's look at a few eight-pin DIP/SOIC/TSSOP dual op amps, shall we? TL072? out in- in+ v- in+ in- out v+ LM358? out in- in+ v- in+ in- out v+ MC33078?out in- in+

Re: [Kicad-developers] [PATCH] compile broken on clang - overload conflict

2015-06-08 Thread Chris Pavlina
Nope, using a by-reference parameter does not appease clang; no idea about MSVC. On Mon, Jun 08, 2015 at 09:15:16AM -0400, Wayne Stambaugh wrote: On 6/8/2015 8:58 AM, Chris Pavlina wrote: It can't and it shouldn't - gcc is the one at fault here. wxString provides the constructor

Re: [Kicad-developers] [PATCH] compile broken on clang - overload conflict

2015-06-08 Thread Chris Pavlina
, Chris Pavlina wrote: It can't and it shouldn't - gcc is the one at fault here. wxString provides the constructor: wxString(char ch, size_t nRepeat=1) which is the one in question, I believe, as the integer literal can also represent a character. Using a reference should work

Re: [Kicad-developers] [PATCH] compile broken on clang - overload conflict

2015-06-08 Thread Chris Pavlina
(const wxString, bool); and SCH_SHEET_LIST::GetSheet(int); How can these two definitions be ambiguous? Does using a reference to the wxString instead of passing the entire string on the stack fix the problem? If so, I would prefer that fix. On 6/7/2015 9:17 PM, Chris Pavlina wrote

Re: [Kicad-developers] [PATCH] Hide pin targets when properly connected

2015-06-08 Thread Chris Pavlina
is to make it obvious to the user (IMO a good thing) that a schematic connection is or is not made, then I would rather do what makes the best user experience rather than follow some standard generated by government body and/or committee. On 6/8/2015 8:25 AM, Chris Pavlina wrote: 60617-3

Re: [Kicad-developers] [PATCH] Hide pin targets when properly connected

2015-06-08 Thread Chris Pavlina
60617-3 allows a dotless junction (as in 03-02-06), but the same connection can be represented with two 03-02-05; it is not a violation of the standard to always use dots. On Mon, Jun 08, 2015 at 08:48:12AM +0300, Vesa Solonen wrote: 08/06/15, 00:44, Wayne Stambaugh kirjoitti: One thing I

Re: [Kicad-developers] [PATCH] Hide pin targets when properly connected

2015-06-08 Thread Chris Pavlina
Yes, but we are not a small group, we are everybody who can contribute. How can an open source project implement/follow a standard when it can't make that standard available to its contributors? On Mon, Jun 08, 2015 at 05:34:46PM +0300, Vesa Solonen wrote: I generally agree with both of you,

Re: [Kicad-developers] [PATCH] GAL arc-drawing crash

2015-06-02 Thread Chris Pavlina
On 06/02/2015 05:44 PM, Chris Pavlina wrote: In GAL, an assertion (drawing_tool.cpp:925) will fail if you begin drawing an arc, and then accidentally terminate the arc at zero angle with the cursor /outside/ the arc radius. It seems that an attempt was made to check for this but the conditional wasn't

Re: [Kicad-developers] [PATCH] Show targets on bus entry as well, hide when connected

2015-06-09 Thread Chris Pavlina
it? One other thing I noticed is the bus wires (and I'm guessing bus entries as well) do not have any segment end point connection indicators. It would be nice if they supported them as well. On 6/8/2015 5:38 PM, Chris Pavlina wrote: Hi, I already sent in this patch but as a reply to my

Re: [Kicad-developers] [PATCH] Show targets on bus entry as well, hide when connected

2015-06-09 Thread Chris Pavlina
the video demo. There are examples of both cases. On 6/9/2015 3:24 PM, Chris Pavlina wrote: No, I just mean things like this: http://misc.c4757p.com/bus.png The bus is very frequently drawn past the end of a row of connections to emphasize the fact that it is a bus. (Imagine

Re: [Kicad-developers] [PATCH] Show targets on bus entry as well, hide when connected

2015-06-09 Thread Chris Pavlina
. There are examples of both cases. I don't see the problem, can you give me a more specific example? On 6/9/2015 3:24 PM, Chris Pavlina wrote: No, I just mean things like this: http://misc.c4757p.com/bus.png The bus is very frequently drawn past the end of a row of connections

[Kicad-developers] [PATCH] Fix: Also hide pin targets for junction dots

2015-06-10 Thread Chris Pavlina
Bit of a bug in my pin target hiding code: junction dots on pins should also hide the target. I forgot you can connect them that way. http://misc.c4757p.com/target_hide_bug.png This patch fixes that. -- Chris commit 7a5c65519bfa49ebc25a2c50c89d0f53ff2c86e4 Author: Chris Pavlina cpavl

Re: [Kicad-developers] [PATCH] Show targets on bus entry as well, hide when connected

2015-06-09 Thread Chris Pavlina
example of both behaviors. It's not that important but some users may wonder why the difference between wire and bus connections. It's something to think about. On 6/9/2015 2:30 PM, Chris Pavlina wrote: I'm not sure about that one - it's common to draw buses in a manner that leaves

Re: [Kicad-developers] [PATCH] Show targets on bus entry as well, hide when connected

2015-06-09 Thread Chris Pavlina
will expect. On Tue, Jun 09, 2015 at 07:44:37PM -0400, Wayne Stambaugh wrote: On 6/9/2015 4:45 PM, Chris Pavlina wrote: Okay, I see what you're talking about in the video demo. Here's a quick screenshot for those who want to follow along: http://misc.c4757p.com/video-demo-block.png Simply

Re: [Kicad-developers] [PATCH] Hide pin targets when properly connected

2015-06-07 Thread Chris Pavlina
work would be involved. I'm surprised I never noticed that before or AFAIR no one has every said anything about it. On 6/4/2015 6:21 PM, Chris Pavlina wrote: Recently a proposal was made on Launchpad for pins to indicate when they are connected: https://bugs.launchpad.net/kicad/+bug

[Kicad-developers] [PATCH] pcbnew crashes when loading file with bad net ID

2015-06-07 Thread Chris Pavlina
If you try to load a kicad_pcb into pcbnew that refers to an invalid net ID, pcbnew crashes after failing an assertion. It should display an error indicating that the file is corrupt instead. I've changed BOARD_CONNECTED_ITEM::SetNetCode() to be able to indicate whether the code was valid,

[Kicad-developers] [PATCH] compile broken on clang - overload conflict

2015-06-07 Thread Chris Pavlina
commit e950b692b8985c1c5037999b3f6936f1d1c993d3 Author: Chris Pavlina cpavl...@binghamton.edu Date: Sun Jun 7 21:14:07 2015 -0400 Resolve clang overload conflict diff --git a/eeschema/find.cpp b/eeschema/find.cpp index 74801bf..2d4b55c 100644 --- a/eeschema/find.cpp +++ b/eeschema/find.cpp

Re: [Kicad-developers] [PATCH] Hide pin targets when properly connected

2015-06-07 Thread Chris Pavlina
with the refresh patch that goes along with it for now. On 6/7/2015 6:14 PM, Chris Pavlina wrote: I could add this too. On Sun, Jun 07, 2015 at 05:44:09PM -0400, Wayne Stambaugh wrote: One thing I did notice is that bus entries do not draw the connection point so they cannot show

Re: [Kicad-developers] Build failed in Jenkins: kicad-noscript-fedora20 #421

2015-06-22 Thread Chris Pavlina
Oh look, another stupid mistake. **hands in C++ card** I'll get a patch in soon, working on fixing another bug right now. I see the problem. -- Chris On Mon, Jun 22, 2015 at 12:35:35PM -0400, Wayne Stambaugh wrote: Chris, Would you please take a look at this when you get a chance?

[Kicad-developers] [PATCH] Update dangling ends when adding no-connect

2015-06-22 Thread Chris Pavlina
Since my recent change to hide dangling ends also responds to no-connect markers, SCH_NO_CONNECT should be changed to correctly update dangling ends after it is placed. This patch accomplishes that. -- Chris commit 32d30d6b24bc75bdfa300153d5e4430a15234456 Author: Chris Pavlina cpavl

Re: [Kicad-developers] [PATCH] Fix build error from 5803

2015-06-22 Thread Chris Pavlina
Nice, I was just about to submit a second patch to fix that destructor. :) On Mon, Jun 22, 2015 at 08:36:12PM +0200, jp charras wrote: Le 22/06/2015 20:17, Chris Pavlina a écrit : Oh, wow. God, I'm a bloody idiot. Third time's the charm? On Mon, Jun 22, 2015 at 02:13:40PM -0400

Re: [Kicad-developers] [PATCH] Fix build error from 5803

2015-06-22 Thread Chris Pavlina
Uh, oops. Apparently I can't export a patch. On Mon, Jun 22, 2015 at 02:13:40PM -0400, Chris Pavlina wrote: Found the problem in the rescue update - left a couple unused variable declarations behind, which were no longer valid. Not sure why clang was okay with them, it shouldn't have been

Re: [Kicad-developers] [PATCH] Update the PCB from schematics in one click

2015-06-23 Thread Chris Pavlina
If I had to give my opinion, I'd say it still needs some work before it's ready for release. At very least, I found it rather unintuitive that it silently fails if you run it while pcbnew isn't running. Any chance of changing that, preferably so that it launches pcbnew? It has a few other

Re: [Kicad-developers] [PATCH] Remove backtracking wires in eeschema

2015-06-23 Thread Chris Pavlina
of SCH_LINE, and the behavior when it fails with dynamic_cast is a bit more obvious. I can throw an assert in there, though, that'd definitely be more correct. Modified patch attached. On Tue, Jun 23, 2015 at 09:24:36AM +0200, jp charras wrote: Le 22/06/2015 22:50, Chris Pavlina a écrit

Re: [Kicad-developers] [PATCH] Remove backtracking wires in eeschema

2015-06-23 Thread Chris Pavlina
Wow. I made enough stupid yesterday for all of us, didn't I? Here you go. I'll try to read over my code more carefully, today... On Tue, Jun 23, 2015 at 04:04:25PM +0200, jp charras wrote: Le 23/06/2015 15:19, Chris Pavlina a écrit : Sure, I can. I usually prefer to use dynamic_cast because

[Kicad-developers] Rotated pads in PNS

2015-06-23 Thread Chris Pavlina
Any thoughts on this? pns_router.cpp:212: else if( orient != 0.0 orient != 180.0 ) { // rotated pads are replaced by for the moment by circles due to my laziness ;) solid-SetShape( new SHAPE_CIRCLE( c, std::max( sz.x, sz.y ) / 2 ) ); nonOrtho = true; } It

Re: [Kicad-developers] Rotated pads in PNS

2015-06-23 Thread Chris Pavlina
On Tue, Jun 23, 2015 at 06:11:52PM +0200, Tomasz Wlostowski wrote: Chris, There is a patch by Mathias Grimberger (he sent it quite a bit of time ago), which I'm planning to integrate with PS this week, along with other, IMHO more urgent bugfixes (e.g. assert failures). Excellent! I started

[Kicad-developers] Eeschema field autoplace, rev 3

2015-06-23 Thread Chris Pavlina
application. + * + * Copyright (C) 2015 Chris Pavlina pavlina.ch...@gmail.com + * Copyright (C) 2015 KiCad Developers, see change_log.txt for contributors. + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License + * as published

Re: [Kicad-developers] [PATCH] Fix segfault on quit

2015-06-22 Thread Chris Pavlina
() from ~PGM_BASE()? On 6/22/2015 7:04 PM, Chris Pavlina wrote: Under certain (but not all) conditions, kicad applications segfault on quit. This has been reported: https://bugs.launchpad.net/kicad/+bug/1431028 https://bugs.launchpad.net/kicad/+bug/1467221 It appears to be the case

[Kicad-developers] [PATCH] Fix segfault on quit

2015-06-22 Thread Chris Pavlina
it from APP_SINGLE_TOP::OnRun() to APP_SINGLE_TOP::OnExit(), which appears to correct the issue. -- Chris commit 1fd47fa8a2bdb3daef67029ed076005e049737b7 Author: Chris Pavlina cpavl...@binghamton.edu Date: Mon Jun 22 19:01:12 2015 -0400 Move OnPgmExit to the correct place to avoid segfault

Re: [Kicad-developers] [PATCH] Fix segfault on quit

2015-06-22 Thread Chris Pavlina
Actually this might also fix the other one too, don't know. But it won't hurt to have both, so you might as well commit them for now. I'll finish investigating the other one later tonight or tomorrow. On Jun 22, 2015 19:43, Chris Pavlina pavlina.ch...@gmail.com wrote: Addition. I still haven't

Re: [Kicad-developers] [PATCH] lib-cache-rescue upgrade

2015-06-19 Thread Chris Pavlina
the footprint search dialog, someone will file a bug report about it shortly there after. :) Wayne On 6/18/2015 3:07 PM, Chris Pavlina wrote: Hi all, It's come to my attention that we have another old project compatibility issue: https://forum.kicad.info/t/exisiting-schematic

[Kicad-developers] Footprint license

2015-06-21 Thread Chris Pavlina
What is the license for the footprint libraries? These should probably have a COPYING.txt in the individual repos - I'm sure I could find the license if I searched around, but it should be right there. ___ Mailing list:

[Kicad-developers] [PATCH] Cleanup: remove unnecessary macros

2015-06-25 Thread Chris Pavlina
f96cd3a51e8c63f3f96a96d3a1e30e88723b9085 Author: Chris Pavlina cpavl...@binghamton.edu Date: Fri Jun 26 01:28:30 2015 -0400 Remove unnecessary macros EXCHG and NEGATE diff --git a/3d-viewer/3d_draw_helper_functions.cpp b/3d-viewer/3d_draw_helper_functions.cpp index 577be18..25e3e6e 100644 --- a/3d

Re: [Kicad-developers] [PATCH] Skip redundant repetition of component name in component chooser

2015-06-25 Thread Chris Pavlina
Are you positive that a better fix wouldn't be to stop putting redundant things in component descriptions? This seems like a poor way to KISS... On Thu, Jun 25, 2015 at 06:24:33PM -0700, Henner Zeller wrote: Hi, In component descriptions, often the first word in the description is a

Re: [Kicad-developers] [PATCH] Skip redundant repetition of component name in component chooser

2015-06-25 Thread Chris Pavlina
/Principle_of_least_astonishment On Thu, Jun 25, 2015 at 07:28:31PM -0700, Henner Zeller wrote: On 25 June 2015 at 19:18, Chris Pavlina pavlina.ch...@gmail.com wrote: Any chance of making it configurable? Or at least, of not being offended if I throw in a patch to do that? ;) What do you want to make

[Kicad-developers] [PATCH] Quick rescue fixes

2015-06-25 Thread Chris Pavlina
(as we're checking for more than just conflicts) and also somewhat awkward, unidiomatic GUI English; I renamed it to Project Rescue Helper. -- Chris commit b4359ade0ab17ca967338cc30b7994208481ddc9 Author: Chris Pavlina cpavl...@binghamton.edu Date: Thu Jun 25 20:26:10 2015 -0400 Rescue fixes

Re: [Kicad-developers] [PATCH] Update dangling ends when adding no-connect

2015-06-24 Thread Chris Pavlina
Haha, okay, I'll try to be more patient... On Wed, Jun 24, 2015 at 11:17:03AM -0400, Wayne Stambaugh wrote: It didn't. I'm working on it now. On 6/24/2015 11:15 AM, Chris Pavlina wrote: Quick bump, I think this patch might have got lost in Monday's patch storm :) On Mon, Jun 22

[Kicad-developers] Eeschema field autoplacing: second rev

2015-06-18 Thread Chris Pavlina
source code file is part of KiCad, a free EDA CAD application. + * + * Copyright (C) 2015 Chris Pavlina pavlina.ch...@gmail.com + * Copyright (C) 2015 KiCad Developers, see change_log.txt for contributors. + * + * This program is free software; you can redistribute it and/or + * modify it under

Re: [Kicad-developers] [PATCH] Autosave assertion failure workaround

2015-06-18 Thread Chris Pavlina
Oops, the same thing has to be applied in pcbnew. Patch attached. On Thu, Jun 18, 2015 at 02:43:56PM -0400, Wayne Stambaugh wrote: Patch committed in product branch r5782. Thanks. On 6/16/2015 11:40 AM, Chris Pavlina wrote: When eeschema attempts to autosave a schematic that hasn't been

[Kicad-developers] [PATCH] lib-cache-rescue upgrade

2015-06-18 Thread Chris Pavlina
a/eeschema/lib_cache_rescue.cpp b/eeschema/lib_cache_rescue.cpp deleted file mode 100644 index da74997..000 --- a/eeschema/lib_cache_rescue.cpp +++ /dev/null @@ -1,385 +0,0 @@ -/* - * This program source code file is part of KiCad, a free EDA CAD application. - * - * Copyright (C) 2015 Chris Pavlina

[Kicad-developers] [PATCH] Fix build error from 5803

2015-06-22 Thread Chris Pavlina
Found the problem in the rescue update - left a couple unused variable declarations behind, which were no longer valid. Not sure why clang was okay with them, it shouldn't have been. -- Chris ___ Mailing list: https://launchpad.net/~kicad-developers

Re: [Kicad-developers] [PATCH] Fix build error from 5803

2015-06-22 Thread Chris Pavlina
Oh, wow. God, I'm a bloody idiot. Third time's the charm? On Mon, Jun 22, 2015 at 02:13:40PM -0400, Chris Pavlina wrote: Found the problem in the rescue update - left a couple unused variable declarations behind, which were no longer valid. Not sure why clang was okay with them

Re: [Kicad-developers] Stable release update.

2015-06-20 Thread Chris Pavlina
On Sat, Jun 20, 2015 at 09:14:14PM +0100, David J S Briscoe wrote: [snip] I'm afraid I will screw up the files on Github so probably better for me to do it the old fashioned way. Who can I send the edited files to? If you do this, someone will have to convert them back to AsciiDoc *by hand*.

Re: [Kicad-developers] [PATCH] lib-cache-rescue upgrade

2015-06-22 Thread Chris Pavlina
No - I attached another in response to JP's recent mail about Coverity. Here it is again: Chris, Is this patch good to go? I'm having trouble keeping up with the patch volume so I want to make sure before I commit it. Thanks, Wayne On 6/18/2015 3:07 PM, Chris Pavlina wrote: Hi all, It's

Re: [Kicad-developers] Interesting compiler warning

2015-06-26 Thread Chris Pavlina
, Chris Pavlina a écrit : Hi, clang gives this warning a couple times: [ 45%] Building CXX object polygon/CMakeFiles/polygon.dir/math_for_graphics.cpp.o /home/cmp/git/kicad/polygon/math_for_graphics.cpp:71:39: warning: using integer absolute value function 'abs' when argument

[Kicad-developers] cvpcb netlist behavior

2015-06-26 Thread Chris Pavlina
Hi, Lately I've noticed a whole bunch of people coming into the IRC channel confused by the new behavior of cvpcb. Since it now pushes changes back to eeschema instead of writing a file, there is an extra step: you have to go back into eeschema and export the netlist again. A lot of people

[Kicad-developers] [PATCH] Rescue UX fixes

2015-06-27 Thread Chris Pavlina
faada345467f40e1b5b35b73b6112cc6849eb838 Author: Chris Pavlina cpavl...@binghamton.edu Date: Sat Jun 27 11:52:47 2015 -0400 Rescue improvements diff --git a/eeschema/dialogs/dialog_rescue_each.cpp b/eeschema/dialogs/dialog_rescue_each.cpp index 69fc5ec..ac804ba 100644 --- a/eeschema/dialogs/dialog_rescue_each.cpp +++ b

Re: [Kicad-developers] Questionable code

2015-06-19 Thread Chris Pavlina
deleted file mode 100644 index da74997..000 --- a/eeschema/lib_cache_rescue.cpp +++ /dev/null @@ -1,385 +0,0 @@ -/* - * This program source code file is part of KiCad, a free EDA CAD application. - * - * Copyright (C) 2015 Chris Pavlina pavlina.ch...@gmail.com - * Copyright (C) 2015 KiCad

Re: [Kicad-developers] [PATCH] Compile warning cleanups

2015-06-26 Thread Chris Pavlina
they are valid but more often than not they are benign or worse noise that distracts developers from real issues. From now until the stable release, please only post patches that fix actual bugs. Thanks, Wayne On 6/26/2015 1:58 PM, Chris Pavlina wrote: Hi, Attached are three

Re: [Kicad-developers] [PATCH] Compile warning cleanups

2015-06-26 Thread Chris Pavlina
On Fri, Jun 26, 2015 at 08:12:21PM -0400, Wayne Stambaugh wrote: On 6/26/2015 8:02 PM, Chris Pavlina wrote: The warning is definitely valid, for the reason I explained. You're comparing a negative value to a value that is allowed to (and explicitly declared to, in some compiler versions

[Kicad-developers] [PATCH] More invalid net ID crash fixes

2015-06-11 Thread Chris Pavlina
Recently I submitted a patch to catch an error that occurred when loading a kicad_pcb containing invalid net IDs; I missed a couple spots. Here's another patch to fix the rest of them. -- Chris commit 98126b8cfba53c52119f809b094cbae266b41b75 Author: Chris Pavlina cpavl...@binghamton.edu Date

[Kicad-developers] [PATCH] Autosave assertion failure workaround

2015-06-16 Thread Chris Pavlina
: Chris Pavlina cpavl...@binghamton.edu Date: Tue Jun 16 11:36:51 2015 -0400 Workaround for autosave assertion failure diff --git a/eeschema/files-io.cpp b/eeschema/files-io.cpp index 4ef6572..39922f5 100644 --- a/eeschema/files-io.cpp +++ b/eeschema/files-io.cpp @@ -509,6 +509,9 @@ bool

[Kicad-developers] [PATCH] Show bus entry joining two wires as dangling

2015-06-15 Thread Chris Pavlina
to the user that a connection has not actually been made. -- Chris commit 04217c50d45ce0ed4e291c24e559da133aa4e181 Author: Chris Pavlina cpavl...@binghamton.edu Date: Mon Jun 15 11:05:25 2015 -0400 Show bus entry joining two wires as dangling diff --git a/eeschema/sch_bus_entry.cpp b/eeschema

[Kicad-developers] LIB_TEXT bounding boxes

2015-06-16 Thread Chris Pavlina
c2a1607092013825312608a454f3861fd4b07547 Author: Chris Pavlina cpavl...@binghamton.edu Date: Tue Jun 16 17:59:28 2015 -0400 Preliminary fix for eeschema text bounding boxes diff --git a/eeschema/class_libentry.cpp b/eeschema/class_libentry.cpp index 2ba8989..81429c8 100644 --- a/eeschema

Re: [Kicad-developers] Scripting

2015-06-14 Thread Chris Pavlina
rules yet, but I really believe we should: 1) Document as we code 2) Write unit tests as we code So we avoid regressions and provide a very consistent API for the users, where we can detect regressions or any issues. Chris Pavlina wrote: wrt scripting and SWIG - SWIG's good

[Kicad-developers] Mac paths help?

2015-06-13 Thread Chris Pavlina
Hi all, I'm looking into prepopulating the list of BOM plugins in eeschema, and further possibly cleaning up resource file access in general. Can I get someone who's using kicad on Mac to run this script in the pcbnew Python console to help me out a bit? import wx; sp = wx.StandardPaths.Get()

[Kicad-developers] [PATCH] Display pin/entry targets while moving part

2015-06-14 Thread Chris Pavlina
: Chris Pavlina cpavl...@binghamton.edu Date: Sun Jun 14 15:24:47 2015 -0400 Display pin targets while dragging components and bus entries diff --git a/eeschema/sch_bus_entry.cpp b/eeschema/sch_bus_entry.cpp index 6b3e3b6..b26d5d6 100644 --- a/eeschema/sch_bus_entry.cpp +++ b/eeschema

[Kicad-developers] [PATCH] Use new footprint selector for Change Footprints

2015-06-14 Thread Chris Pavlina
6f3c07f0835898bb4cc022b45c586c4aecaef4b2 Author: Chris Pavlina cpavl...@binghamton.edu Date: Sun Jun 14 16:28:06 2015 -0400 Use new footprint selector for Change Footprints diff --git a/pcbnew/xchgmod.cpp b/pcbnew/xchgmod.cpp index 3ae43b8..a481419 100644 --- a/pcbnew/xchgmod.cpp +++ b/pcbnew

[Kicad-developers] [PATCH] Fix LIB_TEXT and LIB_FIELD bounding boxes

2015-06-17 Thread Chris Pavlina
You probably saw my thread about the bounding boxes for LIB_TEXT and LIB_FIELD, which were being merged with the main component bounding box incorrectly. I tracked down what the bug was: in ::GetBoundingBox(), the coordinates are inverted because Y coordinates for LIB_ITEMs are bottom to top.

Re: [Kicad-developers] LIB_TEXT bounding boxes

2015-06-17 Thread Chris Pavlina
) and move around some LIB_TEXT instances in a component. The vertical axis is inverted, so that when you move the text downwards, the bounding box grows upwards. On Wed, Jun 17, 2015 at 05:35:43PM +0200, jp charras wrote: Le 17/06/2015 00:11, Chris Pavlina a écrit : Hi all, While working

Re: [Kicad-developers] LIB_TEXT bounding boxes

2015-06-17 Thread Chris Pavlina
is a bug here, after I investigate further to figure out /exactly/ what the problem is. On Wed, Jun 17, 2015 at 06:29:56PM +0200, jp charras wrote: Le 17/06/2015 17:39, Chris Pavlina a écrit : Yeah, I know that much - I'm just trying to figure out where the LIB_TEXT bounding boxes are going

Re: [Kicad-developers] LIB_TEXT bounding boxes

2015-06-17 Thread Chris Pavlina
: Le 17/06/2015 17:39, Chris Pavlina a écrit : Yeah, I know that much - I'm just trying to figure out where the LIB_TEXT bounding boxes are going /wrong/. Try it - turn on the switch to view the bounding boxes (sch_component.cpp line 382, recommend changing GetBoundingBox on 385

[Kicad-developers] [PATCH] Rescue error message not shown

2015-06-13 Thread Chris Pavlina
There's a minor bug in lib_cache_rescue - if it fails to insert the new library into the project, the error message for this is not displayed. This patch adds the necessary ShowModal() call. -- Chris commit a2f938a9c25bf1273a9e7c8f8919a0e95b695ff3 Author: Chris Pavlina cpavl...@binghamton.edu

Re: [Kicad-developers] Scripting

2015-06-13 Thread Chris Pavlina
wrt scripting and SWIG - SWIG's good for generating a low-level wrapper, but if we'd like scripting to go anywhere, I really think we should come up with a more scripting-friendly API and high-level wrapper. Something with more proper iterables, fewer integer enums, fewer getters and setters,

Re: [Kicad-developers] Feature freeze.

2015-06-15 Thread Chris Pavlina
On Mon, Jun 15, 2015 at 06:29:29PM +0200, jp charras wrote: [[snip]] keywords like UNDEFINED, INFO, WARNING , ERROR are widely used, the risk of collision is high. Usually I use something like: RPT_UNDEFINED, RPT_INFO , RPT_WARNING , RPT_ERROR to avoid this risk. What about namespaces?

  1   2   3   4   5   6   7   8   9   10   >