Re: [Kicad-developers] Vacation

Excuse my RFC mail then, I promise that was the last one from my side. Enjoy your time in Europe! Cheers, Orson On 05/13/2016 03:27 PM, Wayne Stambaugh wrote: > Just a heads up for everyone. I will be leaving for Italy tomorrow for > a nice long family vacation until the 25th of May. Please

[Kicad-developers] [RFC] Undo buffer refactoring

I would like to solve once and for all the problem of GAL view/ratsnest not being occasionally updated. I am still getting related bug reports, as there are just many places in the source code that need to have "item->ViewUpdate(); ratsnest->Update(item)" added. 1. Replace UR_MODEDIT with

Re: [Kicad-developers] mode openGL issues after latest updates

On 05/03/2016 12:06 PM, Mário Luzeiro wrote: > Hi Orson, > I tested the new updates on my branch code, and now on Windows I got this > issues after I close the 3d-viewer windows: > > Error: mapping vertices buffer: invalid operation > Error: unmapping vertices buffer: invalid operation > Error:

Re: [Kicad-developers] mode openGL issues after latest updates

On 05/04/2016 11:45 AM, jp charras wrote: > Le 04/05/2016 à 11:20, Maciej Sumiński a écrit : >> On 05/03/2016 04:48 PM, Wayne Stambaugh wrote: >> [snip] >>> Not quite yet. See attached screen shot on latest msys2/mingw32. The >>> Cairo version is 1.15.2. I

Re: [Kicad-developers] mode openGL issues after latest updates

On 05/03/2016 04:48 PM, Wayne Stambaugh wrote: [snip] > Not quite yet. See attached screen shot on latest msys2/mingw32. The > Cairo version is 1.15.2. I suppose it could be the graphics drivers on > my work laptop (it's one of the Intel HD graphics chips). I'll test it > on my home system

[Kicad-developers] Missing features in GAL

Now we plan to fill the remaining gaps between the legacy and GAL canvases. I think it is a good opportunity to either improve or remove certain tools, therefore I am asking for your input. What do you think about porting the following features? Do you find them useful, maybe would you change

Re: [Kicad-developers] mode openGL issues after latest updates

Do you get any error message? I am trying hard to reproduce the problem, but none of the available PCs expose the bug. I have tried Win7 & Win10 64-bit. Both build with msys2/gcc 5.3, but I still cannot crash pcbnew. Are there any particular steps I need to perform? Open pcbnew empty? Load a

Re: [Kicad-developers] Bitmap fonts (+ dotted grid)

splay. It would also introduce another inconsistency with the legacy canvas, and I would rather avoid it at the moment. Regards, Orson > Simon > > On Tue, May 3, 2016 at 3:16 AM, Maciej Sumiński <maciej.sumin...@cern.ch> > wrote: >> As noone had opposed the changes,

Re: [Kicad-developers] mode openGL issues after latest updates

On 05/03/2016 03:23 PM, Wayne Stambaugh wrote: > On 5/3/2016 6:58 AM, jp charras wrote: >> Le 03/05/2016 à 12:06, Mário Luzeiro a écrit : >>> Hi Orson, >>> I tested the new updates on my branch code, and now on Windows I got this >>> issues after I close the 3d-viewer windows: >>> >>> Error:

Re: [Kicad-developers] Bitmap fonts (+ dotted grid)

t; * Font of RTC_INT is pretty small in comparison to GND or RXD/TXD… track > width > of RXD/TXD is the same as RTC_*. Similar for GND/+3.3V. > > > Regards, > Bernhard > > > > > >> On 02.05.2016, at 18:33, jp charras <jp.char...@wanadoo.fr >>

Re: [Kicad-developers] Bitmap fonts (+ dotted grid)

eks old and grid is fine >>> both with dots and lines. >>> >>> >>> Thanks, Bernhard. >>> >>> @Orson, >>> On wxWidgets 3.1, the dotted grid is not visible on Opengl. The line grid is >>> visible. >>> On Cairo, both are

Re: [Kicad-developers] mode openGL issues after latest updates

work with the right context. Most of the time the OpenGL canvas is shown, therefore SetCurrent() will be called. The only moment when the canvas is not shown is during the pcbnew initialization, but this case is handled by OPENGL_TEST. Regards, Orson > Mario > __

Re: [Kicad-developers] mode openGL issues after latest updates

t] on behalf of > Mário Luzeiro [mrluze...@ua.pt] > Sent: 03 May 2016 15:27 > To: Maciej Sumiński; kicad-developers@lists.launchpad.net > Subject: Re: [Kicad-developers] mode openGL issues after latest updates > > I tested (on Windows) and it works! > I didn't feel any issue

Re: [Kicad-developers] Bitmap fonts (+ dotted grid)

As noone had opposed the changes, I have just merged the bitmap fonts branch. As a small bonus, we have also added an option to switch to dotted grid in GAL (thanks to Tom for refactoring the grid drawing routine). Regards, Orson signature.asc Description: OpenPGP digital signature

Re: [Kicad-developers] Bitmap fonts

As you have already noticed - it is not. It may be moved back to noncached container and it will be redrawn every frame. Another solution is to apply dynamic scaling using shaders - it is already done for lines, so they do not disappear when their width is smaller than 1 px. Regards, Orson On

Re: [Kicad-developers] Bitmap fonts

ril 2016 11:39 > To: kicad-developers@lists.launchpad.net > Subject: Re: [Kicad-developers] Bitmap fonts > > Le 15/04/2016 11:21, Maciej Sumiński a écrit : >> On 04/14/2016 06:39 PM, Simon Richter wrote: >>> Hi, >>> >>> On 14.04.2016 11:33, Maciej Sumi

Re: [Kicad-developers] Bitmap fonts

ext chars based on the previous shader calculation :/ > ________ > From: Maciej Sumiński [maciej.sumin...@cern.ch] > Sent: 18 April 2016 15:12 > To: Mário Luzeiro; kicad-developers@lists.launchpad.net > Subject: Re: [Kicad-developers] Bitmap fonts > > Lines a

Re: [Kicad-developers] Bitmap fonts

On 04/15/2016 12:39 PM, jp charras wrote: [snip] > Orson, > > I just tested your last version, and I find the result rather good. I have just changed one more thing: now vertex data is not stored in the system memory, but in mapped video memory [1]. I hope it solves all the memory related

Re: [Kicad-developers] Bitmap fonts

On 04/15/2016 03:41 PM, "Torsten Hüter" wrote: > Hi Orson, > thanks for your nice work. I remember that we have discussed about this > subject > a few years ago - in general I think it's an advantage to > have an alternative for the stroke font. Not for performance, but for the > visual >

Re: [Kicad-developers] Bitmap fonts

Regards, Orson > Keep good work! > Mario Luzeiro > > From: Kicad-developers > [kicad-developers-bounces+mrluzeiro=ua...@lists.launchpad.net] on behalf of > Maciej Sumiński [maciej.sumin...@cern.ch] > Sent: 14 April 2016 10:33 > To: Ki

[Kicad-developers] Bitmap fonts

Hi, As recently Jean-Pierre has reported he had been running out of memory with complex boards, I decided to take another step to reduce memory footprint of OpenGL canvas. Currently, the most expensive thing to draw is stroked text, as there are lots of labels on tracks and pads. To reduce the

Re: [Kicad-developers] Bitmap fonts

On 04/14/2016 11:48 AM, Lorenzo Marcantonio wrote: > On Thu, Apr 14, 2016 at 11:33:18AM +0200, Maciej Sumiński wrote: >> Hi, >> >> As recently Jean-Pierre has reported he had been running out of memory >> with complex boards, I decided to take another step to reduce me

Re: [Kicad-developers] Bitmap fonts

) > > but if you manage to enable the midmapping in opengl and see that it works > OKs.. so I guess that it "will work for now" > .. but mind that the openGL midmapping may be an overwriten quality option by > the system configuration. > > my 2 cents (of €uro)! :P > Mario &

Re: [Kicad-developers] Bitmap fonts

On 04/14/2016 03:30 PM, jp charras wrote: [snip] > I just tested it > (note: on msys2, W7 32 bits I had a GL_INVALID_FRAMEBUFFER_OPERATION > undefined compil error) It should be fixed now. Regards, Orson signature.asc Description: OpenPGP digital signature

Re: [Kicad-developers] Bitmap fonts

but as far as I know, > most of the times they use "one font size" -> "one texture" and it is not > common to have different text scales on/using the same font/texture > Thats it why you need to go more tricky here.. :) > > Mario > _

Re: [Kicad-developers] Bitmap fonts

On 04/14/2016 03:30 PM, jp charras wrote: [snip] > Thanks, Orson. > > I just tested it > (note: on msys2, W7 32 bits I had a GL_INVALID_FRAMEBUFFER_OPERATION > undefined compil error) > > After testing a complex 16 layers board, the current version allocates up to > 128 Mbytes, and the >

Re: [Kicad-developers] Bitmap fonts

On 04/14/2016 06:39 PM, Simon Richter wrote: > Hi, > > On 14.04.2016 11:33, Maciej Sumiński wrote: > >> Currently, the most expensive thing to draw is stroked text, as there >> are lots of labels on tracks and pads. To reduce the drawing cost (and >&g

Re: [Kicad-developers] Bitmap fonts

On 04/15/2016 12:35 AM, Simon Richter wrote: > Hi, > > On 14.04.2016 20:27, Vesa Solonen wrote: > >> Orson, please have a look how rendering is done on gEDA gschem. IIRC >> font rendering is by Peter Clifton and he went on to optimize stroke >> (pixel)grid fitting, etc. The actual renderer is

Re: [Kicad-developers] Bitmap fonts

On 04/14/2016 08:27 PM, Vesa Solonen wrote: > 14/04/16, 13:00, Mário Luzeiro kirjoitti: > >> But it may suffer from scaling issues, as we can see in your screenshots in >> the very small size (they are not render properly, C2: pin 1.. etc) >> So you may need to pre-render the font in difference

Re: [Kicad-developers] Bitmap fonts

On 04/21/2016 04:52 PM, jp charras wrote: > Le 21/04/2016 16:25, Maciej Sumiński a écrit : >> I got rid off the artifacts resulting from mipmapping, and I think the >> branch [1] is ready for merging. Apart from bitmap fonts, there are also >> a few other changes that shoul

Re: [Kicad-developers] Bitmap fonts

On 04/18/2016 05:20 PM, Wayne Stambaugh wrote: [snip] > Please don't dismiss this idea too quickly. We've already discussed > using freetype to allow us to use any font even in boards. We also > already have an indirect dependency on freetype via cairo so we wouldn't > be adding much in that

[Kicad-developers] Track locking

I have noticed there is an option to mark tracks & vias as 'locked' in the legacy canvas (right click on a track->Set Flags->Track: Locked. According to my observations, it is only used by Global Deletion dialog. Should we make locked tracks & vias behave like locked modules, so they cannot be

[Kicad-developers] Copy & operator=

I am trying to understand the meaning of Copy() method defined for some of BOARD_ITEMs. I would like to replace the method with operator= to make the code clearer, and then give it consistent behavior. I have noticed that Copy() implementations differ in: - clearing Pback/Pnext fields - setting a

Re: [Kicad-developers] Integrated Simulator

On 07/23/2016 01:17 PM, jp charras wrote: > Le 22/07/2016 à 13:49, Tomasz Wlostowski a écrit : >> On 22.07.2016 13:36, jp charras wrote: >>> Le 22/07/2016 à 13:15, jp charras a écrit : Le 22/07/2016 à 11:59, Tomasz Wlostowski a écrit : > On 22.07.2016 11:56, Eldar Khayrullin wrote: >>

Re: [Kicad-developers] Integrated Simulator

Hi Tom, Thank you for the report. I have just updated the get_libngspice_so.sh [1] script. Would you try it again? Regards, Orson 1. https://orson.net.pl/pub/libngspice/get_libngspice_so.sh On 07/22/2016 03:30 PM, Tom Andrews wrote: > Hi guys, > > Thanks very much for adding this feature for

Re: [Kicad-developers] About Bug 1604841: Pcbnew crash at moving via, and boost::context fixes to make it compatible with boost 1.61

On 08/01/2016 05:15 AM, Michael Steinberg wrote: > Hey, > > pinpointing the problem proved really difficult, I didn't expect it > where it was... > This bug existed before my 1.61-patch and did not surface because > DELEGATE would not clear its content on destruction. See the attached > patch. >

Re: [Kicad-developers] Integrated Simulator

Hi Eldar, I would rather install the libraries to /usr/local, so they do not interfere with libraries installed by package managers. I guess I know what I kind of issue you have faced, and now it should be fixed in the new version get_libngspice_so.sh script [1]. Regards, Orson 1.

Re: [Kicad-developers] About Bug 1604841: Pcbnew crash at moving via, and boost::context fixes to make it compatible with boost 1.61

Hi Wayne, Jean-Pierre, Excuse my late answer, I was away for a week. I could not reproduce the problem here, so right now I am unable to say whether it fixes the recent issue. I will try again later with another virtual machine. I believe the stable branch is not affected by the bug, but we will

Re: [Kicad-developers] Testing Tom’s integrated ngspice simulator on Mac OSX

Hi Johannes, Cool! I am really grateful for your fixes - they are already merged and I am going test them with Linux and Windows. I really hope homebrew developers will accept your formula soon, as it would make getting ngspice library so much simpler. Regards, Orson On 08/01/2016 12:40 PM,

Re: [Kicad-developers] Integrated Simulator

red library has been built successfully!\e[0m > > Now, to finish the installation run the script as root with 'install' > parameter: > sudo ./get_libngspice_so.sh install > > В Понедельник, 1 авг. 2016 в 4:19 , Maciej Sumiński > <maciej.sumin...@cern.ch> написал: >>

Re: [Kicad-developers] About Bug 1604841: Pcbnew crash at moving via, and boost::context fixes to make it compatible with boost 1.61

Hi Michael, Good job, I know it was not trivial. I have just tested the patch against the same boost versions under Linux and it works as expected. Thank you for the fix, it has been committed in revision 7002. Regards, Orson On 08/02/2016 02:26 AM, Michael Steinberg wrote: > Hello all, > >

Re: [Kicad-developers] Power components vs labels

On 08/02/2016 05:30 PM, Chris Pavlina wrote: > Moving this to a new thread. > >> On 8/2/2016 7:16 AM, Chris Pavlina wrote: >>> My implementation had a large number of symbols, would have allowed >>> user-supplied arbitrary symbols if I had finished it, and automatically >>> selected a symbol

Re: [Kicad-developers] Power components vs labels

ropriate symbol based on net name, place it, rename it to the selected > net" workflow? It can sit under the P hotkey in place of the filtered > selection we have now. > > On Aug 2, 2016 11:43 AM, "Maciej Sumiński" <maciej.sumin...@cern.ch> wrote: > &

Re: [Kicad-developers] Integrated Simulator

TL;DR: I consider preparing a script that builds patched ngspice DLL to solve the problem. The bug stems from the fact that when an error occurs user is expected to answer whether the simulation should be continued with y/n. As there is no way we can answer the question when ngspice runs from a

Re: [Kicad-developers] Integrated Simulator

On 08/10/2016 02:43 PM, jp charras wrote: > Le 10/08/2016 à 10:21, jp charras a écrit : >> Le 10/08/2016 à 09:43, jp charras a écrit : >>> Le 10/08/2016 à 09:03, Maciej Sumiński a écrit : >>>> Hi Jean-Pierre, >>>> >>>> This is str

Re: [Kicad-developers] Integrated Simulator

I have just merged the ngspice branch. It is still required to enable KICAD_SPICE switch in cmake in order to use it, so it does not cause problems on systems without ngspice library installed. Regards, Orson On 08/05/2016 09:40 PM, Maciej Sumiński wrote: > I had spoken with ngspice d

Re: [Kicad-developers] [PATCH] Memoize SHAPE_LINE_CHAIN bounding box computation

Just to let you know: I had asked Tom and he had had nothing against the patch, so Chris has committed it. Regards, Orson On 08/10/2016 04:19 PM, Wayne Stambaugh wrote: > Orson & Tom, > > Please look over this patch when you get a chance to see if it makes > sense to commit it. > > Thanks, >

Re: [Kicad-developers] Git transition

On 08/10/2016 04:49 PM, Chris Pavlina wrote: [snip] > Any particular reason for having (fixes lp:) in the first > line? Typically the first line of the commit message is kept very > short and limited to things one might need when quickly browsing a > log. The usual convention in git is to

Re: [Kicad-developers] Integrated Simulator

Hi Jean-Pierre, This is strange. I had the problem you describe (Windows 7 x86_64) and fixed it in commit ee24275f [1]. Does the cursor look fine if you revert the commit? What wxWidgets & Windows versions do you use? Regards, Orson 1.

Re: [Kicad-developers] Integrated Simulator

On 08/02/2016 09:23 AM, Johannes Maibaum wrote: > Hi Orson, > >> Am 01.08.2016 um 15:08 schrieb Maciej Sumiński <maciej.sumin...@cern.ch >> <mailto:maciej.sumin...@cern.ch>>: >> >> Hi Jean-Pierre, >> >> Thank you for the wxWidgets patch, I ha

Re: [Kicad-developers] [PATCH] Remove definition of log10(double)

Thank you Simon. I have committed your patch in revision 7031. Regards, Orson On 08/12/2016 09:17 PM, Simon Richter wrote: > > This is also defined in , and likely to be a compiler intrinsic. > --- > common/widgets/mathplot.cpp | 6 -- > 1 file changed, 6 deletions(-) > > > >

Re: [Kicad-developers] Testing Tom’s integrated ngspice simulator on Mac OSX

m libs due to the bundle >> utilities cmake script bundling everything else >> >> Simon >> >> On Tue, Aug 9, 2016 at 1:43 AM, Maciej Sumiński <maciej.sumin...@cern.ch> >> wrote: >>> Hi Bernhard, >>> >>> The case is similar to othe

Re: [Kicad-developers] Git transition

On 08/11/2016 08:28 PM, Wayne Stambaugh wrote: [snip] > I'll see if I can figure out how to do this and if it works we can use > it instead of adding the bug report url to the commit message. I wonder > if we can link a commit to a bug report? That could be an issue if we > cannot. I don't want

Re: [Kicad-developers] Integrated Simulator

On 08/12/2016 04:38 PM, Wayne Stambaugh wrote: [snip] >> Hi Orson, >> >> I saw your commit. Thanks for addressing this issue in a timely mannor. >> I have on minor comment. FindFoo.cmake files should always have an >> option to override the default find location which should take >> precedence

Re: [Kicad-developers] Integrated Simulator

On 08/11/2016 05:37 PM, Wayne Stambaugh wrote: > Congratulations on everyone who made the is happen. This is a nice > feature for KiCad and hopefully users will find it useful. > > There are a few things will need to addressed that I missed when I > initially evaluated the code. > > Maybe I

[Kicad-developers] Differential pair settings per net class

There is a set of patches for the PNS router [1] coded by Tom that we would like to commit soon (a few teasers: locking tracks & vias, removing tracks while the router is active, 45-degree tuning meanders). One of the changes adds a possibility to specify differential pairs width & gap per net

Re: [Kicad-developers] Git transition

with LP until something better comes along or we take full > control a provide our own hosting. > > On 8/8/2016 3:58 AM, Maciej Sumiński wrote: >> Apparently we have not discussed git transition for a long time now, so >> I felt it is the right time to raise the subject agai

Re: [Kicad-developers] Git transition

On 08/10/2016 03:34 PM, Wayne Stambaugh wrote: > On 8/10/2016 5:02 AM, Maciej Sumiński wrote: >> On 08/08/2016 06:09 PM, Wayne Stambaugh wrote: >>> The last time I looked, notifications of repo commits still were not >>> implemented. This is a show stopper fo

Re: [Kicad-developers] KiCad New Main Icon proposal

I am in favor of pencil removal too. What do you think about keeping the page with a folded corner as the icon base, and depending on the editor: - a part of schematic (like we have now) - a single component - a part of layout (like we have now) - a single footprint to show what is the editor

Re: [Kicad-developers] Trouble with bitmapped font

I am glad that you liked it. Surprisingly, I suspected that you are going to hate the new bitmap fonts the most due to antialiasing, so I see the patches as a quite positive change. Regards, Orson On 07/05/2016 09:56 PM, Lorenzo Marcantonio wrote: > On Tue, Jul 05, 2016 at 09:21:05PM +0200,

Re: [Kicad-developers] Integrated Simulator

I had spoken with ngspice devs and they have suggested me a workaround for the bug. Unfortunately, it requires a patch that is currently not included in the release version, so we resort to building from the source again. To ease the pain, I have updated get_libngspice_so.sh [1]. Now it should

[Kicad-developers] Git transition

Apparently we have not discussed git transition for a long time now, so I felt it is the right time to raise the subject again to keep our routine. Launchpad now supports merge proposals [1] and it looks like they are still improving git integration. The only missing feature are links between bug

Re: [Kicad-developers] Testing Tom’s integrated ngspice simulator on Mac OSX

ebrew > formula. > > > Best, > Johannes > >> Am 01.08.2016 um 16:01 schrieb Adam Wolf <adamw...@feelslikeburning.com>: >> >> I'll make sure it works on the build server regardless of what homebrew does >> :) >> >> On Mon, Aug 1, 2016 at

Re: [Kicad-developers] Testing Tom’s integrated ngspice simulator on Mac OSX

>>> it won’t get merged anyhow. >>> >>> But, I have just asked the Homebrew devs if they think that a >>> separate „libngspice“ formula that just builds the library would >>> be OK for them. Let’s see what comes out of this… >>> >>

Re: [Kicad-developers] [PATCH 2/2] Avoid warning about int -> pointer conversion

On 06/30/2016 04:22 PM, Wayne Stambaugh wrote: > @Orson, please take a look at this patch and see if it makes sense when > you get a chance. It looks fine to me, but this is code that you are > more familiar with than I am. Hi Wayne, The first patch is already applied, and the second one is

Re: [Kicad-developers] replace_boost_function_boost_bind.patch: Replace boost::function and boost::bind with their std:: counterparts

On 06/28/2016 05:52 PM, Wayne Stambaugh wrote: > Orson, > > Since this mostly effects the new tool framework, I'll defer to your > judgement as to whether or not to commit this patch. I don't have a > strong opinion one way or the other since we will not be able to > completely eliminate boost

Re: [Kicad-developers] Broken setlocale in sim/ngspice.cpp

On 08/15/2016 03:03 PM, jp charras wrote: > The reason is setlocale( LC_ALL, "" ); switches the locale to the system > locale, not the previously > set locale. > It creates serious issues if the previous locale or the Kicad locale is not > the system locale. > (For instance if you are using

Re: [Kicad-developers] Differential pair settings per net class

On 08/12/2016 05:57 PM, Chris Pavlina wrote: > On Fri, Aug 12, 2016 at 05:18:57PM +0200, Maciej Sumiński wrote: >> There is a set of patches for the PNS router [1] coded by Tom that we >> would like to commit soon (a few teasers: locking tracks & vias, >> removing tracks w

Re: [Kicad-developers] Differential pair settings per net class

On 08/15/2016 04:34 PM, Wayne Stambaugh wrote: [snip] > Orson, > > Go ahead an merge this. In the short term, we can bump the rev for each > change and see how it goes. If it becomes problematic, we can readdress > it then. I don't want this to slow down development. I will say up > front,

Re: [Kicad-developers] Differential pair settings per net class

; KiCad version. > > On Mon, Aug 15, 2016 at 05:37:31PM +0200, Maciej Sumiński wrote: >> On 08/15/2016 04:34 PM, Wayne Stambaugh wrote: >> [snip] >>> Orson, >>> >>> Go ahead an merge this. In the short term, we can bump the rev for each >>> change

Re: [Kicad-developers] [PATCH v2] Complete str[n]icmp -> str[n]casecmp

Thank you Simon, I have committed your patch in revision 7060. Regards, Orson On 08/15/2016 08:51 PM, Simon Richter wrote: > > This also reverses the substitution logic if strcasecmp is missing. > --- > CMakeModules/config.h.cmake| 8 > common/class_bitmap_base.cpp

Re: [Kicad-developers] [PATCH] Add exchange footprints to GAL

Hi John, I have just pushed your patches. Once again - thank you very much! Taking into account your recent contributions, I dare to say you now deserve the GAL contributor medal. Regards, Orson On 01/31/2017 04:32 PM, John Beard wrote: > Hi, > > The attached patches add the "exchange

Re: [Kicad-developers] [PATCH] CPolyLine -> SHAPE_POLY_SET refactor

On 02/01/2017 02:36 PM, jp charras wrote: [snip] > * In GAL canvas, depending on the zoom level and the size of the filled zones > areas, filled zones > areas are displayed or not. > Same for zone outlines. Without looking at the code, my first shot is incorrect bounding box calculation

Re: [Kicad-developers] [PATCH] C++14-style std::make_unique for C++11

Hi John, I have just merged your patch, thank you for your contribution. Regards, Orson On 01/21/2017 05:38 PM, John Beard wrote: > Hi, > > This is a patch to add std::make_unique to common.h when the C++ > standard is C++11 (which it normally is for KiCad). > > This simplifies code creating

Re: [Kicad-developers] [PATCH] Move PostCommandMenuEvent to EDA_BASE_FRAME

Hi John, I have just merged your patch, thank you for your contribution. Regards, Orson On 01/23/2017 02:11 AM, John Beard wrote: > Hi, > > This is a small patch to move PostCommandMenuEvent up to > EDA_BASE_FRAME, from PCB_BASE_EDIT_FRAME. > > This function has nothing intristic to PCB edit

Re: [Kicad-developers] issues in GAL mode with event manager.

Hi Jean-Pierre, Both problems should be already fixed. Regards, Orson On 01/20/2017 09:57 AM, jp charras wrote: > Le 20/01/2017 à 09:46, Maciej Sumiński a écrit : >> Hi Jean-Pierre, >> >> Thank you for the report. I already see the first issue, the fix is in >> progre

Re: [Kicad-developers] Modedit graphical item properties dialog patch

Thank you Diogo, I have just committed your patch. Regards, Orson On 01/27/2017 09:49 PM, Diogo Condeço wrote: > From a6d5b321ca5d5a75cde7f5039bb0bd0f729454b4 Mon Sep 17 00:00:00 2001 > From: Diogo Condeco > Date: Fri, 27 Jan 2017 20:31:35 + > Subject: [PATCH] MACOS

Re: [Kicad-developers] Modedit graphical item properties dialog patch

On 01/25/2017 08:14 PM, Diogo Condeço wrote: > Hi all, > > This patch corrects the CMD+C cancel dialog bug on macos... There are still > some both in the footprint editor, and the board editor. I will try to > patch them once i can get some free time. I wonder if FixOSXCancelButtonIssue() call

Re: [Kicad-developers] Pad import/export/push and modedit mirror

Thank you John, you really help us progress towards legacy canvas removal, good job! I have just merged your patches and fixed minor code formatting violations mentioned by Wayne. Regards, Orson On 01/25/2017 08:39 AM, John Beard wrote: > Sorry, attached the wrong version of the "import export"

Re: [Kicad-developers] [PATCH] Change from EDA_COLOR_T to COLOR4D and arbitrary color support

ind changing to static consts! > > Best, > Jon > > On Mon, Feb 20, 2017 at 12:50 PM, Maciej Sumiński <maciej.sumin...@cern.ch> > wrote: > >> Hi Jon, >> >> I have just tested the patch, and I really like it. I just need to test >> it a bit lo

Re: [Kicad-developers] [PATCH] Fix layer color swatches in Linux

Wayne, I would like to merge the COLOR4D patches today, once I confirm with Jon they are complete. Regards, Orson On 02/21/2017 03:41 PM, Wayne Stambaugh wrote: > I forgot to mention that this will likely clash with the COLOR4D work > that is already in progress so we will have to coordinate

Re: [Kicad-developers] [PATCH] Refactor COMMON_ACTIONS into a base and derived class

pendencies on pcbnew that need to be resolved -- I did not >> want to take on the refactoring needed to fix this in this patch, but I >> plan on looking at it in the near future. >> >> Best, >> Jon >> >> On Mon, Feb 20, 2017 at 11:13 AM, Maciej Sumiń

Re: [Kicad-developers] [PATCH] Setting grid line sizes and density

to unbind >> from a lambda, as I suspect you are right. >> >> Cheers, >> >> John >> >> On Fri, Feb 17, 2017 at 12:23 AM, Maciej Sumiński >> <maciej.sumin...@cern.ch> wrote: >>> Hi John, >>> >>> Thank you very m

Re: [Kicad-developers] [PATCH] Refactor COMMON_ACTIONS into a base and derived class

(maybe pcb_actions.cpp or >> something in future) would need to include most of these headers so it >> can still map legacy event IDs, but that's how it should be - a file >> that needs lots, includes lots. >> >> Cheers, >> >> John >> >> >&g

Re: [Kicad-developers] [PATCH] Change from EDA_COLOR_T to COLOR4D and arbitrary color support

Hi Jon, I have just tested the patch, and I really like it. I just need to test it a bit longer, as there are numerous changes, but I am in favor of merging the patch. I also applied one more patch changing a few defines (UNSPECIFIED, BLACK, WHITE) to static consts, I hope you do not mind. If

Re: [Kicad-developers] [PATCH] Move ZoomFitScreen and ZoomPreset to common

w if this looks better. > > Best, > Jon > > On Thu, Feb 23, 2017 at 4:17 AM, Maciej Sumiński <maciej.sumin...@cern.ch> > wrote: > >> Hi Jon, >> >> I really like the generic approach in the zoom methods. This part I >> would merge instantly, but t

Re: [Kicad-developers] [PATCH] Move ZoomFitScreen and ZoomPreset to common

The previous mail had incorrect patch, please check this one. On 02/24/2017 10:16 AM, Maciej Sumiński wrote: > Hi Jon, > > The current version looks much better to me. From what I see there is no > actual bounding box caching, as GetBoundingBox() always calls > ComputeBoundingB

Re: [Kicad-developers] [PATCH] Move ZoomFitScreen and ZoomPreset to common

flag for things like BOARD. >> >> If there is no good way to implement caching, I guess another way would >> be to implement caching at the sites that use the BOARD bounding box >> heavily (autorouter etc) >> >> -Jon >> >> On Fri, Feb 24, 2017 at 9:22

Re: [Kicad-developers] [PATCH] Add cancel interactive tool to GAL

Hi John, I am really happy to see that your patching spree has not stopped. I have just committed your patch. Thank you for adding missing GAL features. Cheers, Orson On 02/24/2017 06:18 AM, John Beard wrote: > Hi, > > This adds a new action to the common ACTIONS tools: cancelInteractive. > >

Re: [Kicad-developers] [PATCH] Change reporter message of footprint missmatch to warning on netlist-import

Hi Marco, Good catch, I have just committed your patch. Thank you for your contribution. Regards, Orson On 02/22/2017 02:30 PM, Marco Sterbik wrote: > Hi, > > this patch just fixes a small thing that may irritate beginners to the > program (at least in a recent training some people were a bit

Re: [Kicad-developers] [PATCH] Fix grid sizes in GAL modedit

Thank you John, your patch has just been committed. Cheers, Orson On 02/23/2017 03:15 PM, John Beard wrote: > Hi, > > The COMMON_TOOLS GAL tool wasn't registered in modedit, so the grid > setting didn't work. > > Here's a patch. This fixes lp:1667264, possibly the tersest bug report > ever,

Re: [Kicad-developers] [PATCH] Move ZoomFitScreen and ZoomPreset to common

Hi Jon, I really like the generic approach in the zoom methods. This part I would merge instantly, but there is an issue with caching the board bounding box. It does not take into account that items already added to board may change their position and affect the bounding box. I would remove

Re: [Kicad-developers] [PATCH] Select filter dialog in GAL

l be greyed out as currently? > Perhaps the CONTEXT_MENU::HasEnabledItems could work too to delegate > the decision to the enablement functions of each item? > > Cheers, > > John > > On Thu, Feb 23, 2017 at 1:11 AM, Maciej Sumiński > <maciej.sumin...@cern.ch> w

Re: [Kicad-developers] [PATCH] Fix MacOS coroutine segfault

Hi Chris, Would you give more details about the problem? Boost version, backtrace? Regards, Orson On 02/23/2017 02:23 AM, Chris Pavlina wrote: > Hi, > > pcbnew is segfaulting on launch on my MacOS Sierra build, due to a null > dereference in the coroutine code: > > coroutine.h > 408static

Re: [Kicad-developers] [PATCH] Remove dependence on LAYER_ID from EDA_DRAW_PANEL_GAL

Hi Jon, Thank you very much, I have just committed your patch. Regards, Orson On 02/17/2017 02:02 AM, Jon Evans wrote: > Hi all, > > Another refactoring of the GAL base classes, this time to not depend on > LAYER_ID, which is specific to pcbnew. > > Best, > Jon > > > >

Re: [Kicad-developers] [PATCH] Refactor COMMON_ACTIONS into a base and derived class

Hi Jon, I see the point of your patch, as COMMON_ACTIONS are now a bit misused. They should not keep majority of the TOOL_ACTIONs, as many of them are pcbnew specific, but there are still actions that will be shared with other applications (e.g. zoom & grid control, move/rotate/flip). For some

Re: [Kicad-developers] [PATCH] Change from EDA_COLOR_T to COLOR4D and arbitrary color support

Great, so now they are in the master repository. Thank you for the patches. Regards, Orson On 02/22/2017 02:10 PM, Jon Evans wrote: > Yes, they are ready to merge. > > Best, > Jon > > On Feb 22, 2017 03:37, "Maciej Sumiński" <maciej.sumin...@cern.ch> wrote:

Re: [Kicad-developers] [PATCH] Select filter dialog in GAL

Hi Jon, Thank you very much for you help. Actually we had another idea for the selection filter [1]. We would like to have a panel in the layer widget area and filter the selection all the time, instead of after invoking a dialog. As your patch is ready at the moment, we can merge it unless

Re: [Kicad-developers] [PATCH] Update tool framework documention

Hi John, I planned to do this, but your changes are even better than what I had in mind. Thank you, your patch is already pushed with a few minor modifications in a separate commit. Cheers, Orson On 02/23/2017 04:51 AM, John Beard wrote: > Hi, > > In light of recent changes to the tool

Re: [Kicad-developers] [PATCH] hiding nets from ratsnest

Hi Julius, Thank you for the patch, but at the moment I am not sure we can push it. We would like to have the feature you implemented, but there is a new connectivity algorithm on the way, which may be much different compared to what we have now. There is also a minor bug, which causes ratsnest

<    1   2   3   4   5   6   7   8   9   >