[COMMIT master] Flush icache after dma operations for ia64

2009-06-08 Thread Avi Kivity
From: Jes Sorensen j...@sgi.com ia64 system depends on that platform issues snoop cycle to flush icache for memory touched by DMA write operations, but virtual DMA operations is emulated by memcpy, so use explict instrustions to flush the related icache, otherwise, guest may use obsolete icache.

[COMMIT master] Make qemu-kvm build and run again on ia64

2009-06-08 Thread Avi Kivity
From: Jes Sorensen j...@sgi.com Update ipf.c and Makefile.target for QEMU/ia64 to match recent changes in QEMU. Signed-off-by: Jes Sorensen j...@sgi.com Signed-off-by: Avi Kivity a...@redhat.com diff --git a/Makefile.target b/Makefile.target index 7811444..da18f48 100644 --- a/Makefile.target

[COMMIT master] KVM: ppc: e500: Add MMUCFG and PVR emulation

2009-06-08 Thread Avi Kivity
From: Liu Yu yu@freescale.com Latest kernel started to use these two registers. Signed-off-by: Liu Yu yu@freescale.com Signed-off-by: Avi Kivity a...@redhat.com diff --git a/arch/powerpc/kvm/e500_emulate.c b/arch/powerpc/kvm/e500_emulate.c index 3f76041..be95b8d 100644 ---

[COMMIT master] KVM: VMX: Rename rmode.active to rmode.vm86_active

2009-06-08 Thread Avi Kivity
From: Nitin A Kamble nitin.a.kam...@intel.com That way the interpretation of rmode.active becomes more clear with unrestricted guest code. Signed-off-by: Nitin A Kamble nitin.a.kam...@intel.com Signed-off-by: Avi Kivity a...@redhat.com diff --git a/arch/x86/include/asm/kvm_host.h

[COMMIT master] Fix include paths when the kernel source and build directory are different

2009-06-08 Thread Avi Kivity
From: James Pike ja...@chilon.net Use correct architecture includes when kernel source and build directory are different. Signed-off-by: James Pike ja...@chilon.net Acked-by: Jan Kiszka jan.kis...@siemens.com Signed-off-by: Avi Kivity a...@redhat.com diff --git a/Makefile b/Makefile index

[COMMIT master] Backwards compatibility for do_machine_check()

2009-06-08 Thread Avi Kivity
From: Avi Kivity a...@redhat.com Signed-off-by: Avi Kivity a...@redhat.com diff --git a/sync b/sync index c4c4078..b12fb8a 100755 --- a/sync +++ b/sync @@ -37,6 +37,7 @@ def __hack(data): 'on_each_cpu relay_open request_irq free_irq ' 'init_srcu_struct cleanup_srcu_struct

[COMMIT master] Update source link

2009-06-08 Thread Avi Kivity
From: Avi Kivity a...@redhat.com Signed-off-by: Avi Kivity a...@redhat.com diff --git a/linux-2.6 b/linux-2.6 index 28ddf0a..8fecb97 16 --- a/linux-2.6 +++ b/linux-2.6 @@ -1 +1 @@ -Subproject commit 28ddf0aebbf546e56efd1951725d5457ce1ebf98 +Subproject commit

[COMMIT master] Don't compile srcu on newer kernels

2009-06-08 Thread Avi Kivity
From: Avi Kivity a...@redhat.com Causes conflicts with kernel symbols. Signed-off-by: Avi Kivity a...@redhat.com diff --git a/srcu.c b/srcu.c index 3243adf..e9734bc 100644 --- a/srcu.c +++ b/srcu.c @@ -24,6 +24,8 @@ * */ +#if LINUX_VERSION_CODE KERNEL_VERSION(2,6,19) + #include

[COMMIT master] KVM: Cleanup LAPIC interface

2009-06-08 Thread Avi Kivity
From: Jan Kiszka jan.kis...@siemens.com None of the interface services the LAPIC emulation provides need to be exported to modules, and kvm_lapic_get_base is even totally unused today. Signed-off-by: Jan Kiszka jan.kis...@siemens.com Signed-off-by: Avi Kivity a...@redhat.com diff --git

[COMMIT master] KVM: make sure we select EVENTFD for any arch that declares HAVE_KVM_EVENTFD

2009-06-08 Thread Avi Kivity
From: Gregory Haskins ghask...@novell.com Signed-off-by: Gregory Haskins ghask...@novell.com Signed-off-by: Avi Kivity a...@redhat.com diff --git a/virt/kvm/Kconfig b/virt/kvm/Kconfig index b166f30..56c6848 100644 --- a/virt/kvm/Kconfig +++ b/virt/kvm/Kconfig @@ -8,3 +8,4 @@ config

[COMMIT master] KVM: introduce irq_lock, use it to protect ioapic

2009-06-08 Thread Avi Kivity
From: Marcelo Tosatti mtosa...@redhat.com Introduce irq_lock, and use to protect ioapic data structures. Signed-off-by: Marcelo Tosatti mtosa...@redhat.com Signed-off-by: Avi Kivity a...@redhat.com diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h index bcb94eb..c32df81 100644

[COMMIT master] KVM: switch irq injection/acking data structures to irq_lock

2009-06-08 Thread Avi Kivity
From: Marcelo Tosatti mtosa...@redhat.com Protect irq injection/acking data structures with a separate irq_lock mutex. This fixes the following deadlock: CPU A CPU B kvm_vm_ioctl_deassign_dev_irq() mutex_lock(kvm-lock);worker_thread() -

Re: OCFS2 file system corruption with QEMU/KVM

2009-06-08 Thread Avi Kivity
Charles Duffy wrote: Bike Snow wrote: Is anyone using OCFS2 on a SAN based setup (in my case iSCSI) for a shared storage setup for KVM? I've got a really nice setup that works really well and gives very good performance. However, the QEMU disk images (raw format) keep corrupting. Is OCFS2

Re: [PATCH 1/3] Make possible to use kvm_config as a standalone program.

2009-06-08 Thread Michael Goldish
1. It would also be nice to add a '#!/usr/bin/python' line at the beginning of the file, so I can make the file executable and run it without the 'python' prefix. 2. I think you missed the exception raised in parse_file(). 3. Wouldn't it be a good idea to define our own ConfigError exception

Re: [PATCH net-next 1/4] IPv6: HW csum support for outgoing large UFO packets

2009-06-08 Thread RĂ©mi Denis-Courmont
On Saturday 06 June 2009 03:16:27 ext Sridhar Samudrala wrote: @@ -668,7 +709,14 @@ static int udp_v6_push_pending_frames(struct sock *sk) if (is_udplite) csum = udplite_csum_outgoing(sk, skb); - else + else if (sk-sk_no_check == UDP_CSUM_NOXMIT) { /* UDP csum

Re: [Autotest] [PATCH 2/3] Fixing bad line breaks

2009-06-08 Thread Michael Goldish
1. Inside parentheses there is no need to fix anything. e.g. the following code is fine: logging.info(Copying %s.tar.bz2 to guest (file is missing or has a different size)... % test_name) and also looks cleaner than the new version with the backslash and weird

Re: [Autotest] [PATCH 3/3] Fix bad logging calls

2009-06-08 Thread Michael Goldish
format_str_for_message() is meant to be appended to the end of a string, with no spaces or newlines immediately preceding it -- its job is to add spaces or newlines as necessary. So instead of: logging.debug(Timeout elapsed or process terminated. Output: %s,

Re: [PATCH 1/3] Make possible to use kvm_config as a standalone program.

2009-06-08 Thread Michael Goldish
Small correction to 1: '#!/usr/bin/env python' instead of '#!/usr/bin/python'. I'm not really sure what's better, but we used the one with 'env' before the merge. We still use it in stepeditor. Also CCing Autotest. - Original Message - From: Michael Goldish mgold...@redhat.com To:

[GIT PULL] KVM fix for 2.6.30-rc8

2009-06-08 Thread Avi Kivity
Linus, if it's not too late, please pull git://git.kernel.org/pub/scm/virt/kvm/kvm.git kvm-updates/2.6.30 this fixes a crash during reboot with the kvm modules loaded if CONFIG_SMP is selected. If you merge the larger cpumask initializing allocator, you can drop this. Avi Kivity (1):

Re: [PATCH] fix include paths when the kernel source and build directory are different

2009-06-08 Thread Jan Kiszka
James Pike wrote: Use correct architecture includes when kernel source and build directory are different. Signed-off-by: James Pike ja...@chilon.net diff --git a/Makefile b/Makefile index 95e4c81..ad08c45 100644 --- a/Makefile +++ b/Makefile @@ -27,8 +27,9 @@ all:: prerequisite #

Re: [PATCH] fix detection of kernel source directory

2009-06-08 Thread Jan Kiszka
James Pike wrote: Fix detection of kernel source directory when it is different to build directory. Signed-off-by: James Pike ja...@chilon.net diff --git a/configure b/configure index e01ba98..c3b7a5f 100755 --- a/configure +++ b/configure @@ -91,7 +91,7 @@ arch=${arch%%-*} # see if

[PATCH -v3] KVM: Add VT-x machine check support

2009-06-08 Thread Huang Ying
From: Andi Kleen a...@linux.intel.com VT-x needs an explicit MC vector intercept to handle machine checks in the hyper visor. It also has a special option to catch machine checks that happen during VT entry. Do these interceptions and forward them to the Linux machine check handler. Make it

Re: [PATCH] fix include paths when the kernel source and build directory are different

2009-06-08 Thread Avi Kivity
James Pike wrote: Use correct architecture includes when kernel source and build directory are different. Signed-off-by: James Pike ja...@chilon.net --- a/Makefile +++ b/Makefile @@ -27,8 +27,9 @@ all:: prerequisite # include header priority 1) $LINUX 2) $KERNELDIR 3) include-compat

Re: [PATCH -v3] KVM: Add VT-x machine check support

2009-06-08 Thread Avi Kivity
Huang Ying wrote: From: Andi Kleen a...@linux.intel.com VT-x needs an explicit MC vector intercept to handle machine checks in the hyper visor. It also has a special option to catch machine checks that happen during VT entry. Do these interceptions and forward them to the Linux machine

Re: [PATCH] Fixing kvm test authorship issue

2009-06-08 Thread Michael Goldish
Hi Lucas, I'm bothering you with technicalities again unfortunately: 1. I'm not sure if it's customary to add @author tags to other modules except the main kvm.py one, but in case it is, here's what I think should be there (reflects the state of kvm_runtest_2 until before the merge with

Re: [PATCH] fix detection of kernel source directory

2009-06-08 Thread Avi Kivity
Jan Kiszka wrote: James Pike wrote: Fix detection of kernel source directory when it is different to build directory. Signed-off-by: James Pike ja...@chilon.net diff --git a/configure b/configure index e01ba98..c3b7a5f 100755 --- a/configure +++ b/configure @@ -91,7 +91,7 @@

Re: [RFC] CPU hard limits

2009-06-08 Thread Pavel Emelyanov
Paul Menage wrote: On Fri, Jun 5, 2009 at 2:59 AM, Dhaval Gianidha...@linux.vnet.ibm.com wrote: I think we are focusing on the wrong use case here. Guarantees is just a useful side-effect we get by using hard limits. I think the more important use case is where the provider wants to limit the

Re: [PATCH] kvm: x86: Cleanup LAPIC interface

2009-06-08 Thread Avi Kivity
Jan Kiszka wrote: None of the interface services the LAPIC emulation provides need to be exported to modules, and kvm_lapic_get_base is even totally unused today. Applied, thanks. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the

Re: [PATCH -v3] KVM: Add VT-x machine check support

2009-06-08 Thread Huang Ying
On Mon, 2009-06-08 at 16:48 +0800, Avi Kivity wrote: Huang Ying wrote: From: Andi Kleen a...@linux.intel.com VT-x needs an explicit MC vector intercept to handle machine checks in the hyper visor. It also has a special option to catch machine checks that happen during VT entry.

Re: [PATCH] kvm: make sure we select EVENTFD for any arch that declares HAVE_KVM_EVENTFD

2009-06-08 Thread Avi Kivity
Gregory Haskins wrote: http://lkml.org/lkml/2009/6/5/277 (It is unclear what action, if any, we also may need to address kvm-kmod for kernels prior to eventfd support (2.6.22ish)) Applied, thanks. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this

Re: linux-2.6.29-git1 + kubuntu-8.04 kvm = kernel oops

2009-06-08 Thread Avi Kivity
Adam Richter wrote: Hi everyone, I have a qcow2 image that runs fine under kubuntu 8.04 with kvm for kernels up to 2.6.29. However, for 2.6.29-git1 and every kernel that I have tried thereafter including 2.6.30-rc8-git1, I get a kernel oops when I try to run kvm on this image. From the

Re: [PATCH] fix include paths when the kernel source and build directory are different

2009-06-08 Thread Jan Kiszka
Avi Kivity wrote: James Pike wrote: Use correct architecture includes when kernel source and build directory are different. Signed-off-by: James Pike ja...@chilon.net --- a/Makefile +++ b/Makefile @@ -27,8 +27,9 @@ all:: prerequisite #include header priority 1) $LINUX 2) $KERNELDIR

Re: [PATCH 2/4] sipi and init: move common code

2009-06-08 Thread Avi Kivity
Glauber Costa wrote: provide functions to query and reset the state of sipi and init in cpu's apic. This way we can move the kvm specific functions out of the apic path. The new functions and data members are kvm specific. Please update their names to reflect that. 'sipi_needed' would

Re: [patch 0/4] move irq protection role to separate lock v4

2009-06-08 Thread Avi Kivity
Marcelo Tosatti wrote: This is to fix a deadlock reported by Alex Williamson, while at the same time makes it easier to allow PIO/MMIO regions to be registered/unregistered while a guest is alive. Applied all, thanks. I also changed the coalesced_mmio overflow check to account for

Re: [patch 1/4] KVM: MMU audit: update count_writable_mappings / count_rmaps

2009-06-08 Thread Avi Kivity
Marcelo Tosatti wrote: Under testing, count_writable_mappings returns a value that is 2 integers larger than what count_rmaps returns. Suspicion is that either of the two functions is counting a duplicate (either positively or negatively). Modifying check_writable_mappings_rmap to check for

Re: [patch 4/4] KVM: MMU audit: audit_mappings tweaks

2009-06-08 Thread Avi Kivity
Marcelo Tosatti wrote: @@ -3256,7 +3261,8 @@ static void kvm_mmu_audit(struct kvm_vcp audit_msg = msg; audit_rmap(vcpu); audit_write_protection(vcpu); - audit_mappings(vcpu); + if (strcmp(pre pte write, audit_msg)) + audit_mappings(vcpu);

[PATCH 2/4] Use pointer to vcpu instead of vcpu_id in timer code.

2009-06-08 Thread Gleb Natapov
Signed-off-by: Gleb Natapov g...@redhat.com --- arch/x86/kvm/i8254.c |2 +- arch/x86/kvm/kvm_timer.h |2 +- arch/x86/kvm/lapic.c |2 +- arch/x86/kvm/timer.c |2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/x86/kvm/i8254.c

[PATCH 0/4] decouple vcpu index from apic id

2009-06-08 Thread Gleb Natapov
Currently vcpu_id is used as an index into vcpus array and as apic id on x86. This is incorrect since apic ids not have to be continuous (they can also encode cpu hierarchy information) and may have values bigger then vcpu array in case of x2apic. This series removes use of vcpu_id as vcpus array

[PATCH 1/4] Introduce kvm_vcpu_is_bsp() function.

2009-06-08 Thread Gleb Natapov
Use it instead of open code vcpu_id zero is BSP assumption. Signed-off-by: Gleb Natapov g...@redhat.com --- arch/ia64/kvm/kvm-ia64.c |2 +- arch/ia64/kvm/vcpu.c |2 +- arch/x86/kvm/i8254.c |4 ++-- arch/x86/kvm/i8259.c |6 +++--- arch/x86/kvm/lapic.c |7

[PATCH 3/4] Break dependency between vcpu index in vcpus array and vcpu_id.

2009-06-08 Thread Gleb Natapov
Archs are free to use vcpu_id as they see fit. For x86 it is used as vcpu's apic id. New ioctl is added to configure boot vcpu id that was assumed to be 0 till now. Signed-off-by: Gleb Natapov g...@redhat.com --- include/linux/kvm.h |2 + include/linux/kvm_host.h |2 +

[PATCH 4/4] Use macro to iterate over vcpus.

2009-06-08 Thread Gleb Natapov
Signed-off-by: Gleb Natapov g...@redhat.com --- arch/ia64/kvm/kvm-ia64.c | 33 ++--- arch/powerpc/kvm/powerpc.c | 16 ++-- arch/s390/kvm/kvm-s390.c | 33 - arch/x86/kvm/i8254.c |7 ++-

Re: [PATCH] fix include paths when the kernel source and build directory are different

2009-06-08 Thread Avi Kivity
Jan Kiszka wrote: Avi Kivity wrote: James Pike wrote: Use correct architecture includes when kernel source and build directory are different. Signed-off-by: James Pike ja...@chilon.net --- a/Makefile +++ b/Makefile @@ -27,8 +27,9 @@ all:: prerequisite #include header priority 1)

Re: [KVM-AUTOTEST] [PATCH] fix a little problem for kvm_config.py

2009-06-08 Thread Michael Goldish
Looks good to me -- thanks. - Original Message - From: Yolkfull Chow yz...@redhat.com To: kvm@vger.kernel.org Cc: sudhir kumar smalik...@gmail.com, yogi anant...@linux.vnet.ibm.com, Uri Lublin u...@redhat.com, kvm@vger.kernel.org Sent: Tuesday, May 26, 2009 5:35:35 AM (GMT+0200)

Re: [PATCH -v4] KVM: Add VT-x machine check support

2009-06-08 Thread Avi Kivity
Huang Ying wrote: From: Andi Kleen a...@linux.intel.com VT-x needs an explicit MC vector intercept to handle machine checks in the hyper visor. It also has a special option to catch machine checks that happen during VT entry. Do these interceptions and forward them to the Linux machine

Log message format in KVM-Autotest

2009-06-08 Thread Michael Goldish
Hi Lucas, Before the merge with Autotest we used kvm_log.py to log formatted messages. Each message contained the current test's 'shortname' (e.g. Fedora.8.32.install), the current date and time (down to a 1 sec resolution) and the message itself. In addition, debug messages contained the name

Re: [PATCH 3/3] kvm-s390: streamline memslot handling - rebased

2009-06-08 Thread Christian Ehrhardt
Marcelo Tosatti wrote: On Tue, Jun 02, 2009 at 04:26:11PM +0200, ehrha...@linux.vnet.ibm.com wrote: From: Christian Ehrhardt ehrha...@linux.vnet.ibm.com [...] @@ -706,13 +713,19 @@ int kvm_arch_set_memory_region(struct kv /* request update of sie control block for all available

Re: strange guest slowness after some time

2009-06-08 Thread Felix Leimbach
Tomasz Chmielewski wrote: Felix Leimbach schrieb: BTW, what CPU do you have? One dual core Opteron 2212 Note: I will upgrade to two Shanghai Quad-Cores in 2 weeks and test with those as well. processor : 1 vendor_id : AuthenticAMD cpu family : 15 model : 65 model

Re: [PATCH 3/3] kvm-s390: streamline memslot handling - rebased

2009-06-08 Thread Avi Kivity
Christian Ehrhardt wrote: Really need that smp_mb__after_clear_bit ? AFAIK test_and_clear_bit implies a barrier? Well I agree that practically test_and_clear_bit has a barrier on s390, but as far as I read Documentation/atomic_ops.txt at line 339-360 I think the interface does not

Re: [PATCH 1/4] Introduce kvm_vcpu_is_bsp() function.

2009-06-08 Thread Avi Kivity
Gleb Natapov wrote: @@ -130,6 +130,7 @@ struct kvm { int nmemslots; struct kvm_memory_slot memslots[KVM_MEMORY_SLOTS + KVM_PRIVATE_MEM_SLOTS]; + struct kvm_vcpu *bsp_vcpu; struct kvm_vcpu *vcpus[KVM_MAX_VCPUS]; struct

Re: [PATCH 3/4] Break dependency between vcpu index in vcpus array and vcpu_id.

2009-06-08 Thread Avi Kivity
Gleb Natapov wrote: Archs are free to use vcpu_id as they see fit. For x86 it is used as vcpu's apic id. New ioctl is added to configure boot vcpu id that was assumed to be 0 till now. @@ -2284,6 +2291,7 @@ static long kvm_dev_ioctl_check_extension_generic(long arg) case

Re: [PATCH 0/4] decouple vcpu index from apic id

2009-06-08 Thread Avi Kivity
Gleb Natapov wrote: Currently vcpu_id is used as an index into vcpus array and as apic id on x86. This is incorrect since apic ids not have to be continuous (they can also encode cpu hierarchy information) and may have values bigger then vcpu array in case of x2apic. This series removes use of

Re: [PATCH] cleanup acpi table creation

2009-06-08 Thread Avi Kivity
Gleb Natapov wrote: Current code is a mess. And addition of acpi tables is broken. Sorry, this patch is impossible to review. Please send the shortest possible fix, even if it remains hacky. We'll switch to seabios as soon as possible, so I don't think it makes sense to clean this up.

Re: [PATCH] cleanup acpi table creation

2009-06-08 Thread Gleb Natapov
On Mon, Jun 08, 2009 at 02:29:16PM +0300, Avi Kivity wrote: Gleb Natapov wrote: Current code is a mess. And addition of acpi tables is broken. Sorry, this patch is impossible to review. Please send the shortest possible fix, even if it remains hacky. We'll switch to seabios as soon

Re: [PATCH 3/3] kvm-s390: streamline memslot handling - rebased

2009-06-08 Thread Christian Ehrhardt
Avi Kivity wrote: Christian Ehrhardt wrote: Really need that smp_mb__after_clear_bit ? AFAIK test_and_clear_bit implies a barrier? Well I agree that practically test_and_clear_bit has a barrier on s390, but as far as I read Documentation/atomic_ops.txt at line 339-360 I think the

Re: systemcalls and kvm ...correct me if I am wrong

2009-06-08 Thread Matteo Signorini
My doubt is: will int0x80 from Guest userspace bring me into Guest kernel space or directly into kvm in the Host kernel? How can I trigger a jump from Guest to Host kvm at will? Then the way back from host kernel to guest is via vmenter/vmrun or must be performed in a different way? thanks in

Re: [PATCH 3/3] kvm-s390: streamline memslot handling - rebased

2009-06-08 Thread Avi Kivity
Christian Ehrhardt wrote: Hmm ... would that be worth a clarifying patch to atomic_ops.txt that confused me in the first place ? If it confused you, it probably confuses others. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line

Re: systemcalls and kvm ...correct me if I am wrong

2009-06-08 Thread Avi Kivity
Matteo Signorini wrote: My doubt is: will int0x80 from Guest userspace bring me into Guest kernel space or directly into kvm in the Host kernel? Like I mentioned, guest kernel. How can I trigger a jump from Guest to Host kvm at will? mmio/pio/vmcall Then the way back from host

Re: [PATCH 2/2] Advertise X2APIC support.

2009-06-08 Thread Avi Kivity
Gleb Natapov wrote: #define MSR_MTRRcap 0xfe diff --git a/target-i386/helper.c b/target-i386/helper.c index 23efcf4..170c3f7 100644 --- a/target-i386/helper.c +++ b/target-i386/helper.c @@ -148,7 +148,7 @@ static x86_def_t x86_defs[] = { CPUID_MTRR | CPUID_CLFLUSH | CPUID_MCA |

[ kvm-Bugs-2506814 ] TAP network lockup after some traffic

2009-06-08 Thread SourceForge.net
Bugs item #2506814, was opened at 2009-01-14 11:38 Message generated for change (Comment added) made by mellen You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=893831aid=2506814group_id=180599 Please note that this message will contain a full copy of the comment

[PATCH 0/2] Large page fixes

2009-06-08 Thread Avi Kivity
Couple of random large page fixes for review. Avi Kivity (2): KVM: Disable large pages on misaligned memory slots KVM: Prevent overflow in largepages calculation virt/kvm/kvm_main.c | 13 ++--- 1 files changed, 10 insertions(+), 3 deletions(-) -- To unsubscribe from this list:

[PATCH 2/2] KVM: Prevent overflow in largepages calculation

2009-06-08 Thread Avi Kivity
If userspace specifies a memory slot that is larger than 8 petabytes, it could overflow the largepages variable. Signed-off-by: Avi Kivity a...@redhat.com --- virt/kvm/kvm_main.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c

[PATCH 1/2] KVM: Disable large pages on misaligned memory slots

2009-06-08 Thread Avi Kivity
If a slots guest physical address and host virtual address unequal (mod large page size), then we would erronously try to back guest large pages with host large pages. Detect this misalignment and diable large page support for the trouble slot. Signed-off-by: Avi Kivity a...@redhat.com ---

Re: Log message format in KVM-Autotest

2009-06-08 Thread Lucas Meneghel Rodrigues
On Mon, 2009-06-08 at 06:35 -0400, Michael Goldish wrote: Hi Lucas, Before the merge with Autotest we used kvm_log.py to log formatted messages. Each message contained the current test's 'shortname' (e.g. Fedora.8.32.install), the current date and time (down to a 1 sec resolution) and

Re: [PATCH 0/2] Large page fixes

2009-06-08 Thread Marcelo Tosatti
On Mon, Jun 08, 2009 at 04:is_largepage_backed00:08PM +0300, Avi Kivity wrote: Couple of random large page fixes for review. Avi Kivity (2): KVM: Disable large pages on misaligned memory slots KVM: Prevent overflow in largepages calculation virt/kvm/kvm_main.c | 13 ++---

Re: [PATCH 0/2] Large page fixes

2009-06-08 Thread Avi Kivity
Marcelo Tosatti wrote: On Mon, Jun 08, 2009 at 04:is_largepage_backed00:08PM +0300, Avi Kivity wrote: Couple of random large page fixes for review. Avi Kivity (2): KVM: Disable large pages on misaligned memory slots KVM: Prevent overflow in largepages calculation virt/kvm/kvm_main.c |

Re: [PATCH RFC] qemu: fix hot remove assigned device

2009-06-08 Thread Paul Brook
On Monday 08 June 2009, Weidong Han wrote: When hot remove an assigned device, segmentation fault was triggered by qemu_free(pci_dev-qdev) in pci_unregister_device(). pci_register_device() doesn't initialize or set pci_dev-qdev. For an assigned device, qdev variable isn't touched at all. So

Re: [KVM-AUTOTEST PATCH 2/8] RHEL-4.7 step files: fix the initial boot barriers

2009-06-08 Thread Lucas Meneghel Rodrigues
On Mon, 2009-06-08 at 01:01 -0300, Lucas Meneghel Rodrigues wrote: Fix the first barrier to include the 'boot:' prompt. This is crucial because the guest accepts keyboard input only after this prompt appears. Applied. Visibility: Small (Data file on the kvm test) Risk: Low (Small, tested

Re: [KVM-AUTOTEST PATCH 1/8] kvm_config: Allow for = in the value of a config parameter

2009-06-08 Thread Lucas Meneghel Rodrigues
On Mon, 2009-06-08 at 01:01 -0300, Lucas Meneghel Rodrigues wrote: fix modifies kvm_config.split_and_strip so it will only split once per line. Applied. example: kernel_args = ks=floppy console=ttyS0 noacpi Signed-off-by: David Huff dh...@redhat.com --- client/tests/kvm/kvm_config.py |

Re: [KVM-AUTOTEST PATCH 4/8] RHEL 5.3 step file fixes

2009-06-08 Thread Lucas Meneghel Rodrigues
On Mon, 2009-06-08 at 01:01 -0300, Lucas Meneghel Rodrigues wrote: Fix the initial boot barriers to include the 'boot:' prompt. Also fix a barrier in 5.3 of a dialog that sometimes appears at an unexpected location. Applied. Signed-off-by: Michael Goldish mgold...@redhat.com ---

Re: [KVM-AUTOTEST PATCH 5/8] stepeditor.py: get rid of some shortcuts

2009-06-08 Thread Lucas Meneghel Rodrigues
On Mon, 2009-06-08 at 01:01 -0300, Lucas Meneghel Rodrigues wrote: Disable a few keyboard shortcuts that were initially assumed to be useful, but apparently override the default functionality of the involved keys (e.g. 'home', 'end', 'delete') regardless of the widget that has the keyboard

Re: [KVM-AUTOTEST PATCH 6/8] Choose a monitor filename in the constructor of VM class

2009-06-08 Thread Lucas Meneghel Rodrigues
On Mon, 2009-06-08 at 01:01 -0300, Lucas Meneghel Rodrigues wrote: Choose a monitor filename in the VM class constructor instead of the VM.create() method. This will reduce the number of monitor files left in /tmp, because the constructor is called fewer times than VM.create(). Applied.

Re: [KVM-AUTOTEST PATCH 7/8] Add new function, VM.clone() to clone an existing VM

2009-06-08 Thread Lucas Meneghel Rodrigues
On Fri, 2009-06-05 at 17:46 -0300, Lucas Meneghel Rodrigues wrote: This method will be useful when writing functional tests. Risk: Low (new method of the kvm test API) Visibility: Low (kvm test developers will have an additional API to use) Applied, but the commit was ammended to follow the

Re: [KVM-AUTOTEST PATCH 8/8] kvm_runtest_2.py: use pickle instead of shelve when loading/saving env

2009-06-08 Thread Lucas Meneghel Rodrigues
On Fri, 2009-06-05 at 17:46 -0300, Lucas Meneghel Rodrigues wrote: pickle allows more control over the load/save process. Specifically, it enables us to dump the contents of an object to disk without having to unpickle it. shelve, which uses pickle, seems to pickle and unpickle every time

Re: [PATCH 2/4] sipi and init: move common code

2009-06-08 Thread Glauber Costa
On Mon, Jun 08, 2009 at 12:08:17PM +0300, Avi Kivity wrote: Glauber Costa wrote: provide functions to query and reset the state of sipi and init in cpu's apic. This way we can move the kvm specific functions out of the apic path. The new functions and data members are kvm specific.

Re: [PATCH 2/4] sipi and init: move common code

2009-06-08 Thread Avi Kivity
Glauber Costa wrote: On Mon, Jun 08, 2009 at 12:08:17PM +0300, Avi Kivity wrote: Glauber Costa wrote: provide functions to query and reset the state of sipi and init in cpu's apic. This way we can move the kvm specific functions out of the apic path. The new functions and

Re: [Autotest] [KVM-AUTOTEST PATCH 8/8] kvm_runtest_2.py: use pickle instead of shelve when loading/saving env

2009-06-08 Thread Martin Bligh
On Fri, Jun 5, 2009 at 1:46 PM, Lucas Meneghel Rodriguesl...@redhat.com wrote: pickle allows more control over the load/save process. Specifically, it enables us to dump the contents of an object to disk without having to unpickle it. shelve, which uses pickle, seems to pickle and unpickle

Re: [PATCH 2/4] sipi and init: move common code

2009-06-08 Thread Glauber Costa
On Mon, Jun 08, 2009 at 06:48:38PM +0300, Avi Kivity wrote: Glauber Costa wrote: On Mon, Jun 08, 2009 at 12:08:17PM +0300, Avi Kivity wrote: Glauber Costa wrote: provide functions to query and reset the state of sipi and init in cpu's apic. This way we can move the kvm specific

Re: [PATCH qemu-kvm] Enable UFO on virtio-net/tap devices

2009-06-08 Thread Sridhar Samudrala
On Sun, 2009-06-07 at 09:21 +0300, Avi Kivity wrote: Sridhar Samudrala wrote: Enable UFO on the host tap device if supported and allow setting UFO on virtio-net in the guest. Signed-off-by: Sridhar Samudrala s...@us.ibm.com diff --git a/hw/virtio-net.c b/hw/virtio-net.c index

Re: [PATCH 1/4] Introduce kvm_vcpu_is_bsp() function.

2009-06-08 Thread Hollis Blanchard
On Mon, 2009-06-08 at 14:20 +0300, Avi Kivity wrote: Gleb Natapov wrote: @@ -130,6 +130,7 @@ struct kvm { int nmemslots; struct kvm_memory_slot memslots[KVM_MEMORY_SLOTS + KVM_PRIVATE_MEM_SLOTS]; + struct kvm_vcpu *bsp_vcpu; struct

Re: [Autotest] [KVM-AUTOTEST PATCH 8/8] kvm_runtest_2.py: use pickle instead of shelve when loading/saving env

2009-06-08 Thread Lucas Meneghel Rodrigues
On Mon, 2009-06-08 at 09:10 -0700, Martin Bligh wrote: On Fri, Jun 5, 2009 at 1:46 PM, Lucas Meneghel Rodriguesl...@redhat.com wrote: pickle allows more control over the load/save process. Specifically, it enables us to dump the contents of an object to disk without having to unpickle it.

Re: [PATCH 1/4] Introduce kvm_vcpu_is_bsp() function.

2009-06-08 Thread Avi Kivity
Hollis Blanchard wrote: please wrap with HAVE_KVM_IRQCHIP (which is a close approximation). I don't know about that... I've definitely thought about implementing an in-kernel PIC for PowerPC. (That will make more sense as an optimization once the processors with hypervisor support start

Re: [PATCH net-next 2/4] udp: Handle large UFO packets from untrusted sources

2009-06-08 Thread Sridhar Samudrala
On Mon, 2009-06-08 at 15:16 +1000, Herbert Xu wrote: On Fri, Jun 05, 2009 at 05:16:31PM -0700, Sridhar Samudrala wrote: + /* Software UFO is not yet supported */ + segs = ERR_PTR(-EPROTONOSUPPORT); Hmm, we need to fill this in before you start using it for virt. After all, it's very

Re: [Autotest] Log message format in KVM-Autotest

2009-06-08 Thread Martin Bligh
if it's specific to one test or whatever, you could also just put it inside the message? Possibly with your own wrapper function around the logging? On Mon, Jun 8, 2009 at 6:03 AM, Lucas Meneghel Rodriguesl...@redhat.com wrote: On Mon, 2009-06-08 at 06:35 -0400, Michael Goldish wrote: Hi Lucas,

[PATCH] KVM: VMX: Support Unrestricted Guest feature

2009-06-08 Thread Nitin A Kamble
Unrestricted Guest feature is added in the VMX specification. Intel Westmere and onwards processors will support this feature. It allows kvm guests to run real mode and unpaged mode code natively in the VMX mode when EPT is turned on. With the unrestricted guest there is no need to emulate

[PATCH 0/4] Start using KVMState

2009-06-08 Thread Glauber Costa
Guys, This is to address the feedback I received in the last attempt. I'm now attempting to move kvm_context inside of KVMState Patch #3 should be applied to qemu. I'll relay it to Anthony if we reach consensus on it here. Patch #4 is an example use of KVMState, to show how I intend to proceed.

[PATCH 1/4] get rid of libkvm-common.h

2009-06-08 Thread Glauber Costa
This file has no purpose in life in new scheme of things. Move its contents to libkvm-all.h. There are some name clashes in qemu-kvm.c. Those function names are then changed. Signed-off-by: Glauber Costa glom...@redhat.com --- kvm.h|1 + libkvm-all.h | 82

[PATCH 2/4] pull qemu headers into libkvm

2009-06-08 Thread Glauber Costa
Those headers define qemu specific things like ram_addr_t. This will allow us to start using them in libkvm. Signed-off-by: Glauber Costa glom...@redhat.com --- libkvm-all.c |2 +- libkvm-all.h |1 + target-i386/libkvm.c |2 ++ 3 files changed, 4 insertions(+), 1

[PATCH 3/4] Move KVMState to common header

2009-06-08 Thread Glauber Costa
This patch should be applied to main qemu, but I'll first post it here for appreciation. In this patch, we move KVMState definition to kvm.h header. With this done, we can also use its definition in our files, until there is no more such thing as our files. This is too selfish anyway. Later on,

Re: [Autotest] Log message format in KVM-Autotest

2009-06-08 Thread Lucas Meneghel Rodrigues
On Mon, 2009-06-08 at 11:15 -0700, Martin Bligh wrote: if it's specific to one test or whatever, you could also just put it inside the message? Possibly with your own wrapper function around the logging? Yes, it's a possibility, but I'd rather avoid it. IMHO the current logging configuration

Re: [PATCH 3/4] Move KVMState to common header

2009-06-08 Thread Jan Kiszka
Glauber Costa wrote: This patch should be applied to main qemu, but I'll first post it here for appreciation. In this patch, we move KVMState definition to kvm.h header. With this done, we can also use its definition in our files, until there is no more such thing as our files. This is too

Re: [PATCH] Fixing kvm test authorship issue

2009-06-08 Thread Lucas Meneghel Rodrigues
On Mon, 2009-06-08 at 04:48 -0400, Michael Goldish wrote: Hi Lucas, I'm bothering you with technicalities again unfortunately: 1. I'm not sure if it's customary to add @author tags to other modules except the main kvm.py one, but in case it is, here's what I think should be there

Re: [Autotest] Log message format in KVM-Autotest

2009-06-08 Thread Michael Goldish
- Lucas Meneghel Rodrigues l...@redhat.com wrote: On Mon, 2009-06-08 at 11:15 -0700, Martin Bligh wrote: if it's specific to one test or whatever, you could also just put it inside the message? No, because the test's 'shortname' contains both the test type and some minimal information

Re: [PATCH 3/4] Move KVMState to common header

2009-06-08 Thread Glauber Costa
On Mon, Jun 08, 2009 at 09:54:34PM +0200, Jan Kiszka wrote: Glauber Costa wrote: This patch should be applied to main qemu, but I'll first post it here for appreciation. In this patch, we move KVMState definition to kvm.h header. With this done, we can also use its definition in our

Re: [PATCH] Fixing kvm test authorship issue

2009-06-08 Thread Michael Goldish
- Lucas Meneghel Rodrigues l...@redhat.com wrote: On Mon, 2009-06-08 at 04:48 -0400, Michael Goldish wrote: Hi Lucas, I'm bothering you with technicalities again unfortunately: 1. I'm not sure if it's customary to add @author tags to other modules except the main kvm.py one,

[PATCH 1/2] Make sure to enable dirty tracking of VBE vram mapping

2009-06-08 Thread Anthony Liguori
Apparently, VBE maps the VGA vram to a fixed physical location. KVM requires that all mappings of the VGA vram have dirty tracking enabled on them. Any access to the VGA vram through the VBE mapping currently fails to result in dirty page tracking updates causing a black screen. This is the

[PATCH 2/2] Make sure to enable dirty log tracking for VMware VGA

2009-06-08 Thread Anthony Liguori
This is needed for VMware VGA to work properly under KVM. Signed-off-by: Anthony Liguori aligu...@us.ibm.com --- hw/vmware_vga.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/hw/vmware_vga.c b/hw/vmware_vga.c index bb17698..246011b 100644 --- a/hw/vmware_vga.c +++

Re: [PATCH 2/2] Make sure to enable dirty log tracking for VMware VGA

2009-06-08 Thread Anthony Liguori
Anthony Liguori wrote: This is needed for VMware VGA to work properly under KVM. Signed-off-by: Anthony Liguori aligu...@us.ibm.com --- hw/vmware_vga.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/hw/vmware_vga.c b/hw/vmware_vga.c index bb17698..246011b 100644

Re: [PATCH 3/4] Move KVMState to common header

2009-06-08 Thread Anthony Liguori
Glauber Costa wrote: On Mon, Jun 08, 2009 at 09:54:34PM +0200, Jan Kiszka wrote: Glauber Costa wrote: This patch should be applied to main qemu, but I'll first post it here for appreciation. In this patch, we move KVMState definition to kvm.h header. With this done, we can also use its

[KVM-AUTOTEST PATCH 00/06] More patch queue patches rebased

2009-06-08 Thread Lucas Meneghel Rodrigues
More 6 patches from the autotest patch queue were rebased against the upstream kvm test. -- Lucas Meneghel Rodrigues Software Engineer (QE) Red Hat - Emerging Technologies -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More

[KVM-AUTOTEST PATCH 01/06] kvm_vm.py: create a lock file to avoid VM creation in parallel

2009-06-08 Thread Lucas Meneghel Rodrigues
VM.create() does a few things (such as finding free ports) which are not safe to execute in parallel. Use a lock file to make sure this doesn't happen. The lock is released only after the VM is started or fails to start. Signed-off-by: Michael Goldish mgold...@redhat.com ---

  1   2   >