Re: [kvm-devel] [PATCH] shrinker support for the mmu cache

2008-03-17 Thread Avi Kivity
Marcelo Tosatti wrote: While aging is not too hard to do, I don't think it would add much in practice; we rarely observe mmu shadow pages being recycled due to memory pressure. So this is mostly helpful for preventing a VM from pinning memory when under severe memory pressure, where we

Re: [kvm-devel] [patch 0/6] pv mmu fixes

2008-03-17 Thread Avi Kivity
Marcelo Tosatti wrote: The following patchset fixes pvmmu/cr3-cache for 32-bit guests. Thanks. I folded the fixes into the patches they fixed, and merged everything except cr3 cache (I want to look at it again and see if I can reduce the impact a little). pvmmu branch now contains the

Re: [kvm-devel] [PATCH] x86: don't allow KVM_CLOCK without HAVE_KVM

2008-03-17 Thread Avi Kivity
Randy Dunlap wrote: On Sun, 16 Mar 2008 13:13:08 +0200 Avi Kivity wrote: Randy Dunlap wrote: From: Randy Dunlap [EMAIL PROTECTED] Make KVM_CLOCK depend on HAVE_KVM. Otherwise a Voyager build can fail with: CC arch/x86/kernel/asm-offsets.s In file included from include2

Re: [kvm-devel] [PATCH] x86: kvmclock needs to include apic.h

2008-03-16 Thread Avi Kivity
Randy Dunlap wrote: From: Randy Dunlap [EMAIL PROTECTED] kvmclock needs to #include apic.h to prevent a build error: next-20080314/arch/x86/kernel/kvmclock.c:142: error: implicit declaration of function 'setup_secondary_APIC_clock' elan1.out:make[2]: *** [arch/x86/kernel/kvmclock.o] Error

Re: [kvm-devel] [PATCH][QEMU] Use a separate device for in-kernel PIT

2008-03-16 Thread Avi Kivity
Anthony Liguori wrote: Part of the feedback we received from Fabrice about the KVM patches for QEMU is that we should create a separate device for the in-kernel APIC to avoid having lots of if (kvm_enabled()) within the APIC code that were difficult to understand why there were needed. This

Re: [kvm-devel] [PATCH][QEMU] Use a separate device for in-kernel PIT

2008-03-16 Thread Avi Kivity
Yang, Sheng wrote: And we got two choices in userspace: one ioctl to reset all kvm devices, or one ioctl for each device. For we are separating in kernel device into separate devices, seems the later is more proper. But would it bring other troubles like inconsistent state for smp? I

Re: [kvm-devel] [PATCH] shrinker support for the mmu cache

2008-03-16 Thread Avi Kivity
Marcelo Tosatti wrote: On Wed, Mar 12, 2008 at 08:13:41PM +0200, Izik Eidus wrote: this patch simply register the mmu cache with the shrinker. Hi Izik, Nice. I think you want some sort of aging mechanism here. Walk through all translations of a shadow page clearing the

Re: [kvm-devel] [patch 00/24] QEMU ACPI PCI hotplug support

2008-03-16 Thread Avi Kivity
Marcelo Tosatti wrote: The following patchset allows PCI hot add/remove through ACPI (handled by the acpiphp driver on Linux guests). Comments are welcome. Applied all, thanks. -- error compiling committee.c: too many arguments to function

Re: [kvm-devel] keymap nl-be bug/incomplete

2008-03-16 Thread Avi Kivity
Ben Budts wrote: Hi, I've been having problems using the -vnc and -k nl-be... Since I've started using KVM v.28 ... Lots of keys won't work and you get the following errors in your Host OS : Warning: no scancode found for keysym 249 Warning: no scancode found for keysym 163 Warning: no

Re: [kvm-devel] Qemu-kvm is leaking my memory ???

2008-03-16 Thread Avi Kivity
Zdenek Kabelac wrote: Hello Recently I'm using qemu-kvm on fedora-rawhide box with my own kernels (with many debug options) I've noticed that over the time my memory seems to disappear somewhere. Here is my memory trace after boot and some time of work - thus memory should be populated.

Re: [kvm-devel] [patch 0/3] QEMU balloon support

2008-03-16 Thread Avi Kivity
Marcelo Tosatti wrote: This patchset resends Anthony's QEMU balloon support plus: - Truncates the target size to ram size - Enables madvise() conditioned on KVM_ZAP_GFN ioctl Once mmu notifiers are in, KVM_ZAP_GFN isn't needed. So we have three possible situations: - zap needed, but

Re: [kvm-devel] [PATCH RFC 1/2] add functions to read and set the ldt

2008-03-16 Thread Avi Kivity
Izik Eidus wrote: From 28f36d30f8eef9c12afe52e183bf4c8405d113d2 Mon Sep 17 00:00:00 2001 From: Izik Eidus [EMAIL PROTECTED] Date: Thu, 13 Mar 2008 02:03:37 +0200 Subject: [PATCH] KVM: vmx, svm add functions to read and set the ldt diff --git a/include/asm-x86/kvm_host.h

Re: [kvm-devel] [PATCH RFC 2/2] Hardware task switching support

2008-03-16 Thread Avi Kivity
Izik Eidus wrote: From 6a7207a0f3ee8af6ebafcec9d40a75b87f00a129 Mon Sep 17 00:00:00 2001 From: Izik Eidus [EMAIL PROTECTED] Date: Thu, 13 Mar 2008 02:34:21 +0200 Subject: [PATCH] KVM: hardware task switching support Signed-off-by: Izik Eidus [EMAIL PROTECTED] --- arch/x86/kvm/svm.c

Re: [kvm-devel] [PATCH] KVM: Add reset support for in kernel PIT

2008-03-16 Thread Avi Kivity
Yang, Sheng wrote: From 2d08f4266a8f47d9c52db9d4f629ab5d2f8fd044 Mon Sep 17 00:00:00 2001 From: Sheng Yang [EMAIL PROTECTED] Date: Thu, 13 Mar 2008 10:22:26 +0800 Subject: [PATCH] KVM: Add reset support for in kernel PIT Separate the reset part and prepare for reset support. diff

Re: [kvm-devel] [ANNOUNCE] kvm-guest-drivers-linux-1

2008-03-16 Thread Avi Kivity
Paul Collins wrote: Iain Paton [EMAIL PROTECTED] writes: Trying to build against 2.6.24 gives the following: CC [M] /root/kvm/kvm-guest-drivers-linux-1/virtio_net.o /root/kvm/kvm-guest-drivers-linux-1/virtio_net.c: In function 'receive_skb':

Re: [kvm-devel] [PATCH] KVM: Add reset support for in kernel PIT

2008-03-16 Thread Avi Kivity
Yang, Sheng wrote: On Sunday 16 March 2008 22:36:57 Avi Kivity wrote: Yang, Sheng wrote: From 2d08f4266a8f47d9c52db9d4f629ab5d2f8fd044 Mon Sep 17 00:00:00 2001 From: Sheng Yang [EMAIL PROTECTED] Date: Thu, 13 Mar 2008 10:22:26 +0800 Subject: [PATCH] KVM: Add reset support

Re: [kvm-devel] [PATCH RFC 0/4]Porting Xentrace to kvm

2008-03-16 Thread Avi Kivity
Liu, Eric E wrote: Hi, The following patches port xentrace to kvm which is useful for performance tuning and debugging. It is designed to allow debugging traces of kvm to be generated on Up/Smp machines. Each trace entry is outputted in a trace ring buffer for per cpu which is mapped to

Re: [kvm-devel] [PATCH RFC 1/4]Porting Xentrace to kvm

2008-03-16 Thread Avi Kivity
Liu, Eric E wrote: From 0d7f1ee470fe907e00ac6246bfa11e5322bc64fb Mon Sep 17 00:00:00 2001 From: Feng (Eric) Liu [EMAIL PROTECTED] Date: Sat, 15 Mar 2008 06:07:33 -0400 Subject: [PATCH] KVM: Add some trace entries in current code, when the KVM_TRACE compilation option is enabled, it outputs

Re: [kvm-devel] [PATCH RFC 0/4]Porting Xentrace to kvm

2008-03-16 Thread Avi Kivity
Jan Kiszka wrote: Avi Kivity wrote: Liu, Eric E wrote: Hi, The following patches port xentrace to kvm which is useful for performance tuning and debugging. It is designed to allow debugging traces of kvm to be generated on Up/Smp machines. Each trace entry is outputted in a trace

Re: [kvm-devel] [PATCH] Fix sci irq set when acpi timer about to wrap

2008-03-16 Thread Avi Kivity
Dor Laor wrote: From 498f162fc9d9fb897c756273c481101a44a220de Mon Sep 17 00:00:00 2001 From: Dor Laor [EMAIL PROTECTED] Date: Thu, 13 Mar 2008 00:11:41 +0200 Subject: [PATCH] Fix sci irq set when acpi timer about to wrap. The acpi timer should generate sci irq when enabled and when bit 23

Re: [kvm-devel] [PATCH 1/6] KVM: In kernel pit model

2008-03-07 Thread Avi Kivity
Yang, Sheng wrote: Found more complex for KVM. Xen pulled pm timer down to kernel part, and used the guest TSC as source. So only adjust TSC is OK for it. But we are still using pm timer in QEmu, which using host time as source. So even we pull back TSC, the problem still exists, for 2.6.9

Re: [kvm-devel] [PATCH] Mark kobjects as unitialized

2008-03-07 Thread Avi Kivity
Greg KH wrote: and is on my TODO list, slowly getting closer to the top... Strange. On my TODO list, things slowly get pushed to the bottom. -- Any sufficiently difficult bug is indistinguishable from a feature. -

Re: [kvm-devel] [PATCH 0/2] provide disable clock functionality.

2008-03-07 Thread Avi Kivity
Glauber Costa wrote: Avi, Hope this is better Applied, thanks. -- Any sufficiently difficult bug is indistinguishable from a feature. - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R)

Re: [kvm-devel] [PATCH] disable clock before rebooting.

2008-03-07 Thread Avi Kivity
Glauber Costa wrote: This patch writes 0 (actually, what really matters is that the LSB is cleared) to the system time msr before rebooting/shutting down the machine. Without it, we can have a random memory location being written when the guest comes back if (!kvm_para_available())

Re: [kvm-devel] [PATCH 1/6] KVM: In kernel pit model

2008-03-07 Thread Avi Kivity
Yang, Sheng wrote: On Friday 07 March 2008 16:53:40 Avi Kivity wrote: Yang, Sheng wrote: Found more complex for KVM. Xen pulled pm timer down to kernel part, and used the guest TSC as source. So only adjust TSC is OK for it. But we are still using pm timer in QEmu, which using host

Re: [kvm-devel] headersinstall of kvm.h does not work

2008-03-07 Thread Avi Kivity
Christian Borntraeger wrote: Hello Avi, in commit fb56dbb31c4738a3918db81fd24da732ce3b4ae6 you changed include/linux/Kbuild: snip KVM: Export include/linux/kvm.h only if $ARCH actually supports KVM Currently, make headers_check barfs due to asm/kvm.h, which linux/kvm.h includes,

Re: [kvm-devel] [PATCH] disable clock before rebooting.

2008-03-07 Thread Avi Kivity
Glauber Costa wrote: Why not go all the way and to _restart the same way? Because it got a parameter, and doing it in the same macro would make my beautiful macros ugly. Using another one, to pass the argument, didn't seem justifiable to me, since there were just one of its kind. Yes, of

Re: [kvm-devel] [PATCH] disable clock before rebooting.

2008-03-07 Thread Avi Kivity
Glauber Costa wrote: as for kexec, it uses precisely the shutdown function, doesn't it? Or is it crash_shutdown? Humm, /me looks, and I think it's the later, right? Only on crash-triggered kexecs. It can also happen via sys_reboot(). Which, it appears, goes through machine_shutdown(). --

Re: [kvm-devel] headersinstall of kvm.h does not work

2008-03-07 Thread Avi Kivity
Christian Borntraeger wrote: Am Freitag, 7. März 2008 schrieb Avi Kivity: As I'm about to disappear for a week, consider a patch to remove the config dependency and add asm-*/kvm.h pre-acked for mainline. Maybe the presence of those empty asm-*/kvm.h files will encourage further kvm

Re: [kvm-devel] [PATCH 0/6] Latest in kernel PIT patch

2008-03-07 Thread Avi Kivity
Yang, Sheng wrote: Hi Here is the latest in kernel PIT patch. Not much change from last edition. One known issue is on 2.6.9 pae guest(e.g. RHEL4), you need clock=pit kernel parameter to get the correct time. That's because the kernel is too active to fix the lost interrupt when PIT

Re: [kvm-devel] [PATCH 1/2] [PATCH] allow machine_crash_shutdown to be replaced

2008-03-07 Thread Avi Kivity
Glauber Costa wrote: This patch a llows machine_crash_shutdown to be replaced, just like any of the other functions in machine_ops er, against what tree is this? doesn't apply to kvm.git. -- Any sufficiently difficult bug is indistinguishable from a feature.

Re: [kvm-devel] [PATCH 1/6] KVM: In kernel pit model

2008-03-06 Thread Avi Kivity
Yang, Sheng wrote: Here is the updated patch. I kept 0xff because I think it's OK for understand easily. :) Any news on the regression with older Linux guests? That's the only thing keeping my from applying the patchset. -- Do not meddle in the internals of kernels, for they are

[kvm-devel] [ANNOUNCE] kvm-guest-drivers-linux-1

2008-03-06 Thread Avi Kivity
This is the first release of block and network drivers for Linux guests running on a kvm host. The drivers are intended for guest kernels 2.6.18-2.6.24. Newer kernels include the drivers; older kernels may not work. kvm-61 or later is needed in the host. Network throughput is around 1

Re: [kvm-devel] [PATCH 8/8] x86: KVM guest: VMX cr3 cache support

2008-03-06 Thread Avi Kivity
Zhao Forrest wrote: * We only need to hook operations that are MMU writes. We hook these so that * we can use lazy MMU mode to batch these operations. We could probably * improve the performance of the host code if we used some of the information @@ -219,6 +359,9 @@ static void

Re: [kvm-devel] automatic reboot winxp hanging on vnc...

2008-03-06 Thread Avi Kivity
Thomas Besser wrote: Avi Kivity wrote: Thomas Besser wrote: Is that a feature or a bug? Any hints to solve this problem? Strange. What kvm version are you using? Ups, sorry for forgetting this: I am using kvm-52 in a productive environment. Host ist Debian etch

Re: [kvm-devel] [Lguest] networking in lguest: strange error: lguest: Guest moved used index from 6 to 256

2008-03-06 Thread Avi Kivity
Dor Laor wrote: On Wed, 2008-03-05 at 17:10 -0600, Anthony Liguori wrote: Dor Laor wrote: Seems to work reliably with kvm, should do the same trick for lguest. You can download it from git://kvm.qumranet.com/home/dor/src/kvm-guest-drivers-linux Anthony, you can update your

Re: [kvm-devel] [PATCH 3/4] [PATCH] kvmclock: allow it to be turned off

2008-03-06 Thread Avi Kivity
Glauber Costa wrote: Apart from the fact that it will break every single guest out there, that's ok. As I said: these things are so early, that maybe we can pay this price. Your call. Which guests? kvmclock is only in kvm.git, and I don't think any distro is based on that. -- Do not

Re: [kvm-devel] [PATCH 7/8] KVM: MMU: VMX cr3 cache support

2008-03-06 Thread Avi Kivity
Marcelo Tosatti wrote: Here CR3_TARGET_VALUEx is written. My question is: 1 why is vmcs_writel(CR3_TARGET_VALUE0 + idx*2, cr3); called by vmx_set_cr3(), but not called by mmu_free_roots()? By clearing guest_cr3 entry of the shared area we avoid the guest from using it. So its

[kvm-devel] Offline for a week

2008-03-06 Thread Avi Kivity
I will be off-line (and sometimes off-piste) from March 8 through March 15. I may have sporadic Internet access. Andrew, should kvm.git not play nicely with the rest of the children, have it stand in the corner. -- error compiling committee.c: too many arguments to function

Re: [kvm-devel] [PATCH/RFC 1/2] anon-inodes: Remove fd_install() from anon_inode_getfd()

2008-03-05 Thread Avi Kivity
Davide Libenzi wrote: I think that may be a bit cleaner than Al's approach, but it still leaves the same trap that create_vcpu_fd() falls into. The current code is: static int create_vcpu_fd(struct kvm_vcpu *vcpu) { int fd, r; struct inode *inode; struct file *file;

Re: [kvm-devel] [RFC] Notifier for Externally Mapped Memory (EMM)

2008-03-05 Thread Avi Kivity
Robin Holt wrote: On Wed, Mar 05, 2008 at 07:09:55AM +0200, Avi Kivity wrote: Isn't that out of the question for .25? I keep hearing this mantra. What is so compelling about the .25 release? When seems to be more important than what. While I understand product release cycles

Re: [kvm-devel] [PATCH 1/6] KVM: In kernel pit model

2008-03-05 Thread Avi Kivity
Yang, Sheng wrote: Thanks for comments! On Wednesday 05 March 2008 17:15:29 Ingo Molnar wrote: * Yang, Sheng [EMAIL PROTECTED] wrote: +#if 1 +#define pit_debug(fmt, arg...) printk(KERN_WARNING fmt, ##arg) +#else +#define pit_debug(fmt, arg...) +#endif this should use

Re: [kvm-devel] [PATCH] virtio-balloon: do not attempt to release more than available pages

2008-03-05 Thread Avi Kivity
Marcelo Tosatti wrote: Handle the case where the balloon target is larger than total ram size. BUG: unable to handle kernel paging request at 00100100 IP: [881970f9] :virtio_balloon:leak__balloon+0x2e/0xbe Signed-off-by: Marcelo Tosatti [EMAIL PROTECTED] Index:

Re: [kvm-devel] still seeing network freezes with rtl8139 nic

2008-03-05 Thread Avi Kivity
david ahern wrote: Try adding the noapic option to your guest kernel. I re-ran that test on kvm-62 and my VM was able to run under load for more than 3-1/2 days (the network never locked up; I stopped the test to try other variations). One side effect of the noapic option is that irq

Re: [kvm-devel] [PATCH 0/6] In kernel PIT patch

2008-03-05 Thread Avi Kivity
Anthony Liguori wrote: Playing a movie is a bit subjective. I presume you're talking about the standard HAL as presumably the ACPI HAL is using the pm timer? ACPI HAL uses the apic timer, IIRC; perhaps the pm timer as well. So the two cases I'm hearing where timer accuracy should

Re: [kvm-devel] [PATCH] virtio-balloon: do not attempt to release more than available pages

2008-03-05 Thread Avi Kivity
Marcelo Tosatti wrote: On Wed, Mar 05, 2008 at 06:59:10PM +0200, Avi Kivity wrote: Marcelo Tosatti wrote: Handle the case where the balloon target is larger than total ram size. BUG: unable to handle kernel paging request at 00100100 IP: [881970f9

Re: [kvm-devel] [ANNOUNCE] kvm-62 release

2008-03-05 Thread Avi Kivity
Avi Kivity wrote: Add cpus on the fly to your virtual machines with the new cpu hotplug feature. er, kvm-63, that is. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic

[kvm-devel] [ANNOUNCE] kvm-62 release

2008-03-05 Thread Avi Kivity
Add cpus on the fly to your virtual machines with the new cpu hotplug feature. Changes from kvm-62: - portability: make room for the ia64 register stack (Xiantao Zhang) - fix leak when setting the pv clock to an invalid address (Marcelo Tosatti) - detect vcpu triple faults (Joerg Roedel) - fix

Re: [kvm-devel] [ANNOUNCE] kvm-62 release

2008-03-05 Thread Avi Kivity
Alexey Eremenko wrote: Very Nice. Must be KVM-63. - merge qemu-cvs - new curses display option How to activate that one? qemu -curses -- Do not meddle in the internals of kernels, for they are subtle and quick to panic.

Re: [kvm-devel] Notifier for Externally Mapped Memory (EMM) V1

2008-03-05 Thread Avi Kivity
Christoph Lameter wrote: /* + * Notifier for devices establishing their own references to Linux + * kernel pages in addition to the regular mapping via page + * table and rmap. The notifier allows the device to drop the mapping + * when the VM removes references to pages. + */ +enum

Re: [kvm-devel] [PATCH 1/4] [PATCH] kvmclock: release time_page if msr is rewritten

2008-03-05 Thread Avi Kivity
Glauber Costa wrote: If the calling cpu rewrites the system clock msr for any reason, release the page we allocated in the last time Applied, thanks. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic.

Re: [kvm-devel] [PATCH 3/4] [PATCH] kvmclock: allow it to be turned off

2008-03-05 Thread Avi Kivity
Glauber Costa wrote: Use the lower 3 lower bits of the system time msr to turn off the clock. This means that all clock registration has to be aligned in a 4-byte boundary 3 bits - 8 bytes. How about just using just bit 0 as an enable bit (not a disable bit). That means the default

Re: [kvm-devel] [PATCH 4/4] [PATCH] cleanup leftovers

2008-03-05 Thread Avi Kivity
Glauber Costa wrote: clean this leftover in kvmclock.c Applied, thanks. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic. - This SF.net email is sponsored by: Microsoft Defy all

Re: [kvm-devel] [PATCH 0/3] Expose thread id through info cpus

2008-03-05 Thread Avi Kivity
Glauber Costa wrote: Hey, This patch series expose the actual thread id of each cpu via the qemu monitor. It is done through info cpus, which I though would be the most natural command to do it. (If you disagree, please voice it) Goal is to allow tools like libvirt to easily grab it and

Re: [kvm-devel] [PATCH] virtio-balloon: do not attempt to release more than available pages

2008-03-05 Thread Avi Kivity
Anthony Liguori wrote: Set the target in QEMU to be larger than guest ram size. The config space variable will be set negatively, so guest attempts to release pages from the balloon. Is an __le32 signed? If so, we should just use an unsigned type. That would balloon the

Re: [kvm-devel] [PATCH 6/8] x86: KVM guest: hypercall batching

2008-03-05 Thread Avi Kivity
Zhao Forrest wrote: Hi Avi, After reading the patch, I think the hypercall batching mechanism is as follows: 1 defer the MMU-related operations and buffer them in kvm_para_state-mmu_queue[] 2 during the flush period, kvm_mmu_op() is called to flush operations in kvm_para_state-mmu_queue[]

Re: [kvm-devel] KVM architecture docs

2008-03-04 Thread Avi Kivity
Zhao Forrest wrote: http://ols.108.redhat.com/2007/Reprints/kivity-Reprint.pdf Hi Avi, I have a question about KVM architecture after reading your paper. It reads: .. At the kernel level, the kernel causes the hardware to enter guest mode. If the processor exits guest mode due

Re: [kvm-devel] use smp_cpus as lapic id

2008-03-04 Thread Avi Kivity
Glauber Costa wrote: apic is not acpi, although they are acronyms. Due to a confusion of mine, those things were mixed, leading to a bug reported at https://sourceforge.net/tracker/index.php?func=detailaid=1903732group_id=180599atid=893831 This patch fixes it, by assigning smp_cpus

Re: [kvm-devel] KVM architecture docs

2008-03-04 Thread Avi Kivity
Zhao Forrest wrote: The incoming packet is processed by the host ethernet stack; it is forwarded to the bridge, which forwards it to the tap. When the tap queues the packet, it sends a signal to qemu (since the tap file descriptor has a signal associated). When the kernel delivers the

Re: [kvm-devel] 11s softlockup and hang with kvm on 2.6.24.3

2008-03-04 Thread Avi Kivity
Paul Collins wrote: Running kvm 62 on 2.6.24.3 (the extraversion is reported due to a local patch to vfat) I just got a couple of soft lockups and a hang. I was installing FreeBSD 7 at the time. Mar 4 21:20:13 burly kernel: Call Trace: Mar 4 21:20:13 burly kernel: [8024b60e]

Re: [kvm-devel] [PATCH 4/8] KVM: MMU: hypercall based pte updates and TLB flushes

2008-03-04 Thread Avi Kivity
Marcelo Tosatti wrote: Hi Avi, Looks nice. On Sun, Mar 02, 2008 at 06:31:17PM +0200, Avi Kivity wrote: +int kvm_pv_mmu_op(struct kvm_vcpu *vcpu, unsigned long bytes, + gpa_t addr, unsigned long *ret) +{ +int r; +struct kvm_pv_mmu_op_buffer buffer; Perhaps

Re: [kvm-devel] [PATCH 4/8] KVM: MMU: hypercall based pte updates and TLB flushes

2008-03-04 Thread Avi Kivity
Avi Kivity wrote: As the patchset (less cr3 caching) passed the regression tests I'll apply it. Forgot about the unresolved CONFIG_HIGHPTE problem, so not applying for now. -- error compiling committee.c: too many arguments to function

[kvm-devel] Stop the clock!

2008-03-04 Thread Avi Kivity
With paravirt clocksource, reboot and kexec are broken: the clock keeps updating after the reboot, and the new kernel will have a random memory location trampled occasionally. So we need to stop the clock on kexec (in the guest) and reboot (in the host). On the host side, this can be done

Re: [kvm-devel] KVM Test result, kernel daf4de3.., userspace 724f8a9.. One new issue

2008-03-04 Thread Avi Kivity
. This breaks guests that go from long mode to compatibility mode. This is noticed on a solaris guest and fixes bug #1842160 Signed-off-by: Amit Shah [EMAIL PROTECTED] Signed-off-by: Avi Kivity [EMAIL PROTECTED] diff --git a/arch/x86/kvm/mmu.h b/arch/x86/kvm/mmu.h index e64e9f5..d83225e

Re: [kvm-devel] The SMP RHEL 5.1 PAE guest can't boot up issue

2008-03-04 Thread Avi Kivity
Avi Kivity wrote: Dong, Eddie wrote: I don't know if the patch was still needed now, since it was posted long ago(I don't know which issue it solved). I'd like to post a revert patch if necessary. I believe the patch is still necessary, since we still need to guarantee that a vcpu's

Re: [kvm-devel] KVM architecture docs

2008-03-04 Thread Avi Kivity
Javier Guerra wrote: On 3/4/08, Avi Kivity [EMAIL PROTECTED] wrote: apply to kvm guests. With mmu notifiers, the trend will grow even stronger. could you (or anybody) elaborate on that? the mmu-related threads show lots of progress, but it's way (way) out of my league. AFAICT

[kvm-devel] [GIT PULL] KVM fixes for 2.6.25-rc3

2008-03-04 Thread Avi Kivity
Linus, please pull the kvm fixes in the repo and branch git://git.kernel.org/pub/scm/linux/kernel/git/avi/kvm.git for-linus comprising an ABI fix, a few host crash fixes, AMD specific fixes, a Kbuild fix for the randconfig addicts, fallout from the scaling work, and other miscellany. Avi

Re: [kvm-devel] loop in copy_user_generic_string

2008-03-04 Thread Avi Kivity
Zdenek Kabelac wrote: Hello I'm having weird problem and being a bit puzzled about where to look for this bug. I'm using T61 - C2D 2GB So I'll describe symptoms: When I run inside my 0.5G smp qemu-kvm guest with Debian these two loops in parallel: 'while : ; do dmsetup status ;

Re: [kvm-devel] loop in copy_user_generic_string

2008-03-04 Thread Avi Kivity
Zdenek Kabelac wrote: Is it emulated ? I've thought it's running natively with vmx? In some cases (memory mapped I/O, writes to page tables) some instructions are emulated. Usually they run natively. Please post the output of 'kvm_stat -1' to ensure the problem is with the emulator. --

Re: [kvm-devel] [RFC] Notifier for Externally Mapped Memory (EMM)

2008-03-04 Thread Avi Kivity
Peter Zijlstra wrote: On Tue, 2008-03-04 at 14:35 -0800, Christoph Lameter wrote: RCU means that the callbacks occur in an atomic context. Not really, if it requires moving the VM locks to sleepable locks under a .config option, I think its also fair to require PREEMPT_RCU. OTOH,

Re: [kvm-devel] KVM architecture docs

2008-03-04 Thread Avi Kivity
Zhao Forrest wrote: - swapping allows you to overcommit memory Normally swapping mechanism choose the Least Recently Used(LRU) pages of a process to be swapped out. When KVM uses MMU notifier in linux kernel to implement swapping for VM, could KVM choose LRU pages of a VM to swap out?

Re: [kvm-devel] [PATCH 0/8] RFC: vcpu pinning at qemu start

2008-03-04 Thread Avi Kivity
Glauber Costa wrote: Hi guys, Here's a first series of patch aiming at vcpu pinning support in qemu. Ideally, as vcpu as just normal threads, the usual userspace tools can be used to set cpu affinities mask. However, It makes it very difficult to _start_ a vm with vcpus pinned, since we

Re: [kvm-devel] KVM architecture docs

2008-03-04 Thread Avi Kivity
Zhao Forrest wrote: Normally swapping mechanism choose the Least Recently Used(LRU) pages of a process to be swapped out. When KVM uses MMU notifier in linux kernel to implement swapping for VM, could KVM choose LRU pages of a VM to swap out? If so, could you give a brief description about how

Re: [kvm-devel] [patch 23/23] QEMU/KVM: device hot-remove

2008-03-04 Thread Avi Kivity
Marcelo Tosatti wrote: Add monitor command to hot-remove devices. Remove device data on _EJ0 notification. Signed-off-by: Marcelo Tosatti [EMAIL PROTECTED] Index: kvm-userspace.hotplug/qemu/monitor.c === ---

Re: [kvm-devel] KVM architecture docs

2008-03-04 Thread Avi Kivity
Zhao Forrest wrote: Normally swapping mechanism choose the Least Recently Used(LRU) pages of a process to be swapped out. When KVM uses MMU notifier in linux kernel to implement swapping for VM, could KVM choose LRU pages of a VM to swap out? If so, could you give a brief description about how

Re: [kvm-devel] [PATCH 1/6] KVM: In kernel pit model

2008-03-04 Thread Avi Kivity
Yang, Sheng wrote: + +static int pit_get_out(struct kvm *kvm, int channel) +{ + struct kvm_kpit_channel_state *c = + kvm-arch.vpit-pit_state.channels[channel]; + s64 d, t; + int out; + + ASSERT(mutex_is_locked(kvm-arch.vpit-pit_state.lock)); + + t =

Re: [kvm-devel] loop in copy_user_generic_string

2008-03-04 Thread Avi Kivity
Andi Kleen wrote: Avi Kivity [EMAIL PROTECTED] writes: Most likely movs emulation is broken for long counts. Please post a disassembly of copy_user_generic_string to make sure we're looking at the same code. Be careful -- this code is patched at runtime and what you see

Re: [kvm-devel] [patch 23/23] QEMU/KVM: device hot-remove

2008-03-04 Thread Avi Kivity
Daniel P. Berrange wrote: (qemu) info block ide0-hd0: type=hd removable=0 file=/root/images/marcelo5.img ro=0 drv=raw ide1-cd0: type=cdrom removable=1 locked=0 [not inserted] floppy0: type=floppy removable=1 locked=0 [not inserted] sd0: type=floppy removable=1 locked=0 [not inserted]

Re: [kvm-devel] [PATCH 0/8] RFC: vcpu pinning at qemu start

2008-03-04 Thread Avi Kivity
Anthony Liguori wrote: Glauber Costa wrote: Anthony Liguori wrote: No, it can't. Because at the time qemu starts, no vcpu - thread id relationship exists at all. And we don't know when it will. Sure we do. The vcpu - thread id relationship is valid after kvm_init_ap() is

Re: [kvm-devel] [patch 14/23] QEMU/KVM: device hot-add

2008-03-04 Thread Avi Kivity
Marcelo Tosatti wrote: Add monitor command to hot-add PCI devices (nic and drive). A drive is not a pci device. One would hot-plug a scsi controller, and then hot-plug a device to that controller. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic.

Re: [kvm-devel] [patch 23/23] QEMU/KVM: device hot-remove

2008-03-04 Thread Avi Kivity
Anthony Liguori wrote: Daniel P. Berrange wrote: Removing based on pci device number is very un-pleasant, since its not something the user of the monitor cares about. Nor do they even know what the PCI device number assigned by 'pci_add' is. As with addition, I'd like separate commands

Re: [kvm-devel] [patch 01/23] QEMU/KVM: add PCI IRQ routing information up to slot 32

2008-03-04 Thread Avi Kivity
Marcelo Tosatti wrote: Signed-off-by: Marcelo Tosatti [EMAIL PROTECTED] Index: kvm-userspace.hotplug/bios/acpi-dsdt.dsl === --- kvm-userspace.hotplug.orig/bios/acpi-dsdt.dsl +++ kvm-userspace.hotplug/bios/acpi-dsdt.dsl @@

Re: [kvm-devel] [PATCH 0/8] RFC: vcpu pinning at qemu start

2008-03-04 Thread Avi Kivity
Anthony Liguori wrote: Glauber Costa wrote: My main interest is in management tools being able to specify pinning set ups at VM creation time. As I said, it can be done through tools like taskset, but then you'd have to know: * when are the threads created * which thread ids corresponds

Re: [kvm-devel] [patch 00/23] [RFC] QEMU/KVM ACPI PCI hotplug

2008-03-04 Thread Avi Kivity
Marcelo Tosatti wrote: The following patchset adds ACPI PCI hotplug support for QEMU. It extends the number of slots with IRQ routing information from 6 to 32. The only PCI driver which the unregister method has been added is LSI SCSI, would like more comments to implement that for the

Re: [kvm-devel] KVM architecture docs

2008-03-04 Thread Avi Kivity
Zhao Forrest wrote: when NPT is used by KVM in the future, this mmu btw, NPT support is already integrated. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic. - This SF.net email

Re: [kvm-devel] [PATCH][EXTBOOT] Fix read drive parameters to solve Grub Error 18

2008-03-04 Thread Avi Kivity
Anthony Liguori wrote: In certain circumstances, the calculated CHS can result in a total number of sectors that is less than the actual number of sectors. I'm not entirely sure why this upsets grub, but it seems to be the source of the Grub Error 18 that sometimes occurs when using extboot.

Re: [kvm-devel] ncurses support

2008-03-03 Thread Avi Kivity
Aurelien Jarno wrote: Hi, ncurses support has been added recently to the QEMU CVS. Would it be possible to update KVM from the latest QEMU CVS to add ncurses support to KVM? I've merged qemu-cvs, will push once it passes regression tests. -- error compiling committee.c: too many

Re: [kvm-devel] [PATCH] mmu notifiers #v8

2008-03-03 Thread Avi Kivity
Jack Steiner wrote: The range invalidates have a performance advantage for the GRU. TLB invalidates on the GRU are relatively slow (usec) and interfere somewhat with the performance of other active GRU instructions. Invalidating a large chunk of addresses with a single GRU TLBINVAL

[kvm-devel] [PATCH 1/8] KVM: add basic paravirt support

2008-03-02 Thread Avi Kivity
] Signed-off-by: Avi Kivity [EMAIL PROTECTED] --- arch/x86/kvm/x86.c |1 + include/asm-x86/kvm_para.h |3 ++- include/linux/kvm.h|1 + 3 files changed, 4 insertions(+), 1 deletions(-) diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index 6f09840..cafed91 100644

[kvm-devel] [PATCH 3/8] KVM: Provide unlocked version of emulator_write_phys()

2008-03-02 Thread Avi Kivity
Signed-off-by: Avi Kivity [EMAIL PROTECTED] --- arch/x86/kvm/x86.c | 21 ++--- include/asm-x86/kvm_host.h |3 +++ 2 files changed, 17 insertions(+), 7 deletions(-) diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index cafed91..a1a6f0a 100644 --- a/arch/x86/kvm

[kvm-devel] [PATCH 2/8] x86: KVM guest: add basic paravirt support

2008-03-02 Thread Avi Kivity
] Signed-off-by: Avi Kivity [EMAIL PROTECTED] --- arch/x86/Kconfig |8 ++ arch/x86/kernel/Makefile |1 + arch/x86/kernel/kvm.c | 52 arch/x86/kernel/setup_32.c |1 + arch/x86/kernel/setup_64.c |2 + include/linux

[kvm-devel] [PATCH 8/8] x86: KVM guest: VMX cr3 cache support

2008-03-02 Thread Avi Kivity
[EMAIL PROTECTED] Signed-off-by: Avi Kivity [EMAIL PROTECTED] --- arch/x86/kernel/kvm.c | 145 - 1 files changed, 144 insertions(+), 1 deletions(-) diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c index 8405984..30e3568 100644 --- a/arch

Re: [kvm-devel] [PATCH][QEMU] Change -hugetlb-path to -mem-path

2008-03-02 Thread Avi Kivity
Anthony Liguori wrote: This patch changes -hugetlb-path to -mem-path and also updates the code so that it works for hugetlbfs or tmpfs. Applied, thanks. -- error compiling committee.c: too many arguments to function

Re: [kvm-devel] I/O bandwidth control on KVM

2008-03-02 Thread Avi Kivity
Anthony Liguori wrote: Hi Ryo, Ryo Tsuruta wrote: Hello all, I've implemented a block device which throttles block I/O bandwidth, which I called dm-ioband, and been trying to throttle I/O bandwidth on KVM environment. But unfortunately it doesn't work well, the number of issued I/Os

[kvm-devel] [PATCH 5/8] x86: KVM guest: hypercall based pte updates and TLB flushes

2008-03-02 Thread Avi Kivity
-p translation in the host. - infer size of pte from guest mode v2-v3: - switch to one ioctl per paravirt feature - move hypercall handling to mmu.c v3-v4: - guest/host split - fix 32-bit truncation issues - adjust to mmu_op Signed-off-by: Marcelo Tosatti [EMAIL PROTECTED] Signed-off-by: Avi

[kvm-devel] [PATCH 4/8] KVM: MMU: hypercall based pte updates and TLB flushes

2008-03-02 Thread Avi Kivity
-by: Marcelo Tosatti [EMAIL PROTECTED] Signed-off-by: Avi Kivity [EMAIL PROTECTED] --- arch/x86/kvm/mmu.c | 135 +++- arch/x86/kvm/x86.c | 18 ++- include/asm-x86/kvm_host.h |4 + include/asm-x86/kvm_para.h | 29 + include/linux

[kvm-devel] [PATCH 0/8] KVM paravirtualized mmu support, v4

2008-03-02 Thread Avi Kivity
This patchset is based on Marcelo's v3. The biggest change is dropping the generic hypercall multicall in favor of an mmu specific hypercall. This brings the following benefits: - no need to check whether the various hypercalls are compatible (for example, you wouldn't want to allow a

[kvm-devel] [PATCH 6/8] x86: KVM guest: hypercall batching

2008-03-02 Thread Avi Kivity
to one ioctl per paravirt feature v3-v4: - adjust to mmu_op - helper for getting para_state without debug warnings Signed-off-by: Marcelo Tosatti [EMAIL PROTECTED] Signed-off-by: Avi Kivity [EMAIL PROTECTED] --- arch/x86/kernel/kvm.c | 62 +++- 1 files

Re: [kvm-devel] catch vmentry failure (was enable gfxboot on VMX)

2008-03-02 Thread Avi Kivity
Guillaume Thouvenin wrote: On Mon, 18 Feb 2008 10:39:31 +0100 Alexander Graf [EMAIL PROTECTED] wrote: So if you want to see a VMentry failure, just remove the SS patching and you'll see one. My guess would be that you see a lot of problems with otherwise working code too then, though,

Re: [kvm-devel] [kvm-ppc-devel] Top level kvm-userspace directory getting crowded ... need new dir for qemu dependencies

2008-03-02 Thread Avi Kivity
Jerone Young wrote: So I forgot to CC all the interested parties on this list (sorry about that I wasn't thinking at the time), but I did start up a conversation on linuxppc-dev on the subject of splitting out libfdt from dtc. Mainly to get the thought of what the dtc folks thought about

<    2   3   4   5   6   7   8   9   10   11   >