Re: [kvm-devel] [PATCH 2/3] [PATCH] unregister pci device

2008-03-27 Thread Avi Kivity
Glauber Costa wrote: If we fail after we have allocated the pci device, we have to get rid of it. Otherwise, a bogus device will be found on the bus Maybe, alter the order so the device is registered last thing. This may help avoid races with pci passthrough hotplug. -- error compiling

Re: [kvm-devel] [PATCH] KVM: MMU: Fix rmap_remove() race

2008-03-27 Thread Avi Kivity
Andrea Arcangeli wrote: On Wed, Mar 26, 2008 at 08:22:31PM +0100, Andrea Arcangeli wrote: what happens if invalidate_page runs after rmap_remove is returned (the spte isn't visible anymore by the rmap code and in turn by invalidate_page) but before the set_shadow_pte(nonpresent) runs.

Re: [kvm-devel] [PATCH v2] x86: don't allow KVM_CLOCK on Voyager or Visual WS

2008-03-27 Thread Avi Kivity
Randy Dunlap wrote: From: Randy Dunlap [EMAIL PROTECTED] Prevent failed randconfig builds with KVM_CLOCK being enabled on Voyager or VISWS. Applies, thanks. -- error compiling committee.c: too many arguments to function

Re: [kvm-devel] [PATCH] KVM: MMU: Fix rmap_remove() race

2008-03-27 Thread Avi Kivity
Andrea Arcangeli wrote: diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c index 30bf832..a49987c 100644 --- a/virt/kvm/kvm_main.c +++ b/virt/kvm/kvm_main.c @@ -741,6 +741,10 @@ static struct vm_operations_struct kvm_vcpu_vm_ops = { static int kvm_vcpu_mmap(struct file *file, struct

Re: [kvm-devel] kvm causing memory corruption? ~2.6.25-rc6

2008-03-27 Thread Avi Kivity
Dave Hansen wrote: On Wed, 2008-03-26 at 18:58 +0200, Avi Kivity wrote: Dave Hansen wrote: On Wed, 2008-03-26 at 11:50 +0200, Avi Kivity wrote: Dave Hansen wrote: I was getting some kvm userspace crashes trying to run a Windows guest. So, I decided to try

Re: [kvm-devel] kvm causing memory corruption? ~2.6.25-rc6

2008-03-27 Thread Avi Kivity
Avi Kivity wrote: Dave Hansen wrote: On Wed, 2008-03-26 at 18:58 +0200, Avi Kivity wrote: Dave Hansen wrote: On Wed, 2008-03-26 at 11:50 +0200, Avi Kivity wrote: Dave Hansen wrote: I was getting some kvm userspace crashes trying to run a Windows guest. So, I

Re: [kvm-devel] KVM Test result, kernel c0af88e.., userspace 0342df6..

2008-03-27 Thread Avi Kivity
Yunfeng Zhao wrote: Hi Alll, This is today's KVM test result against kvm.git c0af88e9014019f6392b06c11e836ca58acc7ede and kvm-userspace.git 0342df67ec22f3d9aa663949b72694e061c2edb2. 3. slab error in kmem_cache_destroy(): cache `kvm_vcpu':

Re: [kvm-devel] [PATCH 2/3] [PATCH] unregister pci device

2008-03-27 Thread Avi Kivity
Glauber Costa wrote: Avi Kivity wrote: Glauber Costa wrote: If we fail after we have allocated the pci device, we have to get rid of it. Otherwise, a bogus device will be found on the bus Maybe, alter the order so the device is registered last thing. This may help avoid races

Re: [kvm-devel] [RFC/PATCH 00/15 v3] kvm on big iron

2008-03-27 Thread Avi Kivity
Carsten Otte wrote: Many thanks for the review feedback we have received so far, and many thanks to Andrew for reviewing our common code memory management changes. I do greatly appreciate that :-). All important parts have been reviewed, all review feedback has been integrated in the code.

Re: [kvm-devel] [PATCH] ignore reads to the EOI register.

2008-03-27 Thread Avi Kivity
Andi Kleen wrote: Maciej W. Rozycki [EMAIL PROTECTED] writes: Linux performs reads to all registers written including this one deliberately using an RMW cycle to avoid triggering an erratum in some early Pentium integrated APICs. Obviously it does not matter for most of the world as

Re: [kvm-devel] manage number of VCPU and memory

2008-03-27 Thread Avi Kivity
Břeťa Vomočil wrote: Thanks, it worked... But I have one more question, is there also some command for changing actual memory like cpu_set for setting number of VCPUs? There's the balloon driver, but that is not yet merged. -- error compiling committee.c: too many arguments to

Re: [kvm-devel] [PATCH] KVM: MMU: Fix rmap_remove() race

2008-03-27 Thread Avi Kivity
Andrea Arcangeli wrote: On Thu, Mar 27, 2008 at 10:11:42AM +0200, Avi Kivity wrote: Erm I don't think this means what you think it means. This is the kernel/user communication area, used to pass exit data to userspace. It's not the memslot vma. Yep... only the kvm_vm_vm_ops can

Re: [kvm-devel] kvm causing memory corruption? ~2.6.25-rc6

2008-03-27 Thread Avi Kivity
Dave Hansen wrote: On Thu, 2008-03-27 at 12:10 +0200, Avi Kivity wrote: btw, is this with = 4GB RAM on the host? Well, are you asking whether I have PAE on or not? :) No, I'm asking whether there is a possibility of address truncation :) PAE by itself doesn't affect kvm much

Re: [kvm-devel] [patch 1/3] QEMU/KVM: separate thread for IO handling

2008-03-27 Thread Avi Kivity
Marcelo Tosatti wrote: I still don't understand this. Timer expiration ought to be processed in the iothread, when SIGALRM is dequeued, and be completely unrelated to whatever vcpu 0 is doing. Yes, now it is unrelated. But before the patch it wasnt. So currently the

Re: [kvm-devel] hugetlbfs not working

2008-03-27 Thread Avi Kivity
Anthony Liguori wrote: If you don't bail when ftruncate fails, does it work as expected for you? Perhaps older versions of hugetlbfs didn't support truncate. If you don't truncate, how can you change the file size? hugetlbfs doesn't support write(). I vaugely recall using ftruncate() on

Re: [kvm-devel] KVM Test result, kernel 680615e.., userspace 52be1a1..

2008-03-26 Thread Avi Kivity
Yunfeng Zhao wrote: Just find one new issue: *[ kvm-Bugs-1925889 ] slab error in kmem_cache_destroy(): cache `kvm_vcpu': https://sourceforge.net/tracker/?func=detailatid=893831aid=1925889group_id=180599 This error happened when reinsert kvm-intel.ko after creating and destroying several

Re: [kvm-devel] KVM Test result, kernel 680615e.., userspace 52be1a1..

2008-03-26 Thread Avi Kivity
Chris Wedgwood wrote: On Wed, Mar 26, 2008 at 02:25:11PM +0800, Yunfeng Zhao wrote: 2. booting smp windows guests has 30% chance of hang https://sourceforge.net/tracker/?func=detailatid=893831aid=1910923group_id=180599 Does it hang or bluescreen? What if you disable the

Re: [kvm-devel] kvm causing memory corruption? ~2.6.25-rc6

2008-03-26 Thread Avi Kivity
Dave Hansen wrote: I was getting some kvm userspace crashes trying to run a Windows guest. So, I decided to try a recent kernel (2.6.25-rc6-00333-ga4083c9) with the kvm kernel code that shipped with that kernel. This is fixed in 2.6.25-rc7. -- Do not meddle in the internals of kernels,

Re: [kvm-devel] [PATCH 0/20] dma_ops for i386

2008-03-26 Thread Avi Kivity
Glauber Costa wrote: Hello, Here there is a series of 20 patches that lays the foundations for using dma_ops in i386 in the very same way x86_64, as well as many other architectures already do. The functions themselves for i386 are placed in a pci-base_32.c, but just a few among them are

Re: [kvm-devel] [PATCH][QEMU] Use a separate device for in-kernel PIT (v2)

2008-03-26 Thread Avi Kivity
Anthony Liguori wrote: Avi Kivity wrote: Please separate the code movement and changes into separate patches. I'm not sure there's a great way to do this that preserves bisectability and results in meaningful history. I could leave the #ifdef's in i8254-kvm.c and then have a second patch

Re: [kvm-devel] [PATCH] Use QEMU functions to access guest memory for virtio

2008-03-26 Thread Avi Kivity
Anthony Liguori wrote: #define s_ld_u64(phys, field, type) \ ldq_phys(phys + offsetof(field, type)) And now we don't need individual accessors, or to encode the offsets as magic numbers. It's a nice thought but it doesn't work out in practice because most of these accessor

[kvm-devel] [PATCH] KVM: MMU: Fix rmap_remove() race

2008-03-26 Thread Avi Kivity
the pages to be freed so we need to flush just once. Signed-off-by: Avi Kivity [EMAIL PROTECTED] --- arch/x86/kvm/mmu.c | 66 +++ include/asm-x86/kvm_host.h |8 + 2 files changed, 67 insertions(+), 7 deletions(-) diff --git a/arch/x86/kvm/mmu.c b

Re: [kvm-devel] buliding and testing PowerPC KVM

2008-03-26 Thread Avi Kivity
Jerone Young wrote: * Sorry was going for paste, and somehow hit send. The earlier post looked much simpler. So it's actually really easy using cross compiler to build everything. I use my laptop and then copy over to our nfs root that our boards use. Here are some instructions I

Re: [kvm-devel] [RFC] QEMU/KVM: dedicated IO thread

2008-03-26 Thread Avi Kivity
Marcelo Tosatti wrote: QEMU/KVM: separate thread for IO handling Move IO processing from vcpu0 to a dedicated thread. This removes load on vcpu0 by allowing better cache locality and also improves latency. We can now block signal handling for IO events, so sigtimedwait won't race with

Re: [kvm-devel] kvm causing memory corruption? ~2.6.25-rc6

2008-03-26 Thread Avi Kivity
Dave Hansen wrote: On Wed, 2008-03-26 at 11:50 +0200, Avi Kivity wrote: Dave Hansen wrote: I was getting some kvm userspace crashes trying to run a Windows guest. So, I decided to try a recent kernel (2.6.25-rc6-00333-ga4083c9) with the kvm kernel code that shipped with that kernel

Re: [kvm-devel] [RFC/PATCH 01/15] preparation: provide hook to enable pgstes in user pagetable

2008-03-25 Thread Avi Kivity
Carsten Otte wrote: Avi Kivity wrote: Well, dup_mm() can't work (and now that I think about it, for more reasons -- what if the process has threads?). We lock out multithreaded users already, -EINVAL. Would be much better if this can be avoided. It's surprising. -- Any sufficiently

[kvm-devel] [GIT PULL] KVM fixes for 2.6.25-rc6

2008-03-25 Thread Avi Kivity
and individual patches follow: arch/x86/kvm/mmu.c | 18 ++ arch/x86/kvm/vmx.c |7 ++- 2 files changed, 16 insertions(+), 9 deletions(-) Avi Kivity (3): KVM: VMX: Restore tss even on x86_64 KVM: MMU: Fix is_rmap_pte() with io ptes KVM: MMU: Fix memory

Re: [kvm-devel] KVM: register the kvm mmu cache with the shrinker.

2008-03-25 Thread Avi Kivity
Izik Eidus wrote: this is the shrinker patch with all comments applied beside adding aging mechanism it look like the aging mechanism is not really needed and therefor for now it isn't implemented. From 8503a57ae88ba819e4eac6371172772c98b485f0 Mon Sep 17 00:00:00 2001 From: Izik Eidus

Re: [kvm-devel] [PATCH][QEMU] Use a separate device for in-kernel PIT (v2)

2008-03-25 Thread Avi Kivity
Anthony Liguori wrote: Part of the feedback we received from Fabrice about the KVM patches for QEMU is that we should create a separate device for the in-kernel APIC to avoid having lots of if (kvm_enabled()) within the APIC code that were difficult to understand why there were needed. This

Re: [kvm-devel] [kvm-ppc-devel] [PATCH 0 of 7] [v6] PowerPC kvm-userspace patches

2008-03-25 Thread Avi Kivity
Jerone Young wrote: Fix big bug found by Anthony, as well formating comments that he commented on. Bombs away! This set of patches enables the following: -Device tree Support - Add libfdt to kvm-userspace - Add bamboo device tree to qemu source

Re: [kvm-devel] [RFC] QEMU/KVM: dedicated IO thread

2008-03-25 Thread Avi Kivity
Marcelo Tosatti wrote: Avi was concerned that this would cause problems with migration. I haven't specifically tested it yet, but it seems there will be no problems introduced by this change: the IO thread will stop all vcpu's in the same way the vcpu0 thread did before. I believe this is

Re: [kvm-devel] [PATCH] kvm.h: __user requires compiler.h

2008-03-25 Thread Avi Kivity
Christian Borntraeger wrote: Am Montag, 24. März 2008 schrieb Avi Kivity: Christian Borntraeger wrote: Am Freitag, 21. März 2008 schrieb Anthony Liguori: This patch breaks QEMU build when doing a 'make sync'. When you do a top-level ./configure, libkvm is built

Re: [kvm-devel] buliding and testing PowerPC KVM

2008-03-25 Thread Avi Kivity
Hollis Blanchard wrote: On Fri, 2008-03-21 at 13:02 +0200, Avi Kivity wrote: Other than that, and the few minor comments that popped up, this (very nice) patchset will be very easy to merge. IIRC you mentioned it is possible for me to get an s390 account; this will be very useful

Re: [kvm-devel] [kvm-ppc-devel] [PATCH] Add -Werror to libkvm compile

2008-03-25 Thread Avi Kivity
Jerone Young wrote: It does work with gcc 4.2.3 . Though no idea if gcc-4.3 4.4 would workout. Though they should. I'll need to to compile them and give them a try. While I'm a fan of -Werror, I have to agree with Anthony it can cause no end of pain to users if they have a slightly

Re: [kvm-devel] [RFC/PATCH 01/15] preparation: provide hook to enable pgstes in user pagetable

2008-03-24 Thread Avi Kivity
Martin Schwidefsky wrote: On Sun, 2008-03-23 at 12:15 +0200, Avi Kivity wrote: Can you convert the page tables at a later time without doing a wholesale replacement of the mm? It should be a bit easier to keep people off the pagetables than keep their grubby mitts off the mm itself

Re: [kvm-devel] [Qemu-devel] [PATCH] [RFC] Fix time drift of rtc clock + general support

2008-03-24 Thread Avi Kivity
Paul Brook wrote: On Sunday 23 March 2008, Dor Laor wrote: --- a/qemu/hw/irq.c +++ b/qemu/hw/irq.c @@ -30,6 +30,8 @@ struct IRQState { int n; }; +uint32_t qemu_irq_acked[NR_IRQ_WORDS]; This is absolute rubbish. The whole point of the IRQ framework is that it doesn't

Re: [kvm-devel] [Qemu-devel] [PATCH] [RFC] Fix time drift of rtc clock + general support

2008-03-24 Thread Avi Kivity
Avi Kivity wrote: Paul Brook wrote: a new timer will be fired to try inject it again soon (==0.1msec) If the guest is missing interrupts, the chances of a 0.1ms interval working are not great. Most likely It's either going trigger immediately, or be delayed significantly

Re: [kvm-devel] Qemu-kvm is leaking my memory ???

2008-03-24 Thread Avi Kivity
Zdenek Kabelac wrote: 2008/3/23, Avi Kivity [EMAIL PROTECTED]: Avi Kivity wrote: I see the same issue too now, and am investigating. The attached patch should fix the issue. It is present in 2.6.25-rc6 only, and not in kvm.git, which is why few people noticed it. Hi

Re: [kvm-devel] [Qemu-devel] [PATCH] [RFC] Fix time drift of rtc clock + general support

2008-03-24 Thread Avi Kivity
Paul Brook wrote: On Monday 24 March 2008, Avi Kivity wrote: Paul Brook wrote: On Sunday 23 March 2008, Dor Laor wrote: --- a/qemu/hw/irq.c +++ b/qemu/hw/irq.c @@ -30,6 +30,8 @@ struct IRQState { int n; }; +uint32_t qemu_irq_acked[NR_IRQ_WORDS

Re: [kvm-devel] Qemu-kvm is leaking my memory ???

2008-03-24 Thread Avi Kivity
Avi Kivity wrote: Tested - and actually seeing no difference in my case of memory leak. Still it looks like over 30M per execution of qemu is lost. (tested with fresh 2.6.25-rc6 with your patch) Can you double check? 2.6.25-rc6 definitely leaks without, and here it doesn't

Re: [kvm-devel] [PATCH] kvm.h: __user requires compiler.h

2008-03-24 Thread Avi Kivity
Christian Borntraeger wrote: Am Freitag, 21. März 2008 schrieb Anthony Liguori: This patch breaks QEMU build when doing a 'make sync'. When you do a top-level ./configure, libkvm is built with kerneldir pointing to kvm-userspace/kernel/include. While linux/kvm.h is present there, there

Re: [kvm-devel] question: HPET for multiple VMs

2008-03-23 Thread Avi Kivity
Anthony Liguori wrote: Avi Kivity wrote: And I would like to ask right and wrong to implement the functionality in terms of need and efficiency (scalability and time accuracy). I think that for newer kernels we already have the desired accuracy. We're not always good at exploiting

Re: [kvm-devel] [PATCH] kvm.h: __user requires compiler.h

2008-03-23 Thread Avi Kivity
Anthony Liguori wrote: This patch breaks QEMU build when doing a 'make sync'. When you do a top-level ./configure, libkvm is built with kerneldir pointing to kvm-userspace/kernel/include. While linux/kvm.h is present there, there isn't a linux/compiler.h. The host kernelpath isn't

Re: [kvm-devel] [PATCH] Move kvm_get_pit to libkvm.c common code

2008-03-23 Thread Avi Kivity
Hollis Blanchard wrote: Don't compile kvm_*_pit() on architectures whose currently supported platforms do not contain a PIT. Signed-off-by: Hollis Blanchard [EMAIL PROTECTED] diff --git a/libkvm/libkvm.h b/libkvm/libkvm.h --- a/libkvm/libkvm.h +++ b/libkvm/libkvm.h @@ -539,6 +539,7 @@

Re: [kvm-devel] [PATCH][QEMU] Use a separate device for in-kernel PIT

2008-03-23 Thread Avi Kivity
Anthony Liguori wrote: Hollis Blanchard wrote: This patch solves annoying qemu build breakage hitting PowerPC around struct kvm_pit_state, so that's another vote in favor... I have an updated version of the patch but it's breaking the build b/c something fouled up right now with

Re: [kvm-devel] [PATCH] 'make clean' is eager to delete config.mak files

2008-03-23 Thread Avi Kivity
Ryota OZAKI wrote: Hi all, Current 'make clean' deletes config.mak files so that we have to ./configure again after doing that. This behavior is different from that of standard 'make clean'. This patch introduces 'make distclean' to delete config.mak files instead of 'make clean',

Re: [kvm-devel] [RFC PATCH 1/5] lguest: mmap backing file

2008-03-23 Thread Avi Kivity
Anthony Liguori wrote: If we're going to mod the kernel, how about a mmap this part of their address space and having the kernel keep the mappings in sync. But I think that if we want to get speed, we should probably be doing the copy between address spaces in-kernel so we

Re: [kvm-devel] [ANNOUNCE] kvm-guest-drivers-windows-1

2008-03-23 Thread Avi Kivity
Avi Kivity wrote: Daniel P. Berrange wrote: On Tue, Mar 18, 2008 at 05:01:09PM +0200, Avi Kivity wrote: This is the first release of network drivers for Windows guests running on a kvm host. The drivers are intended for Windows 2000 and Windows XP 32-bit. kvm-61 or later

Re: [kvm-devel] [RFC/PATCH 01/15] preparation: provide hook to enable pgstes in user pagetable

2008-03-23 Thread Avi Kivity
Heiko Carstens wrote: What you've done with dup_mm() is probably the brute-force way that I would have done it had I just been trying to make a proof of concept or something. I'm worried that there are a bunch of corner cases that haven't been considered. What if someone else is poking

Re: [kvm-devel] Qemu-kvm is leaking my memory ???

2008-03-23 Thread Avi Kivity
Zdenek Kabelac wrote: 2008/3/19, Avi Kivity [EMAIL PROTECTED]: Zdenek Kabelac wrote: 2008/3/19, Avi Kivity [EMAIL PROTECTED]: Zdenek Kabelac wrote: 2008/3/16, Avi Kivity [EMAIL PROTECTED]: The -vnc switch, so there's no local X server. A remote X server should be fine

Re: [kvm-devel] Qemu-kvm is leaking my memory ???

2008-03-23 Thread Avi Kivity
Avi Kivity wrote: I see the same issue too now, and am investigating. The attached patch should fix the issue. It is present in 2.6.25-rc6 only, and not in kvm.git, which is why few people noticed it. -- error compiling committee.c: too many arguments to function diff --git a/arch/x86

Re: [kvm-devel] [Qemu-devel] Coredump from qemu

2008-03-23 Thread Avi Kivity
Zdenek Kabelac wrote: Hi During execution of qemu I've got this crash: #0 0x00407a29 in qemu_mod_timer (ts=0x2e8cf90, expire_time=130685351465) at /usr/src/debug/kvm-63/qemu/vl.c:1073 #1 0x00425590 in pcnet_ioport_writew (opaque=0x0, addr=1836332585, val=8090216) at

Re: [kvm-devel] question: HPET for multiple VMs

2008-03-22 Thread Avi Kivity
Ryota OZAKI wrote: Hi all, Current kvm allows only one VM to use HPET. Is there a plan to implement a functionality to allow multiple VMs to use HPET? If so, how about the status of that? If you use the dyntick clock option (the default, IIRC), and a newer host kernel, then the kernel

Re: [kvm-devel] [RFC/PATCH 05/15] KVM_MAX_VCPUS

2008-03-21 Thread Avi Kivity
Carsten Otte wrote: Hollis Blanchard wrote: On Thu, 2008-03-20 at 17:24 +0100, Carsten Otte wrote: Index: kvm/include/linux/kvm_host.h === --- kvm.orig/include/linux/kvm_host.h +++ kvm/include/linux/kvm_host.h @@

Re: [kvm-devel] [RFC/PATCH 00/15] kvm on big iron

2008-03-21 Thread Avi Kivity
Carsten Otte wrote: This patch series introduces a backend for kvm to run on IBM System z machines that uses the mainframe's sie virtualization capability. This work runs 64bit guests on z800/z890/z900/z990/z9/z10 class machines with a 64bit linux host. Userspace will follow once we're done

Re: [kvm-devel] [RFC/PATCH 06/15] kvm-s390: sie intercept handling

2008-03-21 Thread Avi Kivity
Carsten Otte wrote: /* for KVM_RUN, returned by mmap(vcpu_fd, offset=0) */ struct kvm_run { @@ -138,6 +139,14 @@ struct kvm_run { __u32 is_write; __u32 pad; } tpr_access; + /* KVM_EXIT_S390_SIEIC */ +

Re: [kvm-devel] [RFC/PATCH 15/15] guest: virtio device support, and kvm hypercalls

2008-03-21 Thread Avi Kivity
Carsten Otte wrote: Currently we dont have PCI on s390. Making virtio_pci usable for s390 seems more complicated that providing an own stub. This virtio stub is similar to the lguest one, the memory for the descriptors and the device detection is made via additional mapped memory on top of

Re: [kvm-devel] [kvm-ia64-devel] Cross-arch support for make sync in userspace

2008-03-20 Thread Avi Kivity
Zhang, Xiantao wrote: Avi Kivity wrote: Zhang, Xiantao wrote: Avi Kivity wrote: Zhang, Xiantao wrote: Hi, Avi Currently, make sync in userspace only syncs x86-specific heads from kernel source due to hard-coded in Makefile. Do you have plan to provide cross

Re: [kvm-devel] kvm-guest-drivers patch for RHEL4

2008-03-20 Thread Avi Kivity
david ahern wrote: Backport of the virtio drivers to RHEL4. The patch applies against the kvm-guest-drivers-linux-1 release but also contains diffs for Anthony's spin_lock_irqsave/restore patch. Of note is that to build for RHEL4 Makefile is renamed to Makefile-2.6 so that Makefile can

Re: [kvm-devel] KVM: MMU: add KVM_ZAP_GFN ioctl

2008-03-20 Thread Avi Kivity
Marcelo Tosatti wrote: Add an ioctl to zap all mappings to a given gfn. This allows userspace remove the QEMU process mappings and the page without causing inconsistency. I'm thinking of comitting rmap_nuke() to kvm.git, and the rest to the external module, since this is only needed on

Re: [kvm-devel] KVM Test result, kernel f1080a0.., userspace 49cf2d2..

2008-03-20 Thread Avi Kivity
Yunfeng Zhao wrote: Following issues fixed: 1. qcow based smp linux guests likely hang https://sourceforge.net/tracker/index.php?func=detailaid=1901980group_id=180599atid=893831 2. smp windows installer crashes while rebooting

Re: [kvm-devel] [RFC PATCH 0/4] Inter-guest virtio I/O example with lguest

2008-03-20 Thread Avi Kivity
Anthony Liguori wrote: Avi Kivity wrote: Rusty Russell wrote: Hi all, Just finished my prototype of inter-guest virtio, using networking as an example. Each guest mmaps the other's address space and uses a FIFO for notifications. Isn't that a security hole (hole? chasm

Re: [kvm-devel] [RFC PATCH 0/4] Inter-guest virtio I/O example with lguest

2008-03-20 Thread Avi Kivity
Anthony Liguori wrote: Avi Kivity wrote: Anthony Liguori wrote: Avi Kivity wrote: Each guest's host userspace mmaps the other guest's address space. The userspace then does a copy on both the tx and rx paths. Well, that's better security-wise (I'd still prefer to avoid it, so we can

Re: [kvm-devel] [RFC PATCH 1/5] lguest: mmap backing file

2008-03-20 Thread Avi Kivity
Anthony Liguori wrote: Rusty Russell wrote: From: Paul TBBle Hampson [EMAIL PROTECTED] This creates a file in $HOME/.lguest/ to directly back the RAM and DMA memory mappings created by map_zeroed_pages. I created a test program recently that measured the latency of a

Re: [kvm-devel] [RFC PATCH 0/4] Inter-guest virtio I/O example with lguest

2008-03-20 Thread Avi Kivity
Anthony Liguori wrote: You can have the file descriptor be opened O_RDONLY so trust isn't an issue. Reading is just as bad as writing. This implies trusting the other userspace, which is not a good thing. Let the kernel copy, we already trust it, and it has more resources to do the

Re: [kvm-devel] windows acpi time drift

2008-03-19 Thread Avi Kivity
Anthony Liguori wrote: Why don't we just introduce a vm-ioctl interface for a one-shot programmable timer? It could be programmed in userspace, and when it fires, we can drop down to userspace with a special exit code. We could then introduce an interrupt queuing mechanism in the kernel

Re: [kvm-devel] [PATCH] convert init_rmode_tss to slots_lock

2008-03-19 Thread Avi Kivity
Marcelo Tosatti wrote: init_rmode_tss was forgotten during the conversion from mmap_sem to slots_lock. Applied, thanks. There are several sites reading the slots data without taking slots_lock, including tdp_page_fault. I'll be sending a patch to move acquision to vcpu_run

Re: [kvm-devel] script for watching kvm_stat

2008-03-19 Thread Avi Kivity
Christian Ehrhardt wrote: I added the kvm_stat support to ppc to watch my guest while executing e.g. to check things like what does my guest do when I see nothing ;-) To be able to do that I also needed a script that reports in a iostat/vmstat like style, because of that I wrote a small

Re: [kvm-devel] manage number of VCPU and memory

2008-03-19 Thread Avi Kivity
břeťa wrote: Hi, I want to ask for a help in searching specific documetation. I am looking for any information about how to change the number of VCPU and amount of memory while the VM is running (or at least the magic keywords for google; I was successful in searching information about

Re: [kvm-devel] vmwarevga merge clash

2008-03-19 Thread Avi Kivity
Anthony Liguori wrote: Avi Kivity wrote: Trying to merge qemu-cvs, there's a conflict in vmwarevga between two changes that appear to be identical in purpose, only implemented differently: 6d262b07a2046ed1fa0ec3fd61f00efbfcd5a9ef (master) and 5aa90452c52e3a914e1f6bbf34331507fd7c5d52

Re: [kvm-devel] [ANNOUNCE] kvm-driver-disc-20080318

2008-03-19 Thread Avi Kivity
Anthony Liguori wrote: david ahern wrote: Are you interested in collecting ports of the drivers for various distributions? What we would like to do, is have the kvm-guest-drivers-linux.git tree autogenerate backports for as far back as we need them. Posting what you needed to do for

Re: [kvm-devel] [PATCH] Fix sci irq set when acpi timer about to wrap

2008-03-19 Thread Avi Kivity
Dor Laor wrote: On Sun, 2008-03-16 at 19:08 +0200, Avi Kivity wrote: Dor Laor wrote: From 498f162fc9d9fb897c756273c481101a44a220de Mon Sep 17 00:00:00 2001 From: Dor Laor [EMAIL PROTECTED] Date: Thu, 13 Mar 2008 00:11:41 +0200 Subject: [PATCH] Fix sci irq set when acpi timer about

Re: [kvm-devel] windows acpi time drift

2008-03-19 Thread Avi Kivity
Anthony Liguori wrote: Avi Kivity wrote: The fourth is probably impossible from userspace (and very difficult in the kernel). What makes it impossible to do in userspace? If you managed a tsc_offset in userspace, you would of course need to adjust that tsc_offset within the kernel

Re: [kvm-devel] [ANNOUNCE] kvm-driver-disc-20080318

2008-03-19 Thread Avi Kivity
david ahern wrote: Avi Kivity wrote: It might be difficult for RHEL 4, which is 2.6.5 based IIRC. If the magic required is more that 500 millithaums, then an independent driver would be better. RHEL4 is based on 2.6.9. What do you mean by magic required is more that 500

Re: [kvm-devel] Qemu-kvm is leaking my memory ???

2008-03-19 Thread Avi Kivity
Zdenek Kabelac wrote: 2008/3/16, Avi Kivity [EMAIL PROTECTED]: Zdenek Kabelac wrote: Hello Recently I'm using qemu-kvm on fedora-rawhide box with my own kernels (with many debug options) I've noticed that over the time my memory seems to disappear somewhere. Here is my

Re: [kvm-devel] Qemu-kvm is leaking my memory ???

2008-03-19 Thread Avi Kivity
Zdenek Kabelac wrote: 2008/3/19, Avi Kivity [EMAIL PROTECTED]: Zdenek Kabelac wrote: 2008/3/16, Avi Kivity [EMAIL PROTECTED]: Zdenek Kabelac wrote: Hello Recently I'm using qemu-kvm on fedora-rawhide box with my own kernels (with many debug options) I've noticed

Re: [kvm-devel] windows acpi time drift

2008-03-19 Thread Avi Kivity
Dor Laor wrote: On Wed, 2008-03-19 at 17:39 +0200, Avi Kivity wrote: Anthony Liguori wrote: Avi Kivity wrote: The fourth is probably impossible from userspace (and very difficult in the kernel). What makes it impossible to do in userspace? If you managed

Re: [kvm-devel] Cross-arch support for make sync in userspace

2008-03-19 Thread Avi Kivity
Zhang, Xiantao wrote: Hi, Avi Currently, make sync in userspace only syncs x86-specific heads from kernel source due to hard-coded in Makefile. Do you have plan to provide cross-arch support for that? No plans. I'll apply patches though. But don't you need kernel changes which make it

Re: [kvm-devel] tools to dump guest memory and generate core file

2008-03-18 Thread Avi Kivity
david ahern wrote: Attaching gdb to qemu you work with addresses as seen by the qemu process; the idea is to work with addresses as seen inside the guest. For example, in the qemu console you can examine guest kernel memory such as task structs using guest kernel based addresses: (qemu) x

Re: [kvm-devel] [PATCH] shrinker support for the mmu cache

2008-03-18 Thread Avi Kivity
Marcelo Tosatti wrote: On Mon, Mar 17, 2008 at 04:41:18PM +0200, Avi Kivity wrote: Marcelo Tosatti wrote: While aging is not too hard to do, I don't think it would add much in practice; we rarely observe mmu shadow pages being recycled due to memory pressure. So this is mostly

Re: [kvm-devel] [patch 0/3] QEMU: virtio should register power of two sized regions

2008-03-18 Thread Avi Kivity
Marcelo Tosatti wrote: Otherwise the guest will miscalculate the region size. Applied all, thanks. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic. - This SF.net email is

Re: [kvm-devel] [PATCH] use slots_lock to protect writes to the wall clock

2008-03-18 Thread Avi Kivity
Glauber Costa wrote: As Marcelo pointed out, we need slots_lock to protect against slots changing under our nose during wall clock writing. This patch address this issue. Applied, thanks. This lock is fairly annoying. What do you think about taking it in vcpu_run unconditionally and

Re: [kvm-devel] [PATCH 0/3] kvmclock: shutdown clock before reboot

2008-03-18 Thread Avi Kivity
Glauber Costa wrote: Avi, This series now apply ontop of kvm.git. Only the needed function from machine_ops is made non-static. Applied, thanks. Ingo, can you carry the first two patches as well? They are 602ac559a208ba44d5879a8e6381a379b376a8b7 and

Re: [kvm-devel] [PATCH] kvm.h: __user requires compiler.h

2008-03-18 Thread Avi Kivity
Christian Borntraeger wrote: include/linux/kvm.h defines struct kvm_dirty_log to [...] union { void __user *dirty_bitmap; /* one bit per page */ __u64 padding; }; __user requires compiler.h to compile. Currently, this works on x86 only

[kvm-devel] vmwarevga merge clash

2008-03-18 Thread Avi Kivity
Trying to merge qemu-cvs, there's a conflict in vmwarevga between two changes that appear to be identical in purpose, only implemented differently: 6d262b07a2046ed1fa0ec3fd61f00efbfcd5a9ef (master) and 5aa90452c52e3a914e1f6bbf34331507fd7c5d52 (qemu-cvs). I think the correct action is to drop

Re: [kvm-devel] [PATCH 0/3] kvmclock: shutdown clock before reboot

2008-03-18 Thread Avi Kivity
Avi Kivity wrote: Glauber Costa wrote: Avi, This series now apply ontop of kvm.git. Only the needed function from machine_ops is made non-static. Applied, thanks. Er, compilation breaks if CONFIG_KEXEC is not set (i386). -- Do not meddle in the internals of kernels

Re: [kvm-devel] [PATCH] use slots_lock to protect writes to the wall clock

2008-03-18 Thread Avi Kivity
Glauber Costa wrote: This lock is fairly annoying. What do you think about taking it in vcpu_run unconditionally and only dropping it while in guest mode? Most exits are mmu (or with npt, mmio) so they need to take it anyway. Can't see the point. This is taken before updates to the wall

Re: [kvm-devel] [PATCH] use slots_lock to protect writes to the wall clock

2008-03-18 Thread Avi Kivity
Glauber Costa wrote: [EMAIL PROTECTED] linux-2.6 (master)]$ git grep down_read.*slots_lock arch/x86/kvm/ | wc -l 16 We take the lock for read 16 times, could be narrowed down to probably once (with a drop and re-take around guest mode). Since it will be written to so rarely, that's

Re: [kvm-devel] [PATCH 0/3 - resend] kvmclock reboot

2008-03-18 Thread Avi Kivity
Glauber Costa wrote: Avi, Hope this series is okay now. Thanks for the testing Applied, thanks. [Once a patchset has been applied and pushed (as seen on kvm-commits), I prefer incremental patches] -- Do not meddle in the internals of kernels, for they are subtle and quick to

Re: [kvm-devel] [PATCH 0/3 - resend] kvmclock reboot

2008-03-18 Thread Avi Kivity
Glauber Costa wrote: [Once a patchset has been applied and pushed (as seen on kvm-commits), I prefer incremental patches] But I think this is a very good case of an exception, since the applied patches would break bisect. I prefer to hear damn glommer! because of that than damn glommer!!

[kvm-devel] [ANNOUNCE] kvm-guest-drivers-windows-1

2008-03-18 Thread Avi Kivity
This is the first release of network drivers for Windows guests running on a kvm host. The drivers are intended for Windows 2000 and Windows XP 32-bit. kvm-61 or later is needed in the host. At the moment only binaries are available. The drivers are available from the download page of the

Re: [kvm-devel] [ANNOUNCE] kvm-guest-drivers-windows-1

2008-03-18 Thread Avi Kivity
Daniel P. Berrange wrote: On Tue, Mar 18, 2008 at 05:01:09PM +0200, Avi Kivity wrote: This is the first release of network drivers for Windows guests running on a kvm host. The drivers are intended for Windows 2000 and Windows XP 32-bit. kvm-61 or later is needed in the host

Re: [kvm-devel] [patch 17/24] QEMU/KVM: add cpu_unregister_io_memory and make io mem table index dynamic

2008-03-18 Thread Avi Kivity
Amit Shah wrote: So does the following fix the problem? Yes, it does. Thanks. Okay, applied. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic. - This SF.net email is sponsored

[kvm-devel] [ANNOUNCE] kvm-driver-disc-20080318

2008-03-18 Thread Avi Kivity
This is the first release of the kvm drivers disc -- a collection of kvm guest drivers packaged as an ISO 9660 CD-ROM for easy installation. The driver disc can be obtained from the kvm download page, below. Initial release: - kvm-guest-drivers-linux-1 - kvm-guest-drivers-windows-1

Re: [kvm-devel] [ANNOUNCE] kvm-guest-drivers-windows-1

2008-03-18 Thread Avi Kivity
Ian Kirk wrote: Avi Kivity wrote: This is the first release of network drivers for Windows guests running on a kvm host. Any plans for Windows Server IIUC the XP drivers should also work for Windows 2003 Server. Windows 2008 Server and x64 variants are planned. and block

Re: [kvm-devel] [PATCH/RFC 1/2] anon-inodes: Remove fd_install() from anon_inode_getfd()

2008-03-17 Thread Avi Kivity
Christoph Hellwig wrote: On Sat, Mar 08, 2008 at 06:45:34PM -0800, Roland Dreier wrote: spin_lock(kvm_lock); + if (--kvm-refcount) { + spin_lock(kvm_lock); obvious typo here... Indeed. Any comments from the kvm developers in this approach? The

Re: [kvm-devel] tools to dump guest memory and generate core file

2008-03-17 Thread Avi Kivity
david ahern wrote: Does anyone know of tools that can dump memory for a qemu guest with addresses as seen by the guest and generate a core file? For instance, say you know the guest is running a 32-bit linux kernel with a 1G/3G split. Then you would want to dump 1G of memory starting

Re: [kvm-devel] [patch 0/3] QEMU balloon support

2008-03-17 Thread Avi Kivity
Marcelo Tosatti wrote: Hi Avi, Good that you're back. On Sun, Mar 16, 2008 at 04:00:06PM +0200, Avi Kivity wrote: Marcelo Tosatti wrote: This patchset resends Anthony's QEMU balloon support plus: - Truncates the target size to ram size - Enables madvise() conditioned

Re: [kvm-devel] [PATCH] debugfs directory for each VM

2008-03-17 Thread Avi Kivity
Ryota OZAKI wrote: Hi all, This patch allows a VM to have own directory on debugfs, that contains statics only for the VM. Each directory is identified by the pid of the VM (ie qemu). I tried this patch under several host kernel versions, .22, .23, and .24, and confirmed things work out

Re: [kvm-devel] KVM Test result, kernel a16664b.., userspace 3017d05.. one new issue

2008-03-17 Thread Avi Kivity
Yunfeng Zhao wrote: Hi All, This is today's KVM test result against kvm.git a16664b59065b8ae877b213e68a6f962ac359ca4 and kvm-userspace.git 3017d054a6a9f37bfffee4ebf0bf52a51c9860b5. One new issue: 1. booting smp windows guests has 30% chance of hang

<    1   2   3   4   5   6   7   8   9   10   >