Hi Avi,
Attached is the patch to implement the emulation of instruction
inc : opcodes 0x40-0x47
&
dec : opcodes 0x48-0x4f
Please Apply.
--
Thanks & Regards,
Nitin
Open Source Technology Center, Intel Corporation
-
Hi Avi,
I was trying to avoid vm86 mode completely, by using emulation for
all the real mode code emulation. It is doing better than vm86 mode, but
I am seeing one issue with this approch.
The emulator is failing due to this code. Seems like the execution
need to go back to qemu to finish so
On Tue, 2007-10-16 at 13:12 -0700, Avi Kivity wrote:
> Why do you think it is better? I would have thought that vm86 is much
> faster.
>
I am seeing execution going to strange places in vm86 mode. That issue
is not coming in the emulation.
> I thought of doing it this way:
>
> - try to run nor
Hi Avi,
Attached is the patch implementing these eflags manipulating
instructions:
cmc, clc, cli, sti
opcodes: 0xf5, 0xf8, 0xfa, 0xfb
please Apply.
--
Thanks & Regards,
Nitin
Open Source Technology Center, Intel Corporation
--
Hi Avi,
Attached is the patch to implement mul instruction from the group 3
opcodes.
Please Apply.
--
Thanks & Regards,
Nitin
Open Source Technology Center, Intel Corporation
-
The mind is like a parachute; it works much better whe
Hi Avi,
Attached is the patch to implement emulation of instruction aas
please apply.
--
Thanks & Regards,
Nitin
Open Source Technology Center, Intel Corporation
-
The mind is like a parachute; it works much better when it'
Hi Avi,
Attached is the patch to implement emulation of further xchg
instructions.
--
Thanks & Regards,
Nitin
Open Source Technology Center, Intel Corporation
-
The mind is like a parachute; it works much better when
Hi Avi,
Attached is the patch to implement emulation of instruction:
jb (opcode 0xe3)
Please apply.
--
Thanks & Regards,
Nitin
Open Source Technology Center, Intel Corporation
-
The mind is like a parachute; it works much better
Hi Avi,
Attached is the patch to implement emulation of instructions
mov rl, imm8 (opcodes 0xb0-0xb3)
mov rh, imm8 (opcodes 0xb4-0xb7)
mov r, imm (opcodes0xb8-0xbf)
please apply.
--
Thanks & Regards,
Nitin
Open Source Technology Center, Intel Corporation
--
Hi Avi,
Attached is the patch to implement emulation of instructions
stc (opcode 0xf9)
cld (opcode 0xfc)
Please Apply.
--
Thanks & Regards,
Nitin
Open Source Technology Center, Intel Corporation
-
The mind is like a parachute; i
On Tue, 2007-10-30 at 17:53 -0700, Avi Kivity wrote:
> This is missing a "break;".
Hi Avi,
You are right. The break statement should be there. It was my mistake
while getting the patch out from the test tree to the push tree. Even if
it is a small patch I should not retype it.
>
> How are you
On Tue, 2007-10-30 at 18:06 -0700, Avi Kivity wrote:
> Nitin A Kamble wrote:
> > Hi Avi,
> > Attached is the patch to implement emulation of instructions
> > mov rl, imm8 (opcodes 0xb0-0xb3)
> > mov rh, imm8 (opcodes 0xb4-0xb7)
> > mov r, imm (opcodes0
On Tue, 2007-10-30 at 18:02 -0700, Avi Kivity wrote:
> This is 'cld', but it looks like you're setting DF?
Good catch. Same problem hand copy of the patch.
It should look like this.
+ case 0xfc: /* cld */
+ ctxt->eflags &= ~EFLG_DF;
--
Thanks & Regards,
Nitin
Open Source Tech
On Wed, 2007-10-31 at 09:45 +0200, Avi Kivity wrote:
> 'git gui' and 'git add -i' allow picking specific hunks out of a
> larger change.
This seems like better way of cutting patches. Thanks a lot for sharing
the trick.
--
Thanks & Regards,
Nitin
Open Source Technology Center, Intel Corporation
.
commit a757404387d3580f1a9dca86b2caf142103c6bdf
Author: Nitin A Kamble <[EMAIL PROTECTED]>
Date: Fri Aug 10 17:30:16 2007 -0700
Implement the function emulator_write_std()
Signed-off-by: Nitin A Kamble <[EMAIL PROTECTED]>
diff --git a/drivers/kvm/kvm_main.c b/drivers
x27;s open.
commit 1d77b7ad2bcb20858dd66d9653952a8d1cc0a153
Author: Nitin A Kamble <[EMAIL PROTECTED]>
Date: Fri Aug 10 18:36:12 2007 -0700
Implement instruction "jmp rel" opcode 0xe9
Signed-off-by: Nitin A Kamble <[EMAIL PROTECTED]>
diff --git a/drivers/kvm/x86_em
-
The mind is like a parachute; it works much better when it's open.
commit 38f7db6830c862cd0470aaa07cabe616ff741d69
Author: Nitin A Kamble <[EMAIL PROTECTED]>
Date: Fri Aug 10 18:48:05 2007 -0700
Implement "jmp rel short" opcode: 0xeb
Signed-off-by: Nitin
g the emulator
> into a decoder and executor).
>
> (and, when defining the macro, indent the contents)
>
> --
> error compiling committee.c: too many arguments to function
>
>
commit dd675f122c14adac40c9ac1eb5864de60330cc8c
Author: Nitin A Kamble <[EMAIL PROTECTED]>
Avi,
In my opinion converting this small function to file-scope function,
would make code look ugly. I think the earlier Macro definition was
better.
On Thu, 2007-08-16 at 03:25 -0700, Avi Kivity wrote:
> > + inline void jmp_rel(int rel)
> > + {
> > + _eip += (int)(rel
---
The mind is like a parachute; it works much better when it's open
commit 16312d9a828af54d3d4ad7dc0a9a1f038de72bf6
Author: Nitin A Kamble <[EMAIL PROTECTED]>
Date: Thu Aug 16 19:19:44 2007 -0700
Implement emulation of instruction
and al imm8 (opco
hute; it works much better when it's open
commit 7f712b2d8cda67299e17473356050490a5c05be5
Author: Nitin A Kamble <[EMAIL PROTECTED]>
Date: Thu Aug 16 19:47:19 2007 -0700
Implementing emulation of instructions:
push reg (opcode 0x50-0x57)
Signed-off-by: Nitin A
Hi Avi,
If you are fine with macro then attached are the updated patches for
"jmp rel" & "jmp rel short" instruction emulation.
On Thu, 2007-08-16 at 13:34 -0700, Nitin A Kamble wrote:
> Avi,
> In my opinion converting this small function to file-scope fu
at is happening.
--
Thanks & Regards,
Nitin
Open Source Technology Center, Intel Corporation
-
The mind is like a parachute; it works much better when it's open
commit c609269ebc40e385ec5a82363d5ee4a49388776c
Author: Nitin A K
s,
Nitin
Open Source Technology Center, Intel Corporation
-
The mind is like a parachute; it works much better when it's open
commit 47259a989606e37e5ba24f6722a8258368e6d0a2
Author: Nitin A Kamble <[EMAIL PROTECTED]>
Date: Fri Aug 17 18:39:29 2007 -0700
Implementin
f74ed9d883f1faccd11405d6775344
Author: Nitin A Kamble <[EMAIL PROTECTED]>
Date: Fri Aug 17 18:47:18 2007 -0700
Implementing emulation of instructions:
push reg (opcode 0x50-0x57)
Signed-off-by: Nitin A Kamble <[EMAIL PROTECTED]>
diff --git a/drivers/kvm/x86_em
ike a parachute; it works much better when it's open
commit bd06a9509bbd4a7df1277f743bc9cfcc8498bad8
Author: Nitin A Kamble <[EMAIL PROTECTED]>
Date: Tue Aug 28 20:58:38 2007 -0700
Implement the instruction
push imm8
opcode: 0x6a
Signed-off-by: Nitin A Kamble <[EMAIL
orks much better when it's open
commit d05cbb38ee1603dceb390d0b5ad6c3789364e940
Author: Nitin A Kamble <[EMAIL PROTECTED]>
Date: Tue Aug 28 21:06:36 2007 -0700
Implement emulation of instruction
opcode: 0xe8
call (near)
Signed-off-by: Nitin A Kamble <[EMAIL PROTECT
hute; it works much better when it's open
commit c291035169e88bc3115e9692720f84bcbc50d0ed
Author: Nitin A Kamble <[EMAIL PROTECTED]>
Date: Tue Aug 28 21:27:24 2007 -0700
Implement emulation of instruction
pushf
opcode: 0x9c
Signed-off-by: Nitin A Kamble <[EMAIL
logy Center, Intel Corporation
-
The mind is like a parachute; it works much better when it's open
commit 0af0b63e81cc345009d63703e5a7228fc9edd4d2
Author: Nitin A Kamble <[EMAIL PROTECTED]>
Date: Thu Sep 6 16:46:31 2007
t: Wednesday, September 12, 2007 1:28 AM
> To: Laurent Vivier
> Cc: Kamble, Nitin A; kvm-devel
> Subject: Re: [kvm-devel] [PATCH] (big) real mode emulation - push imm8
>
> Laurent Vivier wrote:
> > Avi Kivity wrote:
> >
> >> Nitin A Kamble wrote:
> >&
much better when it's open
On Thu, 2007-09-13 at 11:15 -0700, Nitin A Kamble wrote:
> Hi Avi,
>Attached is the updated version of the patch, to match the latest tip
> of the tree.
>
> Please apply.
diff --git a/drivers/kvm/x86_emulate.c b/drivers/kvm/x86_emulate.c
index 18c2b
tion
-
The mind is like a parachute; it works much better when it's open
commit 3a29a61aabc299ccd5b41d50207e2dfbc7b38236
Author: Nitin A Kamble <[EMAIL PROTECTED]>
Date: Thu Sep 13 14:57:28 2007 -0700
Implement emulation of instruction:
jump conditional rel
opcodes:
el Corporation
-
The mind is like a parachute; it works much better when it's open
commit c8ea6835e9e4af29339b6abd7800fdd570a23d3a
Author: Nitin A Kamble <[EMAIL PROTECTED]>
Date: Thu Sep 13 19:21:43 2007 -0700
Implement emulation of more jump conditional instructions
jcc sh
ute; it works much better when it's open
commit e7b48d62cfaf4261ec228ee58bcb3d30b434ab8c
Author: Nitin A Kamble <[EMAIL PROTECTED]>
Date: Thu Sep 13 19:30:26 2007 -0700
Correct the emulation of or instruction, opcodes 0xc & 0xd.
Signed-off-by: Nitin A Kamble <[EMAIL P
ke a parachute; it works much better when it's open
commit e976ee1c4f89211f971c704c28617dd6a3b84dc9
Author: Nitin A Kamble <[EMAIL PROTECTED]>
Date: Thu Sep 13 19:59:00 2007 -0700
Correct behavior of instruction:
mov
opcodes: 0x88 - 0x8b
Signed-off-by: Nitin A Kamble &l
tion
-
The mind is like a parachute; it works much better when it's open
commit 6c2690c56af49dd810b504d7c5b8983e4bf25604
Author: Nitin A Kamble <[EMAIL PROTECTED]>
Date: Thu Sep 13 19:39:56 2007 -0700
Implement emulation of instructions:
sub al imm8 (opcode 0x2c)
ke a parachute; it works much better when it's open
commit 637711de0b9b2431c32cfdd880fed6baabec3982
Author: Nitin A Kamble <[EMAIL PROTECTED]>
Date: Thu Sep 13 19:52:21 2007 -0700
Correct emulation of instruction
cmp
opcodes: 0x3c & 0x3d
Signed-off-by: Nit
ke a parachute; it works much better when it's open
commit 910f3167e57c224206a2ef5fe2cb248494724087
Author: Nitin A Kamble <[EMAIL PROTECTED]>
Date: Thu Sep 13 20:18:51 2007 -0700
Implement emulation of instruction
mov rl/rh/r imm
opcodes: 0xb0 - 0xbf
Signed-off-by:
poration
-
The mind is like a parachute; it works much better when it's open
commit 113fa85a2bc3f6f4b53c4f748f5b4b3144572595
Author: Nitin A Kamble <[EMAIL PROTECTED]>
Date: Thu Sep 13 20:26:57 2007 -0700
Intialize src.val & dst.val, to fix bugs in certain instruction emulatio
much better when it's open
commit 7e19bcbeb8feebf9ee80c0948ca64c03729d7dda
Author: Nitin A Kamble <[EMAIL PROTECTED]>
Date: Thu Sep 13 20:07:11 2007 -0700
Implement emulation of instruction:
lea r16/r32, m
opcode: 0x8d:
Signed-off-by: Nitin A Kamble &l
; it works much better when it's open
commit 7bbe21004014731ac7f645de879a91b9160e6a1d
Author: Nitin A Kamble <[EMAIL PROTECTED]>
Date: Thu Sep 13 20:45:34 2007 -0700
Implement emulation of instruction:
popf
opcode: 0x9d
Signed-off-by: Nitin A Kamble <[EMAIL
On Fri, 2007-09-14 at 10:08 -0700, Avi Kivity wrote:
> This seems like it is papering over other bugs. Some instructions use
> src.val or dst.val without having decoded the src or dst operand.
>
> Which instructions are these? Can we fix them instead?
Instructions using 8bit operands such as
; it works much better when it's open
commit d67d775e429b32da323715f52f4ef4ce03a9031c
Author: Nitin A Kamble <[EMAIL PROTECTED]>
Date: Fri Sep 14 14:25:23 2007 -0700
Implement emulation of instruction:
jump absolute r/m
opcode: 0xff /4
Signed-off-by: Nitin A
ke a parachute; it works much better when it's open
commit ea06cdff59c8f9d74be2f6d7b7c4137a7c150a50
Author: Nitin A Kamble <[EMAIL PROTECTED]>
Date: Fri Sep 14 14:55:33 2007 -0700
Implement emulation of instruction:
dec reg
opcode: 0x48 - 0x4f
Signed-off-by: Nitin A
; it works much better when it's open
commit c47e7ccd17a9fe79e0f5e8b3198d6cd84e7c85ed
Author: Nitin A Kamble <[EMAIL PROTECTED]>
Date: Fri Sep 14 14:47:42 2007 -0700
Implement emulation of instruction:
inc reg
opcode: 0x40 - 0x47
Signed-off-by: Nitin A Kamble &l
Hi Avi,
Some emulation case statements have gone to wrong place in the
upstream tree. This patch fixes that. This time I have created the patch
using the git-format-patch command as per your suggestion.
Please apply.
--
Thanks & Regards,
Nitin
Open Source Technology Center, Intel Corporation
Hi Laurent,
Sorry for calling by alst name. You 1st & last both names are totally
new to me. Are these french names?
I understand your explanation. I was worried about code getting
misplaced due to automatic merges.
--
Thanks & Regards,
Nitin
Open Source Technology Center, Intel Corporation
--
47 matches
Mail list logo
