Re: Fw: Proposal: remove commit_timestamp.json
On Mon, Oct 17, 2016 at 11:57 AM, Jacob Peck wrote: > Why is this suddenly an issue? A better answer is that I have been working on distribution for the last three days. Problems come up in that context that we completely ignore normally. Let's be clear. The new signon message is *much* better than before when using git. That's not going away. EKR -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To unsubscribe from this group and stop receiving emails from it, send an email to leo-editor+unsubscr...@googlegroups.com. To post to this group, send email to leo-editor@googlegroups.com. Visit this group at https://groups.google.com/group/leo-editor. For more options, visit https://groups.google.com/d/optout.
Re: Fw: Proposal: remove commit_timestamp.json
From: Edward K. Ream To: leo-editor Sent: Monday, October 17, 2016 1:40 PM Subject: Re: Fw: Proposal: remove commit_timestamp.json On Mon, Oct 17, 2016 at 11:57 AM, Jacob Peck wrote: I'm with Terry on this -- the commit_timestamp.json file has been immensely helpful in debugging user issues in the past. Relegating the commit hash to some funky filename is not an acceptable option. Ok. I can live with this. Ok :-) next time I want to make a point I'll just ask Jacob to post it :-) I would like the hook that creates commit_timestamp.json to use the new format. I'll see what I can do today. It might be a source of confusion if the commit hash and timestamp sometimes agree (i.e. when .git is present), and sometimes don't (i.e. when the commit hash comes from git log -1). If I'm understanding the new format, the githash Leo displays in the log would be for the preceding commit, when .git is not present, and the current commit, when it is? Or perhaps it doesn't display the hash when .git is not present, but then there's not much point having it in the .json file. This is how the use of "20160722143100" as a replacement for a commit hash evolved. I think it's a better atomic identifier than "Mon Oct 17 05:07:33 2016". For one thing it has no spaces in it. Cheers -Terry Git hooks are painless. Why is this suddenly an issue? Because they aren't painless :-). And useless if a dev forgets to copy them into leo-editor/.git when cloning a new repo. In any event, the old code in leoVersion.py is much simpler than the old, which knew way too much the structure of .git folders. The new code just uses git log -1. EKR-- You received this message because you are subscribed to the Google Groups "leo-editor" group. To unsubscribe from this group and stop receiving emails from it, send an email to leo-editor+unsubscr...@googlegroups.com. To post to this group, send email to leo-editor@googlegroups.com. Visit this group at https://groups.google.com/group/leo-editor. For more options, visit https://groups.google.com/d/optout. -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To unsubscribe from this group and stop receiving emails from it, send an email to leo-editor+unsubscr...@googlegroups.com. To post to this group, send email to leo-editor@googlegroups.com. Visit this group at https://groups.google.com/group/leo-editor. For more options, visit https://groups.google.com/d/optout.
Re: Fw: Proposal: remove commit_timestamp.json
On Mon, Oct 17, 2016 at 11:57 AM, Jacob Peck wrote: > I'm with Terry on this -- the commit_timestamp.json file has been > immensely helpful in debugging user issues in the past. Relegating the > commit hash to some funky filename is not an acceptable option. > Ok. I can live with this. I would like the hook that creates commit_timestamp.json to use the new format. I'll see what I can do today. Git hooks are painless. Why is this suddenly an issue? > Because they aren't painless :-). And useless if a dev forgets to copy them into leo-editor/.git when cloning a new repo. In any event, the old code in leoVersion.py is much simpler than the old, which knew way too much the structure of .git folders. The new code just uses git log -1. EKR -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To unsubscribe from this group and stop receiving emails from it, send an email to leo-editor+unsubscr...@googlegroups.com. To post to this group, send email to leo-editor@googlegroups.com. Visit this group at https://groups.google.com/group/leo-editor. For more options, visit https://groups.google.com/d/optout.
Re: Fw: Proposal: remove commit_timestamp.json
I'm with Terry on this -- the commit_timestamp.json file has been
immensely helpful in debugging user issues in the past. Relegating the
commit hash to some funky filename is not an acceptable option.
Git hooks are painless. Why is this suddenly an issue?
-->Jake
On 10/17/2016 12:50 PM, 'Terry Brown' via leo-editor wrote:
[meant to post to the list, not just Edward]
*From:* Edward K. Ream
*To:* leo-editor
*Cc:* terry_n_br...@yahoo.com
*Sent:* Monday, October 17, 2016 11:23 AM
*Subject:* Re: Proposal: remove commit_timestamp.json
On Monday, October 17, 2016 at 9:04:52 AM UTC-5, Terry Brown
wrote:
I'm not really sure this has any utility :-/
I am about to release Leo 5.4b1. Imo, the new scheme works
very well.
Leo /always/ reports first 8 characters of the git hash and
git date, even when there is no git around, which is almost
all the time for most users.
This works because official releases now /do/ include
commit_timestamp.json.
The script that creates daily builds should be modified to
create commit_timestamp.json /in the new format./ Once that is
done, everything will "just work".
As noted earlier in this thread, there is no script that creates
the daily builds, there hasn't been since
April 6, 2014:
https://groups.google.com/d/msg/leo-editor/Hr-ygxeMPm4/tfCZxOCcv4wJ
When you use a link like:
https://github.com/leo-editor/leo-editor/archive/master@{5 days
ago}.zip
GitHub sends you leo-editor-438e...92e4.zip. That's what we have
now on the Leo downloads page.
So with the new scheme all we have for user interaction / bug
resolution is asking the user the funky name of the folder they're
running from, if we re-link "Latest" to ...{0 days ago}.zip
*Even if there was a script*, it wouldn't help that much, even
running at 15 minute intervals could create significant confusion
re latest versions.
Cheers -Terry
To recap, the new scheme is /much /better than the old because:
- No git hooks are ever needed.
- There will be no git merge conflicts on
commit_timestamp.json once people remove their git hooks.
- Leo /always/ reports the hash and the date of the build that
is being run, or will, once the daily build script is updated.)
- The code in leoVersion.py is really simple.
Edward
--
You received this message because you are subscribed to the Google
Groups "leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send
an email to leo-editor+unsubscr...@googlegroups.com
.
To post to this group, send email to leo-editor@googlegroups.com
.
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to the Google Groups
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to leo-editor+unsubscr...@googlegroups.com.
To post to this group, send email to leo-editor@googlegroups.com.
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.
Fw: Proposal: remove commit_timestamp.json
[meant to post to the list, not just Edward]
From: Edward K. Ream
To: leo-editor
Cc: terry_n_br...@yahoo.com
Sent: Monday, October 17, 2016 11:23 AM
Subject: Re: Proposal: remove commit_timestamp.json
On Monday, October 17, 2016 at 9:04:52 AM UTC-5, Terry Brown wrote:
I'm not really sure this has any utility :-/
I am about to release Leo 5.4b1. Imo, the new scheme works very well.
Leo always reports first 8 characters of the git hash and git date, even when
there is no git around, which is almost all the time for most users.
This works because official releases now do include commit_timestamp.json.
The script that creates daily builds should be modified to create
commit_timestamp.json in the new format. Once that is done, everything will
"just work".
As noted earlier in this thread, there is no script that creates the daily
builds, there hasn't been since April 6, 2014:
https://groups.google.com/d/msg/leo-editor/Hr-ygxeMPm4/tfCZxOCcv4wJ
When you use a link
like:https://github.com/leo-editor/leo-editor/archive/master@{5 days ago}.zip
GitHub sends you leo-editor-438e...92e4.zip. That's what we have now on the
Leo downloads page.
So with the new scheme all we have for user interaction / bug resolution is
asking the user the funky name of the folder they're running from, if we
re-link "Latest" to ...{0 days ago}.zip
*Even if there was a script*, it wouldn't help that much, even running at 15
minute intervals could create significant confusion re latest versions.
Cheers -Terry
To recap, the new scheme is much better than the old because:
- No git hooks are ever needed.
- There will be no git merge conflicts on commit_timestamp.json once people
remove their git hooks.
- Leo always reports the hash and the date of the build that is being run, or
will, once the daily build script is updated.)
- The code in leoVersion.py is really simple.
Edward
--
You received this message because you are subscribed to the Google Groups
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to leo-editor+unsubscr...@googlegroups.com.
To post to this group, send email to leo-editor@googlegroups.com.
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.
