Re: [libav-devel] [libav-commits] w32thread: port fixes to pthread_cond_broadcast() from x264.

2011-12-08 Thread Sergey Radionov
One more thing, it hangs on WaitForSingleObject(win32_cond->semaphore, INFINITE); ( http://git.libav.org/?p=libav.git;a=blob;f=libavcodec/w32pthreads.h;hb=HEAD#l215 ) 2011/12/9 Sergey Radionov > Very strange thing happens, when I apply this http://pastie.org/2989007 patch, > then all start to wo

[libav-devel] [PATCH] doc: update documentation to use avconv

2011-12-08 Thread Luca Barbato
--- doc/avserver.texi | 24 doc/indevs.texi| 46 +++--- doc/muxers.texi| 38 +++--- doc/protocols.texi | 44 ++-- 4 files changed, 76 insertions

[libav-devel] [PATCH] doc: rework the faq

2011-12-08 Thread Luca Barbato
Remove stale questions and try to make it less offensive. --- doc/faq.texi | 359 +++--- 1 files changed, 39 insertions(+), 320 deletions(-) diff --git a/doc/faq.texi b/doc/faq.texi index affe88b..3379725 100644 --- a/doc/faq.texi +++ b/doc/faq

Re: [libav-devel] [libav-commits] w32thread: port fixes to pthread_cond_broadcast() from x264.

2011-12-08 Thread Sergey Radionov
Is all of it helpful? 2011/12/9 Ronald S. Bultje > Hi, > > On Thu, Dec 8, 2011 at 5:48 PM, Sergey Radionov wrote: > >> I've found exact place of deadlock. >> it is >> http://git.videolan.org/?p=ffmpeg.git;a=blob;f=libavcodec/pthread.c;hb=HEAD#l859 >> >> patch for debug tracing: http://pastie.or

Re: [libav-devel] [libav-commits] w32thread: port fixes to pthread_cond_broadcast() from x264.

2011-12-08 Thread Sergey Radionov
another variant, right before deadlock (stopped on breakpoint on pthread_cond_wait(&p->progress_cond, &p->progress_mutex);), >&"thread apply all bt\n" >~"\nThread 14 (Thread 1812.0xac0):\n" >~"#0 0x7d61cbeb in ?? ()\n" >~"#1 0x7da43de0 in RPCRT4!NdrpReleaseTypeFormatString () from C:\\WINDOWS\\s

Re: [libav-devel] [libav-commits] w32thread: port fixes to pthread_cond_broadcast() from x264.

2011-12-08 Thread Sergey Radionov
>&"thread apply all bt\n" >~"\nThread 14 (Thread 1460.0x7c):\n" >~"#0 0x7d61002e in ?? ()\n" >~"#1 0x7d6671d1 in ?? ()\n" >~"#2 0x in ?? ()\n" >~"\nThread 13 (Thread 1460.0xb14):\n" >~"#0 0x7d61c846 in ?? ()\n" >~"#1 0x7d4d8c0d in RegisterWaitForInputIdle () from C:\\WINDOWS\\syswow6

Re: [libav-devel] [libav-commits] w32thread: port fixes to pthread_cond_broadcast() from x264.

2011-12-08 Thread Sergey Radionov
Very strange thing happens, when I apply this http://pastie.org/2989007 patch, then all start to work. I don't uderstand what it mean, but maybe it can help. 2011/12/9 Sergey Radionov > I've found exact place of deadlock. > it is > http://git.videolan.org/?p=ffmpeg.git;a=blob;f=libavcodec/pthrea

Re: [libav-devel] [libav-commits] w32thread: port fixes to pthread_cond_broadcast() from x264.

2011-12-08 Thread Sergey Radionov
2011/12/9 Ronald S. Bultje > Hi, > > On Thu, Dec 8, 2011 at 5:48 PM, Sergey Radionov wrote: > >> I've found exact place of deadlock. >> it is >> http://git.videolan.org/?p=ffmpeg.git;a=blob;f=libavcodec/pthread.c;hb=HEAD#l859 >> >> patch for debug tracing: http://pastie.org/2988933 >> debug log:

Re: [libav-devel] [libav-commits] w32thread: port fixes to pthread_cond_broadcast() from x264.

2011-12-08 Thread Ronald S. Bultje
Hi, On Thu, Dec 8, 2011 at 5:48 PM, Sergey Radionov wrote: > I've found exact place of deadlock. > it is > http://git.videolan.org/?p=ffmpeg.git;a=blob;f=libavcodec/pthread.c;hb=HEAD#l859 > > patch for debug tracing: http://pastie.org/2988933 > debug log: http://pastie.org/2988951 > call stack:

Re: [libav-devel] [libav-commits] w32thread: port fixes to pthread_cond_broadcast() from x264.

2011-12-08 Thread Sergey Radionov
if it not what you want, tell me, I try to do something more appropriate, but I don't know what exactly will help you. 2011/12/9 Sergey Radionov > I've found exact place of deadlock. > it is > http://git.videolan.org/?p=ffmpeg.git;a=blob;f=libavcodec/pthread.c;hb=HEAD#l859 > > patch for debug tr

Re: [libav-devel] [libav-commits] w32thread: port fixes to pthread_cond_broadcast() from x264.

2011-12-08 Thread Sergey Radionov
I've found exact place of deadlock. it is http://git.videolan.org/?p=ffmpeg.git;a=blob;f=libavcodec/pthread.c;hb=HEAD#l859 patch for debug tracing: http://pastie.org/2988933 debug log: http://pastie.org/2988951 call stack: http://pastie.org/2988941 2011/12/9 Sergey Radionov > > > 2011/12/8 Rona

Re: [libav-devel] [libav-commits] w32thread: port fixes to pthread_cond_broadcast() from x264.

2011-12-08 Thread Ronald S. Bultje
Hi, On Thu, Dec 8, 2011 at 3:58 PM, Sergey Radionov wrote: > 2011/12/8 Ronald S. Bultje > >> On Thu, Dec 8, 2011 at 5:42 AM, Jean-Baptiste Kempf wrote: >> >>> Hello *, >>> >>> On Wed, Dec 07, 2011 at 07:32:00PM +0100, Ronald S. Bultje wrote : >>> > w32thread: port fixes to pthread_cond_broadca

[libav-devel] [PATCH] fate: Added 8 tests for utvideo decoder

2011-12-08 Thread Aneesh Dogra
--- tests/fate2.mak | 24 tests/ref/fate/utvideo_rgb_left |4 tests/ref/fate/utvideo_rgb_median|5 + tests/ref/fate/utvideo_rgba_left |5 + tests/ref/fate/utvideo_rgba_median |5 + tests/ref/fate/utvide

[libav-devel] [PATCH] cljr: remove unused code

2011-12-08 Thread Paul B Mahol
--- libavcodec/cljr.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/libavcodec/cljr.c b/libavcodec/cljr.c index 65b7433..a5ee738 100644 --- a/libavcodec/cljr.c +++ b/libavcodec/cljr.c @@ -29,7 +29,6 @@ #include "put_bits.h" typedef struct CLJRContext { -AVCodecC

Re: [libav-devel] [libav-commits] w32thread: port fixes to pthread_cond_broadcast() from x264.

2011-12-08 Thread Sergey Radionov
2011/12/8 Ronald S. Bultje > Hi, > > > On Thu, Dec 8, 2011 at 5:42 AM, Jean-Baptiste Kempf wrote: > >> Hello *, >> >> On Wed, Dec 07, 2011 at 07:32:00PM +0100, Ronald S. Bultje wrote : >> > w32thread: port fixes to pthread_cond_broadcast() from x264. >> >> This improves the situation quite a bit

[libav-devel] [PATCH] Add CLJR encoding and decoding regression tests

2011-12-08 Thread Paul B Mahol
--- tests/codec-regression.sh |5 + tests/ref/vsynth1/cljr|4 tests/ref/vsynth2/cljr|4 3 files changed, 13 insertions(+), 0 deletions(-) create mode 100644 tests/ref/vsynth1/cljr create mode 100644 tests/ref/vsynth2/cljr diff --git a/tests/codec-regression.sh

Re: [libav-devel] [PATCH] Add CLJR encoding and decoding regression tests

2011-12-08 Thread Måns Rullgård
Paul B Mahol writes: > --- > tests/codec-regression.sh |5 + > tests/ref/vsynth1/cljr|4 > tests/ref/vsynth2/cljr|4 > 3 files changed, 13 insertions(+), 0 deletions(-) > create mode 100644 tests/ref/vsynth1/cljr > create mode 100644 tests/ref/vsynth2/cljr > >

[libav-devel] [PATCH] Add CLJR encoding and decoding regression tests

2011-12-08 Thread Paul B Mahol
--- tests/codec-regression.sh |5 + tests/ref/vsynth1/cljr|4 tests/ref/vsynth2/cljr|4 3 files changed, 13 insertions(+), 0 deletions(-) create mode 100644 tests/ref/vsynth1/cljr create mode 100644 tests/ref/vsynth2/cljr diff --git a/tests/codec-regression.sh

Re: [libav-devel] [PATCH 6/7] doc: extend external library coverage

2011-12-08 Thread Diego Biurrun
On Thu, Dec 08, 2011 at 02:32:38AM +0100, Luca Barbato wrote: > > --- a/doc/general.texi > +++ b/doc/general.texi > @@ -9,26 +9,81 @@ > + > +@section Libvpx libvpx > +@float NOTE > +x264 is under the GNU Public License Version 2 > +(see @url{http://www.gnu.org/licenses/old-licenses/gpl-2.0.html}

Re: [libav-devel] [PATCH 5/7] doc: split platform specific information

2011-12-08 Thread Diego Biurrun
On Thu, Dec 08, 2011 at 02:32:37AM +0100, Luca Barbato wrote: > Move the platform specific information in a stand alone file. > --- doc: move platform-specific information into its own file I don't really have much of an opinion, so if you prefer it this way, it's fine with me. Diego ___

Re: [libav-devel] RFC: ISO C90 warnings

2011-12-08 Thread Sean McGovern
On Thursday, December 8, 2011, Sean McGovern wrote: > Hi folks, > > Looks like the altivec swscale files have the same warning (wow are those files ever a preprocessor soup eyesore!). > My sincere apologies -- I meant *postproc*, not swscale. -- Sean McG.

Re: [libav-devel] [PATCH] Install libavfilter/vsrc_buffer.h

2011-12-08 Thread Luca Barbato
On 08/12/11 20:27, Andrey Utkin wrote: Subject: [PATCH] Install libavfilter/vsrc_buffer.h Because it declares API necessary for filtering apps We might rename it soon, but we might change that part of the api as well. The patch should be ok. lu -- Luca Barbato Gentoo/linux http://dev.gent

[libav-devel] [PATCH] Install libavfilter/vsrc_buffer.h

2011-12-08 Thread Andrey Utkin
Subject: [PATCH] Install libavfilter/vsrc_buffer.h Because it declares API necessary for filtering apps --- libavfilter/Makefile |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libavfilter/Makefile b/libavfilter/Makefile index e9eaf95..bc05f1d 100644 --- a/libavfilter/Ma

[libav-devel] RFC: ISO C90 warnings

2011-12-08 Thread Sean McGovern
Hi folks, I was trawling through my PPC build logs and noticed the following: /BUILD/libav-fate/src/libavcodec/ptx.c:91:9: warning; ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] Looking at it, I could just put curly brackets around it to start a new block and shus

[libav-devel] [PATCH 3/3] cljr: K&R cosmetics

2011-12-08 Thread Paul B Mahol
On 12/8/11, Diego Biurrun wrote: > --- > libavcodec/cljr.c | 43 +++ > 1 files changed, 23 insertions(+), 20 deletions(-) > LGTM ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailma

[libav-devel] [PATCH 2/3] cljr: return a more sensible value when encountering invalid headers

2011-12-08 Thread Paul B Mahol
On 12/8/11, Diego Biurrun wrote: > --- > libavcodec/cljr.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > OK ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 1/3] cljr: drop unnecessary emms_c() calls without MMX code

2011-12-08 Thread Kostya Shishkov
On Thu, Dec 08, 2011 at 07:05:59PM +0100, Diego Biurrun wrote: > --- > libavcodec/cljr.c |4 > 1 files changed, 0 insertions(+), 4 deletions(-) the whole patchset looks good ___ libav-devel mailing list libav-devel@libav.org https://lists.libav

[libav-devel] [PATCH 1/3] cljr: drop unnecessary emms_c() calls without MMX code

2011-12-08 Thread Paul B Mahol
On 12/8/11, Diego Biurrun wrote: > --- > libavcodec/cljr.c |4 > 1 files changed, 0 insertions(+), 4 deletions(-) > OK ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

[libav-devel] [PATCH 2/3] cljr: return a more sensible value when encountering invalid headers

2011-12-08 Thread Diego Biurrun
--- libavcodec/cljr.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libavcodec/cljr.c b/libavcodec/cljr.c index bc70d1b..187e86d 100644 --- a/libavcodec/cljr.c +++ b/libavcodec/cljr.c @@ -61,7 +61,7 @@ static int decode_frame(AVCodecContext *avctx, if(buf_size/av

[libav-devel] [PATCH 3/3] cljr: K&R cosmetics

2011-12-08 Thread Diego Biurrun
--- libavcodec/cljr.c | 43 +++ 1 files changed, 23 insertions(+), 20 deletions(-) diff --git a/libavcodec/cljr.c b/libavcodec/cljr.c index 187e86d..65b7433 100644 --- a/libavcodec/cljr.c +++ b/libavcodec/cljr.c @@ -28,9 +28,9 @@ #include "get_bits.h" #

[libav-devel] [PATCH 1/3] cljr: drop unnecessary emms_c() calls without MMX code

2011-12-08 Thread Diego Biurrun
--- libavcodec/cljr.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/libavcodec/cljr.c b/libavcodec/cljr.c index 6071807..bc70d1b 100644 --- a/libavcodec/cljr.c +++ b/libavcodec/cljr.c @@ -92,8 +92,6 @@ static int decode_frame(AVCodecContext *avctx, *picture = a->

Re: [libav-devel] [PATCH] avconv: support stream specifiers in -metadata and -map_metadata

2011-12-08 Thread Kostya Shishkov
On Thu, Dec 08, 2011 at 03:24:57PM +0100, Alexandra Khirnova wrote: > --- > avconv.c| 207 +++--- > doc/avconv.texi | 38 -- > 2 files changed, 149 insertions(+), 96 deletions(-) > > diff --git a/avconv.c b/avconv.c > index 54aa89

Re: [libav-devel] [PATCH] doc: update demuxers section

2011-12-08 Thread Diego Biurrun
On Thu, Dec 08, 2011 at 05:37:16PM +0100, Luca Barbato wrote: > Cleanup tags usage and update commandline examples. clean up, command line Other than that, patch OK. Diego ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailm

[libav-devel] [PATCH] doc: update demuxers section

2011-12-08 Thread Luca Barbato
Cleanup tags usage and update commandline examples. --- doc/demuxers.texi |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/demuxers.texi b/doc/demuxers.texi index fc03459..c3049dd 100644 --- a/doc/demuxers.texi +++ b/doc/demuxers.texi @@ -49,19 +49,19 @@ sequence o

[libav-devel] [PATCH] doc: update demuxers section

2011-12-08 Thread Luca Barbato
Cleanup tags usage and update commandline examples. --- doc/demuxers.texi |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/demuxers.texi b/doc/demuxers.texi index fc03459..d16bd48 100644 --- a/doc/demuxers.texi +++ b/doc/demuxers.texi @@ -49,19 +49,19 @@ sequence o

Re: [libav-devel] [libav-commits] w32thread: port fixes to pthread_cond_broadcast() from x264.

2011-12-08 Thread Ronald S. Bultje
Hi, On Thu, Dec 8, 2011 at 5:42 AM, Jean-Baptiste Kempf wrote: > Hello *, > > On Wed, Dec 07, 2011 at 07:32:00PM +0100, Ronald S. Bultje wrote : > > w32thread: port fixes to pthread_cond_broadcast() from x264. > > This improves the situation quite a bit, but isn't perfect. > > Noticeable on 7,

Re: [libav-devel] [PATCH] cljr: group encode/decode parts under single ifdefs

2011-12-08 Thread Kostya Shishkov
On Thu, Dec 08, 2011 at 03:36:38PM +, Mans Rullgard wrote: > This groups the encode/decode parts under single ifdefs and > eliminates the encode_init() function as it merely calls > common_init(). Also fix whitespace in moved code. > > Signed-off-by: Mans Rullgard > --- > libavcodec/cljr.c

Re: [libav-devel] [PATCH] ffmpeg: eliminate unsubstantiated comment previously removed from avconv

2011-12-08 Thread Anton Khirnov
On Thu, 08 Dec 2011 16:30:35 +0100, Diego Biurrun wrote: > On Thu, Dec 08, 2011 at 04:24:08PM +0100, Anton Khirnov wrote: > > > > And since it'll be removed soon anyway (I'm thinking shortly after the > > release/before the bump), there's no point to this patch. > > Then I wonder why the docume

[libav-devel] [PATCH] cljr: group encode/decode parts under single ifdefs

2011-12-08 Thread Mans Rullgard
This groups the encode/decode parts under single ifdefs and eliminates the encode_init() function as it merely calls common_init(). Also fix whitespace in moved code. Signed-off-by: Mans Rullgard --- libavcodec/cljr.c | 88 - 1 files changed

Re: [libav-devel] [PATCH] ffmpeg: eliminate unsubstantiated comment previously removed from avconv

2011-12-08 Thread Kostya Shishkov
On Thu, Dec 08, 2011 at 04:30:35PM +0100, Diego Biurrun wrote: > On Thu, Dec 08, 2011 at 04:24:08PM +0100, Anton Khirnov wrote: > > > > And since it'll be removed soon anyway (I'm thinking shortly after the > > release/before the bump), there's no point to this patch. > > Then I wonder why the do

Re: [libav-devel] [PATCH] ffmpeg: eliminate unsubstantiated comment previously removed from avconv

2011-12-08 Thread Luca Barbato
On 08/12/11 16:30, Diego Biurrun wrote: On Thu, Dec 08, 2011 at 04:24:08PM +0100, Anton Khirnov wrote: And since it'll be removed soon anyway (I'm thinking shortly after the release/before the bump), there's no point to this patch. Then I wonder why the documentation was never updated and sti

Re: [libav-devel] [PATCH] ffmpeg: eliminate unsubstantiated comment previously removed from avconv

2011-12-08 Thread Diego Biurrun
On Thu, Dec 08, 2011 at 04:24:08PM +0100, Anton Khirnov wrote: > > And since it'll be removed soon anyway (I'm thinking shortly after the > release/before the bump), there's no point to this patch. Then I wonder why the documentation was never updated and still mostly speaks of ffmpeg. Diego ___

Re: [libav-devel] [PATCH] ffmpeg: eliminate unsubstantiated comment previously removed from avconv

2011-12-08 Thread Anton Khirnov
On Thu, 08 Dec 2011 16:08:27 +0100, Diego Biurrun wrote: > On Thu, Dec 08, 2011 at 03:03:15PM +, Måns Rullgård wrote: > > Diego Biurrun writes: > > > --- > > > ffmpeg.c |2 +- > > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > > > --- a/ffmpeg.c > > > +++ b/ffmpeg.c > > > @@

Re: [libav-devel] [PATCH 2/3] cljr: group encode/decode parts under single ifdefs

2011-12-08 Thread Diego Biurrun
On Thu, Dec 08, 2011 at 02:51:05PM +, Mans Rullgard wrote: > [...] You beat me to it by seconds or so - I was preparing almost exactly the same patch set and have almost identical changes locally :) > --- a/libavcodec/cljr.c > +++ b/libavcodec/cljr.c > @@ -33,6 +33,17 @@ typedef struct CLJRCo

Re: [libav-devel] [libav-commits] w32thread: port fixes to pthread_cond_broadcast() from x264.

2011-12-08 Thread Sergey Radionov
small investigation: patch to simplify logging http://pastie.org/2986260 debug log http://pastie.org/2986272 P.S. I've use Vlc ActiveX for test. 2011/12/8 Sergey Radionov > On my work system (Phenom II 555, unlocked to x3 + Windows XP x64), every > "play" of .avi file (with vlc, or web plugi

Re: [libav-devel] [PATCH] ffmpeg: eliminate unsubstantiated comment previously removed from avconv

2011-12-08 Thread Kostya Shishkov
On Thu, Dec 08, 2011 at 03:03:15PM +, Måns Rullgård wrote: > Diego Biurrun writes: > > > --- > > ffmpeg.c |2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/ffmpeg.c b/ffmpeg.c > > index c731cec..83514a6 100644 > > --- a/ffmpeg.c > > +++ b/ffmpeg.c > > @@ -5

Re: [libav-devel] [PATCH] ffmpeg: eliminate unsubstantiated comment previously removed from avconv

2011-12-08 Thread Diego Biurrun
On Thu, Dec 08, 2011 at 03:03:15PM +, Måns Rullgård wrote: > Diego Biurrun writes: > > --- > > ffmpeg.c |2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > --- a/ffmpeg.c > > +++ b/ffmpeg.c > > @@ -502,7 +502,7 @@ void exit_program(int ret) > > > > -exit(ret); /* not

Re: [libav-devel] [PATCH] ffmpeg: eliminate unsubstantiated comment previously removed from avconv

2011-12-08 Thread Måns Rullgård
Diego Biurrun writes: > --- > ffmpeg.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/ffmpeg.c b/ffmpeg.c > index c731cec..83514a6 100644 > --- a/ffmpeg.c > +++ b/ffmpeg.c > @@ -502,7 +502,7 @@ void exit_program(int ret) > exit (255); > } > > -

[libav-devel] [PATCH] ffmpeg: eliminate unsubstantiated comment previously removed from avconv

2011-12-08 Thread Diego Biurrun
--- ffmpeg.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/ffmpeg.c b/ffmpeg.c index c731cec..83514a6 100644 --- a/ffmpeg.c +++ b/ffmpeg.c @@ -502,7 +502,7 @@ void exit_program(int ret) exit (255); } -exit(ret); /* not all OS-es handle main() return

[libav-devel] [PATCH 2/3] cljr: group encode/decode parts under single ifdefs

2011-12-08 Thread Paul B Mahol
On 12/8/11, Mans Rullgard wrote: > Signed-off-by: Mans Rullgard > --- > libavcodec/cljr.c | 88 > - > 1 files changed, 40 insertions(+), 48 deletions(-) > OK ___ libav-devel mailing list libav-deve

Re: [libav-devel] [PATCH 1/3] cljr: remove stray semicolon

2011-12-08 Thread Paul B Mahol
On 12/8/11, Mans Rullgard wrote: > Signed-off-by: Mans Rullgard > --- > libavcodec/cljr.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > OK ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/li

Re: [libav-devel] [PATCH] cljr: fix typo

2011-12-08 Thread Paul B Mahol
On 12/8/11, Paul B Mahol wrote: > --- > libavcodec/cljr.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > Patch dropped. ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 3/3] cljr: remove useless casts

2011-12-08 Thread Paul B Mahol
On 12/8/11, Mans Rullgard wrote: > Signed-off-by: Mans Rullgard > --- > libavcodec/cljr.c |6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > Should be OK ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailm

[libav-devel] [PATCH 2/3] cljr: group encode/decode parts under single ifdefs

2011-12-08 Thread Mans Rullgard
Signed-off-by: Mans Rullgard --- libavcodec/cljr.c | 88 - 1 files changed, 40 insertions(+), 48 deletions(-) diff --git a/libavcodec/cljr.c b/libavcodec/cljr.c index 1b8bc53..abfcd95 100644 --- a/libavcodec/cljr.c +++ b/libavcodec/cljr.c @@

[libav-devel] [PATCH 1/3] cljr: remove stray semicolon

2011-12-08 Thread Mans Rullgard
Signed-off-by: Mans Rullgard --- libavcodec/cljr.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libavcodec/cljr.c b/libavcodec/cljr.c index 61bd909..1b8bc53 100644 --- a/libavcodec/cljr.c +++ b/libavcodec/cljr.c @@ -139,7 +139,7 @@ static av_cold int decode_init(AVCod

[libav-devel] [PATCH 3/3] cljr: remove useless casts

2011-12-08 Thread Mans Rullgard
Signed-off-by: Mans Rullgard --- libavcodec/cljr.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/cljr.c b/libavcodec/cljr.c index abfcd95..13d0150 100644 --- a/libavcodec/cljr.c +++ b/libavcodec/cljr.c @@ -37,7 +37,7 @@ static av_cold int common_init(AVC

[libav-devel] [PATCH] cljr: fix typo

2011-12-08 Thread Paul B Mahol
--- libavcodec/cljr.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libavcodec/cljr.c b/libavcodec/cljr.c index dd72082..7b4c4b9 100644 --- a/libavcodec/cljr.c +++ b/libavcodec/cljr.c @@ -139,7 +139,7 @@ static av_cold int decode_init(AVCodecContext *avctx){ static av_

Re: [libav-devel] [PATCH] cljr: release picture at end of decoding

2011-12-08 Thread Paul B Mahol
On 12/8/11, Diego Biurrun wrote: > On Tue, Dec 06, 2011 at 05:14:55AM +, Paul B. Mahol wrote: >> Otherwise after transcoding from cljr we get: Found 1 unreleased buffers! >> >> --- a/libavcodec/cljr.c >> +++ b/libavcodec/cljr.c >> @@ -139,6 +139,13 @@ static av_cold int decode_init(AVCodecCont

Re: [libav-devel] [PATCH] cljr: do not compile decoder unconditionally

2011-12-08 Thread Kostya Shishkov
On Thu, Dec 08, 2011 at 02:37:18PM +, Måns Rullgård wrote: > Kostya Shishkov writes: > > > On Thu, Dec 08, 2011 at 03:23:13PM +0100, Diego Biurrun wrote: > >> On Thu, Dec 08, 2011 at 02:11:47PM +, Måns Rullgård wrote: > >> > Paul B Mahol writes: > >> > > >> > > --- > >> > > libavcodec/

Re: [libav-devel] [PATCH] cljr: release picture at end of decoding

2011-12-08 Thread Diego Biurrun
On Tue, Dec 06, 2011 at 05:14:55AM +, Paul B. Mahol wrote: > Otherwise after transcoding from cljr we get: Found 1 unreleased buffers! > > --- a/libavcodec/cljr.c > +++ b/libavcodec/cljr.c > @@ -139,6 +139,13 @@ static av_cold int decode_init(AVCodecContext *avctx){ > > +static av_cold int de

Re: [libav-devel] [PATCH] cljr: add missing return

2011-12-08 Thread Måns Rullgård
Paul B Mahol writes: > --- > libavcodec/cljr.c |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/libavcodec/cljr.c b/libavcodec/cljr.c > index dd72082..61bd909 100644 > --- a/libavcodec/cljr.c > +++ b/libavcodec/cljr.c > @@ -141,6 +141,7 @@ static av_cold int decode_e

[libav-devel] [PATCH] cljr: add missing return

2011-12-08 Thread Paul B Mahol
--- libavcodec/cljr.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/libavcodec/cljr.c b/libavcodec/cljr.c index dd72082..61bd909 100644 --- a/libavcodec/cljr.c +++ b/libavcodec/cljr.c @@ -141,6 +141,7 @@ static av_cold int decode_end(AVCodecContext *avctx) { if (a

Re: [libav-devel] [PATCH] cljr: do not compile decoder unconditionally

2011-12-08 Thread Måns Rullgård
Kostya Shishkov writes: > On Thu, Dec 08, 2011 at 03:23:13PM +0100, Diego Biurrun wrote: >> On Thu, Dec 08, 2011 at 02:11:47PM +, Måns Rullgård wrote: >> > Paul B Mahol writes: >> > >> > > --- >> > > libavcodec/cljr.c |6 ++ >> > > 1 files changed, 6 insertions(+), 0 deletions(-) >

Re: [libav-devel] [PATCH] cljr: release picture at end of decoding

2011-12-08 Thread Paul B Mahol
On 12/8/11, Diego Biurrun wrote: > On Tue, Dec 06, 2011 at 05:14:55AM +, Paul B. Mahol wrote: >> Otherwise after transcoding from cljr we get: Found 1 unreleased buffers! >> >> --- a/libavcodec/cljr.c >> +++ b/libavcodec/cljr.c >> @@ -139,6 +139,13 @@ static av_cold int decode_init(AVCodecCont

Re: [libav-devel] [PATCH] cljr: release picture at end of decoding

2011-12-08 Thread Diego Biurrun
On Tue, Dec 06, 2011 at 05:14:55AM +, Paul B. Mahol wrote: > Otherwise after transcoding from cljr we get: Found 1 unreleased buffers! > > --- a/libavcodec/cljr.c > +++ b/libavcodec/cljr.c > @@ -139,6 +139,13 @@ static av_cold int decode_init(AVCodecContext *avctx){ > > +static av_cold int de

Re: [libav-devel] [PATCH] cljr: do not compile decoder unconditionally

2011-12-08 Thread Kostya Shishkov
On Thu, Dec 08, 2011 at 03:23:13PM +0100, Diego Biurrun wrote: > On Thu, Dec 08, 2011 at 02:11:47PM +, Måns Rullgård wrote: > > Paul B Mahol writes: > > > > > --- > > > libavcodec/cljr.c |6 ++ > > > 1 files changed, 6 insertions(+), 0 deletions(-) > > > > Why is this not two files?

Re: [libav-devel] [PATCH] doxy: change hue value to match our green

2011-12-08 Thread Diego Biurrun
On Thu, Dec 08, 2011 at 02:29:57PM +0100, Luca Barbato wrote: > --- > Doxyfile |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) OK Diego ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-deve

[libav-devel] [PATCH] avconv: support stream specifiers in -metadata and -map_metadata

2011-12-08 Thread Alexandra Khirnova
--- avconv.c| 207 +++--- doc/avconv.texi | 38 -- 2 files changed, 149 insertions(+), 96 deletions(-) diff --git a/avconv.c b/avconv.c index 54aa89b..95bf244 100644 --- a/avconv.c +++ b/avconv.c @@ -332,6 +332,8 @@ typedef struct

Re: [libav-devel] [PATCH] cljr: do not compile decoder unconditionally

2011-12-08 Thread Måns Rullgård
Diego Biurrun writes: > On Thu, Dec 08, 2011 at 02:11:47PM +, Måns Rullgård wrote: >> Paul B Mahol writes: >> >> > --- >> > libavcodec/cljr.c |6 ++ >> > 1 files changed, 6 insertions(+), 0 deletions(-) >> >> Why is this not two files? > > Since there is common code, that would re

Re: [libav-devel] [PATCH] cljr: do not compile decoder unconditionally

2011-12-08 Thread Diego Biurrun
On Thu, Dec 08, 2011 at 02:11:47PM +, Måns Rullgård wrote: > Paul B Mahol writes: > > > --- > > libavcodec/cljr.c |6 ++ > > 1 files changed, 6 insertions(+), 0 deletions(-) > > Why is this not two files? Since there is common code, that would require splitting the file in three pa

Re: [libav-devel] [PATCH] avconv: remove unsubstantiated comment

2011-12-08 Thread Diego Biurrun
On Thu, Dec 08, 2011 at 02:20:23AM +0100, Luca Barbato wrote: > All the currently supported OS-es manage to use return values > properly. > --- > avconv.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > --- a/avconv.c > +++ b/avconv.c > @@ -556,7 +556,7 @@ void exit_program(int

Re: [libav-devel] [PATCH] cljr: do not compile decoder unconditionally

2011-12-08 Thread Måns Rullgård
Paul B Mahol writes: > --- > libavcodec/cljr.c |6 ++ > 1 files changed, 6 insertions(+), 0 deletions(-) Why is this not two files? -- Måns Rullgård m...@mansr.com ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/ma

Re: [libav-devel] [PATCH] Fix a bunch of common typos.

2011-12-08 Thread Justin Ruggles
On 12/07/2011 06:12 PM, Luca Barbato wrote: > On 08/12/11 00:09, Diego Biurrun wrote: >> On Wed, Oct 05, 2011 at 06:13:18PM +0200, Kostya Shishkov wrote: >>> On Wed, Oct 05, 2011 at 05:02:26PM +0100, Måns Rullgård wrote: Diego Biurrun writes: > On Wed, Oct 05, 2011 at 01:30:56PM +0100, M

[libav-devel] [PATCH] cljr: do not compile decoder unconditionally

2011-12-08 Thread Paul B Mahol
--- libavcodec/cljr.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/libavcodec/cljr.c b/libavcodec/cljr.c index dd72082..acdcb4b 100644 --- a/libavcodec/cljr.c +++ b/libavcodec/cljr.c @@ -33,6 +33,7 @@ typedef struct CLJRContext{ AVFrame picture; } CLJRContext

Re: [libav-devel] [libav-commits] w32thread: port fixes to pthread_cond_broadcast() from x264.

2011-12-08 Thread Sergey Radionov
On my work system (Phenom II 555, unlocked to x3 + Windows XP x64), every "play" of .avi file (with vlc, or web plugin) give only "black screen". Debugging shows that problem now somewhere in static attribute_align_arg void *frame_worker_thread(void *arg) (pthread.c:287) 2011/12/8 Jean-Baptiste Ke

Re: [libav-devel] [PATCH] doxy: change hue value to match our green

2011-12-08 Thread Justin Ruggles
On 12/08/2011 08:29 AM, Luca Barbato wrote: > --- > Doxyfile |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/Doxyfile b/Doxyfile > index bb8d92b..722abf9 100644 > --- a/Doxyfile > +++ b/Doxyfile > @@ -819,7 +819,7 @@ HTML_STYLESHEET= > # 180 is cyan, 240 i

Re: [libav-devel] [libav-commits] w32thread: port fixes to pthread_cond_broadcast() from x264.

2011-12-08 Thread Jean-Baptiste Kempf
Hello *, On Wed, Dec 07, 2011 at 07:32:00PM +0100, Ronald S. Bultje wrote : > w32thread: port fixes to pthread_cond_broadcast() from x264. This improves the situation quite a bit, but isn't perfect. Noticeable on 7, but very visible on XP, frame-based decoding on h264, can deadlock quite a bit,

[libav-devel] [PATCH] doxy: change hue value to match our green

2011-12-08 Thread Luca Barbato
--- Doxyfile |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Doxyfile b/Doxyfile index bb8d92b..722abf9 100644 --- a/Doxyfile +++ b/Doxyfile @@ -819,7 +819,7 @@ HTML_STYLESHEET= # 180 is cyan, 240 is blue, 300 purple, and 360 is red again. # The allowed range is

Re: [libav-devel] [RFC][PATCH] Avoid abort() on decoding mpeg video, just raise the error

2011-12-08 Thread Luca Barbato
On 08/12/11 13:12, Andrey Utkin wrote: Changed style to pointed by Luca. Added retcode check to all places that use ff_find_unused_picture(), not only single one i had in crash backtrace. Luca, AV_ERROR_INVALIDDATA is not defined, as any AV_ERROR* at all. Do you consider it worthy to define this?

Re: [libav-devel] [RFC][PATCH] Avoid abort() on decoding mpeg video, just raise the error

2011-12-08 Thread Andrey Utkin
Changed style to pointed by Luca. Added retcode check to all places that use ff_find_unused_picture(), not only single one i had in crash backtrace. Luca, AV_ERROR_INVALIDDATA is not defined, as any AV_ERROR* at all. Do you consider it worthy to define this? Maybe -1 is enough to be fatal error mar

Re: [libav-devel] [PATCH 1/1] shorten: avoid abort() on unknown audio types

2011-12-08 Thread Kostya Shishkov
On Thu, Dec 08, 2011 at 03:16:21AM -0700, John Brooks wrote: > --- > libavcodec/shorten.c |8 +--- > 1 files changed, 5 insertions(+), 3 deletions(-) LGTM ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinf

[libav-devel] [PATCH 1/1] shorten: avoid abort() on unknown audio types

2011-12-08 Thread John Brooks
--- libavcodec/shorten.c |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/libavcodec/shorten.c b/libavcodec/shorten.c index 2170d59..eb67df7 100644 --- a/libavcodec/shorten.c +++ b/libavcodec/shorten.c @@ -176,7 +176,7 @@ static void fix_bitshift(ShortenContext *s, i

Re: [libav-devel] [PATCH] avconv: remove unsubstantiated comment

2011-12-08 Thread Janne Grunau
On 2011-12-08 02:20:23 +0100, Luca Barbato wrote: > All the currently supported OS-es manage to use return values > properly. > --- > avconv.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/avconv.c b/avconv.c > index 54aa89b..3b1500b 100644 > --- a/avconv.c > +++

Re: [libav-devel] [PATCH] cljr: add encoder

2011-12-08 Thread Diego Biurrun
On Thu, Dec 08, 2011 at 09:46:23AM +0100, Kostya Shishkov wrote: > On Thu, Dec 08, 2011 at 04:35:44AM +, Paul B Mahol wrote: > > > > --- a/libavcodec/cljr.c > > +++ b/libavcodec/cljr.c > > @@ -25,18 +25,15 @@ > > > > +#if CONFIG_CLJR_DECODER > > static int decode_frame(AVCodecContext *avctx

Re: [libav-devel] [PATCH] cljr: add encoder

2011-12-08 Thread Diego Biurrun
On Thu, Dec 08, 2011 at 12:46:15AM +, Paul B Mahol wrote: > On 12/8/11, Diego Biurrun wrote: > > On Thu, Dec 08, 2011 at 12:04:18AM +, Paul B. Mahol wrote: > >> On 12/7/11, Diego Biurrun wrote: > >> > On Wed, Dec 07, 2011 at 11:01:22PM +, Paul B. Mahol wrote: > >> >> On 12/7/11, Diego

Re: [libav-devel] [libav-commits] tests/tools/examples: Replace direct exit() calls by return.

2011-12-08 Thread Diego Biurrun
On Wed, Dec 07, 2011 at 04:35:37PM -0800, Alex Converse wrote: > On Wed, Dec 7, 2011 at 4:28 PM, Diego Biurrun wrote: > > On Wed, Dec 07, 2011 at 04:16:10PM -0800, Alex Converse wrote: > >> On Wed, Dec 7, 2011 at 4:07 PM, Diego Biurrun wrote: > >> > > >> > Author:    Diego Biurrun > >> > Committ

Re: [libav-devel] [PATCH] cljr: add encoder

2011-12-08 Thread Kostya Shishkov
On Thu, Dec 08, 2011 at 04:35:44AM +, Paul B Mahol wrote: > --- > Changelog |1 + > doc/general.texi |2 +- > libavcodec/allcodecs.c |2 +- > libavcodec/cljr.c | 50 ++- > libavcodec/version.h |2 +- > liba

Re: [libav-devel] [PATCH 7/7] doc: add pulseaudio to the input list

2011-12-08 Thread Diego Biurrun
On Thu, Dec 08, 2011 at 02:32:39AM +0100, Luca Barbato wrote: > --- > doc/general.texi |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) Still OK ... Diego ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/li

Re: [libav-devel] [PATCH 1/7] build: merge lists of HTML documentation targets

2011-12-08 Thread Janne Grunau
On 2011-12-08 02:32:33 +0100, Luca Barbato wrote: > From: Diego Biurrun > > Signed-off-by: Luca Barbato > --- > doc/Makefile |8 ++-- > 1 files changed, 6 insertions(+), 2 deletions(-) > > diff --git a/doc/Makefile b/doc/Makefile > index 01960b7..ca403d5 100644 > --- a/doc/Makefile > +