Re: [libav-devel] [PATCH] h264: fix clang warning about uninitialized variable

2014-02-28 Thread Janne Grunau
On 2014-02-28 15:51:18 +0100, Vittorio Giovara wrote: --- libavcodec/h264_refs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/h264_refs.c b/libavcodec/h264_refs.c index 78bb7c4..ccdb49b 100644 --- a/libavcodec/h264_refs.c +++ b/libavcodec/h264_refs.c @@

Re: [libav-devel] [PATCH 6/8] qt-faststart: Check offset_count before reading from the moov_atom buffer

2014-02-28 Thread Janne Grunau
On 2014-02-28 12:29:06 +0200, Martin Storsjö wrote: From: Michael Niedermayer michae...@gmx.at CC: libav-sta...@libav.org --- tools/qt-faststart.c | 8 1 file changed, 8 insertions(+) diff --git a/tools/qt-faststart.c b/tools/qt-faststart.c index d95feb1..b4a6555 100644 ---

Re: [libav-devel] [PATCH 7/8] qt-faststart: Avoid unintentionally sign extending BE_32

2014-02-28 Thread Janne Grunau
On 2014-02-28 12:29:07 +0200, Martin Storsjö wrote: Without this cast, the BE_32() expression is sign extended when assigned to an uint64_t, since the uint8_t|uint8_t expression is promoted to an int. Based on a patch by Michael Niedermayer. --- tools/qt-faststart.c | 10 +- 1

Re: [libav-devel] [PATCH 1/8] qt-faststart: Increase the copy buffer size to 64 KB

2014-02-28 Thread Janne Grunau
On 2014-02-28 12:29:01 +0200, Martin Storsjö wrote: Copying data in chunks of 1 KB is a little wasteful. 64 KB should still easily fit on the stack, so there's no need to allocate it dynamically. not that I care but I do not see an advantage of avoiding a additional heap allocation. ---

Re: [libav-devel] [PATCH 1/2] h264: parse two additional constraint flags

2014-02-28 Thread Janne Grunau
On 2014-02-19 03:23:51 +0100, Vittorio Giovara wrote: --- libavcodec/h264_ps.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavcodec/h264_ps.c b/libavcodec/h264_ps.c index cc80f35..94efaa2 100644 --- a/libavcodec/h264_ps.c +++ b/libavcodec/h264_ps.c @@ -306,7

Re: [libav-devel] [PATCH] h264: update flag name in ff_h264_decode_ref_pic_list_reordering()

2014-02-28 Thread Janne Grunau
On 2014-02-19 03:28:27 +0100, Vittorio Giovara wrote: --- Now updating the correct variable... Vittorio libavcodec/h264_refs.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/libavcodec/h264_refs.c b/libavcodec/h264_refs.c index a0b8f45..78bb7c4 100644

Re: [libav-devel] [PATCHv2 7/8] qt-faststart: Avoid unintentionally sign extending BE_32

2014-02-28 Thread Janne Grunau
On 2014-02-28 20:12:27 +0200, Martin Storsjö wrote: Without this cast, the BE_32() expression is sign extended when assigned to an uint64_t, since the uint8_t|uint8_t expression is promoted to an int. Also avoid undefined behaviour when left shifting an uint8_t by 24 by casting it to an

Re: [libav-devel] [PATCH] h264: document Picture pointers

2014-02-28 Thread Janne Grunau
On 2014-02-17 17:41:58 +0100, Vittorio Giovara wrote: --- After a chat with Janne and Anton (thanks for the explanation). Please correct me if I misunderstood Vittorio libavcodec/h264.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/h264.h

Re: [libav-devel] [PATCH] configure: Set the thread type after resolving dependencies

2014-02-28 Thread Janne Grunau
On 2014-02-28 20:22:58 +0200, Martin Storsjö wrote: From: Diego Biurrun di...@biurrun.de A threading type might be detected originally, but later disabled if one of its dependencies is unavailable. This makes sure that the threading support item in the configure output is right for setups

Re: [libav-devel] [PATCH 2/3] build: Sort h264 objects

2014-02-28 Thread Janne Grunau
On 2014-02-28 17:37:46 +0100, Luca Barbato wrote: --- libavcodec/Makefile | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/Makefile b/libavcodec/Makefile index 460c897..569ace0 100644 --- a/libavcodec/Makefile +++ b/libavcodec/Makefile @@ -195,10

Re: [libav-devel] [PATCHv2 6/8] qt-faststart: Check offset_count before reading from the moov_atom buffer

2014-02-28 Thread Janne Grunau
On 2014-02-28 22:32:38 +0200, Martin Storsjö wrote: From: Michael Niedermayer michae...@gmx.at CC: libav-sta...@libav.org --- Removed one unnecessary INT64_C, changed to use UINT64_C instead of INT64_C. --- tools/qt-faststart.c | 8 1 file changed, 8 insertions(+) diff --git

Re: [libav-devel] [PATCH] pthread_frame: flush all threads on flush, not just the first one

2014-02-28 Thread Janne Grunau
On 2014-02-28 21:55:31 +0100, Anton Khirnov wrote: On Fri, 28 Feb 2014 11:04:17 +0100, Janne Grunau janne-li...@jannau.net wrote: On 2014-02-27 21:40:09 +0100, Anton Khirnov wrote: avcodec_flush_buffers() must release all internally held references according to its documentation

Re: [libav-devel] [PATCH 1/7] dcadec: remove scaling in lfe_interpolation_fir

2014-02-27 Thread Janne Grunau
On 2014-02-22 19:59:16 +0100, Janne Grunau wrote: From: Christophe Gisquet christophe.gisq...@gmail.com The scaling factor is constant so it is faster to scale the FIR coefficients in the tables during compilation. Signed-off-by: Janne Grunau janne-li...@jannau.net --- libavcodec/arm

Re: [libav-devel] [PATCH 7/7] arm: dcadsp: implement decode_hf as external NEON asm

2014-02-27 Thread Janne Grunau
On 2014-02-22 19:59:22 +0100, Janne Grunau wrote: --- libavcodec/arm/dcadsp_init_arm.c | 46 ++-- libavcodec/arm/dcadsp_neon.S | 29 + 2 files changed, 35 insertions(+), 40 deletions(-) ping, patch is changed locally

Re: [libav-devel] [PATCH] parser: cosmetics: Drop some unnecessary parentheses

2014-02-25 Thread Janne Grunau
On 2014-02-25 12:25:12 +0100, Diego Biurrun wrote: --- libavcodec/parser.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) ok Janne ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH] parser: KR cosmetic refactoring

2014-02-24 Thread Janne Grunau
On 2014-02-23 23:59:25 +0100, Luca Barbato wrote: --- Reviews in patch update form please. libavcodec/parser.c | 187 1 file changed, 102 insertions(+), 85 deletions(-) diff --git a/libavcodec/parser.c b/libavcodec/parser.c index

Re: [libav-devel] [PATCH 2/7] x86: dcadsp: implement SSE lfe_dir

2014-02-24 Thread Janne Grunau
On 2014-02-24 11:32:43 +0100, Diego Biurrun wrote: On Sat, Feb 22, 2014 at 07:59:17PM +0100, Janne Grunau wrote: --- a/libavcodec/x86/dcadsp.asm +++ b/libavcodec/x86/dcadsp.asm @@ -88,3 +88,90 @@ INT8X8_FMUL_INT32 INIT_XMM sse4 INT8X8_FMUL_INT32 + +; %1=v0/v1 %2=in1 %3=in2

[libav-devel] [PATCH v2 4/7] x86: synth filter float: implement SSE2 version

2014-02-24 Thread Janne Grunau
. Signed-off-by: Janne Grunau janne-li...@jannau.net --- Changes: removed unneeded %if ARCH_X86_64 whitespace cleanup in code and comments fix big-buf typo in comments libavcodec/synth_filter.c| 1 + libavcodec/synth_filter.h| 1 + libavcodec/x86/dcadsp.asm| 152

[libav-devel] [PATCH v2 6/7] dcadec: simplify decoding of VQ high frequencies

2014-02-24 Thread Janne Grunau
From: Christophe Gisquet christophe.gisq...@gmail.com The vector dequantization has a test in a loop preventing effective SIMD implementation. By moving it out of the loop, this loop can be DSPized. Therefore, modify the current DSP implementation. In particular, the DSP implementation no longer

[libav-devel] [PATCH 1/1] texi2pod: always declare the pod as UTF-8 encoded

2014-02-24 Thread Janne Grunau
On 2014-02-24 19:50:22 +0200, Martin Storsj?? wrote: On Mon, 24 Feb 2014, Vittorio Giovara wrote: Module: libav Branch: master Commit: c91488ab33679add25eeb8c0229dc0b8f6acb5a4 Author:Vittorio Giovara vittorio.giov...@gmail.com Committer: Vittorio Giovara vittorio.giov...@gmail.com

Re: [libav-devel] [PATCH 1/1] texi2pod: always declare the pod as UTF-8 encoded

2014-02-24 Thread Janne Grunau
On 2014-02-24 22:09:25 +0200, Martin Storsjö wrote: On Mon, 24 Feb 2014, Janne Grunau wrote: doc/texi2pod.pl | 2 ++ 1 file changed, 2 insertions(+) diff --git a/doc/texi2pod.pl b/doc/texi2pod.pl index fb4f7be..f974d77 100755 --- a/doc/texi2pod.pl +++ b/doc/texi2pod.pl @@ -324,6 +324,8

Re: [libav-devel] [PATCH 7/7] hevc: Do not left shift a negative value

2014-02-23 Thread Janne Grunau
On 2014-02-22 21:34:19 +0100, Guillaume Martres wrote: On Wednesday 19 February 2014 22:43:13 Luca Barbato wrote: +if (x 0) +x_pos = -((-x / 2) s-sps-pixel_shift); This seems very weird to me, x and y are used to get an index inside the

Re: [libav-devel] [PATCH 1/5] configure: miscellaneous cosmetics

2014-02-23 Thread Janne Grunau
On 2013-11-02 17:21:49 +0100, Diego Biurrun wrote: Sort lists of components. Sort function checks and group them in more sensible blocks. Add some whitespace where it helps readability. Consistently use double instead of single quotes around component lists. --- configure | 68

[libav-devel] [PATCH 1/1] configure: disable cpunop is the check fails

2014-02-23 Thread Janne Grunau
On 2014-02-23 04:08:58 +0100, Luca Barbato wrote: On 23/02/14 04:02, James Almer wrote: On 22/02/14 11:57 PM, Luca Barbato wrote: On 23/02/14 00:52, Dave Yeo wrote: HAVE_LIST has ARCH_EXT_LIST ARCH_EXT_LIST has ARCH_EXT_LIST_X86 I'm wondering why it is broken for you since it

Re: [libav-devel] [PATCH 2/3] x86: add detection for FMA3 instruction set

2014-02-23 Thread Janne Grunau
On 2014-02-22 02:54:01 -0300, James Almer wrote: Based on x264 code Signed-off-by: James Almer jamr...@gmail.com commit author changed to your full name --- configure | 5 + libavutil/cpu.c | 3 +++ libavutil/cpu.h | 1 + libavutil/x86/cpu.c | 5 -

Re: [libav-devel] [PATCH 3/3] x86: add detection for Bit Manipulation Instruction sets

2014-02-23 Thread Janne Grunau
On 2014-02-22 02:54:02 -0300, James Almer wrote: Based on x264 code Signed-off-by: James Almer jamr...@gmail.com --- libavutil/cpu.c | 6 ++ libavutil/cpu.h | 2 ++ libavutil/x86/cpu.c | 16 +++- 3 files changed, 19 insertions(+), 5 deletions(-) diff --git

Re: [libav-devel] [PATCH 1/1] configure: disable cpunop is the check fails

2014-02-23 Thread Janne Grunau
On 2014-02-23 14:18:21 +0100, Janne Grunau wrote: is/if typo in the subject fixed locally Janne ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 2/3] lavc: use AVFrame API properly in ff_reget_buffer()

2014-02-23 Thread Janne Grunau
On 2014-02-15 21:33:52 +0100, Anton Khirnov wrote: --- libavcodec/utils.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/libavcodec/utils.c b/libavcodec/utils.c index b2b11ef..c88b346 100644 --- a/libavcodec/utils.c +++ b/libavcodec/utils.c @@

Re: [libav-devel] [PATCH] avconv: support forcing codec tags for input streams

2014-02-23 Thread Janne Grunau
On 2014-02-23 08:43:13 +0100, Anton Khirnov wrote: --- avconv_opt.c| 12 +++- doc/avconv.texi |2 +- 2 files changed, 12 insertions(+), 2 deletions(-) ok Janne ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH 1/4] libx265: Update API usage

2014-02-23 Thread Janne Grunau
On 2014-02-21 17:16:17 +, Derek Buitenhuis wrote: Framerate is now a sane rational instead of an integer, and inputDepth is changed to what it actually is. Signed-off-by: Derek Buitenhuis derek.buitenh...@gmail.com --- configure| 4 ++-- libavcodec/libx265.c | 9 +++--

Re: [libav-devel] [PATCH 3/4] libx265: Support SAR

2014-02-23 Thread Janne Grunau
On 2014-02-21 17:16:19 +, Derek Buitenhuis wrote: Signed-off-by: Derek Buitenhuis derek.buitenh...@gmail.com --- libavcodec/libx265.c | 9 + 1 file changed, 9 insertions(+) diff --git a/libavcodec/libx265.c b/libavcodec/libx265.c index 1546853..7fdccc7 100644 ---

Re: [libav-devel] [PATCH 4/4] libx265: Properly handled dynamic linking with MSVC

2014-02-23 Thread Janne Grunau
On 2014-02-21 17:16:20 +, Derek Buitenhuis wrote: Signed-off-by: Derek Buitenhuis derek.buitenh...@gmail.com --- libavcodec/libx265.c | 4 1 file changed, 4 insertions(+) diff --git a/libavcodec/libx265.c b/libavcodec/libx265.c index 7fdccc7..9833e48 100644 ---

Re: [libav-devel] [PATCH 2/4] libx265: Support 4:4:4

2014-02-23 Thread Janne Grunau
On 2014-02-21 20:34:49 +, Derek Buitenhuis wrote: On 2/21/2014 5:16 PM, Derek Buitenhuis wrote: Signed-off-by: Derek Buitenhuis derek.buitenh...@gmail.com --- libavcodec/libx265.c | 14 ++ 1 file changed, 14 insertions(+) FYI, I've changed this to be marked as

Re: [libav-devel] [PATCH 1/4] libx265: Update API usage

2014-02-23 Thread Janne Grunau
On 2014-02-23 17:21:10 +, Derek Buitenhuis wrote: On 2/23/2014 3:20 PM, Janne Grunau wrote: This doesn't look right, AV_PIX_FMT_YUV420P is a valid pixel format for 'x265_max_bit_depth == 12' and I can't see how x265 could deduce that otherwise. No, the *internal* depth

Re: [libav-devel] [PATCH 1/4] libx265: Update API usage

2014-02-23 Thread Janne Grunau
On 2014-02-23 18:53:32 +0100, Tim Walker wrote: On 23 Feb 2014, at 18:40, Janne Grunau janne-li...@jannau.net wrote: On 2014-02-23 17:21:10 +, Derek Buitenhuis wrote: On 2/23/2014 3:20 PM, Janne Grunau wrote: This doesn't look right, AV_PIX_FMT_YUV420P is a valid pixel format

[libav-devel] DCA changes from Christophe

2014-02-22 Thread Janne Grunau
Hi, following patch set holds Christophe's remaining DCA changes with arm asm changes from me. I did a couple of minor cosmetic changes and changed some commit messages. The pre-scaling of the lfe_dir coefficients uses a macro so that it can be easily be undone when required. PATCH 5 is further

[libav-devel] [PATCH 4/7] x86: synth filter float: implement SSE2 version

2014-02-22 Thread Janne Grunau
. Signed-off-by: Janne Grunau janne-li...@jannau.net --- libavcodec/synth_filter.c| 1 + libavcodec/synth_filter.h| 1 + libavcodec/x86/dcadsp.asm| 154 +++ libavcodec/x86/dcadsp_init.c | 28 4 files changed, 184 insertions(+) diff --git

[libav-devel] [PATCH 3/7] dcadsp: scan coefficients linearly in dca_lfe_fir

2014-02-22 Thread Janne Grunau
From: Christophe Gisquet christophe.gisq...@gmail.com This change is inspired by x86 asm where it frees a register. Signed-off-by: Janne Grunau janne-li...@jannau.net --- libavcodec/dcadsp.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/libavcodec/dcadsp.c b

[libav-devel] [PATCH 1/7] dcadec: remove scaling in lfe_interpolation_fir

2014-02-22 Thread Janne Grunau
From: Christophe Gisquet christophe.gisq...@gmail.com The scaling factor is constant so it is faster to scale the FIR coefficients in the tables during compilation. Signed-off-by: Janne Grunau janne-li...@jannau.net --- libavcodec/arm/dcadsp_init_arm.c | 12 +- libavcodec/arm/dcadsp_neon.S

[libav-devel] [PATCH 2/7] x86: dcadsp: implement SSE lfe_dir

2014-02-22 Thread Janne Grunau
From: Christophe Gisquet christophe.gisq...@gmail.com Results for Arrandale/Windows: 32: 1670 - 316 64: 728 - 298 Signed-off-by: Janne Grunau janne-li...@jannau.net --- libavcodec/x86/dcadsp.asm| 87 libavcodec/x86/dcadsp_init.c | 4 ++ 2 files

[libav-devel] [PATCH 6/7] dcadec: simplify decoding of VQ high frequencies

2014-02-22 Thread Janne Grunau
From: Christophe Gisquet christophe.gisq...@gmail.com The vector dequantization has a test in a loop preventing effective SIMD implementation. By moving it out of the loop, this loop can be DSPized. Therefore, modify the current DSP implementation. In particular, the DSP implementation no longer

[libav-devel] [PATCH 5/7] dca: factorize scaling in inverse ADPCM

2014-02-22 Thread Janne Grunau
Based on a patch from Christophe Gisquet. Unrolling of the m == 0 case avoids a possible use of the uninitilized value sum when s-predictor_history is not set. I failed to find a sample for it. It also reduced the cycle count from 220 to 150 on sandy bridge, x86_64 linux, gcc 4.8.2 compared to

[libav-devel] [PATCH 7/7] arm: dcadsp: implement decode_hf as external NEON asm

2014-02-22 Thread Janne Grunau
--- libavcodec/arm/dcadsp_init_arm.c | 46 ++-- libavcodec/arm/dcadsp_neon.S | 29 + 2 files changed, 35 insertions(+), 40 deletions(-) diff --git a/libavcodec/arm/dcadsp_init_arm.c b/libavcodec/arm/dcadsp_init_arm.c index

Re: [libav-devel] [PATCH 7/7] hevc: Do not left shift a negative value

2014-02-21 Thread Janne Grunau
On 2014-02-21 00:10:05 +0100, Luca Barbato wrote: On 20/02/14 23:58, Janne Grunau wrote: Also after a cursory glance x can only be smaller than 0 if x0 is smaller than 0. There are some right shifts of x0 i the same function which are implementation defined. IIRC x0 should be at least

[libav-devel] [PATCH 1/1] aarch64: use EXTERN_ASM consistently for exported symbols

2014-02-20 Thread Janne Grunau
Based on e3fec3f095ab5ea08ee662942d98526aaf5e3635 for arm. --- libavcodec/aarch64/h264idct_neon.S | 16 libavutil/aarch64/asm.S| 9 - 2 files changed, 16 insertions(+), 9 deletions(-) diff --git a/libavcodec/aarch64/h264idct_neon.S

Re: [libav-devel] [PATCH 08/10] dcadsp: move test out of loop and dspize

2014-02-20 Thread Janne Grunau
On 2014-02-15 20:03:13 +0100, Christophe Gisquet wrote: Hi, diff --git a/libavcodec/dcadec.c b/libavcodec/dcadec.c index 2d88cb4..371c838 100644 --- a/libavcodec/dcadec.c +++ b/libavcodec/dcadec.c @@ -50,14 +50,10 @@ #if ARCH_ARM # include arm/dca.h #endif -#if

Re: [libav-devel] [PATCH] Give IDCT matrix transpose macro a more descriptive name

2014-02-20 Thread Janne Grunau
On 2014-02-18 10:00:06 -0800, Diego Biurrun wrote: This also avoids a macro name clash and related warning on ARM. --- libavcodec/vp56.c: In function ‘ff_vp56_init’: libavcodec/vp56.c:667:0: warning: T redefined [enabled by default] In file included from libavcodec/vp56.h:237:0,

Re: [libav-devel] [PATCH 5/9] libavcodec: when decoding, copy replaygain side data to decoded frames

2014-02-20 Thread Janne Grunau
On 2014-02-19 21:16:48 +0100, Anton Khirnov wrote: --- libavcodec/internal.h |5 + libavcodec/rawdec.c |6 -- libavcodec/utils.c| 41 ++--- 3 files changed, 43 insertions(+), 9 deletions(-) diff --git a/libavcodec/internal.h

Re: [libav-devel] [PATCH 6/9] avconv: add stream-global side data to the first demuxed packet

2014-02-20 Thread Janne Grunau
On 2014-02-19 21:16:49 +0100, Anton Khirnov wrote: --- avconv.c | 17 + avconv.h |3 +++ 2 files changed, 20 insertions(+) diff --git a/avconv.c b/avconv.c index 295e2dd..88f8473 100644 --- a/avconv.c +++ b/avconv.c @@ -2219,9 +2219,26 @@ static int

Re: [libav-devel] [PATCH 7/9] frame: add a function for removing side data from a frame

2014-02-20 Thread Janne Grunau
On 2014-02-19 21:16:50 +0100, Anton Khirnov wrote: --- doc/APIchanges |4 libavutil/frame.c | 15 +++ libavutil/frame.h |7 +++ libavutil/version.h |2 +- 4 files changed, 27 insertions(+), 1 deletion(-) diff --git a/doc/APIchanges

Re: [libav-devel] [PATCH 3/7] hevc: Drop unnecessary shifts

2014-02-20 Thread Janne Grunau
On 2014-02-19 22:43:09 +0100, Luca Barbato wrote: beta_offset is pre-multiplied by 2. --- libavcodec/hevc_filter.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/hevc_filter.c b/libavcodec/hevc_filter.c index d3f2ff1..3437fd0 100644 ---

Re: [libav-devel] [PATCH 7/7] hevc: Do not left shift a negative value

2014-02-20 Thread Janne Grunau
On 2014-02-19 22:43:13 +0100, Luca Barbato wrote: --- libavcodec/hevc_filter.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/libavcodec/hevc_filter.c b/libavcodec/hevc_filter.c index eb3f5f3..8f425d8 100644 --- a/libavcodec/hevc_filter.c +++

Re: [libav-devel] [PATCH 01/10] dcadsp: remove scaling in LFE FIR

2014-02-18 Thread Janne Grunau
On 2014-02-18 14:35:35 +0100, Niels Möller wrote: Christophe Gisquet christophe.gisq...@gmail.com writes: This scale is constant so it is simpler to just scale the FIR coefficients in the tables instead. --- libavcodec/dcadata.h | 384

Re: [libav-devel] [PATCH] arm: Mark the stack as non-executable

2014-02-18 Thread Janne Grunau
On 2014-02-07 16:37:01 +0200, Martin Storsjö wrote: If linking in an object file without this attribute set, the linker will assume that an executable stack might be needed. --- libavutil/arm/asm.S | 1 + 1 file changed, 1 insertion(+) diff --git a/libavutil/arm/asm.S

Re: [libav-devel] [PATCH 01/10] dcadsp: remove scaling in LFE FIR

2014-02-15 Thread Janne Grunau
On 2014-02-15 08:28:41 +0100, Christophe Gisquet wrote: 2014-02-14 17:03 GMT+01:00 Christophe Gisquet christophe.gisq...@gmail.com: This scale is constant so it is simpler to just scale the FIR coefficients in the tables instead. There are 2 major points with this patch that come to mind:

Re: [libav-devel] [PATCH 03/10] dcadsp: scan coefficients linearly instead.

2014-02-15 Thread Janne Grunau
On 2014-02-14 16:03:08 +, Christophe Gisquet wrote: This change is inspired by x86 asm, where this frees a register. have you looked at the compiled version if it improves too? --- libavcodec/dcadsp.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git

Re: [libav-devel] [PATCH 05/10] dca: replace some memcpy by AV_COPY128

2014-02-15 Thread Janne Grunau
On 2014-02-14 16:03:10 +, Christophe Gisquet wrote: --- libavcodec/dcadec.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/libavcodec/dcadec.c b/libavcodec/dcadec.c index d3af364..c251db8 100644 --- a/libavcodec/dcadec.c +++ b/libavcodec/dcadec.c @@ -1241,9

Re: [libav-devel] [PATCH 06/10] dca: factorize scaling in inverse ADPCM

2014-02-15 Thread Janne Grunau
On 2014-02-14 16:03:11 +, Christophe Gisquet wrote: The codeblock affected accounted for around 4% of the runtime on x86_64 (measured using oprofile on a Penryn). Timings for Arrandale (gcc 4.6.1 tdm64-1 for windows): win32: 341 - 331 win64: 321 - 120 The compiled loops are completely

Re: [libav-devel] [PATCH 08/10] dcadsp: move test out of loop and dspize

2014-02-15 Thread Janne Grunau
On 2014-02-14 16:03:13 +, Christophe Gisquet wrote: The vector dequantization has a test in a loop preventing effective SIMD implementation. By moving it out of the loop, this loop can be DSPized. Therefore, modify the current DSP implementation. In particular, the DSP implementation no

Re: [libav-devel] [PATCH 09/10] dcadsp: perform linear access with offset

2014-02-15 Thread Janne Grunau
On 2014-02-14 16:03:14 +, Christophe Gisquet wrote: This seems to simplify noticeably the addressing. Timings before/after for respectively win32 and win64 are 260/222 and 242/231. --- libavcodec/dcadsp.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git

Re: [libav-devel] [PATCH 8/9] h264: make sure both fields are always marked as finished

2014-02-14 Thread Janne Grunau
On 2014-01-06 08:36:41 +0100, Anton Khirnov wrote: Fixes deadlocks. Found-by: Mateusz j00ru Jurczyk and Gynvael Coldwind CC:libav-sta...@libav.org --- libavcodec/h264.c |8 1 file changed, 8 insertions(+) diff --git a/libavcodec/h264.c b/libavcodec/h264.c index

Re: [libav-devel] [PATCH 1/1] ppc: reduce overreads when loading 8 pixels in altivec dsp functions

2014-02-14 Thread Janne Grunau
On 2014-02-13 17:22:50 +0100, Janne Grunau wrote: Altivec can only load naturally aligned vectors. To handle possibly unaligned data a second vector is loaded from an offset of the original location and the data is recovered through a vector permutation. Overreads are minimal if the offset

[libav-devel] [PATCH 1/1] h264: avoid undefined behavior in chroma motion compensation

2014-02-14 Thread Janne Grunau
Makes fate-h264 pass under valgrind --undef-value-errors=yes with -cpuflags none. {avg,put}_h264_chroma_mc8_8 approximately 5% faster, {avg,put}_h264_chroma_mc4_8 2% faster both on x86 and arm. --- libavcodec/h264chroma_template.c | 35 --- 1 file changed, 32

[libav-devel] [PATCH 1/1] mpeg12dec: do not add stereo3D side data to a non-existing frame

2014-02-13 Thread Janne Grunau
User data is usually coded before slice data. That means the frame the user data belongs to is not available while parsing the user data. The stereo3D side data has to use the same indirection over the private context as pan scan information and A53 captions. Bug-Id:632 ---

Re: [libav-devel] [PATCH 2/2] configure: link only avconv against -lvpdau if needed

2014-02-13 Thread Janne Grunau
On 2014-02-13 12:14:46 +0100, Diego Biurrun wrote: On Thu, Feb 13, 2014 at 12:57:50AM +0100, Janne Grunau wrote: Write all LIBS-$program variables to config.mak. Bug-Id: 635 --- configure | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) The log message does

[libav-devel] [PATCH 1/1] ppc: reduce overreads when loading 8 pixels in altivec dsp functions

2014-02-13 Thread Janne Grunau
Altivec can only load naturally aligned vectors. To handle possibly unaligned data a second vector is loaded from an offset of the original location and the data is recovered through a vector permutation. Overreads are minimal if the offset for second load points to the last element of data. This

Re: [libav-devel] [PATCH] h264: Refactor ff_h264_decode_ref_pic_list_reordering

2014-02-13 Thread Janne Grunau
On 2014-02-13 15:33:36 +0100, Luca Barbato wrote: In preparation for MVC support. --- libavcodec/h264_refs.c | 136 ++--- 1 file changed, 72 insertions(+), 64 deletions(-) ok Janne ___ libav-devel

[libav-devel] [PATCH 1/1] header: fix mixed content warning due to forced http in img

2014-02-12 Thread Janne Grunau
Also do not force http for FATE. --- src/template_head2 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/template_head2 b/src/template_head2 index 043d43f..e0b4fe6 100644 --- a/src/template_head2 +++ b/src/template_head2 @@ -8,7 +8,7 @@ header class=navbar

[libav-devel] [PATCH 1/1] h264: make context_count unsigned

2014-02-12 Thread Janne Grunau
Removes the bogus but scary looking warning 'libavcodec/h264.c:4529:49: warning: array subscript is below array bounds [-Warray-bounds]'. --- libavcodec/h264.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/h264.c b/libavcodec/h264.c index da2d4a5..9b5d6a0

Re: [libav-devel] [PATCH 1/1] h264: make context_count unsigned

2014-02-12 Thread Janne Grunau
On 2014-02-12 13:08:43 +0100, Luca Barbato wrote: On 12/02/14 12:52, Janne Grunau wrote: Removes the bogus but scary looking warning 'libavcodec/h264.c:4529:49: warning: array subscript is below array bounds [-Warray-bounds]'. --- libavcodec/h264.c | 4 ++-- 1 file changed, 2

[libav-devel] [PATCH 1/1] jv: detect partial packets in the demuxer

2014-02-12 Thread Janne Grunau
Fixes valgrind's use of initialized value warnings in fate-jv. --- libavformat/jvdec.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/libavformat/jvdec.c b/libavformat/jvdec.c index 006acec..84d55da 100644 --- a/libavformat/jvdec.c +++ b/libavformat/jvdec.c @@

Re: [libav-devel] [PATCH 1/1] jv: detect partial packets in the demuxer

2014-02-12 Thread Janne Grunau
On 2014-02-12 20:11:27 +0100, Janne Grunau wrote: Fixes valgrind's use of initialized value warnings in fate-jv. Commimt mesage changed to: Fixes fate-jv under valgrind which reports a different CRC for the last frame from a partial read. since it actually has different output. Janne

[libav-devel] [PATCH 1/2] configure: avserver does not need $ldl

2014-02-12 Thread Janne Grunau
Loadable plugins were removed in d010e95f86089abe9a3d4d4a66ac8102312d28a4. --- configure | 1 - 1 file changed, 1 deletion(-) diff --git a/configure b/configure index 1afba25..afb7680 100755 --- a/configure +++ b/configure @@ -2041,7 +2041,6 @@ avplay_select=rdft avprobe_deps=avcodec avformat

[libav-devel] [PATCH 2/2] configure: link only avconv against -lvpdau if needed

2014-02-12 Thread Janne Grunau
Write all LIBS-$program variables to config.mak. Bug-Id: 635 --- configure | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/configure b/configure index afb7680..a150618 100755 --- a/configure +++ b/configure @@ -2038,6 +2038,7 @@ avconv_select=aformat_filter

Re: [libav-devel] [PATCH 2/3] h264: store current_sps_id inside the current sps

2014-02-12 Thread Janne Grunau
On 2014-02-13 00:47:28 +0100, Vittorio Giovara wrote: --- FATE says it's fine with this change. Vittorio should make a difference libavcodec/h264.c| 5 ++--- libavcodec/h264.h| 2 +- libavcodec/h264_ps.c | 2 +- 3 files changed, 4 insertions(+), 5 deletions(-) ok, not sure why I

Re: [libav-devel] [PATCH 3/3] h264: drop outdated comments

2014-02-12 Thread Janne Grunau
On 2014-02-13 00:47:29 +0100, Vittorio Giovara wrote: --- Or at least they look that way. Any other findings would be welcome. Vittorio libavcodec/h264.c | 1 - libavcodec/h264.h | 6 +- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/libavcodec/h264.c

[libav-devel] asf seeking

2014-02-11 Thread Janne Grunau
Hi, I noticed that seeking in avplay of certain asf files didn't work at all while I tested Andrew's patch before pushing. This patch set fixes that. The first patch checks ff_get_guid return values, fate-seek-lavf-asf triggered a undefined value error in valgrind. I covered just ff_get_guid

[libav-devel] [PATCH 3/3] asfdec: fix seeking with fragmented packets

2014-02-11 Thread Janne Grunau
After seeking fragments with an offset 0 must be skipped to correctly assemble packets. Bug-Id: 43 --- libavformat/asfdec.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/libavformat/asfdec.c b/libavformat/asfdec.c index 8580ce0..1da0eab 100644 --- a/libavformat/asfdec.c +++

[libav-devel] [PATCH 1/3] asfdec: check ff_get_guid() return values during seeking

2014-02-11 Thread Janne Grunau
Hitting EOF during seeking is quite likely. Fixes use of uninitialized data during fate-seek-lavf-asf. --- libavformat/asfdec.c | 26 -- 1 file changed, 16 insertions(+), 10 deletions(-) diff --git a/libavformat/asfdec.c b/libavformat/asfdec.c index 5b4366e..e754cb2

[libav-devel] [PATCH 2/3] asfdec: short-circuit seeking to the start of stream

2014-02-11 Thread Janne Grunau
From: Andrew Kelley superjo...@gmail.com Bug-id: 43 Signed-off-by: Janne Grunau janne-li...@jannau.net --- libavformat/asfdec.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/libavformat/asfdec.c b/libavformat/asfdec.c index e754cb2..8580ce0 100644 --- a/libavformat/asfdec.c +++ b

Re: [libav-devel] [PATCH] mov: support exporting rotation angle as AVPacketSideData

2014-02-11 Thread Janne Grunau
On 2014-02-11 12:08:56 +0100, Vittorio Giovara wrote: Compute the full rotatation angle exported by display_matrix. --- Micro optimization, don't do the math when you get the identity matrix! Part of the code based on how VLC does it (in modules/demux/mp4/libmp4.c). Cheers, Vittorio ---

Re: [libav-devel] [PATCH 5/5] wip: fate: FFv1 testcases

2014-02-10 Thread Janne Grunau
On 2014-02-10 12:17:30 +0100, Diego Biurrun wrote: On Sun, Feb 09, 2014 at 07:28:17PM +0100, Luca Barbato wrote: From: Peter B p...@das-werkstatt.com Signed-off-by: Luca Barbato lu_z...@gentoo.org --- +### +# Decoding:

Re: [libav-devel] [PATCH 3/5] ffv1: Make sure to clean up on error

2014-02-10 Thread Janne Grunau
On 2014-02-09 19:28:15 +0100, Luca Barbato wrote: Plug some leaks and free on non-allocated pointers. --- libavcodec/ffv1.c| 29 + libavcodec/ffv1dec.c | 14 +- 2 files changed, 34 insertions(+), 9 deletions(-) diff --git a/libavcodec/ffv1.c

Re: [libav-devel] [PATCH 3/5] ffv1: Make sure to clean up on error

2014-02-10 Thread Janne Grunau
On 2014-02-10 14:09:14 +0100, Luca Barbato wrote: On 10/02/14 14:03, Janne Grunau wrote: On 2014-02-09 19:28:15 +0100, Luca Barbato wrote: Plug some leaks and free on non-allocated pointers. --- @@ -216,10 +220,21 @@ av_cold int ffv1_init_slice_contexts(FFV1Context *f) fs

Re: [libav-devel] [PATCH] aacdec: set AVFrame sample_rate

2014-02-10 Thread Janne Grunau
On 2014-02-08 21:24:00 -0500, Justin Ruggles wrote: On 02/08/2014 09:19 PM, John Stebbins wrote: AVFrame.sample_rate is set in ff_get_buffer, but aacdec calls ff_get_buffer before the samplerate is known. So it needs to be set again before returning the frame. --- libavcodec/aacdec.c |

Re: [libav-devel] [PATCH 1/3] css: Move to bootstrap3

2014-02-09 Thread Janne Grunau
On 2014-01-29 16:09:40 +0100, Luca Barbato wrote: --- htdocs/css/alert.css | 54 - htdocs/css/bootstrap-theme.css | 464 +++ htdocs/css/bootstrap.css | 6771 htdocs/css/libav.css | 105 - not really looked at the css

Re: [libav-devel] [PATCH 2/3] template: Use the correct doctype

2014-02-09 Thread Janne Grunau
On 2014-01-29 16:09:41 +0100, Luca Barbato wrote: We are using html5. and still no video on our homepage --- src/template_head1 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/template_head1 b/src/template_head1 index 21ab236..1e5c8a8 100644 ---

[libav-devel] [PATCH 1/1] build: fix make examples when EXESUF is not empty

2014-02-09 Thread Janne Grunau
From: Christophe Gisquet christophe.gisq...@gmail.com Due to a wrong substitution doc/examples is not added as prerequisite for the objects of the example programs. This results in compiler error due to the non existing output directory. Bug-Id: 636 Signed-off-by: Janne Grunau janne-li

Re: [libav-devel] [PATCH 1/1] build: fix make examples when EXESUF is not empty

2014-02-09 Thread Janne Grunau
On 2014-02-10 00:47:17 +0100, Janne Grunau wrote: From: Christophe Gisquet christophe.gisq...@gmail.com Due to a wrong substitution doc/examples is not added as prerequisite for the objects of the example programs. This results in compiler error due to the non existing output directory

[libav-devel] [PATCH 1/1] x86: use the inline int8x8_fmul_int32 only if inline SSE2 is availbale

2014-02-08 Thread Janne Grunau
Fixes compilation with MSVC. Also does not rely on on earlier config.h include but include it directly. --- libavcodec/x86/dca.h | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libavcodec/x86/dca.h b/libavcodec/x86/dca.h index c14e94f..fbca7ff 100644 ---

Re: [libav-devel] [PATCH 0/2] New VP9 samples

2014-02-08 Thread Janne Grunau
On 2014-02-05 18:35:23 +0100, Guillaume Martres wrote: The samples have been uploaded to ftp://upload.libav.org/incoming/vp9-samples-0214/ . Ronald S. Bultje (2): vp9: add fate sample for parallelmode. vp9: add a new segmentation sample. tests/fate/vpx.mak | 4

Re: [libav-devel] [PATCH] New HEVC streams

2014-02-08 Thread Janne Grunau
On 2014-02-05 19:16:42 +0100, Guillaume Martres wrote: Streams uploaded at ftp://upload.libav.org/incoming/hevc-samples-0214/ . Guillaume Martres (1): hevc: update conformance streams tests/fate/hevc.mak| 11 +- ...ricsson_3 =

[libav-devel] [PATCH 1/2] asvenc: free avctx-coded_frame on codec close

2014-02-08 Thread Janne Grunau
--- libavcodec/asvenc.c | 8 1 file changed, 8 insertions(+) diff --git a/libavcodec/asvenc.c b/libavcodec/asvenc.c index 40257f0..6c83c92 100644 --- a/libavcodec/asvenc.c +++ b/libavcodec/asvenc.c @@ -263,6 +263,12 @@ static av_cold int encode_init(AVCodecContext *avctx){ return

[libav-devel] [PATCH 2/2] mxfdec: free descriptor extradata in .read_close()

2014-02-08 Thread Janne Grunau
Fixes memleak in fate-mxf-demux. --- libavformat/mxfdec.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index 296044e..158e866 100644 --- a/libavformat/mxfdec.c +++ b/libavformat/mxfdec.c @@ -2200,6 +2200,9 @@ static int

[libav-devel] [PATCH 1/1] dca: include dcadsp.h in {arm, x86}/dca.h for checkheaders

2014-02-08 Thread Janne Grunau
--- libavcodec/arm/dca.h | 1 + libavcodec/x86/dca.h | 1 + 2 files changed, 2 insertions(+) diff --git a/libavcodec/arm/dca.h b/libavcodec/arm/dca.h index 06e3ea6..580bd75 100644 --- a/libavcodec/arm/dca.h +++ b/libavcodec/arm/dca.h @@ -24,6 +24,7 @@ #include stdint.h #include config.h

Re: [libav-devel] [PATCH 1/1] x86: use the inline int8x8_fmul_int32 only if inline SSE2 is availbale

2014-02-08 Thread Janne Grunau
On 2014-02-08 14:57:30 +0100, Diego Biurrun wrote: On Sat, Feb 08, 2014 at 11:52:19AM +0100, Janne Grunau wrote: --- a/libavcodec/x86/dca.h +++ b/libavcodec/x86/dca.h @@ -18,7 +18,9 @@ -#if ARCH_X86_64 +#include config.h + +#if ARCH_X86_64 HAVE_SSE2_INLINE # include

Re: [libav-devel] [PATCH] vp8: fix PPC assembly and bilinear C code to work if src_stride != dst_stride.

2014-02-08 Thread Janne Grunau
On 2014-02-06 12:05:16 +0100, Diego Biurrun wrote: On Thu, Feb 06, 2014 at 08:28:44AM +0100, Anton Khirnov wrote: On Wed, 5 Feb 2014 15:32:59 +0100, Diego Biurrun di...@biurrun.de wrote: On Wed, Feb 05, 2014 at 09:59:45AM +0100, Anton Khirnov wrote: --- a/libavcodec/ppc/vp8dsp_altivec.c

Re: [libav-devel] [PATCH] vp8: fix PPC assembly and bilinear C code to work if src_stride != dst_stride.

2014-02-08 Thread Janne Grunau
On 2014-02-08 16:12:43 +0100, Diego Biurrun wrote: On Sat, Feb 08, 2014 at 02:38:53PM +, Janne Grunau wrote: On 2014-02-06 12:05:16 +0100, Diego Biurrun wrote: On Thu, Feb 06, 2014 at 08:28:44AM +0100, Anton Khirnov wrote: On Wed, 5 Feb 2014 15:32:59 +0100, Diego Biurrun di

Re: [libav-devel] [PATCH] lavf: default .ogg audio to libvorbis if we can

2014-02-08 Thread Janne Grunau
On 2014-02-08 18:14:23 +0100, Luca Barbato wrote: On 08/02/14 17:53, Andrew Kelley wrote: Since 2007, the Xipth.org Foundation recommends that .ogg only be used ^ except for this typo Janne ___ libav-devel mailing list

[libav-devel] [PATCH 1/1] arm: asm changes for splitted dca_lfe_fir

2014-02-07 Thread Janne Grunau
Hi, whoever pushes [PATCH 03/11] dcadsp: split lfe_dir cases should squash this patch into it. Original patch is ok this one needs review. Janne ---0--- --- libavcodec/arm/dcadsp_init_arm.c | 46 libavcodec/arm/dcadsp_neon.S | 18 ++--

<    4   5   6   7   8   9   10   11   12   13   >