Re: [libav-devel] [PATCH 01/41] Bump major versions of all libraries

2016-12-19 Thread Anton Khirnov
.giov...@gmail.com> > --- LGTM -- Anton Khirnov ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 04/41] lavfi: Drop deprecated filter initialization

2016-12-19 Thread Anton Khirnov
Quoting Vittorio Giovara (2016-12-06 06:27:25) > Deprecated in 03/2013. > --- > libavfilter/avfilter.c | 7 --- > libavfilter/avfilter.h | 15 --- > libavfilter/version.h | 3 --- > 3 files changed, 25 deletions(-) Ok

Re: [libav-devel] [PATCH 06/41] lavfi: Drop deprecated non-const filter retrieval

2016-12-19 Thread Anton Khirnov
Quoting Vittorio Giovara (2016-12-06 06:27:27) > Deprecated in 10/2013. > --- > libavfilter/avfilter.c | 5 + > libavfilter/avfilter.h | 5 + > libavfilter/version.h | 3 --- > 3 files changed, 2 insertions(+), 11 deletions(-) >

Re: [libav-devel] [PATCH 09/41] lavf: Drop deprecated hint to set muxer timebase

2016-12-19 Thread Anton Khirnov
Quoting Vittorio Giovara (2016-12-06 06:27:30) > Deprecated in 05/2014. > --- > libavformat/mux.c | 11 --- > libavformat/version.h | 4 +--- > 2 files changed, 1 insertion(+), 14 deletions(-) > Ok -- Anton Khirnov _

Re: [libav-devel] [PATCH] unary: Convert to the new bitstream reader

2016-12-19 Thread Anton Khirnov
libavcodec/{unary.h => unary_legacy.h} | 0 > libavcodec/vc1.c | 2 +- > libavcodec/vc1_block.c | 2 +- > libavcodec/wavpack.c | 2 +- > libavformat/mpc8.c | 3 ++- > 17 files changed, 27 insertions(+), 24 deletions(-

Re: [libav-devel] [PATCH 05/41] lavfi: Drop deprecated filter registration

2016-12-19 Thread Anton Khirnov
Quoting Vittorio Giovara (2016-12-06 06:27:26) > Deprecated in 04/2013. > --- > libavfilter/avfilter.c | 11 --- > libavfilter/avfilter.h | 18 -- > libavfilter/version.h | 3 --- > 3 files changed, 32 deletions(-) Ok

Re: [libav-devel] [PATCH 1/4] frame: add left/top cropping fields to AVFrame

2016-12-19 Thread Anton Khirnov
Quoting Hendrik Leppkes (2016-12-18 21:37:44) > On Sun, Dec 18, 2016 at 9:27 PM, Anton Khirnov <an...@khirnov.net> wrote: > > --- > > doc/APIchanges | 4 > > libavutil/frame.c | 2 ++ > > libavutil/frame.h | 14 ++ > > libavutil

Re: [libav-devel] [PATCH 2/5] libautil: add support for AV_HWDEVICE_TYPE_D3D11VA

2016-12-19 Thread Anton Khirnov
/** > + * The surface pool. When an external pool is not provided by the caller, > + * this will be managed (allocated and filled on init, freed on uninit) > by > + * libavutil. > + * When it is provided the allocation/deallocation is up to the caller. > +

Re: [libav-devel] [PATCH 01/31] Bump major versions of all libraries

2016-12-19 Thread Anton Khirnov
g which release number corresponds to > any given library version. I don't undertand this argument. I also do not agree with this change, as I said earlier. -- Anton Khirnov ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.or

Re: [libav-devel] [PATCH 07/41] lavf: Drop deprecated bitexact functionality

2016-12-19 Thread Anton Khirnov
Quoting Vittorio Giovara (2016-12-06 06:27:28) > Deprecated in 05/2014. > --- > libavformat/mux.c | 7 --- > libavformat/version.h | 3 --- > 2 files changed, 10 deletions(-) > Ok -- Anton Khirnov ___ libav-devel mailin

Re: [libav-devel] [PATCH 07/12] mlp: Convert to the new bitstream reader

2016-12-19 Thread Anton Khirnov
--- > 3 files changed, 136 insertions(+), 132 deletions(-) > LGTM -- Anton Khirnov ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 1/4] frame: add left/top cropping fields to AVFrame

2016-12-19 Thread Anton Khirnov
Quoting Vittorio Giovara (2016-12-19 10:11:29) > On Sun, Dec 18, 2016 at 9:27 PM, Anton Khirnov <an...@khirnov.net> wrote: > > --- > > doc/APIchanges | 4 > > libavutil/frame.c | 2 ++ > > libavutil/frame.h | 14 ++ > > libavutil

Re: [libav-devel] [PATCH 02/41] lavfi: Drop deprecated way of passing options for a few filters

2016-12-19 Thread Anton Khirnov
filter/af_channelmap.c > +++ b/libavfilter/af_channelmap.c Looks ok. -- Anton Khirnov ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 08/41] lavf: Drop deprecated AVFract type and related field

2016-12-19 Thread Anton Khirnov
Quoting Vittorio Giovara (2016-12-06 06:27:29) > Deprecated in 05/2014. > --- > libavformat/avformat.h | 21 - > libavformat/version.h | 3 --- > 2 files changed, 24 deletions(-) > Ok -- Anton Khirnov ___ l

Re: [libav-devel] [PATCH 01/41] Bump major versions of all libraries

2016-12-19 Thread Anton Khirnov
sion > > conflict. See for example 6d3ea1957f681b3bf9c752e6d21a501cc8d4180d or > > 3bc2e89c76e88ae6f1fd5287e0b11abcfc3c601c. While most of the root > > causes for those incompatibilities have been long resolved, it's still > > a good practice and relatively harmless to do. > > There was this idea of a single version number for all libraries. > Maybe it's time to revisit it? I do not think it is a good idea. IMO the libraries should be growing more separate, not less. -- Anton Khirnov ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

[libav-devel] [PATCH] hevcdec: do not set decoder-global SPS prematurely

2016-12-18 Thread Anton Khirnov
It should only be set after the decoder state has been fully initialized for using that SPS. Fixes possible invalid reads on get_format() failure. CC: libav-sta...@libav.org --- libavcodec/hevcdec.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/libavcodec/hevcdec.c

[libav-devel] [PATCH 2/4] lavc: add an option for exporting cropping information to the caller

2016-12-18 Thread Anton Khirnov
Also, add generic code for handling cropping, so the decoders can export just the cropping size and not bother with the rest. --- doc/APIchanges | 4 ++ libavcodec/avcodec.h | 26 + libavcodec/decode.c| 96 ++

[libav-devel] [PATCH 1/4] frame: add left/top cropping fields to AVFrame

2016-12-18 Thread Anton Khirnov
--- doc/APIchanges | 4 libavutil/frame.c | 2 ++ libavutil/frame.h | 14 ++ libavutil/version.h | 2 +- 4 files changed, 21 insertions(+), 1 deletion(-) diff --git a/doc/APIchanges b/doc/APIchanges index 7633c99..ca95308 100644 --- a/doc/APIchanges +++

[libav-devel] [PATCH 3/4] hevcdec: export cropping information instead of handling it internally

2016-12-18 Thread Anton Khirnov
--- libavcodec/hevc_parser.c | 4 ++-- libavcodec/hevc_ps.c | 17 + libavcodec/hevc_refs.c | 17 ++--- libavcodec/hevcdec.c | 1 - libavcodec/hevcdec.h | 2 -- 5 files changed, 9 insertions(+), 32 deletions(-) diff --git a/libavcodec/hevc_parser.c

[libav-devel] [PATCH 4/4] h264dec: export cropping information instead of handling it internally

2016-12-18 Thread Anton Khirnov
--- libavcodec/h264_ps.c| 9 - libavcodec/h264_slice.c | 7 +-- libavcodec/h264dec.c| 24 ++-- 3 files changed, 7 insertions(+), 33 deletions(-) diff --git a/libavcodec/h264_ps.c b/libavcodec/h264_ps.c index 8a64a33..7ee3876 100644 ---

[libav-devel] [PATCH] h264dec: make sure to only end a field if it has been started

2016-12-18 Thread Anton Khirnov
Calling ff_h264_field_end() when the per-field state is not properly initialized leads to all kinds of undefined behaviour. CC: libav-sta...@libav.org Bug-Id: 977 978 992 --- libavcodec/h264_picture.c | 1 + libavcodec/h264_slice.c | 4 ++-- libavcodec/h264dec.c | 3 ++-

[libav-devel] [PATCH 1/4] mov: fix a possible invalid read in mov_read_mac_string()

2016-12-17 Thread Anton Khirnov
When the input string is too large, so the second condition in if () fails, the code will erroneously execute the else branch, indexing the mac_to_unicode table with a negative index. CC: libav-sta...@libav.org Bug-Id: 1000 Found-By: Kamil Frankowicz --- libavformat/mov.c | 6 +- 1 file

[libav-devel] [PATCH 2/4] mpegvideo_parser: avoid signed overflow in bitrate calculation

2016-12-17 Thread Anton Khirnov
CC: libav-sta...@libav.org Bug-Id: 981 Found-By: Agostino Sarubbo --- libavcodec/mpegvideo_parser.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/libavcodec/mpegvideo_parser.c b/libavcodec/mpegvideo_parser.c index 27f2985..500d124 100644 ---

[libav-devel] [PATCH 4/4] mpeg12dec: move setting first_field to mpeg_field_start()

2016-12-17 Thread Anton Khirnov
For field picture, the first_field is set based on its previous value. Before this commit, first_field is set when reading the picture coding extension. However, in corrupted files there may be multiple picture coding extension headers, so the final value of first_field that is actually used

[libav-devel] [PATCH 3/4] mpeg12dec: avoid signed overflow in bitrate calculation

2016-12-17 Thread Anton Khirnov
CC: libav-sta...@libav.org Bug-Id: 981 Found-By: Agostino Sarubbo --- libavcodec/mpeg12dec.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/libavcodec/mpeg12dec.c b/libavcodec/mpeg12dec.c index 2d9c99d..310169b 100644 --- a/libavcodec/mpeg12dec.c +++

[libav-devel] [PATCH] hevcdec: add a VAAPI hwaccel

2016-12-15 Thread Anton Khirnov
Partially based on a patch by Timo Rothenpieler . Additional scaling list handling fix by Jun Zhao . --- Changelog | 2 +- configure | 3 + libavcodec/Makefile | 1 + libavcodec/allcodecs.c| 1 +

[libav-devel] [PATCH] vaapi_decode: use the correct logging context

2016-12-15 Thread Anton Khirnov
From: elenril --- libavcodec/vaapi_decode.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/vaapi_decode.c b/libavcodec/vaapi_decode.c index 88bd889..42f03ab 100644 --- a/libavcodec/vaapi_decode.c +++ b/libavcodec/vaapi_decode.c

Re: [libav-devel] [PATCH 2/2] hevcdec: add a VAAPI hwaccel

2016-12-15 Thread Anton Khirnov
Quoting Diego Biurrun (2016-12-15 12:18:44) > On Thu, Dec 15, 2016 at 12:03:36PM +0100, Anton Khirnov wrote: > > Quoting Diego Biurrun (2016-12-15 10:58:52) > > > On Thu, Dec 15, 2016 at 10:32:09AM +0100, Anton Khirnov wrote: > > > > Partially based on a

Re: [libav-devel] [PATCH 2/2] hevcdec: add a VAAPI hwaccel

2016-12-15 Thread Anton Khirnov
Quoting Diego Biurrun (2016-12-15 10:58:52) > On Thu, Dec 15, 2016 at 10:32:09AM +0100, Anton Khirnov wrote: > > Partially based on a patch by Timo Rothenpieler <t...@rothenpieler.org> > > --- > > Changelog | 2 +- > > configure

[libav-devel] [PATCH 2/2] hevcdec: add a VAAPI hwaccel

2016-12-15 Thread Anton Khirnov
Partially based on a patch by Timo Rothenpieler --- Changelog | 2 +- configure | 3 + libavcodec/Makefile | 1 + libavcodec/allcodecs.c| 1 + libavcodec/hevcdec.c | 6 +- libavcodec/vaapi_decode.c | 1 +

[libav-devel] [PATCH 1/2] Changelog: add some missing entries

2016-12-15 Thread Anton Khirnov
--- Changelog | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Changelog b/Changelog index feb151c..ab7f1b6 100644 --- a/Changelog +++ b/Changelog @@ -3,6 +3,9 @@ releases are sorted from youngest to oldest. version : - Support for spherical videos +- Intel QSV-accelerated VP8 and VC-1

[libav-devel] [PATCH] v4l2: use codec descriptors for mapping a codec name to id

2016-12-14 Thread Anton Khirnov
This mapping has nothing to do with decoder implementations, so using decoder names is wrong. --- libavdevice/v4l2.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavdevice/v4l2.c b/libavdevice/v4l2.c index 0479121..a8afe8a 100644 --- a/libavdevice/v4l2.c +++

Re: [libav-devel] [PATCH] avconv: add avconv_d3d11va

2016-12-14 Thread Anton Khirnov
Quoting Anton Khirnov (2016-12-14 11:05:49) > Quoting Steve Lhomme (2016-12-13 14:19:03) > > From: Steve Lhomme <rob...@videolabs.io> > > > > The code is similar to avconv_dxva2. The decoded output needs to be copied > > into > > a staging texture that ca

Re: [libav-devel] [libav-commits] fate: Add h264 test for frame num gaps

2016-12-14 Thread Anton Khirnov
Quoting Derek Buitenhuis (2016-12-14 11:31:30) > Module: libav > Branch: master > Commit: e94b9313b21c3d91a36ef064f7fe3e867616f47f > > Author:Derek Buitenhuis <derek.buitenh...@gmail.com> > Committer: Anton Khirnov <an...@khirnov.net> > Date: Mon Dec

Re: [libav-devel] [PATCH] pthread_frame: use better memory orders for frame progress

2016-12-14 Thread Anton Khirnov
ess[1] using > atomic_init(). > > Signed-off-by: Wan-Teh Chang <w...@google.com> > --- > libavcodec/pthread_frame.c | 8 ++++ > 1 file changed, 4 insertions(+), 4 deletions(-) Pushed, thanks. -- Anton Khirnov ___ libav-

Re: [libav-devel] [PATCH] avconv: add avconv_d3d11va

2016-12-14 Thread Anton Khirnov
avconv_d3d11va.c The whole hwcontext_d3d11va implementation seems to be missing from this patch. -- Anton Khirnov ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 1/2] h264_slice: Wait for refs to be available before we use them in error concealment

2016-12-14 Thread Anton Khirnov
av_image_copy(h->short_ref[0]->f->data, > h->short_ref[0]->f->linesize, >(const uint8_t **)prev->f->data, > -- > 2.11.0 Thanks, pushed. -- Anton Khirnov ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] configure: Add the full parser to the codec dependencies

2016-12-14 Thread Anton Khirnov
Quoting Luca Barbato (2016-12-02 22:01:11) > Matches h263. And? I don't see how that implies that this is the correct thing to do. The h264 decoder does not invoke the parser, so it should not depend on it. -- Anton Khirnov ___ libav-devel mail

[libav-devel] [PATCH] pthread_frame: do not run hwaccel decoding asynchronously unless it's safe

2016-12-14 Thread Anton Khirnov
Certain hardware decoding APIs are not guaranteed to be thread-safe, so having the user access decoded hardware surfaces while the decoder is running in another thread can cause failures (this is mainly known to happen with DXVA2). For such hwaccels, only allow the decoding thread to run while

[libav-devel] [PATCH] pthread_frame: ensure the threads don't run simultaneously with hwaccel

2016-12-14 Thread Anton Khirnov
--- libavcodec/h263dec.c | 2 +- libavcodec/h264dec.c | 2 +- libavcodec/pthread_frame.c | 35 +++ 3 files changed, 37 insertions(+), 2 deletions(-) diff --git a/libavcodec/h263dec.c b/libavcodec/h263dec.c index e4a7227..921ff5f 100644 ---

Re: [libav-devel] [PATCH] vaapi: Support PAL8

2016-12-14 Thread Anton Khirnov
Quoting Luca Barbato (2016-12-12 16:01:18) > On 12/12/2016 13:09, Anton Khirnov wrote: > > Quoting Luca Barbato (2016-12-10 19:29:44) > >> On 10/12/2016 18:44, Mark Thompson wrote: > >>> Um, what? The internet thinks that P208 is a YUV 4:2:2 two-plane format &g

Re: [libav-devel] [PATCH] vaapi: Support PAL8

2016-12-12 Thread Anton Khirnov
> I know ... > > > Also, the middle field there should be a VA_RT_FORMAT (I suggest using the > > macro). > > I know ... > > Yet that's the way (TM), Intel examples are using to support hevc > encoding + vaapi... > > If you have better ideas I'm all ears. HEVC

Re: [libav-devel] [PATCH] lavc: handle MP3 in get_audio_frame_duration()

2016-12-12 Thread Anton Khirnov
ping -- Anton Khirnov ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] tta: Convert to the new bitstream reader

2016-12-08 Thread Anton Khirnov
Quoting Diego Biurrun (2016-11-25 21:57:54) > From: Alexandra Hájková <alexan...@khirnov.net> > > --- > > Rebased on top of Anton's tta cleanup. > > libavcodec/tta.c | 44 ++-- > 1 file changed, 22 insertions(+), 22 del

Re: [libav-devel] [PATCH 3/3] pthread_frame: do not run hwaccel decoding asynchronously unless it's safe

2016-12-07 Thread Anton Khirnov
Quoting Diego Biurrun (2016-12-06 23:20:45) > On Sat, Dec 03, 2016 at 05:34:34PM +0100, Anton Khirnov wrote: > > --- /dev/null > > +++ b/libavcodec/hwaccel.h > > @@ -0,0 +1,24 @@ > > +#ifndef AVCODEC_HWACCEL_H > > +#define AVCODEC_HWACCEL_H > > + > >

[libav-devel] [PATCH 1/3] hevc: decouple calling get_format() from exporting the SPS parameters

2016-12-03 Thread Anton Khirnov
This makes sure ff_get_format() does not get called unnecessarily from update_thread_context(). --- libavcodec/hevcdec.c | 49 ++--- 1 file changed, 30 insertions(+), 19 deletions(-) diff --git a/libavcodec/hevcdec.c b/libavcodec/hevcdec.c index

[libav-devel] [PATCH 3/3] pthread_frame: do not run hwaccel decoding asynchronously unless it's safe

2016-12-03 Thread Anton Khirnov
Certain hardware decoding APIs are often not thread-safe, so having the user access decoded hardware surfaces while the decoder is running in another thread can cause failures (this is mainly known to happen with DXVA2). For such hwaccels, only allow the decoding thread to run while the user is

[libav-devel] [PATCH 2/3] pthread_frame: ensure the threads don't run simultaneously with hwaccel

2016-12-03 Thread Anton Khirnov
--- libavcodec/h263dec.c | 2 +- libavcodec/h264dec.c | 2 +- libavcodec/pthread_frame.c | 27 +++ 3 files changed, 29 insertions(+), 2 deletions(-) diff --git a/libavcodec/h263dec.c b/libavcodec/h263dec.c index e4a7227..921ff5f 100644 ---

Re: [libav-devel] [PATCH 06/12] mimic: Convert to the new bitstream reader

2016-12-03 Thread Anton Khirnov
Quoting Diego Biurrun (2016-11-27 17:32:37) > From: Alexandra Hájková <alexan...@khirnov.net> > > --- > libavcodec/mimic.c | 24 > 1 file changed, 12 insertions(+), 12 deletions(-) > Ok -- Anton Khirnov ___

Re: [libav-devel] [PATCH 05/12] metasound: Convert to the new bitstream reader

2016-12-03 Thread Anton Khirnov
Quoting Diego Biurrun (2016-11-27 17:32:36) > From: Alexandra Hájková <alexan...@khirnov.net> > > --- > libavcodec/metasound.c | 44 ++-- > 1 file changed, 22 insertions(+), 22 deletions(-) >

Re: [libav-devel] [PATCH 04/12] lagarith: Convert to the new bitstream reader

2016-12-03 Thread Anton Khirnov
insertions(+), 19 deletions(-) Ok -- Anton Khirnov ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 03/12] indeo: Convert to the new bitstream reader

2016-12-03 Thread Anton Khirnov
gt; libavcodec/indeo5.c | 127 + > libavcodec/ivi.c| 71 --- > libavcodec/ivi.h| 11 ++-- > 6 files changed, 206 insertions(+), 196 deletions(-) Ok -- Anton Khirnov ___ libav-devel m

Re: [libav-devel] [PATCH 02/12] imc: Convert to the new bitstream reader

2016-12-03 Thread Anton Khirnov
Quoting Diego Biurrun (2016-11-27 17:32:33) > From: Alexandra Hájková <alexan...@khirnov.net> > > --- > libavcodec/imc.c | 45 +++-- > 1 file changed, 23 insertions(+), 22 deletions(-)

[libav-devel] [PATCH] lavc: handle MP3 in get_audio_frame_duration()

2016-12-02 Thread Anton Khirnov
--- libavcodec/utils.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/utils.c b/libavcodec/utils.c index 0b44bb6..5350eb8 100644 --- a/libavcodec/utils.c +++ b/libavcodec/utils.c @@ -1186,6 +1186,9 @@ static int get_audio_frame_duration(enum AVCodecID id, int sr, int ch, int

Re: [libav-devel] [PATCH] compat/atomics: add support for the new memory model aware gcc built-ins

2016-12-02 Thread Anton Khirnov
d 4.8, since 4.9 already supports stdatomic.h) old, obsolete and unmaintained gcc versions. Why even bother? -- Anton Khirnov ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 09/13] build: Drop support for old versions of libdc1394

2016-12-01 Thread Anton Khirnov
he wild? > > That's a question for Anton, he added that option back in 2011. Well, I only added it to replace the stuff in AVFormatParameters. But for what my opinion here is worth (never used this device), if this option is just for the obsolete library version then it didn't even exist for a

Re: [libav-devel] [PATCH 2/2] pnm: Drop inappropriate const qualifier

2016-11-30 Thread Anton Khirnov
PNMContext * const s = avctx->priv_data; > AVFrame * const p= data; > -- > 2.1.4 Again, how is it "inappropriate"? The input packet must not be modified by the decoder, so buf being const is perfectly appropriate. -- Anton Khirnov ___

Re: [libav-devel] [PATCH 1/2] rangecoder: Drop incorrect const from ff_init_range_decoder

2016-11-30 Thread Anton Khirnov
ecoder modify the input buffer? And I asked you multiple times already to stop just citing warnings as justifications for such patches. A warning may or may not be a symptom of a problem in the code. What you should be fixed is that underlying problem, not the warning itself.

Re: [libav-devel] [PATCH] pthread_frame: use better memory orders for frame progress

2016-11-30 Thread Anton Khirnov
easurable change in performance after this patch? I used to have lot more explicit memory orders in my original version of the patch, but then I dropped most of them, since I thought they were unlikely to have any significant effect and just added a chance of hard to detect racy bugs. -- Anton Khirnov ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

[libav-devel] [PATCH 8/8] binkaudio: switch to the new send/receive API

2016-11-30 Thread Anton Khirnov
It is more natural for this codec and allows to avoid awkward constructs like "consuming 0 bytes from input". Also, keep a reference to the input packet to avoid unnecessary copying. --- libavcodec/binkaudio.c | 58 -- 1 file changed, 32

[libav-devel] [PATCH v2] Decoding core rewrite

2016-11-30 Thread Anton Khirnov
converted binkaudio to the new API, mainly as a proof of concept. I think eventually we should covert all the decoders consuming partial packets to the new API, to avoid various associated ambiguities. Since it only concerns several audio decoders, it should be doable. -- Anton Khirnov

[libav-devel] [PATCH 1/8] lavc: add a null bitstream filter

2016-11-30 Thread Anton Khirnov
It is useful for testing/debugging and will also be used as the default filter in the following commit adding pre-decode filtering to avoid having a separate non-filtered codepath. --- doc/bitstream_filters.texi | 3 +++ libavcodec/Makefile| 1 + libavcodec/bitstream_filters.c |

[libav-devel] [PATCH 3/8] decode: restructure the core decoding code

2016-11-30 Thread Anton Khirnov
Currently, the new decoding API is pretty much just a wrapper around the old deprecated one. This is problematic, since it interferes with making full use of the flexibility added by the new API. The old API should also be removed at some future point. Reorganize the code so that the new

[libav-devel] [PATCH 4/8] lavc: add support for filtering packets before decoding

2016-11-30 Thread Anton Khirnov
--- configure | 1 + libavcodec/avcodec.h | 6 ++ libavcodec/decode.c | 163 ++ libavcodec/decode.h | 2 + libavcodec/internal.h | 6 ++ libavcodec/utils.c| 3 + 6 files changed, 169 insertions(+), 12 deletions(-)

[libav-devel] [PATCH 2/8] decode: be more explicit about storing the last packet properties

2016-11-30 Thread Anton Khirnov
The current code stores a pointer to the packet passed to the decoder, which is then used during get_buffer() for timestamps and side data passthrough. However, since this is a pointer to user data which we do not own, storing it is potentially dangerous. It is also ill defined for the new

[libav-devel] [PATCH 5/8] qsvdec_h2645: switch to the new generic filtering mechanism

2016-11-30 Thread Anton Khirnov
Drop the internal manual conversion from the MP4 format to Annex B. --- libavcodec/qsvdec_h2645.c | 74 +++ 1 file changed, 11 insertions(+), 63 deletions(-) diff --git a/libavcodec/qsvdec_h2645.c b/libavcodec/qsvdec_h2645.c index a26f150..8ac403b

[libav-devel] [PATCH 7/8] vp9: split superframes in the filtering stage before actual decoding

2016-11-30 Thread Anton Khirnov
Significantly increases the efficiency of frame threading, since individual frames in a superframe can now be decoded in parallel. --- configure| 2 +- libavcodec/vp9.c | 74 ++-- 2 files changed, 14 insertions(+), 62 deletions(-) diff

[libav-devel] [PATCH 6/8] lavc: add a bitstream filter for splitting VP9 superframes

2016-11-30 Thread Anton Khirnov
Partially based on code by Ronald S. Bultje . --- doc/bitstream_filters.texi| 4 + libavcodec/Makefile | 1 + libavcodec/bitstream_filters.c| 1 + libavcodec/vp9_superframe_split_bsf.c | 146 ++ 4

Re: [libav-devel] [PATCH] qsv: Increase the surface pool

2016-11-30 Thread Anton Khirnov
ze = 64; > frames_hwctx->frame_type = MFX_MEMTYPE_VIDEO_MEMORY_DECODER_TARGET; > > ret = av_hwframe_ctx_init(ist->hw_frames_ctx); > -- > 2.9.2 I think at this point we should just add an avconv option for setting the pool size

Re: [libav-devel] [PATCH] lavfi: Add VAAPI deinterlacer

2016-11-30 Thread Anton Khirnov
Quoting Mark Thompson (2016-11-29 23:48:19) > --- > On 29/11/16 11:50, Anton Khirnov wrote: > > Either one is fine with me. I guess picking the higher numbered might be > > a little safer since it will also work in implementations that don't > > support motion-adaptive,

Re: [libav-devel] [PATCH 3/3] vaapi_encode: Add VP8 support

2016-11-30 Thread Anton Khirnov
of those things, and therefore it's pretty much trivial if we only > support P frames. (That does also mean that the result is atrocious, > so this is mainly a curiosity for now.) I suppose it's much faster than libvpx, so it can still be rather useful. -- Anton Khirnov

Re: [libav-devel] [PATCH 3/3] vaapi_encode: Add VP8 support

2016-11-30 Thread Anton Khirnov
N(avctx->height, 16); > + > +return ff_vaapi_encode_init(avctx); > +} > + > +#define OFFSET(x) (offsetof(VAAPIEncodeContext, codec_options_data) + \ > + offsetof(VAAPIEncodeVP8Options, x)) > +#define FLAGS (AV_OPT

Re: [libav-devel] [PATCH 2/3] vaapi_encode: Pass framerate parameters to driver

2016-11-30 Thread Anton Khirnov
odec/vaapi_encode.c | 25 + > libavcodec/vaapi_encode.h | 4 > 2 files changed, 29 insertions(+) > Looks ok. -- Anton Khirnov ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 1/3] vaapi_h265: Fix CFR mode with framerate set in AVCodecContext

2016-11-30 Thread Anton Khirnov
ck = avctx->framerate.den; > +vseq->vui_time_scale= avctx->framerate.num; > } else { > vseq->vui_num_units_in_tick = avctx->time_base.num; > vseq->vui_time_scale= avctx->time_base.den; > -- > 2.10.2 ok -- A

Re: [libav-devel] [PATCH] lavfi: Add VAAPI deinterlacer

2016-11-29 Thread Anton Khirnov
Quoting Mark Thompson (2016-11-29 10:52:20) > On 29/11/16 09:07, Anton Khirnov wrote: > > Quoting Mark Thompson (2016-11-25 00:27:11) > >> --- > >> Tested somewhat on Skylake GT2 and Polaris 11; on both it comes up with > >> something which looks pretty

Re: [libav-devel] [PATCH] h264: make the parser less verbose

2016-11-29 Thread Anton Khirnov
complete frames. If at the point where parse_nal_units() is called we do not have a complete frame then something went wrong and this should be reported or handled somehow. -- Anton Khirnov ___ libav-devel mailing list libav-devel@libav.org https://lists.li

Re: [libav-devel] [PATCH] avconv: Fix the audio next dts computation

2016-11-29 Thread Anton Khirnov
ded_frame->pts != AV_NOPTS_VALUE) > -ist->next_dts = decoded_frame->pts; > +ist->next_dts = av_rescale_q(decoded_frame->pts, ist->st->time_base, > AV_TIME_BASE_Q); > else if (pkt && pkt->pts != AV_NOPTS_VALU

Re: [libav-devel] [PATCH] lavfi: Add VAAPI deinterlacer

2016-11-29 Thread Anton Khirnov
_SUCCESS) { > +av_log(avctx, AV_LOG_ERROR, "Failed to start picture processing: " > + "%d (%s).\n", vas, vaErrorStr(vas)); > + err = AVERROR(EIO); > +goto fail_after_render; > +} > + > +if (ctx->hwctx-&g

Re: [libav-devel] [PATCH 02/14] aac_adtstoasc_bsf: convert to the new API

2016-11-27 Thread Anton Khirnov
Quoting James Almer (2016-11-25 03:02:30) > On 3/19/2016 1:02 PM, Anton Khirnov wrote: > > Quoting Luca Barbato (2016-03-07 09:10:14) > >> On 07/03/16 08:59, Luca Barbato wrote: > >>> On 04/03/16 09:15, Anton Khirnov wrote: > >>>> --

Re: [libav-devel] [PATCH] pthread_frame: do not run hwaccel decoding asynchronously

2016-11-25 Thread Anton Khirnov
Quoting Anton Khirnov (2016-11-24 19:19:59) > Only allow the decoding thread to run while the user is inside a lavc > decode call (avcodec_send_packet/receive_frame). > Hardware decoding APIs are often not thread-safe, so having the user > access decoded hardware surfaces while

Re: [libav-devel] [PATCH] pthread_frame: do not run hwaccel decoding asynchronously

2016-11-24 Thread Anton Khirnov
Quoting Janne Grunau (2016-11-25 00:17:17) > On 2016-11-24 19:19:59 +0100, Anton Khirnov wrote: > > Only allow the decoding thread to run while the user is inside a lavc > > decode call (avcodec_send_packet/receive_frame). > > Hardware decoding APIs are often not thread-saf

[libav-devel] [PATCH] pthread_frame: do not run hwaccel decoding asynchronously

2016-11-24 Thread Anton Khirnov
Only allow the decoding thread to run while the user is inside a lavc decode call (avcodec_send_packet/receive_frame). Hardware decoding APIs are often not thread-safe, so having the user access decoded hardware surfaces while the decoder is running in another thread can cause failures (this is

Re: [libav-devel] [PATCH] avpacket: fix leak on realloc in av_packet_add_side_data()

2016-11-23 Thread Anton Khirnov
<jamr...@gmail.com> > --- > Should be backported to release/12. Pushed, thanks -- Anton Khirnov ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

[libav-devel] [PATCH 1/2] tta: use get_unary() instead of a custom implementation

2016-11-23 Thread Anton Khirnov
--- libavcodec/tta.c | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/libavcodec/tta.c b/libavcodec/tta.c index 2b57406..2ac8255 100644 --- a/libavcodec/tta.c +++ b/libavcodec/tta.c @@ -35,6 +35,7 @@ #include "avcodec.h" #include "get_bits.h" #include

[libav-devel] [PATCH 2/2] tta: avoid undefined shifts

2016-11-23 Thread Anton Khirnov
--- libavcodec/tta.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/tta.c b/libavcodec/tta.c index 2ac8255..5532580 100644 --- a/libavcodec/tta.c +++ b/libavcodec/tta.c @@ -360,7 +360,7 @@ static int tta_decode_frame(AVCodecContext *avctx, void *data, }

Re: [libav-devel] [PATCH] hmac: Explicitly convert types at function pointer assignment

2016-11-23 Thread Anton Khirnov
Quoting Diego Biurrun (2016-11-14 16:01:43) > On Mon, Nov 14, 2016 at 12:11:47PM +0100, Anton Khirnov wrote: > > Quoting Diego Biurrun (2016-11-14 11:58:34) > > > On Mon, Nov 14, 2016 at 11:40:22AM +0100, Anton Khirnov wrote: > > > > Quoting Diego Biurrun (2016-11

Re: [libav-devel] [PATCH 1/9] lavc: add a null bitstream filter

2016-11-23 Thread Anton Khirnov
Quoting Diego Biurrun (2016-11-23 09:23:10) > On Wed, Nov 23, 2016 at 09:15:06AM +0100, Anton Khirnov wrote: > > Quoting Diego Biurrun (2016-11-22 15:17:22) > > > On Tue, Nov 22, 2016 at 02:36:31PM +0100, Anton Khirnov wrote: > > > > --- > > >

Re: [libav-devel] [PATCH 2/4 v2] lavu: Add AVSphericalMapping type and frame side data

2016-11-23 Thread Anton Khirnov
32_t pitch; ///< Counter-clockwise rotation around the right vector > [-90, 90]. > +int32_t roll; ///< Counter-clockwise rotation around the forward vector > [-180, 180]. > +/** > + * @} > + */ > + >

Re: [libav-devel] [PATCH v3] mov: Export spherical information

2016-11-23 Thread Anton Khirnov
(check for version+size) > as reported by James. > Vittorio > > Changelog | 1 + > libavformat/isom.h | 6 ++ > libavformat/mov.c | 304 > + > 3 files cha

Re: [libav-devel] [PATCH 3/4 v2] lavc: Add spherical packet side data API

2016-11-23 Thread Anton Khirnov
AV_SPHERICAL_CUBEMAP) > +probe_str("projection", "cubemap"); > +else > +probe_str("projection", "unknown"); > + > +probe_object_header("orientation"); > +

Re: [libav-devel] [PATCH 1/9] lavc: add a null bitstream filter

2016-11-23 Thread Anton Khirnov
Quoting Diego Biurrun (2016-11-22 15:17:22) > On Tue, Nov 22, 2016 at 02:36:31PM +0100, Anton Khirnov wrote: > > --- > > doc/bitstream_filters.texi | 3 +++ > > libavcodec/Makefile| 1 + > > libavcodec/bitstream_filters.c | 1 + > > li

Re: [libav-devel] [PATCH 7/9] qsvdec_h2645: switch to the new generic filtering mechanism

2016-11-23 Thread Anton Khirnov
Quoting Diego Biurrun (2016-11-22 15:32:03) > On Tue, Nov 22, 2016 at 02:36:37PM +0100, Anton Khirnov wrote: > > Drop the internal manual conversion from the MP4 format to Annex B. > > --- > > libavcodec/qsvdec_h2645.c | 74 > > +++-

Re: [libav-devel] [PATCH 2/9] lavc: move encoding-related code from utils.c to a new file

2016-11-23 Thread Anton Khirnov
Quoting Vittorio Giovara (2016-11-22 17:03:43) > On Tue, Nov 22, 2016 at 8:36 AM, Anton Khirnov <an...@khirnov.net> wrote: > > + > > +int ff_alloc_packet(AVPacket *avpkt, int size) > > +{ > > +if (size > INT_MAX - AV_INPUT_BUFFER_PADDING_SIZE

Re: [libav-devel] [PATCH 1/3] ape: Restructure DEBUG ifdefs to avoid unused function parameter warnings

2016-11-23 Thread Anton Khirnov
ead_header(AVFormatContext * s) > { > -- > 2.1.4 This is incredibly silly IMO. Unused function parameters are very common and are NOT a problem (which is why they are not enabled by default). Shuffling perfectly valid code around just to appease some specific compiler with some specifi

[libav-devel] [PATCH] examples/decode_audio: flush the decoder

2016-11-23 Thread Anton Khirnov
--- doc/examples/decode_audio.c | 5 + 1 file changed, 5 insertions(+) diff --git a/doc/examples/decode_audio.c b/doc/examples/decode_audio.c index e7b27d3..d952b49 100644 --- a/doc/examples/decode_audio.c +++ b/doc/examples/decode_audio.c @@ -179,6 +179,11 @@ int main(int argc, char **argv)

[libav-devel] [PATCH 9/9] vp9: split superframes in the filtering stage before actual decoding

2016-11-22 Thread Anton Khirnov
Significantly increases the efficiency of frame threading, since individual frames in a superframe can now be decoded in parallel. --- configure| 2 +- libavcodec/vp9.c | 74 ++-- 2 files changed, 14 insertions(+), 62 deletions(-) diff

[libav-devel] [PATCH 1/9] lavc: add a null bitstream filter

2016-11-22 Thread Anton Khirnov
--- doc/bitstream_filters.texi | 3 +++ libavcodec/Makefile| 1 + libavcodec/bitstream_filters.c | 1 + libavcodec/null_bsf.c | 44 ++ 4 files changed, 49 insertions(+) create mode 100644 libavcodec/null_bsf.c diff --git

[libav-devel] [PATCH 3/9] lavc: move decoding-related code from utils.c to a new file

2016-11-22 Thread Anton Khirnov
--- libavcodec/Makefile | 1 + libavcodec/decode.c | 924 libavcodec/utils.c | 889 -- 3 files changed, 925 insertions(+), 889 deletions(-) create mode 100644 libavcodec/decode.c diff --git

[libav-devel] [PATCH 7/9] qsvdec_h2645: switch to the new generic filtering mechanism

2016-11-22 Thread Anton Khirnov
Drop the internal manual conversion from the MP4 format to Annex B. --- libavcodec/qsvdec_h2645.c | 74 +++ 1 file changed, 11 insertions(+), 63 deletions(-) diff --git a/libavcodec/qsvdec_h2645.c b/libavcodec/qsvdec_h2645.c index a26f150..8ac403b

[libav-devel] [PATCH 6/9] lavc: add support for filtering packets before decoding

2016-11-22 Thread Anton Khirnov
--- configure | 1 + libavcodec/avcodec.h | 6 ++ libavcodec/decode.c | 172 ++ libavcodec/internal.h | 8 +++ libavcodec/utils.c| 2 + 5 files changed, 177 insertions(+), 12 deletions(-) diff --git a/configure

<    1   2   3   4   5   6   7   8   9   10   >