Re: [libav-devel] [PATCH 2/2] xwddec: Check bpp more completely

2017-08-12 Thread Diego Biurrun
On Fri, Aug 11, 2017 at 09:35:32PM +0200, Luca Barbato wrote: > On 11/08/2017 20:46, Diego Biurrun wrote: > > From: Michael Niedermayer > > > > Fixes out of array access > > Fixes: 1399/clusterfuzz-testcase-minimized-4866094172995584 > > Bug-Id: CVE-2017-9991 > > CC: libav-sta...@libav.org > > >

[libav-devel] [PATCH] xwddec: support 8bpp grayscale

2017-08-12 Thread Diego Biurrun
From: Piotr Bandurski (cherry picked from commit b9c94e826e7551027754ecfa60e3e487e0c28fcb) Signed-off-by: Diego Biurrun --- Includes the check for bpp == pixdepth now. libavcodec/xwddec.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/libavcodec/xwddec.c b/libavcod

Re: [libav-devel] [PATCH] xwddec: support 8bpp grayscale

2017-08-12 Thread Luca Barbato
On 12/08/2017 09:02, Diego Biurrun wrote: > From: Piotr Bandurski > > (cherry picked from commit b9c94e826e7551027754ecfa60e3e487e0c28fcb) > Signed-off-by: Diego Biurrun > --- > > Includes the check for bpp == pixdepth now. > > libavcodec/xwddec.c | 7 +-- > 1 file changed, 5 insertions(+

Re: [libav-devel] [PATCH 1/2 V6] libavfilter/overlay_qsv: Add QSV overlay vpp filter

2017-08-12 Thread Diego Biurrun
On Fri, Aug 11, 2017 at 09:46:17AM +0800, Huang, Zhengxu wrote: > From c4e8d8c22f2100bd9bffaccca628c5bd3bfd7281 Mon Sep 17 00:00:00 2001 > From: "Huang, Zhengxu" > Date: Tue, 25 Jul 2017 21:55:50 +0800 > Subject: [PATCH] libavfilter/overlay_qsv: Add QSV overlay vpp filter No need for the module p

Re: [libav-devel] [PATCH 01/14] lavc: Add coded bitstream read/write API

2017-08-12 Thread Diego Biurrun
On Fri, Aug 11, 2017 at 12:36:56AM +0100, Mark Thompson wrote: > --- /dev/null > +++ b/libavcodec/cbs.c > @@ -0,0 +1,461 @@ > + > +int ff_cbs_init(CodedBitstreamContext *ctx, > +enum AVCodecID codec_id, void *log_ctx) > +{ > +ctx->log_ctx = log_ctx; > + > +ctx->codec = type;

Re: [libav-devel] [PATCH 02/14] lavc: Add coded bitstream read/write support for H.264

2017-08-12 Thread Diego Biurrun
On Fri, Aug 11, 2017 at 12:36:57AM +0100, Mark Thompson wrote: > --- /dev/null > +++ b/libavcodec/cbs_h2645.c > @@ -0,0 +1,997 @@ > + > +#define FUNC(name) FUNC_H264(READWRITE, name) > +#include "cbs_h264_syntax.c" > +#undef FUNC > + > +#define FUNC(name) FUNC_H264(READWRITE, name) > +#include "cbs

Re: [libav-devel] [PATCH 03/14] lavc: Add coded bitstream read/write support for H.265

2017-08-12 Thread Diego Biurrun
On Fri, Aug 11, 2017 at 12:36:58AM +0100, Mark Thompson wrote: > --- a/libavcodec/cbs_h2645.c > +++ b/libavcodec/cbs_h2645.c > @@ -299,6 +302,10 @@ static int > cbs_h2645_read_more_rbsp_data(BitstreamContext *bc) > #include "cbs_h264_syntax.c" > #undef FUNC > > +#define FUNC(name) FUNC_H265(RE

Re: [libav-devel] [PATCH 05/14] lavc: Add h264_metadata bitstream filter

2017-08-12 Thread Diego Biurrun
On Fri, Aug 11, 2017 at 12:37:00AM +0100, Mark Thompson wrote: > --- /dev/null > +++ b/libavcodec/h264_metadata_bsf.c > @@ -0,0 +1,511 @@ > + > +typedef struct H264MetadataContext { > +const AVClass *class; Isn't the class member unused? Or did I just miss where this is used for logging? Die

Re: [libav-devel] [PATCH 07/14] lavc: Add hevc_metadata bitstream filter

2017-08-12 Thread Diego Biurrun
On Fri, Aug 11, 2017 at 12:37:02AM +0100, Mark Thompson wrote: > --- /dev/null > +++ b/libavcodec/h265_metadata_bsf.c > @@ -0,0 +1,458 @@ > + > +typedef struct H265MetadataContext { > +const AVClass *class; Unused, the same as with H.264? Diego ___

Re: [libav-devel] [PATCH 08/14] vaapi_h264: Convert to use coded bitstream infrastructure

2017-08-12 Thread Diego Biurrun
On Fri, Aug 11, 2017 at 12:37:03AM +0100, Mark Thompson wrote: > --- a/configure > +++ b/configure > @@ -2285,7 +2285,7 @@ h264_omx_encoder_deps="omx" > h264_qsv_decoder_select="h264_mp4toannexb_bsf h264_parser qsvdec > h264_qsv_hwaccel" > h264_qsv_encoder_select="qsvenc" > h264_vaapi_encoder_d

Re: [libav-devel] [PATCH 11/14] vaapi_h265: Convert to use coded bitstream infrastructure

2017-08-12 Thread Diego Biurrun
On Fri, Aug 11, 2017 at 12:37:06AM +0100, Mark Thompson wrote: > --- a/configure > +++ b/configure > @@ -2290,7 +2290,7 @@ hevc_nvenc_encoder_deps="nvenc" > hevc_qsv_decoder_select="hevc_mp4toannexb_bsf hevc_parser hevc_qsv_hwaccel > qsvdec" > hevc_qsv_encoder_select="hevc_ps qsvenc" > hevc_vaa

Re: [libav-devel] [PATCH 13/14] qsvenc_hevc: Replace ad-hoc VPS writing with CBS implementation

2017-08-12 Thread Diego Biurrun
On Fri, Aug 11, 2017 at 12:37:08AM +0100, Mark Thompson wrote: > --- a/configure > +++ b/configure > @@ -2288,7 +2288,7 @@ > h264_vaapi_encoder_deps="VAEncPictureParameterBufferH264" > h264_vaapi_encoder_select="vaapi_encode cbs_h264 golomb" > hevc_nvenc_encoder_deps="nvenc" > hevc_qsv_decoder_

Re: [libav-devel] [PATCH 00/14] Coded bitstream editing (v6)

2017-08-12 Thread Diego Biurrun
On Fri, Aug 11, 2017 at 12:36:55AM +0100, Mark Thompson wrote: > The build system changes want some review, but after that hopefully 1-9 are > done. OK, minor nits noted as replies. Kudos for this whole effort from my side btw. Diego ___ libav-devel m

Re: [libav-devel] [PATCH 1/2 V4] libavfilter/overlay_qsv: Add QSV overlay vpp filter

2017-08-12 Thread Diego Biurrun
On Thu, Aug 10, 2017 at 09:21:25AM +0800, Huang, Zhengxu wrote: > The second one I am not quite sure the format of the filters.texi. So I don't > do this in the new patch. Look at filters.texi, experiment a bit; it should not be hard. If you have trouble, just ask. Diego

Re: [libav-devel] [PATCH 05/14] lavc: Add h264_metadata bitstream filter

2017-08-12 Thread Hendrik Leppkes
On Sat, Aug 12, 2017 at 10:51 AM, Diego Biurrun wrote: > On Fri, Aug 11, 2017 at 12:37:00AM +0100, Mark Thompson wrote: >> --- /dev/null >> +++ b/libavcodec/h264_metadata_bsf.c >> @@ -0,0 +1,511 @@ >> + >> +typedef struct H264MetadataContext { >> +const AVClass *class; > > Isn't the class memb

Re: [libav-devel] [PATCH 1/2 V6] libavfilter/overlay_qsv: Add QSV overlay vpp filter

2017-08-12 Thread Anton Khirnov
Quoting Diego Biurrun (2017-08-12 10:10:30) > On Fri, Aug 11, 2017 at 09:46:17AM +0800, Huang, Zhengxu wrote: > > +s->surface_ptrs_out = > > av_mallocz_array(out_frames_hwctx->nb_surfaces, > > + > > sizeof(*s->surface_ptrs_out)); > > +

Re: [libav-devel] [PATCH 2/2 V2] libavfilter/vf_vpp: Add common filters of the qsv vpp

2017-08-12 Thread Anton Khirnov
Quoting Huang, Zhengxu (2017-08-04 05:15:26) >From 0d3fcc7322b86e236596aad21f704b5844d14446 Mon Sep 17 00:00:00 2001 >From: "Huang, Zhengxu" >Date: Wed, 26 Jul 2017 04:50:06 +0800 >Subject: [PATCH 2/2] libavfilter/vf_vpp: Add common filters of the qsv vpp > >Add common filters of the qsv vpp featu

Re: [libav-devel] [PATCH 10/14] vaapi_h264: Add support for SEI recovery points

2017-08-12 Thread Anton Khirnov
Quoting Mark Thompson (2017-08-11 01:37:05) > Included by default with non-IDR intra frames. LGTM -- Anton Khirnov ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 11/14] vaapi_h265: Convert to use coded bitstream infrastructure

2017-08-12 Thread Anton Khirnov
Quoting Mark Thompson (2017-08-11 01:37:06) > > -priv->ctu_width = FFALIGN(ctx->surface_width, 32) / 32; > -priv->ctu_height= FFALIGN(ctx->surface_height, 32) / 32; > +// This seems to be an Intel driver constraint. Despite MinCbSizeY > +// being 8, we are still required

Re: [libav-devel] [PATCH 12/14] vaapi_h265: Add support for AUD NAL units

2017-08-12 Thread Anton Khirnov
Quoting Mark Thompson (2017-08-11 01:37:07) > Matching the H.264 encoder. > --- Looks ok -- Anton Khirnov ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 13/14] qsvenc_hevc: Replace ad-hoc VPS writing with CBS implementation

2017-08-12 Thread Anton Khirnov
Quoting Mark Thompson (2017-08-11 01:37:08) > This copies more information which should be present from the SPS. > It also fixes the value of vps_temporal_id_nesting_flag, which was > previously incorrect for a single-layer stream (the standard states > that it must be 1, and the reference decoder

Re: [libav-devel] [PATCH 14/14] hevc: Remove unused hevc_ps_enc.c

2017-08-12 Thread Anton Khirnov
Quoting Mark Thompson (2017-08-11 01:37:09) > Replaced with more complete implementation via coded bitstream infrastructure. > --- > Unchanged. Ok -- Anton Khirnov ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listi

Re: [libav-devel] [PATCH] h264dec: add a CUVID hwaccel

2017-08-12 Thread Diego Biurrun
On Thu, Jul 27, 2017 at 01:30:52PM +0300, Martin Storsjö wrote: > On Thu, 27 Jul 2017, Anton Khirnov wrote: > > Quoting Sean McGovern (2017-07-27 07:42:29) > > > On Mon, Jul 24, 2017 at 12:50 PM, Anton Khirnov wrote: > > > > Quoting Luca Barbato (2017-07-24 18:21:20) > > > >> On 24/07/2017 15:15,

Re: [libav-devel] [PATCH V2] libavcodec/mjpeg_qsv: Add the QSV MJPEG encoder

2017-08-12 Thread Diego Biurrun
On Fri, Jul 21, 2017 at 10:08:15AM +0800, Huang, Zhengxu wrote: > > > On 2017/7/20 20:07, Diego Biurrun wrote: > > On Wed, Jul 19, 2017 at 02:41:31PM +0800, Huang, Zhengxu wrote: > > > --- a/libavcodec/qsvenc.c > > > +++ b/libavcodec/qsvenc.c > > > @@ -568,6 +627,24 @@ FF_ENABLE_DEPRECATION_WARNI

Re: [libav-devel] [PATCH 01/14] lavc: Add coded bitstream read/write API

2017-08-12 Thread Mark Thompson
On 12/08/17 09:40, Diego Biurrun wrote: > On Fri, Aug 11, 2017 at 12:36:56AM +0100, Mark Thompson wrote: >> --- /dev/null >> +++ b/libavcodec/cbs.h >> @@ -0,0 +1,274 @@ >> + >> +/** >> + * Write the content of the fragment to its own internal buffer. >> + * >> + * Writes the content of all units an

Re: [libav-devel] [PATCH 02/14] lavc: Add coded bitstream read/write support for H.264

2017-08-12 Thread Mark Thompson
On 12/08/17 09:44, Diego Biurrun wrote: > On Fri, Aug 11, 2017 at 12:36:57AM +0100, Mark Thompson wrote: >> --- /dev/null >> +++ b/libavcodec/cbs_h2645.c >> @@ -0,0 +1,997 @@ >> + >> +#define FUNC(name) FUNC_H264(READWRITE, name) >> +#include "cbs_h264_syntax.c" >> +#undef FUNC >> + >> +#define FUN

Re: [libav-devel] [PATCH 02/14] lavc: Add coded bitstream read/write support for H.264

2017-08-12 Thread Diego Biurrun
On Sat, Aug 12, 2017 at 07:23:50PM +0100, Mark Thompson wrote: > On 12/08/17 09:44, Diego Biurrun wrote: > > On Fri, Aug 11, 2017 at 12:36:57AM +0100, Mark Thompson wrote: > >> --- /dev/null > >> +++ b/libavcodec/cbs_h2645.c > >> @@ -0,0 +1,997 @@ > >> + > >> +#define FUNC(name) FUNC_H264(READWRITE

Re: [libav-devel] [PATCH 01/14] lavc: Add coded bitstream read/write API

2017-08-12 Thread Diego Biurrun
On Sat, Aug 12, 2017 at 07:21:49PM +0100, Mark Thompson wrote: > On 12/08/17 09:40, Diego Biurrun wrote: > > On Fri, Aug 11, 2017 at 12:36:56AM +0100, Mark Thompson wrote: > >> --- /dev/null > >> +++ b/libavcodec/cbs.h > >> @@ -0,0 +1,274 @@ > >> + > >> +/** > >> + * Write the content of the fragme

[libav-devel] [PATCH 13/21] vaapi_h265: Reduce the amount of padding in the stream

2017-08-12 Thread Mark Thompson
It is not necessary to pad to the CTU size. The CB size of 8x8 should be sufficient, but due to constraints in the Intel driver (the one usable implementation of this) it has to be padded to 16x16 like in H.264. --- On 12/08/17 17:02, Anton Khirnov wrote: > Quoting Mark Thompson (2017-08-11 01:37:

[libav-devel] [PATCH] mpeg2enc: Don't mark all streams as component video

2017-08-12 Thread Mark Thompson
Since there is no information about the source format, "unspecified" is the correct value to write here. --- libavcodec/mpeg12enc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/mpeg12enc.c b/libavcodec/mpeg12enc.c index 103f3aaa7..406950901 100644 --- a/libavcodec

Re: [libav-devel] [PATCH 02/14] lavc: Add coded bitstream read/write support for H.264

2017-08-12 Thread Mark Thompson
On 12/08/17 19:45, Diego Biurrun wrote: > On Sat, Aug 12, 2017 at 07:23:50PM +0100, Mark Thompson wrote: >> On 12/08/17 09:44, Diego Biurrun wrote: >>> On Fri, Aug 11, 2017 at 12:36:57AM +0100, Mark Thompson wrote: --- /dev/null +++ b/libavcodec/cbs_h2645.c @@ -0,0 +1,997 @@ + >