On 18/04/11 11:00, Noel Power wrote:
On 17/04/11 02:02, Markus Mohrhard wrote:
[...
So.. the patch as far as I can see looks good, I will do some quick
testing and push it if all is ok, supporting the copy of the
associated code modules ( when copying into a new document ) is
something
On 21/04/11 21:34, Markus Mohrhard wrote:
Hello,
here a short patch that reworks the
ScVbaWorksheet::getAutoFilterMode/setAutoFilterMode methods.
I see Kohei has pushed it :-)
P.S. Noel did you push the last patch?
yes ( done now ), thanks for reminding me :-)
thanks again
Noel
On 24/04/11 13:43, Andreas Radke wrote:
`.text._ZN19ScVbaCollectionBaseIN4cppu15WeakImplHelper1IN3ooo3vba11XCollection4ItemERKN3com3sun4star3uno3AnyESD_[non-virtual
thunk to ScVbaCollectionBasecppu::WeakImplHelper1ooo::vba::XCollection
::Item(com::sun::star::uno::Any const,
Hi
On 26/04/11 20:46, pjpuchyr wrote:
Running calc, I need to load a dll which is not in the search path, and my
problem is
that the Basic ChDir statement does nothing on Windows 7, so the dll can
never be found.
Is there a solution to this problem?
afaik ChDir doesn't work on *any* platform
I agree, Markus please apply for commit access
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Hi Marcel
On 03/05/11 18:46, Marcel HB wrote:
Hello,
I originally posted this bug here:
https://bugs.freedesktop.org/show_bug.cgi?id=33462
[...]
As I'm not really used to send patches over mailing lists so far, I
hope you can use this kind of format. Feel free to use it under the
LGPL v3+
On 03/05/11 15:38, Noel Power wrote:
Hi,
Be great if someone could review cherrypick this patch ( ported from
build repo ) that solves bnc#523191 )
appears that for this week it's ok still to do a bugfix and just post to
the list ( so I pushed
Hi Günter
On 30/04/11 12:56, Günter Heinendirk wrote:
And here my real problems started:
I want to have a dropdown element in the toolbar, which allows to
choose between the available custom slide shows. Since I didn't know,
which custom slide shows are existing, I need to fill the dropdown
I submitted the following patches to libreoffice3.4, scream if you
notice something bad
http://cgit.freedesktop.org/libreoffice/components/commit/?h=libreoffice-3-4id=3db1a4235ac588cda2836f99091888583b461810
please see https://bugs.freedesktop.org/show_bug.cgi?id=37045 and the
patch attached here ( https://bugs.freedesktop.org/attachment.cgi?id=46565 )
if someone would review / cherrypick etc. for libreoffice-3.4 branch
that would be nice
Noel
___
Hi MArkus
On 11/05/11 00:32, Markus Mohrhard wrote:
Hello Noel,
with my last patch I forgot to remove all occurences of
XDatabaseRanges in the vba code. I don't think that there is any use
for XDatabaseRanges in the vba code, because excel only supports one
db data.
Regards,
Markusl
looks
Hi All,
please see https://bugs.freedesktop.org/show_bug.cgi?id=37103
and if someone could review and cherry-pick the patch
http://cgit.freedesktop.org/libreoffice/libs-core/commit/?id=17e8ee1d7b9b4464af73657679df7b0bbdffa028
from master, that would be great
thanks,
Noel
Hi,
Please have a find a fix for
https://bugs.freedesktop.org/show_bug.cgi?id=35139 here
https://bugs.freedesktop.org/attachment.cgi?id=46611 I'd like to apply
that to libreoffice 3.4
thanks
Noel
___
LibreOffice mailing list
I mentioned the wrong bug, the patch fixes the above
On 11/05/11 21:46, Noel Power wrote:
Hi,
Please have a find a fix for
https://bugs.freedesktop.org/show_bug.cgi?id=35139 here
https://bugs.freedesktop.org/attachment.cgi?id=46611 I'd like to
apply that to libreoffice 3.4
thanks
Noel
please see updated patch
Noel
diff --git scripting/util/provider/beanshell/makefile.mk scripting/util/provider/beanshell/makefile.mk
index cbb0c40..1f70fcb 100755
--- scripting/util/provider/beanshell/makefile.mk
+++ scripting/util/provider/beanshell/makefile.mk
@@ -36,6 +36,7 @@
Hi,
can someone please review ( and cherrypick ) to libreoffice3.4 the
following patch
http://cgit.freedesktop.org/libreoffice/libs-core/commit/?id=ea29c4f0d289890fcdb2f12380aa1ccf3d1028c9
from master
thanks,
Noel
___
LibreOffice mailing list
Hi David,
It seems that
http://cgit.freedesktop.org/libreoffice/libs-gui/commit/?id=f9496177a4c942f2acc39a978a3cd65689f14d8d
is causing some problems with component registration with at least basic
on master. I have a temporary fix for this here
Hi,
following patch fixes regressions reported in
https://bugs.freedesktop.org/show_bug.cgi?id=37211
https://bugs.freedesktop.org/show_bug.cgi?id=37170
https://bugs.freedesktop.org/attachment.cgi?id=46831
it would be great to get the 1 review for libreoffice-3-4 ( not
critical so no
On 17/05/11 20:13, Clio wrote:
17.05.2011 12:47, Noel Power пишет:
( not critical
so no point pushing for the release branch I think )
If it is not fixed in 3.4.0, you can't Select All neither with the menu
Select All from the menu has been broken forever, see
http://openoffice.org/bugzilla
On 17/05/11 17:04, Kohei Yoshida wrote:
Hi there,
The attached patch fixes the crasher reported in the following bug:
https://bugs.freedesktop.org/show_bug.cgi?id=37226
and also several other usage of standard algorithms which I believe is
incorrect, since the existing code passes the result
marking as pushed
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
On 18/05/11 15:45, Kohei Yoshida wrote:
I accidentally pushed mine to the -3-4
branch already when I signed off and pushed Rafael's patch (since it was
already committed locally and pushing Rafael's also pushed mine with
it).;-)
So, let me just use that as my excuse for picking my version this
Hi
I have a fix for https://bugs.freedesktop.org/show_bug.cgi?id=36552
I'd like to get it into the 3.4 branch if
possiblehttp://cgit.freedesktop.org/libreoffice/writer/commit/?id=8f1fe65d4fab09515b0b67319fef67c88533b2e0
thanks,
Noel
___
On 18/05/11 16:48, Cedric Bosdonnat wrote:
Hi Noel,
The patch looks good to me. Still two other reviews to get it in 3.4.0
thanks, pushed to the libreoffice3-4 branch, of course if I get 2 more
acks I'll push it to the 3.4.0 branch
Noel
___
Hi Cedric
On 18/05/11 17:09, Cedric Bosdonnat wrote:
Hi all,
Could you review the attached patch (sign it off, and so on)? It fixes a
crash when reading some malformed ODT files. It would be great to have
that one in 3.4.
looks fine to me, you got 1 signoff
Noel
On 18/05/11 17:05, Noel Power wrote:
On 18/05/11 16:48, Cedric Bosdonnat wrote:
Hi Noel,
The patch looks good to me. Still two other reviews to get it in 3.4.0
thanks, pushed to the libreoffice3-4 branch, of course if I get 2 more
acks I'll push it to the 3.4.0 branch
pushed now
Hi
Please review this fix for a regression from 3.3.2,
patch is here ( ripe for picking )
http://cgit.freedesktop.org/libreoffice/filters/commit/?id=ac80fce47404c0843c372336ab700d62297f1647
on master, would be great to get into libreoffice3-4 branch at least
thanks,
Noel
On 19/05/11 17:01, Michael Meeks wrote:
On Thu, 2011-05-19 at 16:14 +0100, Noel Power wrote:
http://cgit.freedesktop.org/libreoffice/filters/commit/?id=ac80fce47404c0843c372336ab700d62297f1647
You have my +1 - and I've cherry-picked it to 3-4.
Thanks,
Michael
On 19/05/11 16:54, Michael Meeks wrote:
To avoid a NULL pointer de-reference, don't de-reference a null
pointer :-) I'd like to get this into 3.4.0
Thanks,
Michael.
looks sane to me +1
___
LibreOffice mailing list
On 20/05/11 10:02, Michael Meeks wrote:
Weelll ... it seems that (for all its ugliness) the more common way of
doing this inside button.cxx's draw code (cf. ImplDrawPushButtonFrame)
seems to be this:
diff --git a/vcl/source/control/button.cxx b/vcl/source/control/button.cxx
index
On 20/05/11 10:43, Noel Power wrote:
On 20/05/11 10:02, Michael Meeks wrote:
I prefer Michael's version, so +1 for that ( although I don't agree
with the ugly comment, to me it shows the intentional bypassing of the
dynamic binding )
___
I committed that version to 3.4 branch, I'm
On 20/05/11 08:27, Cedric Bosdonnat wrote:
Hi all,
Sorry, I couldn't join yesterday. I'm just wondering where the
reviewboard action item went? is that a dropped idea or does it still
deserves some action?
I meant to say something when this was originally floated but got
distracted. I think
On 20/05/11 15:53, Clio wrote:
Please, see here, that the patch actually added 1 line:
On 20/05/11 12:53, Norbert Thiebaud wrote:
I do agree. but then it should be possible to use a nice review-tools
and still have the generated review comment posted in the the ML
I mean, when someone add a patch to be review in the tool that can
generate a post to the ML with the patch (either
Hi
Please review this fix
https://bugs.freedesktop.org/attachment.cgi?id=47096 for
https://bugs.freedesktop.org/show_bug.cgi?id=37370.It would have been
great to get this into rc2 ( unfortunately I wasn't quick enough ) as
this is an extremely annoying bug and makes identifying problems with
On 24/05/11 11:36, Michael Meeks wrote:
Looks odd to me - this was not necessary in the past (at least
comparing with -3-3 and so on) - I suspect there is a deeper and more
interesting problem we're just band-aiding.
yes, resources from basic.srs were merged previously into ofa[en].res
On 24/05/11 21:03, Kohei Yoshida wrote:
The attached patch fixes the crasher reported in
https://bugs.freedesktop.org/show_bug.cgi?id=37520
The crash occurs in ScRangeList::Join() where the array size is cached
prior to the for loop, but array may shrink during the loop, in which
case an
On 26/05/11 21:09, Rafael Dominguez wrote:
Fix possible oob when trying to erase an element. Please review and
signoff for merging into 3.4.1
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
On 27/05/11 10:29, Noel Power wrote:
really mark as pushed
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
On 26/05/11 23:38, Luke Petrolekas wrote:
License LGPLv3+/MPL
More dead code.
Luke
Thank you for the nice patch, committed to master
Noel
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
On 26/05/11 23:48, Luke Petrolekas wrote:
No, this is not more dead code this time :). I noticed this and I'm
pretty confident the code is sloppy. It's my first time deliberately
touching the code, so sorry if it's a bit small.
nope, don't be sorry, useful cleanup, thanks again
Noel
On 26/05/11 23:59, Luke Petrolekas wrote:
License LGPLv3+/MPL
thanks again,
Noel
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
I'd like to get the following patch into 3.4 so 1 review needed
bug: https://bugs.freedesktop.org/show_bug.cgi?id=37590
patch:
http://cgit.freedesktop.org/libreoffice/libs-core/commit/?id=ecbd796ee8157047b1738ac12c98a6ef4d3c18ff
hanks,
Noel
___
On 28/05/11 19:40, Rob Snelders wrote:
Hi,
Here is a really small patch to solve fdo#34872.
This patch is submitted under LGPLv3+/MPL-Licence.
looks good ( I suppose some risk that this might have some side affects
for other fields that use this Expression field type, but ok, master is
the
On 29/05/11 05:23, Korrawit Pruegsanusak wrote:
Hello all,
The attached patch is to cleanup the code in calc.
Please feel free to comment.
thanks for the patch, nice job, pushed to master now
regards,
Noel
___
LibreOffice mailing list
On 29/05/11 05:42, Korrawit Pruegsanusak wrote:
Hello all,
The attached patch is to remove warning about inefficient checking
for emptiness from cppcheck.
thanks again for the nice patch,
pushed to master
Noel
___
LibreOffice mailing list
On 30/05/11 11:55, Noel Power wrote:
On 28/05/11 19:40, Rob Snelders wrote:
Hi,
Here is a really small patch to solve fdo#34872.
This patch is submitted under LGPLv3+/MPL-Licence.
looks good ( I suppose some risk that this might have some side
affects for other fields that use
On 28/05/11 19:47, Korrawit Pruegsanusak wrote:
Hello all,
Although the diff may look frustrated, I've explained what I've done
in log message.
Please feel free to comment :-)
Nice patch, thanks again, I took the comment 'Clean background first
because of plugins. ' from Christina, not sure if
On 30/05/11 13:35, Katarina Machalkova wrote:
Hey there,
can some1 please review cherry-pick for 3.4 the following patch:
http://cgit.freedesktop.org/libreoffice/filters/commit/?id=6603c30f910b1fb5674a28988304dfcd14c11ecb
Seems that it somehow fell through the cracks and never made it to 3.4
On 27/05/11 14:17, Noel Power wrote:
I'd like to get the following patch into 3.4 so 1 review needed
bug: https://bugs.freedesktop.org/show_bug.cgi?id=37590
patch:
http://cgit.freedesktop.org/libreoffice/libs-core/commit/?id=ecbd796ee8157047b1738ac12c98a6ef4d3c18ff
Petr and I chatted briefly
Hi
On 30/05/11 15:39, Takeshi Abe wrote:
Hi all,
(thanks to Noel, for helpful comments on its initial version and
suggesting to post to this list).
ahem, I seem to have gotten the wrong end of the stick about some of the
patch ( or at least looking at it again I see that )
It seems to work
On 31/05/11 01:41, Takeshi Abe wrote:
Hi Noel,
[...]
Well the change against common_brand.scp is surrounded with #ifdef, so will not
affect to WNT nor to MACOSX. Or am I misunderstanding something?
yes that's what I said ( probably not clearly enough ) e.g. I realised
that the config changed
On 30/05/11 18:18, Korrawit Pruegsanusak wrote:
Hello all,
Attached patch is a bit more code cleanup in filters.
Please feel free to comment.
Anyway, I've found some comments are unreadable, eg. in
/hwpfilter/source/hwpreader.cxx line ~4440. Should we also remove
them? or are they my encoding
On 31/05/11 10:06, Michael Meeks wrote:
Hi Noel,
On Mon, 2011-05-30 at 20:40 +0100, Noel Power wrote:
Petr and I chatted briefly on IRC, as he rightly pointed out most
likely the intended change would be
https://bugs.freedesktop.org/attachment.cgi?id=47337
as per the ack, pushed to 3.4
On 31/05/11 09:25, Noel Power wrote:
On 31/05/11 01:41, Takeshi Abe wrote:
Hi Noel,
[...]
Well the change against common_brand.scp is surrounded with #ifdef,
so will not
affect to WNT nor to MACOSX. Or am I misunderstanding something?
yes that's what I said ( probably not clearly enough
On 31/05/11 13:03, Chr. Rossmanith wrote:
Hi,
more duplicate code cleanup.
Class SfxObjectShell has two nearly identical methods: ImportFrom and
InsertFrom. The latter has a few lines of code more, so I've removed
InsertFrom (which was added to the code base later than ImportFrom),
added a
On 31/05/11 18:03, André Schnabel wrote:
Hi,
we came across a minor accessability issue at the German discuss list.
But the fix is so easy that even I could do it.
It's just to remove one line that breaks the keyboard navigation in
the options dialog and has no sense at all. Christoph Noack
On 01/06/11 06:34, jeffrey chang wrote:
Sorry here is the patch.
On Wed, Jun 1, 2011 at 1:18 PM, jeffrey chang jeffdch...@gmail.com
mailto:jeffdch...@gmail.com wrote:
Hi,
I am new to the LibreOffice community. I know that 34786 has been
posted for awhile, but no one seems to
On 01/06/11 12:05, Noel Power wrote:
On 01/06/11 06:34, jeffrey chang wrote:
[...]
Sorry here is the patch.k, patch looks fine to me and works as
expected, pushed to 3.4 branch. look forward to your next patch
thanks alot
oh and can you please confirm the patch is contributed under LGPLv3
On 08/06/11 13:55, Takeshi Abe wrote:
OK, so do you mean libs-core/desktop/source/migration?, which functionality
I have not yet recognized clearly.
It would be great if anyone familiar with the code suggests a starting
point to dig into.
I *think* this ( see attached patch ) will fix it, not
On 08/06/11 14:19, Noel Power wrote:
On 08/06/11 13:55, Takeshi Abe wrote:
OK, so do you mean libs-core/desktop/source/migration?, which
functionality
I have not yet recognized clearly.
It would be great if anyone familiar with the code suggests a starting
point to dig into.
I *think
Hi Petr
On 09/06/11 18:41, Petr Mladek wrote:
Noel Power píše v Čt 09. 06. 2011 v 16:11 +0100:
Hi Petr
On 09/06/11 13:46, Petr Mladek wrote:
Noel Power píše v St 08. 06. 2011 v 17:36 +0100:
[...]
Hmm, I am not sure if we want to hardcode /.config. If I understand
Hmm, do we really want
On 10/06/11 13:15, Petr Mladek wrote:
OK, you convinced me. I think that you should commit the two patches and
be done with it for now:-)
finally did it ( I nearly completely forgot to get back to this )
thanks again for reviewing that
regards
Noel
Hi Anurag
On 19/06/11 10:10, Anurag Jain wrote:
Hello Kohei, Noel
This is the brief of my work for this week. As I was supposed to
create a new container class which will contain ScTextWnd obejct +
ScrollBar + Button object, I've done so. Also I've tunneled the calls
to ScTextWnd from
On 21/06/11 09:08, Petr Mladek wrote:
Michael Meeks píše v Po 20. 06. 2011 v 21:06 +0100:
On Mon, 2011-06-20 at 20:25 +0100, Michael Meeks wrote:
The rest of that method seems to assume in several places that
pActiveViewSh can be NULL and checks for that:
Markus is committing
On 20/06/11 10:18, Noel Power wrote:
hmm, I just built your feature branch on Friday and tried to get my
head around the task ( and it is still a little unfamiliar to me ), I
am sure though I could help though with your latest problem when I
have a patch with your latest work :-)
I hope you
Hi
On 21/06/11 14:34, Andor E wrote:
Hi,
I'm building my own version of OOo 3.2.1 and I'm wondering what the
--disable-vba switch is disabling in detail.
disables build of the vba compatibility api shared library ( but not
iirc the idl type libraries )
The Basic function
CreateObject no
On 21/06/11 15:17, Markus Mohrhard wrote:
Hello Noel, all,
I have attached a test document and a diff. I don't understand why
this still crashs calc even if there is nothing anymore that can
create any problems.
well it doesn't crash for me ( even worse it doesn't crash without the
patch
Hi Anurag
On 21/06/11 18:59, Anurag Jain wrote:
Hi Noel,
Please review the patch I'm sending here. I did not have luck getting
the control shown up. Please guide me what I'm missing ?
Thanks and regards
Sorry I think you need to redo the patch, it doesn't apply for me ( or
at least the hunks
On 21/06/11 18:52, Markus Mohrhard wrote:
I did a debug build. And I had some stl debug symbols in my backtrace
so it might be that perhaps the compiler won't optimize this out.
I attached the backtrace.
print it shows: it = {__gnu_debug::_Safe_iterator_base =
{_M_sequence = 0x29e3678,
Hi Anurag
On 22/06/11 05:20, Anurag Jain wrote:
Hi Noel,
Actually the problem started from not doing a git pull on my end after
Kohei pushing my patch (created using git diff) as I went on making
changes. In order to resolve this I ran git stash; git pull; and then
git stash pop; And I made
On 22/06/11 10:19, Noel Power wrote:
still I see with the debug build that I did that I can't reproduce
this, seems that for me _GLIBCXX_DEBUG isn't set. Just from my future
reference what did you pass to configure ? ( I just passed the
--enable-debug )
sigh seems I did something wrong here
On 22/06/11 10:23, Noel Power wrote:
On 22/06/11 10:19, Noel Power wrote:
still I see with the debug build that I did that I can't reproduce
this, seems that for me _GLIBCXX_DEBUG isn't set. Just from my future
reference what did you pass to configure ? ( I just passed the
--enable-debug
On 22/06/11 11:03, Caolán McNamara wrote:
On Tue, 2011-06-21 at 17:43 +0100, Noel Power wrote:
well it doesn't crash for me ( even worse it doesn't crash without the
patch either ) and even worse still valgrind doesn't even complain.
When you valgrind manually you definitely do
export G_SLICE
On 23/06/11 13:42, Markus Mohrhard wrote:
http://cgit.freedesktop.org/libreoffice/calc/commit/?id=4068aa5fac1c3e6f4baac44b7ed5e3793a6b8fd1
[...]
Markus
looks good to me, please commit to master, let me know the commit
id and I will cherrypick/signoff for 3.4
thanks again
Please review
http://cgit.freedesktop.org/libreoffice/calc/commit/?id=89462758bfcaaec34c508f2afe08eacb759c7093
would like to include in 3.4 ( and additionally whatever current 3.4.x
branch )
thanks,
Noel
___
LibreOffice mailing list
Hi Anurag
On 22/06/11 15:51, Anurag Jain wrote:
Hi Noel,
Resending the patch again along with the source files here.
as mentioned on Wed on iRC I pushed the patch to the feature branch. I
had hoped to see the latest changes you made to correct the control size
problem that I identified that
Hi Anurag
On 26/06/11 18:23, Anurag Jain wrote:
Hello Noel,
On Fri, Jun 24, 2011 at 7:53 PM, Noel Powernopo...@novell.com wrote:
[...]
I'm sending the fix patch here which calculates the height and width
of the ScInputbarGroup and makes the border invisible.
great, thanks for that, more
On 27/06/11 09:24, Anurag Jain wrote:
Hello Noel,
Here I got some chance to play with MS Excel 2010 and I analyzed the
behavior of inputbar. I'm sending an image here showing the desire
behavior.
The first figure in the image shows the normal behavior showing only a
single line and keep on
On 27/06/11 12:14, Noel Power wrote:
so I would not get overly hung up by this, we don't have to have
exactly the same arrangement, I think a workable and useful first cut
is as Kohei and I mentioned already
oh and before I forget, I wouldn't even think about resizing by dragging
Hi Anurag,
As discussed on IRC I had hoped to see the patch you promised to send.
The one that rename's your class, restores ScTextWnd and removes the
unnecessary changes and does some cleanup of the existing code, is there
some problem? everything ok? I need those changes to integrate your
On 04/07/11 11:29, Anurag Jain wrote:
Hello Noel,
I'm sending the inputwin.cxx with the changes I've made in
ScInputBargroup. Do not push it as of now. I'd be making some more
changes as mentioned in above mail before it can be pushed.
I guess it really isn't usable without a header file :-( I
On 05/07/11 03:52, Anurag Jain wrote:
Hello Noel,
As you asked I'm sending a patch here with most of the changes
incorporated. I've done total rework again and made a bit more
modular, removed unnecessary things and now it look way better than
what i was getting yesterday. Please have a look
On 05/07/11 03:52, Anurag Jain wrote:
As of now there are might be some printf's lying around so ignore them
as of now.
Awaiting your feedback on this.
Ok, here goes
1) ScInputBarGroup::ScInputBarGroup()
In the initialization list,
bIsMultiLine( this ) is wrong surely, bIsMultiLine is of
On 13/07/11 18:24, Jan Holesovsky wrote:
Hi Michael,
Michael Meeks píše v St 13. 07. 2011 v 11:00 +0100:
A very trivial no-brainer; review/cherry-picking much appreciated.
Reviewed, pushed to libreoffice-3-4, thank you! :-)
2 more reviews needed for 3.4.2...
given the difficulty I
On 13/07/11 19:26, Jan Holesovsky wrote:
Hi,
https://bugs.freedesktop.org/show_bug.cgi?id=36816
The attached patch fixes that - in the original code we were
incrementing the number of paragraphs as the first thing, so I have just
moved the ++rStart.nPara to the original location.
Would be
Hi there,
Be aware that in master regarding the import of controls ( ole/ocx
controls and userform controls ) , please be on the look out for any
regressions in this area and let me know. Note: the import of older form
controls is still handled in the escher import in filters, the hasn't
On 15/07/11 08:27, Tor Lillqvist wrote:
Review, sign-off etc appreciated.
/me raises hand. One more needed for the 3-4-2 branch.
--tml
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
On 14/07/11 23:42, Kohei Yoshida wrote:
Hi there,
I would like to commit the attached change to the -3-4 branch and
hopefully to the 3-4-2 branch as well.
This fixes
https://bugs.freedesktop.org/show_bug.cgi?id=37767
The refresh of data pilot table (or pivot table) was broken from the
UNO
Hi Caolán
could you have a look at this patch
http://cgit.freedesktop.org/libreoffice/writer/commit/?id=95351a519bec2833f5d936c20e3916a4e283b0f6
This should be a nice stroll down memory lane for you as it seems
related to http://openoffice.org/bugzilla/show_bug.cgi?id=1291, yes
issue #1291
On 18/07/11 10:41, Caolán McNamara wrote:
On Fri, 2011-07-15 at 16:35 +0100, Noel Power wrote:
Hi Caolán
could you have a look at this patch
http://cgit.freedesktop.org/libreoffice/writer/commit/?id=95351a519bec2833f5d936c20e3916a4e283b0f6
This should be a nice stroll down memory lane for you
On 26/07/11 23:31, Jan Holesovsky wrote:
Hi,
https://bugs.freedesktop.org/show_bug.cgi?id=33593
The fix for that was provided in CWS dr78 which is integrated in
LibreOffice, but apparently got lost during a merge - I did not
investigate more if it happened already in Mercurial (when the CWS
I would really like to get this patch into 3.4, the patch affects vba
related calls only and imo safe. Basically the patch allows copy to work
for appropriate multi-area ranges. The core calc function 'CopyToClip'
variant that is modified is used *only* by vba api implementation code
so
Hi Kohei,
On 27/07/11 19:23, Kohei Yoshida wrote:
Hi Noel,
On Wed, 2011-07-27 at 11:50 +0100, Noel Power wrote:
I would really like to get this patch into 3.4,
[...]
Hmm... did you forget to attach your patch by any chance?
yes, ouch I did forget :-) ( although it is attached to the bug
On 29/07/11 10:40, Caolán McNamara wrote:
On Thu, 2011-07-28 at 12:48 -0400, Kohei Yoshida wrote:
Ok. So, I did verify that that particular ScViewFunc::CopyToClip()
method
Maybe unrelated but I saw the word Clip and I see that the three
argument
void
On 29/07/11 11:49, Caolán McNamara wrote:
On Fri, 2011-07-29 at 11:36 +0100, Noel Power wrote:
On 29/07/11 10:40, Caolán McNamara wrote:
Are you sure? on master ScDocument::CopyRangeNamesToClip(ScDocument*
pClipDoc, const ScRange rClipRange, SCTAB nTab) was changed to
ScDocument
On 29/07/11 11:49, Caolán McNamara wrote:
http://cgit.freedesktop.org/libreoffice/calc/commit/?id=38cae5f0a09508f48825a7049cb1508b0251fbf0
is apparently the commit that removed the last use of the three argument
CopyRangeNamesToClip variant.
C.
And needless to say that this really is a valid
Hi Kohei
On 29/07/11 15:59, Kohei Yoshida wrote:
after applying your patch, because, before your change, FillScRange was
called first *then* xModel was assigned an instance, but you got them
flipped in your new code.
aha gottcha
This may not affect anything but I've seen in the past a
Hi Miklos
On 01/08/11 19:26, Miklos Vajna wrote:
Hello Noel,
I recently tested the copypaste export (using RTF) on master and got a
crash. The attached patch solves the issue here.
OK to push, or you want to add a check in the called SwMSConvertControls
constructor?
actually I am not at all
Hi Kohei
On 29/07/11 17:01, Kohei Yoshida wrote:
On Fri, 2011-07-29 at 16:48 +0100, Noel Power wrote:
perfect sense. In this case, I don't see it will make any difference, so
you can change the order to the way it was or not as you wish ( I have
no preference )
Ok. Pushed to -3-4
401 - 500 of 1331 matches
Mail list logo
