Re: Improve versioning algorithm description

2009-09-22 Thread Charles Wilson
Bob Friesenhahn wrote: On Wed, 23 Sep 2009, Ralf Wildenhues wrote: The most important question is whether it is correct, not only for Linux. That's what I'm not yet certain about. Something tells me that it is not correct for Windows. Ralf's description is correct also for Windows.

Re: bindir for libtool

2009-08-28 Thread Charles Wilson
be better if the testcase were implemented as part of the automated testsuite, rather than as a standalone test. However, I understand wanting to get some feedback on the code, before spending more time integrating the test. Charles Wilson in mails threads add a note that for GNU Coding Standard

Re: [PATCH, take 4][cygwin|mingw] Control where win32 DLLs get installed.

2009-08-18 Thread Charles Wilson
Roumen Petrov wrote: I'm concerned that we can't implement a working portable(cross-platform) relative path calculation. In the general case, Roumen, you are correct: there IS no portable mechanism to compute relative paths when non-portable constructs such as symbolic links are/may-be

Re: [PATCH, take 4][cygwin|mingw] Control where win32 DLLs get installed.

2009-08-16 Thread Charles Wilson
Roumen Petrov wrote: Dave Korn wrote: Roumen Petrov wrote: I think that processing of '..' in a path is too naive. It will fail to produce correct results on filesystems with links. As I explained to Eric, this function implements 'abspath', not 'realpath', and given that we can't assume

Re: [PATCH+Assign request][cygwin|mingw] Control where win32 DLLs get installed.

2009-08-10 Thread Charles Wilson
Dave Korn wrote: [ Please Cc me on replies, I'm not subbed up to list. ] Windows DLLs, unlike Linux DSOs, have to live in the bin directory (or elsewhere on $PATH), not the lib dir. Libtool handles this at --link time by setting the dlname in the generated .la file to a relative path

Re: [PATCH+Assign request][cygwin|mingw] Control where win32 DLLs get installed.

2009-08-10 Thread Charles Wilson
Dave Korn wrote: Well, I did really want to make it a test of nothing other than the -bindir functionality, in fact it's more or less just a test of the corner cases for func_relative_path! Using -rpath seems to work as far as supplying an input value for $install_libdir and that's all I

[PATCH] Add --lt-* options to shell wrapper

2009-07-12 Thread Charles Wilson
* libltdl/config/ltmain.m4sh (func_emit_wrapper) [func_parse_lt_options]: New function. [func_opts_contain_lt]: New function. [func_lt_dump_args]: New function. [func_exec_program_core]: New function, refactored from [main]. [func_exec_program]: New function. [main]: Call func_parse_lt_options

[PATCH] Document wrapper changes.

2009-07-12 Thread Charles Wilson
* NEWS: Indicate new feature and incompatibility. * doc/libtool.texi [Linking executables]: Mention wrapper executables, in addition to wrapper scripts. Add menu referencing subsection 'Wrapper executables for programs'. [Wrapper executables for programs]: New subsection. Documents cwrapper

Re: [PATCH] Enable runtime cwrapper debugging; add tests

2009-07-12 Thread Charles Wilson
Charles Wilson wrote: I'll follow up this patch with another to add support for --lt-debug --lt-dump-script to the shell wrapper. --lt-debug will do very little other than $ECHO the full path to the program executable and its arguments. --lt-dump-script will simply { cat $0 exit 0

Re: [PATCH] Document and test LT_DEBUGWRAPPER cwrapper macro

2009-07-12 Thread Charles Wilson
End thread. This patch has been obsoleted by: 1. Remove unneeded functions and options from cwrapper committed: 75765d58c38c55ef069ef100732c1e978f4151a6 2. [PATCH] Enable runtime cwrapper debugging; add tests http://lists.gnu.org/archive/html/libtool-patches/2009-06/msg00039.html pending... 3.

Re: [PATCH] [cygwin|mingw] fix dlpreopen with --disable-static take 6

2009-07-12 Thread Charles Wilson
Charles Wilson wrote: * libltdl/config/general.m4sh: Update copyright year. (func_tr_sh): New function. * libltdl/config/ltmain.m4sh (func_generate_dlsyms) [cygwin|mingw]: Obtain DLL name corresponding to import library by using value stored in unique variable libfile_$(transliterated implib

Re: [PATCH] [cygwin|mingw] Create UAC manifest files.

2009-07-01 Thread Charles Wilson
Ralf Wildenhues wrote: But IANAL, so... Me neither. I'm not making up these rules either, so please discuss them with the FSF if you have an issue with them. Nope, no issue. I didn't realize the FSF treated patches cumulatively. You're right, Yaakov has submitted a number of these small

Re: [PATCH] [CXX] Use correct export_dynamic_flag_spec for PE-COFF $hosts

2009-07-01 Thread Charles Wilson
Ralf Wildenhues wrote: * Charles Wilson wrote on Wed, Jul 01, 2009 at 06:48:52AM CEST: but as far as I can tell we don't actually have separate cases for those other languages' linker requirements at present. There's just C++, and everything else: Yes. What I am asking is do

[PATCH] [CXX] Use correct export_dynamic_flag_spec for PE-COFF $hosts

2009-06-30 Thread Charles Wilson
* libltdl/m4/libtool.m4 (_LT_LANG_CXX_CONFIG) [cygwin*|mingw*|pw32*|cegcc*]: Define export_dynamic_flag_spec as -Wl,--export-all-symbols here as well (see commit 5f2bbb494a2753afb2878c399cfd8316b7403a5b). Signed-off-by: Charles Wilson ... --- Originally posted by Yaakov Selkowitz on the cygwin

Re: [PATCH] [cygwin|mingw] Create UAC manifest files.

2009-06-30 Thread Charles Wilson
Eric Blake wrote: Do we need to worry about deleting *.manifest files at the appropriate 'make *clean' level? Hmm. Yes, the one in the build directory (for the wrapper, or the real exe if building without dependencies on uninstalled DLLs) probably should be. The one in .libs/ not so much,

Re: [PATCH] [CXX] Use correct export_dynamic_flag_spec for PE-COFF $hosts

2009-06-30 Thread Charles Wilson
Ralf Wildenhues wrote: Yes but can you please check that you don't need to add another 3 patches for F77, FC, GCJ? Well, the whole tag-based mechanism in libtool makes my teeth ache, but as far as I can tell we don't actually have separate cases for those other languages' linker requirements at

Re: [PATCH] [mingw] Improve sys_lib_search_path_spec detection.

2009-06-29 Thread Charles Wilson
Bob Friesenhahn wrote: On Mon, 29 Jun 2009, Charles Wilson wrote: OK to push? This patch seems like it offers considerable improvement. Please push it. Thanks, pushed. -- Chuck

[PATCH] Finish adding alias for obsoleted AC_LIBTOOL_RC macro.

2009-06-28 Thread Charles Wilson
|1 - 3 files changed, 9 insertions(+), 1 deletions(-) diff --git a/ChangeLog b/ChangeLog index e5b40ca..2b7ba3e 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,11 @@ +2009-06-28 Charles Wilson libt...@cwilson.fastmail.fm + + Finish adding alias for obsoleted AC_LIBTOOL_RC macro

[PATCH] [mingw] Improve sys_lib_search_path_spec detection.

2009-06-28 Thread Charles Wilson
* libltdl/m4/libtool.m4 (_LT_SYS_DYNAMIC_LINKER): Fix handling of dos-style paths when parsing $CC -print-search-dirs output. --- It appears that this particular behavior has been broken for quite some time. Currently, libtool mangles $CC -print-search-dirs badly on mingw:

Re: [PATCH] [mingw] Improve sys_lib_search_path_spec detection.

2009-06-28 Thread Charles Wilson
Charles Wilson wrote: * libltdl/m4/libtool.m4 (_LT_SYS_DYNAMIC_LINKER): Fix handling of dos-style paths when parsing $CC -print-search-dirs output. --- Currently running regression tests on MSYS-1.0.12 + mingw-4.4.0-dw2 (TDM version). OK to push, if no regressions from earlier behavior

Re: [PATCH] [mingw] Improve sys_lib_search_path_spec detection.

2009-06-28 Thread Charles Wilson
Vincent Torri wrote: On MSYS-1.0.12 with gcc-4.4.0dw2 (TDM): 1.0.12 ?? There is only 1.0.11 RC (on the mingw.org wiki) afaik. Where did you get that version ? You're right. It's 1.0.11 and 1.0.10, not 1.0.12 and 1.0.11. Sorry, it's late. -- Chuck

Re: [PATCH] Add alias for obsoleted AC_LIBTOOL_RC macro.

2009-06-27 Thread Charles Wilson
Ralf Wildenhues wrote: * Charles Wilson wrote on Wed, Jun 24, 2009 at 02:32:16AM CEST: * libltdl/m4/libtool.m4: Add alias for obsoleted macro AC_LIBTOOL_RC. OK, Pushed. but *really*, the project thould move to Libtool 2.2.x. Push them, please. OK, with or without an additional change

Re: [PATCH] Enable runtime cwrapper debugging; add tests

2009-06-27 Thread Charles Wilson
Charles Wilson wrote: * libltdl/config/ltmain.m4sh (func_emit_cwrapperexe_src) [ltwrapper_debugprintf]: Renamed to... [lt_debugprintf]: this. Only print messages if lt_debug != 0. [file scope]: Add constants and variables to support new --lt-debug option. Remove LTWRAPPER_DEBUGPRINTF macro

[PATCH] Add alias for obsoleted AC_LIBTOOL_RC macro.

2009-06-26 Thread Charles Wilson
* libltdl/m4/libtool.m4: Add alias for obsoleted macro AC_LIBTOOL_RC. --- Seems obvious to me, unless this bit m4_ifndef([AC_LIBTOOL_RC], [AC_DEFUN([AC_LIBTOOL_RC])]) should be removed from lt~obsolete.m4. As it is, the following configure.ac is just non-functional: ... AC_LIBTOOL_WIN32_DLL

Re: [PATCH] Remove unneeded functions and options from cwrapper

2009-06-22 Thread Charles Wilson
Ralf Wildenhues wrote: * Charles Wilson wrote on Mon, Jun 22, 2009 at 02:07:13AM CEST: Ok to push? OK, thanks. Pushed. -- Chuck

Re: [PATCH] Document and test LT_DEBUGWRAPPER cwrapper macro

2009-06-22 Thread Charles Wilson
Ralf Wildenhues wrote: * Charles Wilson wrote on Sun, Jun 21, 2009 at 08:25:00PM CEST: (the shwrapper in .libs/ is intended to be ephemeral, and as an implementation detail may be deleted after the link is completed.) Why is it intended to be ephemeral? What do we gain from removing

Re: [PATCH] Document and test LT_DEBUGWRAPPER cwrapper macro

2009-06-21 Thread Charles Wilson
Ralf Wildenhues wrote: * Charles Wilson wrote on Fri, Jun 19, 2009 at 07:55:03PM CEST: Now there has been some reluctance about this patch in the past; presumably worry about documenting the --lt- options somehow cements them as an API that must be forever supported Yes, this is a problem

[PATCH] Remove unneeded functions and options from cwrapper

2009-06-21 Thread Charles Wilson
* libltdl/config/ltmain.m4sh (func_emit_cwrapperexe_src) [lt_opt_process_env_set]: Remove. [lt_opt_process_env_prepend]: Remove. [lt_opt_process_env_append]: Remove. [lt_split_name_value]: Remove. [file scope]: Don't declare removed functions. Remove constants and defines related to eliminated

Re: [PATCH] Ensure LT_PATH_LD works when called before LT_INIT

2009-06-20 Thread Charles Wilson
Ralf Wildenhues wrote: * Charles Wilson wrote on Fri, Jun 19, 2009 at 07:33:22PM CEST: * libltdl/m4/libtool.m4 (LT_PATH_LD): AC_REQUIRE _LT_PROG_ECHO_BACKSLASH. Original patch by Yaakov Selkowitz. As he explained: This patch seems like an obvious fix to me. Ok to push? Yes, thank you

Re: [PATCH] Ensure LT_PATH_LD works when called before LT_INIT

2009-06-20 Thread Charles Wilson
Charles Wilson wrote: In my repo, he is already listed as the author (I'm listed as --signed-off). I didn't have the (tiny change) notation tho. I'll add that before pushing. Pushed. -- Chuck

[PATCH] [cygwin|mingw] fix dlpreopen with --disable-static take 6

2009-06-19 Thread Charles Wilson
* libltdl/config/general.m4sh: Update copyright year. (func_tr_sh): New function. * libltdl/config/ltmain.m4sh (func_generate_dlsyms) [cygwin|mingw]: Obtain DLL name corresponding to import library by using value stored in unique variable libfile_$(transliterated implib name). If that fails, use

[PATCH] [cygwin]: Add cross-compile support to cwrapper take 5

2009-06-19 Thread Charles Wilson
* libltdl/config/general.m4sh: Update copyright year. (func_tr_sh): New function. * libltdl/config/ltmain.m4sh (func_generate_dlsyms) [cygwin|mingw]: Obtain DLL name corresponding to import library by using value stored in unique variable libfile_$(transliterated implib name). If that fails, use

Re: [PATCH] [cygwin]: Add cross-compile support to cwrapper take 5

2009-06-19 Thread Charles Wilson
Charles Wilson wrote: ... a long correct message but with the wrong changelog. sorry. Here's the correct changelog. - Refactor cwrapper cross-compile support; Add cygwin. * libltdl/m4/libtool.m4 (_LT_PATH_CONVERSION_FUNCTIONS): New function sets libtool variable $to_host_path_cmd

[PATCH] Improve compatibility with older automake

2009-03-29 Thread Charles Wilson
* libltdl/m4/lt~obsolete.m4: Add AC_DEFUNs for _LT_PREPARE_SED_QUOTE_VARS and _LT_PROG_ECHO_BACKSLASH. Report by Yaakov Selkowitz. aclocal-1.8 and older fail: aclocal: macro `_LT_PREPARE_SED_QUOTE_VARS' required but not defined aclocal: macro `_LT_PROG_ECHO_BACKSLASH' required but not defined

[PATCH] Use correct export_dynamic_flag_spec for PE-COFF $hosts

2009-03-29 Thread Charles Wilson
* libltdl/m4/libtool.m4 (_LT_LINKER_SHLIBS) [cygwin*|mingw*|pw32*|cegcc*]: Define export_dynamic_flag_spec as -Wl,--export-all-symbols, as required by GNU ld for PE-COFF. Original patch by Yaakov Selkowitz. As he explained: On Cygwin, the --export-all-symbols linker flag is required;

[PATCH] [cygwin] Improve operation with gcc4

2009-03-29 Thread Charles Wilson
* libltdl/m4/libtool.m4 (_LT_SYS_DYNAMIC_LINKER) [cygwin*]: Add w32api to sys_lib_search_path_spec without overriding gcc's own search path. Original patch by Yaakov Selkowitz. As he explained: With gcc4 providing shared libs, it should now perfectly legitimate to add any of these libs to the

Re: [PATCH] Use correct export_dynamic_flag_spec for PE-COFF $hosts

2009-03-29 Thread Charles Wilson
--export-all-symbols was part of that addition. I know I updated the (scanty, at the time) documentation for --export-all-symbols in 2001: 2001-08-02 Charles Wilson ... * ld.texinfo: add additional documentation for --export-all-symbols. Document --out-implib, --enable-auto

Re: [PATCH] Improve compatibility with older automake

2009-03-29 Thread Charles Wilson
Bob Friesenhahn wrote: Tested by running aclocal-1.8 successfully, but didn't do a full bootstrap. Still, the fix seems obvious...okay to push? Since the fix seems obvious, please do. Pushed. -- Chuck

Re: FYI: latest official cygwin libtool

2009-02-25 Thread Charles Wilson
Peter Rosin wrote: Den 2009-02-24 04:04 skrev Charles Wilson: 01-fix-dlpreopen-with-disable-static.patch 02-refactor-cwrapper-cross-compile-and-add-cygwin.patch 03-document-and-test-cwrapper-macro.patch 04-pr-dumpbin-link-support.patch 05-pr-lib-prefix-for-archive-name-ltdl.patch 06-pr

FYI: latest official cygwin libtool

2009-02-23 Thread Charles Wilson
as the default if no acceptable candidate is found. * THANKS: Update Reports by Rudolf Leitgeb and Peter Kjellerstedt. 2009-02-17 Charles Wilson ... Document and test LT_DEBUGWRAPPER cwrapper macro * tests/cwrapper.test: Add new test for -DLT_DEBUGWRAPPER

Re: [PATCH] [cygwin|mingw] fix dlpreopen with --disable-static take 4

2009-02-13 Thread Charles Wilson
Charles Wilson wrote: The attached, re-re-re-re-revised patch addresses these two issues, but is otherwise the same as take 4. Ping. Most recent version is the take 5 attachment, in this message from two weeks ago: http://lists.gnu.org/archive/html/libtool-patches/2009-01/msg00232.html

Re: [PATCH] [cygwin]: Add cross-compile support to cwrapper

2009-02-13 Thread Charles Wilson
Charles Wilson wrote: Charles Wilson wrote: How does that sound, as an intermediate plan? Implemented as attached, which should be applied on top of the -take3 patch. Ping? The attached represents the combination of -take3 http://lists.gnu.org/archive/html/libtool-patches/2009-01/msg00233

Re: [PATCH] [cygwin]: Add cross-compile support to cwrapper

2009-01-30 Thread Charles Wilson
Charles Wilson wrote: In fact, maybe I should add $opt_debug to the new func_to_host_path[list] functions... Addressed in the attached revision. cygwin-native testsuite behavior is as expected.q still true. mingw-native (e.g. msys-mingw) testsuite behavior is as expected. still true

Re: [PATCH] Document and test LT_DEBUGWRAPPER cwrapper macro

2009-01-30 Thread Charles Wilson
Charles Wilson wrote: * tests/cwrapper.test: Add new test for -DLT_DEBUGWRAPPER. * doc/libtool.texi [Linking executables]: Mention wrapper executables, in addition to wrapper scripts. Add menu referencing subsection 'Wrapper executables for programs'. [Wrapper executables for programs]: New

Re: Status of the MSYS/MSVC port

2009-01-29 Thread Charles Wilson
Peter Rosin wrote: I have: $ gcc -v Reading specs from C:/MinGW/bin/../lib/gcc/mingw32/3.4.2/specs Configured with: ../gcc/configure --with-gcc --with-gnu-ld --with-gnu-as --host=mingw32 --target=mingw32 --prefix=/mingw --enable-threads --disable-nls

Re: Status of the MSYS/MSVC port

2009-01-29 Thread Charles Wilson
Peter Rosin wrote: Den 2009-01-29 11:49 skrev Charles Wilson: What version of mingw-runtime are you using? (I'm not sure which version I have; its from a bundle I put together about a year ago; I can get to the docu for that bundler later today. It's probably mingw-runtime-3.14). Something

Re: Status of the MSYS/MSVC port

2009-01-29 Thread Charles Wilson
Bob Friesenhahn wrote: My own MinGW install dates from the 2002/2003 time frame. :-) At the time MinGW/MSYS was a simple install. Nowadays it seems to be all jumbled up so I have not tried to cross the hurdle of an update. Yes, the MinGW download site is a disaster, thanks to SF

Re: Status of the MSYS/MSVC port

2009-01-29 Thread Charles Wilson
Roumen Petrov wrote: I think that we has to be careful about structure _stat and version of msvcrt (=8.0) - it depend from definition of time_t 32/64 bit and the size is deferent depending from an another macro. May be wrapper has to include MSVC headers. This is all moot. We (libtool's

Re: Pings

2009-01-29 Thread Charles Wilson
Akim Demaille wrote: Le 29 janv. 09 à 19:22, Ralf Wildenhues a écrit : For this one I'd prefer if Charles and/or Peter took care of it, they have a bunch of changes in this area and some discussion going on. Actually, I'd prefer to just be able to say go! once y'all have agreed on a common

Re: Pings

2009-01-29 Thread Charles Wilson
a bunch of changes in this area and some discussion going on. Actually, I'd prefer to just be able to say go! once y'all have agreed on a common set of changes. :-) My set of changes were already pushed (0aef3579..6631e515) 2009-01-24 Charles Wilson ... [cygwin|mingw] cwrapper cleanups

Re: Status of the MSYS/MSVC port

2009-01-29 Thread Charles Wilson
Ralf Wildenhues wrote: * Peter Rosin wrote on Thu, Jan 29, 2009 at 06:53:48PM CET: But maybe, just maybe, you don't have a desperate need to do -std=c89 -Werror :-) Guys, if all you're working around is -Werror, then stop right now. Just eliminate -Werror from $LTCC $LTCFLAGS and be done

Re: Status of the MSYS/MSVC port

2009-01-28 Thread Charles Wilson
Peter Rosin wrote: Maybe, here are the errors: So, I guess these declarations should do it (untested): int _setmode (int, int); int _spawnv (int, const char *, const char * const *); #ifndef _P_WAIT /* just in case */ # define _P_WAIT0 #endif _P_WAIT is guarded in MSVC's

Re: Status of the MSYS/MSVC port

2009-01-28 Thread Charles Wilson
Roumen Petrov wrote: Peter Rosin wrote: [SNIP] This was all inside #ifdef __MINGW32__, which assumes msvcrt.dll, i.e. compatible with MSVC 6, so we're safe. I think. Famous last words... It seems to me that I misunderstood report failure and the case. It start for ms compiler why #ifdef

Re: [PATCH] [cygwin]: Add cross-compile support to cwrapper

2009-01-27 Thread Charles Wilson
Peter Rosin wrote: First off, your patch works like a charm on MSYS/MSVC, and I generally like it. But a couple of questions are open, when did native MinGW ar enter the picture when $build = cygwin and why is there a problem with leakage of paths from the other environment? I thought the

Re: Status of the MSYS/MSVC port

2009-01-27 Thread Charles Wilson
Peter Rosin wrote: On MSYS/MinGW, stresstest.at now passes when Run tests with low max_cmd_len, that fails on git master. On the other hand, cwrapper for uninstalled executables fails at cwrapper.at:78 (both with and without low max_cmd_len). It's the second time through the loop that fails,

Re: Add lib prefix to library name in the ltdl preloaded symbol lookup

2009-01-26 Thread Charles Wilson
Peter Rosin wrote: This is from need-lib-prefix.at: main.exeS.c when the test is run on the tip of the pr-msvc-support branch. lt__PROGRAM__LTX_preloaded_symbols[] = { { @PROGRAM@, (void *) 0 }, {foo1.lib, (void *) 0}, {libfoo1_LTX_i, (void *) foo1_LTX_i},

[PATCH] Add -Wall to cwrapper tests.

2009-01-24 Thread Charles Wilson
* tests/cwrapper.at: Add -Wall existing tests. Add additional round of tests with -Wall alone. --- Preapproved. As pushed... tests/cwrapper.at |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tests/cwrapper.at b/tests/cwrapper.at index 30e591e..ce4572e 100644 ---

[PATCH] Document and test LT_DEBUGWRAPPER cwrapper macro

2009-01-24 Thread Charles Wilson
* tests/cwrapper.test: Add new test for -DLT_DEBUGWRAPPER. * doc/libtool.texi [Linking executables]: Mention wrapper executables, in addition to wrapper scripts. Add menu referencing subsection 'Wrapper executables for programs'. [Wrapper executables for programs]: New subsection. Documents

Re: [PATCH] Add tests for cwrapper with -std=c89 and -std=c99

2009-01-23 Thread Charles Wilson
Ralf Wildenhues wrote: Please go ahead and push with these changes. Pushed. -- Chuck

[PATCH] Add tests for cwrapper with -std=c89 and -std=c99

2009-01-22 Thread Charles Wilson
@@ +# cwrapper.at -- test compliance with c89 standard -*- Autotest -*- + +# Copyright (C) 2009 Free Software Foundation, Inc. +# Written by Charles Wilson, 2009 +# +# This file is part of GNU Libtool. +# +# GNU Libtool is free software; you can redistribute it and/or +# modify it under the terms

Re: [PATCH] [cygwin|mingw] Fix compile warnings when -std=c89.

2009-01-22 Thread Charles Wilson
Charles Wilson wrote: The bits removed from this commit are attached as cygwin-cwrapper-cleanups.patch. Will start a new thread with these cleanups. -- Chuck

Re: testsuite performance

2009-01-22 Thread Charles Wilson
Ralf Wildenhues wrote: * Charles Wilson wrote on Wed, Jan 21, 2009 at 08:47:42PM CET: [...] EVERY separate patchset requires an independent full testsuite run. Until recently, that was 5 hours of sitting in front of my computer waiting for popups, while that computer was completely useless

Re: [PATCH] Add tests for cwrapper with -std=c89 and -std=c99

2009-01-22 Thread Charles Wilson
Charles Wilson wrote: + sed s/LTCFAGS=.*/' $restrictive_flags'/ $orig_LIBTOOL ./libtool I've already fixed this typo s/LTCFAGS/LTCFLAGS/ -- Chuck

[PATCH] [cygwin|mingw] cwrapper cleanups.

2009-01-22 Thread Charles Wilson
libltdl/config/ltmain.m4sh (func_emit_cwrapperexe_src) [file scope]: re-organized includes and portability macros. Avoid oldnames on MINGW32 and MSVC for setmode/stat/chmod/getcwd/putenv. Declare _putenv on MINGW32 when -ansi. Use namespaced macro LT_DEBUGWRAPPER. --- This patch contains the parts

Re: [PATCH] Minor cygwin cleanup

2009-01-21 Thread Charles Wilson
Ralf Wildenhues wrote: * Charles Wilson wrote on Tue, Jan 20, 2009 at 11:31:43PM CET: libltdl/config/ltmain.m4sh (func_generate_dlsyms): Correct case pattern for cygwin. --- Ok to push? Yes, thanks! Pushed. -- Chuck

[PATCH] [cygwin|mingw] fix dlpreopen with --disable-static take 4

2009-01-21 Thread Charles Wilson
* libltdl/config/general.m4sh: Update copyright year. (func_tr_sh): New function. * libltdl/config/ltmain.m4sh (func_generate_dlsyms) [cygwin|mingw]: Obtain DLL name corresponding to import library by using value stored in unique variable libfile_$(transliterated implib name). If that fails, use

Re: [PATCH] [cygwin|mingw] Fix compile warnings when -std=c89.

2009-01-21 Thread Charles Wilson
Peter Rosin wrote: Den 2009-01-16 15:15 skrev Charles Wilson: Charles Wilson wrote: Charles Wilson wrote: * libltdl/config/ltmain.m4sh: Update copyright date. (func_emit_wrapper_part1): move contents to... (func_emit_wrapper_part2): move contents to... (func_emit_wrapper): here

Re: [PATCH] [cygwin|mingw] fix dlpreopen with --disable-static take 4

2009-01-21 Thread Charles Wilson
Charles Wilson wrote: Test suite on cygwin/native in progress. Assumming test suite passes, OK? Comments, Review, Discussion? All tests pass (cygwin/native): Old suite: === All 113 tests passed (11 tests were not run) === New suite: 76 tests behaved

Re: [PATCH] [cygwin|mingw] fix dlpreopen with --disable-static take 4

2009-01-21 Thread Charles Wilson
Charles Wilson wrote: Reviewing my own submission... (func_cygming_dll_for_implib_core): New function. This function is actually called func_cygming_dll_for_implib_fallback_core Need to correct log history. (func_cygming_implib_p): New function. Confusing. There is already

Re: [PATCH] [cygwin|mingw] Fix compile warnings when -std=c89.

2009-01-21 Thread Charles Wilson
Ralf Wildenhues wrote: * Charles Wilson wrote on Wed, Jan 21, 2009 at 08:47:42PM CET: Part of my tendency to include minor -- easy to review -- changes with larger ones is due to (a) see it, fix it, otherwise it'll be forgotten and (b) EVERY separate patchset requires an independent full

Re: [PATCH] [cygwin|mingw] Fix compile warnings when -std=c89.

2009-01-21 Thread Charles Wilson
LT_DEBUGWRAPPER # define LTWRAPPER_DEBUGPRINTF(args) ltwrapper_debugprintf args static void ltwrapper_debugprintf (const char *fmt, ...) diff --git a/ChangeLog b/ChangeLog index b702907..8d83a7b 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,17 @@ 2009-01-21 Charles Wilson libt...@cwilson.fastmail.fm

Re: Run tests with low max_cmd_len on MSYS/MSVC

2009-01-21 Thread Charles Wilson
Ralf Wildenhues wrote: We may need to think about speeding up func_to_host_path, e.g., by not forking for arguments that don't need conversion, or by converting several paths with a constant amount of forks. But that can be done separately. FWIW, as part of re-writing this: [PATCH]

Re: spaces

2009-01-21 Thread Charles Wilson
Ralf Wildenhues wrote: OK so it seems there are more voices for spaces. Can we agree to make the switch only after 2.2.8 though, I would like to avoid unnecessary churn ATM. Works for me. -- Chuck

Re: [PATCH] [cygwin|mingw] Fix compile warnings when -std=c89.

2009-01-21 Thread Charles Wilson
/c89.at 2009-01-21 21:32:01.79210 -0500 @@ -0,0 +1,85 @@ +# c89.at -- test compliance with c89 standard -*- Autotest -*- + +# Copyright (C) 2009 Free Software Foundation, Inc. +# Written by Charles Wilson, 2009 +# +# This file is part of GNU Libtool. +# +# GNU Libtool is free software

Re: spaces

2009-01-20 Thread Charles Wilson
Bob Friesenhahn wrote: For many years I have had my editor configured to always use spaces. This ensures WYSIWYG for everyone involved. Agree 100%. I try to manually match whatever sp/tab convention is in place -- using vi if I have to -- but much prefer all spaces. -- Chuck

Re: [PATCH] [cygwin|mingw] fix dlpreopen with --disable-static take 2

2009-01-20 Thread Charles Wilson
Ralf Wildenhues wrote: +# func_tr_sh +# turn $1 into a string suitable for a shell variable name +# result is stored in $func_tr_sh_result +func_tr_sh () +{ + func_tr_sh_result=`echo $1 | $SED -e 's/[^A-Za-z0-9_]/_/g'` + # ensure result begins with non-digit + case $func_tr_sh_result in

[PATCH] Minor cygwin cleanup

2009-01-20 Thread Charles Wilson
libltdl/config/ltmain.m4sh (func_generate_dlsyms): Correct case pattern for cygwin. --- Ok to push? libltdl/config/ltmain.m4sh |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libltdl/config/ltmain.m4sh b/libltdl/config/ltmain.m4sh index 6be529a..760f647 100644 ---

Re: [PATCH] [cygwin|mingw] fix dlpreopen with --disable-static take 3

2009-01-16 Thread Charles Wilson
Charles Wilson wrote: Full test suite on cygwin in progress. Assuming it passes, ok for squash and push? Results: old test suite: === All 113 tests passed (11 tests were not run) === New test suite: ERROR: 76 tests were run, 4 failed (3 expected

Re: [PATCH] [cygwin|mingw] Fix compile warnings when -std=c89.

2009-01-16 Thread Charles Wilson
Charles Wilson wrote: Charles Wilson wrote: * libltdl/config/ltmain.m4sh: Update copyright date. (func_emit_wrapper_part1): move contents to... (func_emit_wrapper_part2): move contents to... (func_emit_wrapper): here. (func_emit_cwrapperexe_src) [file scope]: re-organized includes

[PATCH] [cygwin|mingw] fix dlpreopen with --disable-static take 3

2009-01-15 Thread Charles Wilson
* libltdl/m4/libtool.m4 (_LT_CHECK_SHAREDLIB_FROM_LINKLIB): New macro sets sharedlib_from_linklib_cmd variable. (_LT_DECL_DLLTOOL): New macro ensures DLLTOOL is always set. * libltdl/config/ltmain.m4sh (func_generate_dlsyms): Use $sharedlib_from_linklib_cmd instead of directly invoking

Re: [PATCH] [cygwin|mingw] fix dlpreopen with --disable-static take 2

2009-01-13 Thread Charles Wilson
Peter Rosin wrote: Den 2009-01-06 02:06 skrev Charles Wilson: Maybe under that name. But a libbfd-ified version of impgen (as a replacement for the IMO totally broken -- but part of mingw-utils-0.3 -- reimp program), that happens to also supply an --identify foo --identify-ms functionality

Re: [PATCH] [cygwin|mingw] Fix compile warnings when -std=c89.

2009-01-08 Thread Charles Wilson
Charles Wilson wrote: * libltdl/config/ltmain.m4sh: Update copyright date. (func_emit_wrapper_part1): move contents to... (func_emit_wrapper_part2): move contents to... (func_emit_wrapper): here. (func_emit_cwrapperexe_src) [file scope]: re-organized includes and portability macros. Avoid

Re: [PATCH] [cygwin|mingw] fix dlpreopen with --disable-static take 2

2009-01-05 Thread Charles Wilson
Peter Rosin wrote: Den 2009-01-05 06:24 skrev Charles Wilson: Interesting! Meanwhile, I have done some experiments on my own, as I don't like the dependence on anything that comes with MinGW when dealing with libtool and MSVC. I kind of suspected that. What about the attached? This version

Re: [PATCH] [cygwin|mingw] Fix compile warnings when -std=c89.

2009-01-04 Thread Charles Wilson
Roumen Petrov wrote: Charles Wilson wrote: [SNIP] This patch attempts to correct the issues raised in this thread: msys/mingw warnings about string length and putenv absence with gcc -Wall -ansi http://lists.gnu.org/archive/html/bug-libtool/2008-12/msg00038.html [SNIP] Patch fail

Re: [PATCH] [cygwin|mingw] fix dlpreopen with --disable-static take 2

2009-01-04 Thread Charles Wilson
Charles Wilson wrote: Peter Rosin wrote: I'm primarily trying to determine what impact this has on my MSVC branch... Ran some experiments on the libraries shipped with the Windows SDK. The attached script worked ok on most of them. After eliminating the static libraries and the import

Re: [PATCH] [cygwin|mingw] fix dlpreopen with --disable-static take 2

2009-01-04 Thread Charles Wilson
Charles Wilson wrote: Charles Wilson wrote: Peter Rosin wrote: I'm primarily trying to determine what impact this has on my MSVC branch... Ran some experiments on the libraries shipped with the Windows SDK. The attached script worked ok on most of them. After eliminating the static

Re: [PATCH] [cygwin|mingw] Fix compile warnings when -std=c89.

2009-01-03 Thread Charles Wilson
Charles Wilson wrote: Spot checked some regression tests on cygwin (all passed). Running full regression suite on mingw. OK to push, pending testsuite results? No regressions on msys/mingw from the last time I ran the testsuite on that platform (2.2.5a). IOW: Old testsuite results

[PATCH] [cygwin]: Add cross-compile support to cwrapper

2009-01-03 Thread Charles Wilson
libltdl/config/ltmain.m4sh: (func_cygpath): New function. (func_wine_to_win32_path): New function. Refactored from... (func_msys_to_win32): New function supports converting both paths and pathlists. Refactored from... (func_to_host_path): ...here. [msys-mingw]: Use refactored func_msys_to_win32.

Re: [PATCH] [cygwin|mingw] fix dlpreopen with --disable-static take 2

2009-01-03 Thread Charles Wilson
Peter Rosin wrote: I'm primarily trying to determine what impact this has on my MSVC branch... Den 2009-01-03 02:39 skrev Charles Wilson: *snip* +*cygwin* | *mingw* | *cegcc* ) We should strive to have fewer of these in ltmain.m4sh, not more. Yep. But the problem

[PATCH] [cygwin|mingw] fix dlpreopen with --disable-static take 2

2009-01-02 Thread Charles Wilson
* libltdl/config/general.m4sh: Adjust copyright date. (func_tr_sh): New function. * libltdl/config/ltmain.m4sh: Adjust copyright date. (func_dlltool_identify): New function. (func_win32_dllname_for_implib): New function. (func_generate_dlsyms) [cygwin|mingw]: Obtain DLL name corresponding to

Re: [PATCH] [cygwin|mingw] fix dlpreopen with --disable-static take 2

2009-01-02 Thread Charles Wilson
Charles Wilson wrote: bootstrapped on cygwin, tested the demo-{conf|shared|static} + demo-make + demo-exec test cases with success. Full test suite in progress. And...4.5 hours later, test suite results on cygwin (1.7.0-37, but that shouldn't matter. The good news is, cygwin-1.7 now

[PATCH] [cygwin|mingw] Fix compile warnings when -std=c89.

2009-01-02 Thread Charles Wilson
* libltdl/config/ltmain.m4sh: Update copyright date. (func_emit_wrapper_part1): move contents to... (func_emit_wrapper_part2): move contents to... (func_emit_wrapper): here. (func_emit_cwrapperexe_src) [file scope]: re-organized includes and portability macros. Avoid oldnames on MINGW32 and MSVC

Re: [PATCH] [cygwin|mingw] fix dlpreopen with --disable-static

2008-11-24 Thread Charles Wilson
Brian Dessent wrote: Ralf Wildenhues wrote: Did GCC change since then, or is this system-dependent? Interesting. I'd be curious to see if powerpc-ibm-aix5.3.0.0-c++filt recognises the FI/FD encoding, and if so then it would be reasonable to conclude that this is in fact system-dependent

Re: [PATCH] Fix --verbose option and add new --no-silent option

2008-11-21 Thread Charles Wilson
Charles Wilson wrote: Ralf Wildenhues wrote: Hi Charles, * Charles Wilson wrote on Sat, Nov 15, 2008 at 10:40:26AM CET: * libltdl/config/ltmain.m4sh (usage): Document new --no-silent/--no-quiet options. Spacing changes. (func_enable_tag): Handle --no-silent/--no-quiet options. Modified

[PATCH] Fix --verbose option; add new --no-{silent|quiet|verbose} options.

2008-11-21 Thread Charles Wilson
++- libltdl/config/ltmain.m4sh | 16 +++- 4 files changed, 81 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog index b1582fd..cd1b1fa 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,22 @@ +2008-11-21 Charles Wilson ... + + Fix --verbose option; add new --no-{silent

Re: [PATCH] Fix --verbose option and add new --no-silent option

2008-11-21 Thread Charles Wilson
Ralf Wildenhues wrote: If you agree, then go ahead and commit with needed changes. Pushed: see new thread: [PATCH] Fix --verbose option; add new --no-{silent|quiet|verbose} options. -- Chuck

[PATCH] Fix --verbose option and add new --no-silent option

2008-11-15 Thread Charles Wilson
* libltdl/config/ltmain.m4sh (usage): Document new --no-silent/--no-quiet options. Spacing changes. (func_enable_tag): Handle --no-silent/--no-quiet options. Modified --verbose to actually activate opt_verbose. New behavior: --silent disables both normal output and func_verbose output. --verbose

[PATCH] Add func_win32_import_lib_p

2008-11-15 Thread Charles Wilson
* libltdl/config/ltmain.m4sh (func_win32_import_lib_p): New function. --- The second of several smaller patches broken out of, or arising from discussion involving, my original [PATCH] [cygwin|mingw] fix dlpreopen with --disable-static one:

Re: [PATCH] [cygwin|mingw] fix dlpreopen with --disable-static

2008-11-15 Thread Charles Wilson
Charles Wilson wrote: Of course, first I need to revise the dlltool patch and get it accepted; there have been some comments on the binutils list. Done. Yay! http://sourceware.org/ml/binutils/2008-11/msg00180.html Well, that, and it fixes a test that currently fails. Which one, and can you

Re: [PATCH] [cygwin|mingw] fix dlpreopen with --disable-static

2008-11-13 Thread Charles Wilson
Ralf Wildenhues wrote: The point is, we perhaps STARTED with the .la file, but the whole point of the dlpreopen $pass is to replace each .la file in $dlprefiles with the name of the object from which the symbols should be extracted, to build the symbol table. So, pick one: either the DLL, or

<    1   2   3   4   5   >