Re: [Libusbx-devel] [PATCH] BSD: add NetBSD experimental support

2012-04-20 Thread Hans de Goede
Hi, Looks good, ack. Regards, Hans On 04/19/2012 07:10 PM, Pete Batard wrote: With a few matters out of the way, let's try to get back to business (provided SF.net fixed their mail issue with gmail servers). The proposed attached patch adds experimental NetBSD support. It's basically a

Re: [Libusbx-devel] 3 more warnings fixed: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

2012-04-20 Thread Hans de Goede
Hi, All 3 look good to me, ack series. Regards, Hans On 04/20/2012 10:30 AM, Ludovic Rousseau wrote: Hello, 3 new patches to fix 3 (minor) compiler warnings. The idea to fix every warnings is that _new_ warnings are easy to spot. Bye

Re: [Libusbx-devel] Do not use an explicit inline

2012-04-20 Thread Hans de Goede
Makes sense, ack. On 04/20/2012 11:32 AM, Ludovic Rousseau wrote: Hello, The C compiler is much better than us to know when to inline a function or not. This also fixes a lot of compiler warnings: xusb.c:59:19: warning: function ‘perr’ can never be inlined because it uses variable

Re: [Libusbx-devel] Another patch to fix compiler warnings: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

2012-04-20 Thread Hans de Goede
Ack for the new version :) p.s. Any chance you could send patches inline? That makes it much easier to comment on them when reply-ing. Hint, try git send-email. Regards, Hans On 04/20/2012 11:26 AM, Ludovic Rousseau wrote: Le 20 avril 2012 11:09, Hans de Goedehdego...@redhat.com a écrit :

Re: [Libusbx-devel] Another patch to fix compiler warnings: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

2012-04-20 Thread Ludovic Rousseau
Le 20 avril 2012 11:39, Hans de Goede hdego...@redhat.com a écrit : Any chance you could send patches inline? That makes it much easier to comment on them when reply-ing. Hint, try git send-email. It will be hard to use git send-email from work (Microsoft mail server, etc.) but I will try it

[Libusbx-devel] libusbx roadmap discussion

2012-04-20 Thread Xiaofan Chen
Ref: http://sourceforge.net/apps/trac/libusbx/roadmap I think 1.0.11 target is already quite aggressive. For 1.0.12, I think we may need more details. Milestone: v1.0.12 Due in 4 months (09/01/12) [New features] * OSX: add HID support * Windows: libsub0.sys driver support * Windows: libusbK.sys

Re: [Libusbx-devel] Another patch to fix compiler warnings: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

2012-04-20 Thread Pete Batard
Revised patch looks OK to me too, so I will commit/push along with previous set. On 2012.04.20 10:57, Ludovic Rousseau wrote: Le 20 avril 2012 11:39, Hans de Goedehdego...@redhat.com a écrit : Any chance you could send patches inline? That makes it much easier to comment on them when

Re: [Libusbx-devel] libusbx roadmap discussion

2012-04-20 Thread Pete Batard
On 2012.04.20 11:03, Xiaofan Chen wrote: I will say OS X HID backend is a nice to have feature but not absolutely necessary, could be in 1.0.13 or 2.0. Actually, it was stated for 1.0.11 and I moved it to 1.0.12, as I don't think we'll have much time to look into it. I don't have a problem

Re: [Libusbx-devel] Fix compiler warning: warning: enumeration value ‘USE_GENERIC’ not handled in switch

2012-04-20 Thread Hans de Goede
Looks good, ack. On 04/20/2012 11:37 AM, Ludovic Rousseau wrote: Easy patch. The default case does nothing so it is harmless to also remove it. -- For Developers, A Lot Can Happen In A Second. Boundary is the

Re: [Libusbx-devel] libusbx roadmap discussion

2012-04-20 Thread Xiaofan Chen
On Fri, Apr 20, 2012 at 6:38 PM, Pete Batard p...@akeo.ie wrote: On 2012.04.20 11:03, Xiaofan Chen wrote: I will say OS X HID backend is a nice to have feature but not absolutely necessary, could be in 1.0.13 or 2.0. Actually, it was stated for 1.0.11 and I moved it to 1.0.12, as I don't

Re: [Libusbx-devel] Name of the files

2012-04-20 Thread Xiaofan Chen
On Sat, Apr 21, 2012 at 8:32 AM, Jose Pablo josepablo.cas...@gmail.com wrote: Hi everybody Can you change the name of this files? From:                          To: libusb.h                       libusbx.h libusb-1.0.a                 libusbx-1.0.a libusb-1.0.la                

Re: [Libusbx-devel] Name of the files

2012-04-20 Thread Orin Eman
On Fri, Apr 20, 2012 at 8:21 PM, Jose Pablo josepablo.cas...@gmail.comwrote: What If I use a software which uses libusb-1.0 and then I decide to install another software which use libusbx-1.0? Do I have to uninstall the first one to uses the second one? Just because you people can´t decide not

Re: [Libusbx-devel] Name of the files

2012-04-20 Thread Jose Pablo
I understand that NOW its not a problem. But in a future may be a problem. So, why don' t change the names NOW and prevent future problems? Is an engineering issue, anticipate a future problem and prevent it. Before the problem blow up in front of you. If it not, it's gonna crash on an iceberg