Re: [libvirt] [RFC v2] libvirt vGPU QEMU integration

> My concern is that a type id seems arbitrary but we're specifying that > it be unique. We already have something unique, the name. So why try > to make the type id unique as well? A vendor can accidentally create > their vendor driver so that a given name means something

Re: [libvirt] [RFC v2] libvirt vGPU QEMU integration

> From: Alex Williamson [mailto:alex.william...@redhat.com] > Sent: Thursday, September 22, 2016 11:02 AM > > On Thu, 22 Sep 2016 02:33:01 + > "Tian, Kevin" wrote: > > > > From: Alex Williamson [mailto:alex.william...@redhat.com] > > > Sent: Wednesday, September 21,

Re: [libvirt] [RFC v2] libvirt vGPU QEMU integration

On Thu, 22 Sep 2016 02:33:01 + "Tian, Kevin" wrote: > > From: Alex Williamson [mailto:alex.william...@redhat.com] > > Sent: Wednesday, September 21, 2016 12:37 PM > > > > On Wed, 21 Sep 2016 03:56:21 + > > "Tian, Kevin" wrote: > > > > > >

Re: [libvirt] [RFC v2] libvirt vGPU QEMU integration

> From: Tian, Kevin > Sent: Thursday, September 22, 2016 10:33 AM > > > > > > Another example is class-specific attributes such > > > as 'resolution', etc. which you listed under 'display class'. All those > > > attributes should be moved to mdev directory. Only class ID is > > > required under

Re: [libvirt] [PATCH 5/7] qemu: Use qemuGetCompressionProgram for error paths

At 2016-09-22 05:30:53, "John Ferlan" wrote: >Let's do some more code reuse - there are 3 other callers that care to >check/get the compress program. Each of those though cares whether the >requested cfg image is valid and exists. So, add a parameter to handle >those cases. >

Re: [libvirt] [RFC v2] libvirt vGPU QEMU integration

> From: Alex Williamson [mailto:alex.william...@redhat.com] > Sent: Wednesday, September 21, 2016 12:43 PM > > On Wed, 21 Sep 2016 04:10:53 + > "Tian, Kevin" wrote: > > > > From: Kirti Wankhede [mailto:kwankh...@nvidia.com] > > > Sent: Wednesday, September 21, 2016

Re: [libvirt] [RFC v2] libvirt vGPU QEMU integration

> From: Alex Williamson [mailto:alex.william...@redhat.com] > Sent: Wednesday, September 21, 2016 12:37 PM > > On Wed, 21 Sep 2016 03:56:21 + > "Tian, Kevin" wrote: > > > > From: Kirti Wankhede [mailto:kwankh...@nvidia.com] > > > Sent: Tuesday, September 20, 2016 10:22

Re: [libvirt] [PATCH 0/7] Pass the path of compress program (redo)

At 2016-09-22 05:30:48, "John Ferlan" wrote: >Rather than try to describe what I was thinking about for the passing >the compress program directly series from Chen Hanxiao: > >http://www.redhat.com/archives/libvir-list/2016-September/msg00677.html > >and >

Re: [libvirt] [PATCH v2 0/3] pass the path of compress prog directly

At 2016-09-22 05:32:10, "John Ferlan" wrote: > > >On 09/19/2016 07:06 AM, Chen Hanxiao wrote: >> From: Chen Hanxiao >> >> This series will pass the path of compress programe >> directly to functions such as doCoreDump, qemuDomainSaveInternal, etc. >>

[libvirt] [PATCH 5/7] interface_backend_udev.c:fix a typo

Signed-off-by: Nitesh Konkar --- src/interface/interface_backend_udev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/interface/interface_backend_udev.c b/src/interface/interface_backend_udev.c index 27a772d..5d0fc64 100644 ---

[libvirt] [PATCH 7/7] esx_driver.c:fix a typo

Signed-off-by: Nitesh Konkar --- src/esx/esx_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/esx/esx_driver.c b/src/esx/esx_driver.c index fd2452f..5ce98b3 100644 --- a/src/esx/esx_driver.c +++ b/src/esx/esx_driver.c @@ -969,7 +969,7

[libvirt] [PATCH 6/7] esx_driver.c:fix a typo

Signed-off-by: Nitesh Konkar --- src/esx/esx_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/esx/esx_driver.c b/src/esx/esx_driver.c index 3d90b69..fd2452f 100644 --- a/src/esx/esx_driver.c +++ b/src/esx/esx_driver.c @@ -78,7 +78,7 @@

[libvirt] [PATCH 4/7] storage_conf.c:fix a typo

Signed-off-by: Nitesh Konkar --- src/conf/storage_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c index 05a1a49..7e7bb72 100644 --- a/src/conf/storage_conf.c +++ b/src/conf/storage_conf.c @@

[libvirt] [PATCH 3/7] domain_conf.c:fix a typo

Signed-off-by: Nitesh Konkar --- src/conf/domain_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 5ec1970..dd34cec 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@

[libvirt] [PATCH 2/7] domain_conf.h:fix a typo

Signed-off-by: Nitesh Konkar --- src/conf/domain_conf.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index d4a84c3..ce90c27 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@

[libvirt] [PATCH 0/7] Fix some typos.

*** BLURB HERE *** Nitesh Konkar (7): domain_conf.c:fix a typo domain_conf.h:fix a typo domain_conf.c:fix a typo storage_conf.c:fix a typo interface_backend_udev.c:fix a typo esx_driver.c:fix a typo esx_driver.c:fix a typo src/conf/domain_conf.c | 4 ++--

[libvirt] [PATCH 1/7] domain_conf.c:fix a typo

Signed-off-by: Nitesh Konkar --- src/conf/domain_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 5fede3d..5ec1970 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@

Re: [libvirt] [PATCH] libxl: support VIR_MIGRATE_PERSIST_DEST migration flag

Michal Privoznik wrote: > On 19.09.2016 22:25, Jim Fehlig wrote: >> By default, virt-manager (and likely other libvirt-based apps) sets >> the VIR_MIGRATE_PERSIST_DEST flag when invoking the migrate API, which >> fails in a Xen setup since the libxl driver does not support the flag. >> >>

Re: [libvirt] xen/libvirt freeze while attching network-device to vm´s - question about provided patches

guido.rossmuel...@gdata.de wrote: > Hi Jim, > > thanks for your response ans sorry for my late answer, > > i´m sorry, i don´t really understand what you are missing in [2], or from > where in the log-output you see that an > shutdown event is missing. Well, during my testing of the patch I

[libvirt] [PATCH 7/7] qemu: Get/return compressedpath program

Based upon a patch from Chen Hanxiao , rather than need to call virFindFileInPath twice, let's just save the path and pass it along with the compressed type. (NB: the second call would be in virExec as called from virCommandRunAsync which is called from qemuMigrationToFile

[libvirt] [PATCH 5/7] qemu: Use qemuGetCompressionProgram for error paths

Let's do some more code reuse - there are 3 other callers that care to check/get the compress program. Each of those though cares whether the requested cfg image is valid and exists. So, add a parameter to handle those cases. NB: We won't need to initialize the returned value in the case where

[libvirt] [PATCH 1/7] qemu: Move getCompressionType

A subsequent patch will adjust the 3 callers to just call from doCoreDump. Signed-off-by: John Ferlan --- src/qemu/qemu_driver.c | 70 ++ 1 file changed, 36 insertions(+), 34 deletions(-) diff --git a/src/qemu/qemu_driver.c

Re: [libvirt] [PATCH v2 0/3] pass the path of compress prog directly

On 09/19/2016 07:06 AM, Chen Hanxiao wrote: > From: Chen Hanxiao > > This series will pass the path of compress programe > directly to functions such as doCoreDump, qemuDomainSaveInternal, etc. > this can avoid one extra virFindFileInPath call in during virExec. > >

[libvirt] [PATCH 6/7] qemu: Remove qemuCompressProgramAvailable

There's only one caller and the code is duplicitous just converting the recently converted cfg image name back into it's string value in order to get/find the path to the image. A subsequent patch can return this path. Signed-off-by: John Ferlan --- src/qemu/qemu_driver.c |

[libvirt] [PATCH 3/7] qemu: Introduce helper qemuGetCompressionProgram

Split out the guts of getCompressionType to perform the same functionality in the new helper program with a subsequent patch goal to be reusable for other callers making similar checks/calls to ensure the compression type is valid and that the compression program cannot be found. Signed-off-by:

[libvirt] [PATCH 4/7] qemu: Remove getCompressionType

There's only one caller now anyway... Besides it's just a shell for getting the compress type. Subsequent patches will return the path to the compression program. Signed-off-by: John Ferlan --- src/qemu/qemu_driver.c | 25 +++-- 1 file changed, 7

[libvirt] [PATCH] libxl: find virDomainObj in libxlDomainShutdownThread

libxl events are delivered to libvirt via the libxlDomainEventHandler callback registered with libxl. Documenation in $xensrc/tools/libxl/libxl_event.h states that the callback "may occur on any thread in which the application calls libxl". This can result in deadlock since many of the libvirt

[libvirt] [PATCH 2/7] qemu: Adjust doCoreDump to call getCompressionType

Rather than calling getCompressionType from each of the callers, just call it from doCoreDump. A subsequent patch will be adjust the code even more. Signed-off-by: John Ferlan --- src/qemu/qemu_driver.c | 18 ++ 1 file changed, 6 insertions(+), 12

[libvirt] [PATCH 0/7] Pass the path of compress program (redo)

Rather than try to describe what I was thinking about for the passing the compress program directly series from Chen Hanxiao: http://www.redhat.com/archives/libvir-list/2016-September/msg00677.html and http://www.redhat.com/archives/libvir-list/2016-August/msg01237.html I took the liberty of

Re: [libvirt] [PATCH] qemu_process: show shutoff reasons when debug log disabled

On 09/19/2016 04:17 AM, Chen Hanxiao wrote: > From: Chen Hanxiao > > We have a few of senarios that libvirtd would invoke qemuProcessStop > and leave a "shutting down" in /var/log/libvirt/qemu/$DOMAIN.log. > > The shutoff reason showing in debug log is also very

Re: [libvirt] [PATCH] qemu_process: move graphics validation into separate function

On Wed, Sep 21, 2016 at 04:58:55PM -0400, John Ferlan wrote: > On 09/21/2016 11:40 AM, Pavel Hrdina wrote: > > Signed-off-by: Pavel Hrdina > > --- > > src/qemu/qemu_process.c | 56 > > + > > 1 file changed, 33 insertions(+), 23

Re: [libvirt] [PATCH] qemu_process: move graphics validation into separate function

On 09/21/2016 11:40 AM, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > src/qemu/qemu_process.c | 56 > + > 1 file changed, 33 insertions(+), 23 deletions(-) > > diff --git a/src/qemu/qemu_process.c

Re: [libvirt] [PATCH 2/2] bhyve: add e1000 nic support

On 08/27/2016 09:11 AM, Roman Bogorodskiy wrote: > Recently e1000 NIC support was added to bhyve; implement that in > the bhyve driver: > > - Add capability check by analyzing output of the 'bhyve -s 0,e1000' >command > - Modify bhyveBuildNetArgStr() to support e1000 and also pass >

Re: [libvirt] [PATCH 1/2] bhyve: Separate out checks from virBhyveProbeCaps

On 08/27/2016 09:11 AM, Roman Bogorodskiy wrote: > From: Fabian Freyer > > At the moment this is just one check, but separating this out into a > separate function makes checks more modular, allowing for more readable > code once more checks are added. This

Re: [libvirt] [PATCH] libvirt-nodedev.c:fix a typo

On 09/21/2016 04:02 PM, Nitesh Konkar wrote: > Signed-off-by: Nitesh Konkar > --- > src/libvirt-nodedev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > ACK and pushed, Tks, John -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH] libvirt-admin.c:fix a typo

On 09/21/2016 03:31 PM, Nitesh Konkar wrote: > Signed-off-by: Nitesh Konkar > --- > src/libvirt-admin.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > ACK and pushed, Tks, John In the future, rather than one patch at a time, keep a git tree of

Re: [libvirt] [PATCH] domain_conf.c:fix a typo

On 09/21/2016 03:18 PM, Nitesh Konkar wrote: > Signed-off-by: Nitesh Konkar > --- > src/conf/domain_conf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > ACK and pushed, Tks, John -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH] driver.c:fix a typo

On 09/21/2016 03:17 PM, Nitesh Konkar wrote: > Signed-off-by: Nitesh Konkar > --- > src/driver.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > ACK and pushed, Tks, John -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH] domain_conf.c:fix the comment.

On 09/21/2016 01:17 PM, Nitesh Konkar wrote: > Signed-off-by: Nitesh Konkar > --- > src/conf/domain_conf.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > ACK and pushed Tks - John > diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c

Re: [libvirt] [PATCH] domain_conf.c:fix a typo

On 09/21/2016 12:52 PM, Nitesh Konkar wrote: > Signed-off-by: Nitesh Konkar > --- > src/conf/domain_conf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > ACK and pushed Tks, John -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH v2 19/20] virlog: Store the journald fd within the output object

On 08/18/2016 07:47 AM, Erik Skultety wrote: > Now that previous patches tried to refactor the code and split parsing and > defining logic of logging primitives, there is no reason why we could not keep > journald's fd within the journald output object the same way as we do for > regular

[libvirt] [PATCH] libvirt-nodedev.c:fix a typo

Signed-off-by: Nitesh Konkar --- src/libvirt-nodedev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libvirt-nodedev.c b/src/libvirt-nodedev.c index e4e9836..59f020b 100644 --- a/src/libvirt-nodedev.c +++ b/src/libvirt-nodedev.c @@ -595,7

Re: [libvirt] [PATCH v2 20/20] virlog: Split parsing and setting priority

On 08/18/2016 07:47 AM, Erik Skultety wrote: > Handling of outputs and filters has been changed in a way that splits > parsing and defining. Do the same thing for logging priority as well, this > however, doesn't need much of a preparation. > --- > src/util/virlog.c | 21 + >

Re: [libvirt] [PATCH v2 09/20] virlog: Introduce virLogParseOutput

On 08/18/2016 07:47 AM, Erik Skultety wrote: > Introduce a method to parse an individual logging output. The difference > compared to the virLogParseAndDefineOutput is that this method does not define > the output, instead it makes use of the virLogNewOutputTo* methods introduced > in the

Re: [libvirt] [PATCH v2 18/20] virlog: Make some of the methods static

On 08/18/2016 07:47 AM, Erik Skultety wrote: > Several methods that were introduced in previous patches were not made static > on purpose so they could be introduced without any occurrence without the > compiler complaining about not using them. Since the scope of the methods is > local to the

Re: [libvirt] [PATCH v2 17/20] virlog: Remove functions that aren't used anywhere anymore

On 08/18/2016 07:47 AM, Erik Skultety wrote: > This is mainly virLogAddOutputTo* which were replaced by virLogNewOutputTo* > and > the previously poorly named ones virLogParseAndDefine* functions. All of these > are unnecessary now, since all the original callers were transparently > switched

[libvirt] [PATCH v5 2/2] qemu_capabilities: Introduce gluster specific debug capability

Teach qemu driver to detect whether qemu supports this configuration factor or not. Signed-off-by: Prasanna Kumar Kalever --- src/qemu/qemu_capabilities.c | 5 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 6 --

[libvirt] [PATCH v5 0/2] qemu/gluster: add option for tuning debug logging level

This series run basic sanity and other tests: 1. make syntax-check 2. make check 3. VIR_TEST_VERBOSE=1 ./tests/qemuargv2xmltest 4. VIR_TEST_VERBOSE=1 ./tests/qemuxml2argvtest 5. VIR_TEST_VERBOSE=1 ./tests/qemucapabilitiestest v5: Avoild copying variable glusterDebugLevel to disk->src

[libvirt] [PATCH v5 1/2] qemu/gluster: add option for tuning debug logging level

This helps in selecting log level of the gluster gfapi, output to stderr. The option is 'gluster_debug_level', can be tuned by editing '/etc/libvirt/qemu.conf' Debug levels ranges 0-9, with 9 being the most verbose, and 0 representing no debugging output. The default is the same as it was

[libvirt] [PATCH] libvirt-admin.c:fix a typo

Signed-off-by: Nitesh Konkar --- src/libvirt-admin.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libvirt-admin.c b/src/libvirt-admin.c index 03245b6..88eef54 100644 --- a/src/libvirt-admin.c +++ b/src/libvirt-admin.c @@ -344,7 +344,7 @@

Re: [libvirt] [PATCH v4 2/2] qemu_capabilities: Introduce gluster specific debug capability

On Wed, Sep 21, 2016 at 7:21 PM, Jiri Denemark wrote: > On Wed, Sep 21, 2016 at 19:00:17 +0530, Prasanna Kumar Kalever wrote: >> Teach qemu driver to detect whether qemu supports this configuration >> factor or not. >> >> Signed-off-by: Prasanna Kumar Kalever

[libvirt] [PATCH] domain_conf.c:fix a typo

Signed-off-by: Nitesh Konkar --- src/conf/domain_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index ea246b0..28b81d2 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@

[libvirt] [PATCH] driver.c:fix a typo

Signed-off-by: Nitesh Konkar --- src/driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/driver.c b/src/driver.c index 1514a3b..67ac020 100644 --- a/src/driver.c +++ b/src/driver.c @@ -38,7 +38,7 @@ VIR_LOG_INIT("driver"); #ifdef

Re: [libvirt] [PATCH v2 16/20] daemon: Split filter parsing and filter defining

On 08/18/2016 07:47 AM, Erik Skultety wrote: > Similar to outputs, parser should do parsing only, thus the 'define' logic > is going to be stripped from virLogParseAndDefineFilters by replacing calls to > this method to virLogSetFilters instead. > Similar to my comments in patch 15 - I think

Re: [libvirt] [PATCH v2 15/20] daemon: Split output parsing and output defining

On 08/18/2016 07:47 AM, Erik Skultety wrote: > Since virLogParseAndDefineOutputs is going to be stripped from 'output > defining' > logic, replace all relevant occurrences with virLogSetOutputs call to make the > change transparent to all original callers (daemons mostly). I think the commit

Re: [libvirt] [PATCH v4 1/2] qemu/gluster: add option for tuning debug logging level

On Wed, Sep 21, 2016 at 7:28 PM, Jiri Denemark wrote: > On Wed, Sep 21, 2016 at 19:00:16 +0530, Prasanna Kumar Kalever wrote: >> This helps in selecting log level of the gluster gfapi, output to stderr. >> The option is 'gluster_debug_level', can be tuned by editing >>

Re: [libvirt] [RFC v2] libvirt vGPU QEMU integration

On Thu, 22 Sep 2016 00:04:14 +0530 Kirti Wankhede wrote: > On 9/20/2016 10:20 PM, Alex Williamson wrote: > > On Tue, 20 Sep 2016 21:53:16 +0530 > > Kirti Wankhede wrote: > > > >> On 9/20/2016 8:13 PM, Alex Williamson wrote: > >>> On Tue, 20 Sep

Re: [libvirt] [PATCH v2 14/20] virlog: Introduce virLogSetFilters

On 08/18/2016 07:47 AM, Erik Skultety wrote: > This method will eventually replace virLogParseAndDefineFilters which > currently does both parsing and defining. > > Signed-off-by: Erik Skultety > --- > src/libvirt_private.syms | 1 + > src/util/virlog.c| 31

Re: [libvirt] [PATCH v2 13/20] virlog: Introduce virLogSetOutputs

On 08/18/2016 07:47 AM, Erik Skultety wrote: > This API is the entry point to output modification of the logger. Currently, > everything is done by virLogParseAndDefineOutputs. Parsing and defining will > be > split into two operations both handled by this method transparently. > >

Re: [libvirt] [PATCH v2 12/20] virlog: Introduce virLogParseFilters

On 08/18/2016 07:47 AM, Erik Skultety wrote: > Same as with outputs. Another layer of abstraction, this provides support for > parsing a set of filters (preferred way). Comment works well if you read the previous patch... > > Signed-off-by: Erik Skultety > --- >

Re: [libvirt] [PATCH v2 11/20] virlog: Introduce virLogParseOutputs

On 08/18/2016 07:47 AM, Erik Skultety wrote: > Another abstraction added on the top of parsing a single logging output. This > method takes and parses the whole set of outputs, adding each single output > that has already been parsed into a caller-provided array. If the > user-supplied > string

Re: [libvirt] [PATCH v2 10/20] virlog: Introduce virLogParseFilter

On 08/18/2016 07:47 AM, Erik Skultety wrote: > Same as for outputs, introduce a new method, that is basically the same as > virLogParseAndDefineFilter with the difference that it does not define the > filter. It rather returns a newly created object that needs to be inserted > into > a list and

Re: [libvirt] [RFC v2] libvirt vGPU QEMU integration

On 9/20/2016 10:20 PM, Alex Williamson wrote: > On Tue, 20 Sep 2016 21:53:16 +0530 > Kirti Wankhede wrote: > >> On 9/20/2016 8:13 PM, Alex Williamson wrote: >>> On Tue, 20 Sep 2016 19:51:58 +0530 >>> Kirti Wankhede wrote: >>> On 9/20/2016

Re: [libvirt] [PATCH v2 09/20] virlog: Introduce virLogParseOutput

On 08/18/2016 07:47 AM, Erik Skultety wrote: > Introduce a method to parse an individual logging output. The difference > compared to the virLogParseAndDefineOutput is that this method does not define > the output, instead it makes use of the virLogNewOutputTo* methods introduced > in the

Re: [libvirt] [PATCH v2 08/20] virlog: Take a special care of syslog when setting new set of log outputs

On 08/18/2016 07:47 AM, Erik Skultety wrote: > Now that we're in the critical section, syslog connection can be re-opened > by issuing openlog, which is something that cannot be done beforehand, since > syslog keeps its file descriptor private and changing the tag earlier might > introduce a log

Re: [libvirt] [PATCH v2 04/20] virlog: Introduce virLogFindOutput

[...] doh! Like a good fluorescent lightbulb - it just dawned on me... > + > +for (i = 0; i < noutputs; i++) { > +if (dest == outputs[i]->dest && > +(dest != VIR_LOG_TO_FILE || STREQ(outputs[i]->name, name))) STREQ_NULLABLE would I believe remove the need for the

Re: [libvirt] [PATCH v2 07/20] virlog: Introduce virLogNewOutputTo* as a replacement for virLogAddOutputTo*

On 08/18/2016 07:47 AM, Erik Skultety wrote: > Continuing with the effort to split output parsing and defining, these new > functions return a logging object reference instead of defining the output. > Eventually, these functions will replace the existing ones > (virLogAddOutputTo*) > which

Re: [libvirt] [PATCH v2 06/20] virlog: Introduce virLogDefineFilters

On 08/18/2016 07:47 AM, Erik Skultety wrote: > Prepare a method that only defines a set of filters. It takes a list of > filters, preferably created by virLogParseFilters. The original set of filters > is reset and replaced by the new user-provided set of filters. > > Signed-off-by: Erik

Re: [libvirt] [PATCH v2 05/20] virlog: Introduce virLogDefineOutputs

On 08/18/2016 07:47 AM, Erik Skultety wrote: > Prepare a method that only defines a set of outputs. It takes a list of > outputs, preferably created by virLogParseOutputs. The original set of outputs > is reset and replaced by the new user-provided set of outputs. > > Signed-off-by: Erik

Re: [libvirt] [PATCH v2 02/20] virlog: Introduce virLogOutputNew

On 08/18/2016 07:47 AM, Erik Skultety wrote: > Continuing with the refactor, in order to later split output parsing and > output s/Continuing with the refactor, i/I > defining, introduce a new function which will create a new virLogOutput object > which parser will insert into a list with the

Re: [libvirt] [PATCH v2 04/20] virlog: Introduce virLogFindOutput

On 08/18/2016 07:47 AM, Erik Skultety wrote: > Outputs are a bit trickier than filters, because if the user(config)-specified > set of outputs does contain duplicates. So, not only we would log twice, but "because the user(config) specified set of outputs can contain duplicates." > we would

Re: [libvirt] [PATCH v2 03/20] virlog: Introduce virLogFilterNew

On 08/18/2016 07:47 AM, Erik Skultety wrote: > This method allocated a new filter object which it then returns back to > caller. s/allocated/allocates > > Signed-off-by: Erik Skultety > --- > src/libvirt_private.syms | 2 ++ > src/util/virlog.c| 46

Re: [libvirt] [PATCH v2 01/20] virlog: Rename virLogParse* to virLogParseAndDefine*

On 08/18/2016 07:47 AM, Erik Skultety wrote: > The reason for this is to be later able to split parsing from defining in a > convenient and transparent way, so eventually, the original virLogParse* > (virLogParseAndDefine* after this patch) functions which were named a bit > poorly will be

[libvirt] [PATCH] domain_conf.c:fix the comment.

Signed-off-by: Nitesh Konkar --- src/conf/domain_conf.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index ebddf5f..7daf2fd 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c

[libvirt] [PATCH] domain_conf.c:fix a typo

Signed-off-by: Nitesh Konkar --- src/conf/domain_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index a70be31..ebddf5f 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@

[libvirt] [libvirt-php][PATCH] libvirt_domain_get_screenshot_api: More memleak fixes and checks

Firstly, we are not checking whether virStreamNew succeeds or not. Secondly, we are not freeing the stream in all exit paths. Then we are copying the same pattern which frees allocated memory over and over again. Oh, and also we should abort stream if we are exiting abnormally. Signed-off-by:

Re: [libvirt] [PATCH rfc v2 0/8] fspool: backend directory

> 20 сент. 2016 г., в 23:52, John Ferlan написал(а): > > > >> On 09/15/2016 03:32 AM, Olga Krishtal wrote: >> Hi everyone, we would like to propose the first implementation of fspool >> with directory backend. >> >> Filesystem pools is a facility to manage filesystems

[libvirt] [PATCH] qemu_process: move graphics validation into separate function

Signed-off-by: Pavel Hrdina --- src/qemu/qemu_process.c | 56 + 1 file changed, 33 insertions(+), 23 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 1f56883..b360f6b 100644 ---

[libvirt] [libvirt-php][PATCH 1/2] examples: Sort domains

In the examples/index.php we list all domains/networks/.. defined for the connection we have. However, the objects are printed out in the order as provided by libvirt, so basically a random order. It may be more user friendly if we sort the array of objects before printing it out. Signed-off-by:

[libvirt] [libvirt-php][PATCH 0/2] Couple of example fixes

Pushed under "I'm the PHP master" rule. Michal Privoznik (2): examples: Sort domains examples: Die early if getting a screenshot fails examples/index.php | 2 +- examples/libvirt.php | 8 2 files changed, 9 insertions(+), 1 deletion(-) -- 2.8.4 -- libvir-list mailing list

[libvirt] [libvirt-php][PATCH 2/2] examples: Die early if getting a screenshot fails

Our index.php has a capability to fetch a screenshot for a domain. However, if there's a libvirt error, it just prints it out and continue executing the rest of the script even though it is not supposed to. Signed-off-by: Michal Privoznik --- examples/index.php | 2 +- 1

Re: [libvirt] [PATCH 6/7] qemu: Support newer ivshmem device variants

On Wed, Sep 21, 2016 at 05:10:09PM +0200, Martin Kletzander wrote: > On Wed, Sep 21, 2016 at 04:01:23PM +0100, Daniel P. Berrange wrote: > > I'm not a fan of the idea of silently picking a different device > > for the guest behind the applications back. By not exposing the > > different device

Re: [libvirt] [PATCH] libxl: support VIR_MIGRATE_PERSIST_DEST migration flag

On 19.09.2016 22:25, Jim Fehlig wrote: > By default, virt-manager (and likely other libvirt-based apps) sets > the VIR_MIGRATE_PERSIST_DEST flag when invoking the migrate API, which > fails in a Xen setup since the libxl driver does not support the flag. > > Persisting a domain is a trivial task

Re: [libvirt] [PATCH 6/7] qemu: Support newer ivshmem device variants

On Wed, Sep 21, 2016 at 04:01:23PM +0100, Daniel P. Berrange wrote: I'm not a fan of the idea of silently picking a different device for the guest behind the applications back. By not exposing the different device types with a "model" attribute, we miss a way to report to the application which

Re: [libvirt] [PATCH 0/4] qemu: fix vcpupin/emulatorpin with --config on VMs with automatic NUMA pinning

On Wed, Sep 21, 2016 at 04:50:52PM +0200, Michal Privoznik wrote: On 21.09.2016 15:54, Martin Kletzander wrote: On Wed, Sep 14, 2016 at 08:39:05AM +0200, Peter Krempa wrote: The automatic nodeset would creep into the persistent definition for live VMs with automatic pinning which is incorrect.

Re: [libvirt] [PATCH 6/7] qemu: Support newer ivshmem device variants

On Wed, Sep 21, 2016 at 03:30:55PM +0200, Martin Kletzander wrote: > QEMU added support for ivshmem-plain and ivshmem-doorbell. Those are > reworked varians of legacy ivshmem that are compatible from the guest > POV, but not from host's POV and have sane specification and handling. > > Details

Re: [libvirt] [PATCH 0/4] qemu: fix vcpupin/emulatorpin with --config on VMs with automatic NUMA pinning

On 21.09.2016 15:54, Martin Kletzander wrote: > On Wed, Sep 14, 2016 at 08:39:05AM +0200, Peter Krempa wrote: >> The automatic nodeset would creep into the persistent definition for >> live VMs >> with automatic pinning which is incorrect. >> >> https://bugzilla.redhat.com/show_bug.cgi?id=1365779

[libvirt] [RFC/PATCH 2/2] tests/networkxml2confdata: add dhcp-authoritative option

The previous patch changes the confdata output for dnsmasq. Adapt the expected test results to match. --- tests/networkxml2confdata/dhcp6-nat-network.conf | 1 + tests/networkxml2confdata/dhcp6host-routed-network.conf | 1 +

[libvirt] [RFC/PATCH 0/2] dnsmasq option "dhcp-authoritative"

On Mon, 2016-09-19 at 17:45 -0400, Laine Stump wrote: > After reading Simon's mail, and the openstack patch and description, > it isn't clear that this will actually solve your problem. Have you > tried it? (to test it, you should be able to just kill dnsmasq, add the > option to the dnsmasq conf

Re: [libvirt] [PATCH v4 0/5] Remove caching of address sets

On Fri, Aug 19, 2016 at 06:03:22AM +0200, Tomasz Flendrich wrote: Link to the previous version: https://www.redhat.com/archives/libvir-list/2016-August/msg00721.html Changes in v4: * instead of failing, qemuDomainValidateDevicePCISlotsChipsets now simply displays a warning when a new address

[libvirt] [RFC/PATCH 1/2] network: add dnsmasq option 'dhcp-authoritative'

The dnsmasq man page recommends that dhcp-authoritative "should be set when dnsmasq is definitely the only DHCP server on a network". This is the case for libvirt-managed virtual networks. The effect of this is that VMs that fail to renew their DHCP lease in time (e.g. if the VM or host is

Re: [libvirt] [PATCH v3 0/6] Test persistent device attachment

On Thu, Jul 28, 2016 at 09:53:55PM +0200, Tomasz Flendrich wrote: Changes in v3: * fewer patches, because part of v2 was ACK'd * two old commits, 08/10 and 09/10, are now one commit * qemuDomainUpdateDeviceFlags is now also split, creating a new function qemuDomainUpdateDeviceLiveAndConfig().

Re: [libvirt] [PATCH 0/2] Rework qemuhotplugtest

On Wed, Aug 03, 2016 at 12:37:47AM +0200, Tomasz Flendrich wrote: This series requires another one: https://www.redhat.com/archives/libvir-list/2016-July/msg01205.html Just so this doesn't look like it was not read by anyone, see response to the other hotplug series: v3 of Test persistent

Re: [libvirt] [PATCH 0/4] qemu: fix vcpupin/emulatorpin with --config on VMs with automatic NUMA pinning

On Wed, Sep 21, 2016 at 15:54:34 +0200, Martin Kletzander wrote: > On Wed, Sep 14, 2016 at 08:39:05AM +0200, Peter Krempa wrote: > >The automatic nodeset would creep into the persistent definition for live VMs > >with automatic pinning which is incorrect. > > >

Re: [libvirt] [PATCH v4 1/2] qemu/gluster: add option for tuning debug logging level

On Wed, Sep 21, 2016 at 19:00:16 +0530, Prasanna Kumar Kalever wrote: > This helps in selecting log level of the gluster gfapi, output to stderr. > The option is 'gluster_debug_level', can be tuned by editing > '/etc/libvirt/qemu.conf' > > Debug levels ranges 0-9, with 9 being the most verbose,

Re: [libvirt] [PATCH 0/4] qemu: fix vcpupin/emulatorpin with --config on VMs with automatic NUMA pinning

On Wed, Sep 14, 2016 at 08:39:05AM +0200, Peter Krempa wrote: The automatic nodeset would creep into the persistent definition for live VMs with automatic pinning which is incorrect. https://bugzilla.redhat.com/show_bug.cgi?id=1365779 Peter Krempa (4): conf: Introduce

Re: [libvirt] [PATCH v4 2/2] qemu_capabilities: Introduce gluster specific debug capability

On Wed, Sep 21, 2016 at 19:00:17 +0530, Prasanna Kumar Kalever wrote: > Teach qemu driver to detect whether qemu supports this configuration > factor or not. > > Signed-off-by: Prasanna Kumar Kalever ... > diff --git a/src/qemu/qemu_command.c

Re: [libvirt] [PATCH] migration: Document we don't copy storage during offline migration

On Wed, Sep 21, 2016 at 11:27:20AM +0200, Michal Privoznik wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1322717 During offline migration, no storage is copied. Nor disks, nor NVRAM file, nor anything. We use qemu for that and because domain is not running there's nobody to copy that for

[libvirt] [PATCH 7/7] qemu: Add support for hot/cold-(un)plug of shmem devices

This is needed in order to migrate with ivshmem role='peer' as that is not allowed to migrate. Signed-off-by: Martin Kletzander --- src/qemu/qemu_driver.c | 39 +++- src/qemu/qemu_hotplug.c| 231 -

[libvirt] [PATCH 4/7] qemu: Add qemuDomainSupportsNonLegacyShmem

That function checks whether ivshmem_plain/doorbell devices are supported so that we don't decide on the capability on multiple places, it also unifies error reporting. Signed-off-by: Martin Kletzander --- src/qemu/qemu_domain.c | 12 src/qemu/qemu_domain.h |

  1   2   >