On Mon, November 04, 2013 at 18:42 (+0100), Josef Bacik wrote:
On Thu, Oct 24, 2013 at 03:22:06PM +0200, Jan Schmidt wrote:
btrfs_dec_ref() queued a delayed ref for owner of a tree block. The qgroup
tracking is based on delayed refs. The owner of a tree block is set when a
tree block
(cc Arne)
On Thu, October 24, 2013 at 16:49 (+0200), Wang Shilong wrote:
Hello Jan,
btrfs_dec_ref() queued a delayed ref for owner of a tree block. The qgroup
tracking is based on delayed refs. The owner of a tree block is set when a
tree block is allocated, it is never updated.
When you
delayed refs for the root being removed. This fixes the qgroup
accounting.
Signed-off-by: Jan Schmidt list.bt...@jan-o-sch.net
Tested-by: dustym...@gmail.com
---
fs/btrfs/extent-tree.c | 14 +-
1 files changed, 9 insertions(+), 5 deletions(-)
diff --git a/fs/btrfs/extent-tree.c
Hi Karl,
On Fri, October 25, 2013 at 15:12 (+0200), Karl Kiniger wrote:
is there low level support to change inode ctimes somehow?
(on ext[234] it can be done using debugfs)
No.
It would be nice to make received snapshots as similar as
possible to their send source. (I am not talking about
On Thu, October 24, 2013 at 16:49 (+0200), Wang Shilong wrote:
Hello Jan,
btrfs_dec_ref() queued a delayed ref for owner of a tree block. The qgroup
tracking is based on delayed refs. The owner of a tree block is set when a
tree block is allocated, it is never updated.
When you allocate a
On Tue, October 15, 2013 at 22:41 (+0200), Zach Brown wrote:
Probably a bit too obscure to turn this into an xfstest? At least nobody
complained so far, and this reproducer takes me 1m57 to run, so nothing I
want
in each xfstest cycle.
I disagree. The entire point of regression tests is
On Wed, October 09, 2013 at 18:26 (+0200), Josef Bacik wrote:
btrfs_rename was using the root of the old dir instead of the root of the new
dir when checking for a hash collision, so if you tried to move a file into a
subvol it would freak out because it would see the file you are trying to
__btrfs_add_free_space(pinned, objectid, 1);
Reviewed-by: Jan Schmidt list.bt...@jan-o-sch.net
... although this is not the most beautiful commit message I've ever seen ;-)
-Jan
--
To unsubscribe from this list: send the line unsubscribe linux-btrfs in
the body of a message to majord...@vger.kernel.org
-by: Jan Schmidt list@jan-o-sch.net
-Jan
--
To unsubscribe from this list: send the line unsubscribe linux-btrfs in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Basic send / receive functionality test for btrfs. Requires current
version of fsstress built (-x support). Relies on fssum tool but can
skip the test if it failed to build.
Signed-off-by: Jan Schmidt list@jan-o-sch.net
Reviewed-by: Josef Bacik jba...@fusionio.com
---
tests/btrfs/316
- fixed comment in test/btrfs/316's header (314 - 316)
v3-v4:
- build fssum with help of autotools only if libssl is available
- removed clumsy OPT_TARGETS in src/Makefile
- added #define directives for SEEK_DATA and SEEK_HOLE to fssum.c
Jan Schmidt (2):
xfstests: add fssum tool
xfstests btrfs/316
On Fri, August 09, 2013 at 07:25 (+0200), Wang Shilong wrote:
The origin code dealt with 'ref' as following steps:
|-list_del(ref-list)
|-some operations
|-kfree(ref)
If operations failed, it would goto label 'out' without freeing this 'ref'.
and then memory
On Wed, August 07, 2013 at 23:11 (+0200), Josef Bacik wrote:
There is no reason we can't just set the path to blocking and then do normal
GFP_NOFS allocations for these extent buffers. Thanks,
Signed-off-by: Josef Bacik jba...@fusionio.com
---
fs/btrfs/ctree.c | 16
in
extent_buffer_under_io and btrfs_release_extent_buffer_page, you just moved
btrfs_clone_extent_buffer, right? Perhaps --patience or --minimal could do
better? Otherwise,
Reviewed-by: Jan Schmidt list@jan-o-sch.net
Thanks,
-Jan
--
To unsubscribe from this list: send the line unsubscribe linux-btrfs
;
}
default:
Reviewed-by: Jan Schmidt list.bt...@jan-o-sch.net
Thanks,
-Jan
--
To unsubscribe from this list: send the line unsubscribe linux-btrfs in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
Basic send / receive functionality test for btrfs. Requires current
version of fsstress built (-x support). Relies on fssum tool but can
skip the test if it failed to build.
Signed-off-by: Jan Schmidt list@jan-o-sch.net
Reviewed-by: Josef Bacik jba...@fusionio.com
---
tests/btrfs/316
will just be skipped
if fssum wasn't built.
Signed-off-by: Jan Schmidt list@jan-o-sch.net
---
.gitignore|1 +
common/config |2 +
src/Makefile | 11 +-
src/fssum.c | 819 +
4 files changed, 832 insertions(+), 1 deletions
fssum.c comes from as well.
--
v1-v2:
- included fssum
- test number is now 316 (was 314)
v2-v3:
- added missing -lcrypto to build fssum
- removed obsolete change in README now that fssum is included
- fixed comment in test/btrfs/316's header (314 - 316)
Jan Schmidt (2):
xfstests: add fssum
On Thu, August 08, 2013 at 12:24 (+0200), Filipe David Manana wrote:
On Thu, Aug 8, 2013 at 6:04 AM, Wang Shilong wangsl.f...@cn.fujitsu.com
wrote:
find_extent_in_eb() may return ENOMEM, catch this error return value.
Signed-off-by: Wang Shilong wangsl.f...@cn.fujitsu.com
Reviewed-by:
On Thu, August 08, 2013 at 07:04 (+0200), Wang Shilong wrote:
struct __prelim_ref is allocated and freed frequently when
walking backref tree, using slab allocater can not only
speed up allocating but also detect memory leaks.
Signed-off-by: Wang Shilong wangsl.f...@cn.fujitsu.com
On Thu, August 08, 2013 at 15:12 (+0200), Josef Bacik wrote:
On Thu, Aug 08, 2013 at 09:23:06AM +0200, Jan Schmidt wrote:
On Wed, August 07, 2013 at 23:11 (+0200), Josef Bacik wrote:
There is no reason we can't just set the path to blocking and then do normal
GFP_NOFS allocations
On Thu, August 08, 2013 at 16:28 (+0200), David Sterba wrote:
On Thu, Aug 08, 2013 at 09:36:52AM +0200, Jan Schmidt wrote:
Weird patch formatting concerning extent_io.c, I assume there are no changes
in
extent_buffer_under_io and btrfs_release_extent_buffer_page, you just moved
Nice try hiding this one in a dedup patch set, but I finally found it :-)
On Wed, July 31, 2013 at 17:37 (+0200), Liu Bo wrote:
So we don't need to do qgroups accounting trick without enabling quota.
This reduces my tester's costing time from ~28s to ~23s.
Signed-off-by: Liu Bo
On Mon, August 05, 2013 at 16:18 (+0200), Liu Bo wrote:
On Mon, Aug 05, 2013 at 02:34:30PM +0200, Jan Schmidt wrote:
Nice try hiding this one in a dedup patch set, but I finally found it :-)
A, I didn't mean to ;-)
On Wed, July 31, 2013 at 17:37 (+0200), Liu Bo wrote:
So we don't
;
}
ret = ulist_add_merge(refs, ref-parent,
(uintptr_t)ref-inode_list,
The only ret 0 I'm seeing is ENOMEM, so that should be safe.
Reviewed-by: Jan Schmidt list.bt...@jan-o-sch.net
Thanks,
-Jan
--
To unsubscribe from this list: send
Liu Bo right he's going to send
it to 3.10 stable soon.
Thanks,
-Jan
Thanks!
-BJ
- Original Message -
From: Jan Schmidt list.bt...@jan-o-sch.net
Sent: Monday, July 29, 2013 3:21:51 AM
Hi BJ,
[original message rewrapped]
On Thu, July 25, 2013 at 18:32 (+0200), BJ
Hi BJ,
[original message rewrapped]
On Thu, July 25, 2013 at 18:32 (+0200), BJ Quinn wrote:
(Apologies for the double post -- forgot to send as plain text the first time
around, so the list rejected it.)
I see that there's now a btrfs send / receive and I've tried using it, but
I'm getting
-nodes[ulist-nnodes].aux = aux;
Reviewed-by: Jan Schmidt list.bt...@jan-o-sch.net
Josef, how about sending this one for the next 3.11 rc and to 3.10 stable? Any
objections?
-Jan
--
To unsubscribe from this list: send the line unsubscribe linux-btrfs in
the body of a message to majord
in the far-progs repository where fssum.c comes from as well.
Jan Schmidt (2):
xfstests: add fssum tool
xfstests btrfs/316: test send / receive
.gitignore |1 +
README |3 +
common/config |2 +
src/Makefile| 11 +-
src/fssum.c | 819
Basic send / receive functionality test for btrfs. Requires current
version of fsstress built (-x support). Relies on fssum tool but can
skip the test if it failed to build.
Signed-off-by: Jan Schmidt list@jan-o-sch.net
---
README |3 +
tests/btrfs/316 | 113
with extent buffer leak.
Signed-off-by: Liu Bo bo.li@oracle.com
Reviewed-by: Jan Schmidt list.bt...@jan-o-sch.net
---
fs/btrfs/ctree.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/btrfs/ctree.c b/fs/btrfs/ctree.c
index 02fae7f..3d790b4 100644
--- a/fs/btrfs
On Sun, June 30, 2013 at 15:55 (+0200), Josef Bacik wrote:
On Sun, Jun 30, 2013 at 10:25:05AM +0200, Jan Schmidt wrote:
On 30.06.2013 05:17, Josef Bacik wrote:
We need to hold the tree mod log lock in __tree_mod_log_rewind since we walk
forward in the tree mod entries, otherwise we'll end up
On Mon, July 01, 2013 at 22:25 (+0200), Josef Bacik wrote:
Previously we held the tree mod lock when adding stuff because we use it to
check and see if we truly do want to track tree modifications. This is
admirable, but GFP_ATOMIC in a critical area that is going to get hit pretty
hard and
in __tree_mod_log_rewind. Thanks,
Signed-off-by: Josef Bacik jba...@fusionio.com
Strange that never really popped up largely so far, should be quite easy to hit.
Anyway,
Reviewed-by: Jan Schmidt list.bt...@jan-o-sch.net
---
fs/btrfs/ctree.c |3 ++-
1 files changed, 2 insertions(+), 1
On 30.06.2013 05:17, Josef Bacik wrote:
We need to hold the tree mod log lock in __tree_mod_log_rewind since we walk
forward in the tree mod entries, otherwise we'll end up with random entries
and
trip the BUG_ON() at the front of __tree_mod_log_rewind. This fixes the
panics
people were
Hi Chris,
I know, Linus is turning grumpy again. I'd still feel better if we sent this
patch set for the very next rc now. Any particular objections?
-Jan
On Tue, May 28, 2013 at 17:47 (+0200), Jan Schmidt wrote:
Here are three fixes for the new qgroup rescan feature. The first two
are quite
(cc Arne for far-progs discussion)
On Thu, June 06, 2013 at 19:54 (+0200), Eric Sandeen wrote:
On 6/6/13 10:20 AM, Jan Schmidt wrote:
Basic send / receive functionality test for btrfs. Requires current
version of fsstress built (-x support). Relies on fssum tool, which is
not part of the test
On Fri, June 07, 2013 at 16:51 (+0200), Arne Jansen wrote:
On 07.06.2013 16:50, Eric Sandeen wrote:
On 6/7/13 5:29 AM, Dave Chinner wrote:
On Fri, Jun 07, 2013 at 09:18:58AM +0200, Jan Schmidt wrote:
(cc Arne for far-progs discussion)
On Thu, June 06, 2013 at 19:54 (+0200), Eric Sandeen
Basic send / receive functionality test for btrfs. Requires current
version of fsstress built (-x support). Relies on fssum tool, which is
not part of the test suite but can skip the test if it is missing.
Signed-off-by: Jan Schmidt list@jan-o-sch.net
---
README |3 +
common
change that need not be split artifically in my
opinion.
Jan Schmidt (3):
Btrfs: fix memory patcher through fs_info-qgroup_ulist
Btrfs: avoid double free of fs_info-qgroup_ulist
Btrfs: fix qgroup rescan resume on mount
fs/btrfs/ctree.h |2 +
fs/btrfs/disk-io.c |2 +
fs/btrfs
for (ret 0) would have been the right choice. This commit fixes the check.
Cc: Wang Shilong wangsl-f...@cn.fujitsu.com
Signed-off-by: Jan Schmidt list.bt...@jan-o-sch.net
---
fs/btrfs/qgroup.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/btrfs/qgroup.c b/fs/btrfs
progress during
btrfs_qgroup_account_ref, which is no longer required due to having step 2
from the list above.
As a side effect, this commit prepares to move the rescan start code from
btrfs_run_qgroups (which is run during commit) to a less time critical
section.
Signed-off-by: Jan Schmidt
, turning
the ulist_free in btrfs_free_qgroup_config into a noop.
Cc: Wang Shilong wangsl-f...@cn.fujitsu.com
Signed-off-by: Jan Schmidt list.bt...@jan-o-sch.net
---
fs/btrfs/qgroup.c |8 ++--
1 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/fs/btrfs/qgroup.c b/fs/btrfs/qgroup.c
Hi Wang,
Please have a look at these patches, you should have been CCed but I just
realized git send-email doesn't care about Cc lines in the patch file. Sigh.
Thanks,
-Jan
--
To unsubscribe from this list: send the line unsubscribe linux-btrfs in
the body of a message to
On Thu, May 16, 2013 at 09:19 (+0200), Kai Krakow wrote:
3.9.2 still does not fix anything. I'll go with autodefrag=off for the
moment until I hear some news in that regard. With this new information, is
it still helpful to get a metadata image from me? It should be reproducable
if you
On Fri, May 10, 2013 at 01:30 (+0200), Kai Krakow wrote:
Jan Schmidt list.bt...@jan-o-sch.net schrieb:
Apparently, it's not fixed. The system does not freeze now but it threw
multiple backtraces right in front of my Xorg session. The backtraces
look a little bit different now. Here's what I
On Wed, May 08, 2013 at 02:24 (+0200), Kai Krakow wrote:
Kai Krakow hurikhan77+bt...@gmail.com schrieb:
I can reliably reproduce it from two different approaches. I'd like to
only apply the commits fixing it. Can you name them here?
In git log order:
6ced2666 Btrfs: separate sequence
On Mon, May 06, 2013 at 22:29 (+0200), Kai Krakow wrote:
Jan Schmidt list.bt...@jan-o-sch.net schrieb:
That one should be fixed in btrfs-next. If you can reliably reproduce the
bug I'd be glad to get a confirmation - you can probably even save putting
it on bugzilla then ;-)
I can
On Mon, May 06, 2013 at 23:20 (+0200), David Sterba wrote:
On Mon, May 06, 2013 at 09:14:17PM +0200, Jan Schmidt wrote:
--- a/include/uapi/linux/btrfs.h
+++ b/include/uapi/linux/btrfs.h
@@ -530,6 +530,7 @@ struct btrfs_ioctl_send_args {
struct
don't need hold qgroup_rescan_lock
when doing qgroup accounting.
NAK.
After a discussion on that lock the last thing in this thread I see is ...
On Wed, May 01, 2013 at 13:57 (+0200), Jan Schmidt wrote:
Now I see what you mean. The second check is only required when we start
a rescan operation
On Tue, May 07, 2013 at 08:20 (+0200), Wang Shilong wrote:
If you look the code carefully, you will see all the tree_mod_alloc()
has to use GFP_ATOMIC. However, the original code pass the wrong arg
gfp_t in some places, this dosen't cause any problems, because in the
tree_mod_alloc(), it
the commits mentioned
in my previous email today:
On Tue, May 07, 2013 at 08:08 (+0200), Jan Schmidt wrote:
In git log order:
6ced2666 Btrfs: separate sequence numbers for delayed ref tracking and tree
mod log
ef9120b1 Btrfs: fix tree mod log regression on root split operations
2ed098ca Btrfs: fix
On Sun, May 05, 2013 at 15:58 (+0200), Wang Shilong wrote:
It seems the original code doesn't pass the right arg gfp_t to decide how to
allocate.
Just applying this patch, fsstress will fail. So please ignore this patch,
will resend later..
That's in fact what the comment above the line you
On Sun, May 05, 2013 at 12:07 (+0200), Kai Krakow wrote:
I'm using an bash/rsync script[1] to backup my whole system on a nightly
basis to an attached USB3 drive into a scratch area, then take a snapshot of
this area. I'd like to have these snapshots immutable, so they should be
read-only.
On Sun, May 05, 2013 at 18:10 (+0200), Kai Krakow wrote:
Hello list,
Kai Krakow hurikhan77+bt...@gmail.com schrieb:
I've upgraded to 3.9.0 mainly for the snapshot-aware defragging patches.
I'm running bedup[1] on a regular basis and it is now the third time that
I got back to my PC just
Two small patches, one for the kernel and one for the user mode. Both
required to support waiting for quota rescan to complete.
Jan Schmidt (1):
Btrfs: add ioctl to wait for qgroup rescan completion
fs/btrfs/ctree.h |2 ++
fs/btrfs/ioctl.c | 12
fs/btrfs
With -w one can wait for a rescan operation to finish. It can be used when
starting a rescan operation or later to wait for the currently running
rescan operation to finish. Waiting is interruptible.
Signed-off-by: Jan Schmidt list.bt...@jan-o-sch.net
---
cmds-quota.c | 19
The patch set previously sent was sent together with the kernel part, but
was not updated as I added some reserved bytes to the ioctl struct for
future compatibility. This fixes struct btrfs_ioctl_quota_rescan_args.
Signed-off-by: Jan Schmidt list.bt...@jan-o-sch.net
---
ioctl.h |1 +
1
btrfs_qgroup_wait_for_completion waits until the currently running qgroup
operation completes. It returns immediately when no rescan process is in
progress. This is useful to automate things around the rescan process (e.g.
testing).
Signed-off-by: Jan Schmidt list.bt...@jan-o-sch.net
---
fs
.
A filesystem under rescan can still be umounted. The rescan continues on the
next mount. Status information is provided with a separate ioctl while a
rescan operation is in progress.
Signed-off-by: Jan Schmidt list.bt...@jan-o-sch.net
---
fs/btrfs/ctree.h | 17 ++-
fs/btrfs/disk-io.c
operation and should not be used unless required.
A filesystem under rescan can still be umounted. The rescan continues on
the
next mount. Status information is provided with a separate ioctl while a
rescan operation is in progress.
Signed-off-by: Jan Schmidt list.bt...@jan-o-sch.net
---
fs
Hi Josef,
tried your btrfs-image tool (which didn't work for me but that's not that
important).
# ~/btrfs-image /dev/sdt1 /var/tmp/janosch.btrfsimage
# mount -o loop /var/tmp/janosch.btrfsimage /mnt/test
mount: you must specify the filesystem type
Doesn't mount, okay. Use -r:
# ~/btrfs-image
On Fri, April 26, 2013 at 07:29 (+0200), Eric Sandeen wrote:
Tests after 276 were failing because the background fsstress
hadn't quit prior to exit, devices couldn't be unmounted, etc.
I don't see how that would happen. Any further insight?
Just use the same trick as generic/068 does, and use
The function is separated into a preparation part and the three accounting
steps mentioned in the qgroups documentation. The goal is to make steps two
and three usable by the rescan functionality. A side effect is that the
function is restructured into readable subunits.
Signed-off-by: Jan
When qgroup tracking is enabled, we do an automatic cycle of the new rescan
mechanism.
Signed-off-by: Jan Schmidt list.bt...@jan-o-sch.net
---
fs/btrfs/qgroup.c | 11 +++
1 files changed, 11 insertions(+), 0 deletions(-)
diff --git a/fs/btrfs/qgroup.c b/fs/btrfs/qgroup.c
index 664d457
on the
next mount. Status information is provided with a separate ioctl while a
rescan operation is in progress.
Signed-off-by: Jan Schmidt list.bt...@jan-o-sch.net
---
fs/btrfs/ctree.h | 17 ++-
fs/btrfs/disk-io.c |5 +
fs/btrfs/ioctl.c | 83 ++--
fs/btrfs
On Wed, April 24, 2013 at 10:12 (+0200), Liu Bo wrote:
On Tue, Apr 23, 2013 at 08:00:27PM +0200, Jan Schmidt wrote:
Sequence numbers for delayed refs have been introduced in the first version
of the qgroup patch set. To solve the problem of find_all_roots on a busy
file system, the tree mod
On Wed, April 24, 2013 at 15:04 (+0200), Josef Bacik wrote:
On Tue, Apr 23, 2013 at 12:00:27PM -0600, Jan Schmidt wrote:
Sequence numbers for delayed refs have been introduced in the first version
of the qgroup patch set. To solve the problem of find_all_roots on a busy
file system, the tree
On Wed, April 24, 2013 at 13:00 (+0200), Wang Shilong wrote:
Hello Jan,
[snip]
+/*
+ * returns 0 on error, 0 when more leafs are to be scanned.
+ * returns 1 when done, 2 when done and FLAG_INCONSISTENT was cleared.
+ */
+static int
+qgroup_rescan_leaf(struct qgroup_rescan *qscan,
wrong and WARN_ONs
from the tree mod log code may happen.
Signed-off-by: Jan Schmidt list.bt...@jan-o-sch.net
---
Changes v1-v2:
- added spin lock and comment around btrfs_inc_tree_mod_seq_minor (to make
Josef happy in case I get hit by a bus and somebody tries to change it
later)
fs/btrfs
When qgroup tracking is enabled, we do an automatic cycle of the new rescan
mechanism.
Signed-off-by: Jan Schmidt list.bt...@jan-o-sch.net
---
fs/btrfs/qgroup.c | 10 ++
1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/fs/btrfs/qgroup.c b/fs/btrfs/qgroup.c
index 249dd64
The function is separated into a preparation part and the three accounting
steps mentioned in the qgroups documentation. The goal is to make steps two
and three usable by the rescan functionality. A side effect is that the
function is restructured into readable subunits.
Signed-off-by: Jan
checking
- add some reserved ints to struct btrfs_ioctl_quota_rescan_args
- changed modification to unused #define BTRFS_QUOTA_CTL_RESCAN
- added missing (unsigned long long) casts for pr_debug
- more detailed commit messages
Jan Schmidt (3):
Btrfs: split btrfs_qgroup_account_ref into four
on the
next mount. Status information is provided with a separate ioctl while a
rescan operation is in progress.
Signed-off-by: Jan Schmidt list.bt...@jan-o-sch.net
---
fs/btrfs/ctree.h | 17 ++-
fs/btrfs/disk-io.c |5 +
fs/btrfs/ioctl.c | 83 ++--
fs/btrfs
On Tue, April 23, 2013 at 14:05 (+0200), Wang Shilong wrote:
Hello Jan,
[..snip..]
/*
* the delayed ref sequence number we pass depends on the direction of
* the operation. for add operations, we pass (node-seq - 1) to skip
@@ -1401,7 +1428,17 @@ int
On Tue, April 23, 2013 at 17:36 (+0200), David Sterba wrote:
On Tue, Apr 23, 2013 at 01:26:51PM +0200, Jan Schmidt wrote:
--- a/fs/btrfs/qgroup.c
+++ b/fs/btrfs/qgroup.c
@@ -1494,10 +1494,14 @@ int btrfs_run_qgroups(struct btrfs_trans_handle
*trans,
{
struct btrfs_root *quota_root
On Tue, April 23, 2013 at 16:54 (+0200), Wang Shilong wrote:
Hello Jan,
+static void btrfs_qgroup_rescan_worker(struct btrfs_work *work)
+{
+struct qgroup_rescan *qscan = container_of(work, struct qgroup_rescan,
+ work);
+struct
and WARN_ONs
from the tree mod log code may happen.
Signed-off-by: Jan Schmidt list.bt...@jan-o-sch.net
---
fs/btrfs/ctree.c | 36 +---
fs/btrfs/ctree.h |7 ++-
fs/btrfs/delayed-ref.c |6 --
fs/btrfs/disk-io.c |2 +-
fs/btrfs
On Fri, April 19, 2013 at 07:57 (+0200), Tejun Heo wrote:
(cc'ing btrfs people)
On Fri, Apr 19, 2013 at 11:33:20AM +0800, Wanlong Gao wrote:
RIP: 0010:[812484d3] [812484d3]
ftrace_raw_event_block_bio_complete+0x73/0xf0
...
[811b6c10] bio_endio+0x80/0x90
On Tue, April 16, 2013 at 14:22 (+0200), Wang Shilong wrote:
Hello Jan, more comments below..
[...snip..]
+
+static long btrfs_ioctl_quota_rescan_status(struct file *file, void __user
*arg)
+{
+struct btrfs_root *root = BTRFS_I(fdentry(file)-d_inode)-root;
+struct
On Tue, April 16, 2013 at 10:40 (+0200), Liu Bo wrote:
We need such a sanity check for wrong start, otherwise, even with
a wrong start that's larger than file size, we can end up not only
changing inode's force compress flag but also FS's incompat flags.
That reads out very cryptic. Can you
(unsigned long long) casts for pr_debug
- more detailed commit messages
Jan Schmidt (3):
Btrfs: split btrfs_qgroup_account_ref into four functions
Btrfs: rescan for qgroups
Btrfs: automatic rescan after quota enable command
fs/btrfs/ctree.h | 17 +-
fs/btrfs/disk-io.c
on the
next mount. Status information is provided with a separate ioctl while a
rescan operation is in progress.
Signed-off-by: Jan Schmidt list.bt...@jan-o-sch.net
---
fs/btrfs/ctree.h | 17 ++-
fs/btrfs/disk-io.c |6 +
fs/btrfs/ioctl.c | 83 ++--
fs/btrfs
When qgroup tracking is enabled, we do an automatic cycle of the new rescan
mechanism.
Signed-off-by: Jan Schmidt list.bt...@jan-o-sch.net
---
fs/btrfs/qgroup.c | 10 ++
1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/fs/btrfs/qgroup.c b/fs/btrfs/qgroup.c
index bb081b5
The function is separated into a preparation part and the three accounting
steps mentioned in the qgroups documentation. The goal is to make steps two
and three usable by the rescan functionality. A side effect is that the
function is restructured into readable subunits.
Signed-off-by: Jan
On Tue, April 16, 2013 at 11:20 (+0200), Wang Shilong wrote:
Hello Jan,
The function is separated into a preparation part and the three accounting
steps mentioned in the qgroups documentation. The goal is to make steps two
and three usable by the rescan functionality. A side effect is that
.
A filesystem under rescan can still be umounted. The rescan continues on the
next mount. Status information is provided with a separate ioctl while a
rescan operation is in progress.
Signed-off-by: Jan Schmidt list.bt...@jan-o-sch.net
---
fs/btrfs/ctree.h | 17 ++-
fs/btrfs
On Tue, April 16, 2013 at 12:08 (+0200), Wang Shilong wrote:
Hello Jan,
slot = path-slots[0];
ptr = btrfs_item_ptr(l, slot, struct btrfs_qgroup_status_item);
+spin_lock(fs_info-qgroup_lock);
Why we need hold qgroup_lock here? would you please explain...
It would have
On Mon, April 15, 2013 at 08:08 (+0200), Wang Shilong wrote:
Hello Jan,
On Mon, April 15, 2013 at 07:44 (+0200), Jan Schmidt wrote:
Thanks, v2 to come.
Uh, but not immediately. I didn't get tracking of exclusive right. That
will
need some time to fix and test.
'exclusive' adds
On Mon, April 15, 2013 at 07:44 (+0200), Jan Schmidt wrote:
Thanks, v2 to come.
Uh, but not immediately. I didn't get tracking of exclusive right. That will
need some time to fix and test.
-Jan
--
To unsubscribe from this list: send the line unsubscribe linux-btrfs in
the body of a message
The tree mod log functions were accessing root-node-... directly, without
use of btrfs_root_node() or explicit rcu locking. This could lead to an
extent buffer reference being leaked and another reference being freed too
early when preemtion was enabled.
Signed-off-by: Jan Schmidt list.bt...@jan
applied, I've been running my tests for more
than a day without any issues, while without, it takes only minutes to
trigger a BUG_ON or WARN_ON.
Jan Schmidt (3):
Btrfs: fix tree mod log regression on root split operations
Btrfs: fix accessing the root pointer in tree mod log functions
Btrfs: fix
removes the erroneous logging of removal of all elements.
Signed-off-by: Jan Schmidt list.bt...@jan-o-sch.net
---
fs/btrfs/ctree.c | 55 -
1 files changed, 29 insertions(+), 26 deletions(-)
diff --git a/fs/btrfs/ctree.c b/fs/btrfs/ctree.c
index
On Fri, April 12, 2013 at 06:13 (+0200), Miao Xie wrote:
Onthu, 11 Apr 2013 16:29:48 +0200, Jan Schmidt wrote:
On Thu, April 11, 2013 at 12:35 (+0200), Miao Xie wrote:
Now, we set incompat flag EXTEND_IREF when we actually need insert a
extend inode reference, not when making a fs
*/
};
struct ulist {
@@ -54,6 +58,8 @@ struct ulist {
*/
struct ulist_node *nodes;
+ struct rb_root root;
+
/*
* inline storage space for the first ULIST_SIZE entries
*/
Makes a lot of sense. Thanks!
Reviewed-by: Jan Schmidt list.bt...@jan-o
On Thu, April 11, 2013 at 12:28 (+0200), Miao Xie wrote:
There is no extended irefs in the new fs, and we can mount it on
the old kernel without extended iref function safely. So we needn't
set INCOMPAT_EXTENDED_IREF flag when making a new fs, and just set
it when we actually insert a extended
On Thu, April 11, 2013 at 12:35 (+0200), Miao Xie wrote:
Now, we set incompat flag EXTEND_IREF when we actually need insert a
extend inode reference, not when making a fs. But some users may hope
that the fs still can be mounted on the old kernel, and don't hope we
insert any extend inode
On Wed, April 10, 2013 at 09:58 (+0200), Ahmet Inan wrote:
I got this problem since 3.8.5 + for-linus (from that time).
Have just tried 3.8.6 + for-linus with git merge -X theirs
btrfs/for-linus but still same problem.
Going back to 3.7.4 + for-linus (from that time) doesn't give me the
I was running fsstress to trigger a tree mod log problem on a current kernel
with some custom debug patches applied, so if anyone looking at this needs any
line numbers let me know:
4[ 1221.749586] [ INFO: possible circular locking dependency detected ]
4[ 1221.749589] 3.8.0+ #9 Not tainted
4[
On 06.04.2013 20:30, Eric Sandeen wrote:
From: Mark Fasheh mfas...@suse.de
btrfs-progs: re-add send-test
send-test.c links against libbtrfs and uses the send functionality provided
to decode and print a send stream to the console.
This looks pretty much like fardump from Arne's far
1 - 100 of 517 matches
Mail list logo
