Linux 2.6.24 sata_promise SATA300TX4 problems

2008-01-26 Thread Peter Favrholdt
Hi Mikael list, I have previously reported problems with my setup: SATA300TX4 + 4 Seagate Barracuda ES 500GB I just tested with 2.6.24. After copying approx 25GB of each drive using dd if=/dev/sd[abcd] of=/dev/null bs=1M sda failed with the following message: [ 1060.069489] ata1: SError: {

Re: [PATCH 02/14] sata_mv Mask transient IRQs.

2008-01-26 Thread Mark Lord
Jeff Garzik wrote: Mark Lord wrote: sata_mv Mask transient IRQs. The chips can handle many transient errors internally without a software IRQ. We now mask/ignore those interrupts here. This is necessary for NCQ, later on. Signed-off-by: Mark Lord [EMAIL PROTECTED] ---

Re: [PATCH 05/14] sata_mv Fix EDMA configuration

2008-01-26 Thread Mark Lord
Jeff Garzik wrote: Mark Lord wrote: sata_mv Fix EDMA configuration. Simplify and fix EDMA configuration setup to match Marvell specificiations. The chip documentation gives a specific (re)init sequence, which we now follow. Signed-off-by: Mark Lord [EMAIL PROTECTED] ---

Re: [PATCH 07/14] sata_mv Use hqtag instead of ioid

2008-01-26 Thread Mark Lord
Jeff Garzik wrote: Mark Lord wrote: sata_mv Use hqtag instead of ioid. Simplify tag handling by using the cid/hqtag field instead of ioid, as recommended by Marvell. Signed-off-by: Mark Lord [EMAIL PROTECTED] --- old/drivers/ata/sata_mv.c2008-01-24 12:07:16.0 -0500 +++

Re: [PATCH 10/14] sata_mv Use DMA memory pools for hardware memory tables

2008-01-26 Thread Mark Lord
Jeff Garzik wrote: Mark Lord wrote: .. static int __init mv_init(void) { +/* Ideally, a device (second parameter) would own these pools. + * But for maximum memory efficiency, we really need one global + * set of each, shared among all like devices. As below. + */ +

Re: [PATCH 10/14] sata_mv Use DMA memory pools for hardware memory tables

2008-01-26 Thread Mark Lord
Jeff Garzik wrote: .. The amount of memory used in the pre-existing configuration is small, it is already allocated on a per-device basis, and it is statically allocated -- meaning no worry about allocations failing inside of interrupts or similar nastiness. .. Note that there's also no

Re: [PATCH 13/14] sata_mv No soft resets

2008-01-26 Thread Mark Lord
Jeff Garzik wrote: Mark Lord wrote: sata_mv No soft resets. Soft resets rarely have significant effect with these chips, so always do a hard reset instead. Signed-off-by: Mark Lord [EMAIL PROTECTED] --- old/drivers/ata/sata_mv.c2008-01-24 14:49:28.0 -0500 +++

Re: [PATCH 10/14] sata_mv Use DMA memory pools for hardware memory tables

2008-01-26 Thread Mark Lord
Mark Lord wrote: Jeff Garzik wrote: Mark Lord wrote: .. static int __init mv_init(void) { +/* Ideally, a device (second parameter) would own these pools. + * But for maximum memory efficiency, we really need one global + * set of each, shared among all like devices. As below. +

Re: [PATCH 10/14] sata_mv Use DMA memory pools for hardware memory tables

2008-01-26 Thread Jeff Garzik
Mark Lord wrote: Just say exactly what you require here. And keep in mind that any change I make incurs a 2-day wait while the Marvell folks vet it again (not my choice). (about to go to sleep, so the rest must wait) Bandwidth and mailing list archives are cheap, emailing is scriptable and

libata pm

2008-01-26 Thread [EMAIL PROTECTED]
I'm currently running Linux *** 2.6.23 #1 SMP PREEMPT Sat Jan 26 17:59:58 CET 2008 x86_64 Intel(R) Pentium(R) D CPU 3.20GHz GenuineIntel GNU/Linux with the libata-tj-2.6.23-20071011 path for 2.6.23 and for testing purposes linux-2.6.24-rc6-mm1 on a Asus P5WDG2-WS with two PCI-X Dawicontrol DC

Re: [PATCH 21/21] ide: make remaining built-in only IDE host drivers modular

2008-01-26 Thread Bartlomiej Zolnierkiewicz
Hi, On Friday 04 January 2008, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: * Make remaining built-in only IDE host drivers modular, add ide-scan-pci.c file for probing PCI host drivers registered with IDE core (special case for built-in IDE and

Re: libata pm

2008-01-26 Thread [EMAIL PROTECTED]
I could solve the problem by ncq blacklisting the Maxtor 6V300F0 devices in libata-core.c Am Sa, 26.01.2008, 18:03, schrieb [EMAIL PROTECTED]: I'm currently running Linux *** 2.6.23 #1 SMP PREEMPT Sat Jan 26 17:59:58 CET 2008 x86_64 Intel(R) Pentium(R) D CPU 3.20GHz GenuineIntel GNU/Linux

Re: [PATCH 10/14] sata_mv Use DMA memory pools for hardware memory tables

2008-01-26 Thread Mark Lord
Jeff Garzik wrote: Mark Lord wrote: Just say exactly what you require here. .. .. repost the whole thing .. .. Okay, will do in a couple of days. -ml - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: From: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] (linux.* mail to news gateway)

2008-01-26 Thread Frans Pop
config BLK_DEV_IDE_PMAC - bool Builtin PowerMac IDE support + tristate Builtin PowerMac IDE support This does not seem to make sense: if the option is now tristate, it is no longer Builtin, so probably s/Builtin // in the description. Cheers, FJP - To unsubscribe from this list:

Re: From: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] (linux.* mail to news gateway)

2008-01-26 Thread Jan Engelhardt
On Jan 26 2008 21:31, Frans Pop wrote: config BLK_DEV_IDE_PMAC - bool Builtin PowerMac IDE support + tristate Builtin PowerMac IDE support This does not seem to make sense: if the option is now tristate, it is no longer Builtin, so probably s/Builtin // in the description. Or

Re: From: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] (linux.* mail to news gateway)

2008-01-26 Thread Bartlomiej Zolnierkiewicz
On Saturday 26 January 2008, Jan Engelhardt wrote: On Jan 26 2008 21:31, Frans Pop wrote: config BLK_DEV_IDE_PMAC - bool Builtin PowerMac IDE support + tristate Builtin PowerMac IDE support this change is no-op at the moment because the next Kconfig line is: depends

[PATCH 02/13] sata_mv ncq Mask transient IRQs

2008-01-26 Thread Mark Lord
The chips can handle many transient errors internally without a software IRQ. We now mask/ignore those interrupts here. This is necessary for NCQ, later on. Signed-off-by: Mark Lord [EMAIL PROTECTED] --- old/drivers/ata/sata_mv.c 2008-01-24 11:11:26.0 -0500 +++

[PATCH 03/13] sata_mv ncq Rename base to port mmio

2008-01-26 Thread Mark Lord
Use naming consistent with elsewhere in this driver. This will keep things less confusing when we later add hc_mmio in this function. Signed-off-by: Mark Lord [EMAIL PROTECTED] --- old/drivers/ata/sata_mv.c 2008-01-24 11:23:05.0 -0500 +++ new/drivers/ata/sata_mv.c 2008-01-24

[PATCH 04/13] sata_mv ncq Fix EDMA configuration

2008-01-26 Thread Mark Lord
Simplify and fix EDMA configuration setup to match Marvell specificiations. The chip documentation gives a specific (re)init sequence, which we now follow. Signed-off-by: Mark Lord [EMAIL PROTECTED] --- old/drivers/ata/sata_mv.c 2008-01-24 12:06:25.0 -0500 +++

[PATCH 05/13] sata_mv ncq Add want ncq parameter for EDMA configuration

2008-01-26 Thread Mark Lord
An extra EDMA config bit is required for NCQ operation. So set/clear it as needed, and cache current setting in port_priv. For now though, it will always be off (0). Signed-off-by: Mark Lord [EMAIL PROTECTED] --- old/drivers/ata/sata_mv.c 2008-01-24 12:12:37.0 -0500 +++

[PATCH 06/13] sata_mv ncq Use hqtag instead of ioid

2008-01-26 Thread Mark Lord
Simplify tag handling by using the cid/hqtag field instead of ioid, as recommended by Marvell. Signed-off-by: Mark Lord [EMAIL PROTECTED] --- old/drivers/ata/sata_mv.c 2008-01-26 10:46:58.0 -0500 +++ new/drivers/ata/sata_mv.c 2008-01-26 10:47:35.0 -0500 @@ -1252,7 +1252,6

[PATCH 07/13] sata_mv ncq Ignore response status LSB on NCQ

2008-01-26 Thread Mark Lord
The lower 8 bits of response status are not valid for NCQ. Signed-off-by: Mark Lord [EMAIL PROTECTED] --- old/drivers/ata/sata_mv.c 2008-01-24 12:35:14.0 -0500 +++ new/drivers/ata/sata_mv.c 2008-01-24 12:35:43.0 -0500 @@ -1587,13 +1587,12 @@ qc =

[PATCH 08/13] sata_mv ncq Restrict max sectors to 8-bits on GenII NCQ

2008-01-26 Thread Mark Lord
The GenII chips have only 8-bits for the sector_count field when performing NCQ. Add a dev_config method to restrict this when necessary, taking care not to override any other restriction already in place (likely none, but someday.. ?). Signed-off-by: Mark Lord [EMAIL PROTECTED] ---

[PATCH 09/13] sata_mv ncq Use DMA memory pools for hardware memory tables

2008-01-26 Thread Mark Lord
Create host-owned DMA memory pools, for use in allocating/freeing per-port command/response queues and SG tables. This gives us a way to guarantee we meet the hardware address alignment requirements, and also reduces memory that might otherwise be wasted on alignment gaps. Signed-off-by: Mark

[PATCH 10/13] sata_mv ncq Introduce per-tag SG tables

2008-01-26 Thread Mark Lord
In preparation for supporting NCQ, we must allocate separate SG tables for each command tag, rather than just a single table per port as before. Gen-I hardware cannot do NCQ, though, so we still allocate just a single table for that, but populate it in all 32 slots to avoid special-cases

[PATCH 11/13] sata_mv ncq Enable NCQ operation

2008-01-26 Thread Mark Lord
Final changes to actually turn on NCQ in the driver for GEN_II/IIE hardware. Signed-off-by: Mark Lord [EMAIL PROTECTED] --- old/drivers/ata/sata_mv.c 2008-01-26 12:41:01.0 -0500 +++ new/drivers/ata/sata_mv.c 2008-01-26 12:43:21.0 -0500 @@ -510,7 +510,8 @@ .name

[PATCH 12/13] sata_mv ncq Remove post internal cmd op

2008-01-26 Thread Mark Lord
This driver currently has no need for the .post_internal_cmd op. So get rid of it, to save unnecessary transitions between EDMA and non-EDMA modes. Signed-off-by: Mark Lord [EMAIL PROTECTED] --- old/drivers/ata/sata_mv.c 2008-01-26 18:11:17.0 -0500 +++ new/drivers/ata/sata_mv.c

[PATCH 13/13] sata_mv ncq Comments and version bump

2008-01-26 Thread Mark Lord
Remove some obsolete comments, and bump up the driver version number. Signed-off-by: Mark Lord [EMAIL PROTECTED] --- old/drivers/ata/sata_mv.c 2008-01-26 11:05:54.0 -0500 +++ new/drivers/ata/sata_mv.c 2008-01-26 11:12:32.0 -0500 @@ -29,7 +29,13 @@ I distinctly remember a

Re: Linux 2.6.24 sata_promise SATA300TX4 problems

2008-01-26 Thread Mikael Pettersson
Peter Favrholdt writes: Hi Mikael list, I have previously reported problems with my setup: SATA300TX4 + 4 Seagate Barracuda ES 500GB I just tested with 2.6.24. After copying approx 25GB of each drive using dd if=/dev/sd[abcd] of=/dev/null bs=1M sda failed with the following

Re: Linux 2.6.24 sata_promise SATA300TX4 problems

2008-01-26 Thread Peter Favrholdt
Hi Mikael, Thanks for your reply :-) Mikael Pettersson wrote: Mysterious. What you have there is a transmission error between the controller and the disk, which is bad in and by itself, but then there's a sequence of COMRESETs that fail to bring the port or disk back to life. The original

Re: libata pm

2008-01-26 Thread [EMAIL PROTECTED]
Am Sa, 26.01.2008, 23:33, schrieb Tejun Heo: [EMAIL PROTECTED] wrote: I could solve the problem by ncq blacklisting the Maxtor 6V300F0 devices in libata-core.c That's a strange story. The reported error was PHY readiness changed and Device exchanged, both of which point to hotplug event.

Re: Linux 2.6.24 sata_promise SATA300TX4 problems

2008-01-26 Thread Mikael Pettersson
Peter Favrholdt writes: Hi Mikael, Thanks for your reply :-) Mikael Pettersson wrote: Mysterious. What you have there is a transmission error between the controller and the disk, which is bad in and by itself, but then there's a sequence of COMRESETs that fail to bring the