On Mon, Feb 25, 2008 at 8:31 AM, Ingo Molnar [EMAIL PROTECTED] wrote:
* Paolo Ciarrocchi [EMAIL PROTECTED] wrote:
Before:
total: 34 errors, 14 warnings, 456 lines checked
After:
total: 0 errors, 8 warnings, 456 lines checked
sidenote: please also indicate to maintainers that
Hi!
This is a patch (very ugly, assumes you have just one disk) to bring
powersaving to AHCI. You need Alan's SCSI autosuspend (attached) patch
as a base.
It saves .5W compared to config with disk spinning, and even .15W
compared to hdparm -y... on my thinkpad x60 anyway.
It is also mandatory
On Mon, Feb 25, 2008 at 03:57:06PM +1000, Brad Rosser wrote:
Hi Boris,
Well, this sounds strange. Are you sure you're entering the boot options
correctly on the kernel command line? Which is your boot loader? I just
booted
my machine with 'hdc=noprobe' (hdc is my cdrom drive) and
James Bottomley wrote:
I keep hearing that we need to convert libsas to use libata's new error
handling. Unfortunately, I have very little conception of what that
means. Right at the moment, libsas doesn't use any error handling
functions of libata at all.
I've looked through the
Tejun Heo wrote:
Mark Lord wrote:
..
But no big deal. I can clone code and not bother you any more.
In fact, some of the cloned code was already in sata_mv, and I removed
it this past week in my local working copy. I'll just restore that,
along with another big blob so that we can select pm
On Mon, 2008-02-25 at 10:34 -0600, Brian King wrote:
The new libata-eh is used for more than just EH. It is used for device
probing, device revalidation, and power management. It is also woken for
all command failures and is where the request sense for ATAPI devices is
issued. Device
James Bottomley wrote:
On Mon, 2008-02-25 at 10:34 -0600, Brian King wrote:
The new libata-eh is used for more than just EH. It is used for device
probing, device revalidation, and power management. It is also woken for
all command failures and is where the request sense for ATAPI devices is
Does anyone have in their posession the old errata docs for the HPT370
controller. I'm seeing two reports now where there is some kind of FIFO
corruption pattern (shifted data and duplicated dwords) on the drives
which are UDMA100 blacklisted, so presumably more is required for the
workaround.
Paolo Ciarrocchi wrote:
File is now error free, only a few
WARNING: line over 80 characters
are left.
Compile tested.
Signed-off-by: Paolo Ciarrocchi [EMAIL PROTECTED]
Acked-by: Sergei Shtylyov [EMAIL PROTECTED]
MBR, Sergei
-
To unsubscribe from this list: send the line unsubscribe
On my T61p, 2.6.25-rc2 seems to wake up fine from suspend to ram.
Not so 2.6.25-rc3: it hangs on suspend to ram, with a blank screen.
At one point I got lucky and got this on console (wrote down by hand,
there could be typos):
ata1: COMRESET failed (errno=-16)
ata1: COMRESET failed (errno=-16)
On Monday, 25 of February 2008, Michael S. Tsirkin wrote:
On my T61p, 2.6.25-rc2 seems to wake up fine from suspend to ram.
Not so 2.6.25-rc3: it hangs on suspend to ram, with a blank screen.
Thanks for the report.
At one point I got lucky and got this on console (wrote down by hand,
there
Michael S. Tsirkin wrote:
git bisect points at this commit:
commit 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2.
power_state: get rid of write-only variable in SATA
Hello Pavel --
It looks like this not a write-only variable after all...
Jeff
-
To unsubscribe from this list: send the
On Monday 25 February 2008, Rafael J. Wysocki wrote:
On Monday, 25 of February 2008, Michael S. Tsirkin wrote:
On my T61p, 2.6.25-rc2 seems to wake up fine from suspend to ram.
Not so 2.6.25-rc3: it hangs on suspend to ram, with a blank screen.
Thanks for the report.
At one point I got
Alan Cox wrote:
Does anyone have in their posession the old errata docs for the HPT370
controller. I'm seeing two reports now where there is some kind of FIFO
corruption pattern (shifted data and duplicated dwords) on the drives
which are UDMA100 blacklisted, so presumably more is required for
Pavel Machek wrote:
Hi!
This is a patch (very ugly, assumes you have just one disk) to bring
powersaving to AHCI. You need Alan's SCSI autosuspend (attached) patch
as a base.
It saves .5W compared to config with disk spinning, and even .15W
compared to hdparm -y... on my thinkpad x60 anyway.
Hi!
This is a patch (very ugly, assumes you have just one disk) to bring
powersaving to AHCI. You need Alan's SCSI autosuspend (attached) patch
as a base.
It saves .5W compared to config with disk spinning, and even .15W
compared to hdparm -y... on my thinkpad x60 anyway.
..
There was a
On Mon 2008-02-25 16:04:08, Jeff Garzik wrote:
Michael S. Tsirkin wrote:
git bisect points at this commit:
commit 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2.
power_state: get rid of write-only variable in SATA
Hello Pavel --
It looks like this not a write-only variable after all...
Yep,
(additional explanation for the revert is in the full changeset
description)
Please pull from 'upstream-linus' branch of
master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/libata-dev.git
upstream-linus
to receive the following updates:
drivers/ata/libata-core.c |5 -
Mark Lord wrote:
Pavel Machek wrote:
This is a patch (very ugly, assumes you have just one disk) to bring
powersaving to AHCI. You need Alan's SCSI autosuspend (attached) patch
as a base.
It saves .5W compared to config with disk spinning, and even .15W
compared to hdparm -y... on my thinkpad
chaoyang wang wrote:
Dear Jeff,
I was looking at the kernel 2.6.21 code of the achi driver and found
that the sg_table_size was set to 168, while the libata set the maximum
sg to be 128 somewhere else. When a requester issues a request with 128
sgs to the ahci attached device, the system
Saumendra Dash wrote:
Hi Jeff,
I'm working on ULI1575 SATA driver which I want to run in Emulated-PATA
mode.
I have the following understanding to run a SATA device in
Emulated-PATA mode:
1. In Emulated-PATA mode the legacy IDE driver should access the SATA
device directly in combined
On Mon, 25 Feb 2008 20:05:22 +0100 Gerold Jury [EMAIL PROTECTED] wrote:
Hello,
I have two DVD drives, one connected to the SATA port (LG) the other to the
IDE port (PHILIPS) of a via chipset.
They are driven by VIA SATA support (SATA_VIA) and VIA PATA support
(PATA_VIA).
When I write
Jon Li wrote:
Hello,
I am curious as to whether there are plans to add support for integrated
sata devices. I personally want to add support for a 60x1C0 based
device (pci:id = 0x5182). I think adding support should be relatively
simple, except for a few issues outlined below.
In the
Hello, Mark.
Mark Lord wrote:
MMmm.. maybe the vendor unique FIS mechanism of the chipset
can save the scenario here. It would seem to be a reasonable
way to direct a FIS (anything up to 8KB) at a specific pmp,
without changing the default pmp on the channel.
I can have qc_issue use that
Hi all,
at the moment I'm having another go at trying to make the disk shock
protection patch fit for upstream submission. However, there are still
some fundamental issues I'd like to discuss in order to make sure that
I'm heading in the right direction.
The general idea: A daemon running in
Jeff,
We had a discussion here today about IOMMUs,
and they *never* split sg list entries -- they only ever *merge*.
And this happens only after the block layer has
already done merging while respecting q-seg_boundary_mask.
So worst case, the IOMMU may merge everything, and then in
libata we
Elias Oltmanns wrote:
The general idea: A daemon running in user space monitors input data
from an accelerometer. When the daemon detects a critical condition,
i.e., a sudden acceleration (for instance, laptop slides off the desk),
it signals the kernel so the hard disk may be put into a (more)
Jeff Garzik wrote:
Jon Li wrote:
Hello,
I am curious as to whether there are plans to add support for integrated
sata devices. I personally want to add support for a 60x1C0 based
device (pci:id = 0x5182). I think adding support should be relatively
simple, except for a few issues outlined
Tejun Heo wrote:
libata doesn't really put much restrictions on what a LLD should do on
entering EH and if the controller's behavior is predictable, there's no
reason to freeze the port. If the problem is that the DMA engine isn't
usable after PMP error but it's known that the controller isn't
http://bugzilla.kernel.org/show_bug.cgi?id=10086
--- Comment #1 from [EMAIL PROTECTED] 2008-02-24 17:12 ---
Handled-By : Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
--
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
--- You are receiving this mail
Mark Lord wrote:
Jeff Garzik wrote:
Jon Li wrote:
Hello,
I am curious as to whether there are plans to add support for integrated
sata devices. I personally want to add support for a 60x1C0 based
device (pci:id = 0x5182). I think adding support should be relatively
simple, except for a few
The optional .qc_defer() methods don't seem to be called
on the ata_exec_internal_sg() path.
At present, this is probably okay. But in the future,
as we add functionality for link power management
and hotplug polling, this could be a problem.
I think. Or is it possibly also a problem today
As an aside, ISTR tomo-san was working on eliminating the need for the
/2 by tackling the details on the IOMMU side...
Jeff
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
Jeff Garzik wrote:
Mark Lord wrote:
Jeff,
We had a discussion here today about IOMMUs,
and they *never* split sg list entries -- they only ever *merge*.
And this happens only after the block layer has
already done merging while respecting q-seg_boundary_mask.
So worst case, the IOMMU may
Jeff Garzik wrote:
As an aside, ISTR tomo-san was working on eliminating the need for the
/2 by tackling the details on the IOMMU side...
..
Yes, tomo-san just led a nice detailed discussion of it here at LSF'08,
and he agrees that even today it shouldn't affect us that way.
Cheers
-
To
Jeff Garzik [EMAIL PROTECTED] wrote:
Elias Oltmanns wrote:
The general idea: A daemon running in user space monitors input data
from an accelerometer. When the daemon detects a critical condition,
i.e., a sudden acceleration (for instance, laptop slides off the desk),
it signals the kernel so
On Mon, 2008-02-25 at 19:15 -0500, Jeff Garzik wrote:
Mark Lord wrote:
Jeff,
We had a discussion here today about IOMMUs,
and they *never* split sg list entries -- they only ever *merge*.
And this happens only after the block layer has
already done merging while respecting
On Tue, 26 Feb 2008, Elias Oltmanns wrote:
You don't want, for example, to swap out other apps, swap in the
daemon, in order to handle a sudden acceleration.
Quite. But with mlock this particular problem can be handled in user
space just fine. The only reason I can see right now for
Benjamin Herrenschmidt wrote:
On Mon, 2008-02-25 at 19:15 -0500, Jeff Garzik wrote:
Mark Lord wrote:
Jeff,
We had a discussion here today about IOMMUs,
and they *never* split sg list entries -- they only ever *merge*.
And this happens only after the block layer has
already done merging while
Hello, Mark.
Mark Lord wrote:
The optional .qc_defer() methods don't seem to be called
on the ata_exec_internal_sg() path.
At present, this is probably okay. But in the future,
as we add functionality for link power management
and hotplug polling, this could be a problem.
I think. Or
Mark Lord wrote:
Benjamin Herrenschmidt wrote:
..
The split wasn't done by the iommu. The split was done by the IDE code
itself to handle the stupid 64k crossing thingy. If it's done
differently now, it might be possible to remove it, I haven't looked.
..
The block layer uses
Hello, Mark.
Mark Lord wrote:
libata doesn't really put much restrictions on what a LLD should do on
entering EH and if the controller's behavior is predictable, there's no
reason to freeze the port. If the problem is that the DMA engine isn't
usable after PMP error but it's known that the
The block layer uses seg_boundary_mask to ensure that we never have
to split them again in the LLD.
A very long time ago, when I wrote the IDE DMA code, this was not the case.
Not good enough, still, because the boundaries can change due to the
iommu merging, thus the split must be re-done.
James B. suggests that we stick a WARN_ON() into libata to let us
know if that precondition is violated. Sounds like an easy thing to do
for a couple of -rc cycles someday.
If the block layer gives us a 32k block aligned on a 32k boundary
(aligned), we have no guarantee that the iommu will
Benjamin Herrenschmidt wrote:
James B. suggests that we stick a WARN_ON() into libata to let us
know if that precondition is violated. Sounds like an easy thing to do
for a couple of -rc cycles someday.
If the block layer gives us a 32k block aligned on a 32k boundary
(aligned), we have no
On Mon, 2008-02-25 at 23:38 -0500, Mark Lord wrote:
Benjamin Herrenschmidt wrote:
James B. suggests that we stick a WARN_ON() into libata to let us
know if that precondition is violated. Sounds like an easy thing to do
for a couple of -rc cycles someday.
If the block layer gives us
Benjamin Herrenschmidt wrote:
On Mon, 2008-02-25 at 23:38 -0500, Mark Lord wrote:
Benjamin Herrenschmidt wrote:
James B. suggests that we stick a WARN_ON() into libata to let us
know if that precondition is violated. Sounds like an easy thing to do
for a couple of -rc cycles someday.
If the
On Tue, 2008-02-26 at 00:43 -0500, Mark Lord wrote:
I suppose so. I don't remember all of the details, but iirc, it has to
do with crossing 64K boundaries. Some controllers can't handle it.
It's not only the _size_ of the segments, it's their alignment.
The iommu will not keep
Hi Bart,
here some trivial fixes that i wanted to get out the door.
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-cd.c | 29 +
1 files changed, 13 insertions(+), 16 deletions(-)
diff --git a/drivers/ide/ide-cd.c b/drivers/ide/ide-cd.c
index 546f436..3600648 100644
--- a/drivers/ide/ide-cd.c
+++
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-cd.c | 634 +
1 files changed, 323 insertions(+), 311 deletions(-)
diff --git a/drivers/ide/ide-cd.c b/drivers/ide/ide-cd.c
index 3600648..3853eb5 100644
---
51 matches
Mail list logo
