Re: ATA, SATA Disk Problems

2008-01-21 Thread Tejun Heo
Hello, rgheck wrote: Hi, and sorry if this turns out to be a known issue. Actually, I'll be thrilled if this turns out to be a known issue. But I've searched on it forever, and although I've found some information, I've not found a definite fix. Possibly my fault, but this is driving me nuts.

Re: unable to use cdrom/dvd drive after some usage

2008-01-21 Thread Tejun Heo
Alan Cox wrote: On Mon, 14 Jan 2008 20:46:08 -0800 Johnny Luong [EMAIL PROTECTED] wrote: Hi, If possible, I would like to know if its worthwhile simply just to get another SATA drive / different controller / cable rather than trying to figure out this PATA drive on SATA/PATA

Re: SIlicon Image Controller 3512A or Seagate Barracuda ST3160827AS Issue

2008-01-21 Thread Tejun Heo
Tony Mugan wrote: Hello Jeff, I've tried a few recent Kernels (incl 2.6.23.14) attempting to have my SATA Raid configuration detected to no avail. My SATA drives are not on your blacklist in sata_sil.c so I decided to contact you to see if I am missing something or can offer a testbed to

Re: dvdrw-cdrom

2008-01-21 Thread Tejun Heo
[restoring linux-ide. please don't drop cc's. use reply-to-all.] Jake wrote: Hi, Tejun: http://marc.info/?l=linux-idem=120069298104580w=4 It has been 2 weeks here hunting for some solutions, can you recommend anything that I should try? Thank you. Can you please post full boot log from

Re: dvdrw-cdrom

2008-01-21 Thread Tejun Heo
Jake wrote: http://marc.info/?l=linux-idem=120069298104580w=4 It has been 2 weeks here hunting for some solutions, can you recommend anything that I should try? Thank you. Can you please post full boot log from the working kernel broken kernel? It seems you were using ide-scsi driver

Re: dvdrw-cdrom

2008-01-21 Thread Jake
http://marc.info/?l=linux-idem=120069298104580w=4 It has been 2 weeks here hunting for some solutions, can you recommend anything that I should try? Thank you. Can you please post full boot log from the working kernel broken kernel? It seems you were using ide-scsi driver previously, right?

Re: [PATCHSET] printk: implement printk_header() and merging printk, take #2

2008-01-21 Thread Matthew Wilcox
On Mon, Jan 21, 2008 at 02:13:52PM +0900, Tejun Heo wrote: In a nutshell, printk_header() lets you do the following atomically (against other messages). code: printk(KERN_INFO ata1.00: , line0\nline1\nline2\n); output: 6ata1.00: line0 6 line1 6 line2 I think

Re: [PATCHSET] printk: implement printk_header() and merging printk, take #2

2008-01-21 Thread Tejun Heo
Matthew Wilcox wrote: On Mon, Jan 21, 2008 at 02:13:52PM +0900, Tejun Heo wrote: In a nutshell, printk_header() lets you do the following atomically (against other messages). code: printk(KERN_INFO ata1.00: , line0\nline1\nline2\n); output: 6ata1.00: line0 6 line1 6

Re: ATA device reset, shoud I be concerned?

2008-01-21 Thread Alan Cox
transmission failure as timeouts. Of course, if we're ticking the timer while the command is not in flight, that's a bug. If there are cases where 30 secs isn't enough, can you please point me to those reports? I have been, in bugzilla - the raid failure example where old IDE eventually

Re: ATA device reset, shoud I be concerned?

2008-01-21 Thread Tejun Heo
Alan Cox wrote: transmission failure as timeouts. Of course, if we're ticking the timer while the command is not in flight, that's a bug. If there are cases where 30 secs isn't enough, can you please point me to those reports? I have been, in bugzilla - the raid failure example where old

Re: dvdrw-cdrom

2008-01-21 Thread Robert Hancock
Tejun Heo wrote: Jake wrote: http://marc.info/?l=linux-idem=120069298104580w=4 It has been 2 weeks here hunting for some solutions, can you recommend anything that I should try? Thank you. Can you please post full boot log from the working kernel broken kernel? It seems you were using

Re: ATA device reset, shoud I be concerned?

2008-01-21 Thread Tejun Heo
Alan Cox wrote: while IDE thinks that IRQ might be lost and complete the command if the TF status register says so. For PATA at least that makes a lot of sense. It would probably make the Promise driver a lot more stable too. Can you elaborate a bit? I don't really think completing a

Re: ATA device reset, shoud I be concerned?

2008-01-21 Thread Tejun Heo
Tejun Heo wrote: IMHO, losing media error information is much better than locking up a machine hard. We can start white listing known good controllers but I'm skeptical how much benefit it will bring. Just a data point, even ICHs lock up after PHY event if the wrong TF register is accessed.

Re: ATA, SATA Disk Problems

2008-01-21 Thread rgheck
Full boot log below. This is the critical part, as far as boot is concerned: ata7: PATA max UDMA/133 cmd 0x000101f0 ctl 0x000103f6 bmdma 0x0001fc00 irq 14 ata7.00: ATAPI: PLEXTOR CD-R PX-W1610A, 1.05, max MWDMA2 ata7.00: configured for MWDMA2 ata7.00: exception Emask

Re: sata_sil24 / Alpha / 4726 PMP issue ..

2008-01-21 Thread Thomas Evans
I should have mentioned that in 1 of the failing logs, it finds the PMP device, that is rare, it usually doesn't even see it. That happened this morning and I was hopeful that somehow it was more meaningful than the usual case where it doesn't even notice the PMP. ...tom Thomas Evans wrote:

Re: ATA device reset, shoud I be concerned?

2008-01-21 Thread Alan Cox
Can you elaborate a bit? I don't really think completing a command after 30sec timeout contributes a lot to driver stability. Timeout, timeout, timeout, reset, timeout.. (repeat), failed I/O This gives the end user no information about the fault, nor does it let the upper layers of SCSI and

Re: ATA device reset, shoud I be concerned?

2008-01-21 Thread Tejun Heo
Alan Cox wrote: Can you elaborate a bit? I don't really think completing a command after 30sec timeout contributes a lot to driver stability. Timeout, timeout, timeout, reset, timeout.. (repeat), failed I/O This gives the end user no information about the fault, nor does it let the upper

Re: ATA device reset, shoud I be concerned?

2008-01-21 Thread Alan Cox
I still don't think it's worth the trouble. There's currently only one reported device which forgets to raise IRQ on media error. The behavior Most people wouldn't realise what is going on. Old IDE says it works for PATA. For SATA I can see it might need more care and you might simply

Re: [PATCH] libata: add enclosure management support

2008-01-21 Thread James Bottomley
On Fri, 2008-01-18 at 16:52 -0800, Kristen Carlson Accardi wrote: On Fri, 18 Jan 2008 18:16:34 -0600 James Bottomley [EMAIL PROTECTED] wrote: On Fri, 2008-01-18 at 09:41 -0800, Kristen Carlson Accardi wrote: On Fri, 18 Jan 2008 11:11:21 -0600 James Bottomley [EMAIL PROTECTED] wrote:

[PATCH] Palmchip BK3710 IDE driver

2008-01-21 Thread Anton Salnikov
This is Palmchip BK3710 IDE controller support for kernel version 2.6.24-rc8. The IDE controller logic supports PIO, multiword DMA and ultra-DMA modes. Supports interface to compact Flash (CF) configured in True-IDE mode. Use ide_setup_dma() since BLK_DEV_PALMCHIP_BK3710 selects

Re: [PATCH] Palmchip BK3710 IDE driver

2008-01-21 Thread Alan Cox
+static inline u32 ioread(u32 reg) +{ + return ioread32(base + reg); +} + +static inline void iowrite(u32 val, u32 reg) +{ + iowrite32(val, base + reg); +} Why not just use ioread32/iowrite32 directly ? Otherwise this looks way way better. Alan - To unsubscribe from this list:

Re: [PATCHSET] printk: implement printk_header() and merging printk

2008-01-21 Thread Matt Mackall
On Sat, 2008-01-19 at 07:58 +0900, Tejun Heo wrote: Matt Mackall wrote: On Wed, 2008-01-16 at 10:00 +0900, Tejun Heo wrote: And mprintk the following. code: DEFINE_MPRINTK(mp, 2 * 80); mprintk_set_header(mp, KERN_INFO ata%u.%2u: , 1, 0); mprintk_push(mp, ATA %d, 7);

Re: [PATCH 0/12] ide-floppy redux v2.5

2008-01-21 Thread Bartlomiej Zolnierkiewicz
Hi Borislav, On Sunday 20 January 2008, Borislav Petkov wrote: On Mon, Jan 14, 2008 at 10:38:17PM +0100, Bartlomiej Zolnierkiewicz wrote: By the way, I have an Iomega ZIP 100 drive somewhere in my hardware pile and will do some testing with the new :) driver just in case. This

Re: [PATCH] pdc2026x: remove surplus initialiser

2008-01-21 Thread Bartlomiej Zolnierkiewicz
On Saturday 19 January 2008, Alan Cox wrote: Signed-off-by: Alan Cox [EMAIL PROTECTED] applied with: - s/pdc2026x/pdc202xx_old/ in patch summary - drive-by CodingStyle fixups diff -u --new-file --recursive --exclude-from /usr/src/exclude

Re: [PATCH] pdc2026x: remove surplus initialiser

2008-01-21 Thread Bartlomiej Zolnierkiewicz
On Saturday 19 January 2008, Alan Cox wrote: On Sat, 19 Jan 2008 19:54:03 +0300 Sergei Shtylyov [EMAIL PROTECTED] wrote: Hello. Alan Cox wrote: Signed-off-by: Alan Cox [EMAIL PROTECTED] diff -u --new-file --recursive --exclude-from /usr/src/exclude

[PATCH] ide-disk: use do_rw_taskfile() (take 2)

2008-01-21 Thread Bartlomiej Zolnierkiewicz
* Add IDE_TFLAG_DMA_PIO_FALLBACK taskfile flag to indicate the need to skip loading taskfile registers in do_rw_taskfile(). * Export do_rw_taskfile(). * Convert __ide_do_rw_disk() to use do_rw_taskfile(). * Unexport ide_tf_load(). * Unexport {pre_task_out,task_in}_intr() and make it static.

[PATCH 00/16] ide: various fixes/cleanups

2008-01-21 Thread Bartlomiej Zolnierkiewicz
Easy stuff done as relax from more hard-core changes... diffstat: drivers/ide/cris/ide-cris.c |6 - drivers/ide/ide-dma.c | 20 ++ drivers/ide/ide-iops.c | 145 ++-- drivers/ide/ide-probe.c | 35 ++

[PATCH 01/16] ide-tape: use ide_execute_command()

2008-01-21 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-tape.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Index: b/drivers/ide/ide-tape.c === --- a/drivers/ide/ide-tape.c +++

[PATCH 02/16] ide-scsi: use ide_execute_command()

2008-01-21 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/scsi/ide-scsi.c |7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) Index: b/drivers/scsi/ide-scsi.c === --- a/drivers/scsi/ide-scsi.c +++

[PATCH 03/16] trm290: use ide_execute_command()

2008-01-21 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/trm290.c |5 + 1 file changed, 1 insertion(+), 4 deletions(-) Index: b/drivers/ide/pci/trm290.c === --- a/drivers/ide/pci/trm290.c +++

[PATCH 04/16] ide-cris: use ide_execute_command()

2008-01-21 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/cris/ide-cris.c |6 +- 1 file changed, 1 insertion(+), 5 deletions(-) Index: b/drivers/ide/cris/ide-cris.c === --- a/drivers/ide/cris/ide-cris.c +++

[PATCH 05/16] ide-probe: remove needless Status register reads

2008-01-21 Thread Bartlomiej Zolnierkiewicz
* Cache value read from the Status register in 'stat' variable in do_probe() and enable_nest(), then remove remove needless Status register reads. While at it: * Add proper KERN_* levels to printk() calls. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] ---

[PATCH 07/16] ide: convert -straight8 field in ide_hwif_t to bit flag

2008-01-21 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- include/linux/ide.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: b/include/linux/ide.h === --- a/include/linux/ide.h +++ b/include/linux/ide.h @@

[PATCH 08/16] ide: remove -nice0 and -nice2 fields from ide_drive_t

2008-01-21 Thread Bartlomiej Zolnierkiewicz
* -nice0 and -nice2 ide_drive_t fields are always zero so remove them. * IDE_NICE_0 and IDE_NICE_2 defines from linux/hdreg.h are no longer used by any kernel code so cover them with #ifndef/#endif __KERNEL__. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide.c

[PATCH 09/16] ide: remove SATA_*_REG macros

2008-01-21 Thread Bartlomiej Zolnierkiewicz
* siimage.c: use hwif-sata_scr[SATA_{ERROR,STATUS}_OFFSET] instead of SATA_{ERROR,STATUS}_REG macros. * Remove no longer needed SATA_*_REG macros. While at it: * Remove needless SATA Status register read from sil_sata_reset_poll(). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]

[PATCH 11/16] ide: unexport SELECT_DRIVE()

2008-01-21 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-iops.c |2 -- 1 file changed, 2 deletions(-) Index: b/drivers/ide/ide-iops.c === --- a/drivers/ide/ide-iops.c +++ b/drivers/ide/ide-iops.c @@ -163,8

[PATCH 12/16] ide: remove set_transfer()

2008-01-21 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-iops.c | 18 -- drivers/ide/ide-taskfile.c |6 +- include/linux/ide.h|1 - 3 files changed, 5 insertions(+), 20 deletions(-) Index: b/drivers/ide/ide-iops.c

[PATCH 13/16] ide: remove ide_ata66_check()

2008-01-21 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-iops.c | 15 --- drivers/ide/ide-taskfile.c |5 - include/linux/ide.h|1 - 3 files changed, 4 insertions(+), 17 deletions(-) Index: b/drivers/ide/ide-iops.c

[PATCH 14/16] ide: move drive-crc_count check out from check_dma_crc()

2008-01-21 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-iops.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) Index: b/drivers/ide/ide-iops.c === ---

[PATCH 15/16] ide: remove ide_auto_reduce_xfer()

2008-01-21 Thread Bartlomiej Zolnierkiewicz
While at it: * Remove needless '!drive-crc_count' check. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-iops.c | 41 + 1 file changed, 13 insertions(+), 28 deletions(-) Index: b/drivers/ide/ide-iops.c

[PATCH 16/16] ide: move check_dma_crc() to ide-dma.c

2008-01-21 Thread Bartlomiej Zolnierkiewicz
* Move check_dma_crc() to ide-dma.c and add inline version for CONFIG_BLK_DEV_IDEDMA=n case. * Rename check_dma_crc() to ide_check_dma_crc(). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-dma.c | 20 drivers/ide/ide-iops.c | 24

Re: ATA device reset, shoud I be concerned?

2008-01-21 Thread Tejun Heo
Hello, Alan Cox wrote: I still don't think it's worth the trouble. There's currently only one reported device which forgets to raise IRQ on media error. The behavior Most people wouldn't realise what is going on. Yeap, true but I don't think we have many timeouts due to media errors.

Re: [PATCHSET] printk: implement printk_header() and merging printk

2008-01-21 Thread Tejun Heo
Matt Mackall wrote: I suppose. I still find this approach less than ideal, especially putting something potentially large on the stack. The dangers are perhaps worse than a malloc, really. I pondered on this a bit but the thing is we already use several hundreds bytes in a function which

Re: ATA device reset, shoud I be concerned?

2008-01-21 Thread Bartlomiej Zolnierkiewicz
On Monday 21 January 2008, Tejun Heo wrote: [...] Old IDE says it works for PATA. For SATA I can see it might need more care and you might simply not be able to get the info. Old IDE often locks up the machine hard after timeouts. I'm all for Could you point me to some bugreports? I

Re: [PATCHSET] printk: implement printk_header() and merging printk

2008-01-21 Thread Matt Mackall
On Tue, 2008-01-22 at 10:00 +0900, Tejun Heo wrote: Matt Mackall wrote: I suppose. I still find this approach less than ideal, especially putting something potentially large on the stack. The dangers are perhaps worse than a malloc, really. I pondered on this a bit but the thing is we

Re: ATA device reset, shoud I be concerned?

2008-01-21 Thread Tejun Heo
Bartlomiej Zolnierkiewicz wrote: On Monday 21 January 2008, Tejun Heo wrote: [...] Old IDE says it works for PATA. For SATA I can see it might need more care and you might simply not be able to get the info. Old IDE often locks up the machine hard after timeouts. I'm all for Could you

Re: ATA device reset, shoud I be concerned?

2008-01-21 Thread Alan Cox
Could you point me to some bugreports? I would like to know more about hosts/conditions for which it happens. The timer reset path races the I/O path races the interrupt path. That was the vomitously foul race that persuaded me to go libata instead. I seem to remember explaining this all some

Re: ATA device reset, shoud I be concerned?

2008-01-21 Thread Tejun Heo
Tejun Heo wrote: Bartlomiej Zolnierkiewicz wrote: On Monday 21 January 2008, Tejun Heo wrote: [...] Old IDE says it works for PATA. For SATA I can see it might need more care and you might simply not be able to get the info. Old IDE often locks up the machine hard after timeouts. I'm all

Re: sata_sil24 / Alpha / 4726 PMP issue ..

2008-01-21 Thread Tejun Heo
Hello, Thomas. Thomas Evans wrote: What do you mean by eSata PMP enclosure? Is it a different PMP device? It is an external PMP box, 5 drive bays - it is the exact same manufacturer and is based on the same PMP: 0x1095:0x4726 r31, 7 ports, feat 0x1/0x9 Okay. I can hook the card and

Re: dvdrw-cdrom

2008-01-21 Thread Jake
Jake wrote: http://marc.info/?l=linux-idem=120069298104580w=4 It has been 2 weeks here hunting for some solutions, can you recommend anything that I should try? Thank you. Can you please post full boot log from the working kernel broken kernel? It seems you were using ide-scsi driver