Re: [PATCH V8] kbuild: create a rule to run the pre-processor on *.dts files

2013-02-12 Thread Stephen Warren
On 02/12/2013 11:08 AM, Grant Likely wrote: > On Mon, 11 Feb 2013 12:11:22 -0700, Stephen Warren > wrote: >> On 02/08/2013 08:45 AM, Grant Likely wrote: >>> On Tue, 5 Feb 2013 12:06:28 -0700, Stephen Warren >>> wrote: Create cmd_dtc_cpp to run the C pre-processor on *.dts file before

[GIT PULL] ARM: arm-soc fixes for 3.8

2013-02-12 Thread Olof Johansson
Hi Linus, The following changes since commit 836dc9e3fbbab0c30aa6e664417225f5c1fb1c39: Linux 3.8-rc7 (2013-02-09 08:20:39 +1100) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc.git tags/fixes-for-linus for you to fetch changes up to

[PATCH] ACPI, PCI: Get PRT entry during acpi_pci_enable_irq()

2013-02-12 Thread Yinghai Lu
Peter Hurley found "irq 18 nobody cared" with pci-next, and dmesg has [8.983246] pci :00:1e.0: can't derive routing for PCI INT A [8.983600] snd_ctxfi :09:02.0: PCI INT A: no GSI - using ISA IRQ 5 bisect to | commit 4f535093cf8f6da8cfda7c36c2c1ecd2e9586ee4 | PCI: Put pci_dev

Re: [tip:x86/mm] x86, mm: Use a bitfield to mask nuisance get_user() warnings

2013-02-12 Thread H. Peter Anvin
On 02/12/2013 10:46 AM, Linus Torvalds wrote: On Tue, Feb 12, 2013 at 10:25 AM, H. Peter Anvin wrote: I just thought up this variant, I'm about to test it, but H.J., do you see any problems with it? Looks good to me. And we already use __builtin_choose_expr(), so it's "portable". And it

Re: [PATCH] dw_dmac: adjust slave_id accordingly to request line base

2013-02-12 Thread Mika Westerberg
On Tue, Feb 12, 2013 at 09:34:35AM -0800, Vinod Koul wrote: > On Tue, Feb 12, 2013 at 06:43:51PM +0200, Mika Westerberg wrote: > > On Tue, Feb 12, 2013 at 07:53:34AM -0800, Vinod Koul wrote: > > > On Tue, Jan 29, 2013 at 10:29:43AM +0530, Viresh Kumar wrote: > > > > Next time, please direct these

Re: [PATCH 05/32] lib: devres: don't enclose pcim_*() functions in CONFIG_HAS_IOPORT

2013-02-12 Thread Thomas Petazzoni
Dear Arnd Bergmann, On Tue, 12 Feb 2013 18:00:48 +, Arnd Bergmann wrote: > On Tuesday 12 February 2013, Thomas Petazzoni wrote: > > The pcim_*() functions are used by the libata-sff subsystem, and > > this subsystem is used for many SATA drivers on ARM platforms that > > do not necessarily

Re: [PATCH 2/2] ima: Support appraise_type=imasig_optional

2013-02-12 Thread Vivek Goyal
On Tue, Feb 12, 2013 at 01:52:03PM -0500, Vivek Goyal wrote: > On Tue, Feb 12, 2013 at 12:14:07PM -0500, Mimi Zohar wrote: > > [..] > > > > > --- a/security/integrity/ima/ima_appraise.c > > > > > +++ b/security/integrity/ima/ima_appraise.c > > > > > @@ -124,19 +124,26 @@ int

Re: [PATCH v2] IIO ADC support for AD7923

2013-02-12 Thread Lars-Peter Clausen
On 02/12/2013 06:10 PM, Christophe Leroy wrote: > This patch adds support for Analog Devices AD7923 ADC in the IIO Subsystem. > > Signed-off-by: Patrick Vasseur > Signed-off-by: Christophe Leroy Looks good to me except for one small, but important issue. [...] > diff -urN

Re: [PATCH 2/2] ima: Support appraise_type=imasig_optional

2013-02-12 Thread Vivek Goyal
On Tue, Feb 12, 2013 at 12:14:07PM -0500, Mimi Zohar wrote: [..] > > > > --- a/security/integrity/ima/ima_appraise.c > > > > +++ b/security/integrity/ima/ima_appraise.c > > > > @@ -124,19 +124,26 @@ int ima_appraise_measurement(int func, struct > > > > integrity_iint_cache *iint, > > > >

Re: [RFC][PATCH] tracing/syscalls: Have ia32 compat syscalls show raw format

2013-02-12 Thread Steven Rostedt
On Tue, 2013-02-12 at 13:42 -0500, Steven Rostedt wrote: > Really, I converted: > > lls-1127 [005] d... 936.409188: sys_recvfrom(fd: 0, ubuf: > 4d560fc4, size: 0, flags: 8048034, addr: 8, addr_len: f7700420) > lls-1127 [005] d... 936.409190: sys_recvfrom ->

Re: [tip:x86/mm] x86, mm: Use a bitfield to mask nuisance get_user() warnings

2013-02-12 Thread Linus Torvalds
On Tue, Feb 12, 2013 at 10:25 AM, H. Peter Anvin wrote: > I just thought up this variant, I'm about to test it, but H.J., do you > see any problems with it? Looks good to me. And we already use __builtin_choose_expr(), so it's "portable". And it should avoid all the potential issues with

Re: [RFC][PATCH] tracing/syscalls: Have ia32 compat syscalls show raw format

2013-02-12 Thread Steven Rostedt
On Tue, 2013-02-12 at 10:11 -0800, H. Peter Anvin wrote: > What? > > Seriously, this has got to be a bad joke. > > Either I'm not getting something here or this is just a nonstarter. > > This feels like a hack upon a kluge upon a wart, and something that we'd > have to support forever. > > No.

[char-misc-next 05/12 v3] mei: bus: Add bus related structures to mei_cl

2013-02-12 Thread Samuel Ortiz
We keep track of all MEI devices on the bus through a specific linked list. We also have a mei_device instance in the mei_cl structure. Signed-off-by: Samuel Ortiz Signed-off-by: Tomas Winkler --- drivers/misc/mei/bus.c | 46 +++-

[char-misc-next 10/12 v3] mei: nfc: Connect also the regular ME client

2013-02-12 Thread Samuel Ortiz
After receiving the NFC interface version, IVN and radio type, we can connect to the the actual nfc ME client and send the initialization (nfc connect) message. Signed-off-by: Samuel Ortiz Signed-off-by: Tomas Winkler --- drivers/misc/mei/nfc.c | 128

[char-misc-next 01/12 v3] mei: Rename mei_device to mei_host

2013-02-12 Thread Samuel Ortiz
In preparation for the MEI bus code merge, we rename the mei_device structure to mei_host. struct mei_device will be used for devices on the MEI bus in order to follow exisiting driver model implementations practices. Signed-off-by: Samuel Ortiz --- drivers/misc/mei/amthif.c| 30

[char-misc-next 03/12 v3] mei: bus: Implement driver registration

2013-02-12 Thread Samuel Ortiz
Signed-off-by: Samuel Ortiz Signed-off-by: Tomas Winkler --- drivers/misc/mei/bus.c | 26 ++ include/linux/mei_bus.h |6 ++ 2 files changed, 32 insertions(+) diff --git a/drivers/misc/mei/bus.c b/drivers/misc/mei/bus.c index 485fcf3c..04e7ada 100644 ---

[char-misc-next 02/12 v3] mei: bus: Initial MEI bus type implementation

2013-02-12 Thread Samuel Ortiz
mei bus will present some of the me clients as devices for other standard subsystems Implement the probe, remove, match and the device addtion routines. A mei-bus.txt document describing the rationale and the API usage is also added. Signed-off-by: Samuel Ortiz Signed-off-by: Tomas Winkler ---

[char-misc-next 08/12 v3] mei: bus: Implement bus driver data setter/getter

2013-02-12 Thread Samuel Ortiz
MEI drivers should be able to carry their private data around. Signed-off-by: Samuel Ortiz Signed-off-by: Tomas Winkler --- drivers/misc/mei/bus.c | 12 include/linux/mei_bus.h |3 +++ 2 files changed, 15 insertions(+) diff --git a/drivers/misc/mei/bus.c

[char-misc-next 12/12 v3] mei: nfc: Implement MEI bus IO ops

2013-02-12 Thread Samuel Ortiz
The send ops for NFC builds the command header, updates the request id and then waits for an ACK. The recv ops check if it receives data or an ACK and in the latter case wakes the send ops up. Signed-off-by: Samuel Ortiz Signed-off-by: Tomas Winkler --- drivers/misc/mei/nfc.c | 76

[char-misc-next 07/12 v3] mei: bus: Synchronous API for the data transmission

2013-02-12 Thread Samuel Ortiz
Define a truly synchronous API for the bus Tx path by putting all pending request to the write list and wait for the interrupt tx handler to wake us up. The ___mei_send() out path is also slightly reworked to make it look more like main.c:mei_write(). Signed-off-by: Samuel Ortiz Signed-off-by:

[char-misc-next 11/12 v3] mei: nfc: Add NFC device to the MEI bus

2013-02-12 Thread Samuel Ortiz
After building its bus name as a string based on its vendor id and radio type, we can add it to the bus. Signed-off-by: Samuel Ortiz Signed-off-by: Tomas Winkler --- drivers/misc/mei/nfc.c | 56 drivers/misc/mei/nfc.h |6 ++ 2 files

[char-misc-next 09/12 v3] mei: nfc: Initial nfc implementation

2013-02-12 Thread Samuel Ortiz
NFC ME device is exported through the MEI bus to be consumed by the NFC subsystem. NFC is represented by two mei clients: An info one and the actual NFC one. In order to properly build the ME id we first need to retrieve the firmware information from the info client. Signed-off-by: Samuel Ortiz

[char-misc-next 04/12 v3] mei: bus: Initial implementation for I/O routines

2013-02-12 Thread Samuel Ortiz
Signed-off-by: Samuel Ortiz Signed-off-by: Tomas Winkler --- drivers/misc/mei/bus.c | 226 drivers/misc/mei/mei_dev.h | 28 ++ include/linux/mei_bus.h| 11 +++ 3 files changed, 265 insertions(+) diff --git a/drivers/misc/mei/bus.c

[char-misc-next 06/12 v3] mei: bus: Call bus routines from the core code

2013-02-12 Thread Samuel Ortiz
Register the MEI bus type against the kernel core bus APIs and call the bus Rx handler from interrupt.c Signed-off-by: Samuel Ortiz Signed-off-by: Tomas Winkler --- drivers/misc/mei/bus.c | 22 ++ drivers/misc/mei/interrupt.c |2 ++ drivers/misc/mei/mei_dev.h

[char-misc-next 00/12 v3] Add MEI bus and NFC device

2013-02-12 Thread Samuel Ortiz
This is take 3 on the MEI bus + NFC device patches addressing Arnd and Greg comments. This patch set adds implementation of MEI BUS abstraction over MEI device, this allows standard Linux device drivers to access functionality exposed by MEI device that was previously available only to the user

Re: Abysmal HDD/USB write speed after sleep on a UEFI system

2013-02-12 Thread Artem S. Tashkinov
Feb 12, 2013 11:30:20 PM, Linus Torvalds wrote: >On Mon, Feb 11, 2013 at 10:25 PM, Artem S. Tashkinov wrote: >> Hello Linus, >> >> I 've already posted a bug report >> (https://bugzilla.kernel.org/show_bug.cgi?id=53551), >> a message to LKML >>

Re: [tip:x86/mm] x86, mm: Use a bitfield to mask nuisance get_user() warnings

2013-02-12 Thread H.J. Lu
On Tue, Feb 12, 2013 at 10:25 AM, H. Peter Anvin wrote: > I just thought up this variant, I'm about to test it, but H.J., do you > see any problems with it? > > #define itype(x) \ > __typeof__(__builtin_choose_expr(sizeof(*(x)) > sizeof(0UL), 0ULL, 0UL)) > > I tried it out with a small test

Re: [tip:x86/mm] x86, mm: Use a bitfield to mask nuisance get_user() warnings

2013-02-12 Thread H. Peter Anvin
I just thought up this variant, I'm about to test it, but H.J., do you see any problems with it? #define itype(x) \ __typeof__(__builtin_choose_expr(sizeof(*(x)) > sizeof(0UL), 0ULL, 0UL)) I tried it out with a small test program (attached), and it seems to work. Next for using it in the

[PATCH linux-next] jbd: start_this_handle(): remove kfree() redundant null check

2013-02-12 Thread Tim Gardner
smatch analysis: fs/jbd/transaction.c:236 start_this_handle() info: redundant null check on new_transaction calling kfree() Cc: Andrew Morton Cc: Jan Kara Cc: linux-e...@vger.kernel.org Signed-off-by: Tim Gardner --- fs/jbd/transaction.c |3 +-- 1 file changed, 1 insertion(+), 2

Re: [PATCH V4 1/2] get_maintainer: allow keywords to match filenames

2013-02-12 Thread Joe Perches
On Tue, 2013-02-12 at 11:17 -0700, Stephen Warren wrote: > On 02/11/2013 11:17 PM, Joe Perches wrote: > > If the -f pattern is a single file, > > get_maintainer reads that file content and then > > matches any K: patterns. > > > > When the -f pattern is a directory, it doesn't. > > Yes, I guess

[PATCH V2 3/3] gpio: Make of_count_named_gpios() use new of_count_phandle_with_args()

2013-02-12 Thread Grant Likely
This patch replaces the horribly coded of_count_named_gpios() with a call to of_count_phandle_with_args() which is far more efficient. This also changes the return value of of_gpio_count() & of_gpio_named_count() from 'unsigned int' to 'int' so that it can return an error code. All the users of

[PATCH V2 2/3] of: Create function for counting number of phandles in a property

2013-02-12 Thread Grant Likely
This patch creates of_count_phandle_with_args(), a new function for counting the number of phandle+argument tuples in a given property. This is better than the existing method of parsing each phandle individually until parsing fails which is a horribly slow way to do the count. It also converts

Re: [PATCH V8] kbuild: create a rule to run the pre-processor on *.dts files

2013-02-12 Thread Grant Likely
On Mon, 11 Feb 2013 12:11:22 -0700, Stephen Warren wrote: > On 02/08/2013 08:45 AM, Grant Likely wrote: > > On Tue, 5 Feb 2013 12:06:28 -0700, Stephen Warren > > wrote: > >> Create cmd_dtc_cpp to run the C pre-processor on *.dts file before > >> passing them to dtc for final compilation. This

[PATCH V2 1/3] of/selftest: Fix GPIOs selftest to cover the 7th case

2013-02-12 Thread Grant Likely
The of_gpio_named_count() self test doesn't hit the out-of-range condition even though it is coded. Fix the bug by increasing the for loop range by one. Reported-by: Andreas Larsson Cc: Rob Herring Signed-off-by: Grant Likely --- drivers/of/selftest.c |2 +- 1 file changed, 1

Re: [PATCH v2 5/6] of_spi: Add fetching of of_gpio flags to of_spi_register_master

2013-02-12 Thread Grant Likely
On Tue, 12 Feb 2013 10:39:02 +0100, Andreas Larsson wrote: > On 2013-02-11 01:22, Grant Likely wrote: > > On Tue, 29 Jan 2013 15:53:42 +0100, Andreas Larsson > > wrote: > >> When using a gpio chip select with a OF_GPIO_ACTIVE_LOW flag, this needs > >> to be > >> known to the controller driver.

Re: [PATCH] of: Create function for counting number of phandles in a property

2013-02-12 Thread Grant Likely
On Mon, 11 Feb 2013 12:26:15 +0100, Andreas Larsson wrote: > On 2013-02-11 00:58, Grant Likely wrote: > > diff --git a/drivers/of/base.c b/drivers/of/base.c > > index 2390ddb..e1120a2 100644 > > --- a/drivers/of/base.c > > +++ b/drivers/of/base.c > > @@ -1025,12 +1025,13 @@

Re: [PATCH v8 2/4] misc: Generic on-chip SRAM allocation driver

2013-02-12 Thread Grant Likely
On Mon, 11 Feb 2013 19:15:24 +0100, Philipp Zabel wrote: > Hi Grant, > > Am Freitag, den 08.02.2013, 20:16 + schrieb Grant Likely: > > On Mon, 4 Feb 2013 12:32:16 +0100, Philipp Zabel > > wrote: > > > This driver requests and remaps a memory region as configured in the > > > device tree.

Re: [PATCH] of: Create function for counting number of phandles in a property

2013-02-12 Thread Grant Likely
On Tue, 12 Feb 2013 10:18:10 +0100, Andreas Larsson wrote: > On 2013-02-11 00:58, Grant Likely wrote: > > This patch creates of_count_phandle_with_args(), a new function for > > counting the number of phandle+argument tuples in a given property. This > > is better than the existing method of

Re: [PATCH v2 6/6] of_spi: Initialize cs_gpios and cs_gpio with -EEXIST

2013-02-12 Thread Grant Likely
On Tue, 12 Feb 2013 10:46:27 +0100, Andreas Larsson wrote: > On 2013-02-11 01:23, Grant Likely wrote: > > On Tue, 29 Jan 2013 15:53:43 +0100, Andreas Larsson > > wrote: > >> Holes in the cs-gpios DT phandle list is supposed to mark that native > >> chipselects is to be used. The value returned

Re: [PATCH 1/9] virtio: add functions for piecewise addition of buffers

2013-02-12 Thread Michael S. Tsirkin
On Tue, Feb 12, 2013 at 07:04:27PM +0100, Paolo Bonzini wrote: > >> Perhaps, but 3 or 4 arguments (in/out/nsg or in/out/nsg_in/nsg_out) just > >> for this are definitely too many and make the API harder to use. > >> > >> You have to find a balance. Having actually used the API, the > >>

[PATCH linux-next] hugetlbfs: hugetlbfs_fill_super(): remove kfree() redundant null check

2013-02-12 Thread Tim Gardner
smatch analysis: fs/hugetlbfs/inode.c:883 hugetlbfs_fill_super() info: redundant null check on sbinfo->spool calling kfree() Cc: Nadia Yvette Chambers Signed-off-by: Tim Gardner --- fs/hugetlbfs/inode.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

Re: [PATCH V4 1/2] get_maintainer: allow keywords to match filenames

2013-02-12 Thread Stephen Warren
On 02/11/2013 11:17 PM, Joe Perches wrote: > On Mon, 2013-02-11 at 17:39 -0700, Stephen Warren wrote: >> From: Stephen Warren >> >> Allow K: entries in MAINTAINERS to match directly against filenames; >> either those extracted from patch +++ or --- lines, or those specified >> on the command-line

Re: [PATCH 2/2] ima: Support appraise_type=imasig_optional

2013-02-12 Thread Mimi Zohar
On Tue, 2013-02-12 at 09:26 -0500, Vivek Goyal wrote: > On Mon, Feb 11, 2013 at 05:10:14PM -0500, Mimi Zohar wrote: > > On Mon, 2013-02-11 at 15:11 -0500, Vivek Goyal wrote: > > > appraise_type=imasig_optional will allow appraisal to pass even if no > > > signatures are present on the file. If

Re: [PATCH linux-next] ecryptfs: ecryptfs_msg_ctx_alloc_to_free(): remove kfree() redundant null check

2013-02-12 Thread Tyler Hicks
On 2013-02-12 11:03:49, Tim Gardner wrote: > smatch analysis: > > fs/ecryptfs/messaging.c:101 ecryptfs_msg_ctx_alloc_to_free() info: > redundant null check on msg_ctx->msg calling kfree() > > Cc: Tyler Hicks > Cc: Dustin Kirkland > Cc: ecryp...@vger.kernel.org > Signed-off-by: Tim Gardner

Re: [PATCH linux-next] eCryptfs: decrypt_pki_encrypted_session_key(): remove kfree() redundant null check

2013-02-12 Thread Tyler Hicks
On 2013-02-12 10:56:54, Tim Gardner wrote: > smatch analysis: > > fs/ecryptfs/keystore.c:1206 decrypt_pki_encrypted_session_key() info: > redundant null check on msg calling kfree() > > Cc: Tyler Hicks > Cc: Dustin Kirkland > Cc: ecryp...@vger.kernel.org > Signed-off-by: Tim Gardner Thanks,

Re: [RFC][PATCH] tracing/syscalls: Have ia32 compat syscalls show raw format

2013-02-12 Thread H. Peter Anvin
What? Seriously, this has got to be a bad joke. Either I'm not getting something here or this is just a nonstarter. This feels like a hack upon a kluge upon a wart, and something that we'd have to support forever. No. Realize that syscall number does not, and never have, been a unique

Re: [PATCH linux-next] befs: befs_fill_super(): remove unreachable code

2013-02-12 Thread Tim Gardner
On 02/12/2013 10:46 AM, Eric W. Biederman wrote: > Tim Gardner writes: > >> befs_sb->num_blocks is of base type u64 which is the same as sector_t. >> Therefore, num_blocks can never be larger then the maximum >> value of sector_t. > > The analysys is wrong. On 32bit with CONFIG_LBAF unset

Re: [PATCH 1/3] nbd: support FLUSH requests

2013-02-12 Thread Paolo Bonzini
Il 12/02/2013 18:37, Alex Bligh ha scritto: > For my education, why remove the FUA stuff? Because I had no way to test it. >>> > > Hmmm... the underlying storage could be md/dm RAIDs in which case FUA >>> > > should be cheaper than FLUSH. >> > >> > If someone ever wrote a virtio-blk backend

Re: [PATCH] of: dma.c: fix memory leakage

2013-02-12 Thread Vinod Koul
On Tue, Jan 22, 2013 at 10:10:53AM +, Cong Ding wrote: > On Sun, Jan 20, 2013 at 04:24:49PM -0600, Rob Herring wrote: > > On 01/19/2013 07:06 AM, Cong Ding wrote: > > > The memory allocated to ofdma might be a leakage when error occurs. > > > > > > Signed-off-by: Cong Ding > > > > You need

Re: [PATCH 1/9] virtio: add functions for piecewise addition of buffers

2013-02-12 Thread Paolo Bonzini
Il 12/02/2013 18:34, Michael S. Tsirkin ha scritto: > On Tue, Feb 12, 2013 at 05:57:55PM +0100, Paolo Bonzini wrote: >> Il 12/02/2013 17:35, Michael S. Tsirkin ha scritto: >>> On Tue, Feb 12, 2013 at 05:17:47PM +0100, Paolo Bonzini wrote: Il 12/02/2013 17:13, Michael S. Tsirkin ha scritto:

[PATCH v2 1/9] virtio: add functions for piecewise addition of buffers

2013-02-12 Thread Paolo Bonzini
virtio device drivers translate requests from higher layer in two steps: a device-specific step in the device driver, and generic preparation of virtio direct or indirect buffers in virtqueue_add_buf. Because virtqueue_add_buf also accepts the outcome of the first step as a single struct

[PATCH linux-next] ecryptfs: ecryptfs_msg_ctx_alloc_to_free(): remove kfree() redundant null check

2013-02-12 Thread Tim Gardner
smatch analysis: fs/ecryptfs/messaging.c:101 ecryptfs_msg_ctx_alloc_to_free() info: redundant null check on msg_ctx->msg calling kfree() Cc: Tyler Hicks Cc: Dustin Kirkland Cc: ecryp...@vger.kernel.org Signed-off-by: Tim Gardner --- fs/ecryptfs/messaging.c |3 +-- 1 file changed, 1

Re: Should SPARC use cpuidle?

2013-02-12 Thread Len Brown
>> Can you please move the definition of sparc_idle to processor_32.h >> It is sparc32 specific - and then we do not need the __ASSEMBLY__ guards >> as the sparc32 variant are not used from assembler. > > sure, let me know if attached works. ugh, not accustomed to sending patches via

Should SPARC use cpuidle? (was: linux-next: build failure after merge of the final tree (acpi tree related))

2013-02-12 Thread Len Brown
On 02/12/2013 12:35 PM, Sam Ravnborg wrote: >>> Signed-off-by: Stephen Rothwell >>> --- >>> arch/sparc/include/asm/processor.h | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/arch/sparc/include/asm/processor.h >>> b/arch/sparc/include/asm/processor.h >>> index 34baa35..622cfa5

Re: [PATCH 05/32] lib: devres: don't enclose pcim_*() functions in CONFIG_HAS_IOPORT

2013-02-12 Thread Arnd Bergmann
On Tuesday 12 February 2013, Thomas Petazzoni wrote: > The pcim_*() functions are used by the libata-sff subsystem, and this > subsystem is used for many SATA drivers on ARM platforms that do not > necessarily have I/O ports. > > Signed-off-by: Thomas Petazzoni > Cc: Paul Gortmaker > Cc: Jesse

[RFC][PATCH] tracing/syscalls: Have ia32 compat syscalls show raw format

2013-02-12 Thread Steven Rostedt
The tracing of ia32 compat system calls has been a bit of a pain as they use different system call numbers than the 64bit equivalents. I wrote a simple 'lls' program that lists files. I compiled it as a i686 ELF binary and ran it under a x86_64 box. This is the result: echo 0 >

Re: [PATCH -mm] i2c: style cleanups after idr_alloc() conversion

2013-02-12 Thread Jean Delvare
On Tue, 12 Feb 2013 09:36:48 -0800, Tejun Heo wrote: > On Tue, Feb 12, 2013 at 09:34:14AM -0800, Tejun Heo wrote: > > Style cleanups suggested by Wolfram. > > > > * s/res/id/ in i2c_add_numbered_adapter() so that it matches > > i2c_add_adapter(). > > > > * Add a blank line before return in

Re: [PATCH] dw_dmac: adjust slave_id accordingly to request line base

2013-02-12 Thread Vinod Koul
On Tue, Feb 12, 2013 at 06:43:51PM +0200, Mika Westerberg wrote: > On Tue, Feb 12, 2013 at 07:53:34AM -0800, Vinod Koul wrote: > > On Tue, Jan 29, 2013 at 10:29:43AM +0530, Viresh Kumar wrote: > > > Next time, please direct these mails to my Linaro id :) > > > > > > On Mon, Jan 28, 2013 at 4:34

Re: [tip:x86/mm] x86, mm: Use a bitfield to mask nuisance get_user() warnings

2013-02-12 Thread Russell King - ARM Linux
On Tue, Feb 12, 2013 at 09:32:54AM -0800, Linus Torvalds wrote: > On Tue, Feb 12, 2013 at 9:14 AM, H. Peter Anvin wrote: > > > > No, I think what he is talking about it this bit: > > Ok, I agree that the bitfield code actually looks cleaner. > > That said, maybe gcc has an easier time using a

[PATCH linux-next] eCryptfs: decrypt_pki_encrypted_session_key(): remove kfree() redundant null check

2013-02-12 Thread Tim Gardner
smatch analysis: fs/ecryptfs/keystore.c:1206 decrypt_pki_encrypted_session_key() info: redundant null check on msg calling kfree() Cc: Tyler Hicks Cc: Dustin Kirkland Cc: ecryp...@vger.kernel.org Signed-off-by: Tim Gardner --- fs/ecryptfs/keystore.c |3 +-- 1 file changed, 1

Re: [PATCH v3 4/7] memcg: remove memcg from the reclaim iterators

2013-02-12 Thread Michal Hocko
On Tue 12-02-13 08:10:51, Paul E. McKenney wrote: > On Tue, Feb 12, 2013 at 04:43:30PM +0100, Michal Hocko wrote: > > On Tue 12-02-13 10:10:02, Johannes Weiner wrote: > > > On Tue, Feb 12, 2013 at 10:54:19AM +0100, Michal Hocko wrote: > > > > On Mon 11-02-13 17:39:43, Johannes Weiner wrote: > > >

Re: [PATCH v3 4/7] memcg: remove memcg from the reclaim iterators

2013-02-12 Thread Paul E. McKenney
On Tue, Feb 12, 2013 at 04:43:30PM +0100, Michal Hocko wrote: > On Tue 12-02-13 10:10:02, Johannes Weiner wrote: > > On Tue, Feb 12, 2013 at 10:54:19AM +0100, Michal Hocko wrote: > > > On Mon 11-02-13 17:39:43, Johannes Weiner wrote: > > > > On Mon, Feb 11, 2013 at 10:27:56PM +0100, Michal Hocko

Re: [tip:x86/mm] x86, mm: Use a bitfield to mask nuisance get_user() warnings

2013-02-12 Thread Linus Torvalds
On Tue, Feb 12, 2013 at 9:35 AM, H. Peter Anvin wrote: > > On the other hand, it still uses two gcc extensions: long long bitfields and > typeof. > > I'll see what kind of code we get with the macro. At least one thing to look out for is the poor LLVM people who are trying to make the kernel

Re: [PATCH 1/3] nbd: support FLUSH requests

2013-02-12 Thread Alex Bligh
Paolo, > Add support for a new flag that the server can pass. If the flag is > enabled, we translate REQ_FLUSH requests into the NBD_CMD_FLUSH > command. > > Cc: > Cc: Paul Clements > Cc: Andrew Morton > Signed-off-by: Alex Bligh > [ Removed FUA support for reasons similar to those outlined

Re: [PATCH V2] clk: tegra: initialise parent of uart clocks

2013-02-12 Thread Stephen Warren
On 02/12/2013 08:17 AM, Laxman Dewangan wrote: > Initialise the parent of UARTs to PLLP and disabling clock by > default. This patch wasn't tested, was it? Without the patch I just sent titled "ARM: tegra: remove clock-frequency properties from serial nodes", the UART clocks get turned off and

Re: [PATCH linux-next] befs: befs_fill_super(): remove unreachable code

2013-02-12 Thread Eric W. Biederman
Tim Gardner writes: > befs_sb->num_blocks is of base type u64 which is the same as sector_t. > Therefore, num_blocks can never be larger then the maximum > value of sector_t. The analysys is wrong. On 32bit with CONFIG_LBAF unset sector_t is an unsigned long aka a u32, while befs_off_t is

[PATCH linux-next] x86: smpboot.c: Remove unused variable c

2013-02-12 Thread Stratos Karafotis
This patch removes the unused variable 'c' in mwait_play_dead and fixes the following warning: arch/x86/kernel/smpboot.c: In function ‘mwait_play_dead’: arch/x86/kernel/smpboot.c:1370:22: warning: unused variable ‘c’ [-Wunused-variable] Signed-off-by: Stratos Karafotis ---

Re: [PATCH] x86: mm: Check if PUD is large when validating a kernel address

2013-02-12 Thread Michal Hocko
On Mon 11-02-13 14:52:36, Mel Gorman wrote: > A user reported the following oops when a backup process read > /proc/kcore. > > BUG: unable to handle kernel paging request at bb00ff33b000 > IP: [] kern_addr_valid+0xbe/0x110 > PGD 0 > Oops: [#1] SMP > CPU 6 > Modules linked in:

Re: [PATCH 2/2] stop_machine: dequeue work before signal completion

2013-02-12 Thread Tejun Heo
On Sun, Feb 10, 2013 at 01:26:11PM +0800, Hillf Danton wrote: > When a CPU is finally put down in either CPU_UP_CANCELLED or > CPU_POST_DEAD, cpu_stop_cpu_callback() signals immediate completion on > all cpu_stop_works still queued on the dead CPU; unfortunately, this > code is buggy in that it

Re: [PATCH v3 4/7] memcg: remove memcg from the reclaim iterators

2013-02-12 Thread Johannes Weiner
On Tue, Feb 12, 2013 at 06:12:16PM +0100, Michal Hocko wrote: > On Tue 12-02-13 11:41:03, Johannes Weiner wrote: > > > > > > Michal Hocko wrote: > > > > >On Tue 12-02-13 17:13:32, Michal Hocko wrote: > > >> On Tue 12-02-13 16:43:30, Michal Hocko wrote: > > >> [...] > > >> The example was not

Re: [PATCH 1/2] stop_machine: check work->done while handling enqueued works

2013-02-12 Thread Tejun Heo
On Sun, Feb 10, 2013 at 01:22:43PM +0800, Hillf Danton wrote: > In cpu_stopper_thread(), @work->done may be NULL if the cpu stop work > is queued from stop_one_cpu_nowait(); however, cpu_stopper_thread() > updates @done->ret without checking whether @done exists or not when > the work function

Re: [PATCH -mm] i2c: style cleanups after idr_alloc() conversion

2013-02-12 Thread Tejun Heo
On Tue, Feb 12, 2013 at 09:34:14AM -0800, Tejun Heo wrote: > Style cleanups suggested by Wolfram. > > * s/res/id/ in i2c_add_numbered_adapter() so that it matches > i2c_add_adapter(). > > * Add a blank line before return in i2c_add_numbered_adapter(). > > This patch is purely cosmetic. > >

Re: [tip:x86/mm] x86, mm: Use a bitfield to mask nuisance get_user() warnings

2013-02-12 Thread H. Peter Anvin
On 02/12/2013 09:32 AM, Linus Torvalds wrote: On Tue, Feb 12, 2013 at 9:14 AM, H. Peter Anvin wrote: No, I think what he is talking about it this bit: Ok, I agree that the bitfield code actually looks cleaner. That said, maybe gcc has an easier time using a few odd builtins and magic

Re: linux-next: build failure after merge of the final tree (acpi tree related)

2013-02-12 Thread Sam Ravnborg
> > Signed-off-by: Stephen Rothwell > > --- > > arch/sparc/include/asm/processor.h | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/arch/sparc/include/asm/processor.h > > b/arch/sparc/include/asm/processor.h > > index 34baa35..622cfa5 100644 > > ---

[PATCH linux-next] befs: befs_fill_super(): remove unreachable code

2013-02-12 Thread Tim Gardner
befs_sb->num_blocks is of base type u64 which is the same as sector_t. Therefore, num_blocks can never be larger then the maximum value of sector_t. smatch analysis: fs/befs/linuxvfs.c:851 befs_fill_super() warn: impossible condition '(befs_sb->num_blocks > ~(0)) => (0-u64max > u64max)' Cc: Al

[PATCH -mm] i2c: style cleanups after idr_alloc() conversion

2013-02-12 Thread Tejun Heo
Style cleanups suggested by Wolfram. * s/res/id/ in i2c_add_numbered_adapter() so that it matches i2c_add_adapter(). * Add a blank line before return in i2c_add_numbered_adapter(). This patch is purely cosmetic. Signed-off-by: Tejun Heo Cc: Wolfram Sang --- drivers/i2c/i2c-core.c | 13

Re: [PATCH 0/2] perf stat: add per-core count aggregation

2013-02-12 Thread Stephane Eranian
On Tue, Feb 12, 2013 at 6:29 PM, Andi Kleen wrote: >> >> > The idea itself is useful. >> > >> Yes, it is. > > BTW it would be even more useful if it could print some of the > statistics turbostat does (in particular frequency and C0 residency) > Often you only care about cycles not idle, and the

Re: [PATCH v3 1/3] dmaengine: add dma_get_slave_sg_caps()

2013-02-12 Thread Vinod Koul
On Mon, Feb 04, 2013 at 02:47:02PM -0500, Matt Porter wrote: > Add a dmaengine API to retrieve slave SG transfer capabilities. > > The API is optionally implemented by dmaengine drivers and when > unimplemented will return a NULL pointer. A client driver using > this API provides the required dma

Re: [tip:x86/mm] x86, mm: Use a bitfield to mask nuisance get_user() warnings

2013-02-12 Thread Linus Torvalds
On Tue, Feb 12, 2013 at 9:14 AM, H. Peter Anvin wrote: > > No, I think what he is talking about it this bit: Ok, I agree that the bitfield code actually looks cleaner. That said, maybe gcc has an easier time using a few odd builtins and magic typeof's. But at least the bitfield trick looks

Re: [v2 3/3] ARM: tegra: Unify Device tree board files

2013-02-12 Thread Arnd Bergmann
On Tuesday 12 February 2013, Stephen Warren wrote: > > I don't think that's going to help any link issues, so I'd drop it and > > keep this function simple. > > As explained in the above, a complier will drop unnecessary functions > automatically with this IS_ENABLED(),

Re: [PATCH 1/9] virtio: add functions for piecewise addition of buffers

2013-02-12 Thread Michael S. Tsirkin
On Tue, Feb 12, 2013 at 05:57:55PM +0100, Paolo Bonzini wrote: > Il 12/02/2013 17:35, Michael S. Tsirkin ha scritto: > > On Tue, Feb 12, 2013 at 05:17:47PM +0100, Paolo Bonzini wrote: > >> Il 12/02/2013 17:13, Michael S. Tsirkin ha scritto: > > + * @nsg: the number of sg lists that will be

Re: [tip:x86/mm] x86, mm: Use a bitfield to mask nuisance get_user() warnings

2013-02-12 Thread H.J. Lu
On Tue, Feb 12, 2013 at 9:14 AM, H. Peter Anvin wrote: > On 02/12/2013 09:00 AM, Linus Torvalds wrote: >> On Tue, Feb 12, 2013 at 8:38 AM, H.J. Lu wrote: >>> >>> Can you do something similar to what we did in glibc: >> >> No. Because we use macros to be type-independent (i e"get_user()" >> works

Re: Abysmal HDD/USB write speed after sleep on a UEFI system

2013-02-12 Thread Linus Torvalds
On Mon, Feb 11, 2013 at 10:25 PM, Artem S. Tashkinov wrote: > Hello Linus, > > I've already posted a bug report > (https://bugzilla.kernel.org/show_bug.cgi?id=53551), > a message to LKML > (http://lkml.indiana.edu/hypermail/linux/kernel/1302.1/00837.html) > and so far I've received zero

Re: [PATCH 0/2] perf stat: add per-core count aggregation

2013-02-12 Thread Andi Kleen
> > > The idea itself is useful. > > > Yes, it is. BTW it would be even more useful if it could print some of the statistics turbostat does (in particular frequency and C0 residency) Often you only care about cycles not idle, and the frequency tells you how fast the cycles happen. I think Cx

Re: [PATCH] drm: missing idr_preload_end in drm_gem_flink_ioctl

2013-02-12 Thread Tejun Heo
(cc'ing Andrew) Hello, On Sun, Feb 10, 2013 at 03:49:05PM +0400, Artem Savkov wrote: > Added missing idr_preload_end calls in drm_gem_flink_ioctl(). > Without those preemption stays disabled resulting in lots of "scheduling while > atomic" BUGs. > > Introduced in

Re: [PATCH 1/2] perf stat: refactor aggregation code

2013-02-12 Thread Andi Kleen
On Tue, Feb 12, 2013 at 03:09:27PM +0100, Stephane Eranian wrote: > - fmt = "%s%.0f%s%s"; > + fmt = "%.0f%s%s"; > else if (big_num) > - fmt = "%s%'18.0f%s%-25s"; > + fmt = "%'18.0f%s%-25s"; > else > - fmt = "%s%18.0f%s%-25s";

Re: [PATCH 0/2] perf stat: add per-core count aggregation

2013-02-12 Thread Stephane Eranian
On Tue, Feb 12, 2013 at 6:23 PM, Andi Kleen wrote: > On Tue, Feb 12, 2013 at 03:09:26PM +0100, Stephane Eranian wrote: >> This patch series contains improvement to the aggregation support >> in perf stat. >> >> First, the aggregation code is refactored and a aggr_mode enum >> is defined. There is

Re: [PATCH v3 4/7] memcg: remove memcg from the reclaim iterators

2013-02-12 Thread Johannes Weiner
On Tue, Feb 12, 2013 at 08:10:51AM -0800, Paul E. McKenney wrote: > On Tue, Feb 12, 2013 at 04:43:30PM +0100, Michal Hocko wrote: > > On Tue 12-02-13 10:10:02, Johannes Weiner wrote: > > > On Tue, Feb 12, 2013 at 10:54:19AM +0100, Michal Hocko wrote: > > > > On Mon 11-02-13 17:39:43, Johannes

Re: [PATCH] drivers/block/xsysace - replace in(out)_8/in(out)_be16/in(out)_le16 with generic iowrite(read)8/16(be)

2013-02-12 Thread Arnd Bergmann
On Tuesday 12 February 2013, Michal Simek wrote: > But on Microblaze LE is necessary to use different datain/out_le16 > functions as below > which are also not compatible with Microblaze and PPC BE. > > diff --git a/drivers/block/xsysace.c b/drivers/block/xsysace.c > index bbad046..8dd192c 100644

Re: [PATCH 0/2] perf stat: add per-core count aggregation

2013-02-12 Thread Andi Kleen
On Tue, Feb 12, 2013 at 03:09:26PM +0100, Stephane Eranian wrote: > This patch series contains improvement to the aggregation support > in perf stat. > > First, the aggregation code is refactored and a aggr_mode enum > is defined. There is also an important bug fix for the existing > per-socket

[PATCH linux-next] befs: befs_get_block(): remove unreachable code

2013-02-12 Thread Tim Gardner
'sector_t block' is unsigned and can therefore never be '< 0'. smatch analysis: fs/befs/linuxvfs.c:131 befs_get_block() warn: unsigned 'block' is never less than zero. Cc: Al Viro Cc: Andrew Morton Cc: "Eric W. Biederman" Cc: "Kirill A. Shutemov" Signed-off-by: Tim Gardner ---

Re: [PATCH 6/9] gpiolib: use descriptors internally

2013-02-12 Thread Arnd Bergmann
On Tuesday 12 February 2013, Paul Mundt wrote: > > While I do get the point... I chatted with Grant about it and > > I want to talk to some toolchain people about this to see if > > pointers containing potential error codes can somehow be > > "flagged" by the compiler so we can enforce error

Re: [PATCH] iommu: making IOMMU sysfs nodes API public

2013-02-12 Thread Alex Williamson
On Wed, 2013-02-13 at 01:42 +1100, Alexey Kardashevskiy wrote: > On 12/02/13 16:07, Alex Williamson wrote: > > On Tue, 2013-02-12 at 15:06 +1100, Alexey Kardashevskiy wrote: > >> Having this patch in a tree, adding new nodes in sysfs > >> for IOMMU groups is going to be easier. > >> > >> The first

Re: [tip:x86/mm] x86, mm: Use a bitfield to mask nuisance get_user() warnings

2013-02-12 Thread H. Peter Anvin
On 02/12/2013 09:00 AM, Linus Torvalds wrote: > On Tue, Feb 12, 2013 at 8:38 AM, H.J. Lu wrote: >> >> Can you do something similar to what we did in glibc: > > No. Because we use macros to be type-independent (i e"get_user()" > works *regardless* of type), so casting to "uintptr_t" doesn't work.

Re: [PATCH v2] lib/scatterlist: add simple page iterator

2013-02-12 Thread Tejun Heo
Hello, On Tue, Feb 12, 2013 at 07:07:20PM +0200, Imre Deak wrote: > It's the one implemented by sg_miter_{start,stop} in scatterlist.c. It > also iterates through a scatterlist a page at a time, but it also kmaps > these pages. Since in our use case we don't need to map the pages we > needed a

[PATCH linux-next] autofs4: autofs4_catatonic_mode(): remove redundant null check on kfree()

2013-02-12 Thread Tim Gardner
smatch analysis: fs/autofs4/waitq.c:46 autofs4_catatonic_mode() info: redundant null check on wq->name.name calling kfree() Cc: Ian Kent Cc: aut...@vger.kernel.org Signed-off-by: Tim Gardner --- fs/autofs4/waitq.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git

Re: [PATCH v3 4/7] memcg: remove memcg from the reclaim iterators

2013-02-12 Thread Michal Hocko
On Tue 12-02-13 11:41:03, Johannes Weiner wrote: > > > Michal Hocko wrote: > > >On Tue 12-02-13 17:13:32, Michal Hocko wrote: > >> On Tue 12-02-13 16:43:30, Michal Hocko wrote: > >> [...] > >> The example was not complete: > >> > >> > Wait a moment. But what prevents from the following race?

Re: [PATCH 1/6] idr: fix top layer handling

2013-02-12 Thread Tejun Heo
Hey, Andrew. On Mon, Feb 11, 2013 at 03:39:55PM -0800, Andrew Morton wrote: > This doesn't apply happily to 3.7, so Greg will be needing a redone > version when the time arrives. > > But does it really need backporting? Is anyone likely to hit this in > practice? For most cases, probably not.

[PATCH v2] IIO ADC support for AD7923

2013-02-12 Thread Christophe Leroy
This patch adds support for Analog Devices AD7923 ADC in the IIO Subsystem. Signed-off-by: Patrick Vasseur Signed-off-by: Christophe Leroy diff -urN linux-next-e347c98/drivers/iio/adc/Kconfig linux-next-e347c98.new/drivers/iio/adc/Kconfig --- linux-next-e347c98/drivers/iio/adc/Kconfig

Re: [PATCH v2] lib/scatterlist: add simple page iterator

2013-02-12 Thread Imre Deak
On Mon, 2013-02-11 at 12:54 -0800, Andrew Morton wrote: > On Mon, 11 Feb 2013 20:50:04 +0200 > Imre Deak wrote: > > > Add an iterator to walk through a scatter list a page at a time starting > > at a specific page offset. As opposed to the mapping iterator this is > > What is "the mapping

<    1   2   3   4   5   6   7   8   9   10   >