Re: [REGRESSION] -rc7/-rc4+: unable to USB boot - enumeration partially broken (was: Linux v3.8-rc7)

2013-02-12 Thread Greg KH
On Tue, Feb 12, 2013 at 05:07:27PM +0100, Andreas Mohr wrote: On Sun, Feb 10, 2013 at 03:05:54PM +0100, Andreas Mohr wrote: Regression sorta confirmed now. -rc3 with a fully suitable .config does not boot either. Will start bisection. Will take ages. Down to 91 commits (all in USB land!),

Re: [PATCH v5 04/45] percpu_rwlock: Implement the core design of Per-CPU Reader-Writer Locks

2013-02-12 Thread Paul E. McKenney
On Sun, Feb 10, 2013 at 11:54:17AM -0800, Paul E. McKenney wrote: On Sun, Feb 10, 2013 at 07:06:07PM +0100, Oleg Nesterov wrote: On 02/08, Paul E. McKenney wrote: [ . . . ] +static inline void sync_reader(struct percpu_rwlock *pcpu_rwlock, + unsigned

Re: [PATCH 1/9] virtio: add functions for piecewise addition of buffers

2013-02-12 Thread Paolo Bonzini
Il 12/02/2013 17:13, Michael S. Tsirkin ha scritto: + * @nsg: the number of sg lists that will be added This means number of calls to add_sg ? Not sure why this matters. How about we pass in in_num/out_num - that is total # of sg, same as add_buf? It is used to choose between direct and

Re: [PATCH] dw_dmac: adjust slave_id accordingly to request line base

2013-02-12 Thread Vinod Koul
On Tue, Jan 29, 2013 at 10:29:43AM +0530, Viresh Kumar wrote: Next time, please direct these mails to my Linaro id :) On Mon, Jan 28, 2013 at 4:34 PM, Andy Shevchenko andriy.shevche...@linux.intel.com wrote: On some hardware configurations we have got the request line with the offset.

Re: [PATCH] dw_dmac: adjust slave_id accordingly to request line base

2013-02-12 Thread Vinod Koul
On Wed, Jan 30, 2013 at 09:32:56AM +0200, Andy Shevchenko wrote: On Tue, 2013-01-29 at 20:57 +0530, Viresh Kumar wrote: On Tue, Jan 29, 2013 at 10:52 AM, Mika Westerberg mika.westerb...@linux.intel.com wrote: We had a discusssion about this with Andy as well. The thing is that there is

Re: [PATCH v3 4/7] memcg: remove memcg from the reclaim iterators

2013-02-12 Thread Michal Hocko
On Tue 12-02-13 17:13:32, Michal Hocko wrote: On Tue 12-02-13 16:43:30, Michal Hocko wrote: [...] The example was not complete: Wait a moment. But what prevents from the following race? rcu_read_lock() cgroup_next_descendant_pre css_tryget(css); memcg = mem_cgroup_from_css(css)

[PATCH 05/32] lib: devres: don't enclose pcim_*() functions in CONFIG_HAS_IOPORT

2013-02-12 Thread Thomas Petazzoni
The pcim_*() functions are used by the libata-sff subsystem, and this subsystem is used for many SATA drivers on ARM platforms that do not necessarily have I/O ports. Signed-off-by: Thomas Petazzoni thomas.petazz...@free-electrons.com Cc: Paul Gortmaker paul.gortma...@windriver.com Cc: Jesse

Re: [PATCH 1/9] virtio: add functions for piecewise addition of buffers

2013-02-12 Thread Michael S. Tsirkin
On Tue, Feb 12, 2013 at 05:17:47PM +0100, Paolo Bonzini wrote: Il 12/02/2013 17:13, Michael S. Tsirkin ha scritto: + * @nsg: the number of sg lists that will be added This means number of calls to add_sg ? Not sure why this matters. How about we pass in in_num/out_num - that is total # of

Re: [PATCH v3 4/7] memcg: remove memcg from the reclaim iterators

2013-02-12 Thread Johannes Weiner
Michal Hocko mho...@suse.cz wrote: On Tue 12-02-13 10:10:02, Johannes Weiner wrote: On Tue, Feb 12, 2013 at 10:54:19AM +0100, Michal Hocko wrote: On Mon 11-02-13 17:39:43, Johannes Weiner wrote: On Mon, Feb 11, 2013 at 10:27:56PM +0100, Michal Hocko wrote: On Mon 11-02-13 14:58:24,

Re: [patch 32/40] rcu: Convert rcutree to hotplug state machine

2013-02-12 Thread Paul E. McKenney
On Mon, Feb 11, 2013 at 04:01:01PM -0800, Paul E. McKenney wrote: On Thu, Jan 31, 2013 at 12:11:38PM -, Thomas Gleixner wrote: Do we really need so many states here ? Well, all that RCU does for CPU_DYING is to do tracing, which could be ditched. Required changes called out inline

Re: [PATCH] dw_dmac: adjust slave_id accordingly to request line base

2013-02-12 Thread Andy Shevchenko
On Tue, Feb 12, 2013 at 5:56 PM, Vinod Koul vinod.k...@intel.com wrote: On Wed, Jan 30, 2013 at 09:32:56AM +0200, Andy Shevchenko wrote: On Tue, 2013-01-29 at 20:57 +0530, Viresh Kumar wrote: On Tue, Jan 29, 2013 at 10:52 AM, Mika Westerberg mika.westerb...@linux.intel.com wrote: We had a

Re: [PATCH] dw_dmac: add support for Lynxpoint DMA controllers

2013-02-12 Thread Vinod Koul
On Fri, Feb 08, 2013 at 09:25:11AM +0200, Andy Shevchenko wrote: On Fri, Feb 8, 2013 at 6:28 AM, Viresh Kumar viresh.ku...@linaro.org wrote: On Thu, Feb 7, 2013 at 10:35 PM, Andy Shevchenko andy.shevche...@gmail.com wrote: On Thu, Feb 7, 2013 at 5:39 PM, Viresh Kumar viresh.ku...@linaro.org

Re: [v2 3/3] ARM: tegra: Unify Device tree board files

2013-02-12 Thread Stephen Warren
On 02/12/2013 06:50 AM, Arnd Bergmann wrote: On Tuesday 12 February 2013, Hiroshi Doyu wrote: static void __init paz00_init(void) @@ -129,6 +128,9 @@ static void __init tegra_dt_init_late(void) tegra_init_late(); + if (IS_ENABLED(CONFIG_PCI) IS_ENABLED(CONFIG_ARCH_TEGRA_2x_SOC)) +

Re: [PATCH v3 4/7] memcg: remove memcg from the reclaim iterators

2013-02-12 Thread Michal Hocko
On Tue 12-02-13 17:24:42, Michal Hocko wrote: On Tue 12-02-13 17:13:32, Michal Hocko wrote: On Tue 12-02-13 16:43:30, Michal Hocko wrote: [...] The example was not complete: Wait a moment. But what prevents from the following race? rcu_read_lock()

Re: [tip:x86/mm] x86, mm: Use a bitfield to mask nuisance get_user() warnings

2013-02-12 Thread H.J. Lu
On Mon, Feb 11, 2013 at 8:21 PM, H. Peter Anvin h...@zytor.com wrote: On 02/11/2013 07:33 PM, Linus Torvalds wrote: On Mon, Feb 11, 2013 at 5:37 PM, tip-bot for H. Peter Anvin h...@zytor.com wrote: However, we can declare a bitfield using sizeof(), which is legal because sizeof() is a

Re: [PATCH] dw_dmac: adjust slave_id accordingly to request line base

2013-02-12 Thread Mika Westerberg
On Tue, Feb 12, 2013 at 07:53:34AM -0800, Vinod Koul wrote: On Tue, Jan 29, 2013 at 10:29:43AM +0530, Viresh Kumar wrote: Next time, please direct these mails to my Linaro id :) On Mon, Jan 28, 2013 at 4:34 PM, Andy Shevchenko andriy.shevche...@linux.intel.com wrote: On some hardware

Re: [PATCH] dw_dmac: apply default dma_mask if needed

2013-02-12 Thread Vinod Koul
On Tue, Jan 29, 2013 at 05:06:24PM +0200, Andy Shevchenko wrote: In some cases we got the device without dma_mask configured. We have to apply the default value to avoid crashes during memory mapping. what was this generated against, it fails to apply for me. Signed-off-by: Andy Shevchenko

Re: [PATCH] dw_dmac: add support for Lynxpoint DMA controllers

2013-02-12 Thread Vinod Koul
On Thu, Feb 07, 2013 at 05:36:28PM +0200, Andy Shevchenko wrote: From: Mika Westerberg mika.westerb...@linux.intel.com Intel Lynxpoint PCH Low Power Subsystem has DMA controller to support general purpose serial buses like SPI, I2C, and HSUART. This controller is enumerated from ACPI

Re: [PATCH v3 4/7] memcg: remove memcg from the reclaim iterators

2013-02-12 Thread Johannes Weiner
Michal Hocko mho...@suse.cz wrote: On Tue 12-02-13 17:13:32, Michal Hocko wrote: On Tue 12-02-13 16:43:30, Michal Hocko wrote: [...] The example was not complete: Wait a moment. But what prevents from the following race? rcu_read_lock() cgroup_next_descendant_pre

[GIT PULL rcu/srcu] SRCU commits for 3.9

2013-02-12 Thread Paul E. McKenney
Hello, Ingo, This series contains SRCU changes for 3.9. These include debugging aids, updates that move towards the goal of permitting srcu_read_lock() and srcu_read_unlock() to be used from idle and offline CPUs, and a few small fixes. These commits are available in the git repository at:

Re: [PATCH] ioatdma: fix race between updating ioat-head and IOAT_COMPLETION_PENDING

2013-02-12 Thread Vinod Koul
On Thu, Feb 07, 2013 at 02:38:32PM -0700, Dave Jiang wrote: There is a race that can hit during __cleanup() when the ioat-head pointer is incremented during descriptor submission. The __cleanup() can clear the PENDING flag when it does not see any active descriptors. This causes new submitted

Re: [PATCH] dw_dmac: apply default dma_mask if needed

2013-02-12 Thread Andy Shevchenko
On Tue, Feb 12, 2013 at 6:16 PM, Vinod Koul vinod.k...@intel.com wrote: On Tue, Jan 29, 2013 at 05:06:24PM +0200, Andy Shevchenko wrote: In some cases we got the device without dma_mask configured. We have to apply the default value to avoid crashes during memory mapping. what was this

Re: [alsa-devel] Xonar DG pci sound card driver incomplete

2013-02-12 Thread Clemens Ladisch
kernel kernel wrote: Requesting guidance on how to implement the missing mic input support for this Asus Xonar card. I've downloaded the relevant datasheets but am unsure how to proceed. Rip out the card, and look (or eletrically trace) how the CMI8788's GPIOs and the CS4245's inputs/outputs

Re: [patch for-3.8] fs, dlm: fix build error when EXPERIMENTAL is disabled

2013-02-12 Thread Linus Torvalds
On Tue, Feb 12, 2013 at 1:50 AM, Steven Whitehouse swhit...@redhat.com wrote: That doesn't seem right to me... DLM has not been experimental for a long time now. Why not just select CRC32 in addition to IP_SCTP ? Hmm. IP_SCTP already does a select libcrc32c. So why doesn't that end up working?

Re: [PATCH] pinctrl/pinconfig: add debug interface

2013-02-12 Thread Stephen Warren
On 02/12/2013 05:54 AM, Linus Walleij wrote: On Mon, Feb 11, 2013 at 9:53 PM, Stephen Warren swar...@wwwdotorg.org wrote: On 02/10/2013 01:11 PM, Linus Walleij wrote: From: Laurent Meunier laurent.meun...@st.com This update adds a debugfs interface to modify a pin configuration for a given

Re: [PATCH 1/9] virtio: add functions for piecewise addition of buffers

2013-02-12 Thread Paolo Bonzini
Il 12/02/2013 17:35, Michael S. Tsirkin ha scritto: On Tue, Feb 12, 2013 at 05:17:47PM +0100, Paolo Bonzini wrote: Il 12/02/2013 17:13, Michael S. Tsirkin ha scritto: + * @nsg: the number of sg lists that will be added This means number of calls to add_sg ? Not sure why this matters. How

Re: [tip:x86/mm] x86, mm: Use a bitfield to mask nuisance get_user() warnings

2013-02-12 Thread Linus Torvalds
On Tue, Feb 12, 2013 at 8:38 AM, H.J. Lu hjl.to...@gmail.com wrote: Can you do something similar to what we did in glibc: No. Because we use macros to be type-independent (i eget_user() works *regardless* of type), so casting to uintptr_t doesn't work. It throws away the type information, and

Re: [PATCH] drivers/block/xsysace - replace in(out)_8/in(out)_be16/in(out)_le16 with generic iowrite(read)8/16(be)

2013-02-12 Thread Michal Simek
2013/2/7 Grant Likely grant.lik...@secretlab.ca: On Thu, Feb 7, 2013 at 3:12 PM, Alexey Brodkin alexey.brod...@synopsys.com wrote: On 02/07/2013 06:51 PM, Grant Likely wrote: On Thu, Feb 7, 2013 at 2:39 PM, Grant Likely grant.lik...@secretlab.ca wrote: On Wed, Feb 6, 2013 at 9:35 PM,

Re: [PATCH v7 07/10] dmaengine: add dma_request_slave_channel_compat()

2013-02-12 Thread Vinod Koul
On Fri, Feb 01, 2013 at 01:22:52PM -0500, Matt Porter wrote: Adds a dma_request_slave_channel_compat() wrapper which accepts both the arguments from dma_request_channel() and dma_request_slave_channel(). Based on whether the driver is instantiated via DT, the appropriate channel request call

Re: [PATCH v2] lib/scatterlist: add simple page iterator

2013-02-12 Thread Imre Deak
On Mon, 2013-02-11 at 12:54 -0800, Andrew Morton wrote: On Mon, 11 Feb 2013 20:50:04 +0200 Imre Deak imre.d...@intel.com wrote: Add an iterator to walk through a scatter list a page at a time starting at a specific page offset. As opposed to the mapping iterator this is What is the

Re: [PATCH] ieee802154/at231rf230: deadlock in at86rf230_xmit

2013-02-12 Thread David Miller
linux-kernel is not the correct mailing list to post networking patches, net...@vger.kernel.org is, thank you. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at

[PATCH v2] IIO ADC support for AD7923

2013-02-12 Thread Christophe Leroy
This patch adds support for Analog Devices AD7923 ADC in the IIO Subsystem. Signed-off-by: Patrick Vasseur patrick.vass...@c-s.fr Signed-off-by: Christophe Leroy christophe.le...@c-s.fr diff -urN linux-next-e347c98/drivers/iio/adc/Kconfig linux-next-e347c98.new/drivers/iio/adc/Kconfig ---

Re: [PATCH 1/6] idr: fix top layer handling

2013-02-12 Thread Tejun Heo
Hey, Andrew. On Mon, Feb 11, 2013 at 03:39:55PM -0800, Andrew Morton wrote: This doesn't apply happily to 3.7, so Greg will be needing a redone version when the time arrives. But does it really need backporting? Is anyone likely to hit this in practice? For most cases, probably not.

Re: [PATCH v3 4/7] memcg: remove memcg from the reclaim iterators

2013-02-12 Thread Michal Hocko
On Tue 12-02-13 11:41:03, Johannes Weiner wrote: Michal Hocko mho...@suse.cz wrote: On Tue 12-02-13 17:13:32, Michal Hocko wrote: On Tue 12-02-13 16:43:30, Michal Hocko wrote: [...] The example was not complete: Wait a moment. But what prevents from the following race?

[PATCH linux-next] autofs4: autofs4_catatonic_mode(): remove redundant null check on kfree()

2013-02-12 Thread Tim Gardner
smatch analysis: fs/autofs4/waitq.c:46 autofs4_catatonic_mode() info: redundant null check on wq-name.name calling kfree() Cc: Ian Kent ra...@themaw.net Cc: aut...@vger.kernel.org Signed-off-by: Tim Gardner tim.gard...@canonical.com --- fs/autofs4/waitq.c |6 ++ 1 file changed, 2

Re: [PATCH v2] lib/scatterlist: add simple page iterator

2013-02-12 Thread Tejun Heo
Hello, On Tue, Feb 12, 2013 at 07:07:20PM +0200, Imre Deak wrote: It's the one implemented by sg_miter_{start,stop} in scatterlist.c. It also iterates through a scatterlist a page at a time, but it also kmaps these pages. Since in our use case we don't need to map the pages we needed a

Re: [PATCH] iommu: making IOMMU sysfs nodes API public

2013-02-12 Thread Alex Williamson
On Wed, 2013-02-13 at 01:42 +1100, Alexey Kardashevskiy wrote: On 12/02/13 16:07, Alex Williamson wrote: On Tue, 2013-02-12 at 15:06 +1100, Alexey Kardashevskiy wrote: Having this patch in a tree, adding new nodes in sysfs for IOMMU groups is going to be easier. The first candidate for

Re: [tip:x86/mm] x86, mm: Use a bitfield to mask nuisance get_user() warnings

2013-02-12 Thread H. Peter Anvin
On 02/12/2013 09:00 AM, Linus Torvalds wrote: On Tue, Feb 12, 2013 at 8:38 AM, H.J. Lu hjl.to...@gmail.com wrote: Can you do something similar to what we did in glibc: No. Because we use macros to be type-independent (i eget_user() works *regardless* of type), so casting to uintptr_t

Re: [PATCH 6/9] gpiolib: use descriptors internally

2013-02-12 Thread Arnd Bergmann
On Tuesday 12 February 2013, Paul Mundt wrote: While I do get the point... I chatted with Grant about it and I want to talk to some toolchain people about this to see if pointers containing potential error codes can somehow be flagged by the compiler so we can enforce error checking on

[PATCH linux-next] befs: befs_get_block(): remove unreachable code

2013-02-12 Thread Tim Gardner
'sector_t block' is unsigned and can therefore never be ' 0'. smatch analysis: fs/befs/linuxvfs.c:131 befs_get_block() warn: unsigned 'block' is never less than zero. Cc: Al Viro v...@zeniv.linux.org.uk Cc: Andrew Morton a...@linux-foundation.org Cc: Eric W. Biederman ebied...@xmission.com Cc:

Re: [PATCH 0/2] perf stat: add per-core count aggregation

2013-02-12 Thread Andi Kleen
On Tue, Feb 12, 2013 at 03:09:26PM +0100, Stephane Eranian wrote: This patch series contains improvement to the aggregation support in perf stat. First, the aggregation code is refactored and a aggr_mode enum is defined. There is also an important bug fix for the existing per-socket

Re: [PATCH] drivers/block/xsysace - replace in(out)_8/in(out)_be16/in(out)_le16 with generic iowrite(read)8/16(be)

2013-02-12 Thread Arnd Bergmann
On Tuesday 12 February 2013, Michal Simek wrote: But on Microblaze LE is necessary to use different datain/out_le16 functions as below which are also not compatible with Microblaze and PPC BE. diff --git a/drivers/block/xsysace.c b/drivers/block/xsysace.c index bbad046..8dd192c 100644 ---

Re: [PATCH v3 4/7] memcg: remove memcg from the reclaim iterators

2013-02-12 Thread Johannes Weiner
On Tue, Feb 12, 2013 at 08:10:51AM -0800, Paul E. McKenney wrote: On Tue, Feb 12, 2013 at 04:43:30PM +0100, Michal Hocko wrote: On Tue 12-02-13 10:10:02, Johannes Weiner wrote: On Tue, Feb 12, 2013 at 10:54:19AM +0100, Michal Hocko wrote: On Mon 11-02-13 17:39:43, Johannes Weiner wrote:

Re: [PATCH 0/2] perf stat: add per-core count aggregation

2013-02-12 Thread Stephane Eranian
On Tue, Feb 12, 2013 at 6:23 PM, Andi Kleen a...@linux.intel.com wrote: On Tue, Feb 12, 2013 at 03:09:26PM +0100, Stephane Eranian wrote: This patch series contains improvement to the aggregation support in perf stat. First, the aggregation code is refactored and a aggr_mode enum is defined.

Re: [PATCH 1/2] perf stat: refactor aggregation code

2013-02-12 Thread Andi Kleen
On Tue, Feb 12, 2013 at 03:09:27PM +0100, Stephane Eranian wrote: - fmt = %s%.0f%s%s; + fmt = %.0f%s%s; else if (big_num) - fmt = %s%'18.0f%s%-25s; + fmt = %'18.0f%s%-25s; else - fmt = %s%18.0f%s%-25s; +

Re: [PATCH] drm: missing idr_preload_end in drm_gem_flink_ioctl

2013-02-12 Thread Tejun Heo
(cc'ing Andrew) Hello, On Sun, Feb 10, 2013 at 03:49:05PM +0400, Artem Savkov wrote: Added missing idr_preload_end calls in drm_gem_flink_ioctl(). Without those preemption stays disabled resulting in lots of scheduling while atomic BUGs. Introduced in

Re: [PATCH 0/2] perf stat: add per-core count aggregation

2013-02-12 Thread Andi Kleen
The idea itself is useful. Yes, it is. BTW it would be even more useful if it could print some of the statistics turbostat does (in particular frequency and C0 residency) Often you only care about cycles not idle, and the frequency tells you how fast the cycles happen. I think Cx could be

Re: Abysmal HDD/USB write speed after sleep on a UEFI system

2013-02-12 Thread Linus Torvalds
On Mon, Feb 11, 2013 at 10:25 PM, Artem S. Tashkinov t.ar...@lycos.com wrote: Hello Linus, I've already posted a bug report (https://bugzilla.kernel.org/show_bug.cgi?id=53551), a message to LKML (http://lkml.indiana.edu/hypermail/linux/kernel/1302.1/00837.html) and so far I've received

Re: [tip:x86/mm] x86, mm: Use a bitfield to mask nuisance get_user() warnings

2013-02-12 Thread H.J. Lu
On Tue, Feb 12, 2013 at 9:14 AM, H. Peter Anvin h...@zytor.com wrote: On 02/12/2013 09:00 AM, Linus Torvalds wrote: On Tue, Feb 12, 2013 at 8:38 AM, H.J. Lu hjl.to...@gmail.com wrote: Can you do something similar to what we did in glibc: No. Because we use macros to be type-independent (i

Re: [PATCH 1/9] virtio: add functions for piecewise addition of buffers

2013-02-12 Thread Michael S. Tsirkin
On Tue, Feb 12, 2013 at 05:57:55PM +0100, Paolo Bonzini wrote: Il 12/02/2013 17:35, Michael S. Tsirkin ha scritto: On Tue, Feb 12, 2013 at 05:17:47PM +0100, Paolo Bonzini wrote: Il 12/02/2013 17:13, Michael S. Tsirkin ha scritto: + * @nsg: the number of sg lists that will be added This

Re: [v2 3/3] ARM: tegra: Unify Device tree board files

2013-02-12 Thread Arnd Bergmann
On Tuesday 12 February 2013, Stephen Warren wrote: I don't think that's going to help any link issues, so I'd drop it and keep this function simple. As explained in the above, a complier will drop unnecessary functions automatically with this IS_ENABLED(), which could save many ifdefs.

Re: [tip:x86/mm] x86, mm: Use a bitfield to mask nuisance get_user() warnings

2013-02-12 Thread Linus Torvalds
On Tue, Feb 12, 2013 at 9:14 AM, H. Peter Anvin h...@zytor.com wrote: No, I think what he is talking about it this bit: Ok, I agree that the bitfield code actually looks cleaner. That said, maybe gcc has an easier time using a few odd builtins and magic typeof's. But at least the bitfield

Re: [PATCH v3 1/3] dmaengine: add dma_get_slave_sg_caps()

2013-02-12 Thread Vinod Koul
On Mon, Feb 04, 2013 at 02:47:02PM -0500, Matt Porter wrote: Add a dmaengine API to retrieve slave SG transfer capabilities. The API is optionally implemented by dmaengine drivers and when unimplemented will return a NULL pointer. A client driver using this API provides the required dma

Re: [PATCH 0/2] perf stat: add per-core count aggregation

2013-02-12 Thread Stephane Eranian
On Tue, Feb 12, 2013 at 6:29 PM, Andi Kleen a...@linux.intel.com wrote: The idea itself is useful. Yes, it is. BTW it would be even more useful if it could print some of the statistics turbostat does (in particular frequency and C0 residency) Often you only care about cycles not idle,

[PATCH -mm] i2c: style cleanups after idr_alloc() conversion

2013-02-12 Thread Tejun Heo
Style cleanups suggested by Wolfram. * s/res/id/ in i2c_add_numbered_adapter() so that it matches i2c_add_adapter(). * Add a blank line before return in i2c_add_numbered_adapter(). This patch is purely cosmetic. Signed-off-by: Tejun Heo t...@kernel.org Cc: Wolfram Sang w.s...@pengutronix.de

Re: linux-next: build failure after merge of the final tree (acpi tree related)

2013-02-12 Thread Sam Ravnborg
Signed-off-by: Stephen Rothwell s...@canb.auug.org.au --- arch/sparc/include/asm/processor.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/sparc/include/asm/processor.h b/arch/sparc/include/asm/processor.h index 34baa35..622cfa5 100644 ---

[PATCH linux-next] befs: befs_fill_super(): remove unreachable code

2013-02-12 Thread Tim Gardner
befs_sb-num_blocks is of base type u64 which is the same as sector_t. Therefore, num_blocks can never be larger then the maximum value of sector_t. smatch analysis: fs/befs/linuxvfs.c:851 befs_fill_super() warn: impossible condition '(befs_sb-num_blocks ~(0)) = (0-u64max u64max)' Cc: Al Viro

Re: [tip:x86/mm] x86, mm: Use a bitfield to mask nuisance get_user() warnings

2013-02-12 Thread H. Peter Anvin
On 02/12/2013 09:32 AM, Linus Torvalds wrote: On Tue, Feb 12, 2013 at 9:14 AM, H. Peter Anvin h...@zytor.com wrote: No, I think what he is talking about it this bit: Ok, I agree that the bitfield code actually looks cleaner. That said, maybe gcc has an easier time using a few odd builtins

Re: [PATCH -mm] i2c: style cleanups after idr_alloc() conversion

2013-02-12 Thread Tejun Heo
On Tue, Feb 12, 2013 at 09:34:14AM -0800, Tejun Heo wrote: Style cleanups suggested by Wolfram. * s/res/id/ in i2c_add_numbered_adapter() so that it matches i2c_add_adapter(). * Add a blank line before return in i2c_add_numbered_adapter(). This patch is purely cosmetic.

Re: [PATCH 1/2] stop_machine: check work-done while handling enqueued works

2013-02-12 Thread Tejun Heo
On Sun, Feb 10, 2013 at 01:22:43PM +0800, Hillf Danton wrote: In cpu_stopper_thread(), @work-done may be NULL if the cpu stop work is queued from stop_one_cpu_nowait(); however, cpu_stopper_thread() updates @done-ret without checking whether @done exists or not when the work function fails.

Re: [PATCH v3 4/7] memcg: remove memcg from the reclaim iterators

2013-02-12 Thread Johannes Weiner
On Tue, Feb 12, 2013 at 06:12:16PM +0100, Michal Hocko wrote: On Tue 12-02-13 11:41:03, Johannes Weiner wrote: Michal Hocko mho...@suse.cz wrote: On Tue 12-02-13 17:13:32, Michal Hocko wrote: On Tue 12-02-13 16:43:30, Michal Hocko wrote: [...] The example was not complete:

Re: [PATCH 2/2] stop_machine: dequeue work before signal completion

2013-02-12 Thread Tejun Heo
On Sun, Feb 10, 2013 at 01:26:11PM +0800, Hillf Danton wrote: When a CPU is finally put down in either CPU_UP_CANCELLED or CPU_POST_DEAD, cpu_stop_cpu_callback() signals immediate completion on all cpu_stop_works still queued on the dead CPU; unfortunately, this code is buggy in that it

Re: [PATCH] x86: mm: Check if PUD is large when validating a kernel address

2013-02-12 Thread Michal Hocko
On Mon 11-02-13 14:52:36, Mel Gorman wrote: A user reported the following oops when a backup process read /proc/kcore. BUG: unable to handle kernel paging request at bb00ff33b000 IP: [8103157e] kern_addr_valid+0xbe/0x110 PGD 0 Oops: [#1] SMP CPU 6 Modules linked

[PATCH linux-next] x86: smpboot.c: Remove unused variable c

2013-02-12 Thread Stratos Karafotis
This patch removes the unused variable 'c' in mwait_play_dead and fixes the following warning: arch/x86/kernel/smpboot.c: In function ‘mwait_play_dead’: arch/x86/kernel/smpboot.c:1370:22: warning: unused variable ‘c’ [-Wunused-variable] Signed-off-by: Stratos Karafotis strat...@semaphore.gr ---

Re: [PATCH linux-next] befs: befs_fill_super(): remove unreachable code

2013-02-12 Thread Eric W. Biederman
Tim Gardner tim.gard...@canonical.com writes: befs_sb-num_blocks is of base type u64 which is the same as sector_t. Therefore, num_blocks can never be larger then the maximum value of sector_t. The analysys is wrong. On 32bit with CONFIG_LBAF unset sector_t is an unsigned long aka a u32,

Re: [PATCH V2] clk: tegra: initialise parent of uart clocks

2013-02-12 Thread Stephen Warren
On 02/12/2013 08:17 AM, Laxman Dewangan wrote: Initialise the parent of UARTs to PLLP and disabling clock by default. This patch wasn't tested, was it? Without the patch I just sent titled ARM: tegra: remove clock-frequency properties from serial nodes, the UART clocks get turned off and the

Re: [PATCH 1/3] nbd: support FLUSH requests

2013-02-12 Thread Alex Bligh
Paolo, Add support for a new flag that the server can pass. If the flag is enabled, we translate REQ_FLUSH requests into the NBD_CMD_FLUSH command. Cc: nbd-gene...@lists.sf.net Cc: Paul Clements paul.cleme...@steeleye.com Cc: Andrew Morton a...@linux-foundation.org Signed-off-by: Alex

Re: [tip:x86/mm] x86, mm: Use a bitfield to mask nuisance get_user() warnings

2013-02-12 Thread Linus Torvalds
On Tue, Feb 12, 2013 at 9:35 AM, H. Peter Anvin h...@zytor.com wrote: On the other hand, it still uses two gcc extensions: long long bitfields and typeof. I'll see what kind of code we get with the macro. At least one thing to look out for is the poor LLVM people who are trying to make the

Re: [PATCH v3 4/7] memcg: remove memcg from the reclaim iterators

2013-02-12 Thread Paul E. McKenney
On Tue, Feb 12, 2013 at 04:43:30PM +0100, Michal Hocko wrote: On Tue 12-02-13 10:10:02, Johannes Weiner wrote: On Tue, Feb 12, 2013 at 10:54:19AM +0100, Michal Hocko wrote: On Mon 11-02-13 17:39:43, Johannes Weiner wrote: On Mon, Feb 11, 2013 at 10:27:56PM +0100, Michal Hocko wrote:

Re: [PATCH v3 4/7] memcg: remove memcg from the reclaim iterators

2013-02-12 Thread Michal Hocko
On Tue 12-02-13 08:10:51, Paul E. McKenney wrote: On Tue, Feb 12, 2013 at 04:43:30PM +0100, Michal Hocko wrote: On Tue 12-02-13 10:10:02, Johannes Weiner wrote: On Tue, Feb 12, 2013 at 10:54:19AM +0100, Michal Hocko wrote: On Mon 11-02-13 17:39:43, Johannes Weiner wrote: On Mon, Feb

[PATCH linux-next] eCryptfs: decrypt_pki_encrypted_session_key(): remove kfree() redundant null check

2013-02-12 Thread Tim Gardner
smatch analysis: fs/ecryptfs/keystore.c:1206 decrypt_pki_encrypted_session_key() info: redundant null check on msg calling kfree() Cc: Tyler Hicks tyhi...@canonical.com Cc: Dustin Kirkland dustin.kirkl...@gazzang.com Cc: ecryp...@vger.kernel.org Signed-off-by: Tim Gardner

Re: [tip:x86/mm] x86, mm: Use a bitfield to mask nuisance get_user() warnings

2013-02-12 Thread Russell King - ARM Linux
On Tue, Feb 12, 2013 at 09:32:54AM -0800, Linus Torvalds wrote: On Tue, Feb 12, 2013 at 9:14 AM, H. Peter Anvin h...@zytor.com wrote: No, I think what he is talking about it this bit: Ok, I agree that the bitfield code actually looks cleaner. That said, maybe gcc has an easier time

Re: [PATCH] dw_dmac: adjust slave_id accordingly to request line base

2013-02-12 Thread Vinod Koul
On Tue, Feb 12, 2013 at 06:43:51PM +0200, Mika Westerberg wrote: On Tue, Feb 12, 2013 at 07:53:34AM -0800, Vinod Koul wrote: On Tue, Jan 29, 2013 at 10:29:43AM +0530, Viresh Kumar wrote: Next time, please direct these mails to my Linaro id :) On Mon, Jan 28, 2013 at 4:34 PM, Andy

Re: [PATCH -mm] i2c: style cleanups after idr_alloc() conversion

2013-02-12 Thread Jean Delvare
On Tue, 12 Feb 2013 09:36:48 -0800, Tejun Heo wrote: On Tue, Feb 12, 2013 at 09:34:14AM -0800, Tejun Heo wrote: Style cleanups suggested by Wolfram. * s/res/id/ in i2c_add_numbered_adapter() so that it matches i2c_add_adapter(). * Add a blank line before return in

[RFC][PATCH] tracing/syscalls: Have ia32 compat syscalls show raw format

2013-02-12 Thread Steven Rostedt
The tracing of ia32 compat system calls has been a bit of a pain as they use different system call numbers than the 64bit equivalents. I wrote a simple 'lls' program that lists files. I compiled it as a i686 ELF binary and ran it under a x86_64 box. This is the result: echo 0

Should SPARC use cpuidle? (was: linux-next: build failure after merge of the final tree (acpi tree related))

2013-02-12 Thread Len Brown
On 02/12/2013 12:35 PM, Sam Ravnborg wrote: Signed-off-by: Stephen Rothwell s...@canb.auug.org.au --- arch/sparc/include/asm/processor.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/sparc/include/asm/processor.h b/arch/sparc/include/asm/processor.h index 34baa35..622cfa5

Re: [PATCH 05/32] lib: devres: don't enclose pcim_*() functions in CONFIG_HAS_IOPORT

2013-02-12 Thread Arnd Bergmann
On Tuesday 12 February 2013, Thomas Petazzoni wrote: The pcim_*() functions are used by the libata-sff subsystem, and this subsystem is used for many SATA drivers on ARM platforms that do not necessarily have I/O ports. Signed-off-by: Thomas Petazzoni thomas.petazz...@free-electrons.com Cc:

Re: Should SPARC use cpuidle?

2013-02-12 Thread Len Brown
Can you please move the definition of sparc_idle to processor_32.h It is sparc32 specific - and then we do not need the __ASSEMBLY__ guards as the sparc32 variant are not used from assembler. sure, let me know if attached works. ugh, not accustomed to sending patches via thunderbird.

[PATCH linux-next] ecryptfs: ecryptfs_msg_ctx_alloc_to_free(): remove kfree() redundant null check

2013-02-12 Thread Tim Gardner
smatch analysis: fs/ecryptfs/messaging.c:101 ecryptfs_msg_ctx_alloc_to_free() info: redundant null check on msg_ctx-msg calling kfree() Cc: Tyler Hicks tyhi...@canonical.com Cc: Dustin Kirkland dustin.kirkl...@gazzang.com Cc: ecryp...@vger.kernel.org Signed-off-by: Tim Gardner

[PATCH v2 1/9] virtio: add functions for piecewise addition of buffers

2013-02-12 Thread Paolo Bonzini
virtio device drivers translate requests from higher layer in two steps: a device-specific step in the device driver, and generic preparation of virtio direct or indirect buffers in virtqueue_add_buf. Because virtqueue_add_buf also accepts the outcome of the first step as a single struct

Re: [PATCH 1/9] virtio: add functions for piecewise addition of buffers

2013-02-12 Thread Paolo Bonzini
Il 12/02/2013 18:34, Michael S. Tsirkin ha scritto: On Tue, Feb 12, 2013 at 05:57:55PM +0100, Paolo Bonzini wrote: Il 12/02/2013 17:35, Michael S. Tsirkin ha scritto: On Tue, Feb 12, 2013 at 05:17:47PM +0100, Paolo Bonzini wrote: Il 12/02/2013 17:13, Michael S. Tsirkin ha scritto: In this

Re: [PATCH] of: dma.c: fix memory leakage

2013-02-12 Thread Vinod Koul
On Tue, Jan 22, 2013 at 10:10:53AM +, Cong Ding wrote: On Sun, Jan 20, 2013 at 04:24:49PM -0600, Rob Herring wrote: On 01/19/2013 07:06 AM, Cong Ding wrote: The memory allocated to ofdma might be a leakage when error occurs. Signed-off-by: Cong Ding ding...@gmail.com You need

Re: [PATCH 1/3] nbd: support FLUSH requests

2013-02-12 Thread Paolo Bonzini
Il 12/02/2013 18:37, Alex Bligh ha scritto: For my education, why remove the FUA stuff? Because I had no way to test it. Hmmm... the underlying storage could be md/dm RAIDs in which case FUA should be cheaper than FLUSH. If someone ever wrote a virtio-blk backend that sits directly

Re: [PATCH linux-next] befs: befs_fill_super(): remove unreachable code

2013-02-12 Thread Tim Gardner
On 02/12/2013 10:46 AM, Eric W. Biederman wrote: Tim Gardner tim.gard...@canonical.com writes: befs_sb-num_blocks is of base type u64 which is the same as sector_t. Therefore, num_blocks can never be larger then the maximum value of sector_t. The analysys is wrong. On 32bit with

Re: [RFC][PATCH] tracing/syscalls: Have ia32 compat syscalls show raw format

2013-02-12 Thread H. Peter Anvin
What? Seriously, this has got to be a bad joke. Either I'm not getting something here or this is just a nonstarter. This feels like a hack upon a kluge upon a wart, and something that we'd have to support forever. No. Realize that syscall number does not, and never have, been a unique

Re: [PATCH linux-next] eCryptfs: decrypt_pki_encrypted_session_key(): remove kfree() redundant null check

2013-02-12 Thread Tyler Hicks
On 2013-02-12 10:56:54, Tim Gardner wrote: smatch analysis: fs/ecryptfs/keystore.c:1206 decrypt_pki_encrypted_session_key() info: redundant null check on msg calling kfree() Cc: Tyler Hicks tyhi...@canonical.com Cc: Dustin Kirkland dustin.kirkl...@gazzang.com Cc:

Re: [PATCH linux-next] ecryptfs: ecryptfs_msg_ctx_alloc_to_free(): remove kfree() redundant null check

2013-02-12 Thread Tyler Hicks
On 2013-02-12 11:03:49, Tim Gardner wrote: smatch analysis: fs/ecryptfs/messaging.c:101 ecryptfs_msg_ctx_alloc_to_free() info: redundant null check on msg_ctx-msg calling kfree() Cc: Tyler Hicks tyhi...@canonical.com Cc: Dustin Kirkland dustin.kirkl...@gazzang.com Cc:

Re: [PATCH 2/2] ima: Support appraise_type=imasig_optional

2013-02-12 Thread Mimi Zohar
On Tue, 2013-02-12 at 09:26 -0500, Vivek Goyal wrote: On Mon, Feb 11, 2013 at 05:10:14PM -0500, Mimi Zohar wrote: On Mon, 2013-02-11 at 15:11 -0500, Vivek Goyal wrote: appraise_type=imasig_optional will allow appraisal to pass even if no signatures are present on the file. If signatures

Re: [PATCH V4 1/2] get_maintainer: allow keywords to match filenames

2013-02-12 Thread Stephen Warren
On 02/11/2013 11:17 PM, Joe Perches wrote: On Mon, 2013-02-11 at 17:39 -0700, Stephen Warren wrote: From: Stephen Warren swar...@nvidia.com Allow K: entries in MAINTAINERS to match directly against filenames; either those extracted from patch +++ or --- lines, or those specified on the

[PATCH linux-next] hugetlbfs: hugetlbfs_fill_super(): remove kfree() redundant null check

2013-02-12 Thread Tim Gardner
smatch analysis: fs/hugetlbfs/inode.c:883 hugetlbfs_fill_super() info: redundant null check on sbinfo-spool calling kfree() Cc: Nadia Yvette Chambers n...@holomorphy.com Signed-off-by: Tim Gardner tim.gard...@canonical.com --- fs/hugetlbfs/inode.c |3 +-- 1 file changed, 1 insertion(+), 2

Re: [PATCH v2 6/6] of_spi: Initialize cs_gpios and cs_gpio with -EEXIST

2013-02-12 Thread Grant Likely
On Tue, 12 Feb 2013 10:46:27 +0100, Andreas Larsson andr...@gaisler.com wrote: On 2013-02-11 01:23, Grant Likely wrote: On Tue, 29 Jan 2013 15:53:43 +0100, Andreas Larsson andr...@gaisler.com wrote: Holes in the cs-gpios DT phandle list is supposed to mark that native chipselects is to

Re: [PATCH 1/9] virtio: add functions for piecewise addition of buffers

2013-02-12 Thread Michael S. Tsirkin
On Tue, Feb 12, 2013 at 07:04:27PM +0100, Paolo Bonzini wrote: Perhaps, but 3 or 4 arguments (in/out/nsg or in/out/nsg_in/nsg_out) just for this are definitely too many and make the API harder to use. You have to find a balance. Having actually used the API, the possibility of mixing

Re: [PATCH] of: Create function for counting number of phandles in a property

2013-02-12 Thread Grant Likely
On Tue, 12 Feb 2013 10:18:10 +0100, Andreas Larsson andr...@gaisler.com wrote: On 2013-02-11 00:58, Grant Likely wrote: This patch creates of_count_phandle_with_args(), a new function for counting the number of phandle+argument tuples in a given property. This is better than the existing

Re: [PATCH v8 2/4] misc: Generic on-chip SRAM allocation driver

2013-02-12 Thread Grant Likely
On Mon, 11 Feb 2013 19:15:24 +0100, Philipp Zabel p.za...@pengutronix.de wrote: Hi Grant, Am Freitag, den 08.02.2013, 20:16 + schrieb Grant Likely: On Mon, 4 Feb 2013 12:32:16 +0100, Philipp Zabel p.za...@pengutronix.de wrote: This driver requests and remaps a memory region as

Re: [PATCH] of: Create function for counting number of phandles in a property

2013-02-12 Thread Grant Likely
On Mon, 11 Feb 2013 12:26:15 +0100, Andreas Larsson andr...@gaisler.com wrote: On 2013-02-11 00:58, Grant Likely wrote: diff --git a/drivers/of/base.c b/drivers/of/base.c index 2390ddb..e1120a2 100644 --- a/drivers/of/base.c +++ b/drivers/of/base.c @@ -1025,12 +1025,13 @@

[PATCH V2 1/3] of/selftest: Fix GPIOs selftest to cover the 7th case

2013-02-12 Thread Grant Likely
The of_gpio_named_count() self test doesn't hit the out-of-range condition even though it is coded. Fix the bug by increasing the for loop range by one. Reported-by: Andreas Larsson andr...@gaisler.com Cc: Rob Herring rob.herr...@calxeda.com Signed-off-by: Grant Likely grant.lik...@secretlab.ca

Re: [PATCH v2 5/6] of_spi: Add fetching of of_gpio flags to of_spi_register_master

2013-02-12 Thread Grant Likely
On Tue, 12 Feb 2013 10:39:02 +0100, Andreas Larsson andr...@gaisler.com wrote: On 2013-02-11 01:22, Grant Likely wrote: On Tue, 29 Jan 2013 15:53:42 +0100, Andreas Larsson andr...@gaisler.com wrote: When using a gpio chip select with a OF_GPIO_ACTIVE_LOW flag, this needs to be known

Re: [PATCH V8] kbuild: create a rule to run the pre-processor on *.dts files

2013-02-12 Thread Grant Likely
On Mon, 11 Feb 2013 12:11:22 -0700, Stephen Warren swar...@wwwdotorg.org wrote: On 02/08/2013 08:45 AM, Grant Likely wrote: On Tue, 5 Feb 2013 12:06:28 -0700, Stephen Warren swar...@wwwdotorg.org wrote: Create cmd_dtc_cpp to run the C pre-processor on *.dts file before passing them to

[PATCH V2 3/3] gpio: Make of_count_named_gpios() use new of_count_phandle_with_args()

2013-02-12 Thread Grant Likely
This patch replaces the horribly coded of_count_named_gpios() with a call to of_count_phandle_with_args() which is far more efficient. This also changes the return value of of_gpio_count() of_gpio_named_count() from 'unsigned int' to 'int' so that it can return an error code. All the users of

[PATCH V2 2/3] of: Create function for counting number of phandles in a property

2013-02-12 Thread Grant Likely
This patch creates of_count_phandle_with_args(), a new function for counting the number of phandle+argument tuples in a given property. This is better than the existing method of parsing each phandle individually until parsing fails which is a horribly slow way to do the count. It also converts

<    5   6   7   8   9   10   11   12   13   14   >