Re: [RFC PATCH 5/5] vsock: Add an ioctl request to get all CIDs

2024-05-23 Thread Stefano Garzarella
On Fri, May 17, 2024 at 10:46:07PM GMT, Xuewei Niu wrote: The new request is called `IOCTL_VM_SOCKETS_GET_LOCAL_CIDS`. And the old one, `IOCTL_VM_SOCKETS_GET_LOCAL_CID` is retained. For the transport that supports multi-devices: * `IOCTL_VM_SOCKETS_GET_LOCAL_CID` returns "-1";

[RESEND PATCH v5 6/7] remoteproc: stm32: Create sub-functions to request shutdown and release

2024-05-21 Thread Arnaud Pouliquen
*name) return -EINVAL; } +static void stm32_rproc_request_shutdown(struct rproc *rproc) +{ + struct stm32_rproc *ddata = rproc->priv; + int err, dummy_data, idx; + + /* Request shutdown of the remote processor */ + if (rproc->state != RPROC_OFFLINE &&

[PATCH v5 6/7] remoteproc: stm32: Create sub-functions to request shutdown and release

2024-05-21 Thread Arnaud Pouliquen
*name) return -EINVAL; } +static void stm32_rproc_request_shutdown(struct rproc *rproc) +{ + struct stm32_rproc *ddata = rproc->priv; + int err, dummy_data, idx; + + /* Request shutdown of the remote processor */ + if (rproc->state != RPROC_OFFLINE &&

[RFC PATCH 5/5] vsock: Add an ioctl request to get all CIDs

2024-05-17 Thread Xuewei Niu
The new request is called `IOCTL_VM_SOCKETS_GET_LOCAL_CIDS`. And the old one, `IOCTL_VM_SOCKETS_GET_LOCAL_CID` is retained. For the transport that supports multi-devices: * `IOCTL_VM_SOCKETS_GET_LOCAL_CID` returns "-1"; * `IOCTL_VM_SOCKETS_GET_LOCAL_CIDS` returns a vector of CIDS.

Re: [PATCH v3 2/2] virtiofs: use GFP_NOFS when enqueuing request through kworker

2024-05-10 Thread Hou Tao
ctly, >> GFP_KERNEL and memalloc_nofs_{save|restore} helpers are used instead. > Makes sense. > > However, I don't understand why the GFP_NOFS behavior is optional. It > should work when queuing the request for the first time as well, no? No. fuse_request_queue_background() may ca

Re: [PATCH v3 2/2] virtiofs: use GFP_NOFS when enqueuing request through kworker

2024-05-10 Thread Miklos Szeredi
Makes sense. However, I don't understand why the GFP_NOFS behavior is optional. It should work when queuing the request for the first time as well, no? Thanks, Miklos

BUG: unable to handle kernel paging request in do_split

2024-04-29 Thread Ubisectech Sirius
Hello. We are Ubisectech Sirius Team, the vulnerability lab of China ValiantSec. Recently, our team has discovered a issue in Linux kernel 6.7. Attached to the email were a PoC file of the issue. Stack dump: BUG: unable to handle page fault for address: ed110c2fd97f #PF: supervisor read

[PATCH v3 2/2] virtiofs: use GFP_NOFS when enqueuing request through kworker

2024-04-26 Thread Hou Tao
GFP_ATOMIC); + req->argbuf = kmalloc(len, gfp); if (!req->argbuf) return -ENOMEM; @@ -1183,7 +1188,8 @@ static unsigned int sg_init_fuse_args(struct scatterlist *sg, /* Add a request to a virtqueue and kick the device */ static in

Re: [PATCH v4 3/4] remoteproc: stm32: Create sub-functions to request shutdown and release

2024-03-25 Thread Mathieu Poirier
rs/remoteproc/stm32_rproc.c > @@ -209,6 +209,54 @@ static int stm32_rproc_mbox_idx(struct rproc *rproc, > const unsigned char *name) > return -EINVAL; > } > > +static void stm32_rproc_request_shutdown(struct rproc *rproc) > +{ > + struct stm32_rproc *ddata = rproc-

[PATCH v4 3/4] remoteproc: stm32: Create sub-functions to request shutdown and release

2024-03-08 Thread Arnaud Pouliquen
) return -EINVAL; } +static void stm32_rproc_request_shutdown(struct rproc *rproc) +{ + struct stm32_rproc *ddata = rproc->priv; + int err, dummy_data, idx; + + /* Request shutdown of the remote processor */ + if (rproc->state != RPROC_OFFLINE &&

[PATCH v2 6/6] virtiofs: use GFP_NOFS when enqueuing request through kworker

2024-02-28 Thread Hou Tao
@@ -1332,7 +1337,8 @@ static bool use_scattered_argbuf(struct fuse_req *req) /* Add a request to a virtqueue and kick the device */ static int virtio_fs_enqueue_req(struct virtio_fs_vq *fsvq, -struct fuse_req *req, bool in_flight) +

[PATCH v3 6/7] remoteproc: stm32: Create sub-functions to request shutdown and release

2024-02-14 Thread Arnaud Pouliquen
) return -EINVAL; } +static void stm32_rproc_request_shutdown(struct rproc *rproc) +{ + struct stm32_rproc *ddata = rproc->priv; + int err, dummy_data, idx; + + /* Request shutdown of the remote processor */ + if (rproc->state != RPROC_OFFLINE &&

Re: [syzbot] [fs?] [trace?] BUG: unable to handle kernel paging request in tracefs_apply_options

2024-02-12 Thread syzbot
syzbot suspects this issue was fixed by commit: commit ad579864637af46447208254719943179b69d41a Author: Steven Rostedt (Google) Date: Tue Jan 2 20:12:49 2024 + tracefs: Check for dentry->d_inode exists in set_gid() bisection log:

[PATCH v2 3/4] remoteproc: stm32: Create sub-functions to request shutdown and release

2024-01-18 Thread Arnaud Pouliquen
) return -EINVAL; } +static void stm32_rproc_request_shutdown(struct rproc *rproc) +{ + struct stm32_rproc *ddata = rproc->priv; + int err, dummy_data, idx; + + /* Request shutdown of the remote processor */ + if (rproc->state != RPROC_OFFLINE &&

BUG: unable to handle kernel paging request in __skb_flow_dissect

2024-01-16 Thread Ubisectech Sirius
Hello. We are Ubisectech Sirius Team, the vulnerability lab of China ValiantSec. Recently, our team has discovered a issue in Linux kernel 6.7.0-g052d534373b7. Attached to the email were a POC file of the issue. Stack dump: [ 185.664167][ T8332] BUG: unable to handle page fault for address:

[PATCH 3/4] remoteproc: stm32: create sub-functions to request shutdown and release

2024-01-15 Thread Arnaud Pouliquen
) return -EINVAL; } +static void stm32_rproc_request_shutdown(struct rproc *rproc) +{ + struct stm32_rproc *ddata = rproc->priv; + int err, dummy_data, idx; + + /* Request shutdown of the remote processor */ + if (rproc->state != RPROC_OFFLINE &&

Re: [PATCH v2] virtiofs: use GFP_NOFS when enqueuing request through kworker

2024-01-08 Thread Benjamin Coddington
On 5 Jan 2024, at 5:53, Hou Tao wrote: > From: Hou Tao > > When invoking virtio_fs_enqueue_req() through kworker, both the > allocation of the sg array and the bounce buffer still use GFP_ATOMIC. > Considering the size of both the sg array and the bounce buffer may be > greater than PAGE_SIZE,

Re: [PATCH v2] virtiofs: use GFP_NOFS when enqueuing request through kworker

2024-01-05 Thread Hou Tao
Hi Vivek, On 1/6/2024 5:27 AM, Vivek Goyal wrote: > On Fri, Jan 05, 2024 at 08:57:55PM +, Matthew Wilcox wrote: >> On Fri, Jan 05, 2024 at 03:41:48PM -0500, Vivek Goyal wrote: >>> On Fri, Jan 05, 2024 at 08:21:00PM +, Matthew Wilcox wrote: On Fri, Jan 05, 2024 at 03:17:19PM -0500,

Re: [PATCH v2] virtiofs: use GFP_NOFS when enqueuing request through kworker

2024-01-05 Thread Hou Tao
On 1/6/2024 4:21 AM, Matthew Wilcox wrote: > On Fri, Jan 05, 2024 at 03:17:19PM -0500, Vivek Goyal wrote: >> On Fri, Jan 05, 2024 at 06:53:05PM +0800, Hou Tao wrote: >>> From: Hou Tao >>> >>> When invoking virtio_fs_enqueue_req() through kworker, both the >>> allocation of the sg array and the

Re: [PATCH v2] virtiofs: use GFP_NOFS when enqueuing request through kworker

2024-01-05 Thread Vivek Goyal
On Fri, Jan 05, 2024 at 08:57:55PM +, Matthew Wilcox wrote: > On Fri, Jan 05, 2024 at 03:41:48PM -0500, Vivek Goyal wrote: > > On Fri, Jan 05, 2024 at 08:21:00PM +, Matthew Wilcox wrote: > > > On Fri, Jan 05, 2024 at 03:17:19PM -0500, Vivek Goyal wrote: > > > > On Fri, Jan 05, 2024 at

Re: [PATCH v2] virtiofs: use GFP_NOFS when enqueuing request through kworker

2024-01-05 Thread Matthew Wilcox
On Fri, Jan 05, 2024 at 03:41:48PM -0500, Vivek Goyal wrote: > On Fri, Jan 05, 2024 at 08:21:00PM +, Matthew Wilcox wrote: > > On Fri, Jan 05, 2024 at 03:17:19PM -0500, Vivek Goyal wrote: > > > On Fri, Jan 05, 2024 at 06:53:05PM +0800, Hou Tao wrote: > > > > From: Hou Tao > > > > > > > >

Re: [PATCH v2] virtiofs: use GFP_NOFS when enqueuing request through kworker

2024-01-05 Thread Vivek Goyal
On Fri, Jan 05, 2024 at 08:21:00PM +, Matthew Wilcox wrote: > On Fri, Jan 05, 2024 at 03:17:19PM -0500, Vivek Goyal wrote: > > On Fri, Jan 05, 2024 at 06:53:05PM +0800, Hou Tao wrote: > > > From: Hou Tao > > > > > > When invoking virtio_fs_enqueue_req() through kworker, both the > > >

Re: [PATCH v2] virtiofs: use GFP_NOFS when enqueuing request through kworker

2024-01-05 Thread Matthew Wilcox
On Fri, Jan 05, 2024 at 03:17:19PM -0500, Vivek Goyal wrote: > On Fri, Jan 05, 2024 at 06:53:05PM +0800, Hou Tao wrote: > > From: Hou Tao > > > > When invoking virtio_fs_enqueue_req() through kworker, both the > > allocation of the sg array and the bounce buffer still use GFP_ATOMIC. > >

Re: [PATCH v2] virtiofs: use GFP_NOFS when enqueuing request through kworker

2024-01-05 Thread Vivek Goyal
t, args->out_args); > > - req->argbuf = kmalloc(len, GFP_ATOMIC); > + req->argbuf = kmalloc(len, gfp); > if (!req->argbuf) > return -ENOMEM; > > @@ -1119,7 +1120,8 @@ static unsigned int sg_init_fuse_args(struct > scatterlist *sg, >

[PATCH v2] virtiofs: use GFP_NOFS when enqueuing request through kworker

2024-01-05 Thread Hou Tao
@@ -1119,7 +1120,8 @@ static unsigned int sg_init_fuse_args(struct scatterlist *sg, /* Add a request to a virtqueue and kick the device */ static int virtio_fs_enqueue_req(struct virtio_fs_vq *fsvq, -struct fuse_req *req, bool in_flight) +

Re: [PATCH] virtiofs: use GFP_NOFS when enqueuing request through kworker

2024-01-03 Thread Matthew Wilcox
On Thu, Jan 04, 2024 at 09:58:05AM +0800, Hou Tao wrote: > static int virtio_fs_enqueue_req(struct virtio_fs_vq *fsvq, > - struct fuse_req *req, bool in_flight); > + struct fuse_req *req, bool in_flight, > +

[PATCH] virtiofs: use GFP_NOFS when enqueuing request through kworker

2024-01-03 Thread Hou Tao
req->argbuf = kmalloc(len, gfp); if (!req->argbuf) return -ENOMEM; @@ -1119,7 +1120,8 @@ static unsigned int sg_init_fuse_args(struct scatterlist *sg, /* Add a request to a virtqueue and kick the device */ static int virtio_fs_enqueue_req(struct virtio_fs_vq *fs

Re: [syzbot] [fs?] [trace?] BUG: unable to handle kernel paging request in tracefs_apply_options

2024-01-03 Thread Steven Rostedt
On Wed, 03 Jan 2024 13:41:31 -0800 syzbot wrote: > Hello, > > syzbot found the following issue on: > > HEAD commit:453f5db0619e Merge tag 'trace-v6.7-rc7' of git://git.kerne.. > git tree: upstream > console+strace: https://syzkaller.appspot.com/x/log.txt?x=10ec3829e8 > kernel

[syzbot] [fs?] [trace?] BUG: unable to handle kernel paging request in tracefs_apply_options

2024-01-03 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:453f5db0619e Merge tag 'trace-v6.7-rc7' of git://git.kerne.. git tree: upstream console+strace: https://syzkaller.appspot.com/x/log.txt?x=10ec3829e8 kernel config: https://syzkaller.appspot.com/x/.config?x=f8e72bae38c079e4

Re: BUG: unable to handle kernel paging request in bpf_probe_read_compat_str

2023-12-20 Thread Hou Tao
and lastest net bpf titled BUG: >>> unable to handle kernel paging request in bpf_probe_read_compat_str >>> >>> If you fix this issue, please add the following tag to the commit: >>> Reported-by: xingwei Lee >>> >>> kernel: net 9702817384aa4

Re: BUG: unable to handle kernel paging request in bpf_probe_read_compat_str

2023-12-20 Thread Yonghong Song
On 12/20/23 1:19 AM, Hou Tao wrote: Hi, On 12/14/2023 11:40 AM, xingwei lee wrote: Hello I found a bug in net/bpf in the lastest upstream linux and comfired in the lastest net tree and lastest net bpf titled BUG: unable to handle kernel paging request in bpf_probe_read_compat_str If you fix

Re: BUG: unable to handle kernel paging request in bpf_probe_read_compat_str

2023-12-20 Thread Hou Tao
Hi, On 12/14/2023 11:40 AM, xingwei lee wrote: > Hello I found a bug in net/bpf in the lastest upstream linux and > comfired in the lastest net tree and lastest net bpf titled BUG: > unable to handle kernel paging request in bpf_probe_read_compat_str > > If you fix this is

BUG: unable to handle kernel paging request in bpf_probe_read_compat_str

2023-12-13 Thread xingwei lee
Hello I found a bug in net/bpf in the lastest upstream linux and comfired in the lastest net tree and lastest net bpf titled BUG: unable to handle kernel paging request in bpf_probe_read_compat_str If you fix this issue, please add the following tag to the commit: Reported-by: xingwei Lee

Re: [PATCH] ASoC: fsl: imx-pcm-dma: Don't request dma channel in probe

2021-04-20 Thread Lucas Stach
t; > > > Hi > > > > > > > > > > > > > > On Tue, May 19, 2020 at 6:04 PM Lucas Stach > > > > > > > > > > > > > wrote: > > > > > > > > Am Dienstag, den 19.05.2020, 17:41 +0800 schrieb Shengjiu

RE: [PATCH] ASoC: fsl: imx-pcm-dma: Don't request dma channel in probe

2021-04-20 Thread Robin Gong
; > > > > > > > > > wrote: > > > > > > > Am Dienstag, den 19.05.2020, 17:41 +0800 schrieb Shengjiu Wang: > > > > > > > > There are two requirements that we need to move the > > > > > > > > request of

RE: [net-next 1/3] net: dsa: optimize tx timestamp request handling

2021-04-20 Thread Y.b. Lu
idelot ; Florian > Fainelli ; Claudiu Manoil ; > Alexandre Belloni ; > unglinuxdri...@microchip.com; linux-...@vger.kernel.org; > linux-kernel@vger.kernel.org > Subject: Re: [net-next 1/3] net: dsa: optimize tx timestamp request handling > > On Fri, Apr 16, 2021 at 08:36:53PM +0800,

RE: [net-next 1/3] net: dsa: optimize tx timestamp request handling

2021-04-20 Thread Y.b. Lu
n Fainelli ; Claudiu Manoil > ; Alexandre Belloni > ; unglinuxdri...@microchip.com; > linux-...@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [net-next 1/3] net: dsa: optimize tx timestamp request handling > > On Fri, Apr 16, 2021 at 08:36:53PM +0800, Yangbo Lu wrote: > >

RE: [net-next 1/3] net: dsa: optimize tx timestamp request handling

2021-04-20 Thread Y.b. Lu
Didelot ; Florian Fainelli ; > Claudiu Manoil ; Alexandre Belloni > ; unglinuxdri...@microchip.com; > linux-...@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [net-next 1/3] net: dsa: optimize tx timestamp request handling > > On Sun, Apr 18, 2021 at 12:18:42PM +0300, Vladimi

[PATCH v2 2/2] usb: cdnsp: Fix lack of removing request from pending list.

2021-04-19 Thread Pawel Laszczak
From: Pawel Laszczak Patch fixes lack of removing request from ep->pending_list on failure of the stop endpoint command. Driver even after failing this command must remove request from ep->pending_list. Without this fix driver can stuck in cdnsp_gadget_ep_disable function in loop:

Re: [PATCH 2/2] usb: cdnsp: Fix lack of removing request from pending list.

2021-04-19 Thread Peter Chen
On 21-04-19 09:53:11, Pawel Laszczak wrote: > From: Pawel Laszczak > > Patch fixes lack of removing request from ep->pending_list on failure > of the stop endpoint command. Driver even after failing this command > must remove request from ep->pending_list. > Without t

Re: [PATCH] usb: dwc3: gadget: Avoid canceling current request for queuing error

2021-04-19 Thread Thinh Nguyen
> >>>>>> If an error is received when issuing a start or update transfer >>>>>> command, the error handler will stop all active requests (including >>>>>> the current USB request), and call dwc3_gadget_giveback() to notify

Re: [PATCH] usb: dwc3: gadget: Avoid canceling current request for queuing error

2021-04-19 Thread Wesley Cheng
g a start or update transfer >>>>> command, the error handler will stop all active requests (including >>>>> the current USB request), and call dwc3_gadget_giveback() to notify >>>>> function drivers of the requests which have been stopped. Avoid >&g

pull request: linux-firmware: update cxgb4 firmware to 1.25.4.0

2021-04-19 Thread Raju Rangoju
Hi Josh, I've adjusted the actual file entries now. Can you please pull the new firmware from the following URL? git://git.chelsio.net/pub/git/linux-firmware.git for-upstream Thanks, Raju The following changes since commit f66adc3cde7ee0607ea9198ca460031d3564fb33: Merge branch 'main' of

RE: pull request: linux-firmware: update cxgb4 firmware to 1.25.4.0

2021-04-19 Thread Raju Rangoju
Josh, thanks for pointing that out. I'll send the new pull request shortly. -Raju -Original Message- From: Josh Boyer Sent: Monday, 19 April, 2021 19:28 To: Raju Rangoju Cc: linux-firmw...@kernel.org; linux-kernel@vger.kernel.org; Ramaraju Yelavarthy ; Rahul Lakkireddy Subject: Re

[PATCH 5.4 68/73] r8169: fix performance regression related to PCIe max read request size

2021-04-19 Thread Greg Kroah-Hartman
revert the original change, just use pcie_set_readrq() now instead of changing the PCIe capability register directly. Fixes: 2df49d365498 ("r8169: remove fiddling with the PCIe max read request size") Signed-off-by: Heiner Kallweit Signed-off-by: David S. Miller Signed-off-by: S

[PATCH 5.4 66/73] r8169: remove fiddling with the PCIe max read request size

2021-04-19 Thread Greg Kroah-Hartman
From: Heiner Kallweit [ Upstream commit 2df49d36549808a7357ad9f78b7a8e39516e7809 ] The attempt to improve performance by changing the PCIe max read request size was added in the vendor driver more than 10 years back and copied to r8169 driver. In the vendor driver this has been removed long ago

[PATCH 5.4 70/73] r8169: tweak max read request size for newer chips also in jumbo mtu mode

2021-04-19 Thread Greg Kroah-Hartman
From: Heiner Kallweit [ Upstream commit 5e00e16cb98935bcf06f51931876d898c226f65c ] So far we don't increase the max read request size if we switch to jumbo mode before bringing up the interface for the first time. Let's change this. Signed-off-by: Heiner Kallweit Signed-off-by: Jakub Kicinski

[PATCH 5.10 095/103] r8169: tweak max read request size for newer chips also in jumbo mtu mode

2021-04-19 Thread Greg Kroah-Hartman
From: Heiner Kallweit [ Upstream commit 5e00e16cb98935bcf06f51931876d898c226f65c ] So far we don't increase the max read request size if we switch to jumbo mode before bringing up the interface for the first time. Let's change this. Signed-off-by: Heiner Kallweit Signed-off-by: Jakub Kicinski

[PATCH 5.11 115/122] r8169: tweak max read request size for newer chips also in jumbo mtu mode

2021-04-19 Thread Greg Kroah-Hartman
From: Heiner Kallweit [ Upstream commit 5e00e16cb98935bcf06f51931876d898c226f65c ] So far we don't increase the max read request size if we switch to jumbo mode before bringing up the interface for the first time. Let's change this. Signed-off-by: Heiner Kallweit Signed-off-by: Jakub Kicinski

Re: [PATCH] ASoC: fsl: imx-pcm-dma: Don't request dma channel in probe

2021-04-19 Thread Lucas Stach
t; > Am Mittwoch, den 20.05.2020, 16:20 +0800 schrieb Shengjiu Wang: > > > > > Hi > > > > > > > > > > On Tue, May 19, 2020 at 6:04 PM Lucas Stach > > > > > > > > > wrote: > > > > > > Am Dienstag, den 19.05.2020,

[PATCH 2/2] usb: cdnsp: Fix lack of removing request from pending list.

2021-04-19 Thread Pawel Laszczak
From: Pawel Laszczak Patch fixes lack of removing request from ep->pending_list on failure of the stop endpoint command. Driver even after failing this command must remove request from ep->pending_list. Without this fix driver can stuck in cdnsp_gadget_ep_disable function in loop:

RE: [PATCH] ASoC: fsl: imx-pcm-dma: Don't request dma channel in probe

2021-04-19 Thread Robin Gong
gt; > > > > > On Tue, May 19, 2020 at 6:04 PM Lucas Stach > > > > > > > wrote: > > > > > Am Dienstag, den 19.05.2020, 17:41 +0800 schrieb Shengjiu Wang: > > > > > > There are two requirements that we need to move the request o

Re: [net-next 1/3] net: dsa: optimize tx timestamp request handling

2021-04-19 Thread Kurt Kanzenbach
On Fri Apr 16 2021, Yangbo Lu wrote: > Optimization could be done on dsa_skb_tx_timestamp(), and dsa device > drivers should adapt to it. > > - Check SKBTX_HW_TSTAMP request flag at the very beginning, instead of in > port_txtstamp, so that most skbs not requiring tx timest

Re: [net-next 1/3] net: dsa: optimize tx timestamp request handling

2021-04-18 Thread Richard Cochran
On Sun, Apr 18, 2021 at 12:18:42PM +0300, Vladimir Oltean wrote: > > How about not passing "clone" back to DSA as an argument by reference, > but instead require the driver to populate DSA_SKB_CB(skb)->clone if it > needs to do so? > > Also, how about changing the return type to void? Returning

Re: [net-next 1/3] net: dsa: optimize tx timestamp request handling

2021-04-18 Thread Richard Cochran
e them, and pass them to the > - * switch driver > - */ > + /* Handle tx timestamp request if has */ "if has" what? > dsa_skb_tx_timestamp(p, skb); > > if (dsa_realloc_skb(skb, dev)) { > -- > 2.25.1 > Thanks, Richard

Re: [net-next 1/3] net: dsa: optimize tx timestamp request handling

2021-04-18 Thread Richard Cochran
On Fri, Apr 16, 2021 at 08:36:53PM +0800, Yangbo Lu wrote: > Optimization could be done on dsa_skb_tx_timestamp(), and dsa device > drivers should adapt to it. > > - Check SKBTX_HW_TSTAMP request flag at the very beginning, instead of in > port_txtstamp, so that most skbs n

Re: [PATCH] kernel:irq:manage: request threaded irq with a specified priority

2021-04-18 Thread chensong
read which can be applied upfront. There are ~5400 instances of request*irq() in the kernel source and there is no way to make priority decisions for them which work for every RT system out there. The kernel sets a default and the system designer, admin, user has to take care of tuning it to m

Re: [net-next 1/3] net: dsa: optimize tx timestamp request handling

2021-04-18 Thread Vladimir Oltean
On Fri, Apr 16, 2021 at 08:36:53PM +0800, Yangbo Lu wrote: > Optimization could be done on dsa_skb_tx_timestamp(), and dsa device > drivers should adapt to it. > > - Check SKBTX_HW_TSTAMP request flag at the very beginning, instead of in > port_txtstamp, so that most skbs n

Re: [PULL REQUEST] i2c for 5.12

2021-04-17 Thread pr-tracker-bot
The pull request you sent on Sat, 17 Apr 2021 19:18:16 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/for-current has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/194cf4825638256e9afe1d360831aa5379b3517a Thank you! -- Deet-doot-dot, I

[PULL REQUEST] i2c for 5.12

2021-04-17 Thread Wolfram Sang
Linus, here is one more driver bugfix for I2C. Please pull. Thanks, Wolfram The following changes since commit d434405aaab7d0ebc516b68a8fc4100922d7f5ef: Linux 5.12-rc7 (2021-04-11 15:16:13 -0700) are available in the Git repository at:

[PATCH 5/7] habanalabs: request f/w in separate function

2021-04-17 Thread Oded Gabbay
From: Ohad Sharabi This refactor is needed due to the dynamic FW load in which requesting the FW file (and getting its attributes) is not immediately followed by copying FW file content. Signed-off-by: Ohad Sharabi Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay ---

[PATCH V1] fuse: Set fuse request error upon fuse abort connection

2021-04-16 Thread Pradeep P V K
There is a minor race in setting the fuse out request error between fuse_abort_conn() and fuse_dev_do_read() as explained below. Thread-1 Thread-2 ->fuse_simple_request() ->shutdown ->__fuse_req

[net-next 1/3] net: dsa: optimize tx timestamp request handling

2021-04-16 Thread Yangbo Lu
Optimization could be done on dsa_skb_tx_timestamp(), and dsa device drivers should adapt to it. - Check SKBTX_HW_TSTAMP request flag at the very beginning, instead of in port_txtstamp, so that most skbs not requiring tx timestamp just return. - No longer to identify PTP packets, and limit tx

Re: [RFC PATCH 2/2] bfq/mq-deadline: remove redundant check for passthrough request

2021-04-16 Thread Jens Axboe
On 4/14/21 9:43 PM, Lin Feng wrote: > Since commit 01e99aeca39796003 'blk-mq: insert passthrough request into > hctx->dispatch directly', passthrough request should not appear in > IO-scheduler any more, so blk_rq_is_passthrough checking in addon IO > schedulers is redunda

Re: [PATCH 1/2] blk-mq: bypass IO scheduler's limit_depth for passthrough request

2021-04-16 Thread Jens Axboe
On 4/14/21 9:39 PM, Lin Feng wrote: > Commit 01e99aeca39796003 ("blk-mq: insert passthrough request into > hctx->dispatch directly") gives high priority to passthrough requests and > bypass underlying IO scheduler. But as we allocate tag for such request it > still run

Re: [PATCH] kernel:irq:manage: request threaded irq with a specified priority

2021-04-16 Thread Thomas Gleixner
and be completely wrong for all others. > Further, what if irq handlear thread has to run on the expected priority > at the very beginning? This patch helps. There is no such thing as the expected priority of an interrupt thread which can be applied upfront. There are ~5400 instances of request*i

Re: [PATCH] kernel:irq:manage: request threaded irq with a specified priority

2021-04-16 Thread Daniel Bristot de Oliveira
On 4/16/21 6:57 AM, chensong wrote: > > > On 2021/4/13 下午4:39, Thomas Gleixner wrote: >> On Tue, Apr 13 2021 at 14:19, Song Chen wrote: >>> In general, irq handler thread will be assigned a default priority which >>> is MAX_RT_PRIO/2, as a result, no one can preempt others. >>> >>> Here is the 

Re: [PATCH] kernel:irq:manage: request threaded irq with a specified priority

2021-04-15 Thread chensong
On 2021/4/13 下午4:39, Thomas Gleixner wrote: On Tue, Apr 13 2021 at 14:19, Song Chen wrote: In general, irq handler thread will be assigned a default priority which is MAX_RT_PRIO/2, as a result, no one can preempt others. Here is the case I found in a real project, an interrupt int_a is

Re: [RFC PATCH 2/2] bfq/mq-deadline: remove redundant check for passthrough request

2021-04-15 Thread Ming Lei
On Thu, Apr 15, 2021 at 11:43:26AM +0800, Lin Feng wrote: > Since commit 01e99aeca39796003 'blk-mq: insert passthrough request into > hctx->dispatch directly', passthrough request should not appear in > IO-scheduler any more, so blk_rq_is_passthrough checking in addon IO > schedule

Re: [PATCH 1/2] blk-mq: bypass IO scheduler's limit_depth for passthrough request

2021-04-15 Thread Ming Lei
On Thu, Apr 15, 2021 at 11:39:20AM +0800, Lin Feng wrote: > Commit 01e99aeca39796003 ("blk-mq: insert passthrough request into > hctx->dispatch directly") gives high priority to passthrough requests and > bypass underlying IO scheduler. But as we allocate tag for such requ

Re: [PATCH] usb: dwc3: gadget: Avoid canceling current request for queuing error

2021-04-15 Thread Thinh Nguyen
Thinh Nguyen wrote: > Wesley Cheng wrote: >> >> >> On 4/14/2021 11:26 PM, Felipe Balbi wrote: >>> Wesley Cheng writes: >>> >>>> If an error is received when issuing a start or update transfer >>>> command, the error handler will s

Re: [PATCH] usb: dwc3: gadget: Avoid canceling current request for queuing error

2021-04-15 Thread Thinh Nguyen
Wesley Cheng wrote: > > > On 4/14/2021 11:26 PM, Felipe Balbi wrote: >> Wesley Cheng writes: >> >>> If an error is received when issuing a start or update transfer >>> command, the error handler will stop all active requests (including >>> the cur

Re: [PATCH] usb: dwc3: gadget: Avoid canceling current request for queuing error

2021-04-15 Thread Wesley Cheng
On 4/14/2021 11:26 PM, Felipe Balbi wrote: > Wesley Cheng writes: > >> If an error is received when issuing a start or update transfer >> command, the error handler will stop all active requests (including >> the current USB request), and call dwc3_gadget_giveback

Re: [PATCH 2/2] drm/ingenic: Don't request full modeset if property is not modified

2021-04-15 Thread Maxime Ripard
Hi, On Mon, Mar 29, 2021 at 06:50:46PM +0100, Paul Cercueil wrote: > Avoid requesting a full modeset if the sharpness property is not > modified, because then we don't actually need it. > > Fixes: fc1acf317b01 ("drm/ingenic: Add support for the IPU") > Cc: # 5.8+ > Signed-off-by: Paul Cercueil

Re: [PATCH 2/2] KVM: x86: Fix split-irqchip vs interrupt injection window request

2021-04-15 Thread Lai Jiangshan
On Thu, Apr 15, 2021 at 2:07 PM Paolo Bonzini wrote: > > On 15/04/21 02:59, Lai Jiangshan wrote: > > The next call to inject_pending_event() will reach here AT FIRST with > > vcpu->arch.exception.injected==false and vcpu->arch.exception.pending==false > > > >> ... if

Re: [PATCH] usb: dwc3: gadget: Avoid canceling current request for queuing error

2021-04-15 Thread Felipe Balbi
Wesley Cheng writes: > If an error is received when issuing a start or update transfer > command, the error handler will stop all active requests (including > the current USB request), and call dwc3_gadget_giveback() to notify > function drivers of the requests which have been sto

Re: [PATCH 2/2] KVM: x86: Fix split-irqchip vs interrupt injection window request

2021-04-15 Thread Paolo Bonzini
On 15/04/21 02:59, Lai Jiangshan wrote: The next call to inject_pending_event() will reach here AT FIRST with vcpu->arch.exception.injected==false and vcpu->arch.exception.pending==false ... if (!vcpu->arch.exception.pending) { if (vcpu->arch.nmi_injected) {

[RFC PATCH 2/2] bfq/mq-deadline: remove redundant check for passthrough request

2021-04-14 Thread Lin Feng
Since commit 01e99aeca39796003 'blk-mq: insert passthrough request into hctx->dispatch directly', passthrough request should not appear in IO-scheduler any more, so blk_rq_is_passthrough checking in addon IO schedulers is redundant. (Notes: this patch passes generic IO load test with hdds un

[PATCH 1/2] blk-mq: bypass IO scheduler's limit_depth for passthrough request

2021-04-14 Thread Lin Feng
Commit 01e99aeca39796003 ("blk-mq: insert passthrough request into hctx->dispatch directly") gives high priority to passthrough requests and bypass underlying IO scheduler. But as we allocate tag for such request it still runs io-scheduler's callback limit_depth, while we really wa

Re: [PATCH 2/2] KVM: x86: Fix split-irqchip vs interrupt injection window request

2021-04-14 Thread Lai Jiangshan
On Thu, Apr 15, 2021 at 12:58 AM Paolo Bonzini wrote: > > On 14/04/21 04:28, Lai Jiangshan wrote: > > On Tue, Apr 13, 2021 at 8:15 PM Paolo Bonzini wrote: > >> > >> On 13/04/21 13:03, Lai Jiangshan wrote: > >>> This patch claims that it has a place to > >>> stash the IRQ when EFLAGS.IF=0, but

[PATCH] usb: dwc3: gadget: Avoid canceling current request for queuing error

2021-04-14 Thread Wesley Cheng
If an error is received when issuing a start or update transfer command, the error handler will stop all active requests (including the current USB request), and call dwc3_gadget_giveback() to notify function drivers of the requests which have been stopped. Avoid having to cancel the current

Re: [PATCH 2/2] KVM: x86: Fix split-irqchip vs interrupt injection window request

2021-04-14 Thread Paolo Bonzini
On 14/04/21 04:28, Lai Jiangshan wrote: On Tue, Apr 13, 2021 at 8:15 PM Paolo Bonzini wrote: On 13/04/21 13:03, Lai Jiangshan wrote: This patch claims that it has a place to stash the IRQ when EFLAGS.IF=0, but inject_pending_event() seams to ignore EFLAGS.IF and queues the IRQ to the guest

Re: [PATCH] ASoC: fsl: imx-pcm-dma: Don't request dma channel in probe

2021-04-14 Thread Lucas Stach
wrote: > > > > Am Dienstag, den 19.05.2020, 17:41 +0800 schrieb Shengjiu Wang: > > > > > There are two requirements that we need to move the request of dma > > > > > channel from probe to open. > > > > > > > > How do you handl

RE: [PATCH] ASoC: fsl: imx-pcm-dma: Don't request dma channel in probe

2021-04-14 Thread Robin Gong
> There are two requirements that we need to move the request of dma > > > > channel from probe to open. > > > > > > How do you handle -EPROBE_DEFER return code from the channel request > > > if you don't do it in probe? > > > > I use the d

Re: [PATCH 2/2] KVM: x86: Fix split-irqchip vs interrupt injection window request

2021-04-13 Thread Lai Jiangshan
On Tue, Apr 13, 2021 at 8:15 PM Paolo Bonzini wrote: > > On 13/04/21 13:03, Lai Jiangshan wrote: > > This patch claims that it has a place to > > stash the IRQ when EFLAGS.IF=0, but inject_pending_event() seams to ignore > > EFLAGS.IF and queues the IRQ to the guest directly in the first branch >

Re: [PATCH 2/2] KVM: x86: Fix split-irqchip vs interrupt injection window request

2021-04-13 Thread Paolo Bonzini
On 13/04/21 13:03, Lai Jiangshan wrote: This patch claims that it has a place to stash the IRQ when EFLAGS.IF=0, but inject_pending_event() seams to ignore EFLAGS.IF and queues the IRQ to the guest directly in the first branch of using "kvm_x86_ops.set_irq(vcpu)". This is only true for

Re: [PATCH 2/2] KVM: x86: Fix split-irqchip vs interrupt injection window request

2021-04-13 Thread Paolo Bonzini
On 12/04/21 23:43, Sean Christopherson wrote: where kvm_arch_interrupt_allowed() checks EFLAGS.IF (and an edge case related to nested virtualization). KVM also captures EFLAGS.IF in vcpu->run->if_flag. For whatever reason, QEMU checks both vcpu->run flags before injecting an IRQ, maybe to

Re: [PATCH 2/2] KVM: x86: Fix split-irqchip vs interrupt injection window request

2021-04-13 Thread Lai Jiangshan
gt; > -!kvm_cpu_has_interrupt(vcpu) && > > > -!kvm_event_needs_reinjection(vcpu) && > > > -kvm_cpu_accept_dm_intr(vcpu); > > > +(!lapic_in_kernel(vcpu) > > > + ? !vcpu->arch.interrupt.injected > &

[PATCH 1/2] clk: Introduce a clock request API

2021-04-13 Thread Maxime Ripard
resolution rate resulting in a poor power-efficiency. In order to address both issues, let's create an API that allows user to create temporary requests to increase the rate to a minimum, before going back to the initial rate once the request is done. This introduces mainly two side-effects

[PATCH 2/2] drm/vc4: hdmi: Convert to the new clock request API

2021-04-13 Thread Maxime Ripard
The new clock request API allows us to increase the rate of the HSM clock to match our pixel rate requirements while decreasing it when we're done, resulting in a better power-efficiency. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_hdmi.c | 19 --- drivers/gpu/drm

[PATCH 0/2] clk: Implement a clock request API

2021-04-13 Thread Maxime Ripard
an use-case for something else, this should maybe be made more flexible? Let me know what you think Maxime Maxime Ripard (2): clk: Introduce a clock request API drm/vc4: hdmi: Convert to the new clock request API drivers/clk/clk.c | 121

Re: cocci script hints request

2021-04-13 Thread Fabio Aiuto
On Tue, Apr 13, 2021 at 11:56:20AM +0200, Julia Lawall wrote: > > > On Tue, 13 Apr 2021, Fabio Aiuto wrote: > > > Hi, > > > > I would like to improve the following coccinelle script: > > > > @@ > > expression a, fmt; > > expression list var_args; > > @@ > > > > - DBG_871X_LEVEL(a, fmt,

Re: cocci script hints request

2021-04-13 Thread Julia Lawall
On Tue, 13 Apr 2021, Fabio Aiuto wrote: > Hi, > > I would like to improve the following coccinelle script: > > @@ > expression a, fmt; > expression list var_args; > @@ > > - DBG_871X_LEVEL(a, fmt, var_args); > + printk(fmt, var_args); > > I would replace the DBG_871X_LEVEL macro

Re: cocci script hints request

2021-04-13 Thread Greg KH
On Tue, Apr 13, 2021 at 11:24:56AM +0200, Fabio Aiuto wrote: > On Tue, Apr 13, 2021 at 11:11:38AM +0200, Greg KH wrote: > > On Tue, Apr 13, 2021 at 11:04:01AM +0200, Fabio Aiuto wrote: > > > Hi, > > > > > > I would like to improve the following coccinelle script: > > > > > > @@ > > > expression

Re: cocci script hints request

2021-04-13 Thread Fabio Aiuto
On Tue, Apr 13, 2021 at 11:11:38AM +0200, Greg KH wrote: > On Tue, Apr 13, 2021 at 11:04:01AM +0200, Fabio Aiuto wrote: > > Hi, > > > > I would like to improve the following coccinelle script: > > > > @@ > > expression a, fmt; > > expression list var_args; > > @@ > > > > -

Re: cocci script hints request

2021-04-13 Thread Greg KH
On Tue, Apr 13, 2021 at 11:04:01AM +0200, Fabio Aiuto wrote: > Hi, > > I would like to improve the following coccinelle script: > > @@ > expression a, fmt; > expression list var_args; > @@ > > - DBG_871X_LEVEL(a, fmt, var_args); > + printk(fmt, var_args); > > I would replace the

cocci script hints request

2021-04-13 Thread Fabio Aiuto
Hi, I would like to improve the following coccinelle script: @@ expression a, fmt; expression list var_args; @@ - DBG_871X_LEVEL(a, fmt, var_args); + printk(fmt, var_args); I would replace the DBG_871X_LEVEL macro with printk, but I can't find a way to add KERN_* constant prefix

Re: [PATCH] kernel:irq:manage: request threaded irq with a specified priority

2021-04-13 Thread Thomas Gleixner
On Tue, Apr 13 2021 at 14:19, Song Chen wrote: > In general, irq handler thread will be assigned a default priority which > is MAX_RT_PRIO/2, as a result, no one can preempt others. > > Here is the case I found in a real project, an interrupt int_a is > coming, wakes up its handler handler_a and

Re: [syzbot] BUG: unable to handle kernel paging request in bpf_trace_run2

2021-04-13 Thread Dmitry Vyukov
On Thu, Apr 1, 2021 at 8:01 PM syzbot wrote: > > syzbot suspects this issue was fixed by commit: > > commit befe6d946551d65cddbd32b9cb0170b0249fd5ed > Author: Steven Rostedt (VMware) > Date: Wed Nov 18 14:34:05 2020 + > > tracepoint: Do not fail unregistering a probe due to memory

[PATCH v2 05/12] usb: dwc2: Add exit clock gating from session request interrupt

2021-04-13 Thread Artur Petrosyan
Added clock gating exit flow from session request interrupt handler according programming guide. Signed-off-by: Artur Petrosyan --- Changes in v2: - None drivers/usb/dwc2/core_intr.c | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/drivers/usb/dwc2

  1   2   3   4   5   6   7   8   9   10   >