Re: [PATCH 00/28] Reenable maybe-uninitialized warnings

2016-10-17 Thread Christoph Hellwig
On Tue, Oct 18, 2016 at 12:03:28AM +0200, Arnd Bergmann wrote: > This is a set of patches that I hope to get into v4.9 in some form > in order to turn on the -Wmaybe-uninitialized warnings again. Hi Arnd, I jsut complained to Geert that I was introducing way to many bugs or pointless warnings

cron job: media_tree daily build: ERRORS

2016-10-17 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Tue Oct 18 05:00:24 CEST 2016 media-tree git hash:43ea43b9d8b27b7acd443ec59319faa3cdb8a616 media_build

amazing and exciting

2016-10-17 Thread Xen-devel
Hello! I've just heard from a friend about that amazing stuff, I'm so excited, you've got to take a look Kind regards, Xen-devel -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to

[PATCH] media: s5p-mfc include buffer size in error message

2016-10-17 Thread Shuah Khan
Include buffer size in s5p_mfc_alloc_priv_buf() the error message when it fails to allocate the buffer. Remove the debug message that does the same. Signed-off-by: Shuah Khan --- drivers/media/platform/s5p-mfc/s5p_mfc_opr.c | 5 ++--- 1 file changed, 2 insertions(+), 3

Re: [PATCH v4 3/8] media: adv7180: add support for NEWAVMODE

2016-10-17 Thread Steve Longerbeam
On 10/16/2016 05:18 AM, Laurent Pinchart wrote: Hi Steve, Thank you for the patch. On Wednesday 03 Aug 2016 11:03:45 Steve Longerbeam wrote: Parse the optional v4l2 endpoint DT node. If the bus type is V4L2_MBUS_BT656 and the endpoint node specifies "newavmode", configure the BT.656 bus in

[PATCH 28/28] Kbuild: bring back -Wmaybe-uninitialized warning

2016-10-17 Thread Arnd Bergmann
Traditionally, we have always had warnings about uninitialized variables enabled, as this is part of -Wall, and generally a good idea [1], but it also always produced false positives, mainly because this is a variation of the halting problem and provably impossible to get right in all cases [2].

[PATCH 13/28] [media] dib0700: fix uninitialized data on 'repeat' event

2016-10-17 Thread Arnd Bergmann
After a recent cleanup patch, "gcc -Wmaybe-uninitialized" reports a new warning about an existing bug: drivers/media/usb/dvb-usb/dib0700_core.c: In function ‘dib0700_rc_urb_completion’: drivers/media/usb/dvb-usb/dib0700_core.c:763:2: error: ‘protocol’ may be used uninitialized in this function

[PATCH 12/28] [media] rc: print correct variable for z8f0811

2016-10-17 Thread Arnd Bergmann
A recent rework accidentally left a debugging printk untouched while changing the meaning of the variables, leading to an uninitialized variable being printed: drivers/media/i2c/ir-kbd-i2c.c: In function 'get_key_haup_common': drivers/media/i2c/ir-kbd-i2c.c:62:2: error: 'toggle' may be used

[PATCH 00/28] Reenable maybe-uninitialized warnings

2016-10-17 Thread Arnd Bergmann
This is a set of patches that I hope to get into v4.9 in some form in order to turn on the -Wmaybe-uninitialized warnings again. After talking to Linus in person at Linaro Connect about this, I spent some time on finding all the remaining warnings, and this is the resulting patch series. More

[GIT PULL] HSV formats v2

2016-10-17 Thread Ricardo Ribalda Delgado
Hi Mauro, These is the last PULL request rebased to your last master thanks to Laurent :) These patches add support for HSV. HSV formats are extremely useful for image segmentation. This set of patches makes v4l2 aware of this kind of formats. Vivid changes have been divided to ease the

Re: [PATCH] [media] solo6x10: avoid delayed register write

2016-10-17 Thread Andrey Utkin
On Thu, Sep 22, 2016 at 03:03:31AM +0300, Andrey Utkin wrote: > This fixes a lockup at device probing which happens on some solo6010 > hardware samples. This is a regression introduced by commit e1ceb25a1569 > ("[media] SOLO6x10: remove unneeded register locking and barriers") > > The observed

Re: [PATCH 54/57] [media] platform: don't break long lines

2016-10-17 Thread Andrey Utkin
On Mon, Oct 17, 2016 at 09:44:19PM +0300, Laurent Pinchart wrote: > Hi Andrey, > > On Monday 17 Oct 2016 20:39:45 Andrey Utkin wrote: > > Maybe the remaining manual work may be outsourced to seekers of janitor > > tasks? > > I'm fine with that, but we should rework the original patches, not

Re: [PATCH] [media] tw5864: crop picture width to 704

2016-10-17 Thread Andrey Utkin
On Thu, Sep 22, 2016 at 03:04:20AM +0300, Andrey Utkin wrote: > Previously, width of 720 was used, but it gives 16-pixel wide black bar > at right side of encoded picture. > > Signed-off-by: Andrey Utkin > --- > drivers/media/pci/tw5864/tw5864-reg.h | 8

Re: [PATCH 54/57] [media] platform: don't break long lines

2016-10-17 Thread Laurent Pinchart
Hi Andrey, On Monday 17 Oct 2016 20:39:45 Andrey Utkin wrote: > On Mon, Oct 17, 2016 at 04:45:06PM +0300, Laurent Pinchart wrote: > > If you really want to perform such a change, let's not make lines > > unnecessarily long either. You should add a line break after the first and > > > > second

Re: [PATCH 54/57] [media] platform: don't break long lines

2016-10-17 Thread Andrey Utkin
On Mon, Oct 17, 2016 at 04:45:06PM +0300, Laurent Pinchart wrote: > If you really want to perform such a change, let's not make lines > unnecessarily long either. You should add a line break after the first and > second argument: > > dprintk(ctx->dev, > "%s

[PATCH v1] media: saa7146: Fix for "[BUG] process stuck when closing saa7146 [dvb_ttpci]"

2016-10-17 Thread Andrey Utkin
Release queued DMA buffers when ending streaming, so that videobuf_waiton() doesn't block forever. As reported, this fixes avoids occasional lockup of process reading from video device, which manifests in such log: INFO: task ffmpeg:9864 blocked for more than 120 seconds. Tainted: P

Re: [PATCH v2 02/31] cinergyT2-core: don't do DMA on stack

2016-10-17 Thread Mauro Carvalho Chehab
Em Sat, 15 Oct 2016 22:54:49 +0200 Johannes Stezenbach escreveu: > On Tue, Oct 11, 2016 at 07:09:17AM -0300, Mauro Carvalho Chehab wrote: > > --- a/drivers/media/usb/dvb-usb/cinergyT2-core.c > > +++ b/drivers/media/usb/dvb-usb/cinergyT2-core.c > > @@ -41,6 +41,8 @@

Re: [PATCH 1/4] doc-rst: reST-directive kernel-cmd / include contentent from scripts

2016-10-17 Thread Mauro Carvalho Chehab
Hi Markus, Em Thu, 6 Oct 2016 09:20:17 +0200 Markus Heiser escreveu: > From: Markus Heiser > > The ``kernel-cmd`` directive includes contend from the stdout of a > command-line. With the ``kernel-cmd`` directive we can include the >

Re: [PATCH 3/5] [media] rc: meson-ir: Fix module autoload

2016-10-17 Thread Kevin Hilman
On Mon, Oct 17, 2016 at 8:44 AM, Javier Martinez Canillas wrote: > If the driver is built as a module, autoload won't work because the module > alias information is not filled. So user-space can't match the registered > device with the corresponding module. > > Export the

Re: V4L2_DEC_CMD_STOP and last_buffer_dequeued

2016-10-17 Thread 李務誠
We found videobuf2-core.h has a function vb2_clear_last_buffer_dequeued to clear last_buffer_dequeued. We call vb2_clear_last_buffer_dequeued in the driver when it gets CMD_START. Everything works now. On Mon, Oct 17, 2016 at 9:46 PM, Nicolas Dufresne wrote: > Le samedi 15

Re: [PATCH 2/5] [media] v4l: rcar-fcp: Fix module autoload for OF registration

2016-10-17 Thread Laurent Pinchart
Hi Javier, Thank you for the patch. On Monday 17 Oct 2016 12:44:09 Javier Martinez Canillas wrote: > If the driver is built as a module, autoload won't work because the module > alias information is not filled. So user-space can't match the registered > device with the corresponding module. > >

Re: [PATCH 1/5] [media] v4l: vsp1: Fix module autoload for OF registration

2016-10-17 Thread Laurent Pinchart
Hi Javier, Thank you for the patch. On Monday 17 Oct 2016 12:44:08 Javier Martinez Canillas wrote: > If the driver is built as a module, autoload won't work because the module > alias information is not filled. So user-space can't match the registered > device with the corresponding module. > >

[PATCH 4/5] [media] s5p-cec: Fix module autoload

2016-10-17 Thread Javier Martinez Canillas
If the driver is built as a module, autoload won't work because the module alias information is not filled. So user-space can't match the registered device with the corresponding module. Export the module alias information using the MODULE_DEVICE_TABLE() macro. Before this patch: $ modinfo

[PATCH 5/5] [media] st-cec: Fix module autoload

2016-10-17 Thread Javier Martinez Canillas
If the driver is built as a module, autoload won't work because the module alias information is not filled. So user-space can't match the registered device with the corresponding module. Export the module alias information using the MODULE_DEVICE_TABLE() macro. Before this patch: $ modinfo

[PATCH 3/5] [media] rc: meson-ir: Fix module autoload

2016-10-17 Thread Javier Martinez Canillas
If the driver is built as a module, autoload won't work because the module alias information is not filled. So user-space can't match the registered device with the corresponding module. Export the module alias information using the MODULE_DEVICE_TABLE() macro. Before this patch: $ modinfo

[PATCH 0/5] [media] Fix module autoload for media platform drivers

2016-10-17 Thread Javier Martinez Canillas
Hello Mauro, I noticed that module autoload won't be working in a bunch of media platform drivers because the module alias information is not filled in the modules. This patch series contains the fixes for them. Best regards, Javier Javier Martinez Canillas (5): [media] v4l: vsp1: Fix module

[PATCH 2/5] [media] v4l: rcar-fcp: Fix module autoload for OF registration

2016-10-17 Thread Javier Martinez Canillas
If the driver is built as a module, autoload won't work because the module alias information is not filled. So user-space can't match the registered device with the corresponding module. Export the module alias information using the MODULE_DEVICE_TABLE() macro. Before this patch: $ modinfo

[PATCH 1/5] [media] v4l: vsp1: Fix module autoload for OF registration

2016-10-17 Thread Javier Martinez Canillas
If the driver is built as a module, autoload won't work because the module alias information is not filled. So user-space can't match the registered device with the corresponding module. Export the module alias information using the MODULE_DEVICE_TABLE() macro. Before this patch: $ modinfo

Re: [GIT PULL] HSV formats

2016-10-17 Thread Laurent Pinchart
Hi Ricardo, I've rebased your branch on top of the latest linuxtv/master, fixed the documentation conflicts, and tested compilation of the documentation. You'll find the result at git://linuxtv.org/pinchartl/media.git vsp1/hsv Could you please check it and submit another pull request

Re: [PATCH] [media] videobuf2-dma-contig: Support cacheable MMAP

2016-10-17 Thread Sakari Ailus
Hi Thierry, On Fri, Oct 14, 2016 at 03:21:49PM +0200, Thierry Escande wrote: > From: Heng-Ruey Hsu > > DMA allocations for MMAP type are uncached by default. But for > some cases, CPU has to access the buffers. ie: memcpy for format > converter. Supporting cacheable MMAP

Re: [Patch 00/35] media: ti-vpe: fixes and enhancements

2016-10-17 Thread Hans Verkuil
On 09/28/2016 11:16 PM, Benoit Parrot wrote: > This patch series is to publish a number of enhancements > we have been carrying for a while. > > A number of bug fixes and feature enhancements have been > included. > > We also need to prepare the way for the introduction of > the VIP (Video Input

Re: [Patch 05/35] media: ti-vpe: Use line average de-interlacing for first 2 frames

2016-10-17 Thread Hans Verkuil
On 09/28/2016 11:20 PM, Benoit Parrot wrote: > From: Archit Taneja > > For n input fields, the VPE de-interlacer creates n - 2 progressive frames. That's confusing. I think you mean '(n / 2) - 1'? Two fields make one frame, right? Regards, Hans > > To support this,

Re: [Patch 01/35] media: ti-vpe: vpdma: Make vpdma library into its own module

2016-10-17 Thread Hans Verkuil
On 09/28/2016 11:16 PM, Benoit Parrot wrote: > The VPDMA (Video Port DMA) as found in devices such as DRA7xx is > used for both the Video Processing Engine (VPE) and the Video Input > Port (VIP). > > In preparation for this we need to turn vpdma into its own > kernel module. > > Signed-off-by:

Re: [Patch 06/35] media: ti-vpe: vpe: Do not perform job transaction atomically

2016-10-17 Thread Hans Verkuil
On 09/28/2016 11:20 PM, Benoit Parrot wrote: > From: Nikhil Devshatwar > > Current VPE driver does not start the job until all the buffers for > a transaction are not queued. When running in multiple context, this might I think this should be: s/not queued/queued/, right? >

Re: [ANN] Report of the V4L2 Request API brainstorm meeting

2016-10-17 Thread Nicolas Dufresne
Le lundi 17 octobre 2016 à 13:37 +0200, Hans Verkuil a écrit : > 1.5 Requests vs. w/o requests > > There are three options for drivers w.r.t. the request API: > > 1) The driver doesn't use the request API > 2) The driver requires the request API > 3) The request API is optional. > > It is not

Re: [PATCH 53/57] [media] i2c: don't break long lines

2016-10-17 Thread Laurent Pinchart
Hi Mauro, Thank you for the patch. On Friday 14 Oct 2016 17:20:41 Mauro Carvalho Chehab wrote: > Due to the 80-cols checkpatch warnings, several strings > were broken into multiple lines. This is not considered > a good practice anymore, as it makes harder to grep for > strings at the source

Re: [PATCH 18/25] [media] uvc_driver: use KERN_CONT where needed

2016-10-17 Thread Laurent Pinchart
Hi Mauro, Thank you for the patch. On Friday 14 Oct 2016 14:45:56 Mauro Carvalho Chehab wrote: > Some continuation messages are not using KERN_CONT. > > Since commit 563873318d32 ("Merge branch 'printk-cleanups"), > this won't work as expected anymore. So, let's add KERN_CONT > to those lines.

Re: Trying to get TBS5880 to work on Ubuntu with Hauppauge

2016-10-17 Thread Joacim J
Hi I have a fresh Ubuntu Server 16.04 install (for third time this weekend) and trying to get my TBS5880 to work. I have two "'Hauppauge Nova-T 500 Dual DVB-T" in the computer and being recognized directly during install using: root@frodo:~/tbs/linux-tbs-drivers# lsmod | grep dvb

Re: [PATCH 49/57] [media] uvc: don't break long lines

2016-10-17 Thread Laurent Pinchart
Hi Mauro, Thank you for the patch. Same comment, please add line breaks where applicable. On Friday 14 Oct 2016 17:20:37 Mauro Carvalho Chehab wrote: > Due to the 80-cols checkpatch warnings, several strings > were broken into multiple lines. This is not considered > a good practice anymore, as

Re: [PATCH 26/57] [media] omap3isp: don't break long lines

2016-10-17 Thread Laurent Pinchart
Hi Mauro, Thank you for the patch. As commented before, please add line breaks after function arguments to keep lines within the 80 columns limit where possible. On Friday 14 Oct 2016 17:20:14 Mauro Carvalho Chehab wrote: > Due to the 80-cols checkpatch warnings, several strings > were broken

Re: [PATCH 25/57] [media] omap: don't break long lines

2016-10-17 Thread Laurent Pinchart
Hi Mauro, Thank you for the patch. On Friday 14 Oct 2016 17:20:13 Mauro Carvalho Chehab wrote: > Due to the 80-cols checkpatch warnings, several strings > were broken into multiple lines. This is not considered > a good practice anymore, as it makes harder to grep for > strings at the source

Re: V4L2_DEC_CMD_STOP and last_buffer_dequeued

2016-10-17 Thread Nicolas Dufresne
Le samedi 15 octobre 2016 à 08:16 +0800, Wu-Cheng Li (李務誠) a écrit : > last_buffer_dequeued is only cleared to false when CAPTURE queue is > STREAMOFF (#1). Queuing a header to OUTPUT queue won't clear > last_buffer_dequeued of CAPTURE queue. It looks to me that v4l2 core > needs to intercept

Re: [PATCH 54/57] [media] platform: don't break long lines

2016-10-17 Thread Laurent Pinchart
Hi Mauro, Thank you for the patch. On Friday 14 Oct 2016 17:20:42 Mauro Carvalho Chehab wrote: > Due to the 80-cols checkpatch warnings, several strings > were broken into multiple lines. This is not considered > a good practice anymore, as it makes harder to grep for > strings at the source

Re: [PATCH 1/2] devicetree/bindings: display: Add bindings for LVDS panels

2016-10-17 Thread Laurent Pinchart
Hi Rob, On Friday 14 Oct 2016 07:40:14 Rob Herring wrote: > On Sun, Oct 9, 2016 at 11:33 AM, Laurent Pinchart wrote: > > On Saturday 08 Oct 2016 20:29:39 Rob Herring wrote: > >> On Tue, Oct 04, 2016 at 07:23:29PM +0300, Laurent Pinchart wrote: > >>> LVDS is a physical layer specification defined

Re: [PATCH v2 00/21] Basic i.MX IPUv3 capture support

2016-10-17 Thread Philipp Zabel
Hi Gary, Am Montag, den 17.10.2016, 12:18 +0200 schrieb Gary Bisson: [...] > For the whole series: > Tested-by: Gary Bisson > > Tested on Nitrogen6x + BD_HDMI_MIPI daughter board on linux-next > 20161016. > > This required using your v4l2-ctl patch to set the

[PATCH 0/2] v4l-utils: fixed dvbv5 vdr format

2016-10-17 Thread Markus Heiser
Hi Mauro, hi Chris sorry (again) for my late reply [1]. I merged & tested the patches of Chris [2] and mine [3] fixing the vdr channel format. Since the patches had a conflict, I had to slightly modify the patch [2] from Chris. --> Chris, I hope this is OK for you. I tested DVB-S2 and DVB-T with

[PATCH 1/2] v4l-utils: fixed dvbv5 vdr format

2016-10-17 Thread Markus Heiser
From: Markus Heiser From: Heiser, Markus The vdr format was broken, I got '(null)' entries HD:11494:S1HC23I0M5N1O35:S:(null):22000:5101:5102,5103,5106,5108:0:0:10301:0:0:0: 0-:1:2--:3:4-: refering to the VDR Wikis ...

Re: [PATCH v2 08/21] [media] imx: Add i.MX IPUv3 capture driver

2016-10-17 Thread Philipp Zabel
Hi Jack, Am Montag, den 17.10.2016, 12:32 +0100 schrieb Jack Mitchell: > Hi Philipp, > > I'm looking at how I would enable a parallel greyscale camera using this > set of drivers and am a little bit confused. Do you have an example > somewhere of a devicetree with an input node. In your board

Re: [ANN] Report of the V4L2 Request API brainstorm meeting

2016-10-17 Thread Jose Abreu
Hi, On 17-10-2016 12:37, Hans Verkuil wrote: > Report of the V4L2 brainstorm meeting October 10-11 2016, Berlin [snip] > 4.4 Streamon and streamoff > > - How to handle STREAMON/OFF? > - Pipelines without video nodes? > - Buffer size may change. Need to reallocate buffers, which is

Re: [PATCH v2 08/21] [media] imx: Add i.MX IPUv3 capture driver

2016-10-17 Thread Jack Mitchell
On 17/10/16 12:35, Marek Vasut wrote: On 10/17/2016 01:32 PM, Jack Mitchell wrote: Hi Philipp, Hi, I'm looking at how I would enable a parallel greyscale camera using this set of drivers and am a little bit confused. Do you have an example somewhere of a devicetree with an input node. I

Re: [PATCH v2 08/21] [media] imx: Add i.MX IPUv3 capture driver

2016-10-17 Thread Marek Vasut
On 10/17/2016 01:32 PM, Jack Mitchell wrote: > Hi Philipp, Hi, > I'm looking at how I would enable a parallel greyscale camera using this > set of drivers and am a little bit confused. Do you have an example > somewhere of a devicetree with an input node. I also have a further note > below:

[ANN] Report of the V4L2 Request API brainstorm meeting

2016-10-17 Thread Hans Verkuil
Report of the V4L2 brainstorm meeting October 10-11 2016, Berlin Attendees: Sakari Ailus Kieran Bingham Lars-Peter Clausen Guennadi Liakhovetski Pawel Osciak Laurent Pinchart

Re: [PATCH v2 08/21] [media] imx: Add i.MX IPUv3 capture driver

2016-10-17 Thread Jack Mitchell
Hi Philipp, I'm looking at how I would enable a parallel greyscale camera using this set of drivers and am a little bit confused. Do you have an example somewhere of a devicetree with an input node. I also have a further note below: + +static int ipu_capture_start_streaming(struct

Re: [PATCH v2 00/21] Basic i.MX IPUv3 capture support

2016-10-17 Thread Gary Bisson
Hi Philipp, On Fri, Oct 14, 2016 at 07:34:20PM +0200, Philipp Zabel wrote: > Hi, > > the second round removes the prepare_stream callback and instead lets the > intermediate subdevices propagate s_stream calls to their sources rather > than individually calling s_stream on each subdevice from

Re: [PATCH 2/2] [media] vb2: Add support for use_dma_bidirectional queue flag

2016-10-17 Thread Sakari Ailus
Hi Thierry, Thanks for the set. A few comments below. On Fri, Oct 14, 2016 at 02:08:14PM +0200, Thierry Escande wrote: > From: Pawel Osciak > > When this flag is set for CAPTURE queues by the driver on calling > vb2_queue_init(), it forces the buffers on the queue to be >

Re: [PATCH 10/10] mm: replace access_process_vm() write parameter with gup_flags

2016-10-17 Thread Jesper Nilsson
On Thu, Oct 13, 2016 at 01:20:20AM +0100, Lorenzo Stoakes wrote: > This patch removes the write parameter from access_process_vm() and replaces > it > with a gup_flags parameter as use of this function previously _implied_ > FOLL_FORCE, whereas after this patch callers explicitly pass this flag.

Re: [PATCH 06/10] mm: replace get_user_pages() write/force parameters with gup_flags

2016-10-17 Thread Jesper Nilsson
On Thu, Oct 13, 2016 at 01:20:16AM +0100, Lorenzo Stoakes wrote: > This patch removes the write and force parameters from get_user_pages() and > replaces them with a gup_flags parameter to make the use of FOLL_FORCE > explicit > in callers as use of this flag can result in surprising behaviour

Re: [PATCH 07/22] [media] imx: Add IPUv3 media common code

2016-10-17 Thread Ian Arkver
On 07/10/16 17:00, Philipp Zabel wrote: From: Sascha Hauer Add video4linux API routines common to drivers for units that accept or provide video data via the i.MX IPU IDMAC channels, such as capture, mem2mem scaler or deinterlacer drivers. Signed-off-by: Sascha Hauer

Re: [STLinux Kernel] [PATCH 28/57] [media] c8sectpfe: don't break long lines

2016-10-17 Thread Peter Griffin
On Fri, 14 Oct 2016, Mauro Carvalho Chehab wrote: > Due to the 80-cols checkpatch warnings, several strings > were broken into multiple lines. This is not considered > a good practice anymore, as it makes harder to grep for > strings at the source code. So, join those continuation > lines. > >