Re: [PATCH v2] [media] Delete unnecessary variable initialisations in seven functions

2018-02-22 Thread Alexey Klimov
Signed-off-by: Markus Elfring > --- > > v2: > Hans Verkuil insisted on patch squashing. Thus some changes > were recombined based on source files from Linux next-20180216. > > drivers/media/radio/radio-mr800.c | 2 +- For radio-mr800: Acked-by: Alexey Klim

Re: [PATCH 3/3] [media] radio: constify usb_device_id

2017-08-21 Thread Alexey Klimov
-off-by: Arvind Yadav For dsbr100, radio-mr800 and radio-ma901 please feel free to use: Acked-by: Alexey Klimov > --- > drivers/media/radio/dsbr100.c | 2 +- > drivers/media/radio/radio-keene.c | 2 +- > drivers/media/radio/radio-ma901.c |

Re: [PATCH v9 2/8] media: Add registration helpers for V4L2 flash sub-devices

2015-06-18 Thread Alexey Klimov
d); > + struct led_classdev_flash *fled_cdev = v4l2_flash->fled_cdev; > + struct led_classdev *led_cdev = &fled_cdev->led_cdev; > + int ret = 0; > + > + mutex_lock(&led_cdev->led_access); > + > + if (!v4l2_fh_is_sin

Re: [PATCH 5/6] update reference, kerneltrap.org no longer works

2014-06-09 Thread Alexey Klimov
On Mon, Jun 9, 2014 at 7:55 PM, Pranith Kumar wrote: > kerneltrap.org no longer works, update to a working reference > > Signed-off-by: Pranith Kumar Acked-by: Alexey Klimov Thanks! -- Best regards, Klimov Alexey -- To unsubscribe from this list: send the line "unsubscribe l

Re: [REVIEW PATCH 0/4] add radio-raremono driver

2014-01-08 Thread Alexey Klimov
On Fri, Dec 13, 2013 at 4:26 PM, Hans Verkuil wrote: > This patch series adds the new radio-raremono driver for the USB > 'Thanko's Raremono' AM/FM/SW receiver. > > Since it (ab)uses the same USB IDs as the si470x SiLabs Reference > Design I had to add additional checks to si470x to tell the two a

Re: Fw: [patch 02/03 v2] usb hid quirks for Masterkit MA901 usb radio

2013-03-27 Thread Alexey Klimov
On Wed, Mar 27, 2013 at 2:18 PM, Jiri Kosina wrote: > On Tue, 19 Mar 2013, Alexey Klimov wrote: > >> Yes, i just checked how hid_ignore() works and prepared dirty fix to >> test in almost the same way like it's done for Keene usb driver. I >> will send correct fix i

[patch 2/2] media: radio-ma901: return ENODEV in probe if usb_device doesn't match

2013-03-27 Thread Alexey Klimov
Masterkit MA901 usb radio device shares USB ID with Atmel V-USB devices. This patch adds additional checks in usb_ma901radio_probe() and if product or manufacturer doesn't match we return -ENODEV and don't continue. This allows hid drivers to handle not MA901 device. Signed-off-by: Ale

[patch 1/2] hid: fix Masterkit MA901 hid quirks

2013-03-27 Thread Alexey Klimov
. Signed-off-by: Alexey Klimov diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c index 512b01c..aa341d1 100644 --- a/drivers/hid/hid-core.c +++ b/drivers/hid/hid-core.c @@ -2077,7 +2077,6 @@ static const struct hid_device_id hid_ignore_list[] = { { HID_USB_DEVICE

Re: Fw: [patch 02/03 v2] usb hid quirks for Masterkit MA901 usb radio

2013-03-18 Thread Alexey Klimov
On Mon, Mar 18, 2013 at 5:51 PM, Jiri Kosina wrote: > On Fri, 15 Mar 2013, Alexey Klimov wrote: > >> > indeed your patch breaks Atmega applications which using V-USB >> > (http://www.obdev.at/products/vusb/index.html), because 0x16c0, 0x05df are >> > the defau

Re: [REVIEW PATCH 2/5] v4l2: add const to argument of write-only s_tuner ioctl.

2013-03-16 Thread Alexey Klimov
a/radio/radio-ma901.c|2 +- > drivers/media/radio/radio-mr800.c | 2 +- Acked-by: Alexey Klimov for this three radio drivers. Thanks. -- Best regards, Klimov Alexey -- To unsubscribe from this list: send the line "unsubscribe linux-media"

[review patch] radio-mr800: move clamp_t check inside amradio_set_freq()

2013-03-14 Thread Alexey Klimov
set_freq. With this patch we can call amradio_set_freq() with out of range frequency from any place. Also put comment that sometimes radio->curfreq is set to out of range value in vidioc_s_hw_freq_seek(). Signed-off-by: Alexey Klimov diff --git a/drivers/media/radio/radio-mr800.c b/drivers/media

Re: Fw: [patch 02/03 v2] usb hid quirks for Masterkit MA901 usb radio

2013-03-14 Thread Alexey Klimov
On Thu, Mar 14, 2013 at 2:20 PM, Dirk E. Wagner wrote: > Hi Alexey, Hi Dirk, Mauro, Jiri > indeed your patch breaks Atmega applications which using V-USB > (http://www.obdev.at/products/vusb/index.html), because 0x16c0, 0x05df are > the default Ids of V-USB. > > Have a look at this FAQ > > https

Re: Fw: [patch 02/03 v2] usb hid quirks for Masterkit MA901 usb radio

2013-03-11 Thread Alexey Klimov
o > apply this hid patch there? > > Thanks! > Mauro > > Forwarded message: > > Date: Mon, 12 Nov 2012 07:57:03 +0100 > From: Alexey Klimov > To: linux-media@vger.kernel.org > Subject: [patch 02/03 v2] usb hid quirks for Masterkit MA901 usb radio > > > Don

[PATCH] [media] radio-si470x doc: add info about v4l2-ctl and sox+alsa

2013-02-11 Thread Alexey Klimov
Patch adds information about using v4l2-ctl utility to tune the si470x radio and example how to use sox+alsa to redirect sound from radio sound device to another sound device. Signed-off-by: Alexey Klimov diff --git a/Documentation/video4linux/si470x.txt b/Documentation/video4linux/si470x.txt

Re: [PATCH v3 0/6] Driver for Si476x series of chips

2013-02-11 Thread Alexey Klimov
Hello Andrey, Mauro, Hans, On Tue, Oct 23, 2012 at 6:44 PM, Andrey Smirnov wrote: > This is a third version of the patchset originaly posted here: > https://lkml.org/lkml/2012/9/13/590 > > Second version of the patch was posted here: > https://lkml.org/lkml/2012/10/5/598 > > To save everyone's ti

[radio-si470x questions] Re: HI. problem with playing radio using fmtools, radio

2013-02-10 Thread Alexey Klimov
fmtools behave the same with the two different > cards. > > So the question is how do i keep radio running while issuing a command > trough fmtools or radio app. > Is there any other app that keeps radio open while receiving control > commands. > > Thanks I believe

Re: HI

2013-01-28 Thread Alexey Klimov
Hello Igor, On Mon, Jan 28, 2013 at 3:14 AM, Igor Stamatovski wrote: > Im trying to use ADS tech instantFM music USB card. > > dmesg reports this after machine reset (USB stays on machine) > > [6.387624] USB radio driver for Si470x FM Radio Receivers, Version 1.0.10 > [6.930228] radio-si4

Re: iMon Knob driver issue

2012-12-29 Thread Alexey Klimov
Hello Alexandre, On Sat, Dec 29, 2012 at 4:08 PM, Alexandre LISSY wrote: > Hello, > > Please find attached a small patch for the iMon Knob driver. I've been Could you please also add your Signed-off-by to the patch? It looks like it's missed. -- Best regards, Klimov Alexey -- To unsubscribe fr

Re: [patch 00/03 v2] driver for Masterkit MA901 usb radio

2012-12-28 Thread Alexey Klimov
Hi Hans, On Fri, Dec 28, 2012 at 2:24 PM, Hans Verkuil wrote: > On Mon November 12 2012 07:56:06 Alexey Klimov wrote: >> Hi all, >> >> This is second version of small patch series for ma901 usb radio driver. >> Initial letter about this usb radio was sent on October

Re: [PATCH] [media] v4l: Add mt9v034 sensor driver

2012-11-30 Thread Alexey Klimov
Hi Enric, May i ask about mt9v034_probe() and mt9v034_remove()? On Fri, Oct 5, 2012 at 2:34 PM, Enric Balletbo i Serra wrote: > From: Enric Balletbo i Serra > > The MT9V034 is a parallel wide VGA sensor from Aptina (formerly Micron) > controlled through I2C. > > The driver creates a V4L2 subdev

[patch] MAINTAINERS: add entry for dsbr100 usb radio driver

2012-11-28 Thread Alexey Klimov
This patch adds MAINTAINERS entry for dsbr100 usb radio driver. Signed-off-by: Alexey Klimov diff --git a/MAINTAINERS b/MAINTAINERS index a36b29c..38da55f 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2528,6 +2528,13 @@ S: Supported F: drivers/gpu/drm/exynos F: include/drm

[patch 03/03 v2] MAINTAINERS: add entry for radio-ma901 driver

2012-11-27 Thread Alexey Klimov
This patch adds MAINTAINERS entry for radio-ma901 usb radio driver. Signed-off-by: Alexey Klimov diff --git a/MAINTAINERS b/MAINTAINERS index b623679..a36b29c 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -4723,6 +4723,13 @@ Q: http://patchwork.linuxtv.org/project/linux-media/list/ S

[patch 02/03 v2] usb hid quirks for Masterkit MA901 usb radio

2012-11-27 Thread Alexey Klimov
Don't let Masterkit MA901 USB radio be handled by usb hid drivers. This device will be handled by radio-ma901.c driver. Signed-off-by: Alexey Klimov diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c index 5de3bb3..8e06569 100644 --- a/drivers/hid/hid-core.c +++ b/drivers/hi

[patch 01/03 v2] media: add driver for Masterkit MA901 usb radio

2012-11-27 Thread Alexey Klimov
This patch creates a new usb-radio driver, radio-ma901.c, that supports Masterkit MA 901 USB FM radio devices. This device plugs into both the USB and an analog audio input or headphones, so this thing only deals with initialization and frequency setting. Signed-off-by: Alexey Klimov diff

[patch 00/03 v2] driver for Masterkit MA901 usb radio

2012-11-27 Thread Alexey Klimov
ncy() - added maintainers entry patch Best regards, Alexey Klimov -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: drivers without explicit MAINTAINERS entry - was: Re: [media-workshop] Tentative Agenda for the November workshop

2012-11-26 Thread Alexey Klimov
Hi Hans, On Mon, Nov 26, 2012 at 6:15 PM, Hans Verkuil wrote: > On Mon 26 November 2012 00:18:30 Alexey Klimov wrote: >> Hi Hans, >> >> On Fri, Nov 23, 2012 at 2:31 PM, Hans Verkuil wrote: >> > Hi Alexey, >> > >> > On Mon November 12 2012 19:41:5

Re: [patch review 01/02] add driver for Masterkit MA901 usb radio

2012-11-26 Thread Alexey Klimov
Hi Hans, On Fri, Nov 23, 2012 at 3:42 PM, Hans Verkuil wrote: > Hi Alexey, > > Some (small) comments below... > > On Mon October 29 2012 02:41:10 Alexey Klimov wrote: >> This patch creates a new usb-radio driver, radio-ma901.c, that supports >> Masterkit MA 901 USB FM

Re: [PATCH RFC v3 1/3] V4L: Add driver for S3C244X/S3C64XX SoC series camera interface

2012-11-25 Thread Alexey Klimov
Hi Sylwester, On Sat, Nov 17, 2012 at 2:39 AM, Sylwester Nawrocki wrote: > Hi Alexey, > > > On 11/16/2012 03:10 PM, Alexey Klimov wrote: >>>> >>>> +static int s3c_camif_hw_init(struct camif_dev *camif, struct camif_vp >>>> *vp) >>&

Re: drivers without explicit MAINTAINERS entry - was: Re: [media-workshop] Tentative Agenda for the November workshop

2012-11-25 Thread Alexey Klimov
Hi Hans, On Fri, Nov 23, 2012 at 2:31 PM, Hans Verkuil wrote: > Hi Alexey, > > On Mon November 12 2012 19:41:57 Alexey Klimov wrote: >> Hi Mauro, Hans, all, >> >> On Fri, Nov 2, 2012 at 6:34 PM, Mauro Carvalho Chehab >> wrote: >> > Em Fri, 2 Nov 2012

Re: [PATCH v3 5/6] Add a V4L2 driver for SI476X MFD

2012-11-16 Thread Alexey Klimov
Hello Andrey, On Tue, Oct 23, 2012 at 10:44 PM, Andrey Smirnov wrote: > This commit adds a driver that exposes all the radio related > functionality of the Si476x series of chips via the V4L2 subsystem. > > Signed-off-by: Andrey Smirnov > --- > drivers/media/radio/Kconfig| 17 + > dri

[patch] MAINTAINERS: add an entry for radio-mr800 driver

2012-11-16 Thread Alexey Klimov
This patch adds MAINTAINERS entry for radio-mr800 usb radio driver. Signed-off-by: Alexey Klimov diff --git a/MAINTAINERS b/MAINTAINERS index f4b3aa8..e1d9e38 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -4909,6 +4909,13 @@ S: Maintained F: Documentation/serial/moxa-smartio F

Re: [PATCH RFC v3 1/3] V4L: Add driver for S3C244X/S3C64XX SoC series camera interface

2012-11-16 Thread Alexey Klimov
Hi Sylwester, > On Fri, Nov 16, 2012 at 2:05 AM, Sylwester Nawrocki > wrote: >> >> This patch adds V4L2 driver for Samsung S3C244X/S3C64XX SoC series >> camera interface. The driver exposes a subdev device node for CAMIF >> pixel resolution and crop control and two video capture nodes - for >> th

Re: [PATCH v8 2/6] video: add of helper for videomode

2012-11-12 Thread Alexey Klimov
Hello Steffen, On Mon, Nov 12, 2012 at 7:37 PM, Steffen Trumtrar wrote: > This adds support for reading display timings from DT or/and convert one of > those > timings to a videomode. > The of_display_timing implementation supports multiple children where each > property can have up to 3 values.

Re: drivers without explicit MAINTAINERS entry - was: Re: [media-workshop] Tentative Agenda for the November workshop

2012-11-12 Thread Alexey Klimov
r is > to write one patch by each MAINTAINERS entry (except, of course, if there > are consecutive entries), as I suspect that MAINTAINERS is likely one > of top-rated merge-conflicts file. > >> >> There are more radio drivers that can have that status, but I would need >&g

[patch review 02/02] usb hid quirks for Masterkit MA901 usb radio

2012-10-28 Thread Alexey Klimov
Don't let Masterkit MA901 USB radio be handled by usb hid drivers. This device will be handled by radio-ma901.c driver. Signed-off-by: Alexey Klimov diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c index 5de3bb3..8e06569 100644 --- a/drivers/hid/hid-core.c +++ b/drivers/hi

[patch review 01/02] add driver for Masterkit MA901 usb radio

2012-10-28 Thread Alexey Klimov
This patch creates a new usb-radio driver, radio-ma901.c, that supports Masterkit MA 901 USB FM radio devices. This device plugs into both the USB and an analog audio input or headphones, so this thing only deals with initialization and frequency setting. Signed-off-by: Alexey Klimov diff

[patch review 00/02] driver for Masterkit MA901 usb radio

2012-10-28 Thread Alexey Klimov
used a lot of code from radio-mr800.c and radio-keene.c. Also may be the second patch should go through Jiri Kosina tree, i'm not sure how procedures work for such cases. Previous time Mauro sent patch with usb-quirks to Jiri. Best regards, Alexey Klimov. -- To unsubscribe from this list: sen

Re: [PATCH 2/2] [ARM] samsung-rotator: Add Samsung S3C/S5P rotator driver

2009-12-23 Thread Alexey Klimov
Hello, On Wed, Dec 23, 2009 at 1:08 PM, Pawel Osciak wrote: > The rotator device present on Samsung S3C and S5P series SoCs allows image > rotation and flipping. It requires contiguous memory buffers to operate, > as it does not have scatter-gather support. It is also an example of > a memory-to-

Re: [PATCH 3/4 v13] TVP7002 driver for DM365

2009-12-19 Thread Alexey Klimov
Hello, On Fri, Dec 18, 2009 at 8:07 PM, wrote: > From: Santiago Nunez-Corrales > > This patch provides the implementation of the TVP7002 decoder > driver for DM365. Implemented using the V4L2 DV presets API. > Removed shadow register values. Testing shows that the device > needs not to be power

Re: [PATCH 3/4 v12] TVP7002 driver for DM365

2009-12-17 Thread Alexey Klimov
Hello, On Thu, Dec 17, 2009 at 12:32 AM, wrote: > From: Santiago Nunez-Corrales > > This patch provides the implementation of the TVP7002 decoder > driver for DM365. Implemented using the V4L2 DV presets API. > Removed shadow register values. Testing shows that the device > needs not to be powe

Re: Radio application using V4L2 on console?

2009-12-10 Thread Alexey Klimov
On Thu, Dec 10, 2009 at 11:27 AM, Joonyoung Shim wrote: > Hi, all. > > I just wonder there is any radio application using the V4L2 on console. > I found only the Kradio app of KDE, but the KDE is difficult to use the > embedded system. > > I am testing using my simple radio test application on con

[patch] radio-mr800 - autosuspend for radio-mr800 driver

2009-11-09 Thread Alexey Klimov
From: Oliver Neukum Patch adds autosuspend support for mr800 radio driver. Priority: normal Signed-off-by: Oliver Neukum Acked-by: Alexey Klimov -- diff -r 19c0469c02c3 linux/drivers/media/radio/radio-mr800.c --- a/linux/drivers/media/radio/radio-mr800.c Sat Nov 07 15:51:01 2009 -0200

Re: Gadmei 380 on kernel 2.6.28.4

2009-10-19 Thread Alexey Klimov
Hello Ming-Ching, On Mon, Oct 19, 2009 at 10:28 AM, Ming-Ching Tiew wrote: > > Message below :- > >> From: Ming-Ching Tiew >> Subject: Re: Gadmei 380 on kernel 2.6.28.4 >> To: linux-media@vger.kernel.org >> Date: Monday, October 12, 2009, 8:31 AM >> I did a dmesg, include please find >> the outp

Re: [RFC/RFT 0/14] radio-mr800 patch series

2009-09-22 Thread Alexey Klimov
On Tue, Sep 22, 2009 at 5:06 AM, David Ellingsworth wrote: > On Mon, Sep 21, 2009 at 8:03 PM, Alexey Klimov wrote: >> Hello, David >> >> On Mon, Sep 14, 2009 at 11:09 PM, Alexey Klimov >> wrote: >>> Hello David, >>> >>> On Sun, Sep 13, 200

Re: [RFC/RFT 0/14] radio-mr800 patch series

2009-09-21 Thread Alexey Klimov
Hello, David On Mon, Sep 14, 2009 at 11:09 PM, Alexey Klimov wrote: > Hello David, > > On Sun, Sep 13, 2009 at 7:22 AM, David Ellingsworth > wrote: >> What follow is a series of patches to clean up the radio-mr800 driver. I >> do _not_ have access to this device so

Re: [RFC/RFT 0/14] radio-mr800 patch series

2009-09-14 Thread Alexey Klimov
Hello David, On Sun, Sep 13, 2009 at 7:22 AM, David Ellingsworth wrote: > What follow is a series of patches to clean up the radio-mr800 driver. I > do _not_ have access to this device so these patches need to be tested. > These patches should apply to Mauro's git tree and against the 2.6.31 > re

Re: [patch review 6/6] radio-mr800: redesign radio->users counter

2009-08-09 Thread Alexey Klimov
On Sun, Aug 9, 2009 at 12:19 PM, Hans Verkuil wrote: > On Saturday 08 August 2009 22:16:28 wk wrote: >> Alexey Klimov schrieb: >> > On Sat, Aug 8, 2009 at 10:01 PM, Trent Piepho wrote: >> > >> >> On Sat, 8 Aug 2009, Alexey Klimov wrote: >> >> >

Re: [patch review 6/6] radio-mr800: redesign radio->users counter

2009-08-08 Thread Alexey Klimov
On Sat, Aug 8, 2009 at 10:01 PM, Trent Piepho wrote: > On Sat, 8 Aug 2009, Alexey Klimov wrote: >> Redesign radio->users counter. Don't allow more that 5 users on radio in > > Why? Well, v4l2 specs says that multiple opens are optional. Honestly, i think that five userspace

[patch review 6/6] radio-mr800: redesign radio->users counter

2009-08-08 Thread Alexey Klimov
Redesign radio->users counter. Don't allow more that 5 users on radio in usb_amradio_open() and don't stop radio device if other userspace application uses it in usb_amradio_close(). Signed-off-by: Alexey Klimov -- diff -r c2dd9da28106 linux/drivers/media/radio/radio-mr800.c --- a/

[patch review 5/6] radio-mr800: update suspend/resume procedure

2009-08-08 Thread Alexey Klimov
Patch fixes suspend/resume procedure. Signed-off-by: Alexey Klimov -- diff -r 05754a500f80 linux/drivers/media/radio/radio-mr800.c --- a/linux/drivers/media/radio/radio-mr800.c Sat Aug 08 20:06:36 2009 +0400 +++ b/linux/drivers/media/radio/radio-mr800.c Sat Aug 08 20:22:05 2009 +0400

[patch review 4/6] radio-mr800: make radio->status variable

2009-08-08 Thread Alexey Klimov
Remove radio->muted and radio->removed variables from amradio_device structure. Instead patch creates radio->status variable and updates code. Signed-off-by: Alexey Klimov -- diff -r a1ccdea5a182 linux/drivers/media/radio/radio-mr800.c --- a/linux/drivers/media/radio/radio-mr800.c W

[patch review 3/6] radio-mr800: no need to pass curfreq value to amradio_setfreq()

2009-08-08 Thread Alexey Klimov
Small cleanup of amradio_setfreq(). No need to pass radio->curfreq value to this function. Signed-off-by: Alexey Klimov -- diff -r 5f3329bebfe4 linux/drivers/media/radio/radio-mr800.c --- a/linux/drivers/media/radio/radio-mr800.c Wed Jul 29 12:36:46 2009 +0400 +++ b/linux/drivers/media/ra

[patch review 2/6] radio-mr800: cleanup of usb_amradio_open/close

2009-08-08 Thread Alexey Klimov
Patch removes functions that shouldn't be in usb_amradio_open/close: amradio_set_mute(), amradio_set_stereo(), amradio_setfreq(). Signed-off-by: Alexey Klimov -- diff -r 34b4e5c9d5c2 linux/drivers/media/radio/radio-mr800.c --- a/linux/drivers/media/radio/radio-mr800.c Wed Jul 29 10:44:51

[patch review 1/6] radio-mr800: remove redundant lock/unlock_kernel

2009-08-08 Thread Alexey Klimov
Remove redundant lock/unlock_kernel() calls from usb_amradio_open/close functions. Signed-off-by: Alexey Klimov -- diff -r ee6cf88cb5d3 linux/drivers/media/radio/radio-mr800.c --- a/linux/drivers/media/radio/radio-mr800.c Wed Jul 29 01:42:02 2009 -0300 +++ b/linux/drivers/media/radio/radio

[patch review 0/6] radio-mr800

2009-08-08 Thread Alexey Klimov
Hello all, Here are some radio-mr800 patches against hg v4l-dvb tree. Patchset removes lock_kernel calls, fixes suspend/resume, cleanups, introduces status variable and redesigns users counter in driver. As usual comments, remarks, ideas are more than welcome :) [1/6] radio-mr800: remove redunda

Re: [PATCH] to add support for certain Jeilin dual-mode cameras.

2009-08-03 Thread Alexey Klimov
On Mon, Aug 3, 2009 at 10:30 AM, Jean-Francois Moine wrote: > On Sun, 2 Aug 2009 17:25:29 +0400 > Alexey Klimov wrote: > >> > +       buffer = kmalloc(JEILINJ_MAX_TRANSFER, GFP_KERNEL | >> > GFP_DMA); >> > +       if (!buffer) { >> > +            

Re: [PATCH] to add support for certain Jeilin dual-mode cameras.

2009-08-02 Thread Alexey Klimov
Hello, Theodore On Sun, Aug 2, 2009 at 1:56 AM, Theodore Kilgore wrote: > Several cameras are supported here, which all share the same USB > Vendor:Product number when started up in streaming mode. All of these > cameras use bulk transport for streaming, and all of them produce frames in > JPEG fo

Re: Patch: Kaiser Baas ExpressCard Dual HD Tuner

2009-07-28 Thread Alexey Klimov
Hello, James On Wed, Jul 29, 2009 at 4:19 AM, James A Webb wrote: > Hi. > > I'm new to the list - please bear with me. > > I've spent some time getting a recently purchased Kaiser Baas > ExpressCard Dual HD Tuner working with MythTV.  I ended up patching some > of the dib0700 work.  I'd like to su

Re: [PATCH v2 4/4] radio-si470x: add i2c driver for si470x

2009-07-19 Thread Alexey Klimov
Hello, On Tue, Jul 14, 2009 at 9:15 AM, Joonyoung Shim wrote: > This patch supports i2c interface of si470x. The i2c specific part > exists in radio-si470x-i2c.c file and the common part uses > radio-si470x-common.c file. The '#if defined' is inserted inevitably > because of parts used only si470x

Re: [PATCH 2/2] radio-si470x: add i2c driver for si470x

2009-07-13 Thread Alexey Klimov
Hello all On 7/13/09, Joonyoung Shim wrote: > This patch supports i2c interface of si470x. The i2c specific part > exists in radio-si470x-i2c.c file and the common part uses > radio-si470x-common.c file. The '#if defined' is inserted inevitably > because of parts used only si470x usb in the commo

Re: [PATCH 1/1] gspca: Add sn9c20x subdriver

2009-07-06 Thread Alexey Klimov
Hello Brian, please see below On Mon, Jul 6, 2009 at 3:30 PM, Brian Johnson wrote: > This adds support for webcams using the sn9c201 and sn9c202 bridges. > > Signed-off-by: Brian Johnson > --- >  MAINTAINERS                                        |    8 + >  drivers/media/video/gspca/Kconfig    

Re: [PATCH 4/11 - v3] dm644x ccdc module for vpfe capture driver

2009-06-17 Thread Alexey Klimov
On Thu, Jun 18, 2009 at 12:11 AM, wrote: > From: Muralidharan Karicheri > > DM644x CCDC hw module > > This is the hw module for DM644x CCDC. This registers with the > vpfe capture driver and provides a set of hw_ops to configure > CCDC for a specific decoder device connected to the VPFE > > Modul

Re: [PATCH 3/11 - v3] dm355 ccdc module for vpfe capture driver

2009-06-17 Thread Alexey Klimov
Hello, one more small comment On Thu, Jun 18, 2009 at 12:11 AM, wrote: > From: Muralidharan Karicheri > > DM355 CCDC hw module > > Adds ccdc hw module for DM355 CCDC. This registers with the bridge > driver a set of hw_ops for configuring the CCDC for a specific > decoder device connected to vpf

Re: [PATCH 1/11 - v3] vpfe capture bridge driver for DM355 and DM6446

2009-06-17 Thread Alexey Klimov
Hello, very small comments, see below please On Thu, Jun 18, 2009 at 12:11 AM, wrote: > From: Muralidharan Karicheri > +static int vpfe_enable_clock(struct vpfe_device *vpfe_dev) > +{ > +       struct vpfe_config *vpfe_cfg = vpfe_dev->cfg; > +       int ret = -ENOENT; > + > +       vpfe_cfg-

Re: [PATCH / resubmit] USB interrupt support for radio-si470x FM radio driver

2009-06-16 Thread Alexey Klimov
On Wed, Jun 17, 2009 at 12:05 AM, Edouard Lafargue wrote: > Hello Alexey, Hello Edouard > Many thanks for your comments. I have cleaned up my code/patch along > your guidelines, removed all the remaining code that was not used > anymore, checked that all buffers get deallocated properly - I hope.

Re: [PATCH] USB interrupt support for radio-si470x FM radio driver

2009-06-16 Thread Alexey Klimov
Hello, Edouard (add Tobias and Douglas on c/c) On Tue, Jun 16, 2009 at 5:11 PM, Edouard Lafargue wrote: > Please find below my attempt at removing 'manual' polling from the > radio-si470x USB FM radio driver, by moving to URB interrupt callback > handlers. > > This code significantly improves RDS

Re: [PATCH 10/10 - v2] common vpss module for video drivers

2009-06-11 Thread Alexey Klimov
Hello, On Thu, Jun 11, 2009 at 9:00 PM, wrote: > From: Muralidharan Karicheri > > common voss module for video drivers > > This is a new module added for vpss library functions that are > used for configuring vpss system module. All video drivers will > include vpss.h header file and call functi

Re: [PATCH 1/10 - v2] vpfe capture bridge driver for DM355 and DM6446

2009-06-11 Thread Alexey Klimov
Hello, Very small suggestion, please see below. On Thu, Jun 11, 2009 at 9:00 PM, wrote: > From: Muralidharan Karicheri > > Re-sending since previous one missed a file (vpfe_types.h) > > VPFE Capture bridge driver > > This is version, v2 of vpfe capture bridge driver for doing video > capture on

Re: [patch 1/6] radio-mr800.c: missing mutex include

2009-06-10 Thread Alexey Klimov
On Wed, Jun 10, 2009 at 11:44 PM, wrote: > From: Alessio Igor Bogani > > radio-mr800.c uses struct mutex, so while seems to be > pulled in indirectly by one of the headers it already includes, the right > thing is to include it directly. It was already applied to v4l-dvb tree (and probably to v

[patch review] gspca - stv06xx: remove needless if check and goto

2009-06-09 Thread Alexey Klimov
Hello, Jean-Francois and Erik André What do you think about such small change? Looks like the code doesn't need if-check and goto here in stv06xx_stopN function. The code after label "out" does this. -- Patch removes needless if check and goto. Signed-off-by: Alexey Kli

Re: Probably strange bug with usb radio-mr800

2009-06-07 Thread Alexey Klimov
Hello, On Sun, Jun 7, 2009 at 1:07 AM, Oliver Neukum wrote: > Am Freitag, 5. Juni 2009 00:43:04 schrieb Alexey Klimov: >> Is there any ideas about different behaviour of device on 32- and >> 64-bit platforms with the same usb bulk messages? >> Any input is welcome. > &g

Re: [PATCH 5/9] V4L2: Added Timberdale Logiwin driver

2009-06-06 Thread Alexey Klimov
Hello, Richard i have only two small suggestions. On Fri, Jun 5, 2009 at 5:40 PM, Richard Röjfors wrote: > V4L2 video capture driver for the logiwin IP on the Timberdale FPGA. > > The driver uses the Timberdale DMA engine > > Signed-off-by: Richard Röjfors > --- > Index: linux-2.6.30-rc7/drivers/

Re: Probably strange bug with usb radio-mr800

2009-06-05 Thread Alexey Klimov
On Fri, Jun 5, 2009 at 2:53 AM, Greg KH wrote: > On Fri, Jun 05, 2009 at 02:43:04AM +0400, Alexey Klimov wrote: >> Is there any ideas about different behaviour of device on 32- and >> 64-bit platforms with the same usb bulk messages? > > No, there should be no difference. &g

Re: Probably strange bug with usb radio-mr800

2009-06-04 Thread Alexey Klimov
Is there any ideas about different behaviour of device on 32- and 64-bit platforms with the same usb bulk messages? Any input is welcome. On Wed, May 27, 2009 at 9:51 PM, Alexey Klimov wrote: [...] > So, the same messages to device works fine with radio on 32bit machine > and nothing on

[patch review 4/4] dsbr100: change radio->muted to radio->status, update suspend/resume

2009-05-28 Thread Alexey Klimov
Patch renames radio->muted to radio->status, add defines for that variable, and fixes suspend/resume procedure. Radio->status set to STOPPED in usb_dsbr100_probe because of removing open call. Also, patch increases driver version. Signed-off-by: Alexey Klimov -- diff -r 8046021e5

[patch review 3/4] dsbr100: no need to pass curfreq value to dsbr100_setfreq()

2009-05-28 Thread Alexey Klimov
Small cleanup of dsbr100_setfreq(). No need to pass radio->curfreq value to this function. Signed-off-by: Alexey Klimov -- diff -r d7322837a62c linux/drivers/media/radio/dsbr100.c --- a/linux/drivers/media/radio/dsbr100.c Tue May 19 15:18:56 2009 +0400 +++ b/linux/drivers/media/ra

[patch review 2/4] dsbr100: remove usb_dsbr100_open/close calls

2009-05-28 Thread Alexey Klimov
Patch removes usb_dsbr100_open and usb_dsbr100_close calls. 1. No need to start, set frequency, adjust parameters in open call. 2. This patch tackles issue with lock/unlock_kernel() in open call. 3. With this patch feature "Mute on exit?" in gnomeradio works. Signed-off-by: Ale

[patch review 1/4] dsbr100: remove radio->users counter

2009-05-28 Thread Alexey Klimov
Patch removes radio->users counter because it is not in use. Signed-off-by: Alexey Klimov -- diff -r 315bc4b65b4f linux/drivers/media/radio/dsbr100.c --- a/linux/drivers/media/radio/dsbr100.c Sun May 17 12:28:55 2009 + +++ b/linux/drivers/media/radio/dsbr100.c Tue May 19 15

[patch 0/4] Patches for dsbr100 radio

2009-05-28 Thread Alexey Klimov
There was discussion on maillist about lock/unlock_kernel, about open/close functions and about radio->users counter. So, there are patches arised from that discussion. There is suspend/resume procedure fix in patch 4/4. Here is description of patches: [1/4] dsbr100: remove radio->users counter

Probably strange bug with usb radio-mr800

2009-05-27 Thread Alexey Klimov
Hello, Doing some improvements in media/radio/radio-mr800.c i see very strange situation. I made simple patch that removed usb_amradio_open function. There is no need in this function (no need to start/set frequency radio in open procedure, and also removed lock/unlock_kernel() calls). Here is thi

Re: v4l-dvb and old kernels

2009-05-26 Thread Alexey Klimov
Hello, Antonio On Tue, May 26, 2009 at 5:03 PM, Antonio Beamud Montero wrote: > It would compile today's snapshot of v4l-dvb with an old kernel version (for > example 2.6.16)? (or is better to upgrade the kernel?) Not long time ago v4l-dvb community had discussions about dropping support for ker

Re: [patch 1/4] radio-mr800.c: missing mutex include

2009-05-13 Thread Alexey Klimov
dio/radio-mr800.c > --- a/drivers/media/radio/radio-mr800.c~radio-mr800c-missing-mutex-include > +++ a/drivers/media/radio/radio-mr800.c > @@ -64,6 +64,7 @@ >  #include >  #include >  #include     /* for KERNEL_VERSION MACRO */ > +#include > >  /* driver and module defi

Re: [cron job] v4l-dvb daily build 2.6.22 and up: ERRORS, 2.6.16-2.6.21: ERRORS

2009-05-04 Thread Alexey Klimov
Hello, Hans On Mon, May 4, 2009 at 10:04 PM, Hans Verkuil wrote: > This message is generated daily by a cron job that builds v4l-dvb for > the kernels and architectures in the list below. > > Results of the daily build of v4l-dvb: > > date:        Mon May  4 19:00:02 CEST 2009 > path:        http

Re: [questions] dmesg: Non-NULL drvdata on register

2009-05-04 Thread Alexey Klimov
On Mon, May 4, 2009 at 5:03 PM, Hans Verkuil wrote: > >> Hello, >> >> Not so many time ago i noticed such line in dmesg: >> >> radio-mr800 2-1:1.0: Non-NULL drvdata on register >> >> Quick review showed that it appears in usb_amradio_probe fucntions. Then >> i found such code in v4l2_device_regist

[questions] dmesg: Non-NULL drvdata on register

2009-05-04 Thread Alexey Klimov
Hello, Not so many time ago i noticed such line in dmesg: radio-mr800 2-1:1.0: Non-NULL drvdata on register Quick review showed that it appears in usb_amradio_probe fucntions. Then i found such code in v4l2_device_register() function (v4l2-device.c file): /* Set name to driver name + device na

Re: [PATCH] zoran: Fix &&/|| typo

2009-05-02 Thread Alexey Klimov
Hello, Roel On Sun, May 3, 2009 at 12:52 AM, Roel Kluin wrote: > Fix &&/|| typo > > diff --git a/drivers/media/video/zoran/zoran_card.c > b/drivers/media/video/zoran/zoran_card.c > index ea6c577..ea9de8b 100644 > --- a/drivers/media/video/zoran/zoran_card.c > +++ b/drivers/media/video/zoran/zora

Re: [PATCH 2/5] V4L2 patches for Intel Moorestown Camera Imaging Drivers

2009-05-01 Thread Alexey Klimov
Hello, Xiaolin On Fri, May 1, 2009 at 6:57 PM, Zhang, Xiaolin wrote: > No mind, welcome any comments. Oops, i already did. Probably comments are lost in big letter, please find them :) > I am working on this issue why the first patch -isp drive can't send it out. > Actually it is a little bit

Re: [cron job] v4l-dvb daily build 2.6.22 and up: ERRORS, 2.6.16-2.6.21: ERRORS

2009-04-30 Thread Alexey Klimov
Hello, On Mon, Apr 20, 2009 at 3:59 AM, Mike Isely wrote: > On Mon, 20 Apr 2009, Alexey Klimov wrote: > >   [...] > >> When trying to compile v4l-dvb tree under 2.6.30-rc2 (up-to-date) i >> have such error with pvr2 module: >> >>   CC [M]  /w/new/v4l-dvb/v4l

Re: [PATCH] radio_si470x: Drop unused label

2009-04-30 Thread Alexey Klimov
(added Tobias and Mauro on c/c) On Thu, Apr 30, 2009 at 6:16 PM, Nicola Soranzo wrote: > Fix this warning: > > /home/nicola/v4l-dvb/v4l/radio-si470x.c: In function 'si470x_fops_release': > /home/nicola/v4l-dvb/v4l/radio-si470x.c:1218: warning: label 'unlock' defined > but not used > > Priority:

Re: [PATCH 2/5] V4L2 patches for Intel Moorestown Camera Imaging Drivers

2009-04-30 Thread Alexey Klimov
Hello, do you mind if i make few comments? Really, looks like http://patchwork.kernel.org/project/linux-media/list/ didnt catch your [1/5] patch. On Thu, Apr 30, 2009 at 12:22 PM, Zhang, Xiaolin wrote: > From d8f37b4340ea4cfd28d6e620f1b3224d946b9fab Mon Sep 17 00:00:00 2001 > From: Xiaolin Zhang

Re: [cron job] v4l-dvb daily build 2.6.22 and up: ERRORS, 2.6.16-2.6.21: ERRORS

2009-04-19 Thread Alexey Klimov
On Sun, Apr 19, 2009 at 10:18 PM, Hans Verkuil wrote: > This message is generated daily by a cron job that builds v4l-dvb for > the kernels and architectures in the list below. > > Results of the daily build of v4l-dvb: > > date:        Sun Apr 19 19:00:03 CEST 2009 > path:        http://www.linux

[patch review] av7110_hw: fix compile warning

2009-04-19 Thread Alexey Klimov
One more warning fix. Signed-off-by: Alexey Klimov -- diff -r cda79523a93c linux/drivers/media/dvb/ttpci/av7110_hw.c --- a/linux/drivers/media/dvb/ttpci/av7110_hw.c Thu Apr 16 18:30:38 2009 +0200 +++ b/linux/drivers/media/dvb/ttpci/av7110_hw.c Mon Apr 20 00:17:51 2009 +0400 @@ -1089,7 +1089,7

[patch review] uvc_driver: fix compile warning

2009-04-19 Thread Alexey Klimov
Hello, all I saw warnings in v4l-dvb daily build. May this patch be helpful? Signed-off-by: Alexey Klimov -- diff -r cda79523a93c linux/drivers/media/video/uvc/uvc_driver.c --- a/linux/drivers/media/video/uvc/uvc_driver.cThu Apr 16 18:30:38 2009 +0200 +++ b/linux/drivers/media/video

Re: About the radio-si470x driver for I2C interface

2009-04-12 Thread Alexey Klimov
Hello, Tobias On Mon, Apr 13, 2009 at 12:56 AM, Tobias Lorenz wrote: > Hi Joonyoung, > > Hi Alexey, > > I've split the driver into a couple of segments: > > - radio-si470x-common.c is for common functions > > - radio-si470x-usb.c are the usb support functions > > - radio-si470x-i2c.c is an untest

Re: [PATCH] usb: add reset endpoint operations

2009-04-08 Thread Alexey Klimov
On Thu, Apr 9, 2009 at 3:40 AM, Greg KH wrote: > On Thu, Apr 09, 2009 at 03:36:51AM +0400, Alexey Klimov wrote: >> (added linux-media maillist) >> >> Hello, David >> >> On Wed, Apr 8, 2009 at 9:36 PM, David Vrabel wrote: >> > Wireless USB endpoint

Re: [PATCH] usb: add reset endpoint operations

2009-04-08 Thread Alexey Klimov
(added linux-media maillist) Hello, David On Wed, Apr 8, 2009 at 9:36 PM, David Vrabel wrote: > Wireless USB endpoint state has a sequence number and a current > window and not just a single toggle bit.  So allow HCDs to provide a > endpoint_reset method and call this or clear the software toggl

Re: [cron job] v4l-dvb daily build 2.6.22 and up: ERRORS, 2.6.16-2.6.21: WARNINGS

2009-04-08 Thread Alexey Klimov
On Thu, Apr 9, 2009 at 2:10 AM, Hans Verkuil wrote: > > Can someone take a look at these warnings and errors? Looking at the log > these seem to be pretty easy to fix (compat stuff for the most part). > > I don't have the time for this for several more days, so I'd appreciate it > if someone could

Re: Topro 6800 webcam driver

2009-04-07 Thread Alexey Klimov
On Tue, 2009-04-07 at 15:13 +0400, Andrey Panin wrote: > On 097, 04 07, 2009 at 11:41:32AM +0200, Anders Blomdell wrote: > > +static const struct sd_desc sd_desc = { > > + .name = MODULE_NAME, > > + .ctrls = sd_ctrls, > > + .nctrls = ARRAY_SIZE(sd_ctrls), > > + .config = sd_config, > >

[patch 1/2] dsbr100 radio: convert to to v4l2_device

2009-04-03 Thread Alexey Klimov
dsbr100: convert to v4l2_device. Signed-off-by: Alexey Klimov -- diff -r f86c84534cb4 linux/drivers/media/radio/dsbr100.c --- a/linux/drivers/media/radio/dsbr100.c Sun Mar 29 22:54:35 2009 -0300 +++ b/linux/drivers/media/radio/dsbr100.c Tue Mar 31 15:54:36 2009 +0400 @@ -32,6 +32,9

[patch 2/2] radio-mr800: convert to to v4l2_device

2009-04-03 Thread Alexey Klimov
radio-mr800: convert to to v4l2_device. Signed-off-by: Alexey Klimov -- diff -r 4cd17f5a20cc linux/drivers/media/radio/radio-mr800.c --- a/linux/drivers/media/radio/radio-mr800.c Thu Apr 02 20:50:21 2009 -0300 +++ b/linux/drivers/media/radio/radio-mr800.c Sat Apr 04 01:32:08 2009 +0400

  1   2   >