Re: RFC: Core + Radio profile

2012-08-22 Thread Hans de Goede
Hi, On 08/22/2012 11:40 AM, Hans Verkuil wrote: Hi all! Snip While writing down these profiles I noticed one thing that was very much missing for radio devices: there is no capability bit to tell the application whether there is an associated ALSA device or whether the audio goes through a

Re: [PATCH] media/radio/shark2: Fix build error caused by missing dependencies

2012-08-22 Thread Hans de Goede
/media/radio/shark2.ko] undefined! ERROR: led_classdev_unregister [drivers/media/radio/shark2.ko] undefined! which is seen if RADIO_SHARK2 is enabled, but LEDS_CLASS is not. Since RADIO_SHARK2 depends on NEW_LEDS and LEDS_CLASS, select both if it is enabled. Cc: Hans de Goede hdego...@redhat.com

Re: How to add support for the em2765 webcam Speedlink VAD Laplace to the kernel ?

2012-08-20 Thread Hans de Goede
Hi, On 08/20/2012 01:41 PM, Frank Schäfer wrote: Hi, after a break of 2 1/2 kernel releases (sorry, I was busy with another project), I would like to bring up again the question how to add support for this device to the kernel. See

Re: How to add support for the em2765 webcam Speedlink VAD Laplace to the kernel ?

2012-08-20 Thread Hans de Goede
Hi, On 08/20/2012 09:21 PM, Mauro Carvalho Chehab wrote: Em 20-08-2012 10:02, Hans de Goede escreveu: snip Note that luckily these devices do use a unique USB id and not one of the generic em28xx ids so from that pov having a specialized driver for them is not an issue. Hans, Not sure

[GIT PULL FOR 3.7] Misc. fixes + shark improvements

2012-08-18 Thread Hans de Goede
) Emil Goode (1): gspca: dubious one-bit signed bitfield Ezequiel Garcia (1): pwc: Use vb2 queue mutex through a single name Hans de Goede (10): radio-shark*: Remove work-around for dangling pointer in usb intfdata radio

Re: V4L2 API ambiguities: workshop presentation

2012-08-17 Thread Hans de Goede
Hi, On 08/17/2012 12:35 PM, Hans Verkuil wrote: Hi all, I've prepared a presentation for the upcoming workshop based on my RFC and the comments I received. It is available here: http://hverkuil.home.xs4all.nl/presentations/v4l2-workshop-2012.odp

Re: [Workshop-2011] V4L2 API ambiguities: workshop presentation

2012-08-17 Thread Hans de Goede
Hi, On 08/17/2012 02:57 PM, Laurent Pinchart wrote: Snip Regarding ENUM_FRAMESIZES: it makes sense to add an aspect ratio here for use with sensors. But for video receivers ENUM_FRAMESIZES isn't applicable. Do we have sensors with non-square pixels ? Short answer: not that I know of.

[GIT-PULL FIXES for 3.6] radio-shark*: Only compile led support when CONFIG_LED_CLASS is set

2012-08-15 Thread Hans de Goede
media-for_v3.6 for you to fetch changes up to 74e8155de5331ef7f707ed22432a79f1477a7d22: radio-shark2: Only compile led support when CONFIG_LED_CLASS is set (2012-08-15 12:05:49 +0200) Hans de Goede (4): radio-shark*: Remove

Re: [Workshop-2011] RFC: V4L2 API ambiguities

2012-08-14 Thread Hans de Goede
Hi, On 08/13/2012 09:15 PM, Sylwester Nawrocki wrote: snip And if a driver also supports single-plane formats in addition to 1 plane formats, should V4L2_CAP_VIDEO_CAPTURE be compulsary? Yes, so that non multi-plane aware apps keep working. There is the multi-planar API and there are

Re: [Workshop-2011] RFC: V4L2 API ambiguities

2012-08-14 Thread Hans de Goede
Hi, On 08/14/2012 02:00 AM, Laurent Pinchart wrote: Hi Hans, On Monday 13 August 2012 15:13:34 Hans de Goede wrote: [snip] 4) What should a driver return in TRY_FMT/S_FMT if the requested format is not supported (possible behaviours include returning the currently selected format

Re: Copyright issues, do not copy code and add your own copyrights

2012-08-14 Thread Hans de Goede
Hi, On 08/14/2012 11:10 AM, Manu Abraham wrote: Hi, The subject line says it. Please fix the offending Copyright header. Offending one. http://git.linuxtv.org/media_tree.git/blob/staging/for_v3.7:/drivers/media/dvb-frontends/stb6100_proc.h Original one.

Re: Copyright issues, do not copy code and add your own copyrights

2012-08-14 Thread Hans de Goede
Hi, On 08/14/2012 11:42 AM, Manu Abraham wrote: Hi, On Tue, Aug 14, 2012 at 2:51 PM, Hans de Goede hdego...@redhat.com wrote: Hi, On 08/14/2012 11:10 AM, Manu Abraham wrote: Hi, The subject line says it. Please fix the offending Copyright header. Offending one. http://git.linuxtv.org

Re: [Workshop-2011] RFC: V4L2 API ambiguities

2012-08-14 Thread Hans de Goede
Hi, On 08/14/2012 12:54 PM, Hans Verkuil wrote: On Tue August 14 2012 01:54:16 Laurent Pinchart wrote: Hi Hans, On Monday 13 August 2012 14:27:56 Hans Verkuil wrote: Hi all! As part of the 2012 Kernel Summit V4L2 workshop I will be discussing a bunch of V4L2 ambiguities/improvements. I've

Re: [Workshop-2011] RFC: V4L2 API ambiguities

2012-08-13 Thread Hans de Goede
Hi, snip Easy: 1) Split off the control part from videodev2.h. Controls are almost 30% of videodev2.h. I think maintaining controls would be easier if they are moved to e.g. linux/v4l2-controls.h which is included by videodev2.h. Ack. 2) Currently there are three types of

Re: [Workshop-2011] RFC: V4L2 API ambiguities

2012-08-13 Thread Hans de Goede
Hi, On 08/13/2012 04:52 PM, Hans Verkuil wrote: On Mon August 13 2012 15:13:34 Hans de Goede wrote: Hi, snip 5) How to handle tuner ownership if both a video and radio node share the same tuner? Obvious rules: - Calling S_FREQ, S_TUNER, S_MODULATOR or S_HW_FREQ_SEEK

Re: [RFC PATCH] Add core TMC (Traffic Message Channel) support

2012-08-12 Thread Hans de Goede
Hi, Looks good to me. Regards, Hans On 08/10/2012 07:04 PM, Konke Radlow wrote: Signed-off-by: Konke Radlow korad...@gmail.com --- lib/include/libv4l2rds.h| 64 lib/libv4l2rds/libv4l2rds.c | 340 ++- utils/rds-ctl/rds-ctl.cpp |

Re: [PATCH 1/2] radio-shark: Only compile led support when CONFIG_LED_CLASS is set

2012-08-11 Thread Hans de Goede
Hi, On 08/10/2012 10:15 PM, Mauro Carvalho Chehab wrote: Em 10-08-2012 16:58, Hans de Goede escreveu: Reported-by: Dadiv Rientjes rient...@google.com Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/radio/radio-shark.c | 26 -- 1 file changed, 24

[PATCH 1/4] radio-shark*: Remove work-around for dangling pointer in usb intfdata

2012-08-11 Thread Hans de Goede
Recent kernels properly clear the usb intfdata pointer when another driver fails to bind (in the radio-shark* case the usbhid driver would try to bind first. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/radio/radio-shark.c | 9 - drivers/media/radio/radio-shark2.c

[PATCH 4/4] radio-shark2: Only compile led support when CONFIG_LED_CLASS is set

2012-08-11 Thread Hans de Goede
Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/radio/radio-shark2.c | 122 ++--- 1 file changed, 73 insertions(+), 49 deletions(-) diff --git a/drivers/media/radio/radio-shark2.c b/drivers/media/radio/radio-shark2.c index 217483c..7b4efdf

[PATCH 3/4] radio-shark: Only compile led support when CONFIG_LED_CLASS is set

2012-08-11 Thread Hans de Goede
Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/radio/radio-shark.c | 135 ++ 1 file changed, 79 insertions(+), 56 deletions(-) diff --git a/drivers/media/radio/radio-shark.c b/drivers/media/radio/radio-shark.c index 05e12bf..e1970bf 100644

[PATCH 0/4] radio-shark*: Only compile led support when CONFIG_LED_CLA

2012-08-11 Thread Hans de Goede
Hi All, Here is the second revision of my patch-set to fix the build breakage when the radio-shark* drivers are enabled and CONFIG_LED_CLASS is not enabled. This new version introduces 2 new cleanup / preparation patches, and take into account the remarks from Mauro's review of v1. Regards,

[PATCH 2/4] radio-shark*: Call cancel_work_sync from disconnect rather then release

2012-08-11 Thread Hans de Goede
This removes the need for shark_led_work to take the v4l2 lock. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/radio/radio-shark.c | 13 ++--- drivers/media/radio/radio-shark2.c | 12 ++-- 2 files changed, 4 insertions(+), 21 deletions(-) diff --git

Re: [GIT PULL for 3.6-rc1] media updates part 2

2012-08-10 Thread Hans de Goede
Hi, On 08/09/2012 10:03 PM, David Rientjes wrote: On Thu, 9 Aug 2012, Mauro Carvalho Chehab wrote: Yeah, that would work as well, although the code would look uglier. IMHO, using select/depend is better. Agreed, I think it should be depends on LEDS_CLASS rather than select it if there is a

Re: [RFC PATCH 1/2] Add libv4l2rds library (with changes proposed in RFC)

2012-08-10 Thread Hans de Goede
Hi, On 08/09/2012 02:14 PM, Hans Verkuil wrote: On Thu August 9 2012 13:58:07 Hans de Goede wrote: Hi Konke, As Gregor already mentioned there is no need to define libv4l2rdssubdir in configure.ac , so please drop that. Other then that I've some minor remarks (comments inline), with all

Re: [RFC PATCH 1/2] Add libv4l2rds library (with changes proposed in RFC)

2012-08-10 Thread Hans de Goede
Hi, On 08/10/2012 09:36 AM, Hans Verkuil wrote: On Fri 10 August 2012 09:16:34 Hans de Goede wrote: Hi, On 08/09/2012 02:14 PM, Hans Verkuil wrote: On Thu August 9 2012 13:58:07 Hans de Goede wrote: Hi Konke, As Gregor already mentioned there is no need to define libv4l2rdssubdir

[PATCH 2/2] radio-shark2: Only compile led support when CONFIG_LED_CLASS is set

2012-08-10 Thread Hans de Goede
Reported-by: Dadiv Rientjes rient...@google.com Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/radio/radio-shark2.c | 27 --- 1 file changed, 24 insertions(+), 3 deletions(-) diff --git a/drivers/media/radio/radio-shark2.c b/drivers/media/radio/radio

[PATCH 1/2] radio-shark: Only compile led support when CONFIG_LED_CLASS is set

2012-08-10 Thread Hans de Goede
Reported-by: Dadiv Rientjes rient...@google.com Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/radio/radio-shark.c | 26 -- 1 file changed, 24 insertions(+), 2 deletions(-) diff --git a/drivers/media/radio/radio-shark.c b/drivers/media/radio/radio

Re: [PATCH] pwc: Use vb2 queue mutex through a single name

2012-08-09 Thread Hans de Goede
Hi, Thanks for the patch, I've added it to my tree for 3.7: http://git.linuxtv.org/hgoede/gspca.git/shortlog/refs/heads/media-for_v3.7-wip Regards, Hans On 07/15/2012 08:00 AM, Ezequiel Garcia wrote: This lock was being taken using two different names (pointers) in the same function. Both

Re: [PATCH] [media] gspca: dubious one-bit signed bitfield

2012-08-09 Thread Hans de Goede
Hi, Thanks for the patch, I've added it to my tree for 3.7: http://git.linuxtv.org/hgoede/gspca.git/shortlog/refs/heads/media-for_v3.7-wip Regards, Hans On 08/05/2012 02:34 PM, Emil Goode wrote: This patch changes some signed integers to unsigned because they are not intended for negative

Re: [RFC PATCH 1/2] Add libv4l2rds library (with changes proposed in RFC)

2012-08-09 Thread Hans de Goede
Hi Konke, As Gregor already mentioned there is no need to define libv4l2rdssubdir in configure.ac , so please drop that. Other then that I've some minor remarks (comments inline), with all those fixed, this one is could to go. So hopefully the next version can be added to git master! On

Re: [GIT PULL for 3.6-rc1] media updates part 2

2012-08-09 Thread Hans de Goede
/shark2.ko] undefined! Reported-by: Dadiv Rientjes rient...@google.com Cc: Hans de Goede hdego...@redhat.com Signed-off-by: Mauro Carvalho Chehab mche...@redhat.com diff --git a/drivers/media/radio/Kconfig b/drivers/media/radio/Kconfig index 8090b87..be68ec2 100644 --- a/drivers/media/radio

Re: [RFC PATCH 2/2] Add rds-ctl tool (with changes proposed in RFC)

2012-08-09 Thread Hans de Goede
Hi, Comments inline. On 08/07/2012 05:11 PM, Konke Radlow wrote: --- Makefile.am |3 +- configure.ac |1 + utils/rds-ctl/Makefile.am |5 + utils/rds-ctl/rds-ctl.cpp | 959 + 4 files changed, 967

Re: [PATCH] [media] gspca: dubious one-bit signed bitfield

2012-08-06 Thread Hans de Goede
Hi, On 08/05/2012 02:34 PM, Emil Goode wrote: This patch changes some signed integers to unsigned because they are not intended for negative values and sparse is making noise about it. Sparse gives eight of these errors: drivers/media/video/gspca/ov519.c:144:29: error: dubious one-bit signed

Re: linux-next: Tree for July 31 (media/radio-tea5777)

2012-08-01 Thread Hans de Goede
Thanks for fixing this for me! Acked-by: Hans de Goede hdego...@redhat.com On 07/31/2012 09:56 PM, Mauro Carvalho Chehab wrote: Em 31-07-2012 14:22, Randy Dunlap escreveu: drivers/built-in.o: In function `radio_tea5777_set_freq': radio-tea5777.c:(.text+0x4d8704): undefined reference

Re: Advice on extending libv4l for media controller support

2012-07-28 Thread Hans de Goede
Hi, On 07/26/2012 10:49 PM, Robert Abel wrote: Hi, Sorry to be late to the party... I wanted to follow up on this discussion, but forgot and haven't read anything about it since... On 10.05.2012 17:09, Ivan T. Ivanov wrote: On Wed, May 9, 2012 at 7:08 PM, Sergio Aguirre

Re: [RFC PATCH 1/2] Initial version of the RDS-decoder library Signed-off-by: Konke Radlow krad...@cisco.com

2012-07-28 Thread Hans de Goede
Hi, First of all many thanks for working on this! Note I've also taken a quick look at the original patch with the actual implementation and that looks good. I'm replying here because in my mind the API is the most interesting thing to discuss. Comments inline. On 07/26/2012 06:21 PM, Konke

Re: [RFC PATCH 2/2] Initial version of RDS Control utility Signed-off-by: Konke Radlow krad...@cisco.com

2012-07-28 Thread Hans de Goede
Hi, Overall this looks good, but some of the code, for example the set/get freq and get/set tuner stuff seems to be a 1 on 1 copy of code from v4l2-ctrl, please factor this out into a common file which can be shared between both utilities (I think Hans V's recent work on splitting v4l2-ctl into

Vacation hansg July 13th - July 20th

2012-07-12 Thread Hans de Goede
Hi All, I'm going on vacation for a week starting tomorrow, and I will *not* be reading email, etc. during that time. Regards, Hans -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH 1/5] v4l2: Add rangelow and rangehigh fields to the v4l2_hw_freq_seek struct

2012-07-12 Thread Hans de Goede
Hi, On 07/11/2012 08:37 PM, halli manjunatha wrote: On Wed, Jul 11, 2012 at 1:01 PM, Hans Verkuil hverk...@xs4all.nl wrote: Hi Hans, Thanks for the patch. I've CC-ed Halli as well. On Wed July 11 2012 17:47:34 Hans de Goede wrote: To allow apps to limit a hw-freq-seek to a specific band

RFC: Add support for limiting hw freq seeks to a certain band (v2)

2012-07-12 Thread Hans de Goede
This patchset, which builds on top of hverkuil's bands2 branch, which adds the VIDIOC_ENUM_FREQ_BANDS API, add support for limiting hw freq seeks to one of the bands from VIDIOC_ENUM_FREQ_BANDS, or a subset there of. The first patch introduces the new API and documents its, the other patches are

[PATCH 1/5] v4l2 spec: add VIDIOC_ENUM_FREQ_BANDS documentation.

2012-07-12 Thread Hans de Goede
From: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- Documentation/DocBook/media/v4l/compat.xml | 12 ++ Documentation/DocBook/media/v4l/v4l2.xml |6 + .../DocBook/media/v4l/vidioc-enum-freq-bands.xml | 179

[PATCH 2/5] v4l2: Add rangelow and rangehigh fields to the v4l2_hw_freq_seek struct

2012-07-12 Thread Hans de Goede
To allow apps to limit a hw-freq-seek to a specific band, for further info see the documentation this patch adds for these new fields. Signed-off-by: Hans de Goede hdego...@redhat.com --- .../DocBook/media/v4l/vidioc-s-hw-freq-seek.xml| 50 include/linux/videodev2.h

[PATCH 4/5] radio-si470x: Fix band selection

2012-07-12 Thread Hans de Goede
The mask was wrong resulting in band 0 and 1 always ending up as band 0 in the register. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/radio/si470x/radio-si470x.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/radio/si470x/radio-si470x.h

[PATCH 3/5] radio-si470x: restore ctrl settings after suspend/resume

2012-07-12 Thread Hans de Goede
Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/radio/si470x/radio-si470x-usb.c |7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/media/radio/si470x/radio-si470x-usb.c b/drivers/media/radio/si470x/radio-si470x-usb.c index 40b963c..0204cf4

[PATCH 5/5] radio-si470x: Add support for the new band APIs

2012-07-12 Thread Hans de Goede
Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/radio/si470x/radio-si470x-common.c | 215 +- drivers/media/radio/si470x/radio-si470x-i2c.c|1 + drivers/media/radio/si470x/radio-si470x-usb.c|1 + drivers/media/radio/si470x/radio-si470x.h

Re: video: USB webcam fails since kernel 3.2

2012-07-11 Thread Hans de Goede
Hi, On 07/11/2012 02:01 PM, Martin-Éric Racine wrote: 2012/7/11 Jean-Francois Moine moin...@free.fr: On Wed, 11 Jul 2012 14:14:24 +0300 Martin-Éric Racine martin-eric.rac...@iki.fi wrote: CC [M] /home/perkelix/gspca-2.15.18/build/ov534_9.o /home/perkelix/gspca-2.15.18/build/ov534_9.c: In

RFC: Add support for limiting hw freq seeks to a certain band

2012-07-11 Thread Hans de Goede
This patchset, which builds on top of hverkuil's bands2 branch, which adds the VIDIOC_ENUM_FREQ_BANDS API, add support for limiting hw freq seeks to one of the bands from VIDIOC_ENUM_FREQ_BANDS, or a subset there of. The first patch introduces the new API and documents its, the other patches are

[PATCH 1/5] v4l2: Add rangelow and rangehigh fields to the v4l2_hw_freq_seek struct

2012-07-11 Thread Hans de Goede
To allow apps to limit a hw-freq-seek to a specific band, for further info see the documentation this patch adds for these new fields. Signed-off-by: Hans de Goede hdego...@redhat.com --- .../DocBook/media/v4l/vidioc-s-hw-freq-seek.xml| 44 include/linux/videodev2.h

[PATCH 3/5] radio-si470x: Fix band selection

2012-07-11 Thread Hans de Goede
The mask was wrong resulting in band 0 and 1 always ending up as band 0 in the register. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/radio/si470x/radio-si470x.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/radio/si470x/radio-si470x.h

[PATCH 5/5] radio-si470x: Lower firmware version requirements

2012-07-11 Thread Hans de Goede
Testing with a firmware version 12 usb radio stick has shown version 12 to work fine too. Reported-by: Antti Palosaari cr...@iki.fi Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/radio/si470x/radio-si470x.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 4/5] radio-si470x: Add support for the new band APIs

2012-07-11 Thread Hans de Goede
Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/radio/si470x/radio-si470x-common.c | 215 +- drivers/media/radio/si470x/radio-si470x-i2c.c|1 + drivers/media/radio/si470x/radio-si470x-usb.c|1 + drivers/media/radio/si470x/radio-si470x.h

[PATCH 2/5] radio-si470x: restore ctrl settings after suspend/resume

2012-07-11 Thread Hans de Goede
Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/radio/si470x/radio-si470x-usb.c |7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/media/radio/si470x/radio-si470x-usb.c b/drivers/media/radio/si470x/radio-si470x-usb.c index 40b963c..0204cf4

Re: [PATCH 1/5] v4l2: Add rangelow and rangehigh fields to the v4l2_hw_freq_seek struct

2012-07-11 Thread Hans de Goede
Hi Hans, On 07/11/2012 08:01 PM, Hans Verkuil wrote: Hi Hans, Thanks for the patch. I've CC-ed Halli as well. On Wed July 11 2012 17:47:34 Hans de Goede wrote: To allow apps to limit a hw-freq-seek to a specific band, for further info see the documentation this patch adds for these new

[PATCH-3.5 ] Fix sn9c20x regression (was [regression 3.4-3.5, bisected] kernel oops when starting capturing from gspca-sn9c20x webcams)

2012-07-09 Thread Hans de Goede
Hi Linus, I'm sending this patch (attached) directly to you, since it fixes a regression in 3.5-rc6, and Mauro is on vacation. Please add this to the next 3.5 rc. Thanks Regards, Hans On 07/08/2012 10:04 PM, Frank Schäfer wrote: Am 08.07.2012 19:43, schrieb Hans de Goede: Hi, Thanks

Re: video: USB webcam fails since kernel 3.2

2012-07-09 Thread Hans de Goede
Hi, On 07/08/2012 08:33 PM, Jean-Francois Moine wrote: On Sun, 08 Jul 2012 19:58:08 +0200 Hans de Goede hdego...@redhat.com wrote: Hmm, this is then likely caused by the new isoc bandwidth negotiation code in 3.2, unfortunately the vc032x driver is one of the few gspca drivers for which I

Re: [PATCH 4/4] radio-si470x: Lower firmware version requirements

2012-07-09 Thread Hans de Goede
Hi, On 07/09/2012 11:17 AM, Antti Palosaari wrote: On 07/07/2012 09:53 PM, Hans de Goede wrote: Hi, On 07/07/2012 11:00 AM, Antti Palosaari wrote: Hello Hans, On 07/07/2012 10:58 AM, Hans de Goede wrote: So is your device working properly now? The reason I'm asking it because it is still

Re: [PATCH 4/4] radio-si470x: Lower firmware version requirements

2012-07-09 Thread Hans de Goede
Hi, On 07/09/2012 01:58 PM, Antti Palosaari wrote: On 07/09/2012 01:03 PM, Hans de Goede wrote: If I tune using old radio it works. If I tune using latest radio but with option -l 0 (./console/radio -l 0) it also works. Using arecord -D hw:2,0 -r96000 -c2 -f S16_LE | aplay - to listen. So

Re: video: USB webcam fails since kernel 3.2

2012-07-09 Thread Hans de Goede
Hi, On 07/09/2012 01:33 PM, Martin-Éric Racine wrote: snip Hmm, this is then likely caused by the new isoc bandwidth negotiation code in 3.2, unfortunately the vc032x driver is one of the few gspca drivers for which I don't have a cam to test with. Can you try to build your own kernel from

Re: [regression 3.4-3.5, bisected] kernel oops when starting capturing from gspca-sn9c20x webcams

2012-07-08 Thread Hans de Goede
: Convert to the control framework HdG: Small fix: don't register some controls for sensors which don't have an implementation for them. Signed-off-by: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Hans de Goede hdego...@redhat.com Signed-off-by: Mauro Carvalho Chehab mche

Re: video: USB webcam fails since kernel 3.2

2012-07-08 Thread Hans de Goede
Hi, On 07/08/2012 03:01 PM, Martin-Éric Racine wrote: 2012/6/17 Martin-Éric Racine martin-eric.rac...@iki.fi: pe, 2012-06-15 kello 23:41 -0500, Jonathan Nieder kirjoitti: Martin-Éric Racine wrote: usb 1-7: new high-speed USB device number 3 using ehci_hcd [...] usb 1-7: New USB device

Re: [PATCH 4/4] radio-si470x: Lower firmware version requirements

2012-07-07 Thread Hans de Goede
Hi, So is your device working properly now? The reason I'm asking it because it is still causing a firmware version warning, and if it works fine I would like to lower the firmware version warning point, so that the warning goes away. Regards, Hans -- To unsubscribe from this list: send the

[PATCH] media/video: Add v4l2-common.h to userspace headers

2012-07-07 Thread Hans de Goede
The user header CHECK in usr/include/linux was (rightfully) failing because of v4l2-common.h missing, this patch fixes this. Signed-off-by: Hans de Goede hdego...@redhat.com --- include/linux/Kbuild |1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/Kbuild b/include/linux

[PATCH] v4l2-ioctl: Don't assume file-private_data always points to a v4l2_fh

2012-07-07 Thread Hans de Goede
(V4L2_FL_USES_V4L2_FH, vfd-flags) tests to the ctrl ioctl helpers v4l2_fh paths, fixing the issues with for example the bttv driver. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/video/v4l2-ioctl.c | 21 ++--- 1 file changed, 14 insertions(+), 7 deletions

Re: [PATCH 4/4] radio-si470x: Lower firmware version requirements

2012-07-07 Thread Hans de Goede
Hi, On 07/07/2012 11:00 AM, Antti Palosaari wrote: Hello Hans, On 07/07/2012 10:58 AM, Hans de Goede wrote: So is your device working properly now? The reason I'm asking it because it is still causing a firmware version warning, and if it works fine I would like to lower the firmware version

Re: [PATCH] v4l2-ioctl: Don't assume file-private_data always points to a v4l2_fh

2012-07-07 Thread Hans de Goede
Hi, On 07/07/2012 09:11 PM, Hans Verkuil wrote: On Sat July 7 2012 20:46:21 Hans de Goede wrote: Commit efbceecd4522a41b8442c6b4f68b4508d57d1ccf, adds a number of helper functions for ctrl related ioctls to v4l2-ioctl.c, these helpers assume that if file-private_data != NULL, it points

[GIT PULL for 3.6] gspca control-framework conversions and radio drivers work

2012-07-07 Thread Hans de Goede
. v4l2-ioctl: Don't assume file-private_data always points to a v4l2_fh Hans de Goede (24): snd_tea575x: Add write_/read_val operations snd_tea575x: Add a cannot_mute flag radio-shark: New driver for the Griffin radioSHARK USB radio receiver radio-si470x: Don't

Re: [PATCH 0/6] Add frequency band information

2012-07-05 Thread Hans de Goede
Series looks good to me, ack series: Acked-by: Hans de Goede hdego...@redhat.com On 07/05/2012 12:25 PM, Hans Verkuil wrote: Hi Mauro, This should be the final patch series for adding multiband support to the kernel. This patch series assumes that this pull request was merged first: http

Re: [PATCH 4/4] radio-si470x: Lower firmware version requirements

2012-07-05 Thread Hans de Goede
Hi, On 07/05/2012 03:35 PM, Antti Palosaari wrote: snip I believe you're doing something wrong ... I compiled radio from http://git.linuxtv.org/xawtv3.git to tune and arecord -r96000 -c2 -f S16_LE | aplay - to play sound. Just silent white noise is heard. You're not specifying which

Re: [PATCH 4/4] radio-si470x: Lower firmware version requirements

2012-07-05 Thread Hans de Goede
Hi, On 07/05/2012 04:13 PM, Antti Palosaari wrote: On 07/05/2012 04:41 PM, Hans de Goede wrote: Hi, On 07/05/2012 03:35 PM, Antti Palosaari wrote: snip I believe you're doing something wrong ... I compiled radio from http://git.linuxtv.org/xawtv3.git to tune and arecord -r96000 -c2

Re: [RFC PATCH 1/6] videodev2.h: add VIDIOC_ENUM_FREQ_BANDS.

2012-07-04 Thread Hans de Goede
Hi, On 07/04/2012 10:35 AM, Hans Verkuil wrote: snip snip Can we have a (hopefully short) irc discussion today? I'd really like to get this API finalized. +1, I'm available the entire day (CET office hours + evening if needed that is) snip snip So my current proposal is: use a bitfield

Re: [RFC PATCH 0/6] Add frequency band information

2012-07-02 Thread Hans de Goede
Hi, Series looks good to me, ack series: Acked-by: Hans de Goede hdego...@redhat.com Regards, Hans On 07/02/2012 04:15 PM, Hans Verkuil wrote: Hi all, This patch series adds support for the new VIDIOC_ENUM_FREQ_BANDS ioctl that tells userspace if a tuner supports multiple frequency bands

Re: [git:v4l-dvb/for_v3.6] [media] gspca-core: Fix buffers staying in queued state after a stream_off

2012-06-29 Thread Hans de Goede
buffers staying in queued state after a stream_off Author: Hans de Goede hdego...@redhat.com Date:Tue May 22 11:24:05 2012 -0300 This fixes a regression introduced by commit f7059ea and should be backported to all supported stable kernels which have this commit. Signed-off-by: Hans de Goede hdego

Re: [RFCv2 PATCH 4/6] videodev2.h: add frequency band information.

2012-06-23 Thread Hans de Goede
Hi, On 06/22/2012 06:15 PM, Mauro Carvalho Chehab wrote: Em 22-06-2012 11:07, Hans Verkuil escreveu: snip Reusing G_TUNER/S_TUNER or not, the issue is that a bitfield parameter for frequency range is not actually able to express what are the supported ranges. As I said before, the tuner

Re: [RFCv2 PATCH 4/6] videodev2.h: add frequency band information.

2012-06-19 Thread Hans de Goede
Hi, On 06/19/2012 02:47 AM, Mauro Carvalho Chehab wrote: Em 28-05-2012 07:46, Hans Verkuil escreveu: From: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Hans Verkuil hans.verk...@cisco.com Acked-by: Hans de Goede hdego...@redhat.com --- include/linux/videodev2.h | 19

Re: [RFCv2 PATCH 4/6] videodev2.h: add frequency band information.

2012-06-19 Thread Hans de Goede
Hi, On 06/19/2012 01:09 PM, Mauro Carvalho Chehab wrote: Em 19-06-2012 05:27, Hans de Goede escreveu: Hi, On 06/19/2012 02:47 AM, Mauro Carvalho Chehab wrote: Em 28-05-2012 07:46, Hans Verkuil escreveu: From: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Hans Verkuil hans.verk

Re: [RFCv2 PATCH 4/6] videodev2.h: add frequency band information.

2012-06-19 Thread Hans de Goede
Hi, snip long discussion about having a fixed set of bands versus a way to enumerate bands, including their rangelow, rangehigh and capabilities Ok, you've convinced me. I agree that having a way to actually enumerate ranges, rather then having a fixed set of ranges, is better. Which brings

Re: [RFCv2 PATCH 4/6] videodev2.h: add frequency band information.

2012-06-19 Thread Hans de Goede
Hi, On 06/19/2012 06:47 PM, Hans de Goede wrote: Hi, snip long discussion about having a fixed set of bands versus a way to enumerate bands, including their rangelow, rangehigh and capabilities Ok, you've convinced me. I agree that having a way to actually enumerate ranges, rather then having

Re: [RFCv2 PATCH 4/6] videodev2.h: add frequency band information.

2012-06-19 Thread Hans de Goede
Hi, On 06/19/2012 07:43 PM, halli manjunatha wrote: On Tue, Jun 19, 2012 at 12:33 PM, Hans de Goede hdego...@redhat.com wrote: Hi, On 06/19/2012 06:47 PM, Hans de Goede wrote: Hi, snip long discussion about having a fixed set of bands versus a way to enumerate bands, including

[PATCH 1/4] radio-si470x: Don't unnecesarily read registers on G_TUNER

2012-06-14 Thread Hans de Goede
) Windows does not suffer from the pop sounds After a quick look at the driver I found at that the register reads are not necessary at all, as the device gives us the necessary status through usb interrupt packets, and the driver already uses these! Signed-off-by: Hans de Goede hdego...@redhat.com

[PATCH 3/4] radio-si470x: Lower hardware freq seek signal treshold

2012-06-14 Thread Hans de Goede
The previous value made hardware freq seek not work for me, despite having good reception of almost all Dutch radio stations. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/radio/si470x/radio-si470x-common.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 4/4] radio-si470x: Lower firmware version requirements

2012-06-14 Thread Hans de Goede
With the changes from the previous patches device firmware version 14 + usb microcontroller software version 1 works fine too. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/radio/si470x/radio-si470x-usb.c |2 +- drivers/media/radio/si470x/radio-si470x.h |2 +- 2

[PATCH 2/4] radio-si470x: Always use interrupt to wait for tune/seek completion

2012-06-14 Thread Hans de Goede
monitored. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/radio/si470x/radio-si470x-common.c | 56 +- drivers/media/radio/si470x/radio-si470x-i2c.c|5 +- drivers/media/radio/si470x/radio-si470x-usb.c| 25 ++ drivers/media/radio/si470x/radio

Re: [git:v4l-utils/master] libv4l: Move dev ops to libv4lconvert

2012-06-12 Thread Hans de Goede
Jun 11 21:59:25 2012 +0200 As discussed with Hans de Goede, this patch moves the plugin dev-ops structure to libv4lconvert. It was also renamed to libv4l_dev_ops. As a positive side effect we restored SONAME compatibility with the 0.8.x releases. Nice, good work! So I guess it is about time

Re: [RFCv1 PATCH 00/32] Core and vb2 enhancements

2012-06-12 Thread Hans de Goede
Hi, On 06/12/2012 01:35 PM, Mauro Carvalho Chehab wrote: Em 10-06-2012 16:27, Hans Verkuil escreveu: On Sun June 10 2012 19:32:36 Hans Verkuil wrote: On Sun June 10 2012 18:46:52 Mauro Carvalho Chehab wrote: 3) it would be interesting if you could benchmark the previous code and the new one,

Re: PWC ioctl inappropriate for device (Regression)

2012-06-11 Thread Hans de Goede
Hi, On 06/11/2012 04:34 PM, Bernard GODARD wrote: Hi Hans, Thank you for your reply. I will try to do the fix in qastrocam-g2 myself as this program does not currently have a maintainer. Thanks! Please let me know if you need any help. If programs like qastrocam-g2 are going to depend on

Re: PWC ioctl inappropriate for device (Regression)

2012-06-09 Thread Hans de Goede
Hi, On 06/09/2012 07:06 PM, Bernard GODARD wrote: Dear all, I am using a Philips Toucam Pro 2 webcam with the program qastrocam-g2 (astronomy program that use some specific functions of the PWC driver). I have been using this program with this camera for a long time on different Linux

Re: Doing a new upstream / linuxtv.org xawtv3 release?

2012-06-05 Thread Hans de Goede
Hi, On 06/04/2012 08:01 PM, Gregor Jasny wrote: Hello, On 6/4/12 12:57 PM, Hans de Goede wrote: I've been doing a lot of work on xawtv3 lately, mostly on the radio app but also some on xawtv itself. I'm no done and IMHO it would be good to do a new upstream release to get all those changes

Doing a new upstream / linuxtv.org xawtv3 release?

2012-06-04 Thread Hans de Goede
Hi All, I've been doing a lot of work on xawtv3 lately, mostly on the radio app but also some on xawtv itself. I'm no done and IMHO it would be good to do a new upstream release to get all those changes out there. So any comments / suggestions? Note go for it also is a valid comment :)

Re: [git:v4l-utils/master] Add HW_SEEK and TUNER_BAND capabilities to videodev2.h

2012-06-02 Thread Hans de Goede
Hi, On 06/02/2012 02:15 PM, Hans Verkuil wrote: On Sat June 2 2012 11:11:53 Hans de Goede wrote: This is an automatic generated email to let you know that the following patch were queued at the http://git.linuxtv.org/v4l-utils.git tree: Subject: Add HW_SEEK and TUNER_BAND capabilities

Re: Support for old Intel webcam

2012-06-01 Thread Hans de Goede
Hi, On 05/29/2012 08:46 PM, Jason Miller wrote: I have an old Intel webcam that shows up as: Bus 002 Device 005: ID 8086:0431 Intel Corp. Intel Pro Video PC Camera My hazy memory says that this used to work on linux with the spca_50x driver, though I think I had to add the vendor/device ID

Re: [RFCv2 PATCH 0/5] Add hwseek caps and frequency bands

2012-05-29 Thread Hans de Goede
Hi, On 05/28/2012 01:58 PM, Hans Verkuil wrote: On Mon May 28 2012 13:20:47 Hans de Goede wrote: Hi, Looks good, the entire series is: Acked-by: Hans de Goedehdego...@redhat.com I was thinking that it would be a good idea to add a: #define V4L2_TUNER_CAP_BANDS_MASK 0x001f to videodev2

[GIT PULL FIXES FOR 3.5]: gspca radio fixes (updated 3x)

2012-05-29 Thread Hans de Goede
) Antonio Ospite (1): gspca_ov534: make AGC and AWB controls independent Hans de Goede (10): radio/si470x: Add support for the Axentia ALERT FM USB Receiver snd_tea575x: Report correct frequency range for EU/US versus JA models

Re: [PATCH] gspca - ov534/ov534_9: Fix sccd_read/write errors

2012-05-29 Thread Hans de Goede
Hi, Thanks I've added this and the sonixj fixes to my tree and send an updated pullreq to Mauro to include these in the next round of fixes for 3.5 Regards, Hans On 05/28/2012 07:04 PM, Jean-Francois Moine wrote: The ov534 bridge is too slow to handle the sensor accesses requested by fast

Re: [RFCv2 PATCH 0/5] Add hwseek caps and frequency bands

2012-05-28 Thread Hans de Goede
Hi, Looks good, the entire series is: Acked-by: Hans de Goede hdego...@redhat.com I was thinking that it would be a good idea to add a: #define V4L2_TUNER_CAP_BANDS_MASK 0x001f to videodev2.h, which apps can then easily use to test if the driver supports any bands other then the default

Re: Discussion: How to deal with radio tuners which can tune to multiple bands

2012-05-27 Thread Hans de Goede
Hi, Just noticed the following on: http://linuxtv.org/downloads/v4l-dvb-apis/tuner.html#id2570531 This specification does not define radio output devices., iow no radio modulators, but we agreed upon making the band changes to the modulator too, and this makes sense because AFAIK we do support

Re: [RFCv1 PATCH 1/5] videodev2.h: add new hwseek capability bits.

2012-05-27 Thread Hans de Goede
Looks good: Acked-by: Hans de Goede hdego...@redhat.com On 05/27/2012 01:50 PM, Hans Verkuil wrote: From: Hans Verkuilhans.verk...@cisco.com Tell the application whether the hardware seek is bounded and/or wraps around. Signed-off-by: Hans Verkuilhans.verk...@cisco.com --- include/linux

Re: [RFCv1 PATCH 2/5] v4l2 spec: document the new v4l2_tuner capabilities

2012-05-27 Thread Hans de Goede
Small typo, see comment inline, with that fixed: Acked-by: Hans de Goede hdego...@redhat.com On 05/27/2012 01:50 PM, Hans Verkuil wrote: From: Hans Verkuilhans.verk...@cisco.com Update the spec with the new capabilities and specify new error codes for S_HW_FREQ_SEEK. Signed-off-by: Hans

Re: [RFCv1 PATCH 3/5] S_HW_FREQ_SEEK: set capability flags and return ENODATA instead of EAGAIN.

2012-05-27 Thread Hans de Goede
Looks good: Acked-by: Hans de Goede hdego...@redhat.com On 05/27/2012 01:50 PM, Hans Verkuil wrote: From: Hans Verkuilhans.verk...@cisco.com Set the new capability flags in G_TUNER and return ENODATA if no channels were found. Signed-off-by: Hans Verkuilhans.verk...@cisco.com --- drivers

Re: [RFCv1 PATCH 4/5] videodev2.h: add frequency band information.

2012-05-27 Thread Hans de Goede
Looks good: Acked-by: Hans de Goede hdego...@redhat.com On 05/27/2012 01:50 PM, Hans Verkuil wrote: From: Hans Verkuilhans.verk...@cisco.com Signed-off-by: Hans Verkuilhans.verk...@cisco.com --- include/linux/videodev2.h | 19 +-- 1 file changed, 17 insertions(+), 2

Re: [RFCv1 PATCH 5/5] V4L2 spec: add frequency band documentation.

2012-05-27 Thread Hans de Goede
Hi, Comments inline. On 05/27/2012 01:50 PM, Hans Verkuil wrote: From: Hans Verkuilhans.verk...@cisco.com Based in part on an earlier patch fromhallima...@gmail.com. Signed-off-by: Hans Verkuilhans.verk...@cisco.com --- Documentation/DocBook/media/v4l/common.xml | 28 --

<    1   2   3   4   5   6   7   8   9   10   >