[patch 2.6.27-rc7-omap-git 2/2] twl4030 uses gpiolib

2008-09-25 Thread David Brownell
From: David Brownell <[EMAIL PROTECTED]> Make the twl4030 core create a platform device to which its GPIO code will bind, with platform_data used to configure board-specific behaviors and configuration. Update the twl4030 GPIO code: - Morph its gpio function code into a platform driver. - M

[patch 2.6.27-rc7-omap-git 0/2] twl4030 uses gpiolib

2008-09-25 Thread David Brownell
Two patches follow ... they go on top of (a) the four from Felipe, which he's updating to move the twl_has_XYZ() macros into the core; (b) the pullup tweak from Jagadeesh: - Define and initialize platform data - Be a platform_driver which uses that and gpiolib There's more work to be done, but

[patch 2.6.27-rc7-omap-git 1/2] twl4030 gpio platform data

2008-09-25 Thread David Brownell
From: David Brownell <[EMAIL PROTECTED]> Define platform data for configuring TWL4030 GPIOs, and provide it for all boards using these chips. For now all boards use the same fixed assignments for GPIO and IRQ numbers. Eventually we should be able to shuffle them without changing platform headers

Re: [PATCH 1/4] i2c: clean add_children a bit

2008-09-25 Thread Felipe Balbi
Hi Dave, On Thu, 25 Sep 2008 10:28:00 -0700, David Brownell <[EMAIL PROTECTED]> wrote: > On Thursday 25 September 2008, Felipe Balbi wrote: >> Clean up add_children a bit before adding more children >> to twl4030-core.c >> >> Signed-off-by: Felipe Balbi <[EMAIL PROTECTED]> > > ACK, except for: >

Re: NULL pointer dereference when using ALSA SOC

2008-09-25 Thread Koen Kooi
Op 25 sep 2008, om 19:34 heeft Steve Sakoman het volgende geschreven: On Thu, Sep 25, 2008 at 10:22 AM, David Brownell [EMAIL PROTECTED]> wrote: On Thursday 25 September 2008, Arun KS wrote: I narrowed this into CONFIG_SLUB. When it's set, I can reproduce the bug both with N810 and Beagle bu

Re: [PATCH] Debobs and ETK padconf implementation

2008-09-25 Thread David Brownell
On Thursday 25 September 2008, Kevin Hilman wrote: > But I'm still not sure how to best deal with the possibiltity that the > pin might not always be a GPIO, but might be reconfigured/re-mux'd by > this debobs interface as a debug observability pin. Some platforms have interfaces to reserve and

Re: [PATCH] Debobs and ETK padconf implementation

2008-09-25 Thread Kevin Hilman
David Brownell wrote: On Thursday 25 September 2008, Kevin Hilman wrote: In that case, what is the proposed method for other kernel code to use the debobs lines? Hmm, good point :) My idea was to use the gpiolib calls on GPIO12 - GPIO29, but then there is no way for a user to know if the GPIO w

Re: NULL pointer dereference when using ALSA SOC

2008-09-25 Thread Siarhei Siamashka
On Tuesday 23 September 2008, Arun KS wrote: > Hi all, > > I am writing an ASOC driver for tlvaic23 on osk5912 platform. [...] Hi. Coincidentally I have been hacking the old aic23 driver in the last few days to make it work on Nokia 770. Don't know if these fixes have any value for linux-omap tree

Re: [PATCH] twl4030-gpio: Remove default pullup enable/disable of GPIO

2008-09-25 Thread Girish. S. G.
> On Thursday 25 September 2008, Pakaravoor, Jagadeesh wrote: >> From: Jagadeesh Bhaskar Pakaravoor <[EMAIL PROTECTED]> >> >> One twl4030_request_gpio() should not tamper with the pullup >> enabling/disabling of the rest of the GPIOs. So removing the default >> pullup values written to REG_GPIOPUPD

Re: [patch 2.6.27-rc6-omap] ASOC: quieter boot for non-Overo boards

2008-09-25 Thread David Brownell
On Thursday 25 September 2008, Steve Sakoman wrote: > On Thu, 2008-09-25 at 09:50 -0700, David Brownell wrote: > > On Thursday 25 September 2008, Tony Lindgren wrote: > > > > Get rid of bogus ASOC boot messages on non-Overo boards. > > > > > > I'm not touching this without an ack from alsa list :)

Re: NULL pointer dereference when using ALSA SOC

2008-09-25 Thread Steve Sakoman
On Thu, Sep 25, 2008 at 10:22 AM, David Brownell <[EMAIL PROTECTED]> wrote: > On Thursday 25 September 2008, Arun KS wrote: >> >>> I narrowed this into CONFIG_SLUB. When it's set, I can reproduce the >> >>> bug both with N810 and Beagle but not when using CONFIG_SLAB. > > So it's confirmed that SLU

Re: [PATCH 1/4] i2c: clean add_children a bit

2008-09-25 Thread David Brownell
On Thursday 25 September 2008, Felipe Balbi wrote: > Clean up add_children a bit before adding more children > to twl4030-core.c > > Signed-off-by: Felipe Balbi <[EMAIL PROTECTED]> ACK, except for: > --- a/include/linux/i2c/twl4030.h > +++ b/include/linux/i2c/twl4030.h > @@ -145,4 +145,10 @@ int

Re: NULL pointer dereference when using ALSA SOC

2008-09-25 Thread David Brownell
On Thursday 25 September 2008, Arun KS wrote: > >>> I narrowed this into CONFIG_SLUB. When it's set, I can reproduce the > >>> bug both with N810 and Beagle but not when using CONFIG_SLAB. So it's confirmed that SLUB is a factor, but the root cause is still not known or resolved? -- To unsubscri

Re: [PATCH] twl4030-gpio: Remove default pullup enable/disable of GPIO

2008-09-25 Thread David Brownell
On Thursday 25 September 2008, Pakaravoor, Jagadeesh wrote: > From: Jagadeesh Bhaskar Pakaravoor <[EMAIL PROTECTED]> > > One twl4030_request_gpio() should not tamper with the pullup > enabling/disabling of the rest of the GPIOs. So removing the default > pullup values written to REG_GPIOPUPDCTR1.

Re: [patch 2.6.27-rc6-omap] ASOC: quieter boot for non-Overo boards

2008-09-25 Thread Steve Sakoman
On Thu, 2008-09-25 at 09:50 -0700, David Brownell wrote: > On Thursday 25 September 2008, Tony Lindgren wrote: > > > Get rid of bogus ASOC boot messages on non-Overo boards. > > > > I'm not touching this without an ack from alsa list :) > > Has this driver even gone to that list yet? ;) Yes, th

Re: [PATCH] Debobs and ETK padconf implementation

2008-09-25 Thread David Brownell
On Thursday 25 September 2008, Kevin Hilman wrote: > > >> In that case, what is the proposed method for other kernel code to use > >> the debobs lines? > > > > Hmm, good point :) My idea was to use the gpiolib calls on GPIO12 - > > GPIO29, but then there is no way for a user to know if the GPIO wa

Re: [patch] some drivers switch away from OMAP-specific GPIO calls

2008-09-25 Thread David Brownell
On Thursday 25 September 2008, Tony Lindgren wrote: > > > > This updates most of the OMAP drivers which are in mainline to > > switch to using the cross-platform GPIO calls instead of the > > older OMAP-specific ones. > > > > This is all fairly brainless/obvious stuff.  Probably the > > most inte

Re: [patch 2.6.27-rc6-omap] ASOC: quieter boot for non-Overo boards

2008-09-25 Thread David Brownell
On Thursday 25 September 2008, Tony Lindgren wrote: > > Get rid of bogus ASOC boot messages on non-Overo boards. > > I'm not touching this without an ack from alsa list :) Has this driver even gone to that list yet? ;) I haven't really looked at initialization for this yet, but my initial reac

Re: [PATCH 0/4] twl4030 driver changes

2008-09-25 Thread Felipe Balbi
On Thu, 25 Sep 2008 09:26:12 -0700, David Brownell <[EMAIL PROTECTED]> wrote: > On Thursday 25 September 2008, Felipe Balbi wrote: >> Move twl4030 keypad and usb to new style of >> registration for twl4030 driver > > I can tell I'm going to need to accelerate my > GPIO updates! :) > > Cool. I

Re: [PATCH 0/4] twl4030 driver changes

2008-09-25 Thread David Brownell
On Thursday 25 September 2008, Felipe Balbi wrote: > Move twl4030 keypad and usb to new style of > registration for twl4030 driver I can tell I'm going to need to accelerate my GPIO updates! :) Cool. I'll look at this after breakfast... -- To unsubscribe from this list: send the line "unsubsc

Re: MMC broken on beagleboard with current git

2008-09-25 Thread Steve Sakoman
On Thu, Sep 25, 2008 at 3:39 AM, Tony Lindgren <[EMAIL PROTECTED]> wrote: > Hmm, I don't understand how it could work on 3430sdp... > > Looks like board-omap3beagle.c calls hsmmc_init() just like > board-3430sdp.c. Maybe timings have changed and you need > a longer delay somewhere during the init?

[PATCH 1/4] i2c: clean add_children a bit

2008-09-25 Thread Felipe Balbi
Clean up add_children a bit before adding more children to twl4030-core.c Signed-off-by: Felipe Balbi <[EMAIL PROTECTED]> --- drivers/i2c/chips/twl4030-core.c | 58 - include/linux/i2c/twl4030.h |6 2 files changed, 37 insertions(+), 27 deletion

[PATCH 3/4] i2c: move twl4030-usb to platform_device

2008-09-25 Thread Felipe Balbi
use new style twl4030-core to register a platform_device for twl4030-usb. Signed-off-by: Felipe Balbi <[EMAIL PROTECTED]> --- arch/arm/mach-omap2/board-2430sdp.c |6 + arch/arm/mach-omap2/board-3430sdp.c |5 + arch/arm/mach-omap2/board-omap2evm.c |5 + arch/arm/mach-omap2/board-omap

[PATCH 4/4] i2c: twl4030-usb: add 'vbus' sysfs file

2008-09-25 Thread Felipe Balbi
vbus sysfs file will report the state of vbus irq coming from twl4030-usb. Signed-off-by: Felipe Balbi <[EMAIL PROTECTED]> --- drivers/i2c/chips/twl4030-usb.c | 51 ++- 1 files changed, 50 insertions(+), 1 deletions(-) diff --git a/drivers/i2c/chips/twl4030-

[PATCH 2/4] i2c: move twl4030_keypad to new style registration

2008-09-25 Thread Felipe Balbi
let twl4030-core.c take care of twl4030_keypad registration. Signed-off-by: Felipe Balbi <[EMAIL PROTECTED]> --- arch/arm/mach-omap2/board-2430sdp.c | 14 -- arch/arm/mach-omap2/board-3430sdp.c | 14 -- arch/arm/mach-omap2/board-omap2evm.c| 16

[PATCH 0/4] twl4030 driver changes

2008-09-25 Thread Felipe Balbi
Move twl4030 keypad and usb to new style of registration for twl4030 driver introduced by David Brownell. This is how the device tree looks now: $ find /sys | grep twl4030 /sys/class/i2c-adapter/i2c-1/1-0048/twl4030_usb /sys/class/i2c-adapter/i2c-1/1-0048/twl4030_usb/uevent /sys/class/i2c-adapter

[PATCH] OMAP3 clock: put DPLL into bypass if bypass rate = clk->rate, not hardware rate

2008-09-25 Thread Paul Walmsley
When a non-CORE DPLL is enabled via omap3_noncore_dpll_enable(), use the user's desired rate in clk->rate to determine whether to put the DPLL into bypass or lock mode, rather than reading the DPLL's current idle state from its hardware registers. This fixes a bug observed when leaving retention.

Re: [PATCH] input: keypad: fix null pointer dereference

2008-09-25 Thread Felipe Balbi
From: Felipe Balbi <[EMAIL PROTECTED]> There was a potential NULL pointer dereference if we don't pass some fields of omap_kp_platform_data. At the point of the error message, kp->dbg_dev is not set so it would generate a NULL pointer dereference right away. Fix it by using &pdev->dev Signed-of

[PATCH] omap: get rid of OMAP_TAG_USB

2008-09-25 Thread Felipe Balbi
OMAP_TAGS should vanish soon since they're not generic arm tags. Most of them can be converted to a platform_data or parsed from a command line line the serial tag. For OMAP_TAG_USB we just let boards call omap_usb_init() passing a pointer to omap_usb_config. Signed-off-by: Felipe Balbi <[EMAIL P

[PATCH 0/1] omap tag removal

2008-09-25 Thread Felipe Balbi
Hi all, The following patch was *compile tested* only with h4 defconfig. If anyone has the boards to try it on, please do. regards, Felipe Balbi -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://

[PATCH] OMAP3 clock: fix dss1_alwon_fck

2008-09-25 Thread Paul Walmsley
Commit a63efb1547ac35dcb0f007090396a3c7510eb691 broke the dss1_alwon_fck clock enable on 3430ES2+. The clock code was not waiting for the module to come out of idle. Problem reported by Rajendra Nayak <[EMAIL PROTECTED]>. Signed-off-by: Paul Walmsley <[EMAIL PROTECTED]> --- arch/arm/mach-omap2

[PATCH] input: keypad: fix null pointer dereference

2008-09-25 Thread Felipe Balbi
There was a potential NULL pointer dereference if we don't pass some fields of omap_kp_platform_data. At the point of the error message, kp->dbg_dev is not set so it would generate a NULL pointer dereference right away. Fix it by using &pdev->dev Signed-of-by: Felipe Balbi <[EMAIL PROTECTED]> --

Re: NULL pointer dereference when using ALSA SOC

2008-09-25 Thread Arun KS
On Thu, Sep 25, 2008 at 7:02 PM, Koen Kooi <[EMAIL PROTECTED]> wrote: > > Op 25 sep 2008, om 15:27 heeft Philip Balister het volgende geschreven: > >> Jarkko Nikula wrote: >>> >>> On Tue, 23 Sep 2008 11:50:53 +0300 >>> "ext Jarkko Nikula" <[EMAIL PROTECTED]> wrote: On Tue, 23 Sep 2008 11:

Re: NULL pointer dereference when using ALSA SOC

2008-09-25 Thread Koen Kooi
Op 25 sep 2008, om 15:27 heeft Philip Balister het volgende geschreven: Jarkko Nikula wrote: On Tue, 23 Sep 2008 11:50:53 +0300 "ext Jarkko Nikula" <[EMAIL PROTECTED]> wrote: On Tue, 23 Sep 2008 11:56:00 +0530 "ext Arun KS" <[EMAIL PROTECTED]> wrote: Hi all, I am writing an ASOC driver for

Re: NULL pointer dereference when using ALSA SOC

2008-09-25 Thread Philip Balister
Jarkko Nikula wrote: On Tue, 23 Sep 2008 11:50:53 +0300 "ext Jarkko Nikula" <[EMAIL PROTECTED]> wrote: On Tue, 23 Sep 2008 11:56:00 +0530 "ext Arun KS" <[EMAIL PROTECTED]> wrote: Hi all, I am writing an ASOC driver for tlvaic23 on osk5912 platform. When do an aplay, I m getting a NULL point

[PATCH] twl4030-gpio: Remove default pullup enable/disable of GPIO

2008-09-25 Thread Pakaravoor, Jagadeesh
From: Jagadeesh Bhaskar Pakaravoor <[EMAIL PROTECTED]> One twl4030_request_gpio() should not tamper with the pullup enabling/disabling of the rest of the GPIOs. So removing the default pullup values written to REG_GPIOPUPDCTR1. Signed-off-by: Girish S G <[EMAIL PROTECTED]> Signed-off-by: Jagadees

Re: [patch linux-omap-git] twl4030-core: cleanups

2008-09-25 Thread Tony Lindgren
* David Brownell <[EMAIL PROTECTED]> [080925 10:34]: > From: David Brownell <[EMAIL PROTECTED]> > > A bunch of little cleanups to twl4030-core. > > - Remove needless header inclusions, symbols, and >forward declarations. > > - Make coding style more standard. > > And shrink the object siz

Re: [patch] some drivers switch away from OMAP-specific GPIO calls

2008-09-25 Thread Tony Lindgren
* David Brownell <[EMAIL PROTECTED]> [080925 05:36]: > From: David Brownell <[EMAIL PROTECTED]> > > This updates most of the OMAP drivers which are in mainline to > switch to using the cross-platform GPIO calls instead of the > older OMAP-specific ones. > > This is all fairly brainless/obvious st

Re: [patch 2.6.27-rc6-omap] hsmmc: request_irq says which controller is involved

2008-09-25 Thread Tony Lindgren
* David Brownell <[EMAIL PROTECTED]> [080922 00:50]: > Make the hsmmc driver irq requests say which controller they're > associated with (e.g. "mmc0") so /proc/interrupts is more useful. Pushing today. Tony > > Signed-off-by: David Brownell <[EMAIL PROTECTED]> > > --- a/drivers/mmc/host/omap_h

Re: [patch 2.6.27-rc6-omap] ASOC: quieter boot for non-Overo boards

2008-09-25 Thread Tony Lindgren
* David Brownell <[EMAIL PROTECTED]> [080922 00:50]: > Get rid of bogus ASOC boot messages on non-Overo boards. I'm not touching this without an ack from alsa list :) Tony > > Signed-off-by: David Brownell <[EMAIL PROTECTED]> > --- > sound/soc/omap/overo.c |7 +++ > 1 file changed, 3 i

Re: [PATCH] Debobs and ETK padconf implementation

2008-09-25 Thread Kevin Hilman
"Peter 'p2' De Schrijver" <[EMAIL PROTECTED]> writes: > On Thu, Sep 25, 2008 at 02:40:19PM +0300, ext Kevin Hilman wrote: >> "Peter 'p2' De Schrijver" <[EMAIL PROTECTED]> writes: >> >> >> >> >> The cross-platform gpiolib calls should be used here. >> >> >> >> > + snprintf(

Re: [PATCH] Fixed OMAP3 version check

2008-09-25 Thread Tony Lindgren
* [EMAIL PROTECTED] <[EMAIL PROTECTED]> [080925 15:10]: > Hi, > > Here is a fix that works on top of your patch. Tested with ES2.1 and > ES3.0 chips. I left out the caching for CPU type. Thanks, I'll merge your fix into my patch and push it to l-o. Will also create a series for patches for upstre

RE: [PATCH] Fixed OMAP3 version check

2008-09-25 Thread Tero.Kristo
>-Original Message- >From: ext Tony Lindgren [mailto:[EMAIL PROTECTED] >Sent: 25 September, 2008 14:50 >To: Kristo Tero (Nokia-D/Tampere) >Cc: Balbi Felipe (Nokia-D/Helsinki); linux-omap@vger.kernel.org >Subject: Re: [PATCH] Fixed OMAP3 version check > >* Tony Lindgren <[EMAIL PROTECTED

RE: [PATCH] Fixed OMAP3 version check

2008-09-25 Thread Tero.Kristo
Hi, Here is a fix that works on top of your patch. Tested with ES2.1 and ES3.0 chips. I left out the caching for CPU type. -Tero >-Original Message- >From: ext Tony Lindgren [mailto:[EMAIL PROTECTED] >Sent: 25 September, 2008 13:18 >To: Kristo Tero (Nokia-D/Tampere) >Cc: linux-omap@vge

Re: [PATCH] Debobs and ETK padconf implementation

2008-09-25 Thread Peter 'p2' De Schrijver
> > In that case, what is the proposed method for other kernel code to use > > the debobs lines? > > Hmm, good point :) My idea was to use the gpiolib calls on GPIO12 - > GPIO29, but then there is no way for a user to know if the GPIO was > assigned to debobs or not... Maybe debobs should register

Re: [PATCH] Debobs and ETK padconf implementation

2008-09-25 Thread Peter 'p2' De Schrijver
On Thu, Sep 25, 2008 at 02:40:19PM +0300, ext Kevin Hilman wrote: > "Peter 'p2' De Schrijver" <[EMAIL PROTECTED]> writes: > > >> > >> The cross-platform gpiolib calls should be used here. > >> > >> > +snprintf(name, sizeof(name), "hw_dbg%d", i); > >> > +

Re: [PATCH] Fixed OMAP3 version check

2008-09-25 Thread Tony Lindgren
* Tony Lindgren <[EMAIL PROTECTED]> [080925 14:47]: > * [EMAIL PROTECTED] <[EMAIL PROTECTED]> [080925 14:45]: > > > > > > >-Original Message- > > >From: Balbi Felipe (Nokia-D/Helsinki) > > >Sent: 25 September, 2008 14:41 > > >To: ext Tony Lindgren > > >Cc: Balbi Felipe (Nokia-D/Helsinki

Re: [PATCH] Fixed OMAP3 version check

2008-09-25 Thread Tony Lindgren
* [EMAIL PROTECTED] <[EMAIL PROTECTED]> [080925 14:45]: > > > >-Original Message- > >From: Balbi Felipe (Nokia-D/Helsinki) > >Sent: 25 September, 2008 14:41 > >To: ext Tony Lindgren > >Cc: Balbi Felipe (Nokia-D/Helsinki); Kristo Tero > >(Nokia-D/Tampere); linux-omap@vger.kernel.org > >

RE: [PATCH] Fixed OMAP3 version check

2008-09-25 Thread Tero.Kristo
>-Original Message- >From: Balbi Felipe (Nokia-D/Helsinki) >Sent: 25 September, 2008 14:41 >To: ext Tony Lindgren >Cc: Balbi Felipe (Nokia-D/Helsinki); Kristo Tero >(Nokia-D/Tampere); linux-omap@vger.kernel.org >Subject: Re: [PATCH] Fixed OMAP3 version check > >On Thu, Sep 25, 2008 at

Re: [PATCH 1/10] HDQ driver: Remove global pointer

2008-09-25 Thread Evgeniy Polyakov
Hi. On Thu, Sep 25, 2008 at 12:19:44PM +0530, Gadiyar, Anand ([EMAIL PROTECTED]) wrote: > From: Madhusudhan Chikkature <[EMAIL PROTECTED]> > > This patch provides the necessary modifications to the driver to > remove the global ptr hdq_data. > > Signed-off-by: Madhusudhan Chikkature <[EMAIL PRO

Re: [PATCH] Fixed OMAP3 version check

2008-09-25 Thread Felipe Balbi
On Thu, Sep 25, 2008 at 01:31:21PM +0300, Tony Lindgren wrote: > * Felipe Balbi <[EMAIL PROTECTED]> [080925 13:24]: > > On Thu, Sep 25, 2008 at 01:17:51PM +0300, Tony Lindgren wrote: > > > Hi, > > > > > > * Tero Kristo <[EMAIL PROTECTED]> [080916 14:59]: > > > > CPU version was reported incorrectl

Re: [PATCH] Debobs and ETK padconf implementation

2008-09-25 Thread Kevin Hilman
"Peter 'p2' De Schrijver" <[EMAIL PROTECTED]> writes: >> >> The cross-platform gpiolib calls should be used here. >> >> > + snprintf(name, sizeof(name), "hw_dbg%d", i); >> > + err = _new_debobs_pad(&debobs_pads[i], name, i, >> > +

Re: [PATCH 8/8] i2c-omap: Clean-up i2c-omap, v3

2008-09-25 Thread Tony Lindgren
* Tony Lindgren <[EMAIL PROTECTED]> [080925 10:55]: > Minor checkpatch and formatting clean-up. Also update copyrights. Here's this one updated with correct email addresses for Juha and Nishant. Tony >From 738680e6b79e87132b6cdb15a0b9727b381b87ac Mon Sep 17 00:00:00 2001 From: Tony Lindgren <[EMA

Re: [PATCH 4/8] i2c-omap: FIFO handling support and broken hw workaround for i2c-omap, v3

2008-09-25 Thread Tony Lindgren
* Tony Lindgren <[EMAIL PROTECTED]> [080925 10:54]: > From: Nishanth Menon <[EMAIL PROTECTED]> > > Based on an earlier patch from Nishant Menon: > > - Transfers can use FIFO on FIFO capable devices > - Prevents errors for HSI2C if FIFO is not used > - Implemented errenous handling of STT-STP hand

Re: [PATCH] Debobs and ETK padconf implementation

2008-09-25 Thread Peter 'p2' De Schrijver
> > The cross-platform gpiolib calls should be used here. > > > + snprintf(name, sizeof(name), "hw_dbg%d", i); > > + err = _new_debobs_pad(&debobs_pads[i], name, i, > > + debobs_root); > > + if (err) {

Re: NULL pointer dereference when using ALSA SOC

2008-09-25 Thread Jarkko Nikula
On Tue, 23 Sep 2008 11:50:53 +0300 "ext Jarkko Nikula" <[EMAIL PROTECTED]> wrote: > On Tue, 23 Sep 2008 11:56:00 +0530 > "ext Arun KS" <[EMAIL PROTECTED]> wrote: > > > Hi all, > > > > I am writing an ASOC driver for tlvaic23 on osk5912 platform. > > When do an aplay, I m getting a NULL pointer

Re: [PATCH] PM: Fixed clockdomain state control for OMAP3

2008-09-25 Thread Tony Lindgren
* Paul Walmsley <[EMAIL PROTECTED]> [080923 16:22]: > On Tue, 16 Sep 2008, Tero Kristo wrote: > > > Hardware supervised control for clockdomain power state transitions now > > enabled in omap3_pm_init(). Also fixed set_pwrdm_state() to allow state > > changes between sleep states (i.e. RET<->OFF.)

Re: MMC broken on beagleboard with current git

2008-09-25 Thread Tony Lindgren
* Koen Kooi <[EMAIL PROTECTED]> [080925 13:25]: > > Op 25 sep 2008, om 11:47 heeft Tony Lindgren het volgende geschreven: > >> * Koen Kooi <[EMAIL PROTECTED]> [080925 12:23]: >>> >>> Op 25 sep 2008, om 10:51 heeft Tony Lindgren het volgende geschreven: >>> * Koen Kooi <[EMAIL PROTECTED]> [0809

Re: [PATCH] Fixed OMAP3 version check

2008-09-25 Thread Tony Lindgren
* Felipe Balbi <[EMAIL PROTECTED]> [080925 13:24]: > On Thu, Sep 25, 2008 at 01:17:51PM +0300, Tony Lindgren wrote: > > Hi, > > > > * Tero Kristo <[EMAIL PROTECTED]> [080916 14:59]: > > > CPU version was reported incorrectly (e.g. ES3.0 instead of ES2.1.) > > > Also added a piece of optimization f

Re: [PATCH 8/10] HDQ driver:protect the shared flag

2008-09-25 Thread Felipe Balbi
On Thu, Sep 25, 2008 at 12:28:22PM +0530, ext Gadiyar, Anand wrote: > From: Madhusudhan Chikkature <[EMAIL PROTECTED]> > > This patch moves the shared variable into the local structure and > protects its updation. > > Signed-off-by: Madhusudhan Chikkature <[EMAIL PROTECTED]> Acked-by: Felipe Balb

Re: [PATCH] OMAP3: GPIO: Enable debounce clock only when debounce is enabled v3.

2008-09-25 Thread Tony Lindgren
* Paul Walmsley <[EMAIL PROTECTED]> [080916 16:02]: > On Tue, 16 Sep 2008, Jouni Hogander wrote: > > > This patch changes gpio "driver" to enable debounce clock for > > gpio-bank only when debounce is enabled for some gpio in that bank. > > > > Gpio functional clocks are also renamed in clock tre

Re: MMC broken on beagleboard with current git

2008-09-25 Thread Koen Kooi
Op 25 sep 2008, om 11:47 heeft Tony Lindgren het volgende geschreven: * Koen Kooi <[EMAIL PROTECTED]> [080925 12:23]: Op 25 sep 2008, om 10:51 heeft Tony Lindgren het volgende geschreven: * Koen Kooi <[EMAIL PROTECTED]> [080925 11:42]: Hi, I just built a kernel from current git[1] and the

Re: [PATCH] Fixed OMAP3 version check

2008-09-25 Thread Felipe Balbi
On Thu, Sep 25, 2008 at 01:17:51PM +0300, Tony Lindgren wrote: > Hi, > > * Tero Kristo <[EMAIL PROTECTED]> [080916 14:59]: > > CPU version was reported incorrectly (e.g. ES3.0 instead of ES2.1.) > > Also added a piece of optimization for CPU type check (omap_type()). > > > > Signed-off-by: Tero K

Re: [PATCH] Fixed OMAP3 version check

2008-09-25 Thread Tony Lindgren
Hi, * Tero Kristo <[EMAIL PROTECTED]> [080916 14:59]: > CPU version was reported incorrectly (e.g. ES3.0 instead of ES2.1.) > Also added a piece of optimization for CPU type check (omap_type()). > > Signed-off-by: Tero Kristo <[EMAIL PROTECTED]> > --- > arch/arm/mach-omap2/id.c |7 +-- >

Re: [PATCH 2/10] HDQ driver: replace pr_debug with dev_dbg

2008-09-25 Thread Felipe Balbi
On Thu, Sep 25, 2008 at 12:22:04PM +0530, ext Gadiyar, Anand wrote: > From: Madhusudhan Chikkature <[EMAIL PROTECTED]> > > Replace pr_debug with dev_dbg with device information added for > debug prints. > > Signed-off-by: Madhusudhan Chikkature <[EMAIL PROTECTED]> Acked-by: Felipe Balbi <[EMAIL

Re: [PATCH 7/10] HDQ driver:replace semaphore with mutex

2008-09-25 Thread Felipe Balbi
On Thu, Sep 25, 2008 at 12:27:23PM +0530, ext Gadiyar, Anand wrote: > From: Madhusudhan Chikkature <[EMAIL PROTECTED]> > > This patch replaces the usage of semaphore by mutex. > > Signed-off-by: Madhusudhan Chikkature <[EMAIL PROTECTED]> Acked-by: Felipe Balbi <[EMAIL PROTECTED]> > --- > drivers

Re: [PATCH 6/10] HDQ driver: use ioremap for HDQ base

2008-09-25 Thread Felipe Balbi
On Thu, Sep 25, 2008 at 12:26:17PM +0530, ext Gadiyar, Anand wrote: > From: Madhusudhan Chikkature <[EMAIL PROTECTED]> > > This patch provides the ioremap related changes to the driver. > > Signed-off-by: Madhusudhan Chikkature <[EMAIL PROTECTED]> Acked-by: Felipe Balbi <[EMAIL PROTECTED]> > ---

Re: [PATCH 3/10] HDQ driver: modify probe fn exit points

2008-09-25 Thread Felipe Balbi
On Thu, Sep 25, 2008 at 12:23:22PM +0530, ext Gadiyar, Anand wrote: > From: Madhusudhan Chikkature <[EMAIL PROTECTED]> > > This patch fix the exit paths in the probe function. > > Signed-off-by: Madhusudhan Chikkature <[EMAIL PROTECTED]> Acked-by: Felipe Balbi <[EMAIL PROTECTED]> > --- > drivers

Re: [PATCH 4/10] HDQ driver: remove unlikely calls

2008-09-25 Thread Felipe Balbi
On Thu, Sep 25, 2008 at 12:24:18PM +0530, ext Gadiyar, Anand wrote: > From: Madhusudhan Chikkature <[EMAIL PROTECTED]> > > Remove the unneeded "unlikely" calls. > > Signed-off-by: Madhusudhan Chikkature <[EMAIL PROTECTED]> Acked-by: Felipe Balbi <[EMAIL PROTECTED]> > --- > drivers/w1/masters/oma

Re: [PATCH 10/10] HDQ driver: Make hdq_reg_out as void

2008-09-25 Thread Felipe Balbi
On Thu, Sep 25, 2008 at 12:31:38PM +0530, ext Gadiyar, Anand wrote: > From: Madhusudhan Chikkature <[EMAIL PROTECTED]> > > Make hdq_reg_out as void and remove suspend, resume from the driver structure. > > Signed-off-by: Madhusudhan Chikkature <[EMAIL PROTECTED]> Acked-by: Felipe Balbi <[EMAIL PR

Re: [PATCH 9/10] HDQ driver: Fix indentation and commenting style

2008-09-25 Thread Felipe Balbi
On Thu, Sep 25, 2008 at 12:30:48PM +0530, ext Gadiyar, Anand wrote: > From: Madhusudhan Chikkature <[EMAIL PROTECTED]> > > This patch fixes the indentation, commenting style of a single line comment. > > Signed-off-by: Madhusudhan Chikkature <[EMAIL PROTECTED]> Acked-by: Felipe Balbi <[EMAIL PROT

Re: [PATCH 5/10] HDQ driver: Convert few declarations to static

2008-09-25 Thread Felipe Balbi
On Thu, Sep 25, 2008 at 12:25:11PM +0530, ext Gadiyar, Anand wrote: > From: Madhusudhan Chikkature <[EMAIL PROTECTED]> > > Convert declaration to static. > > Signed-off-by: Madhusudhan Chikkature <[EMAIL PROTECTED]> Acked-by: Felipe Balbi <[EMAIL PROTECTED]> > --- > drivers/w1/masters/omap_hdq.c

Re: [PATCH 1/10] HDQ driver: Remove global pointer

2008-09-25 Thread Felipe Balbi
On Thu, Sep 25, 2008 at 12:19:44PM +0530, ext Gadiyar, Anand wrote: > From: Madhusudhan Chikkature <[EMAIL PROTECTED]> > > This patch provides the necessary modifications to the driver to > remove the global ptr hdq_data. > > Signed-off-by: Madhusudhan Chikkature <[EMAIL PROTECTED]> Acked-by: Fe

[PATCH] ARM: OMAP3: DMA: Fix for sDMA Errata 1.113

2008-09-25 Thread Shilimkar, Santosh
From: Santosh Shilimkar <[EMAIL PROTECTED]> SDMA channel is not disabled after transaction error. So explicitly disable it. Signed-off-by: Santosh Shilimkar <[EMAIL PROTECTED]> Acked By : Nishant kamat <[EMAIL PROTECTED]> --- Index: linux-omap-2.6/arch/arm/plat-omap/dma.c

Re: MMC broken on beagleboard with current git

2008-09-25 Thread Tony Lindgren
* Koen Kooi <[EMAIL PROTECTED]> [080925 12:23]: > > Op 25 sep 2008, om 10:51 heeft Tony Lindgren het volgende geschreven: > >> * Koen Kooi <[EMAIL PROTECTED]> [080925 11:42]: >>> Hi, >>> >>> I just built a kernel from current git[1] and the mmc controller >>> doesn't >>> get detected on boot on m

Re: MMC broken on beagleboard with current git

2008-09-25 Thread Koen Kooi
Op 25 sep 2008, om 10:51 heeft Tony Lindgren het volgende geschreven: * Koen Kooi <[EMAIL PROTECTED]> [080925 11:42]: Hi, I just built a kernel from current git[1] and the mmc controller doesn't get detected on boot on my beagleboards. The omap mmc system has seen a lot of changes lately

Re: [PATCH] Add debobs Kconfig item

2008-09-25 Thread Kevin Hilman
"Peter 'p2' De Schrijver" <[EMAIL PROTECTED]> writes: > Signed-off-by: Peter 'p2' De Schrijver <[EMAIL PROTECTED]> > --- > arch/arm/mach-omap2/Kconfig | 10 +- > arch/arm/mach-omap2/Makefile |3 +++ > 2 files changed, 12 insertions(+), 1 deletions(-) > > diff --git a/arch/arm/mach-

Re: [PATCH] Debobs and ETK padconf implementation

2008-09-25 Thread Kevin Hilman
"Peter 'p2' De Schrijver" <[EMAIL PROTECTED]> writes: > Signed-off-by: Peter 'p2' De Schrijver <[EMAIL PROTECTED]> > --- > arch/arm/mach-omap2/debobs.c | 214 > ++ > 1 files changed, 214 insertions(+), 0 deletions(-) > create mode 100644 arch/arm/mach-om

Re: MMC broken on beagleboard with current git

2008-09-25 Thread Tony Lindgren
* Koen Kooi <[EMAIL PROTECTED]> [080925 11:42]: > Hi, > > I just built a kernel from current git[1] and the mmc controller doesn't > get detected on boot on my beagleboards. The omap mmc system has seen a > lot of changes lately, does anyone have a hint where to start looking > before attemping

MMC broken on beagleboard with current git

2008-09-25 Thread Koen Kooi
Hi, I just built a kernel from current git[1] and the mmc controller doesn't get detected on boot on my beagleboards. The omap mmc system has seen a lot of changes lately, does anyone have a hint where to start looking before attemping a bisect? regards, Koen [1] http://source.mvist

[PATCH 7/8] i2c-omap: Don't compile in OMAP15xx I2C ISR for non-OMAP15xx builds

2008-09-25 Thread Tony Lindgren
From: Paul Walmsley <[EMAIL PROTECTED]> Skip compiling OMAP15xx I2C ISR for non-OMAP15xx builds. Saves 400 bytes of text for most OMAP builds. Signed-off-by: Paul Walmsley <[EMAIL PROTECTED]> Signed-off-by: Tony Lindgren <[EMAIL PROTECTED]> --- drivers/i2c/busses/i2c-omap.c | 10 -- 1

[PATCH 8/8] i2c-omap: Clean-up i2c-omap

2008-09-25 Thread Tony Lindgren
Minor checkpatch and formatting clean-up. Also update copyrights. Signed-off-by: Tony Lindgren <[EMAIL PROTECTED]> --- drivers/i2c/busses/i2c-omap.c | 28 1 files changed, 16 insertions(+), 12 deletions(-) diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/bu

[PATCH 6/8] i2c-omap: Mark init-only functions as __init

2008-09-25 Thread Tony Lindgren
From: Paul Walmsley <[EMAIL PROTECTED]> Mark functions called only at init time as __init. Signed-off-by: Paul Walmsley <[EMAIL PROTECTED]> Signed-off-by: Tony Lindgren <[EMAIL PROTECTED]> --- drivers/i2c/busses/i2c-omap.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 5/8] i2c-omap: Add support on 34xx

2008-09-25 Thread Tony Lindgren
From: Chandra shekhar <[EMAIL PROTECTED]> Signed-off-by: chandra shekhar <[EMAIL PROTECTED]> Signed-off-by: Tony Lindgren <[EMAIL PROTECTED]> --- drivers/i2c/busses/i2c-omap.c | 12 +++- 1 files changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/i2c/busses/i2c-omap.c b/drive

[PATCH 4/8] i2c-omap: FIFO handling support and broken hw workaround for i2c-omap

2008-09-25 Thread Tony Lindgren
From: Nishanth Menon <[EMAIL PROTECTED]> Based on an earlier patch from Nishant Menon: - Transfers can use FIFO on FIFO capable devices - Prevents errors for HSI2C if FIFO is not used - Implemented errenous handling of STT-STP handling on SDP2430 Also merged in is a fix from Jaron Marini to fix

[PATCH 3/8] i2c-omap: Add high-speed support to omap-i2c

2008-09-25 Thread Tony Lindgren
From: Syed Mohammed Khasim <[EMAIL PROTECTED]> Omap2430 has additional support for high-speed I2C. This patch moves I2C speed parameter (from module) to platform data. Also added basic High Speed support based on I2C bus speed. This patch is tested for high speed I2C (with TWL4030 Keypad) and wo

[PATCH 2/8] i2c-omap: Close suspected race between omap_i2c_idle() and omap_i2c_isr()

2008-09-25 Thread Tony Lindgren
From: Paul Walmsley <[EMAIL PROTECTED]> omap_i2c_idle() sets an internal flag, "dev->idle", instructing its ISR to decline interrupts. It sets this flag before it actually masks the interrupts on the I2C controller. This is problematic, since an I2C interrupt could arrive after dev->idle is set,

[PATCH 1/8] i2c-omap: Do not use interruptible wait call in omap_i2c_xfer_msg

2008-09-25 Thread Tony Lindgren
From: Jarkko Nikula <[EMAIL PROTECTED]> If there is a signal pending and wait_for_completion_interruptible_timeout terminates with -ERESTARTSYS, we return and disable the i2c clocks in omap_i2c_xfer. If we terminate before sending last i2c message with a stop condition, the bus remains busy and w

[PATCH 0/8] Updates for i2c-omap from linux-omap tree for review, v2

2008-09-25 Thread Tony Lindgren
Hi all, Here's a repost of the whole series, the first series had a compile error starting with one of the patches. Sorry for the extra noise. This series contains pending i2c-omap patches from linux-omap tree for review. Looks like we've managed to pile up stuff in the omap tree for this driver

Re: [PATCH 0/8] Updates for i2c-omap from linux-omap tree for review

2008-09-25 Thread Tony Lindgren
* Tony Lindgren <[EMAIL PROTECTED]> [080925 10:16]: > Hi all, > > This series contains pending i2c-omap patches from linux-omap tree > for review. > > Looks like we've managed to pile up stuff in the omap tree for this > driver again... Anyways, future patches will be coming straight via > the i2

RE: clk_disable_unused() is bugged

2008-09-25 Thread Paul Walmsley
Hi Rajendra, On Thu, 25 Sep 2008, Rajendra Nayak wrote: > I tried this patch on top of the pm-1 branch. On the 3430SDP I see idle being > able to > hit CORE RET, but system suspend seems to crash. See the crash log below. thanks for the report. Does this patch fix it? - Paul OMAP3 clock: fi

[PATCH] Adds MCBSP mux settings

2008-09-25 Thread Arun KS
Adding MCBSP port 1, 3, 4 and 5 ports mux settings for 2430. Signed-off-by: Arun KS <[EMAIL PROTECTED]> --- arch/arm/mach-omap2/mux.c | 24 arch/arm/plat-omap/include/mach/mux.h | 24 2 files changed, 48 insertions(+), 0 deletions(

[PATCH] Adds MCBSP mux settings

2008-09-25 Thread Arun KS
Adding MCBSP port 1, 3, 4 and 5 ports mux settings for 2430. Signed-off-by: Arun KS <[EMAIL PROTECTED]> --- arch/arm/mach-omap2/mux.c | 24 arch/arm/plat-omap/include/mach/mux.h | 24 2 files changed, 48 insertions(+), 0 deletions(

[patch linux-omap-git] twl4030-core: cleanups

2008-09-25 Thread David Brownell
From: David Brownell <[EMAIL PROTECTED]> A bunch of little cleanups to twl4030-core. - Remove needless header inclusions, symbols, and forward declarations. - Make coding style more standard. And shrink the object size a bit. Signed-off-by: David Brownell <[EMAIL PROTECTED]> --- drivers/

Re: [PATCH 8/8] i2c-omap: Clean-up i2c-omap, v2

2008-09-25 Thread Tony Lindgren
* Tony Lindgren <[EMAIL PROTECTED]> [080925 10:18]: > Minor checkpatch and formatting clean-up. Also update copyrights. Oops, left out the last hunk too to avoid merge conflicts, here's an updated version of this patch. Tony >From a50275a85a81be007c74293b5519c3cbb01f6fa5 Mon Sep 17 00:00:00 2001

[PATCH 8/8] i2c-omap: Clean-up i2c-omap

2008-09-25 Thread Tony Lindgren
Minor checkpatch and formatting clean-up. Also update copyrights. Signed-off-by: Tony Lindgren <[EMAIL PROTECTED]> --- drivers/i2c/busses/i2c-omap.c | 31 ++- 1 files changed, 18 insertions(+), 13 deletions(-) diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c

[PATCH 7/8] i2c-omap: Don't compile in OMAP15xx I2C ISR for non-OMAP15xx builds

2008-09-25 Thread Tony Lindgren
From: Paul Walmsley <[EMAIL PROTECTED]> Skip compiling OMAP15xx I2C ISR for non-OMAP15xx builds. Saves 400 bytes of text for most OMAP builds. Signed-off-by: Paul Walmsley <[EMAIL PROTECTED]> Signed-off-by: Tony Lindgren <[EMAIL PROTECTED]> --- drivers/i2c/busses/i2c-omap.c | 10 -- 1

[PATCH 6/8] i2c-omap: Mark init-only functions as __init

2008-09-25 Thread Tony Lindgren
From: Paul Walmsley <[EMAIL PROTECTED]> Mark functions called only at init time as __init. Signed-off-by: Paul Walmsley <[EMAIL PROTECTED]> Signed-off-by: Tony Lindgren <[EMAIL PROTECTED]> --- drivers/i2c/busses/i2c-omap.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 5/8] i2c-omap: Add support on 34xx

2008-09-25 Thread Tony Lindgren
From: Chandra shekhar <[EMAIL PROTECTED]> Signed-off-by: chandra shekhar <[EMAIL PROTECTED]> Signed-off-by: Tony Lindgren <[EMAIL PROTECTED]> --- drivers/i2c/busses/i2c-omap.c | 12 +++- 1 files changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/i2c/busses/i2c-omap.c b/drive

[PATCH 3/8] i2c-omap: Add high-speed support to omap-i2c

2008-09-25 Thread Tony Lindgren
From: Syed Mohammed Khasim <[EMAIL PROTECTED]> Omap2430 has additional support for high-speed I2C. This patch moves I2C speed parameter (from module) to platform data. Also added basic High Speed support based on I2C bus speed. This patch is tested for high speed I2C (with TWL4030 Keypad) and wo

  1   2   >