Re: [PATCH 3/4] ARM: mvebu: remove the workaround imprecise abort fault handler

2015-10-14 Thread Thomas Petazzoni
cas Stach <l.st...@pengutronix.de> > --- > arch/arm/mach-mvebu/board-v7.c | 35 --- > 1 file changed, 35 deletions(-) Reviewed-by: Thomas Petazzoni <thomas.petazz...@free-electrons.com> In fact this code is anyway no longer needed, since this worka

Re: [PATCH 08/10] ARM: orion: use clkdev_create()

2015-03-03 Thread Thomas Petazzoni
); -void __init orion_clkdev_add(const char *con_id, const char *dev_id, -struct clk *clk); - void __init orion_clkdev_init(struct clk *tclk); #endif -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com

Re: OMAP3 NAND ECC selection

2013-12-05 Thread Thomas Petazzoni
constrain due to ROM code, or upgrading from remote can be handled using various alternative approaches like [a] and [b]. And you're not realizing that these solutions are ugly and impractical? Best regards, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android

Re: OMAP3 NAND ECC selection

2013-12-05 Thread Thomas Petazzoni
and reusable userspace tool to write data with arbitrary ECC schemes would be useful to workaround this situation. Best regards, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line

Re: [PATCH] ARM: dts: omap3-igep00x0: Fix nand ECC to maintain backward compatibility.

2013-12-02 Thread Thomas Petazzoni
foo8 # md5sum -c MD5SUMS foo1: OK foo10: OK foo2: OK foo3: OK foo4: OK foo5: OK foo6: OK foo7: OK foo8: OK foo9: OK Best regards, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send

Re: [PATCH] ARM: dts: omap3-igep00x0: Fix nand ECC to maintain backward compatibility.

2013-12-02 Thread Thomas Petazzoni
using -j option. '-j' option adds a clean marker to erased blocks. As said, I'm erasing/flashing from U-Boot, so flash_eraseall options are not really useful here :) Thanks! Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com

Re: [PATCH] ARM: dts: omap3-igep00x0: Fix nand ECC to maintain backward compatibility.

2013-12-02 Thread Thomas Petazzoni
regards, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH] ARM: dts: omap3-igep00x0: Fix nand ECC to maintain backward compatibility.

2013-12-02 Thread Thomas Petazzoni
-- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH] ARM: dts: omap3-igep00x0: Fix nand ECC to maintain backward compatibility.

2013-12-02 Thread Thomas Petazzoni
being able to specify a different ECC scheme per partition would make sense: when the ROM code uses a weaker ECC scheme than the one used for most other partitions. Best regards, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com

Re: [PATCH RFC 3/9] ASoC: davinci-evm: HDMI audio support for TDA998x trough McASP I2S bus

2013-11-19 Thread Thomas Petazzoni
compatible string for audio in this driver. Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More

[PATCH] arm: omap2: fix AM33xx hwmod infos for UART2

2013-05-28 Thread Thomas Petazzoni
The UART2 hwmod structure is pointing to the EDMA channels of UART1, which doesn't look right. This patch fixes this by making the UART2 hwmod structure to a new structure that lists the EDMA channels to be used by the UART2. Signed-off-by: Thomas Petazzoni thomas.petazz...@free-electrons.com

Re: [PATCHv2] Input: omap4-keypad: Add pinctrl support

2012-10-23 Thread Thomas Petazzoni
IMHO. Agreed. Just like drivers do their ioremap, request_irq and others, they should also request their pin resources using the pinctrl API. Hiding this behind a bus notifier is not nice. Best regards, Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux

Re: [PATCHv2] Input: omap4-keypad: Add pinctrl support

2012-10-23 Thread Thomas Petazzoni
when reading a driver's code: that's the problem with bus notifier, they do things a bit behind your back without you noticing. Having the driver request its own pinctrl state, and switch between states upon suspend/resume is a lot more explicit, IMO. Thomas -- Thomas Petazzoni, Free Electrons Kernel

Re: ttyO2 broken on IGEPv2 on 3.3, 3.4-rc5 or arm-soc/for-next, working on 3.2

2012-10-05 Thread Thomas Petazzoni
: uart3_tx_irtx.uart3_tx_irtx (0x480021a0/0x170 = 0x), b h21, t NA mode: OMAP_PIN_OUTPUT | OMAP_MUX_MODE0 signals: uart3_tx_irtx | NA | NA | NA | gpio_166 | NA | NA | safe_mode Best regards, Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting

Re: ttyO2 broken on IGEPv2 on 3.3, 3.4-rc5 or arm-soc/for-next, working on 3.2

2012-10-05 Thread Thomas Petazzoni
/~thomas/pub/igep-serial-problem/. Thanks, Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body

Re: ttyO2 broken on IGEPv2 on 3.3, 3.4-rc5 or arm-soc/for-next, working on 3.2

2012-10-04 Thread Thomas Petazzoni
Kevin, Reviving an old thread. On Fri, 04 May 2012 16:46:32 -0700, Kevin Hilman wrote: Thomas Petazzoni thomas.petazz...@free-electrons.com writes: I have an IGEPv2 revision 6 board, which uses the DM3730 OMAP3. With 3.2 omap2plus_defconfig, the system boots fine and have

Re: ttyO2 broken on IGEPv2 on 3.3, 3.4-rc5 or arm-soc/for-next, working on 3.2

2012-10-04 Thread Thomas Petazzoni
(UART3_RX_IRRX), (IEN | PTD | DIS | M0)) /* UART3_RX */\ Does this helps? Best regards, Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com -- To unsubscribe from this list: send the line

Re: ttyO2 broken on IGEPv2 on 3.3, 3.4-rc5 or arm-soc/for-next, working on 3.2

2012-10-04 Thread Thomas Petazzoni
(which now includes the SPL for the IGEP) and see if it improves the situation. However, I believe that the rule is that the kernel shouldn't depend too much on initialization done by the bootloader, so it still seems like an issue to me. Best regards, Thomas -- Thomas Petazzoni, Free Electrons

ttyO2 broken on IGEPv2 on 3.3, 3.4-rc5 or arm-soc/for-next, working on 3.2

2012-05-04 Thread Thomas Petazzoni
, Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com Uncompressing Linux... done, booting the kernel. [0.00] Booting Linux on physical CPU 0 [0.00] Linux version 3.2.0-2

Re: [PATCH 01/11] OMAP2+: Add SoC specific map_io functions

2012-05-04 Thread Thomas Petazzoni
-- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH 1/6] Add infrastructure for conditional code and data sections

2010-12-23 Thread Thomas Petazzoni
, without anyway from removing it. The only solution I see so far would be : static char __omap2 foo_name[] = blabla; static struct foobar __omap2 foo = { .name = foo_name, .id = 12, }; but it's really unpleasant. Other ideas ? Regards, Thomas -- Thomas Petazzoni, Free Electrons

Re: [PATCH 1/6] Add infrastructure for conditional code and data sections

2010-12-22 Thread Thomas Petazzoni
-- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info

[PATCH 2/6] omap: add macros to mark SoC-specific data/code

2010-12-21 Thread Thomas Petazzoni
From: Thomas Petazzoni t-petazz...@ti.com Signed-off-by: Thomas Petazzoni t-petazz...@ti.com --- arch/arm/plat-omap/include/plat/cpu.h | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/arch/arm/plat-omap/include/plat/cpu.h b/arch/arm/plat-omap/include/plat

[RFC] Infrastructure for dynamic removal of code and data sections

2010-12-21 Thread Thomas Petazzoni
Hello, Here is a patchset that proposes a mechanism to get rid at runtime of unused data and code sections, depending on the SoC we are currently running on. WARNING: This is only a proof-of-concept, there are many known issues. The sole purpose of this patch is to get some feedback on whether

[PATCH 6/6] omap3: beagle: get rid of unused omap2/omap4 specific code/data

2010-12-21 Thread Thomas Petazzoni
From: Thomas Petazzoni tpetazz...@ti.com Using the new condsections infrastructure, get rid of the unused code/data for OMAP2 and OMAP4 when booting on BeagleBoard OMAP3. Signed-off-by: Thomas Petazzoni t-petazz...@ti.com --- arch/arm/mach-omap2/board-omap3beagle.c |4 1 files changed

Re: [PATCH 6/6] omap3: beagle: get rid of unused omap2/omap4 specific code/data

2010-12-21 Thread Thomas Petazzoni
. The current location in the BeagleBoard board code was just to make a quick test. It belongs somewhere in the CPU detection code. Thanks for your feedback! Regards, Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training

Re: [PATCH 1/6] Add infrastructure for conditional code and data sections

2010-12-21 Thread Thomas Petazzoni
, Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More

[PATCH] omap: prcm: switch to a chained IRQ handler mechanism

2010-12-17 Thread Thomas Petazzoni
From: Thomas Petazzoni t-petazz...@ti.com Introduce a chained interrupt handler mechanism for the PRCM interrupt, so that individual PRCM event can cleanly be handled by handlers in separate drivers. We do this by introducing PRCM event names, which are then matched to the particular PRCM

Re: [PATCH v2] OMAP3: PM: PRCM interrupt: Fix warning MPU wakeup but no wakeup sources

2010-12-16 Thread Thomas Petazzoni
pending=0x0 [ 516.190338] PM: early resume of devices complete after 2.075 msecs [ 516.483612] PM: resume of devices complete after 292.999 msecs [ 516.570281] Restarting tasks ... done. -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting

Re: [PATCH 01/13] OMAP: Introduce a user list for each voltage domain instance in the voltage driver.

2010-11-24 Thread Thomas Petazzoni
consumers. If you're ok with it, I'll submit it the proper way. Thanks, Thomas From fa0edfc1a4428aead4502fcba248084c1194da53 Mon Sep 17 00:00:00 2001 From: Thomas Petazzoni t-petazz...@ti.com Date: Wed, 24 Nov 2010 10:34:35 +0100 Subject: [PATCH] regulator: Take into account the requirements

Re: [PATCH 01/13] OMAP: Introduce a user list for each voltage domain instance in the voltage driver.

2010-11-23 Thread Thomas Petazzoni
, but couldn't find it in the different branches of the linux-2.6-audioplus. Do you have a more specific pointer ? Thanks, Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com -- To unsubscribe from

Re: [PATCH v3 1/3] omap: opp: add OMAP3 OPP table data and common init

2010-11-17 Thread Thomas Petazzoni
subsystem, and then when the OPP subsystem is initialized, it takes those customizations into account. But in that specific case, it's not clear how those customizations could easily be expressed, so maybe that multiple call strategy is the simplest solution. Thomas -- Thomas Petazzoni, Free Electrons

[PATCH] omap: prcm: switch to a chained IRQ handler mechanism

2010-11-17 Thread Thomas Petazzoni
From: Thomas Petazzoni t-petazz...@ti.com Until this patch, the PRCM interrupt was handled through a normal, single interrupt handler. However, the PRCM notifies various types of events, which might be of interest to different drivers. In preparation for the usage of the PRCM interrupt by those

Re: [PATCH v3 1/3] omap: opp: add OMAP3 OPP table data and common init

2010-11-16 Thread Thomas Petazzoni
not have this, or turn this into a BUG_ON(omap_table_init == 1). Regards, Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com -- To unsubscribe from this list: send the line unsubscribe linux

Re: [PATCH v3 1/3] omap: opp: add OMAP3 OPP table data and common init

2010-11-16 Thread Thomas Petazzoni
; + omap_table_init = 1; by BUG_ON(omap_table_init == 1); omap_table_init = 1; would prevent you from having no OPP table (the case where a NULL OPP table is passed is tested *before* in omapX_init_opp()). Regards, Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real

Re: [PATCH v3 1/3] omap: opp: add OMAP3 OPP table data and common init

2010-11-16 Thread Thomas Petazzoni
behind BUG_ON, when there are valid reasons for reentry into code. In the current design, yes, there are indeed valid reasons for reentry into the omapX_init_opp() function, and that's exactly the point I'm critizicing here. Regards! Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers

Re: [PATCH v3 1/3] omap: opp: add OMAP3 OPP table data and common init

2010-11-16 Thread Thomas Petazzoni
-omapm=127507237109393w=2 Ok, if Kevin is happy with this solution, fair enough. Sorry for the noise, and thanks for your answers. Regards, Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free

Re: [PATCH 5/6] OMAP: powerdomain: Arch specific funcs for mem control

2010-11-16 Thread Thomas Petazzoni
OMAP_MEM4_ONSTATE_MASK; + default: + WARN_ON(1); /* should never happen */ + return -EEXIST; EEXIST is the error code for File exists, so here I would rather expect something like ENOENT. But I understand that it was already -EEXIST in the existing code. Thanks, Thomas -- Thomas

Re: [PATCH 2/6] OMAP: powerdomain: Infrastructure to put arch specific code

2010-11-16 Thread Thomas Petazzoni
on this structure, to detail what are the different operations, what they should do, etc. By the way, would pwrdm_operations be more linux-ish than pwrdm_functions ? Thanks, Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training

Re: BeagleBoard not resuming from uart with latest pm-core ?

2010-11-16 Thread Thomas Petazzoni
conversion patches of musb already available somewhere (even preliminary versions) ? Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com -- To unsubscribe from this list: send the line

Re: BeagleBoard not resuming from uart with latest pm-core ?

2010-11-15 Thread Thomas Petazzoni
idea ? Thanks! Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord

Re: BeagleBoard not resuming from uart with latest pm-core ?

2010-11-15 Thread Thomas Petazzoni
On Mon, 15 Nov 2010 11:50:05 +0100 Thomas Petazzoni thomas.petazz...@free-electrons.com wrote: # echo enabled /sys/class/tty/ttyO2/power/wakeup # echo mem /sys/power/state [ 227.685028] PM: Syncing filesystems ... done. [ 227.699432] Freezing user space processes ... (elapsed 0.01

Re: BeagleBoard not resuming from uart with latest pm-core ?

2010-11-15 Thread Thomas Petazzoni
-core. Thanks for the hint, anyway. Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message

Re: [PATCH v3 1/3] omap: opp: add OMAP3 OPP table data and common init

2010-11-15 Thread Thomas Petazzoni
definitions in an header file ? Unless I'm wrong, this means that if the opp3xxx_data.h file is included in two different C files, the structures will be present twice. As far as I could see, most of the kernel instantiate structure in C files instead. Regards, Thomas -- Thomas Petazzoni, Free

BeagleBoard not resuming from uart with latest pm-core ?

2010-11-10 Thread Thomas Petazzoni
/tty/ttyO2/power/wakeup, then trigger suspend to RAM. It enters suspend to RAM, but then it doesn't wakeup when I send data through the UART. Is it a known problem, or is again a mistake on my side ? Thanks, Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux

Re: [PATCH v1 07/16] OMAP3: hwmod DSS: Create platform_driver for each DSS HW IP

2010-10-08 Thread Thomas Petazzoni
are not usually at a random place with all the other static methods and structure definitions. They are located *just* above the module init/cleanup routines. Regards, Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support

Re: [PATCH v1 05/16] OMAP3 DSS Driver register moved to mach_omap2

2010-10-07 Thread Thomas Petazzoni
= omapdss, board-omap3pandora.c: .name = omapdss, board-omap3stalker.c: .name = omapdss, board-rx51-video.c: .name = omapdss, Shouldn't these board files also be updated to use the new omap_display_init() function ? Regards, Thomas -- Thomas Petazzoni, Free Electrons Kernel

Re: [PATCH v1 06/16] OMAP3: hwmod DSS: Build omap_device for each DSS HWIP

2010-10-07 Thread Thomas Petazzoni
, device_shutdown, device_idle fields being used in the following patches in your series. Did I look at the wrong place ? Thanks! Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com -- To unsubscribe

Re: [PATCH v1 11/16] OMAP3: hwmod DSS: RFBI Move init,exit to driver

2010-10-07 Thread Thomas Petazzoni
like most Linux drivers here, and directly do the initialization in probe() and the cleanup in remove() ? Concerning the added pdev field to the rfbi structure, do you really it at this point ? Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development

Re: [PATCH v1 07/16] OMAP3: hwmod DSS: Create platform_driver for each DSS HW IP

2010-10-07 Thread Thomas Petazzoni
= NULL, + .resume = NULL, Those are unneeded, the compiler will initialize those fields to zero automatically if you don't specify any value. Regards, Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support

Re: [PATCH v1 12/16] OMAP3: hwmod DSS: DISPC Move init,exit to driver

2010-10-07 Thread Thomas Petazzoni
; + } + +err_dispc: + return r; } static int omap_dispchw_remove(struct platform_device *pdev) { + dispc_exit(); return 0; } Same comments than the one for the patch on the RFBI driver. Regards, Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time

Re: [PATCH v1 07/16] OMAP3: hwmod DSS: Create platform_driver for each DSS HW IP

2010-10-07 Thread Thomas Petazzoni
__init omap_dispc_init(void) +{ + return platform_driver_register(omap_dispchw_driver); +} + +device_initcall(omap_dispc_init); Regards, Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free

Re: [PATCH v1 13/16] OMAP3: hwmod DSS: VENC Move init,exit to driver

2010-10-07 Thread Thomas Petazzoni
= regulator_get(venc.pdev-dev, vdda_dac); in the venc_init() function (which should become the -probe() method). Thanks! Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com

Re: [PATCH v1 14/16] OMAP3: hwmod DSS: DSI Move init, exit to driver

2010-10-07 Thread Thomas Petazzoni
13/16 about the contents of -probe() and -remove() methods, and the auxilliary dsi_get_vdds_dsi() function. Regards, Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com -- To unsubscribe

Re: Suspend to RAM broken on BeagleBoard ?

2010-09-11 Thread Thomas Petazzoni
is woken up. Concerning the USB issue, no idea ? Thanks, Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body

Suspend to RAM broken on BeagleBoard ?

2010-09-10 Thread Thomas Petazzoni
! Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo

Re: Suspend to RAM broken on BeagleBoard ?

2010-09-10 Thread Thomas Petazzoni
On Fri, 10 Sep 2010 20:00:53 +0300 Felipe Balbi ba...@ti.com wrote: On Fri, Sep 10, 2010 at 10:48:14AM -0500, Thomas Petazzoni wrote: I also have a problem with USB support, both on linux-omap and Kevin's pm-core branch. My USB Ethernet adapter, supported by the asix driver, isn't detected

Re: [PATCH 01/13] OMAP: Introduce a user list for each voltage domain instance in the voltage driver.

2010-09-02 Thread Thomas Petazzoni
, Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More

Re: [RFC 3/7] OMAP: Introduce voltage domain pointer and device specific set rate and get rate in device opp structures.

2010-07-12 Thread Thomas Petazzoni
a characteristic of a particular IP, don't they ? Whatever choice is made, this structure probably needs a comment on top of it explaining what it does, since the name isn't very obvious IMO. Thanks! Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development

Re: Timekeeping issue on aggressive suspend/resume

2010-06-11 Thread Thomas Petazzoni
properly at the clocksource/clock_event_device level. Sincerely, Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com -- To unsubscribe from this list: send the line unsubscribe linux-omap

Re: [RFC] [PATCH v3 2/4] OMAP4: Keyboard device registration

2010-06-02 Thread Thomas Petazzoni
= 0; char *name = omap4-keypad; oh = omap_hwmod_lookup(kbd); if (!oh) { pr_err(Could not look up kbd\n); return -EIO; } Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting

Re: [RFC] [PATCH v3 2/4] OMAP4: Keyboard device registration

2010-06-02 Thread Thomas Petazzoni
, oh_name); In this case, why not: char *oh_name = kbd; There's really no point in using snprintf() for statically-defined strings. Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com