Re: [PATCH 1/2] arm64: dts: r8a77990: Add SDHI device nodes

2018-11-06 Thread Marek Vasut
On 11/06/2018 11:35 AM, Geert Uytterhoeven wrote: > Hi Marek, Hi, > On Tue, Nov 6, 2018 at 11:32 AM Marek Vasut wrote: >> On 11/06/2018 06:26 AM, Yoshihiro Shimoda wrote: From: Marek Vasut, Sent: Tuesday, November 6, 2018 6:41 AM From: Takeshi Kihara This patch adds

[PATCH V3] arm64: dts: r8a77990: ebisu: Add and enable SDHI device nodes

2018-11-06 Thread Marek Vasut
From: Takeshi Kihara This patch adds SDHI{0,1,3} device nodes for the r8a77990 SoC and enables SD card slot connected to SDHI0, micro SD card slot connected to SDHI1 and eMMC connected to SDHI3 on the Ebisu board using the R8A77990 SoC. Signed-off-by: Takeshi Kihara Signed-off-by: Marek Vasut

[PATCH] pinctrl: sh-pfc: r8a77970: add QSPI pins, groups, and functions

2018-11-06 Thread Sergei Shtylyov
From: Dmitry Shifrin Add the QSPI{0|1} pins/groups/functions to the R8A77970 PFC driver. [Sergei: ported to the upstream driver, fixed up the swapped QSPI0 SPCLK/ SSL pins, fixed up the comments, moved the QSPI pins/groups/functions to be in the alphanumeric order, removed unneeded empty lines,

[PATCH v2] gpio: rcar: Request GPIO while enabling interrupt

2018-11-06 Thread Fabrizio Castro
There are cases when the bootloader configures a pin to work as a function rather than GPIO, and other cases when the pin is configured as a function at POR. This commit makes sure the pin is configured as a GPIO the moment we need it to work as an interrupt. Signed-off-by: Fabrizio Castro ---

RE: [PATCH] gpio: rcar: Request GPIO while enabling interrupt

2018-11-06 Thread Fabrizio Castro
Hello Geert, Thank you for your feedback! > Subject: Re: [PATCH] gpio: rcar: Request GPIO while enabling interrupt > > Hi Fabrizio, > > On Fri, Nov 2, 2018 at 8:10 PM Fabrizio Castro > wrote: > > There are cases when the bootloader configures a pin to work > > as a function rather than GPIO,

RE: [RFC] gpio: rcar: Request GPIO before enabling interrupt

2018-11-06 Thread Fabrizio Castro
Hello Geert, Thank you for your feedback! > Subject: Re: [RFC] gpio: rcar: Request GPIO before enabling interrupt > > Hi Fabrizio, > > On Fri, Oct 26, 2018 at 9:57 PM Fabrizio Castro > wrote: > > There are cases when the bootloader configures a pin to work > > as a function rather than GPIO,

Re: [PATCH] dt-bindings: timer: renesas, cmt: Document r8a77470 CMT support

2018-11-06 Thread Rob Herring
On Fri, 26 Oct 2018 09:36:13 +0100, Biju Das wrote: > Document SoC specific compatible strings for r8a77470. No driver change > is needed as the fallback strings will activate the right code. > > Signed-off-by: Biju Das > --- > This patch is tested against linux-next > --- >

Re: [PATCH] dt-bindings: watchdog: renesas-wdt: Document r8a77470 support

2018-11-06 Thread Rob Herring
On Fri, 26 Oct 2018 09:55:53 +0100, Biju Das wrote: > RZ/G1C (R8A77470) watchdog implementation is compatible with R-Car > Gen2, therefore add relevant documentation. > > Signed-off-by: Biju Das > --- > This patch is tested against linux-next > --- >

Re: [PATCH] dt-bindings: timer: renesas, cmt: Document r8a7796 CMT support

2018-11-06 Thread Rob Herring
On Tue, Nov 06, 2018 at 09:54:52AM -0600, Rob Herring wrote: > On Fri, Oct 26, 2018 at 09:01:44AM +0100, Biju Das wrote: > > Document SoC specific bindings for R-Car M3-W (r8a7796) SoC. > > > > Signed-off-by: Biju Das > > --- > > This patch is tested against linu-next > > --- > >

Re: [PATCH] dt-bindings: timer: renesas, cmt: Document r8a7796 CMT support

2018-11-06 Thread Rob Herring
On Fri, Oct 26, 2018 at 09:01:44AM +0100, Biju Das wrote: > Document SoC specific bindings for R-Car M3-W (r8a7796) SoC. > > Signed-off-by: Biju Das > --- > This patch is tested against linu-next > --- > Documentation/devicetree/bindings/timer/renesas,cmt.txt | 2 ++ > 1 file changed, 2

Re: HDMI doesn't work on ULCB board

2018-11-06 Thread Laurent Pinchart
Hi Morimoto-san, On Tuesday, 6 November 2018 16:30:35 EET Laurent Pinchart wrote: > On Thursday, 18 October 2018 05:12:14 EET Kuninori Morimoto wrote: > > Hi Vladimir, Laurent > > > > I'm testing ULCB board, and I noticed that HDMI doen't work on it. > > > > - Sometimes kernel panic happen

Re: HDMI doesn't work on ULCB board

2018-11-06 Thread Laurent Pinchart
Hi Morimoto-san, On Thursday, 18 October 2018 05:12:14 EET Kuninori Morimoto wrote: > Hi Vladimir, Laurent > > I'm testing ULCB board, and I noticed that HDMI doen't work on it. > > - Sometimes kernel panic happen (I lost log, but it said "get crc" > something error), - Often, kernel

Re: [PATCH/RFT] arm64: dts: renesas: r8a77990-ebisu: Add serial console pins

2018-11-06 Thread Simon Horman
On Sun, Oct 21, 2018 at 06:31:28AM +0900, Yoshihiro Kaneko wrote: > From: Takeshi Kihara > > This patch adds pin control for SCIF2. > > Signed-off-by: Takeshi Kihara > Signed-off-by: Yoshihiro Kaneko > --- > > This patch is based on the devel branch of Simon Horman's renesas tree. Hi

Re: [PATCH 1/4] spi: rspi: Add r8a77470 to the compatible list

2018-11-06 Thread Simon Horman
On Thu, Nov 01, 2018 at 12:35:02PM +, Fabrizio Castro wrote: > Add r8a77470 to the list of examples with soctypes. > No driver change is needed as "renesas,qspi" will activate > the right code within the corresponding driver. > > Signed-off-by: Fabrizio Castro Reviewed-by: Simon Horman >

Re: [PATCH v2 6/8] arm64: dts: r8a77990: Add VIN and CSI-2 device nodes

2018-11-06 Thread Simon Horman
On Mon, Nov 05, 2018 at 11:32:37AM +0100, jacopo mondi wrote: > Hi Simon, > > On Wed, Oct 31, 2018 at 03:37:39PM +0100, Simon Horman wrote: > > On Wed, Oct 31, 2018 at 02:18:40PM +0100, jacopo mondi wrote: > > > Hi Simon, > > > > > > On Wed, Oct 31, 2018 at 01:48:13PM +0100, Simon Horman wrote: >

Re: [PATCH v2] arm64: dts: renesas: r8a77990: Fix VIN endpoint numbering

2018-11-06 Thread Simon Horman
On Mon, Nov 05, 2018 at 02:12:43PM +0100, Jacopo Mondi wrote: > The VIN driver bindings dictates fixed numbering for VIN endpoints connected > to CSI-2 endpoints, even when a single endpoint exists. > > Without proper endpoint numbering the VIN driver fails to probe. > > Based on a patch in BSP

renesas-drivers-2018-11-06-v4.20-rc1

2018-11-06 Thread Geert Uytterhoeven
I have pushed renesas-drivers-2018-11-06-v4.20-rc1 to https://git.kernel.org/cgit/linux/kernel/git/geert/renesas-drivers.git This tree is meant to ease development of platform support and drivers for Renesas ARM SoCs. It is created by merging (a) the for-next branches of various subsystem trees

Re: [PATCH] arm64: dts: r8a77990: ebisu: Add serial console pins

2018-11-06 Thread Simon Horman
On Tue, Nov 06, 2018 at 05:22:35AM +, Yoshihiro Shimoda wrote: > Hello Marek-san, > > > From: Marek Vasut, Sent: Tuesday, November 6, 2018 6:39 AM > > > > From: Takeshi Kihara > > > > This patch adds pin control for SCIF2 on R8A77990 E3 Ebisu. > > > > Signed-off-by: Takeshi Kihara > >

Re: [PATCH 1/2] ARM: dts: r8a77470: Add watchdog support to SoC dtsi

2018-11-06 Thread Simon Horman
On Tue, Nov 06, 2018 at 11:18:14AM +0100, Geert Uytterhoeven wrote: > Hi Biju, > > On Fri, Oct 26, 2018 at 11:40 AM Biju Das wrote: > > This patch adds watchdog support to the r8a77470 SoC dtsi. > > > > Signed-off-by: Biju Das > > Thanks for your patch! > > > ---

Re: [PATCH 1/2] arm64: dts: r8a77990: Add SDHI device nodes

2018-11-06 Thread Simon Horman
On Tue, Nov 06, 2018 at 11:35:13AM +0100, Geert Uytterhoeven wrote: > Hi Marek, > > On Tue, Nov 6, 2018 at 11:32 AM Marek Vasut wrote: > > On 11/06/2018 06:26 AM, Yoshihiro Shimoda wrote: > > >> From: Marek Vasut, Sent: Tuesday, November 6, 2018 6:41 AM > > >> > > >> From: Takeshi Kihara > > >>

Re: [PATCH V2] arm64: dts: renesas: Switch eMMC bus to 1V8 on Salvator-X and ULCB

2018-11-06 Thread Simon Horman
On Tue, Nov 06, 2018 at 11:57:17AM +0100, Wolfram Sang wrote: > On Sun, Nov 04, 2018 at 09:37:07PM +0100, Marek Vasut wrote: > > The eMMC card has two supplies, VCC and VCCQ. The VCC supplies the NAND > > array and the VCCQ supplies the bus. On Salvator-X and ULCB, the VCC is > > connected to 3.3V

Re: [PATCH 1/2] pinctrl: sh-pfc: r8a77990: Add SDHI pins, groups and functions

2018-11-06 Thread Marek Vasut
On 11/06/2018 12:14 PM, Wolfram Sang wrote: > >> static const struct { >> -struct sh_pfc_pin_group common[123]; >> +struct sh_pfc_pin_group common[140]; >> struct sh_pfc_pin_group automotive[0]; >> } pinmux_groups = { > > ... > >> static const struct { >> -struct

Re: [PATCH 2/2] pinctrl: sh-pfc: r8a77990: Add voltage switch operations for SDHI

2018-11-06 Thread Wolfram Sang
On Mon, Nov 05, 2018 at 10:40:12PM +0100, Marek Vasut wrote: > From: Takeshi Kihara > > This patch supports the {get,set}_io_voltage operations of SDHI. > > This operates the IOCTRL30 register on the R8A77990 SoC and makes > 1.8V/3.3V signal voltage switch possible. > > Signed-off-by: Takeshi

Re: [PATCH 1/2] pinctrl: sh-pfc: r8a77990: Add SDHI pins, groups and functions

2018-11-06 Thread Wolfram Sang
> static const struct { > - struct sh_pfc_pin_group common[123]; > + struct sh_pfc_pin_group common[140]; > struct sh_pfc_pin_group automotive[0]; > } pinmux_groups = { ... > static const struct { > - struct sh_pfc_function common[29]; > + struct sh_pfc_function

Re: [PATCH] mmc: renesas_sdhi: Whitelist R8A77990 SDHI

2018-11-06 Thread Wolfram Sang
On Mon, Nov 05, 2018 at 10:39:35PM +0100, Marek Vasut wrote: > Whitelist R8A77990 E3 SoC in the SDHI driver. The SDHI core > present in the SoC is an 8tap variant of the Gen3 SDHI core. > > Signed-off-by: Marek Vasut > Cc: Geert Uytterhoeven > Cc: Simon Horman > Cc: Wolfram Sang > Cc:

Re: [PATCH V2] arm64: dts: renesas: Switch eMMC bus to 1V8 on Salvator-X and ULCB

2018-11-06 Thread Wolfram Sang
On Sun, Nov 04, 2018 at 09:37:07PM +0100, Marek Vasut wrote: > The eMMC card has two supplies, VCC and VCCQ. The VCC supplies the NAND > array and the VCCQ supplies the bus. On Salvator-X and ULCB, the VCC is > connected to 3.3V rail, while the VCCQ is connected to 1.8V rail. Adjust > the pinmux

Re: [PATCH 1/2] arm64: dts: r8a77990: Add SDHI device nodes

2018-11-06 Thread Geert Uytterhoeven
Hi Marek, On Tue, Nov 6, 2018 at 11:32 AM Marek Vasut wrote: > On 11/06/2018 06:26 AM, Yoshihiro Shimoda wrote: > >> From: Marek Vasut, Sent: Tuesday, November 6, 2018 6:41 AM > >> > >> From: Takeshi Kihara > >> > >> This patch adds SDHI{0,1,3} device nodes for the r8a77990 SoC. > >> > >>

[PATCH v4 1/4] pinctrl: sh-pfc: Add optional arg to VIN_DATA_PIN_GROUP

2018-11-06 Thread Jacopo Mondi
VIN data groups may appear on different sets of pins, usually named "vinX_data_[a|b]". The existing VIN_DATA_PIN_GROUP() does not support appending the '_a' or '_b' suffix, leading to the definition of groups names not consistent with the ones defined using SH_PFC_PIN_GROUP() macro. Fix this by

[PATCH v4 0/4] sh-pfc: Variadic VIN_DATA_PIN_GROUP macro + updates

2018-11-06 Thread Jacopo Mondi
Hi Geert, thanks to your suggestion I made a variadic macro out of the VIN_DATA_PIN_GROUP one. The macro accepts an optional third argument 'version' and creates properly formatted names in the form of 'vin4_data8_a' in place of the previous 'vin4_data_a8' ones. I included in this series the

[PATCH v4 4/4] pinctrl: sh-pfc: r8a77990: Add VIN[4|5] groups/functions

2018-11-06 Thread Jacopo Mondi
Add pin, mux and functions definitions for VIN4 and VIN5 for R-Car E3. Signed-off-by: Jacopo Mondi --- v3 -> v4: - Use new variadic version of VIN_DATA_PIN_GROUP macro v2 -> v3: - Rebased on v4.20-rc1 - Use the newly introduced VIN_DATA_PIN_GROUP_VER macro Incorporate Geert's comments: -

[PATCH v4 2/4] pinctrl: sh-pfc: Fix VIN versioned groups name

2018-11-06 Thread Jacopo Mondi
Versioned VIN groups can appear on different sets of pins. Using the VIN_DATA_PIN_GROUP macro now supports proper naming of said groups through an optional 'version' argument. Use the 'version' argument for said macro to fix naming of versioned groups for R-Car SoCs that defines them.

Re: [RFC][PATCH] PCI: Avoid PCI device removing/rescanning through sysfs triggers a deadlock

2018-11-06 Thread Marek Vasut
On 11/06/2018 09:13 AM, Geert Uytterhoeven wrote: > Hi Marek, > > Thanks for your patch! > > On Tue, Nov 6, 2018 at 12:25 AM Marek Vasut wrote: >> From: Tho Vu >> >> This patch fixes deadlock warning in removing/rescanning through sysfs >> when CONFIG_PROVE_LOCKING is enabled. >> >> The issue

Re: [PATCH 1/2] arm64: dts: r8a77990: Add SDHI device nodes

2018-11-06 Thread Marek Vasut
On 11/06/2018 06:26 AM, Yoshihiro Shimoda wrote: > Hello Marek-san, Hello Shimoda-san, >> From: Marek Vasut, Sent: Tuesday, November 6, 2018 6:41 AM >> >> From: Takeshi Kihara >> >> This patch adds SDHI{0,1,3} device nodes for the r8a77990 SoC. >> >> Signed-off-by: Takeshi Kihara >>

Re: [PATCH 2/2] arm64: dts: r8a77990: ebisu: Enable SDHI interfaces

2018-11-06 Thread Marek Vasut
On 11/06/2018 09:34 AM, Wolfram Sang wrote: > >> +sdhi3_pins: sd3 { >> +groups = "sdhi3_data8", "sdhi3_ctrl"; >> +function = "sdhi3"; >> +power-source = <1800>; >> +}; >> + >> +sdhi3_pins_uhs: sd3_uhs { >> +groups = "sdhi3_data8",

Re: [PATCH 2/2] arm64: dts: r8a77990: ebisu: Enable SDHI interfaces

2018-11-06 Thread Marek Vasut
On 11/06/2018 06:29 AM, Yoshihiro Shimoda wrote: > Hello Marek-san, Hello Shimoda-san, >> From: Marek Vasut, Sent: Tuesday, November 6, 2018 6:41 AM >> >> From: Takeshi Kihara >> >> This patch enables SD card slot connected to SDHI0, micro SD card slot >> connected to SDHI1 and eMMC connected

Re: [PATCH 1/2] ARM: dts: r8a77470: Add watchdog support to SoC dtsi

2018-11-06 Thread Geert Uytterhoeven
Hi Biju, On Fri, Oct 26, 2018 at 11:40 AM Biju Das wrote: > This patch adds watchdog support to the r8a77470 SoC dtsi. > > Signed-off-by: Biju Das Thanks for your patch! > --- a/arch/arm/boot/dts/r8a77470.dtsi > +++ b/arch/arm/boot/dts/r8a77470.dtsi > @@ -196,6 +196,16 @@ >

Re: [PATCH 2/2] arm64: dts: r8a77990: ebisu: Enable SDHI interfaces

2018-11-06 Thread Wolfram Sang
> + sdhi3_pins: sd3 { > + groups = "sdhi3_data8", "sdhi3_ctrl"; > + function = "sdhi3"; > + power-source = <1800>; > + }; > + > + sdhi3_pins_uhs: sd3_uhs { > + groups = "sdhi3_data8", "sdhi3_ctrl"; > + function = "sdhi3"; > +

Re: [RFC][PATCH] PCI: Avoid PCI device removing/rescanning through sysfs triggers a deadlock

2018-11-06 Thread Geert Uytterhoeven
Hi Marek, Thanks for your patch! On Tue, Nov 6, 2018 at 12:25 AM Marek Vasut wrote: > From: Tho Vu > > This patch fixes deadlock warning in removing/rescanning through sysfs > when CONFIG_PROVE_LOCKING is enabled. > > The issue can be reproduced by these steps: > 1. Enable CONFIG_PROVE_LOCKING