check.
And I've just tried with pcie-xilinx, and pcie-altera, but both still
need this header - so perhaps pcie-rcar was just the odd one out.
Reviewed-by: Kieran Bingham
> Signed-off-by: Andrew Murray
> ---
> drivers/pci/controller/pcie-rcar.c | 2 --
> 1 file changed, 2 dele
Hi Simon,
On 17/07/2019 13:57, Simon Horman wrote:
> * According to the R-Car Gen3 Hardware Manual Errata for Rev 1.00 of
> August 24, 2018, the TX clock internal delay mode isn't supported
> on R-Car E3 (r8a77990) and D3 (r8a77995).
>
> * TX clock internal delay mode is required for reliable
Hi Wolfram,
On 24/06/2019 18:04, Wolfram Sang wrote:
> Nobody (including me) noticed that these functions were exported but not
> added to the header :/
>
A small, minor detail :D
Reviewed-by: Kieran Bingham
> Fixes: 7159dbdae3c5 ("i2c: core: improve return
Hi Laurent,
On 19/06/2019 01:22, Laurent Pinchart wrote:
> Add a generator method to the KMSTest class to enumerate all
> non-writeback connectors, and use it through tests.
>
Excellent, yes that's exactly what I had in mind.
Reviewed-by: Kieran Bingham
> Signed-off-by:
Hi Laurent,
On 17/06/2019 00:41, Laurent Pinchart wrote:
> Add a new test script that tests all formats supported by planes.
>
> Signed-off-by: Laurent Pinchart
Seems reasonable to me.
Reviewed-by: Kieran Bingham
> ---
> tests/kms-test-
5":
> +if soc != "r8a7795" and soc != "r8a77965":
To be a bit more pythonic, you could write;
if soc not in ["r8a7795", "r8a77965"]:
But I don't think this list is going to be extended any time soon so it
doesn't really matter.
Up to you either way,
Reviewed-by: Kieran Bingham
> self.skip("VSPDL (BRU+BRS) not available")
> return
>
>
--
Regards
--
Kieran
n the commit tail handler.
>
Small concern about the duplication of skipping writeback connectors
which we may likely need across other tests, but that is probably a
separate patch on it's own right.
Reviewed-by: Kieran Bingham
> Signed-off-by: Laurent Pinchart
> ---
> te
Hi Laurent,
On 17/06/2019 17:12, Laurent Pinchart wrote:
> When stopping a test, kernel messages can be logged after the event loop
> is stopped. Capture them before closing the log.
Ohh good catch.
Reviewed-by: Kieran Bingham
> Signed-off-by: Laurent Pinchart
> ---
> tests
.atomic_crtc_disable().
>
> Signed-off-by: Laurent Pinchart
Other than minor spelling and pep8 style comments,
Reviewed-by: Kieran Bingham
> ---
> tests/kms-test-crc.py | 2 +-
> tests/kmstest.py | 65 +++
> 2 files changed, 60 insertio
t Pinchart
Reviewed-by: Kieran Bingham
> ---
> drivers/media/platform/vsp1/vsp1_drm.c | 13 -
> drivers/media/platform/vsp1/vsp1_drm.h | 2 ++
> 2 files changed, 14 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/vsp1/vsp1_drm.c
> b/driv
Hi Laurent,
On 17/06/2019 22:09, Laurent Pinchart wrote:
> From: Kieran Bingham
>
> Refactoring of the group control code will soon require more iteration
> over the available groups. Simplify this process by introducing a group
> iteration helper.
>
> Signed-off-by: Kie
ed the other two anyway, it seems silly not to add this here :D
Reviewed-by: Kieran Bingham
> ---
> drivers/mfd/da9063-i2c.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mfd/da9063-i2c.c b/drivers/mfd/da9063-i2c.c
> index 455de74c0dd2..2133b09f6e7a 100644
new functions and fix minor kdoc issues]
> Signed-off-by: Wolfram Sang
This looks good to me.
Reviewed-by: Kieran Bingham
> ---
> Documentation/driver-model/devres.txt | 3 ++
> drivers/i2c/i2c-core-base.c | 44 +++
> include/linux/i2c.h
gned-off-by: Wolfram Sang
I like the new naming a lot more this time :-)
Reviewed-by: Kieran Bingham
> ---
> drivers/i2c/i2c-core-base.c | 74 ++---
> 1 file changed, 61 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/i2c/i2c-core-bas
Hi Michael,
Thank you for the patch,
Could the patch title be a bit better described? Perhaps:
media: i2c: adv748x: Correct EAV F-bit handling
On 10/05/2019 16:30, Michael Rodin wrote:
> According to pages 188 and 193 of the "UG-747: ADV7481 Reference Manual"
> [1], the bit 7 (FRAMENUMBER_INTE
Hi Laurent
On 18/04/2019 07:37, Laurent Pinchart wrote:
> Hi Kieran,
>
> Thank you for the patch.
>
> On Thu, Apr 11, 2019 at 05:12:55PM +0100, Kieran Bingham wrote:
>> The 'mp' value is used through many calculations in determining the scaling
>> factors o
Hi Laurent,
On 18/04/2019 07:33, Laurent Pinchart wrote:
> Hi Kieran,
>
> Thank you for the patch.
>
> On Thu, Apr 11, 2019 at 05:12:54PM +0100, Kieran Bingham wrote:
>> The image partition algorithm operates on the image dimensions as input
>> into the WPF entity
Hi Laurent,
On 18/04/2019 07:32, Laurent Pinchart wrote:
> Hi Kieran,
>
> Thank you for the patch.
>
> On Thu, Apr 11, 2019 at 05:12:53PM +0100, Kieran Bingham wrote:
>> Ensure that the partition window is correctly initialised before being
>> utilised.
>>
w based on the
surrounding comments, but even if those comments prompt action - I don't
think those changes should necessarily be part of this patch.
Therefore:
Reviewed-by: Kieran Bingham
> 25 files changed, 77 insertions(+), 68 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/du
aurent Pinchart
> Acked-by: Linus Walleij
Reviewed-by: Kieran Bingham
> ---
> include/drm/drm_connector.h | 36
> 1 file changed, 32 insertions(+), 4 deletions(-)
>
> diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h
&
gt;
> In the case at hand a dumb VGA bridge needs a specific data enable
> polarity (DRM_BUS_FLAG_DE_LOW).
>
> Signed-off-by: Stefan Agner
> Signed-off-by: Laurent Pinchart
Trivial but, should you have a +renesas^ there?
> Reviewed-by: Tomi Valkeinen
Reviewed-by
d-numbered pixels are transferred on separate LVDS links.
Do you foresee this becoming a bitfield in the future if there are more
options?
I don't think that affects this right now though, and it's fine as a bool.
> Signed-off-by: Laurent Pinchart
Reviewed-by: Kieran Bingham
>
Hi Jacopo,
On 12/04/2019 15:45, Jacopo Mondi wrote:
> Hi Kieran,
>
> On Fri, Apr 12, 2019 at 03:15:46PM +0100, Kieran Bingham wrote:
>> Hi Jacopo,
>>
>> On 16/03/2019 15:47, Jacopo Mondi wrote:
>>> Post-pone the write of the ADV748X_IO_10 register that control
h,
Reviewed-by: Kieran Bingham
> ---
> V1-->V2
> * Incorporated Kieran's review comment
> (https://patchwork.kernel.org/patch/10896165/)
> ---
> drivers/gpu/drm/rcar-du/rcar_du_drv.c | 30 ++
> 1 file changed, 30 insertions(
Hi Jacopo,
On 16/03/2019 15:47, Jacopo Mondi wrote:
> Use the TXA routing information to configure the number of active CSI-2
> data lanes. When routing AFE through TXA limit the number of data lanes
> to 1, while in the canonical HDMI->TXA routing use all the physically
> available ones.
>
> The
tches working then it will help your use case - but
probably needs more considerable work before we can integrate into mainline.
--
Kieran
On 12/04/2019 13:23, Kieran Bingham wrote:
> Hi Fabrizio,
>
> On 12/04/2019 11:12, Fabrizio Castro wrote:
>> Hello Laurent,
>>
>> ha
Hi Fabrizio,
On 12/04/2019 11:12, Fabrizio Castro wrote:
> Hello Laurent,
>
> has colour keying ever been tested on R-Car Gen3?
> I am working on HDMI support for the RZ/G2E, and I wanted to test "colorkey",
> but it
> looks like that once you have RCAR_DU_FEATURE_VSP1_SOURCE defined within the
9:37 +)
--------
Kieran Bingham (9):
drm: Fix subtle spelling error in drm_crtc_state
drm: rcar-du: crtc: Make local functions static
drm: rcar-du: Remove unused prototypes
drm: rcar-du: Link CRTCs to the DU device
drm: rcar-du: Add CR
e non-errptr functions.
Perhaps that's not really an issue if it's caught by review, or
coccinelle though.
Aside from the function-name-bike-shedding which can be handled as you
wished/discussed in 2/3, and one small grammatical fix in a comment below:
Revi
Hi Wolfram,
On 14/03/2019 10:25, Peter Rosin wrote:
> Hi!
>
> A comment from the peanut gallery...
>
> On 2019-03-13 17:55, Wolfram Sang wrote:
>> From: Heiner Kallweit
>>
>> i2c_new_dummy is typically called from the probe function of the
>> driver for the primary i2c client. It requires calls
eate panel bridge instances.
>
> Signed-off-by: Laurent Pinchart
Except for some minor wording on the comment, which I'll let you handle,
Reviewed-by: Kieran Bingham
> ---
> drivers/gpu/drm/rcar-du/rcar_du_encoder.c | 54 ---
> 1 file changed, 48 insertions(+
On 01/03/2019 17:08, Kieran Bingham wrote:
> From: Kieran Bingham
>
> To improve image quality when scaling using the UDS we need to correctly
> determine the start phase value for each partition window, and apply a
> margin to overlap discontinous pixels.
>
> Provide
From: Kieran Bingham
Provide a helper to describe when the partition algorithm is in use on a
given pipeline. This improves readability to the purpose of the code,
rather than obtusely checking the number of partitions.
Signed-off-by: Kieran Bingham
---
drivers/media/platform/vsp1
From: Kieran Bingham
To improve image quality when scaling using the UDS we need to correctly
determine the start phase value for each partition window, and apply a
margin to overlap discontinous pixels.
Provide helper functions for calculating the phase parameters, and source
locations for a
From: Kieran Bingham
Ensure that the partition window is correctly initialised before being
utilised.
Signed-off-by: Kieran Bingham
---
drivers/media/platform/vsp1/vsp1_video.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/vsp1/vsp1_video.c
b
From: Kieran Bingham
The UDS and SRU (and SHP) require expanded partition windows to support
overlapping partition windows as a means of discarding discontinous pixel data,
due to repeated pixels in their input filters.
The first four patches are clean ups and helpers to facilitate the
From: Kieran Bingham
The image partition algorithm operates on the image dimensions as input
into the WPF entity. Document this in the code block header.
Reviewed-by: Laurent Pinchart
Signed-off-by: Kieran Bingham
---
drivers/media/platform/vsp1/vsp1_video.c | 8
1 file changed, 8
From: Kieran Bingham
The 'mp' value is used through many calculations in determining the scaling
factors of the UDS. Factor this out so that it can be reused in further
calculations, and also ensure that if the BLADV control is ever changed only a
single function needs to be modifie
Hi Geert,
On 18/02/2019 09:01, Geert Uytterhoeven wrote:
> Hi Kieran,
>
> On Sun, Feb 17, 2019 at 11:13 PM Kieran Bingham
> wrote:
>> On 16/02/2019 23:58, Niklas Söderlund wrote:
>>> From: Takeshi Kihara
>>>
>>> The register address used for the
rcsi2_write(priv, PHYCNT_REG, phycnt);
> rcsi2_write(priv, LINKCNT_REG, LINKCNT_MONITOR_EN |
> LINKCNT_REG_MONI_PACT_EN | LINKCNT_ICLK_NONSTOP);
> + rcsi2_write(priv, FLD_REG, fld);
However, I can see that this matches the flow chart in figures
25.{17,18
ct startup sequence.
>
> Signed-off-by: Niklas Söderlund
Assuming the step1 table is accurate, which I have not yet been able to
validate:
Reviewed-by: Kieran Bingham
> ---
> drivers/media/platform/rcar-vin/rcar-csi2.c | 39 ++---
> 1 file changed, 35 insertions(+)
Hi Niklas,
On 18/02/2019 01:43, Niklas Söderlund wrote:
> Hi Kieran,
>
> On 2019-02-17 22:27:27 +0000, Kieran Bingham wrote:
>> Hi Niklas,
>>
>> On 13/02/2019 22:07, Niklas Söderlund wrote:
>>> Changes to v4l2-fwnode in commit [1] triggered a lockdep warning i
1. commit eae2aed1eab9bf08 ("media: v4l2-fwnode: Switch to
> v4l2_async_notifier_add_subdev")
>
> Fixes: 6458afc8c49148f0 ("media: rcar-vin: remove unneeded locking in async
> callbacks")
> Signed-off-by: Niklas Söderlund
Only a couple of minorish comments below.
Wit
Hi Niklas, Takeshi,
On 16/02/2019 23:58, Niklas Söderlund wrote:
> From: Takeshi Kihara
>
> The register address used for the reg property of the adv7482 node in
> other Renesas device trees are decimal not hex, change this for Ebisu to
> align it with the others.
>
> Signed-off-by: Takeshi Kih
;
> Signed-off-by: Takeshi Kihara
> [Niklas: rewrite commit message]
> Signed-off-by: Niklas Söderlund
Reviewed-by: Kieran Bingham
> ---
> arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/
Hi Laurent,
On 17/02/2019 12:01, Laurent Pinchart wrote:
> Hi Kieran,
>
> Thank you for the patch.
>
> On Tue, Dec 04, 2018 at 03:51:46PM +, Kieran Bingham wrote:
>> Some of our tests set flipping and rotation controls, and the VSP cell
>
> cell ?
Hrm ... Block,
Hi Laurent,
On 17/02/2019 12:00, Laurent Pinchart wrote:
> Hi Kieran,
>
> Thank you for the patch.
>
> On Tue, Dec 04, 2018 at 03:51:45PM +, Kieran Bingham wrote:
>> Provide the pass-through option of --queue-late to vsp-runner, to request
>> that yavta will qu
Hi Laurent,
On 17/02/2019 11:59, Laurent Pinchart wrote:
> Hi Kieran,
>
> Thank you for the patch.
>
> On Tue, Dec 04, 2018 at 03:51:44PM +, Kieran Bingham wrote:
>> Provide a means for the tester to request pixel perfect matches on tests.
>> This can be
Hi Laurent,
On 17/02/2019 02:42, Laurent Pinchart wrote:
> Hi Kieran,
>
> Thank you for the patch.
>
> On Tue, Dec 04, 2018 at 03:51:43PM +, Kieran Bingham wrote:
>> Signed-off-by: Kieran Bingham
>
> Reviewed-by: Laurent Pinchart
>
Thanks, This has no
Hi Laurent,
On 17/02/2019 02:48, Laurent Pinchart wrote:
> Hi Kieran,
>
> Thank you for the patch.
>
> On Tue, Dec 04, 2018 at 03:51:42PM +, Kieran Bingham wrote:
>> Extend the vsp-lib to support command line parsing for all tests. The
>> arguments parsed here sh
Hi Laurent,
On 17/02/2019 02:47, Laurent Pinchart wrote:
> Hi Kieran,
>
> Thank you for the patch.
>
> On Tue, Dec 04, 2018 at 03:51:41PM +, Kieran Bingham wrote:
>> Validate that a 1xN stream can be read through the RPF and written
>> through the WPF.
>&g
Hi Laurent,
On 17/02/2019 02:41, Laurent Pinchart wrote:
> Hi Kieran,
>
> Thank you for the patch.
>
> On Tue, Dec 04, 2018 at 03:51:40PM +, Kieran Bingham wrote:
>> Provide an initial test which can run as part of the test suite.
>> This test will report the
Hi Hans,
On 18/01/2019 12:09, Hans Verkuil wrote:
> On 1/11/19 6:41 PM, Kieran Bingham wrote:
>> The ADV748x is currently reset by writting a small table of registers to
>> the device.
s/writting/writing/
>>
>> The table lacks documentation and contains magic value
The ADV748X_PAGE_WAIT is a fake page to insert arbitrary delays in the
register tables.
Its only usage was removed, so we can remove the handling and simplify
the code.
Reviewed-by: Laurent Pinchart
Reviewed-by: Niklas Söderlund
Signed-off-by: Kieran Bingham
---
v2:
- Use for loop with regs
n != of_fwnode_handle(e)
> (
> return e;
> |
> *return ...;
> )
> //
>
> Signed-off-by: Julia Lawall
Thankyou for the update.
Reviewed-by: Kieran Bingham
>
> ---
> v2: Add the second of_node_put(entity);, as suggested by Kieran Bingham.
>
> drivers/gpu/drm/rcar-du/rcar_du
> @r exists@
> local idexpression e;
> expression x;
> @@
> e = of_graph_get_remote_port_parent(...);
> ... when != x = e
> when != true e == NULL
> when != of_node_put(e)
> when != of_fwnode_handle(e)
> (
> return e;
> |
> *return ...;
> )
> //
Hi Jacopo,
for this series:
Tested-by: Kieran Bingham
For anyone else who wants to use this series, please remember that if
you reset links on the media controller you will now have to set up the
links between the HDMI/AFE and TXA/TXB with this series in place.
The driver will default to the
Hi Niklas,
On 14/01/2019 13:06, Niklas Söderlund wrote:
> Hi Kieran,
>
> Thanks for your work.
>
> On 2019-01-11 16:17:03 +, Kieran Bingham wrote:
>> From: Steve Longerbeam
>>
>> Switch to devm_kzalloc() when allocating the adv748x device struct.
>>
Hi Laurent,
On 11/01/2019 20:23, Laurent Pinchart wrote:
> Hi Kieran,
>
> Thank you for the patch.
>
> On Friday, 11 January 2019 19:41:41 EET Kieran Bingham wrote:
>> The ADV748X_PAGE_WAIT is a fake page to insert arbitrary delays in the
>> register tables.
>>
Hi Laurent,
Thanks for the review,
On 11/01/2019 20:15, Laurent Pinchart wrote:
> Hi Kieran,
>
> Thank you for the patch.
>
> On Friday, 11 January 2019 19:41:40 EET Kieran Bingham wrote:
>> The ADV748x is currently reset by writting a small table of registers to
>>
the
delay workaround.
Kieran Bingham (2):
media: i2c: adv748x: Convert SW reset routine to function
media: i2c: adv748x: Remove PAGE_WAIT
drivers/media/i2c/adv748x/adv748x-core.c | 49 ++--
drivers/media/i2c/adv748x/adv748x.h | 17 +++-
2 files changed, 44 inserti
of the
specific writes along the way.
Signed-off-by: Kieran Bingham
---
drivers/media/i2c/adv748x/adv748x-core.c | 32
drivers/media/i2c/adv748x/adv748x.h | 16
2 files changed, 38 insertions(+), 10 deletions(-)
diff --git a/drivers/media/i2c/adv748x
The ADV748X_PAGE_WAIT is a fake page to insert arbitrary delays in the
register tables.
Its only usage was removed, so we can remove the handling and simplify
the code.
Signed-off-by: Kieran Bingham
---
drivers/media/i2c/adv748x/adv748x-core.c | 17 ++---
drivers/media/i2c/adv748x
From: Steve Longerbeam
Switch to devm_kzalloc() when allocating the adv748x device struct.
The sizeof() is updated to determine the correct allocation size from
the dereferenced pointer type rather than hardcoding the struct type.
Signed-off-by: Steve Longerbeam
Reviewed-by: Kieran Bingham
Hi Steve,
On 11/01/2019 15:43, Kieran Bingham wrote:
> From: Steve Longerbeam
Thank you for the patch, (which was forwarded to me from the BSP team)
> Switch to devm_kzalloc() when allocating the adv748x device struct.
>
> Signed-off-by: Steve Longerbeam
> ---
> drivers
Hi Matsuoka-san,
Thank you for the patch,
On 11/01/2019 15:43, Kieran Bingham wrote:>
> From: Koji Matsuoka
>
> By Documentation/timers/timers-howto.txt, when waiting 20ms from 10us,
> it is correct to use usleep_range. this patch corrects it.
>
> Signed-off-by: Koji Matsu
From: Steve Longerbeam
Switch to devm_kzalloc() when allocating the adv748x device struct.
Signed-off-by: Steve Longerbeam
---
drivers/media/i2c/adv748x/adv748x-core.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/media/i2c/adv748x/adv748x-core.c
b/drivers/
From: Koji Matsuoka
By Documentation/timers/timers-howto.txt, when waiting 20ms from 10us,
it is correct to use usleep_range. this patch corrects it.
Signed-off-by: Koji Matsuoka
(cherry picked from horms/renesas-bsp commit
af0cdba377bc8a784cdae6a77fb7a822cebc7083)
Signed-off-by: Steve Longerb
Hi Niklas,
Thank you for this series. I think it really helps towards breaking down
those pre-defined tables of register data.
--
Kieran
On 29/11/2018 02:01, Niklas Söderlund wrote:
> Hi,
>
> This series allows the TXA CSI-2 transmitter of the adv748x to function
> in 1-, 2- and 4- lane mode.
er/value writes
> when powering up/down the TXA and TXB transmitters which include the
> write to the NUM_LANES register. By converting the tables into functions
> and using parameters the power up/down functions for TXA and TXB power
> up/down can be merged and used for both transmitte
h TX private data structure.
>
> TXA supports 1, 2 and 4 lanes while TXB supports 1 lane.
>
Reviewed-by: Kieran Bingham
> Signed-off-by: Niklas Söderlund
> Reviewed-by: Jacopo Mondi
> Reviewed-by: Laurent Pinchart
> Tested-by: Jacopo Mondi
>
> ---
> * Change
hardware reducing code duplicating as well aligning with the
> documentation.
>
> Signed-off-by: Niklas Söderlund
> Reviewed-by: Laurent Pinchart
> Tested-by: Jacopo Mondi
Reviewed-by: Kieran Bingham
>
> ---
> * Changes since v2
> - Bring in the undocum
llback on.
>
> Signed-off-by: Niklas Söderlund
Reviewed-by: Kieran Bingham
>
> ---
> * Changes since v3
> - Add paragraph to describe the accepted values for the source endpoint
> data-lane property. Thanks Jacopo for pointing this out and sorry for
> missing this in v2
at link setup time, to route
> the selected video stream to the desired TX output.
Reviewed-by: Kieran Bingham
> Signed-off-by: Jacopo Mondi
> ---
> drivers/media/i2c/adv748x/adv748x-core.c | 48 +++-
> drivers/media/i2c/adv748x/adv748x.h | 2 +
>
Hi Jacopo,
On 10/01/2019 08:58, Jacopo Mondi wrote:
> On Wed, Jan 09, 2019 at 02:15:33PM +0000, Kieran Bingham wrote:
>> On 09/01/2019 00:15, Laurent Pinchart wrote:
>>> Hello,
>>>
>>> On Monday, 7 January 2019 14:36:28 EET Kieran Bingham wrote:
>>
Hi Jacopo,
One more comment below:
On 07/01/2019 12:36, Kieran Bingham wrote:
> Hi Jacopo,
>
> On 06/01/2019 15:54, Jacopo Mondi wrote:
>> When the adv748x driver is informed about a link being created from HDMI or
>> AFE to a CSI-2 TX output, the 'link_setup()&
On 09/01/2019 00:15, Laurent Pinchart wrote:
> Hello,
>
> On Monday, 7 January 2019 14:36:28 EET Kieran Bingham wrote:
>> On 06/01/2019 15:54, Jacopo Mondi wrote:
>>> When the adv748x driver is informed about a link being created from HDMI
>>> or AFE to a
Hi Jacopo,
On 06/01/2019 15:54, Jacopo Mondi wrote:
> When the adv748x driver is informed about a link being created from HDMI or
> AFE to a CSI-2 TX output, the 'link_setup()' callback is invoked. Make
> sure to implement proper routing management at link setup time, to route
> the selected video
stopping the stream.
>
Great - decouples the AFE/HDMI from a specific TX.
Reviewed-by: Kieran Bingham
> Reviewed-by: Laurent Pinchart
> Signed-off-by: Jacopo Mondi
> ---
> drivers/media/i2c/adv748x/adv748x-afe.c | 2 +-
> drivers/media/i2c/adv748x/adv748x-csi2.c | 15 +++
en HDMI and AFE entities to
> TXA, checking which TX the function is operating on is not meaningful anymore.
>
> To fix this, store the subdevice of the source providing video data to the
> CSI-2 TX in the 'struct adv748x_csi2' representing the TX and check on it.
>
Rev
Hi Jacopo,
On 07/01/2019 10:05, Jacopo Mondi wrote:
> Hi Kieran,
>>> diff --git a/drivers/media/i2c/adv748x/adv748x.h
>>> b/drivers/media/i2c/adv748x/adv748x.h
>>> index b482c7fe6957..bc2da1b5ce29 100644
>>> --- a/drivers/media/i2c/adv748x/adv748x.h
>>> +++ b/drivers/media/i2c/adv748x/adv748x.
g
> from existing ones.
Great - this looks good to me.
Small nit below - but it's not a big deal.
Reviewed-by: Kieran Bingham
> Signed-off-by: Jacopo Mondi
> ---
> drivers/media/i2c/adv748x/adv748x-csi2.c | 44 +---
> 1 file changed, 23 insertions(+),
Hi Jacopo,
On 06/01/2019 15:54, Jacopo Mondi wrote:
> Rename the chip reset procedure as they configure the CP (HDMI) and SD
> (AFE) cores.
Reviewed-by: Kieran Bingham
> Reviewed-by: Laurent Pinchart
> Signed-off-by: Jacopo Mondi
> ---
> drivers/media/i2c/adv748x/a
Hi Jacopo
On 06/01/2019 15:54, Jacopo Mondi wrote:
> Add small is_txb() macro to the existing is_txa() and use it where
> appropriate.
Thank you.
I think this will make the code much better to read than if (!is_txa).
> Signed-off-by: Jacopo Mondi
Reviewed-by: Kiera
st of the necessary headers, so the change is simple.
>
> While at it, remove unneeder inclusion of other headers, and unneeded
s/uneeder/unneeded/
> forward declarations of structures.
>
But otherwise:
Reviewed-by: Kieran Bingham
> Signed-off-by: Laurent Pinchart
> ---
>
> probe/remove time")
> Signed-off-by: YueHaibing
Reviewed-by: Kieran Bingham
> ---
> drivers/gpu/drm/shmobile/shmob_drm_drv.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/shmobile/shmob_drm_drv.c
> b/drivers
On 14/12/2018 07:48, Kieran Bingham wrote:
> Hi Hoan-san,
>
> Thank you for the patch,
>
> On 14/12/2018 07:18, Nguyen An Hoan wrote:
>> From: Hoan Nguyen An
>>
>> Add r8a77965 LVDS dts overlay support.
>
>
> There has been a recent change to the form
Hi Hoan-san,
Thank you for the patch,
On 14/12/2018 07:18, Nguyen An Hoan wrote:
> From: Hoan Nguyen An
>
> Add r8a77965 LVDS dts overlay support.
There has been a recent change to the format of how these files are added.
With thanks to Geert's updates, we have a much simpler way to describe
tterhoeven
>> ---
>> The generated dtbs before/after are identical.
>
> I was going to ask whether you had tested the patch, but this should be good
> enough :-)
>
> The result is nicer to read, thanks.
>
I agree!
FWIW:
Reviewed-by: Kieran Bingham
> Revi
nction helps a lot and is readable. The compiler will
likely inline it anyway.
> Signed-off-by: Marek Vasut
Reviewed-by: Kieran Bingham
> Cc: Linus Walleij
> Cc: Bartosz Golaszewski
> ---
> V2: Replace bank_size with bank_shift in commit message
> ---
>
Signed-off-by: Kieran Bingham
---
drivers/media/platform/vsp1/vsp1_wpf.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/media/platform/vsp1/vsp1_wpf.c
b/drivers/media/platform/vsp1/vsp1_wpf.c
index 2e8cc4195c31..207baf0cd75e 100644
--- a/drivers/media/platform/vsp1/vsp1_wpf.c
Hi Jacopo,
On 12/12/2018 08:27, jacopo mondi wrote:
> Hi Kieran,
>
> On Tue, Dec 11, 2018 at 11:43:08PM +0000, Kieran Bingham wrote:
>> Hi Jacopo,
>>
>> On 11/12/2018 15:16, Jacopo Mondi wrote:
>>> When the adv748x driver is informed about a link being create
Hi Jacopo,
On 12/12/2018 08:21, jacopo mondi wrote:
> Hi Kieran,
>
> On Tue, Dec 11, 2018 at 11:07:09PM +0000, Kieran Bingham wrote:
>> Hi Jacopo,
>>
>> Thank you for the patch,
>>
>> On 11/12/2018 15:16, Jacopo Mondi wrote:
>>> The ADV748x chip
Heya
On 12/12/2018 08:16, jacopo mondi wrote:
> Hi Kieran,
>thanks for review
>
> On Tue, Dec 11, 2018 at 11:52:03PM +0000, Kieran Bingham wrote:
>> Hi Jacopo,
>>
>> On 11/12/2018 15:16, Jacopo Mondi wrote:
>>> Re-work the chip reset procedure
Hi Jacopo,
On 11/12/2018 15:16, Jacopo Mondi wrote:
> Re-work the chip reset procedure to configure the CP (HDMI) and SD (AFE) cores
> before resetting the MIPI CSI-2 TXs.
>
> Signed-off-by: Jacopo Mondi
> ---
> drivers/media/i2c/adv748x/adv748x-core.c | 24 ++--
> 1 file ch
Hi Jacopo,
On 11/12/2018 15:16, Jacopo Mondi wrote:
> When the adv748x driver is informed about a link being created from HDMI or
> AFE to a CSI-2 TX output, the 'link_setup()' callback is invoked. Make
> sure to implement proper routing management at link setup time, to route
> the selected video
Hi Jacopo,
On 11/12/2018 15:16, Jacopo Mondi wrote:
> Both the AFE and HDMI s_stream routines (adv748x_afe_s_stream() and
> adv748x_hdmi_s_stream()) have to enable the CSI-2 TX they are streaming video
> data to.
>
> With the introduction of dynamic routing between HDMI and AFE entities to
> TXA,
Hi Jacopo,
On 11/12/2018 15:16, Jacopo Mondi wrote:
> The power_up_tx() procedure needs to set a few registers conditionally to
> the selected video source, but it currently checks for the provided tx to
> be either TXA or TXB.
>
> With the introduction of dynamic routing between HDMI and AFE ent
Hi Jacopo,
Thank you for the patch,
On 11/12/2018 15:16, Jacopo Mondi wrote:
> The ADV748x chip supports routing AFE output to either TXA or TXB.
> In order to support run-time configuration of video stream path, create an
> additional (not enabled) "AFE:8->TXA:0" link, and remove the IMMUTABLE f
ed-off-by: Laurent Pinchart
Reviewed-by: Kieran Bingham
> ---
> drivers/gpu/drm/rcar-du/rcar_dw_hdmi.c | 15 +++
> 1 file changed, 15 insertions(+)
>
> Changes since v1:
>
> - Add a comment to explain where the limit comes from
>
> diff --git a/drivers/gpu/drm
1 - 100 of 1058 matches
Mail list logo
