On Wed, Sep 05, 2012 at 10:11:52AM +0200, Marc Kleine-Budde wrote:
If udc_start() fails the qh_pool dma-pool cannot be closed because
it's still in use. This patch factors out the dma_pool_free() loop
into destroy_eps() and calls it in the error path of udc_start(),
too.
Cc: Richard Zhao
-Original Message-
From: Oliver Neukum [mailto:oneu...@suse.de]
looking at cdc-ncm it seeems to me that cdc-ncm is forced to play very
dirty games because usbnet doesn't have a notion about aggregating
packets for a single transfer.
Several issues need to be improved:
Tx path:
1.
Oliver Neukum oneu...@suse.de writes:
looking at cdc-ncm it seeems to me that cdc-ncm is forced to play
very dirty games because usbnet doesn't have a notion about aggregating
packets for a single transfer.
It seems to me that this can be fixed introducing a method for bundling,
which tells
Ming Lei tom.leim...@gmail.com writes:
On Thu, Sep 6, 2012 at 4:12 AM, Oliver Neukum oneu...@suse.de wrote:
Hi,
looking at cdc-ncm it seeems to me that cdc-ncm is forced to play
very dirty games because usbnet doesn't have a notion about aggregating
packets for a single transfer.
The
On Thursday 06 September 2012 10:13:01 Alexey ORISHKO wrote:
-Original Message-
From: Oliver Neukum [mailto:oneu...@suse.de]
looking at cdc-ncm it seeems to me that cdc-ncm is forced to play very
dirty games because usbnet doesn't have a notion about aggregating
packets for a
On Thu, 2012-09-06 at 10:50 +0200, Oliver Neukum wrote:
On Thursday 06 September 2012 10:13:01 Alexey ORISHKO wrote:
Rx path:
4. IP packets are cloned to separate skb and length of actual data
set to eth packet size, while skb size is still the same as skb
containing full NTB frame. This
On Thu, 2012-09-06 at 11:11 +0200, Eric Dumazet wrote:
Really skb_clone() use should be removed from cdc_ncm_rx_fixup()
Unless you expect 10Gbit speed from this driver, skb_clone() is the
worst possible strategy.
Allocating fresh skbs of the right size permits better memory use and
On Tue, Sep 4, 2012 at 5:32 PM, Alon Bar-Lev alon.bar...@gmail.com wrote:
Going to try out this one[1][2], but now I go to the store and test it
on site before buying.
Alon
[1] http://a.slickdeals.net/attachment.php?attachmentid=84784d=...
[2]
Almost all of usbip assumes that the_controller-lock is acquired
before vdev-priv_lock. The exception is in
vhci_device_unlink_cleanup(), where locks are acquired in the
reverse order. This leads to occasional deadlocks.
Fixing this is a bit fiddly, as the_controller-lock can't be held
when
USB autosuspend suspends vhci_hcd. In this process hcd_bus_suspend gets
executed which puts vhci_hcd in suspend state and calls vhci_hub_status.
vhci_hub_status function checks hub state and if it is in suspend state,
usb_hcd_resume_root_hub gets executed which resumes hub
and if hub is idle,
Hi,
On Mon, Aug 6, 2012 at 6:37 PM, Kishon Vijay Abraham I kis...@ti.com wrote:
All phy related programming like enabling/disabling the clocks, powering
on/off the phy is taken care of by this driver. It is also used for OTG
related functionality like srp.
This also includes device tree
Marc Kleine-Budde m...@pengutronix.de writes:
From: Michael Grzeschik m.grzesc...@pengutronix.de
This patch changes the setup of the endpoint maxpacket size. All non control
endpoints are initialized with an undefined ((unsigned short)~0) maxpacket
size. The maxpacket size of Endpoint 0 will
Marc Kleine-Budde m...@pengutronix.de writes:
From: Michael Grzeschik m.grzesc...@pengutronix.de
Add function to physicaly enable or disable of pullup connection on the USB-D+
line. The uvc gaget will fail, if this function is not implemented.
Signed-off-by: Michael Grzeschik
Marc Kleine-Budde m...@pengutronix.de writes:
This patch fixes the error path of udc_start(). Now NULL is used to
unset the peripheral with otg_set_peripheral().
Signed-off-by: Marc Kleine-Budde m...@pengutronix.de
Reviewed-by: Richard Zhao richard.z...@freescale.com
Acked-by: Alexander
On 09/06/2012 02:26 PM, Alexander Shishkin wrote:
Marc Kleine-Budde m...@pengutronix.de writes:
From: Michael Grzeschik m.grzesc...@pengutronix.de
Add function to physicaly enable or disable of pullup connection on the
USB-D+
line. The uvc gaget will fail, if this function is not
Marc Kleine-Budde m...@pengutronix.de writes:
If udc_start() fails the qh_pool dma-pool cannot be closed because
it's still in use. This patch factors out the dma_pool_free() loop
into destroy_eps() and calls it in the error path of udc_start(),
too.
Cc: Richard Zhao
Hello,
these patches apply to Richard's usb-driver branch [1] and prepare the usbmisc
driver for multi-soc support.
Feel free to squash into your patches, or add to your tree.
regards,
Marc
[1] https://github.com/riczhao/kernel-imx/tree/topics/usb-driver
--
To unsubscribe from this list:
While there fix a potential race condition, first set usbmisc, then call
usbmisc_set_ops().
Signed-off-by: Marc Kleine-Budde m...@pengutronix.de
---
drivers/usb/chipidea/usbmisc_imx6q.c |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git
Signed-off-by: Marc Kleine-Budde m...@pengutronix.de
---
drivers/usb/chipidea/usbmisc_imx6q.c |9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/chipidea/usbmisc_imx6q.c
b/drivers/usb/chipidea/usbmisc_imx6q.c
index edc0edd7..5989a80 100644
---
On 09/06/2012 02:37 PM, Marc Kleine-Budde wrote:
Signed-off-by: Marc Kleine-Budde m...@pengutronix.de
---
drivers/usb/chipidea/usbmisc_imx6q.c |9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/chipidea/usbmisc_imx6q.c
Marc Kleine-Budde m...@pengutronix.de writes:
From: Michael Grzeschik m.grzesc...@pengutronix.de
When attaching an imx28 or imx53 in USB gadget mode to a Windows host and
starting a rndis connection we see this message every 4-10 seconds:
g_ether gadget: high speed config #2: RNDIS
On 09/06/2012 02:46 PM, Alexander Shishkin wrote:
Marc Kleine-Budde m...@pengutronix.de writes:
From: Michael Grzeschik m.grzesc...@pengutronix.de
When attaching an imx28 or imx53 in USB gadget mode to a Windows host and
starting a rndis connection we see this message every 4-10 seconds:
I sent this email a year ago when the patch was committed but I
never received a response.
regards,
dan carpenter
On Wed, Nov 09, 2011 at 10:34:59AM +0300, Dan Carpenter wrote:
Hello Konstantin Khlebnikov,
This is a semi-automatic email about new static checker warnings.
The patch
Hello,
we developing CDC/NCM firmware and found that the Linux CDC/NCM is not
compliant to the USB CDC/NCM specification. The cause is a Bug in the
cdc_ncm.c file.
The structure usb_cdc_ncm_ndp_input_size is only allocated but not
initialized. The CDC/NCM specification section 6.2.7
Marc Kleine-Budde m...@pengutronix.de writes:
On 09/06/2012 02:26 PM, Alexander Shishkin wrote:
Marc Kleine-Budde m...@pengutronix.de writes:
From: Michael Grzeschik m.grzesc...@pengutronix.de
Add function to physicaly enable or disable of pullup connection on the
USB-D+
line. The uvc
On Thursday 06 September 2012, ABRAHAM, KISHON VIJAY wrote:
diff --git a/Documentation/devicetree/bindings/bus/omap-ocp2scp.txt
b/Documentation/devicetree/bindings/bus/omap-ocp2scp.txt
index d2fe064..bb0c7f4 100644
--- a/Documentation/devicetree/bindings/bus/omap-ocp2scp.txt
+++
On Wed, Sep 05, 2012 at 04:49:37PM -0700, Greg KH wrote:
On Thu, Aug 23, 2012 at 12:03:58PM +0300, Felipe Balbi wrote:
Hi Greg,
Here's my (hopefully) last set of fixes for v3.6-rc cycle. Let me know if
you
want me to change anything and I'll do so ASAP.
cheers
The following
Greg KH gre...@linuxfoundation.org writes:
On Fri, Aug 24, 2012 at 10:09:11AM +0800, Richard Zhao wrote:
On Thu, Aug 23, 2012 at 06:57:03PM +0200, Marc Kleine-Budde wrote:
Hello,
Michael and I have a bunch of updates and improvement for the chipidea
driver. They apply to Richard's
On Thu, Sep 06, 2012 at 05:01:46PM +0300, Pantelis Antoniou wrote:
Marking functions as __init or __devinit and calling them at other times
leads to predictable crashes (if you're lucky).
Remove them for now.
Signed-off-by: Pantelis Antoniou pa...@antoniou-consulting.com
---
On Wed, Sep 05, 2012 at 02:23:30PM -0700, Sarah Sharp wrote:
On Tue, Aug 21, 2012 at 08:16:10PM +0800, Andiry Xu wrote:
Just have one question - how do you add suspend/resume support for
DWC USB 3 controller? Where can I find the source code?
Is it reusing the suspend/resume code of
On Thursday 06 September 2012 05:52:30 Dan Carpenter wrote:
I sent this email a year ago when the patch was committed but I
never received a response.
I probably should have checked then.
regards,
dan carpenter
On Wed, Nov 09, 2011 at 10:34:59AM +0300, Dan Carpenter wrote:
Hello
On 09/06/2012 03:05 PM, Alexander Shishkin wrote:
Greg KH gre...@linuxfoundation.org writes:
On Fri, Aug 24, 2012 at 10:09:11AM +0800, Richard Zhao wrote:
On Thu, Aug 23, 2012 at 06:57:03PM +0200, Marc Kleine-Budde wrote:
Hello,
Michael and I have a bunch of updates and improvement for the
Hi,
On Wed, Sep 05, 2012 at 12:31:50PM -0700, Sarah Sharp wrote:
On Wed, Sep 05, 2012 at 08:34:26AM +0300, Felipe Balbi wrote:
From: Moiz Sonasath m-sonas...@ti.com
For non PCI-based stacks, this function call
usb_disable_xhci_ports(to_pci_dev(hcd-self.controller));
made from
On Thu, Sep 06, 2012 at 01:03:02PM +, Arnd Bergmann wrote:
On Thursday 06 September 2012, ABRAHAM, KISHON VIJAY wrote:
diff --git a/Documentation/devicetree/bindings/bus/omap-ocp2scp.txt
b/Documentation/devicetree/bindings/bus/omap-ocp2scp.txt
index d2fe064..bb0c7f4 100644
---
On Wed, Sep 05, 2012 at 02:10:39AM +, Chen Peter-B29397 wrote:
Because the fsl_udc_core driver shares one 'status_req' object for the
complete ep0 control transfer, it is not possible to prime the final
STATUS phase immediately after the IN transaction. E.g. ch9getstatus()
On Thu, Sep 6, 2012 at 2:35 PM, Frank Hoffmann
frank.hoffm...@thesycon.de wrote:
I'm not sure if it is also required to initialize the wNtbInMaxDatagrams
field because 0 (no limit) is a valid value.
It is not required. The limit was removed in one of the patches earlier.
/alexey
--
To
On Thu, Sep 06, 2012 at 03:15:10PM +0200, Marc Kleine-Budde wrote:
On 09/06/2012 03:05 PM, Alexander Shishkin wrote:
Greg KH gre...@linuxfoundation.org writes:
On Fri, Aug 24, 2012 at 10:09:11AM +0800, Richard Zhao wrote:
On Thu, Aug 23, 2012 at 06:57:03PM +0200, Marc Kleine-Budde wrote:
On 09/06/2012 12:02 AM, Sarah Sharp wrote:
I'm actually wondering if you're hitting a bug that is fixed by a patch
in my queue to send to Greg. Apparently, some BIOSes expect specific
USB ports on the mobile Panther Point chipset to remain under the EHCI
controller, even though they can be
On 09/06/2012 04:02 PM, Greg KH wrote:
Indeed there's a pile of patches, I'm going through them right now, Marc
already has my acks. We should probably agree if I should collect them
all before sending to you or if guys can send them to you directly (as
soon as we agree on acks).
The fixes
Felipe Balbi ba...@ti.com writes:
Because the fsl_udc_core driver shares one 'status_req' object for the
complete ep0 control transfer, it is not possible to prime the final
STATUS phase immediately after the IN transaction. E.g. ch9getstatus()
executed:
| req = udc-status_req;
|
Hi,
On Thu, Sep 06, 2012 at 04:27:12PM +0200, Enrico Scholz wrote:
Felipe Balbi ba...@ti.com writes:
Because the fsl_udc_core driver shares one 'status_req' object for the
complete ep0 control transfer, it is not possible to prime the final
STATUS phase immediately after the IN
Chen Peter-B29397 b29...@freescale.com writes:
If the class driver has already mapped this address, the req-req.dma is not
DMA_ADDR_INVALID either, in this case, the dma_sync_single_for_cpu is
enough.
ok; forget the patch then.
Thanks
Enrico
--
To unsubscribe from this list: send the line
On Tue, Sep 04, 2012 at 09:32:06PM +0200, Marc Kleine-Budde wrote:
On 09/04/2012 07:51 PM, ABRAHAM, KISHON VIJAY wrote:
Since it's already a common function, we may give phandler
property
a common name too. So we will not need phandle argument.
Please also don't forget to document the
On Thu, Aug 30, 2012 at 08:04:04PM +0200, Marek Vasut wrote:
Dear Fabio Estevam,
Hi Marek,
On Thu, Aug 30, 2012 at 12:20 PM, Marek Vasut ma...@denx.de wrote:
+#define MXY_PHY_ENHOSTDISCONDETECT_DELAY 250
+
Why 250 what unit? ? :)
It is 250 ms. We found this one to
On Thu, Sep 06, 2012 at 04:32:28PM +0200, Enrico Scholz wrote:
Chen Peter-B29397 b29...@freescale.com writes:
If the class driver has already mapped this address, the req-req.dma is not
DMA_ADDR_INVALID either, in this case, the dma_sync_single_for_cpu is
enough.
ok; forget the patch
On Thu, Sep 06, 2012 at 05:30:02PM +0300, Felipe Balbi wrote:
On Tue, Sep 04, 2012 at 09:32:06PM +0200, Marc Kleine-Budde wrote:
On 09/04/2012 07:51 PM, ABRAHAM, KISHON VIJAY wrote:
Since it's already a common function, we may give phandler
property
a common name too. So we will not
Hi,
We should at least add Grant to the loop, I guess.
On Thu, Sep 06, 2012 at 10:46:13PM +0800, Richard Zhao wrote:
On Thu, Sep 06, 2012 at 05:30:02PM +0300, Felipe Balbi wrote:
On Tue, Sep 04, 2012 at 09:32:06PM +0200, Marc Kleine-Budde wrote:
On 09/04/2012 07:51 PM, ABRAHAM, KISHON
This patch series adds device tree support for MUSB.
The glue layer is now made to write to mailbox register (present in
control module) instead of calling phy layer to write to mailbox
register. Writing to mailbox register notifies the core of events like
device connect/disconnect.
Previously
The glue layer should directly write to mailbox register (present in
control module) instead of calling phy layer to write to mailbox
register. Writing to mailbox register notifies the core of events like
device connect/disconnect.
Currently writing to control module register is taken care in
All the PHY configuration other than VBUS, ID GND and OTG SRP are removed
from twl6030. The phy configurations are taken care by the dedicated
usb2 phy driver. So twl6030 is made as comparator driver for VBUS and
ID detection.
Signed-off-by: Kishon Vijay Abraham I kis...@ti.com
---
Hi Felipe,
A proper answer required some instrumentation printks().
So what I did is that I peppered each function marked with a removed
__init or __devinit with a
printk(KERN_INFO %s:%d (%s) %s\n, __FILE__, __LINE__, KBUILD_MODNAME,
__func__);
Both omap2430 musb_hdrc are compiled as
All phy related programming like enabling/disabling the clocks, powering
on/off the phy is taken care of by this driver. It is also used for OTG
related functionality like srp.
This also includes device tree support for usb2 phy driver and
the documentation with device tree binding information is
The mailbox register for usb otg in omap is present in control module.
On detection of any events VBUS or ID, this register should be written
to send the notification to musb core.
Till we have a separate control module driver to write to control module,
omap2430 will handle the register writes
This patch series adds device tree support for phy's (twl4030 and twl6030).
A new omap-usb2 phy driver has been added (with only dt suppport)
to perform phy configurations. Previously this configuration was
performed by twl6030, using pdata function pointers.
With the addition of omap-usb2 to
Added device tree support for omap musb driver and updated the
Documentation with device tree binding information.
Signed-off-by: Kishon Vijay Abraham I kis...@ti.com
---
Documentation/devicetree/bindings/usb/omap-usb.txt | 33
drivers/usb/musb/omap2430.c|
Hi Felipe,
On Thu, Sep 6, 2012 at 11:30 AM, Felipe Balbi ba...@ti.com wrote:
I need a final version for this series or it won't make it into v3.7
I sent a v2 for this last week:
http://www.spinics.net/lists/linux-usb/msg69955.html
Thanks,
Fabio Estevam
--
To unsubscribe from this list: send
Hi Marc,
Thanks for your patch. It's good.
Richard
On Thu, Sep 06, 2012 at 02:37:58PM +0200, Marc Kleine-Budde wrote:
While there fix a potential race condition, first set usbmisc, then call
usbmisc_set_ops().
Signed-off-by: Marc Kleine-Budde m...@pengutronix.de
---
On 09/06/2012 05:11 PM, Richard Zhao wrote:
Hi Marc,
Thanks for your patch. It's good.
Please include or squash in your tree.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions| Phone: +49-231-2826-924 |
Vertretung West/Dortmund
Hi Marc,
usbmisc_imx6q.c is only for imx6x. And for a certain running kernel,
there will be always one driver instance.
Thanks
Richard
On Thu, Sep 06, 2012 at 02:37:59PM +0200, Marc Kleine-Budde wrote:
Signed-off-by: Marc Kleine-Budde m...@pengutronix.de
---
On Thu, Sep 06, 2012 at 04:09:58PM +0200, Marc Kleine-Budde wrote:
On 09/06/2012 04:02 PM, Greg KH wrote:
Indeed there's a pile of patches, I'm going through them right now, Marc
already has my acks. We should probably agree if I should collect them
all before sending to you or if guys can
On 09/06/2012 04:46 PM, Felipe Balbi wrote:
Hi,
We should at least add Grant to the loop, I guess.
On Thu, Sep 06, 2012 at 10:46:13PM +0800, Richard Zhao wrote:
On Thu, Sep 06, 2012 at 05:30:02PM +0300, Felipe Balbi wrote:
On Tue, Sep 04, 2012 at 09:32:06PM +0200, Marc Kleine-Budde wrote:
On 9/6/2012 8:25 PM, Kishon Vijay Abraham I wrote:
The mailbox register for usb otg in omap is present in control module.
On detection of any events VBUS or ID, this register should be written
to send the notification to musb core.
Till we have a separate control module driver to write to
On Thu, Sep 06, 2012 at 03:59:48PM +0300, Felipe Balbi wrote:
On Wed, Sep 05, 2012 at 04:49:37PM -0700, Greg KH wrote:
On Thu, Aug 23, 2012 at 12:03:58PM +0300, Felipe Balbi wrote:
Hi Greg,
Here's my (hopefully) last set of fixes for v3.6-rc cycle. Let me know if
you
want me to
On Thu, Sep 6, 2012 at 4:30 PM, Bjørn Mork bj...@mork.no wrote:
Ming Lei tom.leim...@gmail.com writes:
On Thu, Sep 6, 2012 at 4:12 AM, Oliver Neukum oneu...@suse.de wrote:
Hi,
looking at cdc-ncm it seeems to me that cdc-ncm is forced to play
very dirty games because usbnet doesn't have a
From: Peter Senna Tschudin peter.se...@gmail.com
removes unnecessary semicolon
Found by Coccinelle: http://coccinelle.lip6.fr/
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
drivers/net/usb/sierra_net.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -u -p
On Thu, Sep 06, 2012 at 02:00:16AM +, Liu, Chuansheng wrote:
Because the IRQF_DISABLED as the flag is now a NOOP and has been
deprecated and in hardirq context the interrupt is disabled.
so in usb/host code:
Removing the usage of flag IRQF_DISABLED;
Removing the calling local_irq
Hi,
To enable usb autosuspend i use the following in a script after booting:
for i in `find /sys/bus/usb/devices/*/power/control`; do echo auto $i; done;
for i in `find /sys/bus/usb/devices/*/power/autosuspend`; do echo 2 $i; done;
After this new usb devices aren't recognized anymore. Whether
Resending patch with latest kernel code:
In xhci-ring.c, function inc_enq and inc_deq calculate the dma address
of trb but never used.
Signed-off-by: Girish Verma gir...@circuitsutra.com
---
drivers/usb/host/xhci-ring.c |4
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git
Hi Greg,
Here's my previous pull request now rebased on top of v3.6-rc4. Sorry
for the inconvenience my never rebase methodology :-)
Note that I'm rebased on top of v3.6-rc4, so you should probably merge
that tag on your tree.
After merging v3.6-rc4 on your tree, you can merge my tag and you
Hi,
On Thu, Sep 06, 2012 at 05:58:27PM +0300, Pantelis Antoniou wrote:
Hi Felipe,
A proper answer required some instrumentation printks().
So what I did is that I peppered each function marked with a removed
__init or __devinit with a
printk(KERN_INFO %s:%d (%s) %s\n, __FILE__,
Hi,
On Thu, Sep 06, 2012 at 09:04:58PM +0530, Vaibhav Hiremath wrote:
On 9/6/2012 8:25 PM, Kishon Vijay Abraham I wrote:
The mailbox register for usb otg in omap is present in control module.
On detection of any events VBUS or ID, this register should be written
to send the
Hi,
On Thu, Sep 06, 2012 at 08:13:03PM +0300, Felipe Balbi wrote:
Hi,
On Thu, Sep 06, 2012 at 09:04:58PM +0530, Vaibhav Hiremath wrote:
On 9/6/2012 8:25 PM, Kishon Vijay Abraham I wrote:
The mailbox register for usb otg in omap is present in control module.
On detection of any
On Thu, 6 Sep 2012, Pavan Kondeti wrote:
Hi
I am debugging EHCI host system error (4.15.2.4) issue. The issue
happens during unlinking of URB from an interface driver. In our system
the device is always connected to the host. some interfaces are always
active (I/O can happen). Other
On Thu, 6 Sep 2012, Florian Merz wrote:
Hi,
To enable usb autosuspend i use the following in a script after booting:
for i in `find /sys/bus/usb/devices/*/power/control`; do echo auto $i; done;
for i in `find /sys/bus/usb/devices/*/power/autosuspend`; do echo 2 $i;
done;
After this
Hi Felipe
I see about __devinit.
There's no crash because in those logs the __init modifiers are gone.
Regards
-- Pantelis
On Sep 6, 2012, at 8:07 PM, Felipe Balbi wrote:
Hi,
On Thu, Sep 06, 2012 at 05:58:27PM +0300, Pantelis Antoniou wrote:
Hi Felipe,
A proper answer required some
Hi,
On Thu, Sep 06, 2012 at 08:36:39PM +0300, Pantelis Antoniou wrote:
Hi Felipe
I see about __devinit.
There's no crash because in those logs the __init modifiers are gone.
it'd be cool to see the crash, though ;-)
--
balbi
signature.asc
Description: Digital signature
On Sep 6, 2012, at 8:37 PM, Felipe Balbi wrote:
Hi,
On Thu, Sep 06, 2012 at 08:36:39PM +0300, Pantelis Antoniou wrote:
Hi Felipe
I see about __devinit.
There's no crash because in those logs the __init modifiers are gone.
it'd be cool to see the crash, though ;-)
--
balbi
Heh,
On Fri, Aug 31, 2012 at 01:39:21PM +0200, Andrzej Pietrasiewicz wrote:
We need a configurable composite gadget in the Tizen platform to
provide sdbd connectivity and mass storage function at the same time.
Your argument is pointless because sdbd is not supported by ccg at this
time. You could
Hi,
On Thu, Sep 06, 2012 at 08:42:56PM +0300, Pantelis Antoniou wrote:
On Sep 6, 2012, at 8:37 PM, Felipe Balbi wrote:
Hi,
On Thu, Sep 06, 2012 at 08:36:39PM +0300, Pantelis Antoniou wrote:
Hi Felipe
I see about __devinit.
There's no crash because in those logs the __init
On Friday 07 September 2012 00:09:13 Ming Lei wrote:
On Thu, Sep 6, 2012 at 4:30 PM, Bjørn Mork bj...@mork.no wrote:
Ming Lei tom.leim...@gmail.com writes:
Looks the introduced .tx_bundle is not necessary since .tx_fixup is OK.
The minidriver does not have any information about tx in
This is a rebase respin of the complete two stage series on top of
current linus/greg/felipe trees.
Patch #1 is new, it adds a note about compatibility issues around ccg
in staging.
The first few patches still touch ccg because I had to change central
gadget code and there was no other sane way.
This Android gadget includes a bunch of .c files. Fixing normal gadgets
is not the real problem but this gadget is not always fixable since the
problem here are fundumential / design.
*I* wanted to get this removed but other people want to keep it even
though there were reports that Android
As it turns out, Sam's comment was better than I initially assumed. This
patch pushes as struct usb_composite_driver data structures into
__refdata section to avoid a section missmatch report from modpost
because the -bind() can be marked __init. The only downside is that
modpost does not check
This patch removes the global variable composite in composite.c.
The private data which was saved there is now passed via an additional
argument to the bind() function in struct usb_gadget_driver.
Only the old-style UDC drivers have to be touched here, new style are
doing it right because this
The first item on the todo list is a new user interface. Put this
information into Kconfig's help entry to people are not too confusing
once an user API changes which does not happen in kernel otherwise.
Cc: de...@driverdev.osuosl.org
Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de
|drivers/usb/gadget/pxa25x_udc.h: In function 'dump_state':
|drivers/usb/gadget/pxa25x_udc.h:228:20: error: invalid type argument of '-'
(have 'struct usb_ep')
Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de
---
drivers/usb/gadget/pxa25x_udc.h |2 +-
1 file changed, 1
This patch adds epautoconf.c into libcomposite and updates all gadgets.
Acked-by: Michal Nazarewicz min...@mina86.com
Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de
---
drivers/usb/gadget/Makefile |2 +-
drivers/usb/gadget/acm_ms.c |1 -
This patch moves USB_BUFSIZ into global header file as
USB_COMP_EP0_BUFSIZ. There is currently only one user (f_sourcesink)
besides composite which need it. Ideally f_sourcesink would have its
own ep0 buffer. Lets keep it that way it was for now.
Acked-by: Michal Nazarewicz min...@mina86.com
This patch pushes the iSerialNumber module argument from composite into
each gadget. Once the user uses the module paramter, the string is
overwritten with the final value.
Acked-by: Michal Nazarewicz min...@mina86.com
Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de
---
epautoconf has two global variables which count the endpoint number of
last assigned endpoint.
This patch removes the global variable and keeps it as per (UDC) gadget.
While here, the ifdef is removed and now the in and outpoint are
enumerated unconditionally. The dwc3 for instance supports 32
This patch pushes the iManufacturer module argument from composite into
each gadget. Once the user uses the module paramter, the string is
overwritten with the final value.
Acked-by: Michal Nazarewicz min...@mina86.com
Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de
---
This moves composite.c into libcomposite and updates all gadgets.
Finally!
Acked-by: Michal Nazarewicz min...@mina86.com
Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de
---
drivers/usb/gadget/Makefile |3 ++-
drivers/usb/gadget/acm_ms.c |2 +-
The index in usb_string array is defined by the gadget. The gadget can
choose which index entry it assigns for the serial number and which the
product name. The gadget has just to ensure that the descriptor contains
the proper string id which is assigned by composite.
If the composite layer knows
MODULE_VERSION and AUTHOR looks better in composite.c than in
usbstrings.c so I move it there.
I put David Brownell as the module Author as I belive he wrote most of
it.
Acked-by: Michal Nazarewicz min...@mina86.com
Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de
---
Some gadgets provide custom entry here. Some may override it with an
etntry that is also created by composite if there was no value sumbitted
at all.
This patch removes all custom manufacturer strings which are the same
as these which are created by composite. Then it moves the creation of
the
there is no read user of bufsiz, its content is available via
USB_COMP_EP0_BUFSIZ. Remove it.
Acked-by: Michal Nazarewicz min...@mina86.com
Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de
---
drivers/usb/gadget/composite.c |1 -
include/linux/usb/composite.h |2 --
2
The struct usb_composite_driver members iProduct, iSerial and
iManufacturer can be entered directly via the string array. There is no
need for them to appear here.
Acked-by: Michal Nazarewicz min...@mina86.com
Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de
---
Using usb_string_ids_tab() instead multiple calls of usb_string_id()
seems to be handy. It also allows to add string without many checks.
Acked-by: Michal Nazarewicz min...@mina86.com
Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de
---
drivers/usb/gadget/acm_ms.c | 12
This patch pushes the iProduct module argument from composite
into each gadget.
Acked-by: Michal Nazarewicz min...@mina86.com
Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de
---
drivers/usb/gadget/composite.c | 21 +++--
include/linux/usb/composite.h |6
I have no idea what I've been thinking while I was doing this in the first
place. Now the strings are initialized properly and reported by lsusb.
Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de
---
drivers/usb/gadget/tcm_usb_gadget.c | 33 -
1 - 100 of 119 matches
Mail list logo
