Hi Greg,
On Wednesday 21 August 2013 11:16 AM, Kishon Vijay Abraham I wrote:
Added a generic PHY framework that provides a set of APIs for the PHY drivers
to create/destroy a PHY and APIs for the PHY users to obtain a reference to
the PHY with or without using phandle.
This framework will
On Friday 02 August 2013 at 21:24:05, Sebastian Andrzej Siewior wrote:
Hi,
this series depends on Felipe's master tree and usb: phy:
rename nop_usb_xceiv = usb_phy_gen_xceiv which I posted earlier. I
created a -rc3 based branch for that patch [0]. If you fine with this
please let Tony know.
On Tue, Aug 20, 2013 at 06:35:53PM +0200, Sebastian Andrzej Siewior wrote:
With enabled pm_runtime in the kernel the device won't work because it
is not on during the probe function. This patch enables the device via
pm_runtime on probe so it remains activated.
Cc: Vinod Koul
On 08/23/2013 05:07 PM, Alan Stern wrote:
On Fri, 23 Aug 2013, Xenia Ragiadakou wrote:
Martin is right; the BOS descriptors are leaked in
usb_reset_and_verify_device(). We need to store the old descriptor,
compare it with the new one following the reset, and delete one of them
afterward. I
Hi Bharat,
On 08/26/2013 02:29 PM, Bharathraj Nagaraju wrote:
Dear All,
With continuation to below mail, our client requirement is pushing us to
implement the EHCI runtime suspend/resume.
I have implemented EHCI runtime suspend/resume using timer concept,Please
find the below design
On Mon, Aug 26, 2013 at 12:46:03PM +0300, Meelis Roos wrote:
Tried 3.11-rc7 and got this compile failure on a couple of hosts where
-rc6 worked. config is below.
This commit seems to break it:
On Sun, 18 Aug 2013, Ming Lei wrote:
Complete() will be run with interrupt enabled, so change to
spin_lock_irqsave().
Cc: Jiri Kosina jkos...@suse.cz
Cc: linux-in...@vger.kernel.org
Signed-off-by: Ming Lei ming@canonical.com
Acked-by: Jiri Kosina jkos...@suse.cz
---
xhci maintains a radix tree for each stream endpoint because it must
be able to map a trb address to the stream ring. Each ring segment
must be added to the ring for this to work. Currently xhci sticks
only the first segment of each stream ring into the radix tree.
Result is that things work
On 08/26/2013 02:29 PM, Bharathraj Nagaraju wrote:
Dear All,
With continuation to below mail, our client requirement is pushing us to
implement the EHCI runtime suspend/resume.
I have implemented EHCI runtime suspend/resume using timer concept,Please
find the below design and attached
On Sat, 2013-08-17 at 18:05 -0400, Peter Hyman wrote:
On 08/17/2013 04:58 PM, Forest Bond wrote:
snip...
Okay, I published it here:
http://www.alittletooquiet.net/media/2131024%20CDMA%20EVDO%20CnS%20Reference.pdf
For the record, the document states its license as follows:
Commit 9a11899c5e69 (USB: OHCI: add missing PCI PM callbacks to
ohci-pci.c) added missing ohci_suspend and ohci_resume callback
pointers, but forgot that these callbacks are declared and defined
only when CONFIG_PM is enabled.
This patch adds a preprocessor conditional to avoid build errors when
On Mon, 26 Aug 2013, Xenia Ragiadakou wrote:
I will send a patch as RFC because i am not quite familiar and because i
have a problem to run kmemleak effectively (i can only scan for a few
seconds, although i have set all necessary kmemleak configuration, i
have not figured out why yet).
omap-control device is present from OMAP4 onwards which
support device tree boots only. So get rid of platform data.
Signed-off-by: Roger Quadros rog...@ti.com
---
drivers/usb/phy/phy-omap-control.c | 12 +++-
include/linux/usb/omap_control_usb.h |4
2 files changed, 3
Add support for new device types and in the process rid of ti,type
device tree property. The correct type of device will be determined
from the compatible string instead.
Introduce a compatible string for each device type. At the moment
we support 4 types Mailbox, USB2, USB3 and DRA7.
Update DT
Split otghs_ctrl and USB2 PHY power down into separate
omap-control-usb nodes. Get rid of ti,type property.
Also get rid of ti,has-mailbox property from usb_otg_hs
node and provide the ctrl-module phandle.
CC: Benoit Cousson bcous...@baylibre.com
Signed-off-by: Roger Quadros rog...@ti.com
---
Split USB2 PHY and USB3 PHY into separate omap-control-usb
nodes. Get rid of ti,type property.
CC: Benoit Cousson bcous...@baylibre.com
Signed-off-by: Roger Quadros rog...@ti.com
---
arch/arm/boot/dts/omap5.dtsi | 20
1 files changed, 12 insertions(+), 8 deletions(-)
diff
omap_get_control_dev() is being deprecated as it doesn't support
multiple instances. As control device is present only from OMAP4
onwards which supports DT only, we use phandles to get the
reference to the control device.
Also get rid of ti,has-mailbox property as it is redundant and
we can
On 22.08.2013 17:22, Florian Echtler wrote:
On 22.08.2013 16:49, Alan Stern wrote:
On Thu, 22 Aug 2013, Florian Echtler wrote:
Userspace version:
// for control commands
usb_control_msg(handle, 0xC0, cmd, 0x00, index, (char*)buf, len, 1000);
Kernel version:
// for control commands
#define
In usb_reset_and_verify_device(), hub_port_init() allocates a new bos
descriptor to hold the value read by the device. The new bos descriptor
has to be compared with the old one in order to figure out if device 's
firmware has changed in which case the device has to be reenumerated.
In the
omap_get_control_dev() is being deprecated as it doesn't support
multiple instances. As control device is present only from OMAP4
onwards which supports DT only, we use phandles to get the
reference to the control device.
As we don't support non-DT boot, we just bail out on probe
if device node
David and Paul:
Here's a question that doesn't seem to be answered in
Documentation/memory-barriers.txt. Are memory accesses within an
interrupt handler synchronized with respect to interrupts?
In more detail, suppose we have an interrupt handler that uses a memory
variable A. The device
This function was preventing us from supporting multiple
instances. Get rid of it. Since we support DT boots only,
users can get the control device phandle from the DT node.
Signed-off-by: Roger Quadros rog...@ti.com
---
drivers/usb/phy/phy-omap-control.c | 31 ++-
Hi,
This patchset does the following:
* Get rid of omap_control_usb platform data as we support DT only.
* Restructure and add support for new PHY types. We now support the follwing
four types
TYPE_OMAP - if it has otghs_control mailbox register (e.g. on OMAP4)
TYPE_USB2 - if it has Power
On Mon, 26 Aug 2013, Xenia Ragiadakou wrote:
In usb_reset_and_verify_device(), hub_port_init() allocates a new bos
descriptor to hold the value read by the device. The new bos descriptor
has to be compared with the old one in order to figure out if device 's
firmware has changed in which case
On Mon, 26 Aug 2013, Ming Lei wrote:
On Sat, 24 Aug 2013, Ming Lei wrote:
But the current interrupt from EHCI isn't be acked(USBSTS isn't cleared),
so EHCI HW don't know the irq has been handled, then it is reasonable
that the EHCI interrupt still interrupts CPU.
EHCI spec(4.15)
omap_get_control_dev() is being deprecated as it doesn't support
multiple instances. As control device is present only from OMAP4
onwards which supports DT only, we use phandles to get the
reference to the control device.
As we don't support non-DT boot, we just bail out on probe
if device node
On Mon, Aug 26, 2013 at 08:38:40AM -0700, Greg Kroah-Hartman wrote:
On Mon, Aug 26, 2013 at 10:53:53AM -0400, Alan Stern wrote:
Commit 9a11899c5e69 (USB: OHCI: add missing PCI PM callbacks to
ohci-pci.c) added missing ohci_suspend and ohci_resume callback
pointers, but forgot that these
On Friday, August 23, 2013 at 2:49 PM, Jiri Kosina wrote:
On Fri, 23 Aug 2013, Benjamin Tissoires wrote:
IIRC, Jiri fixed some paging requests with the two following patches:
Dear Peter,
On 08/12/2013 03:22 AM, Peter Chen wrote:
This patchset adds tested otg id switch function and vbus connect
and disconnect detection for chipidea driver. And fix kinds of
bugs found at chipidea drivers after enabling id and vbus detection.
This patch are fully tested at imx6
Commit 9a11899c5e699a8d USB: OHCI: add missing PCI PM callbacks to
ohci-pci.c Introduced the following compilation errors when power
management is disabled:
drivers/usb/host/ohci-pci.c: In function 'ohci_pci_init':
drivers/usb/host/ohci-pci.c:309:35: error: 'ohci_suspend' undeclared (first use
On Mon, Aug 26, 2013 at 11:35:14AM -0500, Shawn Bohrer wrote:
Commit 9a11899c5e699a8d USB: OHCI: add missing PCI PM callbacks to
ohci-pci.c Introduced the following compilation errors when power
management is disabled:
drivers/usb/host/ohci-pci.c: In function 'ohci_pci_init':
On Mon, 26 Aug 2013, Shawn Bohrer wrote:
Commit 9a11899c5e699a8d USB: OHCI: add missing PCI PM callbacks to
ohci-pci.c Introduced the following compilation errors when power
management is disabled:
drivers/usb/host/ohci-pci.c: In function 'ohci_pci_init':
On Mon, Aug 26, 2013 at 09:06:27AM -0700, Guenter Roeck wrote:
On Mon, Aug 26, 2013 at 08:38:40AM -0700, Greg Kroah-Hartman wrote:
On Mon, Aug 26, 2013 at 10:53:53AM -0400, Alan Stern wrote:
Commit 9a11899c5e69 (USB: OHCI: add missing PCI PM callbacks to
ohci-pci.c) added missing
In usb_reset_and_verify_device(), hub_port_init() allocates a new bos
descriptor to hold the value read by the device. The new bos descriptor
has to be compared with the old one in order to figure out if device 's
firmware has changed in which case the device has to be reenumerated.
In the
On Mon, Aug 26, 2013 at 09:50:22AM -0700, Greg Kroah-Hartman wrote:
On Mon, Aug 26, 2013 at 09:06:27AM -0700, Guenter Roeck wrote:
On Mon, Aug 26, 2013 at 08:38:40AM -0700, Greg Kroah-Hartman wrote:
On Mon, Aug 26, 2013 at 10:53:53AM -0400, Alan Stern wrote:
Commit 9a11899c5e69 (USB:
On Thu, Aug 22, 2013 at 02:55:07PM -0700, Greg KH wrote:
On Thu, Aug 22, 2013 at 02:49:07PM -0700, Sarah Sharp wrote:
On Thu, Aug 22, 2013 at 10:42:49AM -0400, Alan Stern wrote:
On Wed, 21 Aug 2013, Sarah Sharp wrote:
Possible fixes
--
The USB core obviously
On Mon, 26 Aug 2013, Xenia Ragiadakou wrote:
In usb_reset_and_verify_device(), hub_port_init() allocates a new bos
descriptor to hold the value read by the device. The new bos descriptor
has to be compared with the old one in order to figure out if device 's
firmware has changed in which case
Quoting Dan Williams d...@redhat.com:
On Sat, 2013-08-17 at 18:05 -0400, Peter Hyman wrote:
snip
Maybe this will move the ball. We'll see. Thank you.
Yes, I was given that document by Sierra a couple years ago. No, it
doesn't help, because it only covers basic CDMA/EVDO stuff and does not
On Mon, 26 Aug 2013, Sarah Sharp wrote:
One last thought on this note: We know Windows doesn't have high-res
timers, and Arjan says asking for a 10 ms delay will produce a delay
around 17 ms. Since Linux is busy waiting, we may be communicating with
the device sooner than Windows does.
Clemens and everyone else:
Not having heard any responses to the patch posted last Wednesday, I
have updated and completed it. The version below is ready for testing.
Please let me know what you find.
It is not very different from the previous version. I got rid of the
nrpacks module
This patch does the real work. It fixes up ehci-hcd so that an URB
submitted by a completion handler will keep the isochronous stream
alive, even if the handler was delayed by running in a tasklet and the
queue has emptied out.
As I mentioned earlier, this is not a simple change.
Alan Stern
This patch merely interchanges the if and else branches of the big
if statement in iso_stream_schedule(), in order to simplify the
following patch.
Alan Stern
drivers/usb/host/ehci-sched.c | 92 +-
1 file changed, 47 insertions(+), 45 deletions(-)
This first proposed patch for solving the isochronous stream problem
adds a mechanism for seeing whether or not an URB is currently being
given back for a particular endpoint.
The mechanism isn't perfect. It doesn't use any synchronization, so
it's possible that a CPU may think a giveback is
Since ohci-hcd supports runtime PM, the .pm field in its pci_driver
structure should be protected by CONFIG_PM rather than
CONFIG_PM_SLEEP.
Without this change, OHCI controllers won't do runtime suspend if
system suspend or hibernation isn't enabled.
Signed-off-by: Alan Stern
On Fri, Aug 23, 2013 at 10:43:19AM -0400, Alan Stern wrote:
On Wed, 21 Aug 2013, Sarah Sharp wrote:
Background
--
The USB 2.0 specification, section 7.1.7.7, says that upon device remote
wakeup signaling, the first active hub (which is often the roothub) must
rebroadcast
On Thu, Aug 22, 2013 at 05:11:49AM +, Paul Zimmerman wrote:
From: Julius Werner
Sent: Wednesday, August 21, 2013 9:22 PM
You need the USB 2.0 spec errata from 2011-11 that describes the changes
made for BESL as well. It's in the USB2-LPM-Errata-final.pdf and
From: Sarah Sharp [mailto:sarah.a.sh...@linux.intel.com]
Sent: Monday, August 26, 2013 12:14 PM
On Thu, Aug 22, 2013 at 05:11:49AM +, Paul Zimmerman wrote:
From: Julius Werner
Sent: Wednesday, August 21, 2013 9:22 PM
You need the USB 2.0 spec errata from 2011-11 that
From: Paul Zimmerman
Sent: Monday, August 26, 2013 12:38 PM
...
So it may be safer to say that the feature is present starting with 2.50a.
In 2.51a it has been well-tested in simulation. In actual hardware, it
That should have said:
In 2.50a it has been well-tested in simulation...
--
On Mon, 26 Aug 2013, Sarah Sharp wrote:
By the way, I just noticed your Google+ posting about this. I think
you (and perhaps the engineers you spoke with) may have misunderstood
what Table 7-14 means when it lists 10 ms as the _minimum_ value for
TRSMRCY.
This delay value is a
This patch replaces USB_MAXINTERFACES with config-desc.bNumInterface in
the termination condition for the loop that updates the LPM timeout of the
endpoints on the cofiguration's interfaces, in xhci_calculate_lpm_timeout(),
to avoid unnecessary loop cycles since most configurations come with 1-2
This patch removes the to_pci_dev() conversion performed to generic struct
device since it is not actually useful (the pointer to the generic device
can be used directly rather through a conversion to pci_dev) and it is pci
bus specific.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
---
From: Enrico Mioso mrkiko...@gmail.com
Date: Fri, 23 Aug 2013 09:56:29 +0200
+ if ((on atomic_add_return(1, drvstate-pmcount) == 1) || (!on
atomic_dec_and_test(drvstate-pmcount))) {
These line significantly exceeds 80 columns.
+ subdriver =
This patch removes the unneccessary check 'if (stream_info)' because
there is already a check few lines above which ensures that stream_info
is not NULL.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
---
drivers/usb/host/xhci-mem.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
On Mon, 2013-08-26 at 16:31 -0400, David Miller wrote:
From: Enrico Mioso mrkiko...@gmail.com
[]
+ int ret = 0;
+ struct usbnet *usbnet_dev = usb_get_intfdata(intf);
+ struct huawei_cdc_ncm_state *drvstate = (void *)usbnet_dev-data;
+ struct cdc_ncm_ctx *ctx =
It seems I had trouble parsing the maze of instructions I've been
navigating. I suppose I should have emailed the driver maintainer instead.
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at
From: Joe Perches j...@perches.com
Date: Mon, 26 Aug 2013 13:45:13 -0700
I think the premise of local variable
declaration by line length is flawed.
I disagree.
It can't work when local variables are
dependent on initialization order as
above.
Move the initialization below the
On Mon, 26 Aug 2013, Adam Borowski wrote:
Hi!
I'm afraid that your kernel patch 84ebc10294a3d7be4c66f51070b7aedbaa24de9b
(USB: remove CONFIG_USB_SUSPEND option) causes lockups on resume from
suspend on at least some machines.
On kernels from this patch forward up to some point in
On Mon, 2013-08-26 at 16:58 -0400, David Miller wrote:
From: Joe Perches j...@perches.com
Date: Mon, 26 Aug 2013 13:45:13 -0700
I think the premise of local variable
declaration by line length is flawed.
I disagree.
It can't work when local variables are
dependent on
From: Joe Perches j...@perches.com
Date: Mon, 26 Aug 2013 14:05:55 -0700
On Mon, 2013-08-26 at 16:58 -0400, David Miller wrote:
From: Joe Perches j...@perches.com
Date: Mon, 26 Aug 2013 13:45:13 -0700
I think the premise of local variable
declaration by line length is flawed.
I
I think the link in my first email was wrong
here is the correct link
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1210858
I did run 2.6.33 and 2.6.39 in which the 2 usb ports did appear to
work, but the Xserver did not work correctly so I only had command
line.
On Sat, Aug 24, 2013 at
On Mon, 2013-08-26 at 17:09 -0400, David Miller wrote:
From: Joe Perches j...@perches.com
[]
Don't try to over-simplify things and act as if they are black
and white when they aren't.
It wasn't me simplifying.
I commented on your request to:
order local function variable declarations by line
On Mon, Aug 26, 2013 at 10:45:30AM -0700, Sarah Sharp wrote:
On Thu, Aug 22, 2013 at 02:55:07PM -0700, Greg KH wrote:
On Thu, Aug 22, 2013 at 02:49:07PM -0700, Sarah Sharp wrote:
On Thu, Aug 22, 2013 at 10:42:49AM -0400, Alan Stern wrote:
On Wed, 21 Aug 2013, Sarah Sharp wrote:
On Mon, Aug 26, 2013 at 03:07:25PM -0700, Greg KH wrote:
On Mon, Aug 26, 2013 at 10:45:30AM -0700, Sarah Sharp wrote:
One last thought on this note: We know Windows doesn't have high-res
timers, and Arjan says asking for a 10 ms delay will produce a delay
around 17 ms. Since Linux is
On Mon, Aug 26, 2013 at 11:29 PM, Alan Stern st...@rowland.harvard.edu wrote:
On Mon, 26 Aug 2013, Ming Lei wrote:
On Sat, 24 Aug 2013, Ming Lei wrote:
But the current interrupt from EHCI isn't be acked(USBSTS isn't cleared),
so EHCI HW don't know the irq has been handled, then it is
When a device signals remote wakeup on a roothub, and the suspend change
bit is set, the host controller driver must not give control back to the
USB core until the port goes back into the active state.
EHCI accomplishes this by waiting in the get port status function until
the PORT_RESUME bit is
The following changes since commit d8dfad3876e438b759da3c833d62fb8b2267:
Linux 3.11-rc7 (2013-08-25 17:43:22 -0700)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/
tags/usb-3.11-rc8
for you to fetch changes up to
On Mon, 26 Aug 2013, Sarah Sharp wrote:
I double checked with the Intel Windows devs, and they say that Arjan is
mistaken, and they'll get around 11 ms, just like we do.
They say:
The EHCI driver stack applies the 10 ms starting at the point that it
sees C_PORT_SUSPEND asserted for the
On Mon, Aug 26, 2013 at 06:24:48PM +0200, Hector Palacios wrote:
Dear Peter,
On 08/12/2013 03:22 AM, Peter Chen wrote:
This patchset adds tested otg id switch function and vbus connect
and disconnect detection for chipidea driver. And fix kinds of
bugs found at chipidea drivers after
68 matches
Mail list logo
