[PATCH] staging: wilc1000: move initialization of the config values

2016-04-07 Thread Alison Schofield
Move the initialization of the config values so that an uninit'd mutex is not exposed and to simplify the initialization process. The code was allocating a structure with a lock, initializing and taking the lock, setting some values, and then releasing the lock. If no other thread can get it,

Re: [PATCH 1/2] mac80211: implement fair queuing per txq

2016-04-07 Thread Avery Pennarun
On Fri, Mar 25, 2016 at 5:27 AM, Michal Kazior wrote: > mac80211's software queues were designed to work > very closely with device tx queues. They are > required to make use of 802.11 packet aggregation > easily and efficiently. > > However the logic imposed a per-AC

Re: [PATCH MOREWORK 14/19] rtl818x_pci: Fix a memory leak in rtl8180_init_rx_ring

2016-04-07 Thread Julian Calaby
Hi all, Could someone please review this? On Fri, Mar 18, 2016 at 1:27 PM, Julian Calaby wrote: > From: Jia-Ju Bai > > When dev_alloc_skb or pci_dma_mapping_error in rtl8180_init_rx_ring fails, > the memory allocated by pci_zalloc_consistent is

Re: [PATCH 00/19] Pending Cleanup patches for 4.7

2016-04-07 Thread Julian Calaby
Hi Kalle, On Fri, Apr 8, 2016 at 10:56 AM, Julian Calaby wrote: > Hi Kalle, > > On Fri, Apr 8, 2016 at 2:37 AM, Kalle Valo wrote: >> Kalle Valo writes: >> >>> Julian Calaby writes: >>> This is a

我的交友信息在

2016-04-07 Thread 我的交友信息在
你的老朋友邀你来Q群:343257759 抢红包 抢秒杀 抢vip 什么都要抢。太刺激了。不靠手气只拼手速

Re: [PATCH] Revert regression in ath9k on AR9281

2016-04-07 Thread Julian Calaby
Hi, On Fri, Apr 8, 2016 at 8:24 AM, wrote: > Hello, the following commit introduced what looks like a regression on > AR9281 and supposedly other wireless chipsets using the AR9002 part of the > ath9k driver. > > After this commit the network interface's "Bit Rate" as

Kernel crash when ath10k 10.4.3 firmware crashes in TCP download test.

2016-04-07 Thread Ben Greear
We see this kernel splat when using 'flent' TCP download test on a QCA99XX wave-2 NIC. Seems easy to reproduce at least on our test rig. Significantly patched ath10k, should be near linux.ath plus a bit. 4.4.6+ kernel. Probably I can make this go away by fixing the firmware crash (which I

[PATCH] Revert regression in ath9k on AR9281

2016-04-07 Thread lkml2017
Hello, the following commit introduced what looks like a regression on AR9281 and supposedly other wireless chipsets using the AR9002 part of the ath9k driver. After this commit the network interface's "Bit Rate" as shown in "iwconfig" drops from the usual 65Mbps in N mode to 11Mbps also in N

Re: RFC: Handling DL only traffic when already in Powersave

2016-04-07 Thread Johannes Berg
On Thu, 2016-04-07 at 18:31 +0530, Krishna Chaitanya wrote: > Hi, > > When using HW_PS and running Downlink only traffic like UDP-RX, > mac80211 has the mechanism to not to enter power-save (postpone the > dynamic ps timer). > > But if we are already in power-save it continues to stay in PS >

[PATCH 07/18] rtl8xxxu: Pick PHY init table based on chip version first

2016-04-07 Thread Jes . Sorensen
From: Jes Sorensen Pick PHY init table based on device before distinguishing between 1T/2T/high PA tables. The latter is only currently used for 8188cu/8192cu/8188ru. Signed-off-by: Jes Sorensen ---

[PATCH 05/18] rtl8xxxu: Add 8192eu AGC tables

2016-04-07 Thread Jes . Sorensen
From: Jes Sorensen A device specific AGC table is required for the 8192eu as well. Signed-off-by: Jes Sorensen --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 147 ++- 1 file changed, 146 insertions(+), 1 deletion(-)

[PATCH 12/18] rtl8xxxu: Set correct interrupt masking registers on 8192eu

2016-04-07 Thread Jes . Sorensen
From: Jes Sorensen Set HIMR[01] on 8192eu instead of HISR/HIMR. It's not obvious this really matters for USB devices, but this matches the register writes performed by the vendor driver. Signed-off-by: Jes Sorensen ---

[PATCH 09/18] rtl8xxxu: Handle BB init for 8192eu

2016-04-07 Thread Jes . Sorensen
From: Jes Sorensen The 8192eu does not use REG_AFE_PLL_CTRL in it's BB init sequence, so provide device specific handling. Signed-off-by: Jes Sorensen --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 5 + 1 file changed, 5

[PATCH 13/18] rtl8xxxu: Set REG_USB_HRPWM for 8192eu

2016-04-07 Thread Jes . Sorensen
From: Jes Sorensen The vendor driver set register 0xfe58 REG_USB_HWPWM in it's init sequence for 8192eu. Do the same here. Signed-off-by: Jes Sorensen --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 2 ++

[PATCH 06/18] rtl8xxxu: Add 8192eu PHY init table

2016-04-07 Thread Jes . Sorensen
From: Jes Sorensen The 8192eu also requires it's own PHY init table. Signed-off-by: Jes Sorensen --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 140 +++ 1 file changed, 140 insertions(+) diff --git

[PATCH 08/18] rtl8xxxu: Correctly parse 8192eu efuse

2016-04-07 Thread Jes . Sorensen
From: Jes Sorensen The 8192eu efuse only has power data for path A and B. It follows the same layout as 8723bu. Signed-off-by: Jes Sorensen --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 40

[PATCH 11/18] rtl8xxxu: Handle XTAL value setting on 8192eu

2016-04-07 Thread Jes . Sorensen
From: Jes Sorensen Set REG_AFE_XTAL_CTRL on 8192eu to the vendor driver value, and do not skip setting REG_MAX_AGGR_NUM on 8192eu. Signed-off-by: Jes Sorensen --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 5 - 1 file changed, 4

[PATCH 14/18] rtl8xxxu: Fix LDPC RX hang issue on 8192eu

2016-04-07 Thread Jes . Sorensen
From: Jes Sorensen Implement workaround for LDPC RX hands on 8192eu. This was inspired by workaround found in the 8192eu vendor driver. Signed-off-by: Jes Sorensen --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 10 ++ 1 file

[PATCH 18/18] rtl8xxxu: Adjust AFE crystal value on 8192eu

2016-04-07 Thread Jes . Sorensen
From: Jes Sorensen Adjust AFE before enabling PLL on 8192eu, probably also needed for 8723bu. Signed-off-by: Jes Sorensen --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 39 ++

[PATCH 16/18] rtl8xxxu: Use proper register name for REG_PAD_CTRL1

2016-04-07 Thread Jes . Sorensen
From: Jes Sorensen Fixup another case where the hard coded register value was used instead of the name. Signed-off-by: Jes Sorensen --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[PATCH 17/18] rtl8xxxu: Implement IQK calibration for 8192eu

2016-04-07 Thread Jes . Sorensen
From: Jes Sorensen 8192eu has it's own IQK calibration procedure, and notably uses undocumented RF register 0x56 in the process. Signed-off-by: Jes Sorensen --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 608 -

[PATCH 00/18] rtl8xxxu: Additional code to support rtl8192eu

2016-04-07 Thread Jes . Sorensen
From: Jes Sorensen Hi, Here is another set of patches adding more code to handle the rtl8192eu. It is relative to wireless-drivers-next as of 2016-04-07. This isn't the complete set to support the 8192eu, I am breaking it down to make the patch volume easier to manage.

[PATCH 02/18] rtl8xxxu: Do not mess with AFE_XTAL_CTRL on 8192eu

2016-04-07 Thread Jes . Sorensen
From: Jes Sorensen To match the vendor driver, do not mess with AFE_XTAL_CTRL on 8192eu. Signed-off-by: Jes Sorensen --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 15/18] rtl8xxxu: Implement 8192eu device specific quirks

2016-04-07 Thread Jes . Sorensen
From: Jes Sorensen Set REG_QUEUE_CTRL and REG_ACLK_MON for 8192eu. Signed-off-by: Jes Sorensen --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 14 ++ drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_regs.h | 1 + 2 files

[PATCH 10/18] rtl8xxxu: Provide special handling when writing RF regs on 8192eu

2016-04-07 Thread Jes . Sorensen
From: Jes Sorensen The 8192eu requires clearing/restoring bit 17 in REG_FPGA0_POWER_SAVE before/after writing RF registers. Signed-off-by: Jes Sorensen --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 14 +- 1 file changed,

[PATCH 03/18] rtl8xxxu: Set TX page boundaries for 8192eu

2016-04-07 Thread Jes . Sorensen
From: Jes Sorensen The 8192eu also has it's own TRXFF boundary value to set. Signed-off-by: Jes Sorensen --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 7 ++- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h | 1 + 2 files changed,

[PATCH 01/18] rtl8xxxu: Add MAC init table for 8192eu

2016-04-07 Thread Jes . Sorensen
From: Jes Sorensen The 8192eu requires a different MAC init table. Add the missing table and specify the table to use in the fileops structure. Signed-off-by: Jes Sorensen --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 45

[PATCH 04/18] rtl8xxxu: Add radio init tables for 8192eu

2016-04-07 Thread Jes . Sorensen
From: Jes Sorensen Add the required radio init tables for 8192eu devices. Signed-off-by: Jes Sorensen --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 154 +++ 1 file changed, 154 insertions(+) diff --git

Re: [PATCH v2 1/2] mt76: add common code shared between multiple chipsets

2016-04-07 Thread Kalle Valo
Felix Fietkau writes: > This will be used by drivers for MT76x2e, MT7603e and MT7628 > > Signed-off-by: Felix Fietkau I applied these to the pending branch in wireless-drivers-next so that kbuild can do it's magic. -- Kalle Valo -- To unsubscribe from this

Re: [01/10] rtl8xxxu: Change name of struct tx_desc to be more decriptive

2016-04-07 Thread Kalle Valo
> From: Jes Sorensen > > There are two major types of TX descriptor formats for the RTL parts, > the old 32 byte descriptor, and the newer 40 byte descriptor used by > the 8723bu, 8192eu, and 88xx series. > > Signed-off-by: Jes Sorensen

Re: [RESEND,1/7] mwifiex: add support for GTK rekey offload

2016-04-07 Thread Kalle Valo
> From: Ganapathi Bhat > > Added driver functionality to offload GTK rekey to firmware. When > AP sends new GTK, firmware will update it. > > Signed-off-by: Ganapathi Bhat > Signed-off-by: Amitkumar Karwar Thanks, 7 patches applied

Re: [RESEND] mwifiex: fix NULL pointer dereference error

2016-04-07 Thread Kalle Valo
> In mwifiex_enable_hs, we need to check if > priv->wdev.wiphy->wowlan_config is NULL before accessing its member. > This sometimes cause kernel panic when suspend/resume. > > Signed-off-by: Wei-Ning Huang Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To

Re: mwifiex: ie_list is an array, so no need to check if NULL

2016-04-07 Thread Kalle Valo
> From: Colin Ian King > > ap_ie->ie_list is an array of struct mwifiex_ie and can never > be null, so the null check on this array is redundant and can > be removed. > > Signed-off-by: Colin Ian King Thanks, applied to

Re: [01/19] ath9k: Remove unnecessary ?: operator

2016-04-07 Thread Kalle Valo
> From: Ivan Safonov > > "(thermometer < 0) ? 0 : (thermometer == X)" is equivalent to > "thermometer == X" for X >= 0. > > Signed-off-by: Ivan Safonov > [Updated commit message] > Signed-off-by: Julian Calaby Thanks, 16

Re: [PATCH 00/19] Pending Cleanup patches for 4.7

2016-04-07 Thread Kalle Valo
Kalle Valo writes: > Julian Calaby writes: > >> This is a set of all patches in patchwork which were pending when the 4.6 >> merge window opened that meet the following criteria: >> >> 1. They're sane >> 2. They're either obviously correct, I can

Re: [PATCH 1/7] wil6210: add function name to wil log macros

2016-04-07 Thread Joe Perches
On Thu, 2016-04-07 at 15:04 +, Haim, Maya wrote: > On 4/6/2016 10:19 AM, Joe Perches wrote: > > On Tue, 2016-04-05 at 14:24 +0300, Maya Erez wrote: > > > Add __func__ to all wil log macros for easier debugging. > > I think this is unnecessary and merely bloats code size. > > For all the _dbg

Re: [PATCH v2 1/3] ath10k: fix calibration init sequence of qca99x0

2016-04-07 Thread Valo, Kalle
Rajkumar Manoharan writes: > pre-calibration is meant for qca4019 which contains only caldata > whereas calibration file is used by ar9888 and qca99x0 that contains > both board data and caldata. So by definition both pre-cal-file and > cal-file can not coexist.

Re: [PATCH 1/7] wil6210: add function name to wil log macros

2016-04-07 Thread Kalle Valo
"Haim, Maya" writes: > On 4/6/2016 10:19 AM, Joe Perches wrote: >> On Tue, 2016-04-05 at 14:24 +0300, Maya Erez wrote: >>> Add __func__ to all wil log macros for easier debugging. >> I think this is unnecessary and merely bloats code size. >> For all the _dbg calls,

RE: [PATCH 1/7] wil6210: add function name to wil log macros

2016-04-07 Thread Haim, Maya
On 4/6/2016 10:19 AM, Joe Perches wrote: > On Tue, 2016-04-05 at 14:24 +0300, Maya Erez wrote: >> Add __func__ to all wil log macros for easier debugging. > I think this is unnecessary and merely bloats code size. > For all the _dbg calls, dynamic debug can add function names if > desired. > > If

Re: [PATCH 525/525] Staging: Wilc1000: Fixed coding style ether_addr_copy

2016-04-07 Thread Greg KH
On Thu, Apr 07, 2016 at 03:07:15PM +0530, Shyam Saini wrote: > Fixed following warning detected by checkpatch.pl: > warning: Prefer ether_addr_copy() over memcpy() if the Ethernet addressesare > __aligned(2) > > Signed-off-by: Shyam Saini > --- >

Re: [PATCH] wlcore: spi: add wl18xx support

2016-04-07 Thread Kalle Valo
"Reizer, Eyal" writes: >> > static const struct of_device_id wlcore_spi_of_match_table[] = { >> > - { .compatible = "ti,wl1271" }, >> > + { .compatible = "ti,wl1271", .data = _data}, >> > + { .compatible = "ti,wl1273", .data = _data}, >> > + { .compatible = "ti,wl1281", .data

[PATCH v4] iw: Add support for NL80211_STA_INFO_RX_DURATION netlink attribute

2016-04-07 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan Add support for new netlink attribute 'NL80211_STA_INFO_RX_DURATION'. 'NL80211_STA_INFO_RX_DURATION' accounts for aggregate PPDU duration in microseconds for all the frames from a peer. Drivers can fill 'rx_duration' field and set the

[PATCH v4] cfg80211/nl80211: Add support for NL80211_STA_INFO_RX_DURATION

2016-04-07 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan Add support for new netlink attribute 'NL80211_STA_INFO_RX_DURATION'. 'NL80211_STA_INFO_RX_DURATION' accounts for aggregate PPDU duration in microseconds for all the frames from a peer. Drivers can fill 'rx_duration' field and set the

mwifiex: kernel WARN_ON during system suspend

2016-04-07 Thread Vishal Thanki
Hi All, I noticed that sometime I see the kernel trace while system enters into suspend. The trace log is attached with this email. >From the kernel trace it appears that mwifiex_cancel_all_pending_cmd() function tries to cancel the current command by invoking mwifiex_complete_cmd(). Just before

RFC: Handling DL only traffic when already in Powersave

2016-04-07 Thread Krishna Chaitanya
Hi, When using HW_PS and running Downlink only traffic like UDP-RX, mac80211 has the mechanism to not to enter power-save (postpone the dynamic ps timer). But if we are already in power-save it continues to stay in PS and retrieves the frames, for large traffic this is not acceptable. The

RE: [PATCH] wlcore: spi: add wl18xx support

2016-04-07 Thread Reizer, Eyal
> -Original Message- > From: Kalle Valo [mailto:kv...@codeaurora.org] > Sent: Thursday, April 07, 2016 3:25 PM > To: Eyal Reizer > Cc: linux-wireless@vger.kernel.org; net...@vger.kernel.org; linux- > ker...@vger.kernel.org; Reizer, Eyal; devicet...@vger.kernel.org > Subject: Re: [PATCH]

nl80211 set SSID

2016-04-07 Thread Abhishek
I was wondering how do I go about setting up SSID on a AP using nl80211. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] wlcore: spi: add wl18xx support

2016-04-07 Thread Kalle Valo
Eyal Reizer writes: > Add support for using with both wl12xx and wl18xx. > > - all wilink family needs special init command for entering wspi mode. > extra clock cycles should be sent after the spi init command while the > cs pin is high. > - switch to controling the cs

Re: [PATCH] wlcore: spi: add wl18xx support

2016-04-07 Thread Kalle Valo
"Reizer, Eyal" writes: > Ping on this patch > >> -Original Message- >> From: Eyal Reizer [mailto:eyalrei...@gmail.com] >> Sent: Wednesday, March 30, 2016 4:07 PM >> To: kv...@codeaurora.org; linux-wireless@vger.kernel.org; >> net...@vger.kernel.org;

Re: [PATCH 00/19] Pending Cleanup patches for 4.7

2016-04-07 Thread Kalle Valo
Julian Calaby writes: > This is a set of all patches in patchwork which were pending when the 4.6 > merge window opened that meet the following criteria: > > 1. They're sane > 2. They're either obviously correct, I can review them, or they've been >reviewed or ACK'd

Re: [PATCH] PCI: Add Broadcom 4331 reset quirk to prevent IRQ storm

2016-04-07 Thread Andrew Worsley
Sorry but testing the patch shows no difference. I have just compiled debian jessie kernel 3.16.7-ckt25 and booted it and hibernated it twice, then did the same with your patch applied. There appeared to be no difference On first boot I didn't get the nobody card disabling problem but after

Re: [PATCH 525/525] Staging: Wilc1000: Fixed coding style ether_addr_copy

2016-04-07 Thread Joe Perches
On Thu, 2016-04-07 at 15:07 +0530, Shyam Saini wrote: > Fixed following warning detected by checkpatch.pl: > warning: Prefer ether_addr_copy() over memcpy() if the Ethernet addressesare > __aligned(2) Please don't just do checkpatch cleanups but strive to make the code more intelligible for

[PATCH 525/525] Staging: Wilc1000: Fixed coding style ether_addr_copy

2016-04-07 Thread Shyam Saini
Fixed following warning detected by checkpatch.pl: warning: Prefer ether_addr_copy() over memcpy() if the Ethernet addressesare __aligned(2) Signed-off-by: Shyam Saini --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 25 +++ 1 file changed, 12

Re: [PATCH] cfg80211: Improve Connect/Associate command documentation

2016-04-07 Thread Johannes Berg
On Wed, 2016-04-06 at 17:38 +0300, Jouni Malinen wrote: > The roaming cases for the Connect command were not fully covered and > neither Connect nor Associate command uses of the prev_bssid > parameter > were very clear. Add details to describe how the prev_bssid argument > is > supposed to be

Re: [PATCHv2 1/2] mac80211: implement fair queuing per txq

2016-04-07 Thread Johannes Berg
On Wed, 2016-04-06 at 10:39 -0700, Dave Taht wrote: > > > The hope had been the original codel.h would have been reusable, > > > which is not the case at present. > > So what's the strategy for making it happen? > Strategy? to meander towards a result that gives low latency to all > stations, no

Re: [PATCH 2/2] Check protocol number in nl80211 netlink socket release notification handler.

2016-04-07 Thread Johannes Berg
On Wed, 2016-04-06 at 17:23 +0300, Dmitry Ivanov wrote: > This patch corrects the problem where non-privileged user can create > netlink socket with the same port_id as used by hostapd but different > protocol number. Upon close() or process termination, a notification > is > sent  to nl80211

[PATCH] netlink: don't send NETLINK_URELEASE for unbound sockets

2016-04-07 Thread Johannes Berg
From: Dmitry Ivanov All existing users of NETLINK_URELEASE use it to clean up resources that were previously allocated to a socket via some command. As a result, no users require getting this notification for unbound sockets. Sending it for unbound sockets, however,

Re: [PATCH 1/2] Do not send netlink socket release notification when socket is not bound

2016-04-07 Thread Johannes Berg
On Wed, 2016-04-06 at 17:22 +0300, Dmitry Ivanov wrote: > This patch corrects the problem where non-privileged user may create > netlink socket with port_id equal to port_id used by hostapd to > create > virtual wireless network interfaces. Call to bind() will fail for > such > socket, but release

[PATCH] ath10k: fix rx_channel during hw reconfigure

2016-04-07 Thread Rajkumar Manoharan
Upon firmware assert, restart work will be triggered so that mac80211 will reconfigure the driver. An issue is reported that after restart work, survey dump data do not contain in-use (SURVEY_INFO_IN_USE) info for operating channel. During reconfigure, since mac80211 already has valid channel

[PATCH v2] ath10k: remove MSI range support

2016-04-07 Thread Rajkumar Manoharan
MSI-X is never well-tested, might contain bugs and generally isn't really all that useful to maintain. Also ath10k is mainly used with shared/singly-MSI interrupt systems. Hence removing MSI range support. This change will be useful for further cleanup in copy engine lock and to add NAPI support.

[PATCH v2 3/3] ath10k: fix unconditional num_mpdus_ready subtraction

2016-04-07 Thread Rajkumar Manoharan
Decrement num_mpdus_ready only when rx amsdu is processed successfully. Not doing so, will result in leak and impact stabilty under low memory cases. Also commit 3128b3d8a2b9 ("ath10k: speedup htt rx descriptor processing for rx_ind") missed to removed unused skb list rx_q. Fixes: 3128b3d8a2b9

[PATCH v2 2/3] ath10k: remove unnecessary warning for probe response drops

2016-04-07 Thread Rajkumar Manoharan
qca99x0 and qca4019 solutions limit probe responses transmissions. Logging warning message for each probe response drop is flooding kernel log unnecessary with " failed to increase tx mgmt pending count: -16, dropping". Hence reducing log level to debug. Reported-by: Sebastian Gottschall

[PATCH v2 1/3] ath10k: fix calibration init sequence of qca99x0

2016-04-07 Thread Rajkumar Manoharan
pre-calibration is meant for qca4019 which contains only caldata whereas calibration file is used by ar9888 and qca99x0 that contains both board data and caldata. So by definition both pre-cal-file and cal-file can not coexist. Keeping them in shared memory (union), is breaking boot sequence of